Re: [Qemu-devel] [PATCH] net: Include iov.h in checksum.h

2014-02-06 Thread Alexander Graf
> Am 07.02.2014 um 08:05 schrieb Michael Tokarev : > > 06.02.2014 19:30, Alexander Graf wrote: >> The checksum calculation header exports a function that refers to struct >> iov which is defined in iov.h. Include the header so that the compiler >> knows what this struct is about. > > Alternativ

Re: [Qemu-devel] [PATCH 1/4] qemu-io: New option "-a" to aio_read and aio_write

2014-02-06 Thread Fam Zheng
On Sun, 02/02 01:20, Paolo Bonzini wrote: > Il 01/02/2014 15:31, Fam Zheng ha scritto: > >>Why can't it be enabled unconditionally? > >> > > > >So the default behavior is unchanged. > > For the stand-alone executable there is no difference, is there anything > that breaks for the monitor if you al

Re: [Qemu-devel] migration question: disk images on nfs server

2014-02-06 Thread Orit Wasserman
On 02/07/2014 06:35 AM, Alexey Kardashevskiy wrote: Hi! I have yet another problem with migration. Or NFS. There is one NFS server and 2 test POWER8 machines. There is a shared NFS folder on the server, mounted to both test hosts. There is an qcow2 image (abc.qcow2) in that shared folder. We s

Re: [Qemu-devel] [PATCH v2 19/35] target-arm: A64: Make cache ID registers visible to AArch64

2014-02-06 Thread Hu Tao
On Fri, Jan 31, 2014 at 03:45:27PM +, Peter Maydell wrote: > Make the cache ID system registers (CLIDR, CCSELR, CCSIDR, CTR) s/CCSELR/CSSELR/ > visible to AArch64. These are mostly simple 64-bit extensions of the > existing 32 bit system registers and so can share reginfo definitions. Accord

Re: [Qemu-devel] [PATCH 01/10] tests/qapi-schema: Actually check successful QMP command response

2014-02-06 Thread Markus Armbruster
Eric Blake writes: > On 02/06/2014 07:29 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> tests/test-qmp-commands.c | 44 >> 1 file changed, 36 insertions(+), 8 deletions(-) >> >> diff --git a/tests/test-qmp-commands.c b/te

Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors

2014-02-06 Thread Markus Armbruster
Eric Blake writes: > On 02/06/2014 07:30 AM, Markus Armbruster wrote: >> Visitors get passed a pointer to the visited object. The generated >> visitors try to cope with this pointer being null in some places, for >> instance like this: >> >> visit_start_optional(m, obj ? &(*obj)->has_name :

Re: [Qemu-devel] [PATCH] scripts: Add qom-tree script as modern equivalent of info qtree

2014-02-06 Thread Paolo Bonzini
Il 05/02/2014 19:01, Andreas Färber ha scritto: Am 05.02.2014 18:55, schrieb Paolo Bonzini: Il 05/02/2014 18:51, Andreas Färber ha scritto: So, even though I think this script is a very welcome addition, I don't think it helps settling the question of what to do with "info qtree". IMO there's

Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-02-06 Thread Paolo Bonzini
Il 07/02/2014 01:06, Peter Maydell ha scritto: Why do we need OS specific code to do this when the code in vl.c for getting the executable path to use as a base for finding bios blobs works fine without OS specific code? That's because right now module_call_init is not receiving an argv[0] to

Re: [Qemu-devel] 128Kb bios size and older machines?

2014-02-06 Thread Michael Tokarev
07.02.2014 03:56, Paolo Bonzini wrote: > Il 06/02/2014 14:15, Ian Campbell ha scritto: >> Nothing is missing in seabios. >> >> The above patch is a fix to Xen not SeaBIOS, which lets it work >> correctly regardless of the size of the seabios binary. >> >> There is no need to do anything other than

Re: [Qemu-devel] [PATCH] net: Include iov.h in checksum.h

2014-02-06 Thread Michael Tokarev
06.02.2014 19:30, Alexander Graf wrote: > The checksum calculation header exports a function that refers to struct > iov which is defined in iov.h. Include the header so that the compiler > knows what this struct is about. Alternatively (and I sometimes prefer it this way), one can just declare `s

Re: [Qemu-devel] [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-06 Thread Fam Zheng
On Thu, 02/06 13:27, Stefan Hajnoczi wrote: > On Tue, Feb 4, 2014 at 1:38 PM, Michal Privoznik wrote: > > On 03.02.2014 08:45, Stefan Hajnoczi wrote: > >> > >> KVM & libvirt: you are welcome to join the QEMU umbrella organization > >> like last year. > >> > > > > I've updated wiki with a libvirt i

[Qemu-devel] http://www.xrefs.info: qemu source code cross reference

2014-02-06 Thread xrefs.info Admin
hello, I made http://www.xrefs.info available to open source community in the hope of making open source developers more productive. The site hosts many open source code projects' cross references based on OpenGrok, which is a very fast cross reference tool, and easy to use. qemu is a very popula

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-06 Thread Alexey Kardashevskiy
On 02/07/2014 10:49 AM, Paolo Bonzini wrote: > Il 06/02/2014 04:10, Alexey Kardashevskiy ha scritto: Ok, I thought Alexey was saying we are not redirtying that handful of pages. >> >> Every iteration we read the dirty map from KVM and send all dirty pages >> across the stream. > > But w

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-06 Thread Alexey Kardashevskiy
On 02/06/2014 10:24 PM, Dr. David Alan Gilbert wrote: > * Alexey Kardashevskiy (a...@ozlabs.ru) wrote: >> On 02/06/2014 03:45 AM, Paolo Bonzini wrote: >>> Il 05/02/2014 17:42, Dr. David Alan Gilbert ha scritto: Because: * the code is still running and keeps redirtying a small handful

[Qemu-devel] migration question: disk images on nfs server

2014-02-06 Thread Alexey Kardashevskiy
Hi! I have yet another problem with migration. Or NFS. There is one NFS server and 2 test POWER8 machines. There is a shared NFS folder on the server, mounted to both test hosts. There is an qcow2 image (abc.qcow2) in that shared folder. We start a guest with this abc.qcow2 on the test machine #

Re: [Qemu-devel] [RFC PATCH v4 4/4] qcow2: Add full image preallocation option

2014-02-06 Thread Hu Tao
On Mon, Jan 20, 2014 at 10:16:23AM +0800, Hu Tao wrote: > Stefan, > > On Fri, Jan 17, 2014 at 04:48:16PM +0800, Stefan Hajnoczi wrote: > > On Fri, Dec 27, 2013 at 11:05:54AM +0800, Hu Tao wrote: > > > > This approach seems okay but the calculation isn't quite right yet. > > > > On Windows an er

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-06 Thread Bharata B Rao
On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote: > Le Tuesday 04 Feb 2014 à 14:26:58 (-0500), Jeff Cody a écrit : > > > > +static void qemu_gluster_parse_flags(int bdrv_flags, int *open_flags) > > +{ > > +assert(open_flags != NULL); > > + > > +*open_flags |= O_BINARY; > > + >

Re: [Qemu-devel] [PATCH 02/10] tests/qapi-schema: Cover optional command arguments

2014-02-06 Thread Eric Blake
On 02/06/2014 07:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/qapi-schema/qapi-schema-test.json | 4 +++- > tests/qapi-schema/qapi-schema-test.out | 2 +- > tests/test-qmp-commands.c | 8 +--- > 3 files changed, 9 insertions(+), 5 deletions(-

Re: [Qemu-devel] [PATCH 07/10] tests/qapi-schema: Cover flat union types

2014-02-06 Thread Eric Blake
On 02/06/2014 07:29 AM, Markus Armbruster wrote: > The test demonstrates a generator bug: the generated struct > UserDefFlatUnion doesn't include members for the indirect base > UserDefZero. Good catch. > > Signed-off-by: Markus Armbruster > --- > tests/qapi-schema/qapi-schema-test.json | 7 +

Re: [Qemu-devel] [PATCH 01/10] tests/qapi-schema: Actually check successful QMP command response

2014-02-06 Thread Eric Blake
On 02/06/2014 07:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/test-qmp-commands.c | 44 > 1 file changed, 36 insertions(+), 8 deletions(-) > > diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c > ind

Re: [Qemu-devel] [PATCH 04/10] tests/qapi-schema: Cover anonymous union types

2014-02-06 Thread Eric Blake
On 02/06/2014 07:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/qapi-schema/qapi-schema-test.json | 4 > tests/qapi-schema/qapi-schema-test.out | 6 +- > tests/test-qmp-input-strict.c | 32 > tests/test-qmp-i

Re: [Qemu-devel] [PATCH 06/10] tests/qapi-schema: Cover union types with base

2014-02-06 Thread Eric Blake
On 02/06/2014 07:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/qapi-schema/qapi-schema-test.json | 1 + > tests/qapi-schema/qapi-schema-test.out | 2 +- > tests/test-qmp-input-strict.c | 4 ++-- > tests/test-qmp-input-visitor.c | 3 ++- > tes

Re: [Qemu-devel] [PATCH 09/10] qapi: Drop unused code in qapi-commands.py

2014-02-06 Thread Eric Blake
On 02/06/2014 07:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 20 > 1 file changed, 20 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http

Re: [Qemu-devel] [PATCH 05/10] tests/qapi-schema: Cover complex types with base

2014-02-06 Thread Eric Blake
On 02/06/2014 07:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/qapi-schema/qapi-schema-test.json | 6 +- > tests/qapi-schema/qapi-schema-test.out | 6 -- > tests/test-qmp-commands.c | 15 ++- > tests/test-qmp-input-visitor.c

Re: [Qemu-devel] [PATCH 08/10] qapi: Drop nonsensical header guard in generated qapi-visit.c

2014-02-06 Thread Eric Blake
On 02/06/2014 07:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi-visit.py | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Eric Blake > > diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py > index 65f1a54..ff4239c 100644 > --- a/scripts/qap

Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors

2014-02-06 Thread Eric Blake
On 02/06/2014 07:30 AM, Markus Armbruster wrote: > Visitors get passed a pointer to the visited object. The generated > visitors try to cope with this pointer being null in some places, for > instance like this: > > visit_start_optional(m, obj ? &(*obj)->has_name : NULL, "name", &err); > > v

Re: [Qemu-devel] [PATCH 03/10] tests/qapi-schema: Cover simple argument types

2014-02-06 Thread Eric Blake
On 02/06/2014 07:29 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/qapi-schema/qapi-schema-test.json | 2 ++ > tests/qapi-schema/qapi-schema-test.out | 1 + > tests/test-qmp-commands.c | 16 > 3 files changed, 19 insertions(+) > R

Re: [Qemu-devel] Multi GPU passthrough via VFIO

2014-02-06 Thread Maik Broemme
Hi Alex, Alex Williamson wrote: > On Thu, 2014-02-06 at 01:25 +0100, Maik Broemme wrote: > > Hi Alex, > > > > Maik Broemme wrote: > > > > > > > Another minor issue is that the R9 290X is not reset during > > > > > > > shutdown of > > > > > > > VM (neither Linux nor Windows) but it can be trick

Re: [Qemu-devel] Qemu Bare metal Query

2014-02-06 Thread Stewart Smith
Mj Embd writes: > Is it possible to run Qemu bare metal , after u-boot like linux is > loaded from u-boot? > Like running qemu from u-boot bootm command? > > - Reset | Uboot | Qemu > > Usually qemu runs on host os, so there would be some dependencies, how > to find what all dependencies are there?

Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-02-06 Thread Peter Maydell
On 6 February 2014 23:38, Paolo Bonzini wrote: >> Looks like we're not getting the executable path >> correctly on MacOS for some reason. > > Indeed, there is no code for it. Can you try the patch below? > >> Also, mjt pointed out on IRC that we probably want to allow >> installing binary modules

Re: [Qemu-devel] [PULL 00/16] KVM changes for 2014-02-03

2014-02-06 Thread Peter Maydell
On 6 February 2014 23:41, Paolo Bonzini wrote: > Il 06/02/2014 12:12, Peter Maydell ha scritto: > >> On 3 February 2014 16:38, Paolo Bonzini wrote: >> > Anthony, Peter, >> > >> > the following changes since commit >> > 0169c511554cb0014a00290b0d3d26c31a49818f: >> > >> > Merge remote-tracking br

Re: [Qemu-devel] 128Kb bios size and older machines?

2014-02-06 Thread Paolo Bonzini
Il 06/02/2014 14:15, Ian Campbell ha scritto: Nothing is missing in seabios. The above patch is a fix to Xen not SeaBIOS, which lets it work correctly regardless of the size of the seabios binary. There is no need to do anything other than apply that fix to the Xen packages (perhaps by upgradin

Re: [Qemu-devel] 128Kb bios size and older machines?

2014-02-06 Thread Paolo Bonzini
Il 06/02/2014 15:48, Ian Campbell ha scritto: > > I'm not sure why the BIOS size is relevant to migration anyway, Xen > > doesn't load a new BIOS on the target host, the BIOS image is part of > > the migrated RAM. > > The memory layout is different with a larger bios as qemu makes the > virtual

[Qemu-devel] [Bug 1276847] Re: Build fails on latest MinGW

2014-02-06 Thread Corry Lazarowitz
I do understand dependencies :) I just didn't think it was necessary to list that all out. However, this clearly isn't a dependancy issue! (Unless you are saying I have to use autoconf 2.5 or something instead of the current 2.68). I grabbed glib, devel stuff, pkgconfig, etc. Its all setup. P

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-06 Thread Paolo Bonzini
Il 06/02/2014 04:10, Alexey Kardashevskiy ha scritto: >> > Ok, I thought Alexey was saying we are not redirtying that handful of >> > pages. > > Every iteration we read the dirty map from KVM and send all dirty pages > across the stream. But we never finish because qemu_savevm_state_pending is o

Re: [Qemu-devel] [PULL 00/16] KVM changes for 2014-02-03

2014-02-06 Thread Paolo Bonzini
Il 06/02/2014 12:12, Peter Maydell ha scritto: On 3 February 2014 16:38, Paolo Bonzini wrote: > Anthony, Peter, > > the following changes since commit 0169c511554cb0014a00290b0d3d26c31a49818f: > > Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2014-01-24 15:52:44 -0800) > > a

[Qemu-devel] [PATCH] memory: fix limiting of translation at a page boundary

2014-02-06 Thread Paolo Bonzini
Commit 360e607 (address_space_translate: do not cross page boundaries, 2014-01-30) broke MMIO accesses in cases where the section is shorter than the full register width. This can happen for example with the Bochs DISPI registers, which are 16 bits wide but have only a 1-byte long MemoryRegion (if

Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-02-06 Thread Paolo Bonzini
> Looks like we're not getting the executable path > correctly on MacOS for some reason. Indeed, there is no code for it. Can you try the patch below? > Also, mjt pointed out on IRC that we probably want to allow > installing binary modules into a path with the arch name in > it, to allow for mu

[Qemu-devel] [PATCH 4/4] monitor: Add object_add class argument completion.

2014-02-06 Thread Hani Benhabiles
--- monitor.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/monitor.c b/monitor.c index 4a2c1ae..397e1fe 100644 --- a/monitor.c +++ b/monitor.c @@ -56,6 +56,7 @@ #include "qapi/qmp/qjson.h" #include "qapi/qmp/json-streamer.h" #include "qapi/qmp/json-parser.h" +#in

[Qemu-devel] [PATCH 2/4] monitor: Add device_add device argument completion.

2014-02-06 Thread Hani Benhabiles
--- monitor.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/monitor.c b/monitor.c index f8c4cae..65410cb 100644 --- a/monitor.c +++ b/monitor.c @@ -4254,6 +4254,27 @@ static const char *next_arg_type(const char *typestr) return (p != NULL ? ++p : typestr); }

[Qemu-devel] [PATCH 3/4] monitor: Add object_del id argument completion.

2014-02-06 Thread Hani Benhabiles
--- monitor.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/monitor.c b/monitor.c index 65410cb..4a2c1ae 100644 --- a/monitor.c +++ b/monitor.c @@ -4294,6 +4294,27 @@ static void device_del_completion(ReadLineState *rs, BusState *bus, } } +static void object

[Qemu-devel] [PATCH 0/4] monitor: Add argument completion for multiple commands.

2014-02-06 Thread Hani Benhabiles
This patch series add argument completion to multiple human monitor console commands. For device_add and object_add, only the 1st argument is completed. Hani Benhabiles (4): monitor: Add device_del id argument completion. monitor: Add device_add device argument completion. monitor: Add obje

[Qemu-devel] [PATCH 1/4] monitor: Add device_del id argument completion.

2014-02-06 Thread Hani Benhabiles
--- monitor.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/monitor.c b/monitor.c index b1ea262..f8c4cae 100644 --- a/monitor.c +++ b/monitor.c @@ -4254,6 +4254,25 @@ static const char *next_arg_type(const char *typestr) return (p != NULL ? ++p : typestr); }

Re: [Qemu-devel] [Bug 1276879] Re: lots of dma command 10, 14 not supported

2014-02-06 Thread BALATON Zoltan
On Thu, 6 Feb 2014, tyler knosis wrote: p.s. I tried Bochs 2.6.2, and it is not stuck at the same place. Did qemu take the bochs bios and change anything regarding the IDE drives? With OPENSTEP 4.2 a similar irq hang is happening due to a bug in the i8259 model which is fixed by the one lin

[Qemu-devel] [Bug 1276847] Re: Build fails on latest MinGW

2014-02-06 Thread Stefan Weil
cygwin builds are not supported and don't work with the current code. A fresh pull of MinGW/MSYS is not sufficient. You will also need glib-2.0, maybe pdcurses, sdl or even gtk-2.0 and other additional software. You will also need pkconfig (part of the all-in-one installer for gtk-2.0). As I said

[Qemu-devel] [Bug 1276847] Re: Build fails on latest MinGW

2014-02-06 Thread Corry Lazarowitz
Ok, so I figured perhaps my initial attempts with cygwin were the issue, and perhaps that made it much worse than it should have been. So I moved the directory and decompressed the archive again, started with ./configure, but as you said (which I didn't see in the docs) I added --enable-debug. So

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-06 Thread Stefan Priebe
Hi, Am 06.02.2014 20:51, schrieb Dr. David Alan Gilbert: * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: some more things which happen during migration: php5.2[20258]: segfault at a0 ip 00740656 sp 7fff53b694a0 error 4 in php-cgi[40+6d7000] php5.2[20249]: segfault

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-06 Thread Dr. David Alan Gilbert
* Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: > some more things which happen during migration: > > php5.2[20258]: segfault at a0 ip 00740656 sp 7fff53b694a0 > error 4 in php-cgi[40+6d7000] > > php5.2[20249]: segfault at c ip 7f1fb8ecb2b8 sp 7fff642d9c20 >

Re: [Qemu-devel] Version 1.7.0 fails to boot Windows 98 SE on Windows host

2014-02-06 Thread Stefan Weil
-hda > win98-hdd.img > > Any suggestions on how I can troubleshoot this issue further? > > Regards, > Legorol You can try git bisect under MinGW. As your own 1.6.2 build works, but the 1.7.0 build fails, there will be a commit somewhere in the middle which makes things go bad. git bis

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-06 Thread Lluís Vilanova
Richard Henderson writes: > On 02/04/2014 12:33 PM, Lluís Vilanova wrote: >> Richard Henderson writes: >> >>> On 01/31/2014 08:09 AM, Lluís Vilanova wrote: Adds the base ability to specify which events in the "trace-events" file may be used to trace guest activity in the TCG code

Re: [Qemu-devel] [PATCH] xen_disk: fix io accounting

2014-02-06 Thread Andreas Färber
Am 06.02.2014 16:55, schrieb Olaf Hering: > bdrv_acct_done was called unconditional. But in case the ioreq has no > segments there is no matching bdrv_acct_start call. This could lead to > bogus accounting values. > > Found by code inspection. > > Signed-off-by: Olaf Hering > --- > hw/block/xen

Re: [Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2014-02-06 Thread Serge Hallyn
Quoting Manuel Baesler (685...@bugs.launchpad.net): > followup: > > my understanding is there are a bunch of usb interfaces: > > uhci is usb 1.0 > ehci is usb 2.0 > xhci is usb 3.0 > … > > -device piix3-usb-uhci will create an usb 1.0 interface. I guess usb 1.0 > is insufficent for modern usb de

[Qemu-devel] [Bug 1276879] Re: lots of dma command 10, 14 not supported

2014-02-06 Thread tyler knosis
p.s. I tried Bochs 2.6.2, and it is not stuck at the same place. Did qemu take the bochs bios and change anything regarding the IDE drives? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1276879 Ti

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-06 Thread Andreas Färber
Am 06.02.2014 17:16, schrieb Eduardo Habkost: > (CCing libvir-list again, as this is continuing a discussion about a > subject that interests libvirt developers, from another thread.) > > On Thu, Feb 06, 2014 at 04:51:17PM +0100, Andreas Färber wrote: >> Am 06.02.2014 16:19, schrieb Igor Mammedov:

[Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-06 Thread Eduardo Habkost
(CCing libvir-list again, as this is continuing a discussion about a subject that interests libvirt developers, from another thread.) On Thu, Feb 06, 2014 at 04:51:17PM +0100, Andreas Färber wrote: > Am 06.02.2014 16:19, schrieb Igor Mammedov: > > On Wed, 5 Feb 2014 17:52:16 +0100 > > Igor Mammedo

Re: [Qemu-devel] [SeaBIOS] WfW setup and DOS display.sys hanging

2014-02-06 Thread Kevin O'Connor
On Thu, Feb 06, 2014 at 09:17:21AM +0100, Gerd Hoffmann wrote: > Hi, > > > Sebastian, can you document the steps to reproduce the dosidle and > > display.sys failure? > > Placed a copy of a fresh ms-dos 6.2 install here (qcow2 hard disk > image): http://www.kraxel.org/download/ > > display.sys

[Qemu-devel] [PATCH v2] xen_disk: add discard support

2014-02-06 Thread Olaf Hering
Implement discard support for xen_disk. It makes use of the existing discard code in qemu. The discard support is enabled unconditionally. The tool stack may provide a property "discard-enable" in the backend node to optionally disable discard support. This is helpful in case the backing file was

Re: [Qemu-devel] [PATCH 12/12] trace: [all] Add "guest_vmem" event

2014-02-06 Thread Richard Henderson
On 02/04/2014 12:01 PM, Lluís Vilanova wrote: > Richard Henderson writes: > >> On 01/31/2014 08:10 AM, Lluís Vilanova wrote: >>> +#define ldub(p)({ trace_guest_vmem(p, 1, 0); ldub_raw(p);}) > >> Are you sure you want to log these here? Uses of these macros are >> not restricted to the gu

[Qemu-devel] [PATCH v4 2/6] net: extend NetClientInfo for offloading

2014-02-06 Thread Vincenzo Maffione
Some new callbacks have been added to generalize the operations done by virtio-net and vmxnet3 frontends to manipulate TAP offloadings. Signed-off-by: Vincenzo Maffione --- include/net/net.h | 19 +++ net/net.c | 55 +++

[Qemu-devel] [PATCH v4 0/6] Add netmap backend offloadings support

2014-02-06 Thread Vincenzo Maffione
The purpose of this patch series is to add offloadings support (TSO/UFO/CSUM) to the netmap network backend, and make it possible for the paravirtual network frontends (virtio-net and vmxnet3) to use it. In order to achieve this, these patches extend the existing net.h interface to add abstract ope

[Qemu-devel] [PATCH v4 5/6] net: make tap offloading callbacks static

2014-02-06 Thread Vincenzo Maffione
Since TAP offloadings are manipulated through a new API, it's not necessary to export them in include/net/tap.h anymore. Signed-off-by: Vincenzo Maffione --- include/net/tap.h | 6 -- net/tap-win32.c | 12 ++-- net/tap.c | 12 ++-- 3 files changed, 12 insertions(+)

[Qemu-devel] [PATCH v4 4/6] net: virtio-net and vmxnet3 use offloading API

2014-02-06 Thread Vincenzo Maffione
With this patch, virtio-net and vmxnet3 frontends make use of the qemu_peer_* API for backend offloadings manipulations, instead of calling TAP-specific functions directly. We also remove the existing checks which prevent those frontends from using offloadings with backends different from TAP (e.g.

[Qemu-devel] [PATCH v4 3/6] net: TAP uses NetClientInfo offloading callbacks

2014-02-06 Thread Vincenzo Maffione
The TAP NetClientInfo structure is inizialized with the TAP-specific functions that manipulates offloading features. Signed-off-by: Vincenzo Maffione --- net/tap-win32.c | 92 ++--- net/tap.c | 6 2 files changed, 55 insertions(+),

[Qemu-devel] [PATCH v4 6/6] net: add offloading support to netmap backend

2014-02-06 Thread Vincenzo Maffione
Whit this patch, the netmap backend supports TSO/UFO/CSUM offloadings, and accepts the virtio-net header, similarly to what happens with TAP. The offloading callbacks in the NetClientInfo interface have been implemented. Signed-off-by: Vincenzo Maffione --- net/netmap.c | 68

[Qemu-devel] [PATCH v4 1/6] net: change vnet-hdr TAP prototypes

2014-02-06 Thread Vincenzo Maffione
The tap_has_vnet_hdr() and tap_has_vnet_hdr_len() functions used to return int, even though they only return true/false values. This patch changes the prototypes to return bool. Signed-off-by: Vincenzo Maffione --- include/net/tap.h | 4 ++-- net/tap-win32.c | 8 net/tap.c | 6

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-06 Thread Richard Henderson
On 02/04/2014 12:33 PM, Lluís Vilanova wrote: > Richard Henderson writes: > >> On 01/31/2014 08:09 AM, Lluís Vilanova wrote: >>> Adds the base ability to specify which events in the "trace-events" file >>> may be >>> used to trace guest activity in the TCG code (using the "tcg" event >>> propery

[Qemu-devel] [PATCH] xen_disk: fix io accounting

2014-02-06 Thread Olaf Hering
bdrv_acct_done was called unconditional. But in case the ioreq has no segments there is no matching bdrv_acct_start call. This could lead to bogus accounting values. Found by code inspection. Signed-off-by: Olaf Hering --- hw/block/xen_disk.c | 13 - 1 file changed, 12 insertions(+)

Re: [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU features into properties

2014-02-06 Thread Andreas Färber
Am 06.02.2014 16:19, schrieb Igor Mammedov: > On Wed, 5 Feb 2014 17:52:16 +0100 > Igor Mammedov wrote: > >> On Wed, 05 Feb 2014 17:14:27 +0100 >> Andreas Färber wrote: >> >>> Am 05.02.2014 15:40, schrieb Igor Mammedov: On Sun, 15 Dec 2013 23:50:47 +0100 Andreas Färber wrote:

[Qemu-devel] [PATCH] net: Include iov.h in checksum.h

2014-02-06 Thread Alexander Graf
The checksum calculation header exports a function that refers to struct iov which is defined in iov.h. Include the header so that the compiler knows what this struct is about. Fixes the following compile failure for me: In file included from hw/net/fsl_etsec/rings.c:24:0: include/net/checksu

[Qemu-devel] [PATCH v4] qdev: Keep global allocation counter per bus

2014-02-06 Thread Markus Armbruster
From: Alexander Graf When we have 2 separate qdev devices that both create a qbus of the same type without specifying a bus name or device name, we end up with two buses of the same name, such as ide.0 on the Mac machines: dev: macio-ide, id "" bus: ide.0 type IDE dev: macio-ide, i

Re: [Qemu-devel] [PATCH] s390: Storage key global access

2014-02-06 Thread Christian Borntraeger
On 22/01/14 16:48, Jason J. Herne wrote: > From: "Jason J. Herne" > > Introduces global access to storage key data so we can set it for each cpu in > the S390 cpu initialization routine. > > Signed-off-by: Jason J. Herne > --- > hw/s390x/s390-virtio-ccw.c | 3 +-- > hw/s390x/s390-virtio.c

Re: [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU features into properties

2014-02-06 Thread Igor Mammedov
On Wed, 5 Feb 2014 17:52:16 +0100 Igor Mammedov wrote: > On Wed, 05 Feb 2014 17:14:27 +0100 > Andreas Färber wrote: > > > Am 05.02.2014 15:40, schrieb Igor Mammedov: > > > On Sun, 15 Dec 2013 23:50:47 +0100 > > > Andreas Färber wrote: > > > > > >> Am 27.11.2013 23:28, schrieb Igor Mammedov: >

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-06 Thread Markus Armbruster
Alexander Graf writes: > On 06.02.2014, at 15:41, Markus Armbruster wrote: > >> Paolo Bonzini writes: >> >>> Il 04/02/2014 13:14, Markus Armbruster ha scritto: Paolo Bonzini writes: > Il 04/02/2014 11:33, Markus Armbruster ha scritto: >> >>This breaks migration unl

Re: [Qemu-devel] [PATCH V9 0/5] target-ppc: Add support for dumping guest memory using qemu gdb server

2014-02-06 Thread Alexander Graf
On 28.01.2014, at 08:59, Aneesh Kumar K.V wrote: > Hi, > > > This patch series implement support for dumping guest memory using qemu gdb > server. The last patch also enable qemu monitor command dump-guest-memory > > With this patch series we can now do > > (gdb) x/4i htab_call_hpte_insert

[Qemu-devel] [PATCH 04/10] tests/qapi-schema: Cover anonymous union types

2014-02-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/qapi-schema/qapi-schema-test.json | 4 tests/qapi-schema/qapi-schema-test.out | 6 +- tests/test-qmp-input-strict.c | 32 tests/test-qmp-input-visitor.c | 18 ++ tests/test-

[Qemu-devel] [PATCH 09/10] qapi: Drop unused code in qapi-commands.py

2014-02-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi-commands.py | 20 1 file changed, 20 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index b12b696..4bca121 100644 --- a/scripts/qapi-commands.py +++ b/scripts/qapi-commands.py @@ -23,13 +23,6 @

Re: [Qemu-devel] [PATCH RFC] target-ppc: support ibm, pa-features device property

2014-02-06 Thread Alexander Graf
On 28.01.2014, at 09:03, Aneesh Kumar K.V wrote: > We will use this later to disable Transactional memory in case of PR KVM > > Signed-off-by: Aneesh Kumar K.V > --- > NOTE: > PPC2_TM value may need update before merging this. > > hw/ppc/spapr.c | 42

[Qemu-devel] [PATCH 08/10] qapi: Drop nonsensical header guard in generated qapi-visit.c

2014-02-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi-visit.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index 65f1a54..ff4239c 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-visit.py @@ -494,10 +494,8 @@ fdecl.write(guardend("QAPI_VISIT

Re: [Qemu-devel] 128Kb bios size and older machines?

2014-02-06 Thread Ian Campbell
On Thu, 2014-02-06 at 15:31 +0100, Gerd Hoffmann wrote: > Hi, > > > I'm not sure why the BIOS size is relevant to migration anyway, Xen > > doesn't load a new BIOS on the target host, the BIOS image is part of > > the migrated RAM. > > The memory layout is different with a larger bios as qemu m

[Qemu-devel] [PATCH 02/10] tests/qapi-schema: Cover optional command arguments

2014-02-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/qapi-schema/qapi-schema-test.json | 4 +++- tests/qapi-schema/qapi-schema-test.out | 2 +- tests/test-qmp-commands.c | 8 +--- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/qapi-schema/qapi-schema-test.json b/t

[Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors

2014-02-06 Thread Markus Armbruster
Visitors get passed a pointer to the visited object. The generated visitors try to cope with this pointer being null in some places, for instance like this: visit_start_optional(m, obj ? &(*obj)->has_name : NULL, "name", &err); visit_start_optional() passes its second argument to Visitor met

Re: [Qemu-devel] [PATCH v3 0/4] elf loader: exit if incompatible architecture is detected

2014-02-06 Thread Alexander Graf
On 04.02.2014, at 05:04, Alexey Kardashevskiy wrote: > The aim of this set is to print reasonable error if ELF cannot be loaded. > While we are here, also fix some other bits. > > Changes: > v3: > * added a helper to convert error codes to strings Thanks, applied all to ppc-next. Alex

Re: [Qemu-devel] 128Kb bios size and older machines?

2014-02-06 Thread Ian Campbell
On Thu, 2014-02-06 at 17:30 +0400, Michael Tokarev wrote: > 06.02.2014 17:15, Ian Campbell wrote: > > On Thu, 2014-02-06 at 17:08 +0400, Michael Tokarev wrote: > >> 06.02.2014 12:50, Gerd Hoffmann wrote: > [] > >>> As far I know xen has its own seabios builds anyway as they > >>> have to add hvmloa

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-06 Thread Alexander Graf
On 06.02.2014, at 15:41, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Il 04/02/2014 13:14, Markus Armbruster ha scritto: >>> Paolo Bonzini writes: >>> Il 04/02/2014 11:33, Markus Armbruster ha scritto: > >This breaks migration unless you change bus=ide.0 to bus=ide

[Qemu-devel] [PATCH 05/10] tests/qapi-schema: Cover complex types with base

2014-02-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/qapi-schema/qapi-schema-test.json | 6 +- tests/qapi-schema/qapi-schema-test.out | 6 -- tests/test-qmp-commands.c | 15 ++- tests/test-qmp-input-visitor.c | 4 ++-- tests/test-qmp-output-visitor.c |

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-06 Thread Markus Armbruster
Paolo Bonzini writes: > Il 04/02/2014 13:14, Markus Armbruster ha scritto: >> Paolo Bonzini writes: >> >>> Il 04/02/2014 11:33, Markus Armbruster ha scritto: This breaks migration unless you change bus=ide.0 to bus=ide.1 on the destination. Should be mentioned in

[Qemu-devel] Enabling x2apic by default in KvM (was Re: [PATCH] target-i386: enable x2apic by default on more recent CPU models)

2014-02-06 Thread Eduardo Habkost
On Tue, Feb 04, 2014 at 03:12:43PM +0100, Andreas Färber wrote: > Am 03.02.2014 20:01, schrieb Eduardo Habkost: > > On Tue, Jan 21, 2014 at 05:13:50PM +0100, Paolo Bonzini wrote: > >> Il 21/01/2014 16:51, Andreas Färber ha scritto: > > We already do that for other bits (e.g. XSAVE/OSXSAVE), > >

Re: [Qemu-devel] 128Kb bios size and older machines?

2014-02-06 Thread Ian Campbell
On Thu, 2014-02-06 at 17:08 +0400, Michael Tokarev wrote: > 06.02.2014 12:50, Gerd Hoffmann wrote: > > On Do, 2014-02-06 at 12:28 +0400, Michael Tokarev wrote: > >> Since the "small" (128Kb) seabios is now built without > >> support of xen, does that mean that xen will be unable > >> to use qemu wi

Re: [Qemu-devel] [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-06 Thread Giorgio Zoppi
Hi all, i offer part of my free time as mentor. Cheers, Giorgio 2014-02-06 13:27 GMT+01:00 Stefan Hajnoczi : > On Tue, Feb 4, 2014 at 1:38 PM, Michal Privoznik > wrote: > > On 03.02.2014 08:45, Stefan Hajnoczi wrote: > >> > >> KVM & libvirt: you are welcome to join the QEMU umbrella organizatio

Re: [Qemu-devel] 128Kb bios size and older machines?

2014-02-06 Thread Gerd Hoffmann
Hi, > I'm not sure why the BIOS size is relevant to migration anyway, Xen > doesn't load a new BIOS on the target host, the BIOS image is part of > the migrated RAM. The memory layout is different with a larger bios as qemu makes the virtual flash as big as the bios image is. The different mem

[Qemu-devel] [PATCH 00/10] qapi: Test coverage & clean up generated code

2014-02-06 Thread Markus Armbruster
Coverity is unhappy with the generated code. Nothing serious, just heaps of valid DEADCODE defects topped off with a few bogus FORWARD_NULL defects. I had a look at the generator, and decided I don't want to mess with it without decent test coverage. Unfortunately, a few features have been added

[Qemu-devel] [TCG] : Code flow understanding

2014-02-06 Thread Gaurav Sharma
I am working on something where i need to use the primarily the TCG part of qemu. I am aware of the basic code flow for TB generation, execution etc. What I am really looking is the entry / exit points for TCG and also how the mapping of registers is done. I see there are many temporaries created a

Re: [Qemu-devel] [PATCH v3 3/5] net: TAP uses NetClientInfo offloading callbacks

2014-02-06 Thread Vincenzo Maffione
Ok, It could go as patch 5/6. Thanks 2014-02-06 Stefan Hajnoczi : > On Mon, Jan 20, 2014 at 06:07:03PM +0100, Vincenzo Maffione wrote: > > The TAP NetClientInfo structure is inizialized with the TAP-specific > > functions that manipulates offloading features. > > > > Signed-off-by: Vincenzo Maf

[Qemu-devel] [PATCH 06/10] tests/qapi-schema: Cover union types with base

2014-02-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/qapi-schema/qapi-schema-test.json | 1 + tests/qapi-schema/qapi-schema-test.out | 2 +- tests/test-qmp-input-strict.c | 4 ++-- tests/test-qmp-input-visitor.c | 3 ++- tests/test-qmp-output-visitor.c | 2 ++ 5 files changed,

[Qemu-devel] [PATCH 03/10] tests/qapi-schema: Cover simple argument types

2014-02-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/qapi-schema/qapi-schema-test.json | 2 ++ tests/qapi-schema/qapi-schema-test.out | 1 + tests/test-qmp-commands.c | 16 3 files changed, 19 insertions(+) diff --git a/tests/qapi-schema/qapi-schema-test.json b/tests/qa

[Qemu-devel] [PATCH 01/10] tests/qapi-schema: Actually check successful QMP command response

2014-02-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/test-qmp-commands.c | 44 1 file changed, 36 insertions(+), 8 deletions(-) diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c index 5a3e82a..2416d07 100644 --- a/tests/test-qmp-commands.c +++

[Qemu-devel] [PATCH 07/10] tests/qapi-schema: Cover flat union types

2014-02-06 Thread Markus Armbruster
The test demonstrates a generator bug: the generated struct UserDefFlatUnion doesn't include members for the indirect base UserDefZero. Signed-off-by: Markus Armbruster --- tests/qapi-schema/qapi-schema-test.json | 7 +++ tests/qapi-schema/qapi-schema-test.out | 2 ++ tests/test-qmp-input

Re: [Qemu-devel] [PATCH v3 0/5] Add netmap backend offloadings support

2014-02-06 Thread Stefan Hajnoczi
On Mon, Jan 20, 2014 at 06:07:00PM +0100, Vincenzo Maffione wrote: > The purpose of this patch series is to add offloadings support > (TSO/UFO/CSUM) to the netmap network backend, and make it possible > for the paravirtual network frontends (virtio-net and vmxnet3) to > use it. > In order to achiev

Re: [Qemu-devel] [PATCH v3 3/5] net: TAP uses NetClientInfo offloading callbacks

2014-02-06 Thread Stefan Hajnoczi
On Mon, Jan 20, 2014 at 06:07:03PM +0100, Vincenzo Maffione wrote: > The TAP NetClientInfo structure is inizialized with the TAP-specific > functions that manipulates offloading features. > > Signed-off-by: Vincenzo Maffione > --- > net/tap.c | 6 ++ > 1 file changed, 6 insertions(+) > > di

Re: [Qemu-devel] [PATCH v3 0/5] disas: add libvixl to support A64 disassembly

2014-02-06 Thread Michael Matz
Hi, On Thu, 6 Feb 2014, Christopher Covington wrote: > > The FSF always grants back rights on the contribution to the > > contributor. ARM could simply double-license their original > > contribution of the disassembler. > > Is dual licensing always possible given a grant-back? What if the >

  1   2   >