Coverity is unhappy with the generated code. Nothing serious, just heaps of valid DEADCODE defects topped off with a few bogus FORWARD_NULL defects.
I had a look at the generator, and decided I don't want to mess with it without decent test coverage. Unfortunately, a few features have been added without tests. My first seven patches make the tests catch up. tests/qapi-schema/qapi-schema-test.json now covers all mcgen() in scripts/qapi*.py, except for a few in qapi-commands.py that are conditional on -m. My last three patches clean up the generated code. Markus Armbruster (10): tests/qapi-schema: Actually check successful QMP command response tests/qapi-schema: Cover optional command arguments tests/qapi-schema: Cover simple argument types tests/qapi-schema: Cover anonymous union types tests/qapi-schema: Cover complex types with base tests/qapi-schema: Cover union types with base tests/qapi-schema: Cover flat union types qapi: Drop nonsensical header guard in generated qapi-visit.c qapi: Drop unused code in qapi-commands.py qapi: Clean up null checking in generated visitors scripts/qapi-commands.py | 20 --------- scripts/qapi-visit.py | 16 +++---- tests/qapi-schema/qapi-schema-test.json | 24 +++++++++- tests/qapi-schema/qapi-schema-test.out | 19 +++++--- tests/test-qmp-commands.c | 79 +++++++++++++++++++++++++++------ tests/test-qmp-input-strict.c | 69 +++++++++++++++++++++++++++- tests/test-qmp-input-visitor.c | 45 +++++++++++++++++-- tests/test-qmp-output-visitor.c | 67 ++++++++++++++++++++++++++-- tests/test-visitor-serialization.c | 14 +++--- 9 files changed, 288 insertions(+), 65 deletions(-) -- 1.8.1.4
