[Qemu-devel] [PATCH v2] arm/zynq: Add software reset

2014-02-04 Thread Sebastian Huber
Signed-off-by: Sebastian Huber Reviewed-by: Peter Crosthwaite --- hw/misc/zynq_slcr.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/misc/zynq_slcr.c b/hw/misc/zynq_slcr.c index e42a5b0..d1cc233 100644 --- a/hw/misc/zynq_slcr.c +++ b/hw/misc/zynq_slcr.c @@ -31,6

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-04 Thread Paolo Bonzini
Il 04/02/2014 23:17, Alexey Kardashevskiy ha scritto: >> Well, it will fix it in my particular case but in a long run this does not >> feel like a fix - there should be a way for migration_thread() to know that >> ram_save_iterate() sent all dirty pages it had to send, no? > > No, because new pa

[Qemu-devel] [PULL] VirtFS update

2014-02-04 Thread Aneesh Kumar K.V
Hi Anthony, Please pull the below update for VirtFS The following changes since commit 2f61120c10da9128357510debc8e66880cd2bfdc: Merge remote-tracking branch 'qmp-unstable/queue/qmp' into staging (2014-02-01 23:32:31 +) are available in the git repository at: https://github.com/kvan

Re: [Qemu-devel] [PATCH v2 18/35] target-arm: Fix incorrect type for value argument to write_raw_cp_reg

2014-02-04 Thread Peter Crosthwaite
On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell wrote: > The write_raw_cp_reg's value argument should be a uint64_t, since > that's what all its callers hand it and what all the functions it > calls take. A (harmless) typo meant we were accidentally declaring > it as int64_t. > > Signed-off-by: Pete

[Qemu-devel] Qemu Bare metal Query

2014-02-04 Thread Mj Embd
Hi Qemu Folks, Is it possible to run Qemu bare metal , after u-boot like linux is loaded from u-boot? Like running qemu from u-boot bootm command? - Reset | Uboot | Qemu Usually qemu runs on host os, so there would be some dependencies, how to find what all dependencies are there? Thanks -- -m

Re: [Qemu-devel] [PATCH v2 12/35] target-arm: Convert performance monitor reginfo to accesfn

2014-02-04 Thread Peter Crosthwaite
cc Alistair, this may conflict with his timer work. On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell wrote: > Convert the performance monitor reginfo definitions to use > an accessfn rather than returning EXCP_UDEF from read and > write functions. This also allows us to fix a couple of XXX > cases w

Re: [Qemu-devel] [PATCH v2 09/35] target-arm: A64: Implement MSR (immediate) instructions

2014-02-04 Thread Peter Crosthwaite
On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell wrote: > Implement the MSR (immediate) instructions, which can update the > PSTATE SP and DAIF fields. > > Signed-off-by: Peter Maydell > --- > target-arm/cpu.h | 1 + > target-arm/helper.h| 2 ++ > target-arm/op_helper.c | 25

Re: [Qemu-devel] [PATCH] misc: Fix case Qemu -> QEMU

2014-02-04 Thread Stefan Weil
Am 04.02.2014 15:39, schrieb Andreas Färber: > Am 04.02.2014 06:43, schrieb Stefan Weil: >> Signed-off-by: Stefan Weil >> --- >> scripts/switch-timer-api |2 +- >> tests/i440fx-test.c |2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Andreas Färber > > bu

Re: [Qemu-devel] [PATCH v2 05/35] target-arm: Remove unused ARMCPUState sr substruct

2014-02-04 Thread Peter Crosthwaite
On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell wrote: > Remove the 'struct sr' from ARMCPUState -- it isn't actually used and is > a hangover from the original separate system register implementation used > by the SuSE linux-user-mode-only AArch64 target. > > Signed-off-by: Peter Maydell Reviewed

Re: [Qemu-devel] [PATCH] arm/zynq: Add software reset

2014-02-04 Thread Peter Crosthwaite
CC PMM for target-arm queue relevance. On Mon, Feb 3, 2014 at 5:46 PM, Sebastian Huber wrote: > Signed-off-by: Sebastian Huber > --- > hw/misc/zynq_slcr.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/hw/misc/zynq_slcr.c b/hw/misc/zynq_slcr.c > index e42a5b0..4

Re: [Qemu-devel] [PATCH] configure: use glib in glib pkg-config check.

2014-02-04 Thread Chris Johns
On 4/02/2014 8:59 pm, Daniel P. Berrange wrote: On Linux there are more flags present in gthread-2.0.pc that are not present in glib-2.0.pc: Name: GThread Description: Thread support for GLib Requires: glib-2.0 Version: 2.38.2 Libs: -L${libdir} -lgthread-2.0 -pthread Cflags: -

Re: [Qemu-devel] [PATCH v5 2/4] util/fifo8: clear fifo head upon reset

2014-02-04 Thread Peter Crosthwaite
On Fri, Jan 31, 2014 at 8:02 AM, Beniamino Galvani wrote: > To improve the predictability of fifo8_pop_buf(), the fifo head is set > to start of data buffer upon a reset so that the first call to the A nit: "the start of the" > function will be able to retrieve all data in the fifo. > > Signed-

Re: [Qemu-devel] [PATCH v5 1/4] util/fifo8: implement push/pop of multiple bytes

2014-02-04 Thread Peter Crosthwaite
On Fri, Jan 31, 2014 at 8:02 AM, Beniamino Galvani wrote: > The patch adds functions fifo8_push_all() and fifo8_pop_buf() which > can be used respectively to push the content of a memory buffer to the > fifo and to pop multiple bytes obtaining a pointer to the fifo backing > buffer. > > In additio

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-02-04 Thread Peter Crosthwaite
On Tue, Feb 4, 2014 at 7:28 PM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Peter Crosthwaite writes: >> >>> On Wed, Jan 8, 2014 at 11:47 PM, Paolo Bonzini wrote: Il 08/01/2014 14:40, Andreas Färber ha scritto: > > Either you fix "info qtree" to cope with your change to t

Re: [Qemu-devel] backport three changes for v1.7.1

2014-02-04 Thread Petar Jovanovic
ping From: Stefan Hajnoczi [stefa...@gmail.com] Sent: Wednesday, January 08, 2014 5:52 AM To: Petar Jovanovic Cc: qemu-stable ‎[qemu-sta...@nongnu.org]‎; qemu-devel@nongnu.org; Michael Roth Subject: Re: [Qemu-devel] backport three changes for v1.7.1 On Wed,

Re: [Qemu-devel] kvm control qemu-system-aarch64 state

2014-02-04 Thread Claudio Fontana
Hello Peter, thank you for your answer, On 4 February 2014 16:39, Peter Maydell wrote: > > On 4 February 2014 15:36, Claudio Fontana wrote: > > I just wanted to ask what is the current state of kvm control for > > qemu-system-aarch64. > > I tried latest mainline but I think it's not all there y

[Qemu-devel] kvm control qemu-system-aarch64 state

2014-02-04 Thread Claudio Fontana
Hello Peter, I just wanted to ask what is the current state of kvm control for qemu-system-aarch64. I tried latest mainline but I think it's not all there yet (it complains about missing cpu when I use -M virt and -cpu host, so I suspect some of VOS patches are still missing). Is your aarch64-kvm

Re: [Qemu-devel] [Qemu-ppc] standard test image not booting with qemu-system-ppc

2014-02-04 Thread Anthony PERARD
On Tue, Feb 04, 2014 at 02:17:55PM +0100, Paolo Bonzini wrote: > Il 04/02/2014 08:55, Alexander Graf ha scritto: > >> With this change, the > >> memory system is now refusing to allow an access of size > >> 2 through, because it's greater than the region length. So > > > > Ouch. Yes, for ioport re

[Qemu-devel] [PATCH RFC] char: fix avail_connections init in qemu_chr_open_eventfd()

2014-02-04 Thread David Marchand
Hello, First of all, this is a pure RFC patch, I did not take too much time to dig into qemu source code to find the right solution, but since qemu_chr_open_eventfd() is only used by the code I was looking at, here is a patch. When trying to use a ivshmem server with qemu, ivshmem init code tri

Re: [Qemu-devel] [PATCH v2 1/4] target-mips: add CPU definition for MIPS32R5

2014-02-04 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/313937/ http://patchwork.ozlabs.org/patch/313938/ http://patchwork.ozlabs.org/patch/313944/ http://patchwork.ozlabs.org/patch/313936/ Regards, Petar From: Petar Jovanovic [petar.jovano...@rt-rk.com] Sent: Friday, Janua

[Qemu-devel] Speed disk virtio

2014-02-04 Thread XliN
Good day. Very little speed drives Virtio. Drivers are the latest guest on the system "Windows server 2008". Host system centos 6.5. All that can be tried, but failed to increase the speed. And there I have a database running. Screenshots test speed drives http://itmages.ru/image/view/147177

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-04 Thread Chen Gang
On 02/05/2014 12:18 AM, Aneesh Kumar K.V wrote: > Chen Gang writes: > >> On 02/04/2014 07:06 PM, Daniel P. Berrange wrote: >>> On Tue, Feb 04, 2014 at 07:02:18PM +0800, Chen Gang wrote: On 02/03/2014 06:39 PM, Chen Gang wrote: > On 02/03/2014 06:34 PM, Daniel P. Berrange wrote: >> On

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-04 Thread Sander Eikelenboom
Tuesday, February 4, 2014, 10:55:18 PM, you wrote: > Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: >> xenfv has no fwcfg and so does not load acpi from QEMU. >> as such new acpi features don't work. >> >> Reported-by: Sander Eikelenboom >> Signed-off-by: Michael S. Tsirkin >> --- >> >> Sa

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-04 Thread Alexey Kardashevskiy
On 02/05/2014 01:00 AM, Paolo Bonzini wrote: > Il 04/02/2014 13:16, Alexey Kardashevskiy ha scritto: >> On 02/04/2014 11:07 PM, Paolo Bonzini wrote: >>> Il 04/02/2014 12:59, Alexey Kardashevskiy ha scritto: >> With the default throttling of 32 MiB/s, bandwidth must be something >> like

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-04 Thread Paolo Bonzini
Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: xenfv has no fwcfg and so does not load acpi from QEMU. as such new acpi features don't work. Reported-by: Sander Eikelenboom Signed-off-by: Michael S. Tsirkin --- Sander, could you pleas econfirm this works for you? Also, Xen really should

Re: [Qemu-devel] [PATCH V14 00/13] Quorum block filter

2014-02-04 Thread Benoît Canet
Le Tuesday 04 Feb 2014 à 11:35:04 (+0100), Kevin Wolf a écrit : > Am 03.02.2014 um 20:11 hat Benoît Canet geschrieben: > > v14: > >Use quorum_report_failure in early failure test suggested by Max [Benoît] > > > > v13: > > update copyright date and company legal status > > Benoît, please s

Re: [Qemu-devel] [PATCH V15 13/13] quorum: Add unit test.

2014-02-04 Thread Benoît Canet
Le Tuesday 04 Feb 2014 à 17:13:27 (+0100), Kevin Wolf a écrit : > Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: > > Signed-off-by: Benoit Canet > > Reviewed-by: Max Reitz > > --- > > tests/qemu-iotests/075 | 95 > > ++ > > tests/qemu-iotest

[Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-04 Thread Michael S. Tsirkin
xenfv has no fwcfg and so does not load acpi from QEMU. as such new acpi features don't work. Reported-by: Sander Eikelenboom Signed-off-by: Michael S. Tsirkin --- Sander, could you pleas econfirm this works for you? Also, Xen really should switch to fw cfg some day ... hw/i386/pc_piix.c | 11

[Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-04 Thread Jeff Cody
In preparation for supporting reopen on gluster, move flag parsing out to a function. Also, store open_flags and filename in the gluster state storage struct, and add a NULL check in the gconf cleanup. Signed-off-by: Jeff Cody --- block/gluster.c | 48 ---

[Qemu-devel] [PATCH 2/2] block: gluster - add reopen support.

2014-02-04 Thread Jeff Cody
Gluster does parse open flags in its .bdrv_open() implementation, and the .bdrv_reopen_* implementations need to do the same. A new gluster connection to the image file to be created is established in the .bdrv_reopen_prepare(), and the image file opened with the new flags. If this is successful,

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Lluís Vilanova
Richard Henderson writes: > On 02/04/2014 07:02 AM, Peter Maydell wrote: >> On 4 February 2014 14:57, Richard Henderson wrote: >>> I suppose I have no major objection to the feature, although frankly it's >>> not especially exciting. I can't really imagine ever wanting to bulk trace >>> all of t

Re: [Qemu-devel] [PULL 0/1] libcacard glusterfs fix

2014-02-04 Thread Peter Maydell
On 30 January 2014 15:03, Alon Levy wrote: > The following changes since commit 0706f7c85b3c0783f92d44b551f362884db0f4bd: > > Merge remote-tracking branch 'mjt/tags/trivial-patches-2014-01-16' into > staging (2014-01-30 13:56:00 +) > > are available in the git repository at: > > > git://p

Re: [Qemu-devel] Commit 9e047b982452c633882b486682966c1d97097015 (piix4: add acpi pci hotplug support) seems to break Xen pci-passthrough

2014-02-04 Thread Michael S. Tsirkin
On Tue, Feb 04, 2014 at 04:30:24PM +0100, Igor Mammedov wrote: > On Tue, 4 Feb 2014 16:07:08 +0100 > Sander Eikelenboom wrote: > > > > > Tuesday, February 4, 2014, 3:32:19 PM, you wrote: > > > > > On Tue, Feb 04, 2014 at 12:46:08AM +0100, Sander Eikelenboom wrote: > > >> Grmbll my fat fingers h

Re: [Qemu-devel] kvm control qemu-system-aarch64 state

2014-02-04 Thread Peter Maydell
On 4 February 2014 15:36, Claudio Fontana wrote: > I just wanted to ask what is the current state of kvm control for > qemu-system-aarch64. > I tried latest mainline but I think it's not all there yet (it complains > about missing cpu when I use -M virt and -cpu host, so I suspect some of VOS > pa

[Qemu-devel] [PATCH 1/2] SMBIOS: Update Type 17 (Memory Device) struct to v2.3

2014-02-04 Thread Gabriel L. Somlo
Add v2.3 fields to Type 17 (Memory Device) structure. Without these, selecting "About This Mac" on an OS X guest will crash and restart the GUI. Signed-off-by: Gabriel Somlo --- src/fw/smbios.c | 6 ++ src/std/smbios.h | 6 ++ 2 files changed, 12 insertions(+) diff --git a/src/fw/smbio

[Qemu-devel] [PULL v5 02/12] tests: lm32: new rule for single test cases

2014-02-04 Thread Michael Walle
Introduce new target "check_%" to run individual test caes, eg. make check_mmu Signed-off-by: Michael Walle Reviewed-by: Peter Maydell --- tests/tcg/lm32/Makefile |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/tcg/lm32/Makefile b/tests/tcg/lm32/Makefile i

[Qemu-devel] [PATCH 0/2] block: add support for gluster reopen

2014-02-04 Thread Jeff Cody
This series provides support for bdrv_reopen() with gluster protocol drivers, and thereby also enabling block-commit to gluster-based images. Jeff Cody (2): block: gluster - code movements, state storage changes block: gluster - add reopen support. block/gluster.c | 154 +

Re: [Qemu-devel] [PATCH] xen_disk: add discard support

2014-02-04 Thread Kevin Wolf
Am 04.02.2014 um 16:47 hat Olaf Hering geschrieben: > On Mon, Feb 03, Kevin Wolf wrote: > > > Am 30.01.2014 um 16:02 hat Olaf Hering geschrieben: > > > +++ b/hw/block/xen_disk.c > > > > +case BLKIF_OP_DISCARD: > > > +{ > > > +struct blkif_request_discard *discard_req = (void *)&io

[Qemu-devel] [PATCH 4/8] Add check for cache size smaller than page size

2014-02-04 Thread Juan Quintela
From: Orit Wasserman Signed-off-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- arch_init.c | 4 migration.c | 10 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index 66f5e82..8edeabe 100644 --- a/arch_

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Lluís Vilanova
Peter Maydell writes: > On 4 February 2014 14:57, Richard Henderson wrote: >> I suppose I have no major objection to the feature, although frankly it's >> not especially exciting. I can't really imagine ever wanting to bulk trace >> all of the helpers. Tracing specific helpers on a target-by-ta

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Lluís Vilanova
Richard Henderson writes: > On 01/31/2014 08:09 AM, Lluís Vilanova wrote: >> Adds the base ability to specify which events in the "trace-events" file may >> be >> used to trace guest activity in the TCG code (using the "tcg" event propery). >> >> Such events generate an extra set of tracing func

[Qemu-devel] [PULL v5 03/12] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write()

2014-02-04 Thread Michael Walle
From: Antony Pavlov qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and we don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Reported-by: Peter Crosthwaite Acked-by: Peter Crosthwaite Signed-off-by: Antony Pavlov Signed-off-by: Michael Walle

[Qemu-devel] [PULL v2 0/8] migration queue

2014-02-04 Thread Juan Quintela
repository at: git://github.com/juanquintela/qemu.git tags/migration/20140204-1 for you to fetch changes up to 89db9987c07977bdb78d5d4b41d65e7acb9a5a2c: Don't abort on memory allocation error (2014-02-04 16:50:37 +0100) migr

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-04 Thread Aneesh Kumar K.V
Chen Gang writes: > On 02/04/2014 07:06 PM, Daniel P. Berrange wrote: >> On Tue, Feb 04, 2014 at 07:02:18PM +0800, Chen Gang wrote: >>> On 02/03/2014 06:39 PM, Chen Gang wrote: On 02/03/2014 06:34 PM, Daniel P. Berrange wrote: > On Mon, Feb 03, 2014 at 06:00:42PM +0800, Chen Gang wrote:

Re: [Qemu-devel] [PATCH v6 0/6] Support arm-gic-kvm save/restore

2014-02-04 Thread Christoffer Dall
On Tue, Feb 04, 2014 at 08:09:52PM +, Peter Maydell wrote: > On 4 February 2014 20:07, Christoffer Dall > wrote: > > On Tue, Feb 04, 2014 at 07:56:27PM +, Peter Maydell wrote: > >> Thanks; I've applied 1-5 to target-arm.next. > >> (Incidentally you could make my job a little easier by kee

[Qemu-devel] [PATCH 5/8] migration:fix free XBZRLE decoded_buf wrong

2014-02-04 Thread Juan Quintela
From: "Gonglei (Arei)" When qemu do live migration with xbzrle, qemu malloc decoded_buf at destination end but free it at source end. It will crash qemu by double free error in some scenarios. Splitting the XBZRLE structure for clear logic distinguishing src/dst side. Signed-off-by: ChenLiang R

Re: [Qemu-devel] [PATCH v6 0/6] Support arm-gic-kvm save/restore

2014-02-04 Thread Peter Maydell
On 4 February 2014 20:07, Christoffer Dall wrote: > On Tue, Feb 04, 2014 at 07:56:27PM +, Peter Maydell wrote: >> Thanks; I've applied 1-5 to target-arm.next. >> (Incidentally you could make my job a little easier by keeping >> the 'changes between v3 and v4' commentary after the '---' line >>

Re: [Qemu-devel] [PATCH 7/8] Don't abort on memory allocation error

2014-02-04 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> From: Orit Wasserman > >> if (!it->it_data) { >> cache->num_items++; >> +it->it_data = g_try_malloc(cache->page_size); >> +if (!it->it_data) { >> +DPRINTF("Error allocating

Re: [Qemu-devel] [PATCH v6 0/6] Support arm-gic-kvm save/restore

2014-02-04 Thread Christoffer Dall
On Tue, Feb 04, 2014 at 07:56:27PM +, Peter Maydell wrote: > On 3 February 2014 00:55, Christoffer Dall > wrote: > > On Sun, Feb 02, 2014 at 11:31:33PM +, Peter Maydell wrote: > >> On 2 February 2014 23:17, Christoffer Dall > >> wrote: > >> > The patches depend on the device control pat

[Qemu-devel] [PULL v5 09/12] lm32_sys: print test result on stderr

2014-02-04 Thread Michael Walle
Do not use qemu_log(). Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 16dc254..b2e157c 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -80,7 +80,7 @@ static void

Re: [Qemu-devel] [PATCH 12/12] trace: [all] Add "guest_vmem" event

2014-02-04 Thread Lluís Vilanova
Richard Henderson writes: > On 01/31/2014 08:10 AM, Lluís Vilanova wrote: >> +#define ldub(p)({ trace_guest_vmem(p, 1, 0); ldub_raw(p);}) > Are you sure you want to log these here? Uses of these macros are > not restricted to the guest. Therefore you could wind up with e.g. > PCI device

Re: [Qemu-devel] osx pci vs. 99fd437dee468609de8218f0eb3b16621fb6a9c9

2014-02-04 Thread Gabriel L. Somlo
On Tue, Feb 04, 2014 at 05:36:57PM +0200, Michael S. Tsirkin wrote: > Interesting. Possibly OSX wants an ACPI description of all slots > even if they aren't hotpluggable? > Could you try the following? (Note: compiled only, sorry - sick today). Yep, this patch fixes it for me, everything looks "no

[Qemu-devel] [PULL v5 05/12] milkymist-vgafb: swap pixel data in source buffer

2014-02-04 Thread Michael Walle
In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was eliminated. But we are reading from the target buffer a 16-bit value, which is in big-endian format. Therefore, use lduw_be_p() to read the value. Cc: Paolo Bonzini Signed-off-by: Michael Walle --- hw/display/milkymist-v

Re: [Qemu-devel] [PATCH] xen_disk: add discard support

2014-02-04 Thread Olaf Hering
On Tue, Feb 04, Kevin Wolf wrote: > Now you call bdrv_acct_done() in the callback without having a matching > bdrv_acct_start(). You need to make it conditional in the callback. I see. Stefano, Is ioreq_runio_qemu_aio symetric in this regard anyway? In case of BLKIF_OP_WRITE|BLKIF_OP_FLUSH_DISKC

Re: [Qemu-devel] [PATCH v6 0/6] Support arm-gic-kvm save/restore

2014-02-04 Thread Peter Maydell
On 3 February 2014 00:55, Christoffer Dall wrote: > On Sun, Feb 02, 2014 at 11:31:33PM +, Peter Maydell wrote: >> On 2 February 2014 23:17, Christoffer Dall >> wrote: >> > The patches depend on the device control patch series sent out earlier, >> > but is currently waiting on arm64 headers u

[Qemu-devel] [PULL v5 00/12] target-lm32 updates

2014-02-04 Thread Michael Walle
comments, include it here. Thanks, michael The following changes since commit 9396b05a5a35d344dc5eaed6fb0dff96c49d5f50: Merge remote-tracking branch 'remotes/mcayland/qemu-openbios' into staging (2014-02-04 16:16:37 +) are available in the git repository at: git://githu

Re: [Qemu-devel] WfW setup and DOS display.sys hanging

2014-02-04 Thread Kevin Wolf
Hi Gerd, Am 09.01.2014 um 00:20 hat Sebastian geschrieben: > Hi, > > I noticed in newer versions of Qemu (Debian Jessie) a regression > causing DISPLAY.SYS from MS-DOS 6.22 to hang the system as soon as > loaded. now that you sent a pull request for a SeaBIOS update, I tried what would happen wi

[Qemu-devel] [PATCH 3/8] Set xbzrle buffers to NULL after freeing them to avoid double free errors

2014-02-04 Thread Juan Quintela
From: Orit Wasserman Signed-off-by: Orit Wasserman Reviewed-by: Juan Quintela Reviewed-by: Eric Blake Signed-off-by: Juan Quintela --- arch_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch_init.c b/arch_init.c index 77912e7..66f5e82 100644 --- a/arch_init.c +++ b/arch_init.

Re: [Qemu-devel] kvm control qemu-system-aarch64 state

2014-02-04 Thread Christoffer Dall
On Tue, Feb 04, 2014 at 04:52:08PM +, Peter Maydell wrote: > On 4 February 2014 16:37, Claudio Fontana wrote: > > On 4 February 2014 16:39, Peter Maydell wrote: > >> On 4 February 2014 15:36, Claudio Fontana wrote: > >> > I just wanted to ask what is the current state of kvm control for > >>

Re: [Qemu-devel] [PATCH 3/6] migration:fix free XBZRLE decoded_buf wrong

2014-02-04 Thread Juan Quintela
Orit Wasserman wrote: > From: "Gonglei (Arei)" > > When qemu do live migration with xbzrle, qemu malloc decoded_buf > at destination end but free it at source end. It will crash qemu > by double free error in some scenarios. Splitting the XBZRLE structure > for clear logic distinguishing src/dst

[Qemu-devel] [PATCH 2/8] exec: fix ram_list dirty map optimization

2014-02-04 Thread Juan Quintela
From: Alexey Kardashevskiy The ae2810c4bb3b383176e8e1b33931b16c01483aab patch introduced optimization for ram_list.dirty_memory update. However it can only work correctly if hpratio is 1 as the @bitmap parameter stores 1 bits per system page size (may vary, 4K or 64K on PPC64) and ram_list.dirty_

Re: [Qemu-devel] [PATCH v3] target-arm: Add support for AArch32 64bit VCVTB and VCVTT

2014-02-04 Thread Peter Maydell
On 29 January 2014 10:31, Will Newton wrote: > Add support for the AArch32 floating-point half-precision to double- > precision conversion VCVTB and VCVTT instructions. > > Signed-off-by: Will Newton Thanks; I've fixed a minor style issue (missing braces on an if-ladder your patch touches) and a

[Qemu-devel] [PULL v5 10/12] lm32_sys: dump cpu state if test case fails

2014-02-04 Thread Michael Walle
This will ease debugging the test cases. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index b2e157c..e394f2e 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -82,6 +82,9 @@ static

[Qemu-devel] [PATCH] block: Add notes to iSCSI's .bdrv_open and .bdrv_reopen_prepare

2014-02-04 Thread Jeff Cody
iSCSI currently does not need to do any actions to support the current usage of bdrv_reopen(). However, it is important to note a couple of things: 1.) A connection will not be re-established to an iSCSI target, and 2.) If iscsi_open() is changed to parse 'flags', then iscsi_reopen_prepare() may n

[Qemu-devel] [PULL v5 07/12] target-lm32: move model features to LM32CPU

2014-02-04 Thread Michael Walle
This allows us to completely remove CPULM32State from DisasContext. Instead, copy the fields we need to DisasContext. Reviewed-by: Andreas Färber Signed-off-by: Michael Walle --- target-lm32/cpu-qom.h |6 ++ target-lm32/cpu.c | 187 ++- t

[Qemu-devel] [PULL v5 06/12] target-lm32: kill cpu_abort() calls

2014-02-04 Thread Michael Walle
Instead of killing QEMU, translate instructions which are not available on the CPU model as a noop and issue a log message at translation time. On the real hardware CPU unknown opcodes results in undefined behaviour. These changes prepare the removal of CPULM32State from DisasContext. Signed-off

[Qemu-devel] [PULL v5 01/12] lm32_sys: increase test case name length limit

2014-02-04 Thread Michael Walle
The new MMU tests use longer names. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 9bdb781..16dc254 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -42,7 +42

[Qemu-devel] [PULL v5 08/12] target-lm32: add breakpoint/watchpoint support

2014-02-04 Thread Michael Walle
This patch adds in-target breakpoint and watchpoint support. Signed-off-by: Michael Walle --- target-lm32/TODO|2 -- target-lm32/cpu.c |1 + target-lm32/cpu.h | 27 -- target-lm32/helper.c| 90 +++ target

[Qemu-devel] [PULL v5 12/12] hw/lm32: print error if cpu model is not found

2014-02-04 Thread Michael Walle
QEMU crashed if a the given cpu_model is not found. Signed-off-by: Michael Walle Reviewed-by: Peter Maydell --- hw/lm32/lm32_boards.c | 10 ++ hw/lm32/milkymist.c |5 + 2 files changed, 15 insertions(+) diff --git a/hw/lm32/lm32_boards.c b/hw/lm32/lm32_boards.c index c032bb

[Qemu-devel] [PATCH 2/2] SMBIOS: Add Type 2 (Baseboard) struct

2014-02-04 Thread Gabriel L. Somlo
OS X (10.7/Lion and 10.8/MountainLion) guests crash during boot if a Type 2 (Baseboard) structure is not found in the SMBIOS table. Signed-off-by: Gabriel Somlo --- src/fw/smbios.c | 36 src/std/smbios.h | 16 2 files changed, 52 insertions(

[Qemu-devel] [PULL v5 04/12] lm32_uart/lm32_juart: use qemu_chr_fe_write_all()

2014-02-04 Thread Michael Walle
qemu_chr_fe_write() may return EAGAIN. Therefore, use qemu_chr_fe_write_all(). Signed-off-by: Michael Walle Reviewed-by: Peter Maydell --- hw/char/lm32_juart.c |2 +- hw/char/lm32_uart.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/lm32_juart.c b/hw/cha

[Qemu-devel] [PULL v5 11/12] target-lm32: stop VM on illegal or unknown instruction

2014-02-04 Thread Michael Walle
Instead of translating the instruction to a no-op, pause the VM and display a message to the user. As a side effect, this also works for instructions where the operands are only known at runtime. Signed-off-by: Michael Walle --- target-lm32/helper.h|1 + target-lm32/op_helper.c | 17 +

Re: [Qemu-devel] [PULL 0/5] s390/kvm: fixes and features

2014-02-04 Thread Peter Maydell
On 31 January 2014 09:28, Christian Borntraeger wrote: > Anthony, Peter, > > The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c: > > SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) > > are available in the git repository at: > > git://github.com/bor

[Qemu-devel] [PATCH 8/8] Don't abort on memory allocation error

2014-02-04 Thread Juan Quintela
From: Orit Wasserman It is better to fail migration in case of failure to allocate new cache item Signed-off-by: Orit Wasserman Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- arch_init.c| 4 +++- include/migration/page_cache.h | 4 +++- page_cache.

Re: [Qemu-devel] [PATCH] xen_disk: add discard support

2014-02-04 Thread Olaf Hering
On Mon, Feb 03, Kevin Wolf wrote: > Am 30.01.2014 um 16:02 hat Olaf Hering geschrieben: > > +++ b/hw/block/xen_disk.c > > +case BLKIF_OP_DISCARD: > > +{ > > +struct blkif_request_discard *discard_req = (void *)&ioreq->req; > > +bdrv_acct_start(blkdev->bs, &ioreq->acct, > >

Re: [Qemu-devel] file_ram_alloc: unify mem-path, mem-prealloc error handling

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 01:41:53PM -0500, Marcelo Tosatti wrote: > > -mem-prealloc asks to preallocate memory residing on -mem-path path. > > Currently QEMU exits in case: > > - Memory file has been created but allocation via explicit write > fails. > > And it fallbacks to malloc in case: > -

[Qemu-devel] file_ram_alloc: unify mem-path, mem-prealloc error handling

2014-02-04 Thread Marcelo Tosatti
-mem-prealloc asks to preallocate memory residing on -mem-path path. Currently QEMU exits in case: - Memory file has been created but allocation via explicit write fails. And it fallbacks to malloc in case: - Querying huge page size fails. - Lack of sync MMU support. - Open fails. - mmap fail

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Richard Henderson
On 02/04/2014 07:02 AM, Peter Maydell wrote: > On 4 February 2014 14:57, Richard Henderson wrote: >> I suppose I have no major objection to the feature, although frankly it's >> not especially exciting. I can't really imagine ever wanting to bulk trace >> all of the helpers. Tracing specific hel

Re: [Qemu-devel] [PULL] Update OpenBIOS images to r1246

2014-02-04 Thread Peter Maydell
Applied, thanks. -- PMM On 12 January 2014 15:25, Mark Cave-Ayland wrote: > Hi Anthony, > > Please pull the latest OpenBIOS binary images. In particular, these images fix > the following two bugs in SPARC32: > > - Booting with OBP instead of OpenBIOS > - Booting from hard disk instead of CDR

Re: [Qemu-devel] [PATCH] xen_disk: add discard support

2014-02-04 Thread Olaf Hering
On Tue, Feb 04, Olaf Hering wrote: > On Tue, Feb 04, Kevin Wolf wrote: > > > Now you call bdrv_acct_done() in the callback without having a matching > > bdrv_acct_start(). You need to make it conditional in the callback. > Stefano, > Is ioreq_runio_qemu_aio symetric in this regard anyway? In cas

[Qemu-devel] [PATCH 1/8] vmstate: Make VMSTATE_STRUCT_POINTER take type, not ptr-to-type

2014-02-04 Thread Juan Quintela
From: Peter Maydell The VMSTATE_STRUCT_POINTER macros are a bit odd in that they must be passed an argument "FooType *" rather than just taking the FooType. They're only used in one place, so it's easy to tidy this up. This also lets us use the macro to replace the hand-rolled VMSTATE_PTIMER. Si

[Qemu-devel] [PATCH 6/8] XBZRLE cache size should not be larger than guest memory size

2014-02-04 Thread Juan Quintela
From: Orit Wasserman Signed-off-by: Orit Wasserman Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration.c b/migration.c index 46a7305..25add6f 100644 --- a/migration.c +++ b/migration.c @@ -479,6

Re: [Qemu-devel] [PATCH V15 06/13] quorum: Add quorum mechanism.

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: > From: Benoît Canet > > Use gnutls's SHA-256 to compare versions. > > Signed-off-by: Benoit Canet > --- > block/Makefile.objs | 2 +- > block/quorum.c| 386 > +- > configure

Re: [Qemu-devel] [PATCH V15 09/13] quorum: Add quorum_co_get_block_status.

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: > From: Benoît Canet > > Signed-off-by: Benoit Canet > Reviewed-by: Max Reitz > --- > block/quorum.c | 51 +++ > 1 file changed, 51 insertions(+) > > diff --git a/block/quorum.c b/block/quorum

[Qemu-devel] [PATCH 7/8] Don't abort on out of memory when creating page cache

2014-02-04 Thread Juan Quintela
From: Orit Wasserman Signed-off-by: Orit Wasserman Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- arch_init.c | 18 -- page_cache.c | 18 ++ 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5

Re: [Qemu-devel] [PATCH 7/8] Don't abort on memory allocation error

2014-02-04 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > From: Orit Wasserman > if (!it->it_data) { > cache->num_items++; > +it->it_data = g_try_malloc(cache->page_size); > +if (!it->it_data) { > +DPRINTF("Error allocating page\n"); > +return -1; > +

Re: [Qemu-devel] [PULL 0/8] migration queue

2014-02-04 Thread Juan Quintela
Juan Quintela wrote: > Hi > > This includes: > - Peter changes to make VMSTATE_STRUCT_POINTER more consistent > - Fix migration with hpratio (ppc on ppc64 basically) > - Orit/Arei cleanups/fixes to xbzrle > > Thanks, please apply. NACK myself. It has the wrong patch series from Orit. Sorry, and

Re: [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr

2014-02-04 Thread Michael Walle
Am 2014-02-03 23:59, schrieb Peter Maydell: On 3 February 2014 22:39, Michael Walle wrote: Am 2014-02-01 21:31, schrieb Michael Walle: Am Samstag, 1. Februar 2014, 19:00:01 schrieb Peter Maydell: On 20 January 2014 19:34, Michael Walle wrote: > Do not use qemu_log(). > > Signed-off-by: Mic

Re: [Qemu-devel] [PULL v2 00/24] QOM devices patch queue 2013-12-24

2014-02-04 Thread Michael S. Tsirkin
On Tue, Feb 04, 2014 at 04:56:53PM +0100, Andreas Färber wrote: > Michael, > > Am 24.12.2013 18:04, schrieb Andreas Färber: > > P.S. I reproducibly get a signal message: > > TEST: tests/acpi-test... (pid=6364) > > /i386/acpi/tcg: > > main-loo

[Qemu-devel] [PATCH] qtest: don't report signals if qtest driver enabled

2014-02-04 Thread Michael S. Tsirkin
qtest driver always uses signals to kill qemu no need to report it, whatever the accelerator state. Add API to detect qtest driver, and suppress reporting signals in this case. Reported-by: Andreas Färber Signed-off-by: Michael S. Tsirkin --- include/sysemu/qtest.h | 2 ++ qtest.c

Re: [Qemu-devel] Commit 9e047b982452c633882b486682966c1d97097015 (piix4: add acpi pci hotplug support) seems to break Xen pci-passthrough

2014-02-04 Thread Igor Mammedov
On Tue, 4 Feb 2014 16:07:08 +0100 Sander Eikelenboom wrote: > > Tuesday, February 4, 2014, 3:32:19 PM, you wrote: > > > On Tue, Feb 04, 2014 at 12:46:08AM +0100, Sander Eikelenboom wrote: > >> Grmbll my fat fingers hit the send shortcut too soon by accident .. > >> let's try again .. > >> > >>

Re: [Qemu-devel] kvm control qemu-system-aarch64 state

2014-02-04 Thread Peter Maydell
On 4 February 2014 16:37, Claudio Fontana wrote: > On 4 February 2014 16:39, Peter Maydell wrote: >> On 4 February 2014 15:36, Claudio Fontana wrote: >> > I just wanted to ask what is the current state of kvm control for >> > qemu-system-aarch64. >> > I tried latest mainline but I think it's not

Re: [Qemu-devel] [PULL v2 00/24] QOM devices patch queue 2013-12-24

2014-02-04 Thread Andreas Färber
Michael, Am 24.12.2013 18:04, schrieb Andreas Färber: > P.S. I reproducibly get a signal message: > TEST: tests/acpi-test... (pid=6364) > /i386/acpi/tcg: > main-loop: WARNING: I/O thread spun for 1000 iterations > qemu: terminating on signal

Re: [Qemu-devel] [PULL v2 00/24] QOM devices patch queue 2013-12-24

2014-02-04 Thread Michael S. Tsirkin
On Tue, Feb 04, 2014 at 04:56:53PM +0100, Andreas Färber wrote: > Michael, > > Am 24.12.2013 18:04, schrieb Andreas Färber: > > P.S. I reproducibly get a signal message: > > TEST: tests/acpi-test... (pid=6364) > > /i386/acpi/tcg: > > main-loo

Re: [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size

2014-02-04 Thread Orit Wasserman
On 02/04/2014 06:26 PM, Eric Blake wrote: On 02/04/2014 08:19 AM, Juan Quintela wrote: From: Orit Wasserman Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration.c b/migration.c index 46a7305..25add6

Re: [Qemu-devel] [PATCH 0/2] Use g_new() & friends where that makes obvious sense

2014-02-04 Thread Paolo Bonzini
Il 04/02/2014 17:52, Markus Armbruster ha scritto: Unfortunately, our use of macros confuses coccinelle sufficiently to miss quite a few instances of the patterns. Do we want this change anyway? Yes, we already use g_new anyway. Paolo

Re: [Qemu-devel] QEMU-Based Android Emulator

2014-02-04 Thread Marinos Tsantekidis
Maybe I'm not specific enough. I built Android from the source code and I know that the Android Emulator that comes with it, is based on QEMU. I don't want anything from Android. What I'm interested in is the underlying QEMU. I want to see how the program counter changes during translation. To my u

Re: [Qemu-devel] [BUGFIX][PATCH v2] configure: Disable libtool if -fPIE does not work with it (bug #1257099)

2014-02-04 Thread Paolo Bonzini
Il 03/02/2014 12:59, Stefano Stabellini ha scritto: I'm applying this to a "configure" branch on my github repository. Thanks! Paolo, did this patch ever make it upstream? If so, do you have a commit id? It's still in my branch, where it is commit fcfd805b. As soon as I get a go/no-go for

Re: [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size

2014-02-04 Thread Eric Blake
On 02/04/2014 08:19 AM, Juan Quintela wrote: > From: Orit Wasserman > > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > migration.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/migration.c b/migration.c > index 46a7305..25add6f 100644 > --- a/migration.

Re: [Qemu-devel] [BUGFIX][PATCH v2] configure: Disable libtool if -fPIE does not work with it (bug #1257099)

2014-02-04 Thread Stefano Stabellini
On Tue, 4 Feb 2014, Paolo Bonzini wrote: > Il 03/02/2014 12:59, Stefano Stabellini ha scritto: > > > I'm applying this to a "configure" branch on my github repository. > > > Thanks! > > > > Paolo, did this patch ever make it upstream? If so, do you have a commit > > id? > > It's still in my branc

  1   2   >