Re: [Qemu-devel] [PATCH] Revert "memory: syncronize kvm bitmap using bitmaps operations"

2014-01-28 Thread Paolo Bonzini
Il 29/01/2014 06:50, Alexey Kardashevskiy ha scritto: Since 64K system page size is quite popular configuration on PPC64, the original patch breaks migration. Signed-off-by: Alexey Kardashevskiy --- include/exec/ram_addr.h | 54 + 1 file changed,

[Qemu-devel] [PATCH] Revert "memory: syncronize kvm bitmap using bitmaps operations"

2014-01-28 Thread Alexey Kardashevskiy
This reverts commit ae2810c4bb3b383176e8e1b33931b16c01483aab. This reverts the optimization introduced by the original patch as it breaks dirty page tracking on systems where getpagesize() != TARGET_PAGE_SIZE such as POWERPC64. The cpu_physical_memory_set_dirty_lebitmap() is called from the kvm_p

[Qemu-devel] [PATCH v13 02/14] block: Introduce op_blockers to BlockDriverState

2014-01-28 Thread Fam Zheng
BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX elements. Each list is a list of blockers of an operation type (BlockOpType), that marks this BDS as currently blocked for a certain type of operation with reason errors stored in the list. The rule of usage is: * BDS user w

[Qemu-devel] [PATCH v13 11/14] block: Allow backup on referenced named BlockDriverState

2014-01-28 Thread Fam Zheng
Drive backup is a read only operation on source bs. We want to allow this specific case to enable image-fleecing. Note that when image-fleecing job starts, the job still add its blocker to source bs, and any other operation on it will be blocked by that. Signed-off-by: Fam Zheng --- block.c | 2

[Qemu-devel] [PATCH v13 14/14] qemu-iotests: Image fleecing test case 081

2014-01-28 Thread Fam Zheng
This tests the workflow of creating a lightweight point-in-time snapshot with blockdev-backup command and export it with built-in NBD server. It's tested that after the snapshot it created, writing to the original device doesn't change data that can be read from target with NBD. Signed-off-by: Fa

[Qemu-devel] [PATCH v13 09/14] stream: Use bdrv_drop_intermediate and drop close_unused_images

2014-01-28 Thread Fam Zheng
This reuses the new bdrv_drop_intermediate. Signed-off-by: Fam Zheng --- block/stream.c | 30 +- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/block/stream.c b/block/stream.c index dd0b4ac..9cdcf0e 100644 --- a/block/stream.c +++ b/block/stream.c @@ -5

[Qemu-devel] [PATCH v13 13/14] qemu-iotests: Test blockdev-backup in 055

2014-01-28 Thread Fam Zheng
This applies cases on drive-backup on blockdev-backup, except cases with target format and mode. Also add a case to check source == target. Signed-off-by: Fam Zheng --- tests/qemu-iotests/055 | 275 ++--- tests/qemu-iotests/055.out | 4 +- 2 files c

[Qemu-devel] [PATCH v13 12/14] block: Add blockdev-backup to transaction

2014-01-28 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c | 48 qapi-schema.json | 1 + 2 files changed, 49 insertions(+) diff --git a/blockdev.c b/blockdev.c index b346cc1..7372721 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1382,6 +1382,49 @@ static void

[Qemu-devel] [PATCH v13 10/14] qmp: Add command 'blockdev-backup'

2014-01-28 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible but is an illegal case with introduction of

[Qemu-devel] [PATCH v13 06/14] block: Add backing_blocker in BlockDriverState

2014-01-28 Thread Fam Zheng
This makes use of op_blocker and blocks all the operations except for commit target, on each BlockDriverState->backing_hd. The asserts for op_blocker in bdrv_swap are removed because with this change, the target of block commit has at least the backing blocker of its child, so the assertion is not

[Qemu-devel] [PATCH v13 05/14] block: Add bdrv_set_backing_hd()

2014-01-28 Thread Fam Zheng
This is the common but non-trivial steps to assign or change the backing_hd of BDS. Signed-off-by: Fam Zheng --- block.c | 34 +- include/block/block.h | 1 + 2 files changed, 26 insertions(+), 9 deletions(-) diff --git a/block.c b/block.c index 80

[Qemu-devel] [PATCH v13 08/14] block: Support dropping active in bdrv_drop_intermediate

2014-01-28 Thread Fam Zheng
Dropping intermediate could be useful both for commit and stream, and BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs to work with op blockers. Signed-off-by: Fam Zheng --- block.c| 146 + block/commit.c |

[Qemu-devel] [PATCH v13 07/14] block: Parse "backing" option to reference existing BDS

2014-01-28 Thread Fam Zheng
Now it's safe to allow reference for backing_hd in the interface. Signed-off-by: Fam Zheng --- block.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 4e3b393..9d57223 100644 --- a/block.c +++ b/block.c @@ -1392,12 +1392,34

[Qemu-devel] [PATCH v13 04/14] block: Move op_blocker check from block_job_create to its caller

2014-01-28 Thread Fam Zheng
It makes no sense to check for "any" blocker on bs, we are here only because of the mechanical conversion from in_use to op_blockers. Remove it now, and let the callers check specific operation types. Backup and mirror already have it, add checker to stream and commit. Signed-off-by: Fam Zheng --

[Qemu-devel] [PATCH v13 03/14] block: Replace in_use with operation blocker

2014-01-28 Thread Fam Zheng
This drops BlockDriverState.in_use with op_blockers: - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). - Check bdrv_op_is_blocked() in place of bdrv_in_use(bs). The specific types are used, e.g. in place of startin

[Qemu-devel] [PATCH v13 01/14] block: Add BlockOpType enum

2014-01-28 Thread Fam Zheng
This adds the enum of all the operations that can be taken on a block device. Signed-off-by: Fam Zheng --- include/block/block.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/block/block.h b/include/block/block.h index 963a61f..9626650 100644 --- a/include/bloc

[Qemu-devel] [PATCH v13 00/14] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-01-28 Thread Fam Zheng
This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup with existing device as target). We get a thin point-in-time snapshot by COW mechanism of drive-backup, and export it through built in NBD server. The steps are as below: 1. (SHELL) qemu-i

[Qemu-devel] How to mount, install and/or otherwise use an ARM Zero Client image wi th Qemu in Windows

2014-01-28 Thread xan...@juno.com
Hi all, I apologize in advance about my lack of intelligence on this matter, but I am urgently trying to figure out how to get Qemu to work under Windows for mounting and using a Linux-based natively ARM CPU design image to work. I have tried the windows installers and "DIY" version here: http

Re: [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-01-28 Thread Fam Zheng
On Tue, 01/28 15:31, Stefan Hajnoczi wrote: > On Mon, Jan 27, 2014 at 11:48:06AM +0800, Fam Zheng wrote: > > This series adds for point-in-time snapshot NBD exporting based on > > blockdev-backup (variant of drive-backup with existing device as target). > > > > We get a thin point-in-time snapshot

[Qemu-devel] [Bug 1273944] Re: multiboot header has 0 in mem_upper field

2014-01-28 Thread Peter Chubb
This change fixes it. diff --git a/exec.c b/exec.c index 2435d9e..b387d28 100644 --- a/exec.c +++ b/exec.c @@ -1070,7 +1070,7 @@ static void *file_ram_alloc(RAMBlock *block, } /* MAP_POPULATE silently ignores failures */ -for (i = 0; i < (memory/hpagesize); i++) { +

[Qemu-devel] [Bug 1273944] [NEW] multiboot header has 0 in mem_upper field

2014-01-28 Thread Peter Chubb
Public bug reported: When booting a multiboot image,. mem_upper is now always zero. To test, build qemu from current git head, then do cd tests/multiboot ./run_test.sh You will see the test fail. In each case mem_upper is 0k. git-bisect says the bad commit is 0169c511554cb0014a00290b0d3d26

Re: [Qemu-devel] osx bootloader

2014-01-28 Thread Gabriel L. Somlo
On Tue, Jan 28, 2014 at 11:51:25PM +0100, BALATON Zoltan wrote: > Here are some pages that might help enlightening the boot process: > > https://developer.apple.com/library/mac/documentation/Darwin/Conceptual/KernelProgramming/booting/booting.html > http://homepage.ntlworld.com/jonathan.deboynepol

Re: [Qemu-devel] [PATCH v8 08/13] dump: add API to write dump header

2014-01-28 Thread Qiao Nuohan
On 01/28/2014 09:37 PM, Laszlo Ersek wrote: I seem to recall that Qiao Nuohan stated that he (*) couldn't test this feature on any other architecture than i686/x86_64. So my proposal is, let's not block the series based on just this one point. Let's review it and allow it to be merged (if there

Re: [Qemu-devel] osx bootloader

2014-01-28 Thread BALATON Zoltan
On Tue, 28 Jan 2014, Gabriel L. Somlo wrote: BTW, when you say "use Apple's EFI bootloader" what do you mean ? Is that some piece of software we'd have to download and build, like Chameleon? Or would TianoCore in theory be capable of doing what the Apple EFI Bios does and load XNU from the hard

Re: [Qemu-devel] [PATCH 14/21] target-arm: A64: Implement remaining integer scalar-3-same insns

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > Implement the remaining integer instructions in the scalar-three-reg-same > group: SQADD, UQADD, SQSUB, UQSUB, SQSHL, UQSHL, SQRSHL, UQRSHL, > SQDMULH, SQRDMULH. > > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 106 > ++

Re: [Qemu-devel] [PATCH 21/21] target-arm: A64: Add FNEG and FABS to the SIMD 2-reg-misc group

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > Add the SIMD FNEG and FABS instructions in the SIMD 2-reg-misc group. > > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 23 --- > 1 file changed, 20 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderso

Re: [Qemu-devel] [PATCH 20/21] target-arm: A64: Add 2-reg-misc REV* instructions

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > +int elements = dsize / esize; > +int i; > +TCGv_i64 tcg_rd_hi, tcg_rd, tcg_rn; > + > +if (opsz >= 3) { > +unallocated_encoding(s); > +return; > +} > + > +tcg_rn = tcg_temp_new_i64(); > +tcg_rd = tcg_const_i6

Re: [Qemu-devel] [PATCH 19/21] target-arm: A64: Add narrowing 2-reg-misc instructions

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > Add the narrowing integer instructions in the 2-reg-misc class. > > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 85 > -- > 1 file changed, 83 insertions(+), 2 deletions(-) Reviewed-

[Qemu-devel] osx bootloader

2014-01-28 Thread Gabriel L. Somlo
On Sat, Jan 25, 2014 at 10:08:37AM +0100, Alexander Graf wrote: > > Once I finish trying all versions of OSX against all combinations > > of piix vs. q35 and up vs. smp, I'll give the Chameleon source a > > closer look: ultimately, it would be nice if we had something > > Chameleon-like that could

[Qemu-devel] [PATCH v5 6/8] vmstate: Add uint32 2D-array support

2014-01-28 Thread Christoffer Dall
Add support for saving VMState of 2D arrays of uint32 values. Reviewed-by: Peter Maydell Signed-off-by: Christoffer Dall --- include/migration/vmstate.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index be193ba..a106d51 100

[Qemu-devel] [PATCH v5 8/8] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2014-01-28 Thread Christoffer Dall
Save and restore the ARM KVM VGIC state from the kernel. We rely on QEMU to marshal the GICState data structure and therefore simply synchronize the kernel state with the QEMU emulated state in both directions. We take some care on the restore path to check the VGIC has been configured with enoug

[Qemu-devel] [PATCH v5 7/8] arm_gic: Add GICC_APRn state to the GICState

2014-01-28 Thread Christoffer Dall
The GICC_APRn registers are not currently supported by the ARM GIC v2.0 emulation. This patch adds the missing state. Note that we also change the number of APRs to use a define GIC_NR_APRS based on the maximum number of preemption levels. This patch also adds RAZ/WI accessors for the four regis

[Qemu-devel] [PATCH v5 5/8] arm_gic: Support setting/getting binary point reg

2014-01-28 Thread Christoffer Dall
Add a binary_point field to the gic emulation structure and support setting/getting this register now when we have it. We don't actually support interrupt grouping yet, oh well. Reviewed-by: Peter Maydell Signed-off-by: Christoffer Dall --- Changes [v2 -> v3]: - Treat writes for GIC prior to v

[Qemu-devel] [PATCH v5 2/8] arm_gic: Fix GICD_ICPENDR and GICD_ISPENDR writes

2014-01-28 Thread Christoffer Dall
Fix two bugs that would allow changing the state of SGIs through the ICPENDR and ISPENDRs. Signed-off-by: Christoffer Dall --- Changes [v1 -> v5]: - New patch in series hw/intc/arm_gic.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gi

[Qemu-devel] [PATCH v5 4/8] hw: arm_gic: Keep track of SGI sources

2014-01-28 Thread Christoffer Dall
Right now the arm gic emulation doesn't keep track of the source of an SGI (which apparently Linux guests don't use, or they're fine with assuming CPU 0 always). Add the necessary matrix on the GICState structure and maintain the data when setting and clearing the pending state of an IRQ and make

[Qemu-devel] [PATCH v5 3/8] arm_gic: Fix GIC pending behavior

2014-01-28 Thread Christoffer Dall
The existing implementation of the pending behavior in gic_set_irq, gic_acknowledge_irq, gic_complete_irq, and the distributor pending set/clear registers does not follow the semantics of the GICv2.0 specs, but may implement the 11MPCore support. Therefore, maintain the existing semantics for 11MP

[Qemu-devel] [PATCH v5 1/8] arm_gic: Introduce define for GIC_NR_SGIS

2014-01-28 Thread Christoffer Dall
Instead of hardcoding 16 various places in the code, use a define to make it more clear what is going on. Signed-off-by: Christoffer Dall --- Changes [v1 -> v5]: - New patch in series hw/intc/arm_gic.c| 17 +++-- include/hw/intc/arm_gic_common.h | 1 + 2 files chan

[Qemu-devel] [PATCH v5 0/8] Support arm-gic-kvm save/restore

2014-01-28 Thread Christoffer Dall
Implement support to save/restore the ARM KVM VGIC state from the kernel. The basic appraoch is to transfer state from the in-kernel VGIC to the emulated arm-gic state representation and let the standard QEMU vmstate save/restore handle saving the arm-gic state. Restore works by reversing the pro

[Qemu-devel] [PATCH v4 4/4] arm: vgic device control api support

2014-01-28 Thread Christoffer Dall
Support creating the ARM vgic device through the device control API and setting the base address for the distributor and cpu interfaces in KVM VMs using this API. Because the older KVM_CREATE_IRQCHIP interface needs the irq chip to be created prior to creating the VCPUs, we first test if we can us

[Qemu-devel] [PATCH v4 3/4] kvm: Common device control API functions

2014-01-28 Thread Christoffer Dall
Introduces two simple functions: int kvm_device_ioctl(int fd, int type, ...); int kvm_create_device(KVMState *s, uint64_t type, bool test); These functions wrap the basic ioctl-based interactions with KVM in a way similar to other KVM ioctl wrappers. Reviewed-by: Peter Maydell Signed-off

[Qemu-devel] [PATCH v4 2/4] kvm: Introduce kvm_arch_irqchip_create

2014-01-28 Thread Christoffer Dall
Introduce kvm_arch_irqchip_create an arch-specific hook in preparation for architecture-specific use of the device control API to create IRQ chips. Following patches will implement the ARM irqchip create method to prefer the device control API over the older KVM_CREATE_IRQCHIP API. Reviewed-by: P

[Qemu-devel] [PATCH v4 1/4] linux-headers: Update from Linus' master ba635f8

2014-01-28 Thread Christoffer Dall
Update to upstream commit ba635f8cd20ebc7bddf1eb8e1f4eae28a034e916 Signed-off-by: Christoffer Dall --- linux-headers/asm-arm/kvm.h| 28 linux-headers/asm-arm64/kvm.h | 21 - linux-headers/asm-x86/hyperv.h | 13 + linux-headers/lin

[Qemu-devel] [PATCH v4 0/4] Create ARM KVM VGIC with device control API

2014-01-28 Thread Christoffer Dall
This patch series adds generic support for issuing device control related ioctls and supports creating the ARM KVM-accelerated VGIC using the device control API while maintaining backwards compatibility for older kernels. Changelogs in the individual patches. The patch series based on qemu/master

Re: [Qemu-devel] [PATCH] seccomp: add timerfd_create and timerfd_settime to the whitelist

2014-01-28 Thread Eduardo Otubo
On 01/28/2014 04:03 PM, Felix Geyer wrote: On 28.01.2014 14:00, Eduardo Otubo wrote: On 01/26/2014 10:21 AM, Felix Geyer wrote: libusb calls timerfd_create() and timerfd_settime() when it's built with timerfd support. Command to reproduce: qemu -sandbox on -monitor stdio -device piix3-usb-u

Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: Add SIMD three-different ABDL instructions

2014-01-28 Thread Peter Maydell
On 26 January 2014 19:24, Peter Maydell wrote: > Implement the absolute-difference instructions in the SIMD > three-different group: SABAL, SABAL2, UABAL, UABAL2, SABDL, > SABDL2, UABDL, UABDL2. > > Signed-off-by: Peter Maydell > Reviewed-by: Richard Henderson Just a note that if anybody's doin

Re: [Qemu-devel] [PATCH 2/3] Add 'namethreads' suboption to --name

2014-01-28 Thread Michael S. Tsirkin
On Tue, Jan 28, 2014 at 06:09:06PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Tue, Jan 28, 2014 at 03:20:38PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Add flag storage to qemu-thread-* to stor

Re: [Qemu-devel] [PATCH v4 1/3] util/fifo8: implement push/pop of multiple bytes

2014-01-28 Thread Beniamino Galvani
On Tue, Jan 28, 2014 at 10:43:28AM +, Peter Maydell wrote: > On 28 January 2014 00:04, Peter Crosthwaite > wrote: > > On Tue, Jan 28, 2014 at 4:32 AM, Peter Maydell > > wrote: > >>> void fifo8_reset(Fifo8 *fifo) > >>> { > >>> fifo->num = 0; > >>> +fifo->head = 0; > >> > >> This is

Re: [Qemu-devel] [PATCH v4 1/3] util/fifo8: implement push/pop of multiple bytes

2014-01-28 Thread Beniamino Galvani
On Tue, Jan 28, 2014 at 10:04:09AM +1000, Peter Crosthwaite wrote: > On Tue, Jan 28, 2014 at 4:32 AM, Peter Maydell > wrote: > > On 26 January 2014 21:39, Beniamino Galvani wrote: > >> In some circumstances it is useful to be able to push the entire > >> content of a memory buffer to the fifo or

Re: [Qemu-devel] [PATCH 11/21] target-arm: A64: Implement pairwise integer ops from 3-reg-same SIMD

2014-01-28 Thread Peter Maydell
On 28 January 2014 17:21, Richard Henderson wrote: > On 01/26/2014 11:25 AM, Peter Maydell wrote: >> +/* Helper functions for pairwise 32 bit comparisons */ >> +static void gen_pmax_s32(TCGv_i32 res, TCGv_i32 op1, TCGv_i32 op2) >> +{ >> +tcg_gen_movcond_i32(TCG_COND_GE, res, op1, op2, op1, op2

Re: [Qemu-devel] [PATCH 07/24] target-arm: A64: Make cache ID registers visible to AArch64

2014-01-28 Thread Peter Maydell
On 28 January 2014 18:12, Peter Maydell wrote: > typedef enum CPAccessResult { > /* Access is permitted */ > CP_ACCESS_OK = 0, > /* Access fails due to a configurable trap or enable which would > * result in an exception syndrome other than 'uncategorized' > */ > CP_ACCES

Re: [Qemu-devel] [PATCH 07/24] target-arm: A64: Make cache ID registers visible to AArch64

2014-01-28 Thread Peter Maydell
On 28 January 2014 14:05, Peter Crosthwaite wrote: > On Tue, Jan 28, 2014 at 6:45 PM, Peter Maydell > wrote: >> On 28 January 2014 01:46, Peter Crosthwaite >> wrote: >>> There seem to be multiple instances in this series where you fallback >>> to open coded R/W accessor functions for the sake o

Re: [Qemu-devel] [PATCH 2/3] Add 'namethreads' suboption to --name

2014-01-28 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Jan 28, 2014 at 03:20:38PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Add flag storage to qemu-thread-* to store the namethreads flag > > > > Signed-off-by: Dr. David Alan Gilbert > > How about a

Re: [Qemu-devel] [PATCH] seccomp: add timerfd_create and timerfd_settime to the whitelist

2014-01-28 Thread Felix Geyer
On 28.01.2014 14:00, Eduardo Otubo wrote: > On 01/26/2014 10:21 AM, Felix Geyer wrote: >> libusb calls timerfd_create() and timerfd_settime() when it's built with >> timerfd support. >> >> Command to reproduce: >> >> qemu -sandbox on -monitor stdio -device piix3-usb-uhci,id=usb >> -device usb

Re: [Qemu-devel] [PATCH 2/3] Add 'namethreads' suboption to --name

2014-01-28 Thread Michael S. Tsirkin
On Tue, Jan 28, 2014 at 03:20:38PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add flag storage to qemu-thread-* to store the namethreads flag > > Signed-off-by: Dr. David Alan Gilbert How about a pattern? threads='vmfoo-%s' and have qemu fill in specific s

Re: [Qemu-devel] [PULL 3/5] add optional 2nd stage initialization to -object/object-add commands

2014-01-28 Thread Luiz Capitulino
On Tue, 28 Jan 2014 10:34:56 -0700 Eric Blake wrote: > On 01/28/2014 10:27 AM, Luiz Capitulino wrote: > > From: Igor Mammedov > > > > Introduces USER_CREATABLE interface that must be implemented by > > objects which are designed to created with -object CLI option or > > object-add QMP command.

Re: [Qemu-devel] [PATCH 18/21] target-arm: A64: Implement 2-reg-misc CNT, NOT and RBIT

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > Implement the 2-reg-misc CNT, NOT and RBIT instructions. > > Signed-off-by: Peter Maydell > --- > target-arm/helper.h| 1 + > target-arm/neon_helper.c | 12 > target-arm/translate-a64.c | 34 --

Re: [Qemu-devel] [PATCH 15/21] target-arm: A64: Add SIMD simple 64 bit insns from scalar 2-reg misc

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > +do_cmop: > +tcg_gen_setcondi_i64(tcg_invert_cond(cond), tcg_rd, tcg_rn, 0); > +tcg_gen_subi_i64(tcg_rd, tcg_rd, 1); > +break; Another instance of (!test - 1) instead of -(test). Otherwise, Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH 17/21] target-arm: A64: Implement 2-register misc compares, ABS, NEG

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > Implement the simple 2-register-misc operations we can share > with the scalar-two-register-misc code. (SUQADD, USQADD, SQABS, > SQNEG also fall into this category, but aren't implemented in > the scalar-2-register case yet either.) > > Signed-off-by:

Re: [Qemu-devel] [PATCH 16/21] target-arm: A64: Add skeleton decode for SIMD 2-reg misc group

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > Add a skeleton decode for the SIMD 2-reg misc group. > > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 110 > - > 1 file changed, 109 insertions(+), 1 deletion(-) Reviewed-by: Richard

Re: [Qemu-devel] [PULL 3/5] add optional 2nd stage initialization to -object/object-add commands

2014-01-28 Thread Eric Blake
On 01/28/2014 10:27 AM, Luiz Capitulino wrote: > From: Igor Mammedov > > Introduces USER_CREATABLE interface that must be implemented by > objects which are designed to created with -object CLI option or > object-add QMP command. > > +/** > + * UserCreatableClass: > + * @parent_class: the base

Re: [Qemu-devel] [PATCH 13/21] target-arm: A64: Implement scalar pairwise ops

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > Implement the instructions in the scalar pairwise group (C3.6.8). > > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 114 > - > 1 file changed, 113 insertions(+), 1 deletion(-) Review

[Qemu-devel] [PULL 2/5] vl.c: -object: don't ignore duplicate 'id'

2014-01-28 Thread Luiz Capitulino
From: Igor Mammedov object_property_add_child() may fail if 'id' matches an already existing object. Which means an incorrect command line. So instead of silently ignoring error, report it and terminate QEMU. Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Si

[Qemu-devel] [PATCH v3] implementing victim TLB for QEMU system emulated TLB

2014-01-28 Thread Xin Tong
This patch adds a victim TLB to the QEMU system mode TLB. QEMU system mode page table walks are expensive. Taken by running QEMU qemu-system-x86_64 system mode on Intel PIN , a TLB miss and walking a 4-level page tables in guest Linux OS takes ~450 X86 instructions on average. QEMU system mode TL

[Qemu-devel] [PULL 4/5] virtio_rng: replace custom backend API with UserCreatable.complete() callback

2014-01-28 Thread Luiz Capitulino
From: Igor Mammedov in addition fix default backend leak by releasing it if its initialization failed. Signed-off-by: Igor Mammedov Reviewed-by: Stefan Hajnoczi Signed-off-by: Luiz Capitulino --- backends/rng.c | 12 ++-- hw/virtio/virtio-rng.c | 15 +-- include/s

[Qemu-devel] [PULL 3/5] add optional 2nd stage initialization to -object/object-add commands

2014-01-28 Thread Luiz Capitulino
From: Igor Mammedov Introduces USER_CREATABLE interface that must be implemented by objects which are designed to created with -object CLI option or object-add QMP command. Interface provides an ability to do an optional second stage initialization of the object created with -object/object-add c

[Qemu-devel] [PATCH V10 10/13] quorum: Add quorum_co_flush().

2014-01-28 Thread Benoît Canet
From: Benoît Canet Makes a vote to select error if any. Signed-off-by: Benoit Canet --- block/quorum.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 9b0718b..1b84b07 100644 --- a/block/quorum.c +++ b/block/quorum.c

[Qemu-devel] [PULL 0/5] QMP queue

2014-01-28 Thread Luiz Capitulino
The changes (since 0169c511554cb0014a00290b0d3d26c31a49818f) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Igor Mammedov (4): object_add: consolidate error handling vl.c: -object: don't ignore duplicate 'id' add optional 2nd stage initializa

[Qemu-devel] [PULL 5/5] monitor: Cleanup mon->outbuf on write error

2014-01-28 Thread Luiz Capitulino
From: Stratos Psomadakis In case monitor_flush() fails to write the contents of mon->outbuf to the output device, mon->outbuf is not cleaned up properly. Check the return code of the qemu_chr_fe_write() function and cleanup the outbuf if it fails. References: http://lists.nongnu.org/archive/htm

[Qemu-devel] [PULL 1/5] object_add: consolidate error handling

2014-01-28 Thread Luiz Capitulino
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Stefan Hajnoczi Signed-off-by: Luiz Capitulino --- qmp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/qmp.c b/qmp.c index 0f46171..a67e0c4 100644 --- a/qmp.c +++ b/qmp.c @@ -549,15 +549,17 @@ void

Re: [Qemu-devel] [PATCH 12/21] tcg: Add TCGV_UNUSED_PTR, TCGV_IS_UNUSED_PTR, TCGV_EQUAL_PTR

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > We have macros for marking TCGv values as unused, checking if they > are unused and comparing them to each other. However these only exist > for TCGv_i32 and TCGv_i64; add them for TCGv_ptr as well. > > Signed-off-by: Peter Maydell > --- > tcg/tcg.h

Re: [Qemu-devel] [PATCH 11/21] target-arm: A64: Implement pairwise integer ops from 3-reg-same SIMD

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > +/* Helper functions for pairwise 32 bit comparisons */ > +static void gen_pmax_s32(TCGv_i32 res, TCGv_i32 op1, TCGv_i32 op2) > +{ > +tcg_gen_movcond_i32(TCG_COND_GE, res, op1, op2, op1, op2); > +} > + > +static void gen_pmax_u32(TCGv_i32 res, TCGv

Re: [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-01-28 Thread Stefan Hajnoczi
On Mon, Jan 27, 2014 at 11:48:06AM +0800, Fam Zheng wrote: > This series adds for point-in-time snapshot NBD exporting based on > blockdev-backup (variant of drive-backup with existing device as target). > > We get a thin point-in-time snapshot by COW mechanism of drive-backup, and > export it thr

Re: [Qemu-devel] [PATCH 10/21] target-arm: A64: Implement remaining non-pairwise int SIMD 3-reg-same insns

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > @@ -6773,9 +6801,9 @@ static void disas_simd_3same_int(DisasContext *s, > uint32_t insn) > case 0x8: /* SSHL, USHL */ > { > static NeonGenTwoOpFn * const fns[3][2] = { > -{ gen_helper_neon

Re: [Qemu-devel] [PATCH 10/21] target-arm: A64: Implement remaining non-pairwise int SIMD 3-reg-same insns

2014-01-28 Thread Peter Maydell
On 28 January 2014 17:13, Richard Henderson wrote: > On 01/26/2014 11:25 AM, Peter Maydell wrote: >> @@ -6773,9 +6801,9 @@ static void disas_simd_3same_int(DisasContext *s, >> uint32_t insn) >> case 0x8: /* SSHL, USHL */ >> { >> static NeonGenTwoOpFn * c

Re: [Qemu-devel] [PATCH v12 05/11] block: Add bdrv_set_backing_hd()

2014-01-28 Thread Stefan Hajnoczi
On Mon, Jan 27, 2014 at 11:48:11AM +0800, Fam Zheng wrote: > +pstrcpy(bs->backing_file, sizeof(bs->backing_file), > backing_hd->filename); > +pstrcpy(bs->backing_format, sizeof(bs->backing_file), > +backing_hd->drv ? backing_hd->drv->format_name : ""); > +bdrv_ref(bs->backi

Re: [Qemu-devel] [PATCH 09/21] target-arm: A64: Implement SIMD 3-reg-same shift and saturate insns

2014-01-28 Thread Richard Henderson
On 01/26/2014 11:25 AM, Peter Maydell wrote: > Implement the SIMD 3-reg-same instructions SQADD, UQADD, > SQSUB, UQSUB, SSHL, USHL, SQSHl, UQSHL, SRSHL, URSHL, > SQRSHL, UQRSHL; these are all simple calls to existing > Neon helpers. We also enable SSHL, USHL, SRSHL and URSHL > for the 3-reg-same-sc

[Qemu-devel] [PATCH V10 06/13] quorum: Add quorum mechanism.

2014-01-28 Thread Benoît Canet
From: Benoît Canet Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet --- block/Makefile.objs | 2 +- block/quorum.c| 333 +- configure | 36 + docs/qmp/qmp-events.txt | 33 + include

Re: [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-01-28 Thread Ian Main
On Tue, Jan 28, 2014 at 03:31:36PM +0100, Stefan Hajnoczi wrote: > On Mon, Jan 27, 2014 at 11:48:06AM +0800, Fam Zheng wrote: > > This series adds for point-in-time snapshot NBD exporting based on > > blockdev-backup (variant of drive-backup with existing device as target). > > > > We get a thin p

[Qemu-devel] [PATCH V10 11/13] quorum: Implement recursive .bdrv_recurse_is_first_non_filter in quorum.

2014-01-28 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block/quorum.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 1b84b07..e7b2090 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -685,6 +685,23 @@ static coroutine_fn int quorum_

[Qemu-devel] [PATCH V10 13/13] quorum: Add unit test.

2014-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet --- tests/qemu-iotests/075 | 85 ++ tests/qemu-iotests/075.out | 27 +++ tests/qemu-iotests/group | 1 + 3 files changed, 113 insertions(+) create mode 100644 tests/qemu-iotests/075 create mode 100644 tes

[Qemu-devel] [PATCH V10 07/13] quorum: Add quorum_getlength().

2014-01-28 Thread Benoît Canet
From: Benoît Canet Check that every bs file returns the same length. Otherwize, return -EIO to disable the quorum and avoid length discrepancy. Signed-off-by: Benoit Canet --- block/quorum.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/block/quorum.c b/block/

[Qemu-devel] [PATCH V10 00/13] Quorum block driver

2014-01-28 Thread Benoît Canet
Here is the new version of the QUORUM block driver. It now use bdrv_image_open for using QMP references and support snapshotting via the bs node-name infrastructure. I think the series is feature complete. It applies on top of Max bdrv_openv2 branch. in v10 reference support thanks with Kevi

[Qemu-devel] [PATCH V10 09/13] quorum: Add quorum_co_get_block_status.

2014-01-28 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block/quorum.c | 67 ++ 1 file changed, 67 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index a47cd33..9b0718b 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -171,6 +17

[Qemu-devel] [PATCH V10 12/13] quorum: Add quorum_open() and quorum_close().

2014-01-28 Thread Benoît Canet
From: Benoît Canet Example of command line: -drive if=virtio,file.driver=quorum,\ file.children.0.file.filename=1.raw,\ file.children.0.node-name=1.raw,\ file.children.0.driver=raw,\ file.children.1.file.filename=2.raw,\ file.children.1.node-name=2.raw,\ file.children.1.driver=raw,\ file.children

[Qemu-devel] [PATCH V10 01/13] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2014-01-28 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block/Makefile.objs | 1 + block/quorum.c | 54 + 2 files changed, 55 insertions(+) create mode 100644 block/quorum.c diff --git a/block/Makefile.objs b/block/Makefile.objs index 4e8c9

[Qemu-devel] [PATCH V10 04/13] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2014-01-28 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block/blkverify.c | 108 +- include/qemu-common.h | 2 + util/iov.c| 103 +++ 3 files changed, 107 insertions(+), 106 deletions(-) di

[Qemu-devel] [PATCH V10 08/13] quorum: Add quorum_invalidate_cache().

2014-01-28 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block/quorum.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index a8a8492..a47cd33 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -577,6 +577,16 @@ static int64_t quorum_getlength(BlockDr

[Qemu-devel] [PATCH V10 03/13] quorum: Add quorum_aio_writev and its dependencies.

2014-01-28 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block/quorum.c | 123 + 1 file changed, 123 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 0242378..85992ab 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -64,11 +6

[Qemu-devel] [PATCH V10 05/13] quorum: Add quorum_aio_readv.

2014-01-28 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block/quorum.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 85992ab..5bf37b3 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -101,14 +101,

[Qemu-devel] [PATCH V10 02/13] quorum: Create BDRVQuorumState and BlkDriver and do init.

2014-01-28 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block/quorum.c | 25 + 1 file changed, 25 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 1695f04..0242378 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,16 @@ #include "block/block_in

Re: [Qemu-devel] OSX guest support review

2014-01-28 Thread Michael S. Tsirkin
On Tue, Jan 28, 2014 at 11:45:37AM -0500, Gabriel L. Somlo wrote: > On Tue, Jan 28, 2014 at 12:51:40AM +0100, Alexander Graf wrote: > > On 27.01.2014, at 23:51, Gabriel L. Somlo wrote: > > >- on Mavericks, the e1000 pci card doesn't work. In "System > > > Information", under "Hardware", I

Re: [Qemu-devel] OSX guest support review

2014-01-28 Thread Gabriel L. Somlo
On Tue, Jan 28, 2014 at 12:51:40AM +0100, Alexander Graf wrote: > On 27.01.2014, at 23:51, Gabriel L. Somlo wrote: > >- on Mavericks, the e1000 pci card doesn't work. In "System > > Information", under "Hardware", I get nothing under "Ethernet > > Cards", and "ethernet controller, pc

Re: [Qemu-devel] [PATCH 3/3] Add a 'name' parameter to qemu_thread_create

2014-01-28 Thread Michael S. Tsirkin
On Tue, Jan 28, 2014 at 04:12:44PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Tue, Jan 28, 2014 at 03:20:39PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > If enabled, set the thread name at creati

Re: [Qemu-devel] [PATCH 0/3] Name threads

2014-01-28 Thread Paolo Bonzini
Il 28/01/2014 17:31, Dr. David Alan Gilbert ha scritto: > I plead guilty to bikeshedding and propose s/namethreads/threads/. If I need to reroll anyway I'll change that; although I just suggested making it debug-thread in my reply to Michael to make it clear it wasn't an API. Even better. >

Re: [Qemu-devel] [PATCH 0/3] Name threads

2014-01-28 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 28/01/2014 16:20, Dr. David Alan Gilbert (git) ha scritto: > >From: "Dr. David Alan Gilbert" > > > >This series uses pthread_setname_np (when available) to set the names on > >threads that QEMU creates to make life easier when debugging. > > > >It'

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-28 Thread Christoffer Dall
On Tue, Jan 28, 2014 at 03:47:32PM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2014-01-27 at 16:44 -0800, Christoffer Dall wrote: > > > I'm loosing track of this discussion, Ben, can you explain a bit? You > > wrote: > > > > Having a byte array coming in that represents what the CPU does in

Re: [Qemu-devel] [PATCH 3/3] Add a 'name' parameter to qemu_thread_create

2014-01-28 Thread Laszlo Ersek
On 01/28/14 17:12, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: >> On Tue, Jan 28, 2014 at 03:20:39PM +, Dr. David Alan Gilbert (git) wrote: >>> From: "Dr. David Alan Gilbert" >>> >>> If enabled, set the thread name at creation (on GNU systems with >>> pthrea

Re: [Qemu-devel] [PATCH 3/3] Add a 'name' parameter to qemu_thread_create

2014-01-28 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Jan 28, 2014 at 03:20:39PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > If enabled, set the thread name at creation (on GNU systems with > > pthread_set_np) > > Fix up all the callers with a thread

Re: [Qemu-devel] [PATCH V5 00/10] qapi script: support enum as discriminator and better enum name

2014-01-28 Thread Luiz Capitulino
On Wed, 22 Jan 2014 11:07:24 -0500 Luiz Capitulino wrote: > On Fri, 20 Dec 2013 13:23:06 +0800 > Wenchao Xia wrote: > > > This series address two issues: > > > > 1. support using enum as discriminator in union. > > For example, if we have following define in qapi schema: > > { 'enum': 'EnumOne

Re: [Qemu-devel] [PULL v2 0/8] vfio pull request

2014-01-28 Thread Alex Williamson
I guess I should be addressing these to both Anthony and Peter now. Thanks for stepping in, Peter. Thanks, Alex On Tue, 2014-01-28 at 08:44 -0700, Alex Williamson wrote: > Anthony, > > My last vfio pull request didn't seem to make the most recent round of > merges. The only difference in this

  1   2   3   >