Re: [Qemu-devel] [PATCH] vmdk: Fix format specific information (create type) for streamOptimized

2014-01-23 Thread Fam Zheng
On Thu, 01/23 15:42, Kevin Wolf wrote: > Am 23.01.2014 um 08:10 hat Fam Zheng geschrieben: > > Previously the field is wrong: > > > > $ ./qemu-img create -f vmdk -o subformat=streamOptimized /tmp/a.vmdk 1G > > > > $ ./qemu-img info /tmp/a.vmdk > > image: /tmp/a.vmdk > > file forma

Re: [Qemu-devel] [PATCH RFC 5/5] xen: introduce xenpv-softmmu.mak

2014-01-23 Thread Paolo Bonzini
Il 23/01/2014 23:16, Wei Liu ha scritto: -echo "CONFIG_XEN_PCI_PASSTHROUGH=y" >> "$config_target_mak" +if test "$target_name" != "xenpv"; then +echo "CONFIG_XEN_I386=y" >> $config_target_mak +if test "$xen_pci_passthrough" = yes; then +echo "CONFIG_XEN_PCI_

Re: [Qemu-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-23 Thread Paolo Bonzini
Il 23/01/2014 23:16, Wei Liu ha scritto: As promised I hacked a prototype based on Paolo's disable TCG series. However I coded some stubs for TCG anyway. So this series in principle should work with / without Paolo's series. The first 3 patches refactor some code to disentangle Xen PV and HVM gu

Re: [Qemu-devel] [PATCH RFC 3/5] exec: guard Xen HVM hooks with CONFIG_XEN_I386

2014-01-23 Thread Paolo Bonzini
Il 23/01/2014 23:16, Wei Liu ha scritto: Those are only useful when building QEMU with HVM support. We need to expose CONFIG_XEN_I386 to source code so we modify configure and i386/x86_64-softmmu.mak. I think the right way is to add a xen-hvm-stub.c file and include it in xenpv-softmmu. Sin

Re: [Qemu-devel] [PATCH v2 00/42] rework input handling, sdl2 support

2014-01-23 Thread Gerd Hoffmann
> diff --git a/ui/cocoa.m b/ui/cocoa.m > index 146fb21..f20fd1f 100644 > --- a/ui/cocoa.m > +++ b/ui/cocoa.m > Signed-off-by: Peter Maydell Thanks. Yes, I plan quash the fixes in for bisectability. cheers, Gerd

[Qemu-devel] [PATCH] scsi: Change scsi sense buf size to 252

2014-01-23 Thread Fam Zheng
Current buffer size fails the assersion check in like hw/scsi/scsi-bus.c:1655:assert(req->sense_len <= sizeof(req->sense)); when backend (block/iscsi.c) returns more data then 96. Exercise the core dump path by booting an Gentoo ISO with scsi-generic device backed with iscsi (built with

Re: [Qemu-devel] [PATCH v2 3/6] configure: alphabetize output of --help and separate into groups

2014-01-23 Thread Stefan Weil
Am 24.01.2014 02:39, schrieb Stewart Smith: > This should make it (slightly) easier to discover configure options. > I've tried to separate out build options (e.g. gcov) from feature > options (such as gtk). > > Signed-off-by: Stewart Smith > --- > configure | 174 >

Re: [Qemu-devel] [PATCH v2 1/6] configure: add hint of libfdt to DTC dependency not found message

2014-01-23 Thread Stefan Weil
Am 24.01.2014 02:39, schrieb Stewart Smith: > Most distros package it as libfdt, and mentioning libfdt here makes it > much easier to find the package you're missing. > > Signed-off-by: Stewart Smith > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/

[Qemu-devel] [Bug 623852] Re: PPC emulation loops on booting a FreeBSD kernel

2014-01-23 Thread Stewart Smith
On 732c66ce641c69702a7e7fdb73b68f0c1b583ab5, I instead get: Welcome to OpenBIOS v1.1 built on Oct 2 2013 22:57 Trying cd:,\\:tbxi... Consoles: Open Firmware console FreeBSD/powerpc Open Firmware loader, Revision 0.1 (r...@xserve.lan.xcllnt.net, Sun Jul 18 04:50:11 UTC 2010) Memory: 96256KB Boo

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-23 Thread Victor Kamensky
On 23 January 2014 18:14, Christoffer Dall wrote: > On Thu, Jan 23, 2014 at 04:50:18PM -0800, Victor Kamensky wrote: >> On 23 January 2014 12:45, Christoffer Dall >> wrote: >> > On Thu, Jan 23, 2014 at 08:25:35AM -0800, Victor Kamensky wrote: >> >> On 23 January 2014 07:33, Peter Maydell wrote:

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-23 Thread Christoffer Dall
On Thu, Jan 23, 2014 at 04:50:18PM -0800, Victor Kamensky wrote: > On 23 January 2014 12:45, Christoffer Dall > wrote: > > On Thu, Jan 23, 2014 at 08:25:35AM -0800, Victor Kamensky wrote: > >> On 23 January 2014 07:33, Peter Maydell wrote: > >> > On 23 January 2014 15:06, Victor Kamensky > >>

[Qemu-devel] [PATCH v2 4/6] configure: add help for --disable-xfsctl and --enable-xfsctl

2014-01-23 Thread Stewart Smith
Previously undocumented configure options Signed-off-by: Stewart Smith --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index c225291..e607ebf 100755 --- a/configure +++ b/configure @@ -1252,6 +1252,8 @@ Advanced options, features (experts only): --ena

Re: [Qemu-devel] [PATCH 07/13 v7] dump: add members to DumpState and init some of them

2014-01-23 Thread Qiao Nuohan
On 01/23/2014 01:04 AM, Laszlo Ersek wrote: @@ -864,6 +884,16 @@ static int dump_init(DumpState *s, int fd, bool paging, bool has_filter, > qemu_get_guest_simple_memory_mapping(&s->list,&s->guest_phys_blocks); >} > > +s->nr_cpus = nr_cpus; > +s->page_size = TARGET_P

[Qemu-devel] [PATCH v2 6/6] configure: helpfully output package names for some missing dependencies.

2014-01-23 Thread Stewart Smith
This just makes it a tiny bit easier for new developers to get started by making it easy to see what package they need to install to get the dependency. Signed-off-by: Stewart Smith --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/configure b/config

[Qemu-devel] [PATCH v2 5/6] configure: add hints to a remedy for feature_not_found errors

2014-01-23 Thread Stewart Smith
Modify feature_not_found to accept an optional second parameter to be printed after the generic feature not found error. Modify most calls to feature_not_found to provide hints as to the packages that may be missing. The few calls remaining without a remedy are ones I couldn't work out how to reme

[Qemu-devel] [PATCH v2 0/6] configure: make output and errors more friendly

2014-01-23 Thread Stewart Smith
This expands on my previous patch which was just the "configure: helpfully output package names for some missing dependencies" patch. Based on feedback I've added a hint to the could not find DTC error message. There's also other changes that were suggested and the ordering of output from configu

[Qemu-devel] [PATCH v2 1/6] configure: add hint of libfdt to DTC dependency not found message

2014-01-23 Thread Stewart Smith
Most distros package it as libfdt, and mentioning libfdt here makes it much easier to find the package you're missing. Signed-off-by: Stewart Smith --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 3782a6a..8b6e64a 100755 --- a/conf

[Qemu-devel] [PATCH v2 2/6] configure: sort output of configure results alphabetically

2014-01-23 Thread Stewart Smith
Keep the paths and compiler/target details at the top, but sort all the yes/no features alphabetically, making it much easier to both browse through and to check if a feature you want has been enabled or not. Eyes can be faster than grep. Signed-off-by: Stewart Smith --- configure | 118

[Qemu-devel] [PATCH v2 3/6] configure: alphabetize output of --help and separate into groups

2014-01-23 Thread Stewart Smith
This should make it (slightly) easier to discover configure options. I've tried to separate out build options (e.g. gcov) from feature options (such as gtk). Signed-off-by: Stewart Smith --- configure | 174 -- 1 file changed, 89 insert

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-23 Thread Victor Kamensky
On 23 January 2014 12:45, Christoffer Dall wrote: > On Thu, Jan 23, 2014 at 08:25:35AM -0800, Victor Kamensky wrote: >> On 23 January 2014 07:33, Peter Maydell wrote: >> > On 23 January 2014 15:06, Victor Kamensky >> > wrote: >> >> In [1] I wrote >> >> >> >> "I don't see why you so attached to

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-23 Thread Victor Kamensky
On 23 January 2014 08:25, Victor Kamensky wrote: > On 23 January 2014 07:33, Peter Maydell wrote: >> On 23 January 2014 15:06, Victor Kamensky wrote: >>> In [1] I wrote >>> >>> "I don't see why you so attached to desire to describe >>> data part of memory transaction as just one of int >>> types

Re: [Qemu-devel] QEMU ARM946 emulation, DIGIC, and MPU fault handling

2014-01-23 Thread Peter Maydell
On 23 January 2014 23:36, Andreas Färber wrote: > Am 23.01.2014 23:25, schrieb Peter Maydell: >> This bug would also affect the ARMv7M CPU (Cortex-M3) we emulate, >> except that as far as I can tell we don't implement its MPU interface at all! >> (it uses memory mapped registers rather than cp15 r

Re: [Qemu-devel] QEMU ARM946 emulation, DIGIC, and MPU fault handling

2014-01-23 Thread Andreas Färber
Am 23.01.2014 23:25, schrieb Peter Maydell: > This bug would also affect the ARMv7M CPU (Cortex-M3) we emulate, > except that as far as I can tell we don't implement its MPU interface at all! > (it uses memory mapped registers rather than cp15 regs, and they just > aren't wired up in armv7m_nvic.c.

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-23 Thread Christoffer Dall
On Wed, Jan 22, 2014 at 02:27:29PM +0530, Anup Patel wrote: [...] > > Thanks for the info on QEMU side handling of MMIO data. > > I was not aware that we would be only have "target endian = LE" > for ARM/ARM64 in QEMU. I think Marc Z had mentioned similar > thing about MMIO this in our previous

Re: [Qemu-devel] [PATCH v4 2/3] block: resize backing image during active layer commit, if needed

2014-01-23 Thread Benoît Canet
Le Thursday 23 Jan 2014 à 17:45:08 (-0500), Jeff Cody a écrit : > If the top image to commit is the active layer, and also larger than > the base image, then an I/O error will likely be returned during > block-commit. > > For instance, if we have a base image with a virtual size 10G, and a > activ

[Qemu-devel] [PATCH v4 2/3] block: resize backing image during active layer commit, if needed

2014-01-23 Thread Jeff Cody
If the top image to commit is the active layer, and also larger than the base image, then an I/O error will likely be returned during block-commit. For instance, if we have a base image with a virtual size 10G, and a active layer image of size 20G, then committing the snapshot via 'block-commit' w

Re: [Qemu-devel] [PATCH 10/10] PPC: e500: Move to u-boot as firmware

2014-01-23 Thread Scott Wood
On Thu, 2014-01-23 at 11:40 +0100, Alexander Graf wrote: > On 23.01.2014, at 01:23, Scott Wood wrote: > > > On Mon, 2014-01-20 at 00:44 +0100, Alexander Graf wrote: > >> Almost all platforms QEMU emulates have some sort of firmware they can load > >> to expose a guest environment that closely res

Re: [Qemu-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-23 Thread Peter Maydell
On 23 January 2014 22:16, Wei Liu wrote: > As promised I hacked a prototype based on Paolo's disable TCG series. > However I coded some stubs for TCG anyway. So this series in principle > should work with / without Paolo's series. I'm afraid I still think this is a terrible idea. "Xen" isn't a CP

[Qemu-devel] [PATCH v4 1/3] block: resize backing file image during offline commit, if necessary

2014-01-23 Thread Jeff Cody
Currently, if an image file is logically larger than its backing file, committing it via 'qemu-img commit' will fail. For instance, if we have a base image with a virtual size 10G, and a snapshot image of size 20G, then committing the snapshot offline with 'qemu-img commit' will likely fail. This

[Qemu-devel] [PATCH v4 3/3] block: update block commit documentation regarding image truncation

2014-01-23 Thread Jeff Cody
This updates the documentation for commiting snapshot images. Specifically, this highlights what happens when the base image is either smaller or larger than the snapshot image being committed. In the case of the base image being smaller, it is resized to the larger size of the snapshot image. In

[Qemu-devel] [PATCH v4 0/3] block: commits of snapshots larger than backing files

2014-01-23 Thread Jeff Cody
Changes, v3->v4 Patch 1/3: Commit message typo (Eric) Patch 2/3: Removed dead code (Benoît) Patch 3/3: None Changes, v2->v3: Patch 1/3: None Patch 2/3: Set errp for both bdrv_getlength() failure cases (Fam) Remove "." from error message (Eric Blake) Patch 3/3: Removed spurious double

[Qemu-devel] QEMU ARM946 emulation, DIGIC, and MPU fault handling

2014-01-23 Thread Peter Maydell
Hi Antony; have you noticed any issues with QEMU's handling of MPU faults (data or address faults) on our ARM946 model? I ask because DIGIC is the only board we have that uses the 946, and as far as I can tell from the QEMU source code we will incorrectly trash the access permissions registers any

Re: [Qemu-devel] [PATCH v3 1/3] block: resize backing file image during offline commit, if necessary

2014-01-23 Thread Benoît Canet
Le Thursday 23 Jan 2014 à 15:07:44 (-0700), Eric Blake a écrit : > On 01/23/2014 03:00 PM, Benoît Canet wrote: > > Le Thursday 23 Jan 2014 à 16:48:55 (-0500), Jeff Cody a écrit : > >> Currently, if an image file is logically larger than its backing file, > >> commiting it via 'qemu-img commit' will

Re: [Qemu-devel] [PATCH v3 2/3] block: resize backing image during active layer commit, if needed

2014-01-23 Thread Jeff Cody
On Thu, Jan 23, 2014 at 11:05:26PM +0100, Benoît Canet wrote: > Le Thursday 23 Jan 2014 à 16:48:56 (-0500), Jeff Cody a écrit : > > If the top image to commit is the active layer, and also larger than > > the base image, then an I/O error will likely be returned during > > block-commit. > > > > Fo

[Qemu-devel] [PATCH RFC 5/5] xen: introduce xenpv-softmmu.mak

2014-01-23 Thread Wei Liu
The modification to configure is rebased on Paolo's change. Signed-off-by: Wei Liu --- configure | 13 + default-configs/xenpv-softmmu.mak |2 ++ 2 files changed, 11 insertions(+), 4 deletions(-) create mode 100644 default-configs/xenpv-softmmu.mak dif

[Qemu-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-23 Thread Wei Liu
As promised I hacked a prototype based on Paolo's disable TCG series. However I coded some stubs for TCG anyway. So this series in principle should work with / without Paolo's series. The first 3 patches refactor some code to disentangle Xen PV and HVM guest. The 4th patch has the real meat. It in

[Qemu-devel] [PATCH RFC 4/5] xen: implement Xen PV target

2014-01-23 Thread Wei Liu
Basically it's a dummy CPU that doens't do anything. This patch contains necessary hooks to make QEMU compile. Signed-off-by: Wei Liu --- arch_init.c|2 ++ cpu-exec.c |2 ++ include/sysemu/arch_init.h |1 + target-xenpv/Makefile.objs |1 + target-x

[Qemu-devel] [PATCH RFC 2/5] xen: factor out common functions

2014-01-23 Thread Wei Liu
So common functions used by both HVM and PV are factored out from xen-all.c to xen-common.c. Also extract a QMP function from xen-all.c and xen-stub.c to xen-common.c Finally rename xen-all.c to xen-hvm.c, as those functions are only useful to HVM guest. Signed-off-by: Wei Liu --- Makefile.tar

[Qemu-devel] [PATCH RFC 3/5] exec: guard Xen HVM hooks with CONFIG_XEN_I386

2014-01-23 Thread Wei Liu
Those are only useful when building QEMU with HVM support. We need to expose CONFIG_XEN_I386 to source code so we modify configure and i386/x86_64-softmmu.mak. Signed-off-by: Wei Liu --- configure |1 + default-configs/i386-softmmu.mak |1 - default-configs/x8

[Qemu-devel] [PATCH RFC 1/5] xen: move Xen PV machine files to hw/xenpv

2014-01-23 Thread Wei Liu
Signed-off-by: Wei Liu --- hw/i386/Makefile.objs|2 +- hw/xenpv/Makefile.objs |2 ++ hw/{i386 => xenpv}/xen_domainbuild.c |0 hw/{i386 => xenpv}/xen_domainbuild.h |0 hw/{i386 => xenpv}/xen_machine_pv.c |0 5 files changed, 3 insertions(+), 1 del

Re: [Qemu-devel] [PATCH v3 1/3] block: resize backing file image during offline commit, if necessary

2014-01-23 Thread Jeff Cody
On Thu, Jan 23, 2014 at 03:07:44PM -0700, Eric Blake wrote: > On 01/23/2014 03:00 PM, Benoît Canet wrote: > > Le Thursday 23 Jan 2014 à 16:48:55 (-0500), Jeff Cody a écrit : > >> Currently, if an image file is logically larger than its backing file, > >> commiting it via 'qemu-img commit' will fail

Re: [Qemu-devel] [PATCH v3 1/3] block: resize backing file image during offline commit, if necessary

2014-01-23 Thread Eric Blake
On 01/23/2014 03:00 PM, Benoît Canet wrote: > Le Thursday 23 Jan 2014 à 16:48:55 (-0500), Jeff Cody a écrit : >> Currently, if an image file is logically larger than its backing file, >> commiting it via 'qemu-img commit' will fail. s/commiting/committing/ >> +uint8_t *buf = NULL; > > Why a

Re: [Qemu-devel] [PATCH v3 2/3] block: resize backing image during active layer commit, if needed

2014-01-23 Thread Benoît Canet
Le Thursday 23 Jan 2014 à 16:48:56 (-0500), Jeff Cody a écrit : > If the top image to commit is the active layer, and also larger than > the base image, then an I/O error will likely be returned during > block-commit. > > For instance, if we have a base image with a virtual size 10G, and a > activ

Re: [Qemu-devel] [PATCH v3 2/3] block: resize backing image during active layer commit, if needed

2014-01-23 Thread Eric Blake
On 01/23/2014 02:48 PM, Jeff Cody wrote: > If the top image to commit is the active layer, and also larger than > the base image, then an I/O error will likely be returned during > block-commit. > > For instance, if we have a base image with a virtual size 10G, and a > active layer image of size 2

Re: [Qemu-devel] [PATCH v3 1/3] block: resize backing file image during offline commit, if necessary

2014-01-23 Thread Benoît Canet
Le Thursday 23 Jan 2014 à 16:48:55 (-0500), Jeff Cody a écrit : > Currently, if an image file is logically larger than its backing file, > commiting it via 'qemu-img commit' will fail. > > For instance, if we have a base image with a virtual size 10G, and a > snapshot image of size 20G, then commi

Re: [Qemu-devel] [PATCH v2] cpu: implementing victim TLB for QEMU system emulated TLB

2014-01-23 Thread Peter Maydell
On 23 January 2014 21:52, Xin Tong wrote: > Richard. I am sorry. I thought the patch submitter put review-bys > themselves. How do i get a reviewed-by ? You submit your patch, you fix any issues people raise, and you resubmit the fixed version. Eventually when all the problems have been corrected

[Qemu-devel] [PATCH v3 3/3] block: update block commit documentation regarding image truncation

2014-01-23 Thread Jeff Cody
This updates the documentation for commiting snapshot images. Specifically, this highlights what happens when the base image is either smaller or larger than the snapshot image being committed. In the case of the base image being smaller, it is resized to the larger size of the snapshot image. In

Re: [Qemu-devel] Emulating Ethernet controller based on Cortex-A15 platforms

2014-01-23 Thread Peter Maydell
On 23 January 2014 21:42, Andreas Färber wrote: > Am 23.01.2014 20:42, schrieb Peter Maydell: >> In QEMU at the moment the >> board models which support the Cortex-A15 are >> 'vexpress-a15' and the virtual-machine-only 'virt'. > > Surely midway, too? Yes, sorry, I forgot about that one. The point

Re: [Qemu-devel] Emulating Ethernet controller based on Cortex-A15 platforms

2014-01-23 Thread Andreas Färber
Am 23.01.2014 21:02, schrieb rajan pathak: >> I'm not clear what you're trying to do here; could >> you try rephrasing your question? Are you just trying >> to use the existing working QEMU emulation of a >> Cortex-A15 board and ethernet controller, or to do >> something else? > > To be very speci

Re: [Qemu-devel] [PATCH v2] cpu: implementing victim TLB for QEMU system emulated TLB

2014-01-23 Thread Xin Tong
Richard. I am sorry. I thought the patch submitter put review-bys themselves. How do i get a reviewed-by ? Xin On Thu, Jan 23, 2014 at 3:47 PM, Richard Henderson wrote: > On 01/23/2014 11:49 AM, Xin Tong wrote: >> Reviewed-by: Richard Henderson >> Signed-off-by: Xin Tong > > I did not give you

[Qemu-devel] [PATCH v3 1/3] block: resize backing file image during offline commit, if necessary

2014-01-23 Thread Jeff Cody
Currently, if an image file is logically larger than its backing file, commiting it via 'qemu-img commit' will fail. For instance, if we have a base image with a virtual size 10G, and a snapshot image of size 20G, then committing the snapshot offline with 'qemu-img commit' will likely fail. This

[Qemu-devel] [PATCH v3 0/3] block: commits of snapshots larger than backing files

2014-01-23 Thread Jeff Cody
Changes, v2->v3: Patch 1/3: None Patch 2/3: Set errp for both bdrv_getlength() failure cases (Fam) Remove "." from error message (Eric Blake) Patch 3/3: Removed spurious double space (Eric Blake) Changes, v1->v2: Patch 1/3: Added error check for bdrv_getlength() return (Stefan) Patch

[Qemu-devel] [PATCH v3 2/3] block: resize backing image during active layer commit, if needed

2014-01-23 Thread Jeff Cody
If the top image to commit is the active layer, and also larger than the base image, then an I/O error will likely be returned during block-commit. For instance, if we have a base image with a virtual size 10G, and a active layer image of size 20G, then committing the snapshot via 'block-commit' w

Re: [Qemu-devel] [PATCH v2] cpu: implementing victim TLB for QEMU system emulated TLB

2014-01-23 Thread Richard Henderson
On 01/23/2014 11:49 AM, Xin Tong wrote: > Reviewed-by: Richard Henderson > Signed-off-by: Xin Tong I did not give you a Reviewed-by. That implies that I approve of the patch as written, or with minor tweaks. But you can't just add this on your own. r~

Re: [Qemu-devel] [PATCH v2] cpu: implementing victim TLB for QEMU system emulated TLB

2014-01-23 Thread Max Filippov
On Fri, Jan 24, 2014 at 1:29 AM, Xin Tong wrote: >>> +/* swap the 2 given TLB entries as well as their corresponding IOTLB */ >>> +inline void swap_tlb(CPUTLBEntry *te, CPUTLBEntry *se, hwaddr *iote, >>> + hwaddr *iose) >>> +{ >>> + hwaddr iotmp; >>> + CPUTLBEntry t; >>> +

Re: [Qemu-devel] Emulating Ethernet controller based on Cortex-A15 platforms

2014-01-23 Thread Andreas Färber
Am 23.01.2014 20:42, schrieb Peter Maydell: > In QEMU at the moment the > board models which support the Cortex-A15 are > 'vexpress-a15' and the virtual-machine-only 'virt'. Surely midway, too? Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer G

Re: [Qemu-devel] [PATCH v2] cpu: implementing victim TLB for QEMU system emulated TLB

2014-01-23 Thread Xin Tong
Hi Max Thank you for taking the time to review my patch On Thu, Jan 23, 2014 at 2:44 PM, Max Filippov wrote: > Hi Xin, > > On Thu, Jan 23, 2014 at 11:49 PM, Xin Tong wrote: > > [...] > >> diff --git a/cputlb.c b/cputlb.c >> index b533f3f..03a048a 100644 >> --- a/cputlb.c >> +++ b/cputlb.c >> @@

Re: [Qemu-devel] [Qemu-ppc] [PATCH 07/10] PPC: guts: Add emulation of a few more registers

2014-01-23 Thread Scott Wood
On Thu, 2014-01-23 at 12:34 +0100, Alexander Graf wrote: > On 23.01.2014, at 01:08, Scott Wood wrote: > > > On Mon, 2014-01-20 at 00:44 +0100, Alexander Graf wrote: > >> The GUTS device is used by system software to find out about hardware > >> details of the current system. > >> > >> We only em

Re: [Qemu-devel] [PATCH] osdep: drop unused #include "trace.h"

2014-01-23 Thread Benoît Canet
Le Thursday 23 Jan 2014 à 14:27:59 (-0600), Stefan Hajnoczi a écrit : > osdep.c does not use trace_*() so we can just drop the include. > > Signed-off-by: Stefan Hajnoczi > --- > util/osdep.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/util/osdep.c b/util/osdep.c > index 62072b4..bd

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-23 Thread Christoffer Dall
On Thu, Jan 23, 2014 at 08:25:35AM -0800, Victor Kamensky wrote: > On 23 January 2014 07:33, Peter Maydell wrote: > > On 23 January 2014 15:06, Victor Kamensky > > wrote: > >> In [1] I wrote > >> > >> "I don't see why you so attached to desire to describe > >> data part of memory transaction as

Re: [Qemu-devel] [PATCH v2] cpu: implementing victim TLB for QEMU system emulated TLB

2014-01-23 Thread Max Filippov
Hi Xin, On Thu, Jan 23, 2014 at 11:49 PM, Xin Tong wrote: [...] > diff --git a/cputlb.c b/cputlb.c > index b533f3f..03a048a 100644 > --- a/cputlb.c > +++ b/cputlb.c > @@ -34,6 +34,22 @@ > /* statistics */ > int tlb_flush_count; > > +/* swap the 2 given TLB entries as well as their correspondi

[Qemu-devel] [PATCH V6 7/8] qmp: Allow to take external snapshots on bs graphs node.

2014-01-23 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Fam Zheng --- blockdev.c | 55 --- hmp.c| 4 +++- qapi-schema.json | 13 ++--- qmp-commands.hx | 11 ++- 4 files changed, 71 insertions(+), 12 del

[Qemu-devel] [PATCH V6 5/8] block: Create authorizations mechanism for external snapshot and resize.

2014-01-23 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block.c | 65 --- block/blkverify.c | 2 +- blockdev.c| 2 +- include/block/block.h | 20 +++ include/block/block_int.h | 12 ++--- 5 fi

[Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open().

2014-01-23 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 3e0994b..7726636 100644 --- a/block.c +++ b/block.c @@ -908,15 +908,15 @@ int bdrv_file_open(BlockDriverState **pbs, const char *filename, if (referenc

[Qemu-devel] [PATCH V6 3/8] qmp: Add QMP query-named-block-nodes to list the named BlockDriverState nodes.

2014-01-23 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Fam Zheng --- block.c | 18 + block/qapi.c | 109 +- blockdev.c| 5 +++ include/block/block.h | 1 + include/block/qapi.h | 1 + qapi-s

[Qemu-devel] [PATCH V6 1/8] block: Add bs->node_name to hold the name of a bs node of the bs graph.

2014-01-23 Thread Benoît Canet
From: Benoît Canet Add the minimum of code to prepare for the following patches. Signed-off-by: Benoit Canet Reviewed-by: Fam Zheng --- block.c | 57 +++ include/block/block.h | 1 + include/block/block_int.h | 9 +++- 3

[Qemu-devel] [PATCH V6 6/8] qmp: Allow block_resize to manipulate bs graph nodes.

2014-01-23 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Fam Zheng --- blockdev.c | 18 ++ hmp.c| 2 +- qapi-schema.json | 10 -- qmp-commands.hx | 3 ++- 4 files changed, 25 insertions(+), 8 deletions(-) diff --git a/blockdev.c b/blockdev.c ind

[Qemu-devel] [PATCH V6 4/8] qmp: Allow to change password on named block driver states.

2014-01-23 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet Reviewed-by: Fam Zheng There was two candidate ways to implement named node manipulation: 1) { 'command': 'block_passwd', 'data': {'*device': 'str', '*node-name': 'str', 'password': 'str'} } 2) { 'command':

[Qemu-devel] [PATCH V6 0/8] Giving names to graph's BlockDriverState

2014-01-23 Thread Benoît Canet
The following series introduce a new file.node-name property in order to be able to give a name to each BlockDriverState of the graph. since v5: rename to bdrv_assign_node_name [Fam] add node-name to BlockdevOptionsBase [Kevin] add query-named-block-nodes name in commit message [Fam]

[Qemu-devel] [PATCH V6 2/8] block: Allow the user to define "node-name" option both on command line and QMP.

2014-01-23 Thread Benoît Canet
From: Benoît Canet Signed-off-by: Benoit Canet --- block.c | 36 qapi-schema.json | 2 ++ 2 files changed, 38 insertions(+) diff --git a/block.c b/block.c index 60b70bc..d9d02d2 100644 --- a/block.c +++ b/block.c @@ -728,6 +728,33 @@ static int bd

[Qemu-devel] [PATCH] osdep: drop unused #include "trace.h"

2014-01-23 Thread Stefan Hajnoczi
osdep.c does not use trace_*() so we can just drop the include. Signed-off-by: Stefan Hajnoczi --- util/osdep.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/osdep.c b/util/osdep.c index 62072b4..bd4f530 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -46,7 +46,6 @@ extern int madvise(

Re: [Qemu-devel] [PATCH v2 8/8] target-arm: A64: Add SIMD shift by immediate

2014-01-23 Thread Peter Maydell
On 23 January 2014 20:08, C Fontana wrote: >> +if (extended_result) { >> +tcg_temp_free(tcg_src_hi); > > > > should this be tcg_temp_free_i64 ? Yes, though it doesn't actually make a difference here since we know we're building a 64 bit target QEMU. >> +return; > > > no harm but

Re: [Qemu-devel] Emulating Ethernet controller based on Cortex-A15 platforms

2014-01-23 Thread Peter Maydell
On 23 January 2014 20:02, rajan pathak wrote: > To be very specific I am trying to emulate Ethernet controller of KeyStone 2 > device from TI > > http://processors.wiki.ti.com/index.php/MCSDK_User_Guide_for_KeyStone_II > > It is based on CortexA-15 Processor series. So I thought I can use > vexpre

[Qemu-devel] [PATCH v2 8/8] target-arm: A64: Add SIMD shift by immediate

2014-01-23 Thread C Fontana
Hi Peter, just two nits, answering from the tablet so sorry if arrives with strange formatting, hope not.. On Thursday, January 23, 2014, Peter Maydell > wrote: > From: Alex Bennée > > This implements a subset of the AdvSIMD shift operations (namely all the > none saturating or narrowing ones).

Re: [Qemu-devel] Emulating Ethernet controller based on Cortex-A15 platforms

2014-01-23 Thread rajan pathak
Thanks Peter for your kind response. I'm not clear what you're trying to do here; could you try rephrasing your question? Are you just trying to use the existing working QEMU emulation of a Cortex-A15 board and ethernet controller, or to do something else? To be very specific I am trying to emula

Re: [Qemu-devel] [PATCH v2] cpu: implementing victim TLB for QEMU system emulated TLB

2014-01-23 Thread Xin Tong
Attaching data in excel which could not be sent with the patch at the same time. On Thu, Jan 23, 2014 at 1:49 PM, Xin Tong wrote: > This patch adds a victim TLB to the QEMU system mode TLB. > > QEMU system mode page table walks are expensive. Taken by running QEMU > qemu-system-x86_64 system mode

[Qemu-devel] [PATCH v2] cpu: implementing victim TLB for QEMU system emulated TLB

2014-01-23 Thread Xin Tong
This patch adds a victim TLB to the QEMU system mode TLB. QEMU system mode page table walks are expensive. Taken by running QEMU qemu-system-x86_64 system mode on Intel PIN , a TLB miss and walking a 4-level page tables in guest Linux OS takes ~450 X86 instructions on average. QEMU system mode TL

Re: [Qemu-devel] Emulating Ethernet controller based on Cortex-A15 platforms

2014-01-23 Thread Peter Maydell
On 23 January 2014 19:28, rajan pathak wrote: > I have compiled the kernel using versatile_defconfig where I can see > CONFIG_SMC91X,So I guess it uses SMSC 91C111 as its Ethernet controller. > I can see call to this smc91c111_init(nd, 0x1001, sic[25]); function is > made inside hw/arm/versa

[Qemu-devel] Emulating Ethernet controller based on Cortex-A15 platforms

2014-01-23 Thread rajan pathak
Hello Experts I am new to QEMU development and trying to emulate Ethernet controller based on Corext-A15 platform. Current I am able to up the QEMU console and see it uses SMSC 91C111 Ethernet interface emulation code. I have compiled the kernel using versatile_defconfig where I can see CONFIG_S

Re: [Qemu-devel] [PATCH 0/5 v2] Provide common methods for exchange FD

2014-01-23 Thread Antonios Motakis
Hello, On Thu, Jan 23, 2014 at 9:27 AM, Lei Li wrote: > This patch series tries to refactor the functions used for > exchange of FD in current code, provide common methods > for it. > > I just tested it through page flipping migration, and tap/ > bridge-helper a bit, but have some environment p

Re: [Qemu-devel] Possible bug in monitor code

2014-01-23 Thread Luiz Capitulino
On Thu, 23 Jan 2014 17:33:33 +0200 Stratos Psomadakis wrote: > On 01/23/2014 03:54 PM, Luiz Capitulino wrote: > > On Thu, 23 Jan 2014 08:44:02 -0500 > > Luiz Capitulino wrote: > > > >> On Thu, 23 Jan 2014 19:23:51 +0800 > >> Fam Zheng wrote: > >> > >>> Bcc: > >>> Subject: Re: [Qemu-devel] Poss

Re: [Qemu-devel] [PATCH v2 5/7] make hyperv hypercall and guest os id MSRs migratable.

2014-01-23 Thread Paolo Bonzini
Il 23/01/2014 14:40, Vadim Rozenfeld ha scritto: +if (hyperv_enabled(cpu) && +kvm_check_extension(cs->kvm_state, KVM_CAP_HYPERV) > 0) { c->eax = HYPERV_CPUID_MIN; +has_msr_hv_hypercall = true; The commit message should mention that this is done because the MS docs

Re: [Qemu-devel] [PATCH v2 0/7] Hyper-V parameters update

2014-01-23 Thread Paolo Bonzini
Il 23/01/2014 14:40, Vadim Rozenfeld ha scritto: This series consists of several clean-ups, hyper-v MSRs migration fixes, and adding support for new "hv-time" parameter, which designed for activating hyper-v timers feature. Hi Vadim! I think patches 1-4 have some problems: (1) patches 1 and 4

Re: [Qemu-devel] [PATCH v2 7/7] add support for hyper-v timers http://msdn.microsoft.com/en-us/library/windows/hardware/ff541625%28v=vs.85%29.aspx This code is generic for activating reference time co

2014-01-23 Thread Marcelo Tosatti
Subject for 7/7 contains commit log, otherwise Reviewed-by: Marcelo Tosatti On Fri, Jan 24, 2014 at 12:40:49AM +1100, Vadim Rozenfeld wrote: > Signed-off-by: Vadim Rozenfeld > --- > linux-headers/asm-x86/hyperv.h | 3 +++ > linux-headers/linux/kvm.h | 1 + > target-i386/cpu-qom.h

Re: [Qemu-devel] [PATCH v2 7/8] target-arm: A64: Add simple SIMD 3-same floating point ops

2014-01-23 Thread Peter Maydell
On 23 January 2014 16:55, Richard Henderson wrote: > On 01/23/2014 07:28 AM, Peter Maydell wrote: >> +/* Single */ >> +TCGv_i32 tcg_op1 = tcg_temp_new_i32(); >> +TCGv_i32 tcg_op2 = tcg_temp_new_i32(); >> +TCGv_i32 tcg_res = tcg_temp_new_i32(); >> +

Re: [Qemu-devel] [PATCH v4 3/4] qcow2: check for NULL l2meta

2014-01-23 Thread Benoît Canet
Le Thursday 23 Jan 2014 à 11:04:07 (+0800), Hu Tao a écrit : > In case of do preallocating metadata with a large cluster size, In the case of a metadata preallocation with > qcow2_alloc_cluster_offset() can allocate nothing and returns > a NULL l2meta. This patch checks for it and link2 l2 with on

Re: [Qemu-devel] [PATCH v2] qapi: Add "backing" to BlockStats

2014-01-23 Thread Benoît Canet
Le Thursday 23 Jan 2014 à 10:03:26 (+0800), Fam Zheng a écrit : > Currently there is no way to query BlockStats of the backing chain. This > adds "backing" field into BlockStats to make it possible. > > The comment of "parent" is reworded. > > Signed-off-by: Fam Zheng > > --- > v2: Only add "ba

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-01-23 Thread Andreas Färber
Am 23.01.2014 17:00, schrieb Peter Maydell: > On 23 January 2014 15:45, Andreas Färber wrote: >> I have also now sent out a patch covering Macs and e500. So the answer >> is, I will accept a patch that has a reasonably small blacklist. The >> time you're arguing about this on IRC and here you coul

Re: [Qemu-devel] [PATCH v4 2/4] qcow2: fix offset overflow in qcow2_alloc_clusters_at()

2014-01-23 Thread Benoît Canet
Le Thursday 23 Jan 2014 à 11:04:06 (+0800), Hu Tao a écrit : > When cluster size is big enough it can lead offset overflow Maybe "it can lead to an offset overflow in" > in qcow2_alloc_clusters_at(). This patch fixes it. > > The allocation each time is stopped at L2 table boundary "The allocation

Re: [Qemu-devel] [PULL 24/49] target-i386: Remove gen_op_movl_T0_im*

2014-01-23 Thread Richard Henderson
On 01/23/2014 07:24 AM, Kevin Wolf wrote: >> > @@ -6508,12 +6498,11 @@ static target_ulong disas_insn(CPUX86State *env, >> > DisasContext *s, >> > else >> > ot = dflag ? MO_32 : MO_16; >> > val = cpu_ldub_code(env, s->pc++); >> > -gen_op_movl_T0_im(val); >> >

Re: [Qemu-devel] [PATCH v4 1/4] qcow2: remove n_start and n_end of qcow2_alloc_cluster_offset()

2014-01-23 Thread Benoît Canet
Le Thursday 23 Jan 2014 à 11:04:05 (+0800), Hu Tao a écrit : > n_start can be actually calculated from offset. The number of > sectors to be allocated(n_end - n_start) can be passed in in > num. By removing n_start and n_end, we can save two parameters. > > The side effect is there is a bug in qco

[Qemu-devel] [PATCH] target-ppc: Make ppc40x CPUs available in ppcemb

2014-01-23 Thread Andreas Färber
Not only 44x CPUs (BookE) but also 40x CPUs can run with 1k page size. Move the criteria to a central inline function to avoid repetition and #ifdef'fery. Update qom-test to no longer exempt them. Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 38 +++

Re: [Qemu-devel] [PATCH v2 7/8] target-arm: A64: Add simple SIMD 3-same floating point ops

2014-01-23 Thread Richard Henderson
On 01/23/2014 07:28 AM, Peter Maydell wrote: > +/* Single */ > +TCGv_i32 tcg_op1 = tcg_temp_new_i32(); > +TCGv_i32 tcg_op2 = tcg_temp_new_i32(); > +TCGv_i32 tcg_res = tcg_temp_new_i32(); > +TCGv_i64 tcg_tmp = tcg_temp_new_i64(); > + > +

Re: [Qemu-devel] [PATCH v2 6/8] target-arm: A64: Add integer ops from SIMD 3-same group

2014-01-23 Thread Richard Henderson
On 01/23/2014 07:28 AM, Peter Maydell wrote: > Add some of the integer operations in the SIMD 3-same group: > specifically, the comparisons, addition and subtraction. > > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 158 > - > 1 f

Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: Add SIMD three-different multiply accumulate insns

2014-01-23 Thread Richard Henderson
On 01/23/2014 07:28 AM, Peter Maydell wrote: > Add support for the multiply-accumulate instructions from the > SIMD three-different instructions group (C3.6.15): > * skeleton decode of unallocated encodings and split of >the group into its three sub-parts > * framework for handling the 64x64-

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-23 Thread Wei Liu
On Thu, Jan 23, 2014 at 01:54:40PM +, Wei Liu wrote: > On Thu, Jan 23, 2014 at 10:11:57AM +0100, Paolo Bonzini wrote: > > Il 22/01/2014 17:09, Wei Liu ha scritto: > > >On Wed, Jan 22, 2014 at 11:20:38AM +0100, Paolo Bonzini wrote: > > >>Il 21/01/2014 19:27, Wei Liu ha scritto: > > > > > >>>

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-23 Thread Victor Kamensky
On 23 January 2014 07:33, Peter Maydell wrote: > On 23 January 2014 15:06, Victor Kamensky wrote: >> In [1] I wrote >> >> "I don't see why you so attached to desire to describe >> data part of memory transaction as just one of int >> types. If we are talking about bunch of hypothetical >> cases i

[Qemu-devel] [PATCH] tests/Makefile: Run qom-test for every architecture

2014-01-23 Thread Peter Maydell
Rather than requiring every new architecture to remember to add a line to the Makefile to say that qom-test will work on it, autogenerate the list of supported architectures by looking at the files in default-configs (as configure does), and add qom-test to the test list for all of them automatical

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-01-23 Thread Peter Maydell
On 23 January 2014 15:45, Andreas Färber wrote: > I have also now sent out a patch covering Macs and e500. So the answer > is, I will accept a patch that has a reasonably small blacklist. The > time you're arguing about this on IRC and here you could've spent > actually helping investigate and fix

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-01-23 Thread Andreas Färber
Am 23.01.2014 16:40, schrieb Peter Maydell: > On 23 January 2014 14:41, Andreas Färber wrote: >> As indicated on IRC, I want to get those fixed before transforming one >> notation to another. Especially this patch is throwing them all in one >> bucket dropping any annotation hinting at why and how

  1   2   >