Reviewed-by: Wenchao Xia
Reviewed-by: Wenchao Xia
Hi,
I noticed in newer versions of Qemu (Debian Jessie) a regression causing
DISPLAY.SYS from MS-DOS 6.22 to hang the system as soon as loaded.
The Windows for Workgroups 3.11 SETUP.EXE file hangs with a cleared
screen and the cursor blinking in the top left of the screen. The
DOSIDLE.EXE[1]
Il 08/01/2014 23:53, Richard W.M. Jones ha scritto:
> On Wed, Jan 08, 2014 at 11:45:39PM +0100, Paolo Bonzini wrote:
>> Il 08/01/2014 23:24, Richard W.M. Jones ha scritto:
>>> It's extremely difficult to know when it's safe to add this parameter.
>>> Qemu gives no indication of when using discard=.
Hi Rich,
Sorry if my mail annoys you.
Actually I have tested the QEMU KVM snapshot features with multiple
overlays and found it to be working fine.
Let’s say for an example, I have installed Windows XP as a QEMU virtual
machine (The name of the VM is ‘winxp’). Then I created two separate
overlay
On POWERPC, only a whole CPU core can be assigned to a KVM. Since
POWER7/8 support several threads per core, we want all threads of a core
to go to the same KVM so every time we run QEMU with -enable-kvm,
we have to add -smp X,threads=(4|8)" (4 for POWER7 and 8 for POWER8).
The user rather wants t
Reviewed-by: Wenchao Xia
On Thu, Jan 9, 2014 at 10:15 AM, Alan Ye wrote:
> Yes.
Okay, thanks for clarifying.
Please try jitterd to confirm that network latency is the problem
rather than a starved guest vCPU.
Please keep qemu-devel@nongnu.org CCed so the discussion stays on the
mailing list.
Thanks,
Stefan
On Wed, Jan 08, 2014 at 06:39:25PM -0500, Gabriel L. Somlo wrote:
> On Wed, Jan 08, 2014 at 11:13:54PM +0100, Paolo Bonzini wrote:
> > Have you played with the HPET device? It would be nice to have Mac OS X
> > support in QEMU 2.0.
>
> I remember telling you that the HPET needed an extra ACPI pat
On Wed, Jan 08, 2014 at 09:05:38PM +0100, Loic Dachary wrote:
> Suppress rbd progress messages with --no-progress so they are not
> confused with an error output when comparing test results ( progress is
> displayed on stderr ).
>
> Signed-off-by: Loic Dachary
> ---
> tests/qemu-iotests/common.r
Hi Peter,
Thank your for catching this.
On 2014年01月09日 03:43, Peter Feiner wrote:
When a backing file is opened such that (1) a protocol is directly
used as the block driver and (2) the block driver has bdrv_file_open,
bdrv_open_backing_file segfaults. The problem arises because
bdrv_open_comm
On 09.01.2014, at 00:39, Gabriel L. Somlo wrote:
> On Wed, Jan 08, 2014 at 11:13:54PM +0100, Paolo Bonzini wrote:
>> Have you played with the HPET device? It would be nice to have Mac OS X
>> support in QEMU 2.0.
>
> I remember telling you that the HPET needed an extra ACPI patch
> (enclosed a
On Wed, Jan 08, 2014 at 11:13:54PM +0100, Paolo Bonzini wrote:
> Have you played with the HPET device? It would be nice to have Mac OS X
> support in QEMU 2.0.
I remember telling you that the HPET needed an extra ACPI patch
(enclosed again below for reference) to work with OS X, and that
this pat
On Wed, Jan 08, 2014 at 11:45:39PM +0100, Paolo Bonzini wrote:
> Il 08/01/2014 23:24, Richard W.M. Jones ha scritto:
> > It's extremely difficult to know when it's safe to add this parameter.
> > Qemu gives no indication of when using discard=.. is safe (ie. won't
> > cause qemu to fail to start up
Il 08/01/2014 23:24, Richard W.M. Jones ha scritto:
> On Wed, Jan 08, 2014 at 11:11:35PM +0100, Paolo Bonzini wrote:
>> Is guestfish using "discard=on"?
>
> No.
>
> Adding the discard=on parameter does indeed fix this:
>
> 13M/tmp/test1
> 17M/tmp/test2
>
> However why isn't this the def
On Wed, Jan 08, 2014 at 11:37:44PM +0530, kausik pal wrote:
> Hi rich,
>
> Thanks for the answer.
>
> I was wondering how unidesk has solved the problem using disk layering.
> They have the solution for VMware, so if similar feature can be built on
> qemu for KVM hypervisor then we will have a gr
On Wed, Jan 08, 2014 at 11:11:35PM +0100, Paolo Bonzini wrote:
> Is guestfish using "discard=on"?
No.
Adding the discard=on parameter does indeed fix this:
13M/tmp/test1
17M/tmp/test2
However why isn't this the default? Is there a case where discard=on
would be undesirable?
It's extre
Il 08/01/2014 21:02, Gabriel L. Somlo ha scritto:
> Add i386 command line option "-no-fdc", which allows guests to omit the
> configuration of a floppy controller. Applies on top of my previous patch
> titled "Add DSDT node for AppleSMC"
I think we need to provide a mechanism for machine-specific
Il 07/01/2014 22:22, Richard W.M. Jones ha scritto:
> On Tue, Jan 07, 2014 at 09:48:17PM +0100, Paolo Bonzini wrote:
>> Il 07/01/2014 21:27, Richard W.M. Jones ha scritto:
>>> Not much more what I said in the original email (especially see the
>>> attached script which you can download from the bot
On 01/08/2014 12:05 PM, Loic Dachary wrote:
Suppress rbd progress messages with --no-progress so they are not
confused with an error output when comparing test results ( progress is
displayed on stderr ).
Signed-off-by: Loic Dachary
---
tests/qemu-iotests/common.rc | 2 +-
1 file changed, 1
On Wed, Jan 08, 2014 at 10:38:21PM +0200, Michael S. Tsirkin wrote:
> > +/* _STA will be patched to 0x0F if the FDC is present */
> > +ACPI_EXTRACT_NAME_WORD_CONST DSDT_FDC_STA
> > +Name(_STA, 0xFF00)
>
> I'm not sure why this is WORD. Spec says bits 0-4 have meaning bits u
On Wed, Jan 08, 2014 at 03:02:17PM -0500, Gabriel L. Somlo wrote:
> Add i386 command line option "-no-fdc", which allows guests to omit the
> configuration of a floppy controller. Applies on top of my previous patch
> titled "Add DSDT node for AppleSMC"
>
> Signed-off-by: Gabriel Somlo
> ---
> On
Suppress rbd progress messages with --no-progress so they are not
confused with an error output when comparing test results ( progress is
displayed on stderr ).
Signed-off-by: Loic Dachary
---
tests/qemu-iotests/common.rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/
Add i386 command line option "-no-fdc", which allows guests to omit the
configuration of a floppy controller. Applies on top of my previous patch
titled "Add DSDT node for AppleSMC"
Signed-off-by: Gabriel Somlo
---
On Sun, Dec 22, 2013 at 11:21:00PM +0100, Laszlo Ersek wrote:
>I guess the "by the
Hi All,
I have a question regarding Guest TLB flush IPI. Suppose we get two
vcpus 0 and 1.
When vcpu#0 wants to invalidate the tlb entry on vcpu#1. An IPI will
be generated by lapic on vcpu#0 by writing to ICR which will cause a
vmexit.
apic_send_ipi->kvm_irq_delivery_to_apic->kvm_apic_set_irq->__a
When a backing file is opened such that (1) a protocol is directly
used as the block driver and (2) the block driver has bdrv_file_open,
bdrv_open_backing_file segfaults. The problem arises because
bdrv_open_common returns without setting bd->backing_hd->file.
To effect (1), you seem to have to us
19:15:55 +0100)
are available in the git repository at:
git://git.linaro.org/people/pmaydell/qemu-arm.git
tags/pull-target-arm-20140108
for you to fetch changes up to 8900aad218f8f2348bcd688eacf06d6c1f66bc69:
target-arm: A64: Add support for FCVT between half, single and double
(2014-01-08
On 8 January 2014 18:39, M P wrote:
> I will re-add the trace for both write and read and see if I can narrow the
> range down; it will be linux specific, tho, that's why I thought a
> 'catchall' block was more appropriate.
Well, we should be implementing what the hardware does,
generally. Misimp
On 6 January 2014 15:46, Peter Maydell wrote:
> On 11 December 2013 13:56, Michel Pollet wrote:
>
> This implements just enough of the digctl IO block to allow
> > linux to believe it's running on (currently only) an imx23.
> >
> > Signed-off-by: Michel Pollet
> > ---
> > hw/arm/Makefile.objs
On 01/07/2014 08:06 AM, Tom Musta wrote:
> This patch adds the Floating Point Test for Square Root instruction
> which was introduced in Power ISA 2.06.
>
> Signed-off-by: Tom Musta
> ---
> V4: Using the newly added PPC2_FP_TST_ISA206 flag. Modified helper
> signature per Richard Henderson's rev
On 01/07/2014 08:06 AM, Tom Musta wrote:
> This patch adds the Floating Point Test for Divide instruction which
> was introduced in Power ISA 2.06B.
>
> Signed-off-by: Tom Musta
> ---
> V4: Using the newly added PPC2_FP_TST_ISA206 flag. Modified helper
> signature per Richard Henderson's review.
On 7 January 2014 20:03, Peter Maydell wrote:
> +#ifdef HOST_WORDS_BIGENDIAN
> +#define offsetoflow32(S, M) (offsetof(S, M + sizeof(uint32_t))
Mismatched brackets, won't build on bigendian hosts.
(I happened to randomly run cppcheck, or I'd not have spotted
that.)
Reroll #2 coming up later, thou
On 01/07/2014 08:06 AM, Tom Musta wrote:
> The fri* series of instructions was introduced prior to ISA 2.06 and
> is supported on Power7 and Power8 hardware. However, the instruction
> is still considered illegal in the P7 and P8 QEMU emulation models.
> This patch enables these instructions for t
On 01/07/2014 08:06 AM, Tom Musta wrote:
> This patch adds a flag for Floating Point Test instructions that were
> introduced in Power ISA V2.06B.
>
> Signed-off-by: Tom Musta
> ---
> V4: Split single flag into multiple flags per discussion with
> Alex Graf and Scott Wood. Added flag to Power7+
On 01/07/2014 08:06 AM, Tom Musta wrote:
> This patch adds the fcfids, fcfidu and fcfidus instructions which
> were introduced in Power ISA 2.06B. A common macro is provided to
> eliminate repetitious code, and the existing fcfid instruction is
> refactored to use this macro.
>
> Signed-off-by: T
On 01/07/2014 08:05 AM, Tom Musta wrote:
> This patch adds a flag for the floating point conversion instructions
> introduced in Power ISA 2.06B.
>
> Signed-off-by: Tom Musta
> ---
> V4: Split single flag into multiple flags per discussion with
> Alex Graf and Scott Wood. Added to Power7+ config
On 01/07/2014 08:05 AM, Tom Musta wrote:
> This patch adds a flag for the atomic instructions introduced
> in Power ISA V2.06B.
>
> Signed-off-by: Tom Musta
> ---
> V4: Split into new and separate patch. Added to Power7+ model.
>
> target-ppc/cpu.h|5 -
> target-ppc/transla
Am 20.12.2013 um 19:28 hat Max Reitz geschrieben:
> Currently, the configuration of blkdebug and blkverify is done through
> the "filename" alone. There is now way of manually choosing blkdebug or
> blkverify as a driver and using a normal image filename.
>
> In the case of blkdebug, the filename
On 01/07/2014 08:05 AM, Tom Musta wrote:
> This patch addes the signed Divide Word Extended instructions
> which were introduced in Power ISA 2.06B.
>
> Signed-off-by: Tom Musta
> ---
> V2: Eliminating extraneous code in the overflow case per comments
> from Richard Henderson. Fixed corner case
On 01/07/2014 08:05 AM, Tom Musta wrote:
> This patch adds a flag for the Divide Extended instructions that
> were introduced in Power ISA V2.06B. The flag is added to the
> Power7 and Power8 models.
>
> Signed-off-by: Tom Musta
> ---
> V4: Split into new and separate patch. Added flag to Power
On 01/07/2014 08:05 AM, Tom Musta wrote:
> This patch addes the Unsigned Divide Word Extended instructions
> which were introduced in Power ISA 2.06B.
>
> Signed-off-by: Tom Musta
> ---
> V2: Eliminating extraneous code in the overflow case per comments
> from Richard Henderson. Fixed corner cas
All noted, and thanks for all the bits you reviewed so far, I'll do the
changes and resubmit.
M
On 6 January 2014 15:52, Peter Maydell wrote:
> On 11 December 2013 13:56, Michel Pollet wrote:
> > Implements the pinctrl and GPIO block for the imx23
> > It handles GPIO output, and GPIO input f
Hi rich,
Thanks for the answer.
I was wondering how unidesk has solved the problem using disk layering.
They have the solution for VMware, so if similar feature can be built on
qemu for KVM hypervisor then we will have a great solution for application
management from VDI perspective.
Please let
Quoting Miki Mishael (2014-01-05 11:18:51)
> Add support for isa-serial method for qemu-ga on Windows,
> Added -p command line parameter for serial port name
> specification, e.g. "-p COM15".
>
> Signed-off-by: Miki Mishael
> Signed-off-by: Dmitry Fleytman
> ---
> qga/channel-win32.c | 27 +
On Wed, 08 Jan 2014 17:45:25 +0100
Andreas Färber wrote:
> Am 08.01.2014 17:24, schrieb Paolo Bonzini:
> > Il 08/01/2014 17:09, Igor Mammedov ha scritto:
> >> Adds optional interfaces that objects could implement if
> >> they need to:
> >> 1. perform an additional initialization after object pr
On Sat, Dec 28, 2013 at 11:30:43PM +0100, Igor Mammedov wrote:
> Changes since v1:
> * renamed hotplug.c/.h to cpu_hotplug.c/.h
> * make all prefixes acpi_cpu_hotplug and AcpiCpuHotplug
> * updated docs/specs/acpi_cpu_hotplug.txt with Q35's IO port range
> * exclude CPU/PCI/GPE IO ranges f
On Sat, Dec 28, 2013 at 11:30:46PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
> ---
> hw/i386/Makefile.objs | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> index 09ac433..edf5256 100644
> --- a/hw/i386
On Wed, Jan 08, 2014 at 11:26:28AM +0530, kausik pal wrote:
> If this message should go elsewhere, my apologies.
>
> It would be great if QEMU have the capability of detachable overlay or
> union mount.
> So administrators can keep each software as separate individual qcow2/qed
> disks and can put
Il 08/01/2014 18:17, Hani Benhabiles ha scritto:
> For this reason, the loop in assign_device_name() specifically check that the
> ID
> doesn't exist already and uses the next value if it does.
>
> How would something like:
> (qemu) device_add virtio-net-pci
> ==> ID: virtio-net-pci.0
>
> Be mor
Il 08/01/2014 17:51, Igor Mammedov ha scritto:
>> >
>> > Thanks Igor! I like very much patches 1-4 (though I'm thinking that we
>> > need some style conventions for interfaces). I think patch 5 adds more
>> > complexity than we need, but I'm open to discussion.
> I'm sorry that it took so long.
On Wed, Jan 08, 2014 at 08:36:06AM +0100, Markus Armbruster wrote:
> Hani Benhabiles writes:
>
> > This would allow a user to be able to refer to the device when using
> > commands
> > like device_del.
> >
> > Signed-off-by: Hani Benhabiles
>
> No.
>
> Device IDs belong to the user. Any IDs
On Sat, Dec 28, 2013 at 11:30:51PM +0100, Igor Mammedov wrote:
> use C headers defines as source of IO base/len for respective
> values in ASL code.
>
> Signed-off-by: Igor Mammedov
That's cool.
It's a bit confusing that you add macro in one patch, then
drop it in another.
Could you reorder pat
On Sat, Dec 28, 2013 at 11:30:48PM +0100, Igor Mammedov wrote:
> .. so that they might not be used by PCI devices.
>
> Note:
> Resort to concatenating templates with preprocessor help,
> because 1.0b spec isn't supporting ConcatenateResTemplate,
> as result Windows XP fails to execute PCI0._CRS me
On Sat, Dec 28, 2013 at 11:30:50PM +0100, Igor Mammedov wrote:
> .. so OSPM could notice resource conflict if there is any.
>
> Signed-off-by: Igor Mammedov
> ---
> hw/i386/acpi-dsdt-cpu-hotplug.dsl | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/hw/i386/acp
Paolo Bonzini writes:
> Il 08/01/2014 15:35, Markus Armbruster ha scritto:
>> Paolo Bonzini writes:
>>
>>> Leaving only those that will be affected by the patch:
>>
>> You omitted akita, borzoi, connex, mainstone, nuri, smdkc210, spitz,
>> terrier, tosa, verdex, z2, s390-virtio. Why won't the
On Wed, 08 Jan 2014 17:24:31 +0100
Paolo Bonzini wrote:
> Il 08/01/2014 17:09, Igor Mammedov ha scritto:
> > Adds optional interfaces that objects could implement if
> > they need to:
> > 1. perform an additional initialization after object properties are set
> > 2. be placed not in '/objects
Am 08.01.2014 17:24, schrieb Paolo Bonzini:
> Il 08/01/2014 17:09, Igor Mammedov ha scritto:
>> Adds optional interfaces that objects could implement if
>> they need to:
>> 1. perform an additional initialization after object properties are set
>> 2. be placed not in '/objects' container
>>
>>
On Wed, Jan 08, 2014 at 05:11:48PM +0100, Paolo Bonzini wrote:
> Il 08/01/2014 16:07, Yan Vugenfirer ha scritto:
> >>>
> >>> +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1,
> >>> PCI\VEN_1B36&DEV_0002&SUBSYS_11001AF4&REV_01
> >>> +%QEMU-PCI_SERIAL_2_PORT%=ComPort_inst2,
> >>> PCI\VEN_1B36&DEV_0003&SUBSYS_
Il 08/01/2014 17:09, Igor Mammedov ha scritto:
> Adds optional interfaces that objects could implement if
> they need to:
> 1. perform an additional initialization after object properties are set
> 2. be placed not in '/objects' container
>
> Series depends on 2 PULL requests in flight from An
On (Wed) 08 Jan 2014 [17:14:41], Amos Kong wrote:
> On Wed, Dec 18, 2013 at 11:05:14AM +0100, Giuseppe Scrivano wrote:
> > Markus Armbruster writes:
> >
> > > Amos Kong writes:
> > >
> > >> Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563
> > >>
> > >> We have a requests queue to cache the
Adds optional interfaces that objects could implement if
they need to:
1. perform an additional initialization after object properties are set
2. be placed not in '/objects' container
Series depends on 2 PULL requests in flight from Andreas & Luiz
with fixes for QOM interfaces and object-add m
On 01/08/2014 04:31 PM, Peter Maydell wrote:
On 8 January 2014 14:51, Alex Bennée wrote:
Is there an argument for making this an optional component. It would be
useful to know how many users care about having access to the target
assembly. Certainly I'm only looking at it while developing TCG c
object_property_add_child() may fail if 'id' matches already
existing object. Which means incorrect command line,
so instead of silently ignoring error, report it and
go to error path (i.e. terminate QEMU).
Signed-off-by: Igor Mammedov
---
vl.c |2 +-
1 files changed, 1 insertions(+), 1 dele
Provides an ability to do an optional second stage initialization
of an object created with -object/object-add/object_add commands.
Patch adds interface that provides realize() callback, which is
called after the object properties were set upon completion of
-object/object-add/object_add command,
Signed-off-by: Igor Mammedov
---
backends/rng.c | 17 +++--
hw/virtio/virtio-rng.c | 15 +--
include/sysemu/rng.h | 11 ---
3 files changed, 24 insertions(+), 19 deletions(-)
diff --git a/backends/rng.c b/backends/rng.c
index 85cb83f..a7a7b7f 10064
Add a optional OBJECT_PATH_INTERFACE, that will allow to set custom
container path if object's type implements this interface.
Signed-off-by: Igor Mammedov
---
it will be used for memdev backend to so that
-object membackendX,id=memdevY
could create object with path /backends/memdev/memdevY,
gro
Signed-off-by: Igor Mammedov
---
qmp.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/qmp.c b/qmp.c
index 0f46171..a67e0c4 100644
--- a/qmp.c
+++ b/qmp.c
@@ -549,15 +549,17 @@ void object_add(const char *type, const char *id, const
QDict *qdict,
for (e
Il 08/01/2014 16:07, Yan Vugenfirer ha scritto:
>>>
>>> +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1,
>>> PCI\VEN_1B36&DEV_0002&SUBSYS_11001AF4&REV_01
>>> +%QEMU-PCI_SERIAL_2_PORT%=ComPort_inst2,
>>> PCI\VEN_1B36&DEV_0003&SUBSYS_11001AF4&REV_01
>>> +%QEMU-PCI_SERIAL_4_PORT%=ComPort_inst4,
>>> PCI\VEN_1B
On 8 January 2014 14:51, Alex Bennée wrote:
> Is there an argument for making this an optional component. It would be
> useful to know how many users care about having access to the target
> assembly. Certainly I'm only looking at it while developing TCG code.
If you really don't want the dep you
Il 08/01/2014 15:35, Markus Armbruster ha scritto:
> Paolo Bonzini writes:
>
>> Leaving only those that will be affected by the patch:
>
> You omitted akita, borzoi, connex, mainstone, nuri, smdkc210, spitz,
> terrier, tosa, verdex, z2, s390-virtio. Why won't they be affected?
Because the dup
On Jan 7, 2014, at 4:45 PM, Paolo Bonzini wrote:
> Il 05/01/2014 16:04, Miki Mishael ha scritto:
>> Support for pci-serial-2x and pci-serial-4x added to inf file.
>> Standard Windows driver mf.sys used to split single function
>> device into per-port nodes.
>>
>> Signed-off-by: Miki Mishael
>>
afaer...@suse.de writes:
> Hi,
>
> Am 08.01.2014 15:25, schrieb alex.ben...@linaro.org:
>> From: Alex Bennée
>>
>> I was looking to set-up for development but found the script made some
>> hard-coded assumptions. It doesn't seem the script is used by the
>> distros but if it had a little more l
Hi,
Am 08.01.2014 15:25, schrieb alex.ben...@linaro.org:
> From: Alex Bennée
>
> I was looking to set-up for development but found the script made some
> hard-coded assumptions. It doesn't seem the script is used by the
> distros but if it had a little more love maybe it would be ;-)
>
> * Add
Hi,
On Mon, Jan 06, 2014 at 05:15:50PM +0100, André Hentschel wrote:
> From: André Hentschel
> Cc: Riku Voipio
> Signed-off-by: André Hentschel
> ---
> See
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/net.h
> for the value.
Thanks, applied to the
s...@weilnetz.de writes:
> Am 07.01.2014 17:51, schrieb Peter Maydell:
>> Hi. This is a rebased and mildly cleaned up version of Claudio's
>> RFC patchset from last year to add libvixl to QEMU and use it
>> for A64 disassembly.
>>
>> NOTE NOTE NOTE
>> * we now link with g++, not gcc (even if the
peter.mayd...@linaro.org writes:
> On 7 January 2014 16:51, Peter Maydell wrote:
>
> Another option we could consider here is only pulling in the set of source
> files we compile plus the headers they require, not the whole library. That's
>
> for about 6600 lines total. That's a significant r
Paolo Bonzini writes:
> Leaving only those that will be affected by the patch:
You omitted akita, borzoi, connex, mainstone, nuri, smdkc210, spitz,
terrier, tosa, verdex, z2, s390-virtio. Why won't they be affected?
You also omitted the machines that I can't get to start, but I'm not
overly wo
From: Alex Bennée
This script allows you to check if a given binary will match against any
of the currently registered binfmts on the system.
---
v2 (ajb):
- cleaned up whitespace and checkpatch fixes
---
scripts/qemu-binfmt-check.py | 109 +++
1 file
Am 08.01.2014 um 02:42 hat Fam Zheng geschrieben:
> Local variable "n" as int64_t avoids overflow with large sector number
> calculation. See test case change for failure case.
>
> Signed-off-by: Fam Zheng
Thanks, applied to the block branch.
Kevin
From: Alex Bennée
I was looking to set-up for development but found the script made some
hard-coded assumptions. It doesn't seem the script is used by the
distros but if it had a little more love maybe it would be ;-)
* Add usage() instructions
* Move all registering to a single function
* Check
Hi,
While working on my aarch64 work I found setting up binfmt was more of
a pain than it could have been. Specifically:
* hard-coded for /usr/local installs
* no help
* no error checking
Tellingly the script doesn't seem to be used by the distros who have
rolled their own binfmt_misc stuff arou
Il 08/01/2014 14:53, Andreas Färber ha scritto:
> Am 08.01.2014 12:02, schrieb Paolo Bonzini:
>> Il 08/01/2014 04:07, Peter Crosthwaite ha scritto:
> The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus,
> 2013-06-18). Should probably be reverted.
>
>>> Prefer not,
Leaving only those that will be affected by the patch:
Il 07/01/2014 18:34, Markus Armbruster ha scritto:
> target machine bus id times
> aarch64 n800i2c-bus.0 2
> aarch64 n810i2c-bus.0 2
> arm n8
Am 08.01.2014 12:02, schrieb Paolo Bonzini:
> Il 08/01/2014 04:07, Peter Crosthwaite ha scritto:
The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus,
2013-06-18). Should probably be reverted.
>> Prefer not, under no reasonable definition is NAND a sysbus device.
Il 08/01/2014 14:40, Andreas Färber ha scritto:
> > Either you fix "info qtree" to cope with your change to the device
> > graph, or the change needs to be reverted until somebody fixes it or it
> > goes away.
> Sharing a backtrace would be a start, rather than just throwing around
> the word "cras
Am 08.01.2014 09:13, schrieb Markus Armbruster:
> Peter Crosthwaite writes:
>
>> On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini wrote:
>>> Il 07/01/2014 16:12, Markus Armbruster ha scritto:
aarch64 akita info qtree crashes
aarch64 borzoi info qtree cra
This is the common but non-trivial steps to assign or change the
backing_hd of BDS.
Signed-off-by: Fam Zheng
---
block.c | 34 --
include/block/block.h | 1 +
2 files changed, 29 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index b1
On 8 January 2014 06:55, Stefan Weil wrote:
> Am 08.01.2014 00:00, schrieb Peter Maydell:
>> Some experimentation suggests it would also be possible to
>> just do
>>
>> extern "C" {
>> #include "disas/bfd.h"
>> }
>>
>> in the C++ file. If that doesn't have any hidden gotchas I don't
>> know about
Signed-off-by: Lei Li
---
net/tap.c | 40 +++-
1 files changed, 3 insertions(+), 37 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index 39c1cda..97ee2e8 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -39,6 +39,7 @@
#include "sysemu/sysemu.h"
#include "qemu-co
Similar to drive-backup, but this command uses a device id as target
instead of creating/opening an image file.
Also add blocker on target bs, since the target is also a named device
now.
Signed-off-by: Fam Zheng
---
block/backup.c | 21 +
blockdev.c | 47 +++
Signed-off-by: Peter Lieven
---
ui/vnc.c | 65 +++---
ui/vnc.h |6 +-
2 files changed, 46 insertions(+), 25 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 5601cc3..0925bf2 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -442,17 +442,
It makes no sense to check for "any" blocker on bs, we are here only
because of the mechanical conversion from in_use to op_blockers. Remove
it now, and let the callers check specific operation types. Backup and
mirror already have it, add checker to stream and commit.
Signed-off-by: Fam Zheng
--
Dropping intermediate could be useful both for commit and stream, and
BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs
to work with op blockers.
Signed-off-by: Fam Zheng
---
block.c| 145 ++---
block/commit.c |
vnc_update_client currently scans the dirty bitmap of each client
bitwise which is a very costly operation if only few bits are dirty.
vnc_refresh_server_surface does almost the same.
this patch optimizes both by utilizing the heavily optimized
function find_next_bit to find the offset of the next
This adds the enum of all the operations that can be taken on a block
device.
Signed-off-by: Fam Zheng
---
include/block/block.h | 19 +++
1 file changed, 19 insertions(+)
diff --git a/include/block/block.h b/include/block/block.h
index 36efaea..2bc39fe 100644
--- a/include/bloc
This makes use of op_blocker and blocks all the operations except for
commit target, on each BlockDriverState->backing_hd.
The asserts for op_blocker in bdrv_swap are removed because with this
change, the target of block commit has at least the backing blocker of
its child, so the assertion is not
On Wed, Dec 18, 2013 at 11:05:14AM +0100, Giuseppe Scrivano wrote:
> Markus Armbruster writes:
>
> > Amos Kong writes:
> >
> >> Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563
> >>
> >> We have a requests queue to cache the random data, but the second
> >> will come in when the first requ
BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX
elements. Each list is a list of blockers of an operation type
(BlockOpType), that marks this BDS as currently blocked for a certain
type of operation with reason errors stored in the list. The rule of
usage is:
* BDS user w
Signed-off-by: Peter Lieven
---
ui/vnc.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 4117230..da552fe 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -430,30 +430,24 @@ static int vnc_refresh_server_surface(VncDisplay *vd);
static voi
The following artifical test (just the bitmap operation part) running
vnc_update_client 65536 times on a 2560x2048 surface illustrates the
performance difference:
All bits clean - vnc_update_client_new: 0.07 secs
vnc_update_client_new2: 0.07 secs
vnc_update_client
1 - 100 of 121 matches
Mail list logo
