On Wed, Jan 08, 2014 at 10:38:21PM +0200, Michael S. Tsirkin wrote: > > + /* _STA will be patched to 0x0F if the FDC is present */ > > + ACPI_EXTRACT_NAME_WORD_CONST DSDT_FDC_STA > > + Name(_STA, 0xFF00) > > I'm not sure why this is WORD. Spec says bits 0-4 have meaning bits up > to 31 are cleared. So should not this be either dword (to make all > 32 bits explicit) or byte (to make it small)?
You're right of course, _STA returns 32 bits, 5 of which are defined, and the rest are reserved and "must be cleared". As such, I think it should be DWORD (and I'm not confident enough to be sure no breakage would occur if we go "BYTE" instead :) ) Speaking of, I messed this one up in my AppleSMC patch as well. Should I resend that one in its entirety too, with DWORD, or just an incremental patch setting AppleSMC _STA to DWORD ? Thanks, --Gabriel
