Re: [Qemu-devel] Debugging with printf

2013-12-12 Thread Mar Tsan
I understand that they're not one and the same but there are similarities. After all the Emulator is based on QEMU. How would someone go about editing QEMU source to display messages? 2013/12/12 Stefan Hajnoczi > On Wed, Dec 11, 2013 at 04:36:14PM +0200, Mar Tsan wrote: > > Hello. I'm working w

[Qemu-devel] [PATCH v8 10/12] stream: Use bdrv_drop_intermediate and drop close_unused_images

2013-12-12 Thread Fam Zheng
This reuses the new bdrv_drop_intermediate. Signed-off-by: Fam Zheng --- block/stream.c | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/block/stream.c b/block/stream.c index 46bec7d..9cdcf0e 100644 --- a/block/stream.c +++ b/block/stream.c @@ -51,

[Qemu-devel] [PATCH v8 07/12] block: Add backing_blocker in BlockDriverState

2013-12-12 Thread Fam Zheng
This makes use of op_blocker and blocks all the operations except for commit target, on each BlockDriverState->backing_hd. Signed-off-by: Fam Zheng --- block.c | 13 + include/block/block_int.h | 3 +++ 2 files changed, 16 insertions(+) diff --git a/block.c b/bloc

[Qemu-devel] [PATCH v8 03/12] block: Introduce op_blockers to BlockDriverState

2013-12-12 Thread Fam Zheng
BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX elements. Each list is a list of blockers of an operation type (BlockOpType), that marks this BDS as currently blocked for a certain type of operation with reason errors stored in the list. The rule of usage is: * BDS user w

[Qemu-devel] [PATCH v8 09/12] block: Support dropping active in bdrv_drop_intermediate

2013-12-12 Thread Fam Zheng
Dropping intermediate could be useful both for commit and stream, and BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs to work with op blockers. Signed-off-by: Fam Zheng --- block.c| 142 + block/commit.c |

[Qemu-devel] [PATCH v8 12/12] block: Allow backup on referenced named BlockDriverState

2013-12-12 Thread Fam Zheng
Drive backup is a read only operation on source bs. We want to allow this specific case to enable image-fleecing. Note that when image-fleecing job starts, the job still add its blocker to source bs, and any other operation on it will be blocked by that. Signed-off-by: Fam Zheng --- block.c | 2

[Qemu-devel] [PATCH v8 02/12] qapi: Add BlockOperationType enum

2013-12-12 Thread Fam Zheng
This adds the enum of all the operations that can be taken on a block device. Signed-off-by: Fam Zheng --- qapi-schema.json | 50 ++ 1 file changed, 50 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index d6f8615..8e982a2 100644 --

[Qemu-devel] [PATCH v8 05/12] block: Move op_blocker check from block_job_create to its caller

2013-12-12 Thread Fam Zheng
It makes no sense to check for "any" blocker on bs, we are here only because of the mechanical conversion from in_use to op_blockers. Remove it now, and let the callers check specific operation types. Backup and mirror already have it, add checker to stream and commit. Signed-off-by: Fam Zheng --

[Qemu-devel] [PATCH v8 11/12] qmp: Add command 'blockdev-backup'

2013-12-12 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Signed-off-by: Fam Zheng --- block/backup.c | 21 + blockdev.c | 47 +++

[Qemu-devel] [PATCH v8 06/12] block: Add bdrv_set_backing_hd()

2013-12-12 Thread Fam Zheng
This is the common but non-trivial steps to assign or change the backing_hd of BDS. Signed-off-by: Fam Zheng --- block.c | 29 +++-- include/block/block.h | 1 + 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index 28814f7

[Qemu-devel] [PATCH v8 01/12] blkdebug: Use QLIST_FOREACH_SAFE to resume IO

2013-12-12 Thread Fam Zheng
Qemu-iotest 030 was broken. When the coroutine runs and finishes, it will remove itself from the req list, so let's use safe version of foreach to avoid use after free. Signed-off-by: Fam Zheng --- block/blkdebug.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bloc

[Qemu-devel] [PATCH v8 04/12] block: Replace in_use with operation blocker

2013-12-12 Thread Fam Zheng
This drops BlockDriverState.in_use with op_blockers: - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). - Check bdrv_op_is_blocked() in place of bdrv_in_use(bs). The specific types are used, e.g. in place of startin

[Qemu-devel] [PATCH v8 00/12] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2013-12-12 Thread Fam Zheng
This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup with existing device as target). We get a thin point-in-time snapshot by COW mechanism of drive-backup, and export it through built in NBD server. The steps are as below: 1. (SHELL) qemu-i

[Qemu-devel] [PATCH] blkdebug: Use QLIST_FOREACH_SAFE to resume IO

2013-12-12 Thread Fam Zheng
Qemu-iotest 030 was broken. When the coroutine runs and finishes, it will remove itself from the req list, so let's use safe version of foreach to avoid use after free. Signed-off-by: Fam Zheng --- block/blkdebug.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bloc

Re: [Qemu-devel] [PATCH v7 3/6] hw/arm/digic: add timer support

2013-12-12 Thread Peter Crosthwaite
On Fri, Dec 13, 2013 at 3:43 PM, Antony Pavlov wrote: > On Fri, 13 Dec 2013 09:20:27 +1000 > Peter Crosthwaite wrote: > >> On Fri, Dec 13, 2013 at 8:23 AM, Antony Pavlov >> wrote: >> > Signed-off-by: Antony Pavlov >> > Reviewed-by: Peter Maydell >> > --- >> > hw/arm/digic.c | 28 +++

[Qemu-devel] [Bug 1260555] [NEW] qemu-system-sparc UI doesn't work with Cocoa and Sun ROM

2013-12-12 Thread Peter Bartoli
Public bug reported: The 32-bit SPARC emulator's TCX emulation seems to work with OpenBIOS, but doesn't work with a SparcStation ROM on Cocoa. Screenshot attached. Using version 1.7.0 on Mac OS X 10.9 via MacPorts and compiled directly from source, though this problem has carried over from M

Re: [Qemu-devel] issue with vgabios lfb and virtio vga

2013-12-12 Thread Gerd Hoffmann
On Fr, 2013-12-13 at 11:58 +1000, Dave Airlie wrote: > On Thu, Dec 12, 2013 at 6:17 PM, Gerd Hoffmann wrote: > > On Do, 2013-12-12 at 09:51 +1000, Dave Airlie wrote: > >> Now the vgabios.c does a check of bar 0 and bar 1 to see if they are > >> 0xfff1 masked, this protects against the the i/o bar

Re: [Qemu-devel] [PATCH v7 3/6] hw/arm/digic: add timer support

2013-12-12 Thread Antony Pavlov
On Fri, 13 Dec 2013 09:20:27 +1000 Peter Crosthwaite wrote: > On Fri, Dec 13, 2013 at 8:23 AM, Antony Pavlov > wrote: > > Signed-off-by: Antony Pavlov > > Reviewed-by: Peter Maydell > > --- > > hw/arm/digic.c | 28 ++ > > hw/timer/Makefile.objs | 1 + > > hw/timer/digic-ti

Re: [Qemu-devel] [PATCH v12 1/5] vmstate: Add support for an array of ptimer_state *

2013-12-12 Thread Li Guang
Peter Crosthwaite wrote: On Fri, Dec 13, 2013 at 11:19 AM, liguang wrote: From: Peter Maydell Add support for defining a vmstate field which is an array of pointers to structures, and use this to define a VMSTATE_PTIMER_ARRAY() which allows an array of ptimer_state* to be used by devices.

Re: [Qemu-devel] Occasional clockjump in Win2012 after Live Migration

2013-12-12 Thread Vadim Rozenfeld
Does your VM belong to domain or workgroup? Best regards, Vadim. - Original Message - From: "Peter Lieven" To: qemu-devel@nongnu.org, vroze...@redhat.com Sent: Friday, December 13, 2013 3:03:45 AM Subject: Occasional clockjump in Win2012 after Live Migration Hi, is anyone aware of a pr

Re: [Qemu-devel] [PATCH] target-sh4: Use new qemu_ld/st opcodes

2013-12-12 Thread Edgar E. Iglesias
On Fri, Dec 13, 2013 at 01:07:06AM +0100, Aurelien Jarno wrote: > Signed-off-by: Aurelien Jarno Reviewed-by: Edgar E. Iglesias > --- > target-sh4/translate.c | 167 > ++-- > 1 file changed, 90 insertions(+), 77 deletions(-) > > diff --git a/targe

Re: [Qemu-devel] [PATCH v7 04/10] block: support dropping active in bdrv_drop_intermediate

2013-12-12 Thread Fam Zheng
On 2013年12月12日 21:24, Kevin Wolf wrote: Am 12.12.2013 um 09:23 hat Fam Zheng geschrieben: Dropping intermediate could be useful both for commit and stream, and BDS refcnt plus bdrv_swap could do most of the job nicely. It also need some improvements in preparation for op blockers. Signed-off-by

Re: [Qemu-devel] [PATCH v7 08/10] block: Add checks of blocker in block operations

2013-12-12 Thread Fam Zheng
On 2013年12月12日 21:56, Markus Armbruster wrote: Fam Zheng writes: Before operate on a BlockDriverState, respective types are checked against bs->op_blockers and it will error out if there's a blocker. Signed-off-by: Fam Zheng So this patch adds protection against "two of the same kind simul

Re: [Qemu-devel] [PATCH v12 1/5] vmstate: Add support for an array of ptimer_state *

2013-12-12 Thread Peter Crosthwaite
On Fri, Dec 13, 2013 at 11:19 AM, liguang wrote: > From: Peter Maydell > > Add support for defining a vmstate field which is an array > of pointers to structures, and use this to define a > VMSTATE_PTIMER_ARRAY() which allows an array of ptimer_state* > to be used by devices. > > Signed-off-by: P

Re: [Qemu-devel] [PATCH 5/7] hw/arm/boot: Allow easier swapping in of different loader code

2013-12-12 Thread Peter Crosthwaite
On Thu, Nov 28, 2013 at 11:33 PM, Peter Maydell wrote: > For AArch64 we will obviously require a different set of > primary and secondary boot loader code fragments. However currently > we hardcode the offsets into the loader code where we must write > the entrypoint and other data into arm_load_k

Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support

2013-12-12 Thread Alexey Kardashevskiy
On 12/13/2013 01:05 AM, Michael S. Tsirkin wrote: > On Wed, Dec 11, 2013 at 09:22:13PM +1100, Alexey Kardashevskiy wrote: >> With the great help from Paolo, I am presenting yet another try of bootindex >> support on sPAPR, this time with some QOM fixes. Details are in the commit >> messages. >> Pl

Re: [Qemu-devel] [PATCH v7 00/10] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2013-12-12 Thread Fam Zheng
On 2013年12月13日 10:40, Ian Main wrote: On Thu, Dec 12, 2013 at 04:23:36PM +0800, Fam Zheng wrote: This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup with existing device as target). We get a thin point-in-time snapshot by COW mechanism of

Re: [Qemu-devel] [PATCH v7 06/10] block: Replace in_use with operation blocker

2013-12-12 Thread Fam Zheng
On 2013年12月12日 21:46, Markus Armbruster wrote: Fam Zheng writes: This drops BlockDriverState.in_use with op_blockers: - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). - Check bdrv_op_is_blocked() in place of b

Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event

2013-12-12 Thread Wenchao Xia
于 2013/12/2 14:48, Wenchao Xia 写道: + +if (!qapi_event_functions.emit) { Better to return an error here instead of silently failing. The purpose is allowing emit=NULL and skip event code in that case. But the code will do nothing and the caller won't know that. Now the call

Re: [Qemu-devel] [PATCH 4/5] monitor: add object-add (QMP) and object_add (HMP) command

2013-12-12 Thread Wenchao Xia
于 2013/12/11 2:15, Paolo Bonzini 写道: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 10/12/2013 19:00, Eric Blake ha scritto: + 'data': {'qom-type': 'str', 'id': 'str', '*props': 'dict'}, + 'gen': 'no' } This feels VERY open-coded. No where else in qapi-schema do we have 'dict' as a type

Re: [Qemu-devel] [PATCH v7 00/10] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2013-12-12 Thread Ian Main
On Thu, Dec 12, 2013 at 04:23:36PM +0800, Fam Zheng wrote: > This series adds for point-in-time snapshot NBD exporting based on > blockdev-backup (variant of drive-backup with existing device as target). > > We get a thin point-in-time snapshot by COW mechanism of drive-backup, and > export it thr

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-12-12 Thread Eric Blake
On 12/12/2013 07:07 PM, Qiao Nuohan wrote: > Hi, all > > Would you please give some advice about how to continue my series? > > My patches have stuck for several months, because I was not allowed to > add an > option before introspection is implemented. After observing mails about > introspection

Re: [Qemu-devel] [PATCH V7 0/6] qcow2: rollback the modification on fail in snapshot creation

2013-12-12 Thread Wenchao Xia
ping?

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-12-12 Thread Qiao Nuohan
Hi, all Would you please give some advice about how to continue my series? My patches have stuck for several months, because I was not allowed to add an option before introspection is implemented. After observing mails about introspection, I find it is still not confirmed its implement way. Sinc

Re: [Qemu-devel] issue with vgabios lfb and virtio vga

2013-12-12 Thread Dave Airlie
On Thu, Dec 12, 2013 at 6:17 PM, Gerd Hoffmann wrote: > On Do, 2013-12-12 at 09:51 +1000, Dave Airlie wrote: >> Now the vgabios.c does a check of bar 0 and bar 1 to see if they are >> 0xfff1 masked, this protects against the the i/o bar but fails to >> protect against the LFB one as PCI BARs don't

Re: [Qemu-devel] [PATCH qom v1 1/1] qom/object.c: Split out object and class caches.

2013-12-12 Thread Edgar E. Iglesias
On Wed, Nov 27, 2013 at 08:27:33PM -0800, Peter Crosthwaite wrote: > The object-cast and class-cast caches cannot be shared because class > caching is conditional on the target type not being an interface and > object caching is unconditional. Leads to a bug when a class cast > to an interface foll

[Qemu-devel] [PATCH v12 5/5] hw/arm: add cubieboard support

2013-12-12 Thread liguang
Signed-off-by: liguang Reviewed-by: Peter Crosthwaite --- hw/arm/Makefile.objs |2 +- hw/arm/cubieboard.c | 69 ++ 2 files changed, 70 insertions(+), 1 deletions(-) create mode 100644 hw/arm/cubieboard.c diff --git a/hw/arm/Makefile.objs b

[Qemu-devel] [PATCH v12 4/5] hw/arm: add allwinner a10 SoC support

2013-12-12 Thread liguang
Signed-off-by: liguang Reviewed-by: Peter Crosthwaite --- default-configs/arm-softmmu.mak |1 + hw/arm/Makefile.objs|1 + hw/arm/allwinner-a10.c | 103 +++ include/hw/arm/allwinner-a10.h | 35 + 4 files changed, 140

[Qemu-devel] [PATCH v12 2/5] hw/timer: add allwinner a10 timer

2013-12-12 Thread liguang
Signed-off-by: liguang Reviewed-by: Peter Crosthwaite --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |2 + hw/timer/allwinner-a10-pit.c | 254 ++ include/hw/timer/allwinner-a10-pit.h | 59 4 files ch

[Qemu-devel] [PATCH v12 3/5] hw/intc: add allwinner A10 interrupt controller

2013-12-12 Thread liguang
Signed-off-by: liguang Reviewed-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- default-configs/arm-softmmu.mak |1 + hw/intc/Makefile.objs |1 + hw/intc/allwinner-a10-pic.c | 200 +++ include/hw/intc/allwinner-a10-pic.h |

[Qemu-devel] [PATCH v12 0/5] add allwinner A10 SoC support

2013-12-12 Thread liguang
lay a foundation for allwinner A10 SoC with a cortex-a8 processor, and will add more devices later. v2: split timer and interrupt controller emulation into their corresponding files. v3: 1. change loader_start address 2. add 64-bit counter 3. fixup fail to clear interrup status i

[Qemu-devel] [PATCH v12 1/5] vmstate: Add support for an array of ptimer_state *

2013-12-12 Thread liguang
From: Peter Maydell Add support for defining a vmstate field which is an array of pointers to structures, and use this to define a VMSTATE_PTIMER_ARRAY() which allows an array of ptimer_state* to be used by devices. Signed-off-by: Peter Maydell --- include/hw/ptimer.h |4 incl

Re: [Qemu-devel] [PATCH] target-microblaze: Use the new qemu_ld/st opcodes

2013-12-12 Thread Edgar E. Iglesias
On Tue, Dec 10, 2013 at 03:40:21PM -0800, Richard Henderson wrote: > The ability of the new opcodes to byte-swap the memory operation > simplifies the code in and around dec_load and dec_store significantly. I've tested and applied this, thanks. Edgar > > Cc: Edgar E. Iglesias > Signed-off-b

Re: [Qemu-devel] [PATCH v11 3/5] hw/intc: add allwinner A10 interrupt controller

2013-12-12 Thread Li Guang
Peter Maydell wrote: On 11 December 2013 08:08, liguang wrote: +static void aw_a10_pic_set_irq(void *opaque, int irq, int level) +{ +AwA10PICState *s = opaque; + +if (level) { +set_bit(irq%32, (void *)&s->irq_pending[irq/32]); The % and / operators here should have sp

Re: [Qemu-devel] [PATCH v11 1/5] vmstate: add VMSTATE_PTIMER_ARRAY

2013-12-12 Thread Li Guang
Peter Maydell wrote: On 11 December 2013 08:08, liguang wrote: +static int get_ptimer(QEMUFile *f, void *pv, size_t size) +{ +ptimer_state *v = pv; +uint64_t count; + +count = qemu_get_be64(f); +if (count != -1) { +ptimer_set_count(v, count); +} else { +p

Re: [Qemu-devel] [PATCH 09/18] softfloat: Fix Handling of Small Negatives in float64_to_uint64

2013-12-12 Thread Peter Maydell
On 9 December 2013 15:47, Tom Musta wrote: > The float64_to_uint64 routine exits early for all negative numbers. > While the integer result is always correctly returned as 0, the > exception flags are also always set to float_flag_invalid. This > is incorrect for those cases where a small negativ

[Qemu-devel] [PATCH] target-sh4: Use new qemu_ld/st opcodes

2013-12-12 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-sh4/translate.c | 167 ++-- 1 file changed, 90 insertions(+), 77 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index 2272eb0..87f532a 100644 --- a/target-sh4/translate.c +++ b/target

Re: [Qemu-devel] [PATCH v7 2/6] hw/arm/digic: prepare DIGIC-based boards support

2013-12-12 Thread Peter Crosthwaite
On Fri, Dec 13, 2013 at 8:23 AM, Antony Pavlov wrote: > Also this patch adds initial support for Canon > PowerShot A1100 IS compact camera. > > Signed-off-by: Antony Pavlov > --- > hw/arm/Makefile.objs | 1 + > hw/arm/digic_boards.c | 83 > +++ >

Re: [Qemu-devel] [PATCH v7 1/6] hw/arm: add very initial support for Canon DIGIC SoC

2013-12-12 Thread Peter Crosthwaite
On Fri, Dec 13, 2013 at 8:23 AM, Antony Pavlov wrote: > DIGIC is Canon Inc.'s name for a family of SoC > for digital cameras and camcorders. > > There is no publicly available specification for > DIGIC chips. All information about DIGIC chip > internals is based on reverse engineering efforts > ma

Re: [Qemu-devel] [PATCH v7 5/6] hw/arm/digic: add NOR ROM support

2013-12-12 Thread Peter Crosthwaite
On Fri, Dec 13, 2013 at 8:23 AM, Antony Pavlov wrote: > Signed-off-by: Antony Pavlov > --- > hw/arm/digic_boards.c | 70 > +++ > 1 file changed, 70 insertions(+) > > diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c > index 20c8054..ad62c

Re: [Qemu-devel] [PATCH v7 4/6] hw/arm/digic: add UART support

2013-12-12 Thread Peter Crosthwaite
On Fri, Dec 13, 2013 at 8:23 AM, Antony Pavlov wrote: > Signed-off-by: Antony Pavlov > Reviewed-by: Peter Maydell Reveiwed-by: Peter Crosthwaite > --- > hw/arm/digic.c | 16 > hw/char/Makefile.objs | 1 + > hw/char/digic-uart.c | 195 >

Re: [Qemu-devel] [PATCH v7 3/6] hw/arm/digic: add timer support

2013-12-12 Thread Peter Crosthwaite
On Fri, Dec 13, 2013 at 8:23 AM, Antony Pavlov wrote: > Signed-off-by: Antony Pavlov > Reviewed-by: Peter Maydell > --- > hw/arm/digic.c | 28 ++ > hw/timer/Makefile.objs | 1 + > hw/timer/digic-timer.c | 140 > + > hw/timer/di

[Qemu-devel] [PATCH v7 6/6] MAINTAINERS: Document 'Canon DIGIC' machine

2013-12-12 Thread Antony Pavlov
Signed-off-by: Antony Pavlov --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7eed206..02ad9fb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -233,6 +233,12 @@ S: Supported F: hw/arm/highbank.c F: hw/net/xgmac.c +Canon DIGIC +M: Antony P

[Qemu-devel] [PATCH v7 5/6] hw/arm/digic: add NOR ROM support

2013-12-12 Thread Antony Pavlov
Signed-off-by: Antony Pavlov --- hw/arm/digic_boards.c | 70 +++ 1 file changed, 70 insertions(+) diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c index 20c8054..ad62c7e 100644 --- a/hw/arm/digic_boards.c +++ b/hw/arm/digic_boards.c @@ -2

Re: [Qemu-devel] [PATCH] block: Fix relative backing file path checking

2013-12-12 Thread Eric Blake
On 12/09/2013 11:42 PM, Xu Wang wrote: > This patch is made for Bug #1257334 (diffuse handling of image > creation from another path). The cause of it is user could create > image even though the backing file doesn't exist. Becase backing s/Becase/, because/ > file checking in the bdrv_img_create

Re: [Qemu-devel] [PULL v3 00/12] target-lm32 updates

2013-12-12 Thread Michael Walle
Hi Anthony, Am Donnerstag, 28. November 2013, 19:43:10 schrieben Sie: > Hi Anthony, > > This is a pull for various updates and fixes for the LatticeMico32 target. > > Please pull. > > changes since v2: > - rebased > - replaced ifdef HOST_WORDS_BIGENDIAN with be16_to_cpu() in >"milkymist-

Re: [Qemu-devel] [PATCH] target-lm32: Use new qemu_ld/st opcodes

2013-12-12 Thread Michael Walle
Hi Richard, Am Samstag, 7. Dezember 2013, 03:03:21 schrieb Richard Henderson: > Cc: Michael Walle > Signed-off-by: Richard Henderson > --- > target-lm32/translate.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/target-lm32/translate.c b/target-lm32/

[Qemu-devel] [PATCH v7 4/6] hw/arm/digic: add UART support

2013-12-12 Thread Antony Pavlov
Signed-off-by: Antony Pavlov Reviewed-by: Peter Maydell --- hw/arm/digic.c | 16 hw/char/Makefile.objs | 1 + hw/char/digic-uart.c | 195 + hw/char/digic-uart.h | 45 include/hw/arm/digic.h | 2 + 5 files change

[Qemu-devel] [PATCH v7 1/6] hw/arm: add very initial support for Canon DIGIC SoC

2013-12-12 Thread Antony Pavlov
DIGIC is Canon Inc.'s name for a family of SoC for digital cameras and camcorders. There is no publicly available specification for DIGIC chips. All information about DIGIC chip internals is based on reverse engineering efforts made by CHDK (http://chdk.wikia.com) and Magic Lantern (http://www.mag

[Qemu-devel] [PATCH v7 3/6] hw/arm/digic: add timer support

2013-12-12 Thread Antony Pavlov
Signed-off-by: Antony Pavlov Reviewed-by: Peter Maydell --- hw/arm/digic.c | 28 ++ hw/timer/Makefile.objs | 1 + hw/timer/digic-timer.c | 140 + hw/timer/digic-timer.h | 36 + include/hw/arm/digic.h | 6 +++ 5 fil

[Qemu-devel] [PATCH v7 2/6] hw/arm/digic: prepare DIGIC-based boards support

2013-12-12 Thread Antony Pavlov
Also this patch adds initial support for Canon PowerShot A1100 IS compact camera. Signed-off-by: Antony Pavlov --- hw/arm/Makefile.objs | 1 + hw/arm/digic_boards.c | 83 +++ 2 files changed, 84 insertions(+) create mode 100644 hw/arm/digic_boar

[Qemu-devel] [PATCH v7 0/6] add initial support for Canon DIGIC SoC

2013-12-12 Thread Antony Pavlov
[PATCH v7 1/6] hw/arm: add very initial support for Canon DIGIC SoC [PATCH v7 2/6] hw/arm/digic: prepare DIGIC-based boards support [PATCH v7 3/6] hw/arm/digic: add timer support [PATCH v7 4/6] hw/arm/digic: add UART support [PATCH v7 5/6] hw/arm/digic: add NOR ROM support [PATCH v7 6/6] MAINTAINER

[Qemu-devel] [PATCH] vmstate: Add support for an array of ptimer_state *

2013-12-12 Thread Peter Maydell
Add support for defining a vmstate field which is an array of pointers to structures, and use this to define a VMSTATE_PTIMER_ARRAY() which allows an array of ptimer_state* to be used by devices. Signed-off-by: Peter Maydell --- This is an odd lacuna in the VMSTATE macros, given that the underlyi

Re: [Qemu-devel] [PATCH v2 00/19] bsd-user: Add system call and mips/arm support.

2013-12-12 Thread Stacey Son
On Dec 12, 2013, at 1:57 PM, Ed Maste wrote: > On 27 November 2013 06:29, Paolo Bonzini wrote: >> Il 26/11/2013 22:01, Ed Maste ha scritto: >>> >>> Ping. >>> >>> This is a large change in an area that hasn't had a lot of activity of >>> late; what are the next steps here? >> >> We're now in

Re: [Qemu-devel] [PATCH V5 5/7] Add max device width parameter for NOR devices

2013-12-12 Thread Roy Franz
On Thu, Dec 12, 2013 at 9:37 AM, Peter Maydell wrote: > On 12 December 2013 17:26, Peter Maydell wrote: >> On 5 December 2013 21:35, Roy Franz wrote: >>> For handling CFI and device ID reads, we need to not only know the >>> width that a NOR flash device is configured for, but also its maximum >

Re: [Qemu-devel] [PATCH v11 1/5] vmstate: add VMSTATE_PTIMER_ARRAY

2013-12-12 Thread Peter Maydell
On 11 December 2013 08:08, liguang wrote: > +static int get_ptimer(QEMUFile *f, void *pv, size_t size) > +{ > +ptimer_state *v = pv; > +uint64_t count; > + > +count = qemu_get_be64(f); > +if (count != -1) { > +ptimer_set_count(v, count); > +} else { > +ptimer_st

Re: [Qemu-devel] [PATCH v2 00/19] bsd-user: Add system call and mips/arm support.

2013-12-12 Thread Ed Maste
On 27 November 2013 06:29, Paolo Bonzini wrote: > Il 26/11/2013 22:01, Ed Maste ha scritto: >> On 8 November 2013 11:33, Stacey Son wrote: >>> [v2] >>> >>> - Rebases to 1.7.0-rc0. (Requires, however, Andreas Tobler's patch to >>> build: see >>> http://lists.nongnu.org/archive/html/qemu-devel/

Re: [Qemu-devel] [PATCH v2] roms: Flush icache when writing roms to guest memory

2013-12-12 Thread Scott Wood
On Thu, 2013-12-12 at 10:29 +0100, Alexander Graf wrote: > We use the rom infrastructure to write firmware and/or initial kernel > blobs into guest address space. So we're basically emulating the cache > off phase on very early system bootup. > > That phase is usually responsible for clearing the

Re: [Qemu-devel] [PATCH v11 3/5] hw/intc: add allwinner A10 interrupt controller

2013-12-12 Thread Peter Maydell
On 11 December 2013 08:08, liguang wrote: > +static void aw_a10_pic_set_irq(void *opaque, int irq, int level) > +{ > +AwA10PICState *s = opaque; > + > +if (level) { > +set_bit(irq%32, (void *)&s->irq_pending[irq/32]); The % and / operators here should have spaces round them. > +

Re: [Qemu-devel] [PATCH v11 3/5] hw/intc: add allwinner A10 interrupt controller

2013-12-12 Thread Peter Maydell
On 11 December 2013 08:27, Peter Crosthwaite wrote: > Reduces reliance on qemu_set_irq implementation > (ideally someone converts that API to accept bool). I have a feeling we have some users of that API which use it to pass an arbitrary integer value around, not just for a true/false value. An

[Qemu-devel] [PATCH] qemu will core dump with "-smp 254, sockets=2, cores=3, threads=2"

2013-12-12 Thread lijun
Hi all, when set "-smp" more than 160, qemu will give the following warning: Warning: Number of SMP cpus requested (161) exceeds the recommended cpus supported by KVM (160) As the above warning, when set "-smp 160,sockets=2,cores=3,threads=2", but find that apic_id(hw/i386/acpi-build.c) is 259

Re: [Qemu-devel] [RFC 3/7] iothread: add I/O thread object

2013-12-12 Thread Michael Roth
Quoting Stefan Hajnoczi (2013-12-12 07:19:40) > This is a stand-in for Michael Roth's QContext. I expect this to be > replaced once QContext is completed. > > The IOThread object is an AioContext event loop thread. This patch adds > the concept of multiple event loop threads, allowing users to d

Re: [Qemu-devel] [PATCH V5 5/7] Add max device width parameter for NOR devices

2013-12-12 Thread Peter Maydell
On 12 December 2013 17:26, Peter Maydell wrote: > On 5 December 2013 21:35, Roy Franz wrote: >> For handling CFI and device ID reads, we need to not only know the >> width that a NOR flash device is configured for, but also its maximum >> width. The maximum width addressing mode is used for mult

Re: [Qemu-devel] [PATCH V5 7/7] Fix NOR flash device ID reading

2013-12-12 Thread Peter Maydell
On 5 December 2013 21:35, Roy Franz wrote: > Fix NOR flash manufacturer and device ID reading. This now > properly takes into account device widths and device max widths > as required. The reading of these IDs uses the same max_width > dependent addressing as CFI queries. > > The old code remain

Re: [Qemu-devel] [PATCH V5 6/7] Fix CFI query responses for NOR flash

2013-12-12 Thread Peter Maydell
On 5 December 2013 21:35, Roy Franz wrote: > This change fixes the CFI query responses to handle NOR device > widths that are different from the bank width. Support is also > added for multi-width devices in a x8 configuration. This is > typically x8/x16 devices, but the CFI specification mentio

Re: [Qemu-devel] [PATCH V5 3/7] return status for each NOR flash device

2013-12-12 Thread Peter Maydell
On 5 December 2013 21:35, Roy Franz wrote: > Now that we know how wide each flash device that makes up the bank is, > return status for each device in the bank. Leave existing code > that treats 32 bit wide banks as composed of two 16 bit devices as otherwise > we may break configurations that do

Re: [Qemu-devel] [PATCH V5 4/7] Set proper device-width for vexpress flash

2013-12-12 Thread Peter Maydell
On 5 December 2013 21:35, Roy Franz wrote: > Create vexpress specific pflash registration > function which properly configures the device-width > of 16 bits (2 bytes) for the NOR flash on the > vexpress platform. This change is required for > buffered flash writes to work properly. > > Signed-off

Re: [Qemu-devel] [PATCH V5 2/7] Add device-width property to pflash_cfi01

2013-12-12 Thread Peter Maydell
On 5 December 2013 21:35, Roy Franz wrote: > The width of the devices that make up the flash interface > is required to mask certain commands, in particular the > write length for buffered writes. This length will be presented > to each device on the interface by the program writing the flash, >

Re: [Qemu-devel] [PATCH V5 5/7] Add max device width parameter for NOR devices

2013-12-12 Thread Peter Maydell
On 5 December 2013 21:35, Roy Franz wrote: > For handling CFI and device ID reads, we need to not only know the > width that a NOR flash device is configured for, but also its maximum > width. The maximum width addressing mode is used for multi-width > parts no matter which width they are configu

Re: [Qemu-devel] [PATCH v2] target-arm: add support for v8 AES instructions

2013-12-12 Thread Peter Maydell
On 5 December 2013 17:54, Ard Biesheuvel wrote: > This adds support for the AESE/AESD/AESMC/AESIMC instructions that > are available on some v8 implementations of Aarch32. > > Signed-off-by: Ard Biesheuvel I finally managed to get set up to compare this against a reference implementation, and co

Re: [Qemu-devel] [PATCH 0/7] target-arm: Support AArch64 KVM

2013-12-12 Thread Peter Maydell
Last call for review/testing/comments on this patchset: I'm planning to do a target-arm pullreq early next week which will include this patchset. thanks -- PMM On 5 December 2013 15:23, Peter Maydell wrote: > Slightly over-eager ping for code review and/or testing, since the A64 > patches are go

Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking

2013-12-12 Thread Eric Blake
On 12/12/2013 05:27 AM, Gerd Hoffmann wrote: > Hi, > >>> +if (port_offset) { >>> +int baseport; >>> +errno = 0; >>> +baseport = strtol(port, NULL, 10); > >> >> WHY is strtol() such a PAINFUL interface to use correctly? > > Crossed my mind too after reading the ma

Re: [Qemu-devel] [PATCH 0/5] Monitor commands for object-add/del

2013-12-12 Thread Igor Mammedov
On Tue, 10 Dec 2013 18:00:23 +0100 Paolo Bonzini wrote: > These allow hotplugging (and hot-unplugging without leaking an object) > virtio-rng devices. They can also be used for memory hotplug. > > Paolo Bonzini (5): > rng: initialize file descriptor to -1 > qom: fix leak for objects created

Re: [Qemu-devel] [Spice-devel] Vdagent not working on xen linux hvm DomUs

2013-12-12 Thread Fabio Fantoni
Il 12/12/2013 16:23, Wei Liu ha scritto: On Thu, Dec 12, 2013 at 02:10:23PM +0100, Fabio Fantoni wrote: [...] I did some other tests, I narrowed down the commit range to the one between: commit c9fea5d701f8fd33f0843728ec264d95cee3ed37 Mon, 22 Jul 2013 15:14:18 (Merge remote-tracking branch 'bon

[Qemu-devel] Occasional clockjump in Win2012 after Live Migration

2013-12-12 Thread Peter Lieven
Hi, is anyone aware of a problem with a clock jump in Windows (observed in Server 2012) where after a successful live migration the clock jumps roughly 2 days into the future? Maybe this is already fixed we observed this with qemu-kvm-1.2.0. I have not yet managed to reproduce this, but it def

Re: [Qemu-devel] [PATCH 5/11 v3 FIXED] qdev: add "hotplugable" property to Device

2013-12-12 Thread Igor Mammedov
On Wed, 11 Dec 2013 20:57:43 +0100 Markus Armbruster wrote: > Please spell it "pluggable", both in C identifiers and strings. Sure, I'll respin series since it will touch several patches.

Re: [Qemu-devel] [PATCH v3] char: restore read callback on a reattached (hotplug) chardev

2013-12-12 Thread Eric Blake
On 12/12/2013 05:02 AM, Markus Armbruster wrote: > Gal Hammer writes: > >> Fix a bug that was introduced in commit 386a5a1e. A removal of a device >> set the chr handlers to NULL. However when the device is plugged back, >> its read callback is not restored so data can't be transftered from the

Re: [Qemu-devel] [PATCH] trace: add glib 2.32+ static GMutex support

2013-12-12 Thread Michael Tokarev
12.12.2013 18:52, Stefan Hajnoczi wrote: > The GStaticMutex API was deprecated in glib 2.32. We cannot switch over > to GMutex unconditionally since we would drop support for older glib > versions. But the deprecated API warnings during build are annoying so > use static GMutex when possible. >

[Qemu-devel] [PATCH V5 5/7] block: Create authorizations mechanism for external snapshot and resize.

2013-12-12 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c | 65 --- block/blkverify.c | 2 +- blockdev.c| 2 +- include/block/block.h | 20 +++ include/block/block_int.h | 12 ++--- 5 files changed, 77 inser

[Qemu-devel] [PATCH V5 7/7] qmp: Allow to take external snapshots on bs graphs node.

2013-12-12 Thread Benoît Canet
Signed-off-by: Benoit Canet --- blockdev.c | 55 --- hmp.c| 4 +++- qapi-schema.json | 13 ++--- qmp-commands.hx | 11 ++- 4 files changed, 71 insertions(+), 12 deletions(-) diff --git a/blockdev.c b/blockdev

[Qemu-devel] [PATCH V5 6/7] qmp: Allow block_resize to manipulate bs graph nodes.

2013-12-12 Thread Benoît Canet
Signed-off-by: Benoit Canet --- blockdev.c | 18 ++ hmp.c| 2 +- qapi-schema.json | 10 -- qmp-commands.hx | 3 ++- 4 files changed, 25 insertions(+), 8 deletions(-) diff --git a/blockdev.c b/blockdev.c index ebb8f48..374d03d 100644 --- a/blockdev.c +

[Qemu-devel] [PATCH V5 3/7] qmp: Add a command to list the named BlockDriverState nodes.

2013-12-12 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c | 18 + block/qapi.c | 109 +- blockdev.c| 5 +++ include/block/block.h | 1 + include/block/qapi.h | 1 + qapi-schema.json | 16 +++- qmp-commands.

[Qemu-devel] [PATCH V5 4/7] qmp: Allow to change password on named block driver states.

2013-12-12 Thread Benoît Canet
There was two candidate ways to implement named node manipulation: 1) { 'command': 'block_passwd', 'data': {'*device': 'str', '*node-name': 'str', 'password': 'str'} } 2) { 'command': 'block_passwd', 'data': {'device': 'str',

[Qemu-devel] [PATCH V5 1/7] block: Add bs->node_name to hold the name of a bs node of the bs graph.

2013-12-12 Thread Benoît Canet
Add the minimum of code to prepare for the following patches. Signed-off-by: Benoit Canet --- block.c | 57 +++ include/block/block.h | 1 + include/block/block_int.h | 9 +++- 3 files changed, 52 insertions(+), 15 deletions

[Qemu-devel] [PATCH V5 2/7] block: Allow the user to define "node-name" option.

2013-12-12 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/block.c b/block.c index 481d566..1c57f0d 100644 --- a/block.c +++ b/block.c @@ -735,6 +735,39 @@ static int bdrv_open_flags(BlockDriverState *bs, int flags) ret

[Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes

2013-12-12 Thread Benoît Canet
v5: block empty node names [Kevin] factorize setting of node-name option [Kevin] NULL terminate node_name on removal [Kevin] make query-named-block-nodes return BlockDeviceInfo structure [Eric] Change some doc in query-named-block-nodes [Eric] Document the choice of the QMP

Re: [Qemu-devel] [Spice-devel] Vdagent not working on xen linux hvm DomUs

2013-12-12 Thread Wei Liu
On Thu, Dec 12, 2013 at 02:10:23PM +0100, Fabio Fantoni wrote: [...] > I did some other tests, I narrowed down the commit range to the one between: > > commit c9fea5d701f8fd33f0843728ec264d95cee3ed37 Mon, 22 Jul 2013 > 15:14:18 (Merge remote-tracking branch 'bonzini/iommu-for-anthony') > where the

[Qemu-devel] Fwd: [sheepdog] Call to sd_truncate()

2013-12-12 Thread Hadrien KOHL
Hello everyone, I am having trouble with my qemu guests. I am facing buffer input output errors on the guests' kernel log: [TIMESTAMP] Buffer I/O error on device vda1, logical block XX [TIMESTAMP] end_request: I/O error, dev vda, sector XX I am also reading in the qemu log: qemu-system-x8

[Qemu-devel] [PATCH] trace: add glib 2.32+ static GMutex support

2013-12-12 Thread Stefan Hajnoczi
The GStaticMutex API was deprecated in glib 2.32. We cannot switch over to GMutex unconditionally since we would drop support for older glib versions. But the deprecated API warnings during build are annoying so use static GMutex when possible. Signed-off-by: Stefan Hajnoczi --- trace/simple.c

Re: [Qemu-devel] [PATCH v2 10/14] pci: allow 0 address for PCI IO regions

2013-12-12 Thread Michael S. Tsirkin
On Thu, Dec 05, 2013 at 11:33:48PM +, Peter Maydell wrote: > On 5 December 2013 22:33, Michael Roth wrote: > > Some kernels program a 0 address for io regions. PCI 3.0 spec > > sectio 6.2.5.1 doesn't seem to disallow this. > > Hmm. The last PCI spec I looked at said 0 wasn't a valid MMIO > ad

  1   2   >