Signed-off-by: liguang
---
default-configs/arm-softmmu.mak |1 +
hw/intc/Makefile.objs |1 +
hw/intc/sunxi-pic.c | 238 +++
include/hw/intc/sunxi-pic.h | 20
4 files changed, 260 insertions(+), 0 deletions(-)
create mo
Signed-off-by: liguang
---
hw/arm/Makefile.objs |1 +
hw/arm/sunxi-soc.c | 98 ++
2 files changed, 99 insertions(+), 0 deletions(-)
create mode 100644 hw/arm/sunxi-soc.c
diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs
index 3671b4
Signed-off-by: liguang
---
default-configs/arm-softmmu.mak |2 +
hw/timer/Makefile.objs |1 +
hw/timer/sunxi-pit.c| 295 +++
include/hw/timer/sunxi-pit.h| 37 +
4 files changed, 335 insertions(+), 0 deletions(-)
create m
Signed-off-by: liguang
---
MAINTAINERS |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 77edacf..232e1a1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -284,6 +284,15 @@ M: Peter Maydell
S: Maintained
F: hw/*/stellaris*
+Sunxi
+M
this patch-set implemented a device-reduced
machine type for Allwinner's sunxi series SoC,
like sunxi-4i/5i/7i ...
now, It can support sunxi-4i with a cortex-a8 processor.
and will support more later, like sunxi-7i with cortex-a7,
and will add more devices.
v2: split timer and interrupt controll
On 25.11.2013 18:21, Eric Blake wrote:
On 11/25/2013 06:57 AM, Peter Lieven wrote:
Signed-off-by: Peter Lieven
---
qemu-img.c |1 -
1 file changed, 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index efb744c..e2d1a0a 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -105,7 +105,6 @@ stat
This modifies _cleanup_test_img to remove all the extent files listed by
"qemu-img info"'s format specific information.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/common.rc | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/common.rc b/
Patch 1 and 2 add _unsupported_imgopts declaration for vmdk subformats, so the
cases can be skipped if the subformat is not supported.
Patch 3 adds clean up for vmdk extents.
Fam Zheng (3):
qemu-iotests: Introduce _unsupported_imgopts
qemu-iotests: Add _unsupported_imgopts for vmdk subformats
Check the backing file for a loop during image boot, to avoid a lack or
response or segfault.
Signed-off-by: Xu Wang
---
blockdev.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 330aa4a..e39fc27 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -511,6 +511,13
Backing file loop should be checked before calling change_backing_
file(). If loop appeared, this calling should be stopped and an
error printed.
Signed-off-by: Xu Wang
---
block.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/block.c b/block.c
index b8cea1c..87f7018 100644
--- a/
Introduce _unsupported_imgopts that causes _notrun for specific image
options.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/common.rc | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index 7f62457..d465c48 100644
---
Some cases are not applicable for vmdk subformats those don't support
certain features, e.g. backing file, and some others can't run on
mult-file image, e.g. monolithicFlat. This adds declaration in test
cases to skip them automatically, so that iotests on vmdk can go
more smoothly (without manuall
Backing file loop should be checked before qemu-img create command
execution. If loop is found, qemu-img create should be stopped and
an error printed.
Signed-off-by: Xu Wang
---
block.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/block.c b/block.c
ind
If there is a loop in the backing file chain, it could cause problems
such as no response or a segfault during system boot. Hence detecting a
backing file loop is necessary. This patch extracts the loop check from
collect_image_info_list() in block.c into independent functions
bdrv_backing_chain_ok
If there is loop exists in the backing file chain, many problems
could be caused by it, such as no response and segment fault during
system boot. Hence stopping backing file loop appear is very necessary.
These patches refine and export loop checking function from collect_image_
info_list() to bloc
Am 25.11.2013 22:46, schrieb Alexander Graf:
> The default granularity for the FIT timer on 440 is on every 0x1000th
> transition of TB from 0 to 1. Translated that means 48828 times a second.
>
> Since interrupts are quite expensive for 440 and we don't really care
> about the accuracy of the FIT
We support top == active for commit now, remove the check and add an
assertion here.
Signed-off-by: Fam Zheng
---
block/commit.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/block/commit.c b/block/commit.c
index d4090cb..acec4ac 100644
--- a/block/commit.c
+++ b/blo
If active is top, it will be mirrored to base, (with block/mirror.c
code), then the image is switched when user completes the block job.
QMP documentation is updated.
Signed-off-by: Fam Zheng
---
block/mirror.c | 11 +++
blockdev.c | 9 +++--
qapi-schema.json | 5 +++--
3
commit_active_start is implemented in block/mirror.c, It will create a
job with "commit" type and designated base in block-commit command. This
will be used for committing active layer of device.
Sync mode is removed from MirrorBlockJob because there's no proper type
for commit. The used informati
This allows setting the base before entering mirror_run, commit will
make use of it.
Signed-off-by: Fam Zheng
---
block/mirror.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 01a795a..cbdcc21 100644
--- a/block/mirror.c
++
Factor out commit test common logic into super class, and update test
of committing the active image.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/040 | 74 ++
1 file changed, 32 insertions(+), 42 deletions(-)
diff --git a/tests/qemu-iotests/04
Let reference count manage target and don't call bdrv_close here.
Signed-off-by: Fam Zheng
---
block/mirror.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index 7b95acf..01a795a 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -479,7 +479,6 @@ immediate_e
Previously live commit of active block device is not supported, this series
implements it and updates corresponding qemu-iotests cases.
This series is based on BlockJobType enum QAPI series.
v6: Address comments from Stefan:
[04/06] commit: support commit active layer
Fix wording
On 2013年11月25日 20:04, Markus Armbruster wrote:
Peter Maydell writes:
On 25 November 2013 09:53, Paolo Bonzini wrote:
I think anything that makes it easier for users to do bisections instead
of us, and anything that makes it easier to script bisections ("git
bisect run"), is valuable.
Perso
Hi!
btw there is a problem with this patch - it does not compile for
"linux-user" as there is no current-machine global variable defined in vl.c
which is not compiled for linux-user.
How to solve this problem correctly?
On 11/25/2013 06:27 PM, Alexey Kardashevskiy wrote:
> QEMU supports firmwar
This introduces a get_fw_dev_path() callback.
This fixes SCSI disks device node names (which are wildcard nodes in
the device-tree).
This fixes PHB name from "pci" to "pci@" where is a BUID as
there is no bus on top of sPAPRPHBState where PHB firmware name could
be fixed using the BusCla
Public bug reported:
Hi:
I met some filesysterm errors in a sles guest on KVM. My system environment is:
HOST:
suse 10, the kernel version is 2.6.32.43
Qemu-KVM 1.2
Libvirt 1.0
guest OS:
suse 10, the kernel version is 2.6.32.43
VMs use a qcow2 disk.
Description of problem:
I have 20+
Drive backup is a read only operation on source bs. We want to allow
this specific case to enable image-fleecing. Note that when
image-fleecing job starts, the job still add its blocker to source bs,
and any other operation on it will be blocked by that.
Signed-off-by: Fam Zheng
---
block.c | 2
Similar to drive-backup, but this command uses a device id as target
instead of creating/opening an image file.
Also add blocker on target bs, since the target is also a named device
now.
Signed-off-by: Fam Zheng
---
block/backup.c | 21 +
blockdev.c | 47 +++
Before operate on a BlockDriverState, respective types are checked
against bs->op_blockers and it will error out if there's a blocker.
Signed-off-by: Fam Zheng
---
blockdev.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 1efa806..cfb815f 100
This adds the enum of all the operations that can be taken on a block
device.
Signed-off-by: Fam Zheng
---
qapi-schema.json | 49 +
1 file changed, 49 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index 83fa485..c9e513c 100644
---
Signed-off-by: Fam Zheng
---
block.c | 31 ---
block/mirror.c| 2 +-
include/block/block.h | 3 ++-
include/block/block_int.h | 3 +++
4 files changed, 34 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index c2ab6d8..
BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX
elements. Each list is a list of blockers of an operation type
(BlockOpType), that marks this BDS as currently blocked for a certain
type of operation with reason errors stored in the list. The rule of
usage is:
* BDS user w
This drops BlockDriverState.in_use with op_blockers:
- Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1).
- Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0).
- Check bdrv_op_is_blocked() in place of bdrv_in_use(bs).
The specific types are used, e.g. in place of startin
This series adds for point-in-time snapshot NBD exporting based on
blockdev-backup (variant of drive-backup with existing device as target).
We get a thin point-in-time snapshot by COW mechanism of drive-backup, and
export it through built in NBD server. The steps are as below:
1. (SHELL) qemu-i
** Changed in: qemu (Debian)
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1187121
Title:
segfault with -vga vmware and -display gtk
Status in QEMU:
Fix
On 2013年11月25日 19:23, Kevin Wolf wrote:
Am 22.11.2013 um 06:24 hat Fam Zheng geschrieben:
Drive backup is a read only operation on source bs. We want to allow
this specific case to enable image-fleecing. Note that when
image-fleecing job starts, the job still add its blocker to source bs,
and an
Thanks Bryant, this problem has been solved by following
"http://www.mail-archive.com/qemu-devel@nongnu.org/msg200808.html";.
But there is another problem when run configure with "./configure
--target-list=x86_64-softmmu --enable-tpm". The value of "libtpms" is still
"no". when I modif
On 2013年11月26日 01:11, Paolo Bonzini wrote:
Il 22/11/2013 06:24, Fam Zheng ha scritto:
@@ -41,13 +41,11 @@ void *block_job_create(const BlockJobDriver *driver,
BlockDriverState *bs,
{
BlockJob *job;
-if (bs->job || bdrv_in_use(bs)) {
+if (bs->job) {
error_set(errp, QER
On 2013年11月26日 01:15, Paolo Bonzini wrote:
Il 22/11/2013 06:24, Fam Zheng ha scritto:
Before operate on a BlockDriverState, respective types are checked
against bs->op_blockers and it will error out if there's a blocker.
How did you choose them? I understand blocking change (and eject?), but
On 2013年11月26日 01:13, Paolo Bonzini wrote:
Il 22/11/2013 06:24, Fam Zheng ha scritto:
+void bdrv_op_block(BlockDriverState *bs, BlockOpType op, Error *reason)
+{
+BdrvOpBlocker *blocker;
+assert(op >=0 && op < BLOCK_OP_TYPE_MAX);
+
+blocker = g_malloc0(sizeof(BdrvOpBlocker));
+bl
On 2013年11月25日 19:26, Kevin Wolf wrote:
Am 22.11.2013 um 06:24 hat Fam Zheng geschrieben:
This adds the enum of all the operations that can be taken on a block
device.
Signed-off-by: Fam Zheng
Okay, so now I've read the whole series and I still couldn't solve this
mystery: Why is this a QAPI
Format "raw" doesn't always work on certain file systems (e.g. tmpfs).
Use qcow2 to make the allocation status explicit and split into a new
case.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/048 | 27 ---
tests/qemu-iotests/048.out | 16 -
tests/qemu-iotests/074 |
So that the tests can run faster.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
index 26390a6..804ac92 100644
--- a/tests/qemu-iotests/common
+++ b/tests/qemu-iotest
This replaces _unsupported_qemu_io_options and check for support of
current cache mode, and allow to provide a default if user didn't
specify.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/026 | 3 ++-
tests/qemu-iotests/039 | 3 ++-
tests/qemu-iotests/052 | 4 ++--
tests/
The option sets cache mode used in the tests. "-nocache" is changed to
an alias to "-c none", and internally passes "-t none" to qemu-io.
Python scripts will make use of option this in the next commit.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/check | 2 +-
tests/qemu-iotests/common | 2
This series adds cache mode option in the iotests framework. Test cases are
updated to make use of cache mode and mask supported modes.
v4: Address Stefan's comments:
Add _default_cache_mode.
Split last two cases in 048 to 074.
Use long option "--cache" instead of "-t" for qemu-io.
v3
Whitespace changes to align columns.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/common | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
index 804ac92..55a6f72 100644
--- a/tests/qemu-iotests/common
+++
This will allow overriding cache mode from the "-c mode" option.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/iotests.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index fb10ff4..c84a1a5 100644
--- a/test
Peter Crosthwaite wrote:
Hi,
On Mon, Nov 25, 2013 at 5:41 PM, liguang wrote:
Signed-off-by: liguang
---
default-configs/arm-softmmu.mak |2 +
hw/timer/Makefile.objs |1 +
hw/timer/sunxi-pit.c| 260 +++
include/hw/timer/
Peter Crosthwaite wrote:
On Mon, Nov 25, 2013 at 5:41 PM, liguang wrote:
Signed-off-by: liguang
---
default-configs/arm-softmmu.mak |1 +
hw/intc/Makefile.objs |1 +
hw/intc/sunxi-pic.c | 301 +++
include/hw/intc/sunxi-
Igor Mammedov wrote:
On Fri, 22 Nov 2013 08:57:40 +0800
Li Guang wrote:
Michael S. Tsirkin wrote:
On Thu, Nov 21, 2013 at 04:32:27PM +0800, Li Guang wrote:
Michael S. Tsirkin wrote:
On Thu, Nov 21, 2013 at 04:18:45PM +0800, Li Guang wrote:
Hu Tao
On 27 September 2013 11:10, Mian M. Hamayun
wrote:
> From: "Mian M. Hamayun"
>
> This commit adds support for booting a single AArch64 CPU by setting
> appropriate registers. The bootloader includes placehoders for Board-ID
> that are used to implement uniform indexing across different bootloader
Relocate some stuff to avoid forward declarations and use the
realize and unrealize hooks to call into register and unregister vmstate_pcibus
respectively
Signed-off-by: Bandan Das
---
hw/pci/pci.c | 49 -
1 file changed, 28 insertions(+), 21 dele
This introduces three changes - first, it sets the realized property for
BusState in the setter functions for DeviceState so that a call to the
(device) setter will also set the value for any children buses
appropriately. Second, it introduces a bool called realized_cache that
tracks the most re
Add simple set/get functions for bus. The setter also checks if it has
children devices and sets "realize" accordingly.
Signed-off-by: Bandan Das
---
hw/core/qdev.c | 67 ++
include/hw/qdev-core.h | 7 ++
2 files changed, 74 insertion
These patches add realize and unrealize interfaces to BusState just
like we have for DeviceState. 1/3 and 2/3 implement the interface and
attempt to integrate it to the existing DeviceState call path.
3/3 is an example user of the interface, pci in this case. Please
see individual patches for mor
Richard Henderson wrote:
On 11/26/2013 07:01 AM, Michael S. Tsirkin wrote:
Can you confirm this works?
I can confirm that with this follow-on I can once again build on RHEL 5.3.
r~
Sorry, a bit late, but yes, it compiles on my Debian 4.0. My test target is
down at the moment, I try to ge
I suspect this is a NULL pointer access that happens in procps where it
isn't handling an error path that it's not expecting somehow (either a
syscall we're not implementing, or perhaps something like /proc not
being mounted in your chroot environment, or something about qemu's
emulation of some fi
qemu-powerpc-static on i386:
# ps
Invalid data memory access: 0x
NIP 0feb05e4 LR 0feb1440 CTR 0feb13f0 XER
MSR 6040 HID0 HF 6000 idx 0
TB
GPR00 0ffc178c 407fffa0 4083f720 0001
GPR04 29292929
On 11/25/13 22:33, Michael S. Tsirkin wrote:
> I queued other things on top and it's 11:30pm here.
> Guys, go discuss the color of some other bikeshed.
(Just to be clear, I deliberately didn't address how the code in
question *should* be formulated. I'll leave that to you all to figure
out. I onl
glib < 2.22 does not have g_array_get_element_size,
limit it's use (to check all elements are 1 byte
in size) to newer glib.
This fixes build on RHEL 5.3.
Reported-by: Richard Henderson
Reported-by: Erik Rull
Tested-by: Richard Henderson
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-bui
I figured out the problem. There is zerocopy IO is being done via DMA to
a buffer allocated with valloc(). Right now, I am running a hack-fix
locally so I can get some other stuff done first. I will propose a
proper fix to the list in a few days.
On 11/25/2013 10:49 AM, Richard Yao wrote:
> I boot
Thanks to the new timer infrastructure we are now able to trigger timer events
and ridiculous granularities in sub-microsecond orders.
However, the BookE targets were quite unhappy about that change, showing up
to x10 slowdown on a simple Linux guest bootup test.
This patch set makes the constant
On 11/26/2013 07:01 AM, Michael S. Tsirkin wrote:
> Can you confirm this works?
I can confirm that with this follow-on I can once again build on RHEL 5.3.
r~
Today we fire FIT and WDT timer events every time the respective bit
position in TB flips from 0 -> 1.
However, there is no need to do this if the end result would be that
we're changing a TSR bit that is set to 1 to 1 again. No guest visible
change would have occured.
So whenever we see that the
The default granularity for the FIT timer on 440 is on every 0x1000th
transition of TB from 0 to 1. Translated that means 48828 times a second.
Since interrupts are quite expensive for 440 and we don't really care
about the accuracy of the FIT to that significance, let's force FIT and
WDT to at be
On Tue, Nov 26, 2013 at 07:21:52AM +1000, Richard Henderson wrote:
> On 11/26/2013 07:02 AM, Michael S. Tsirkin wrote:
> > In any case it's too late to play with cosmetic changes for 1.7.
> > We can revisit for 1.8.
>
> I beg your pardon? I didn't realize your patch had already been applied.
Whe
Same thing with qemu-mips-static too by the looks of things.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1254672
Title:
ps segfaults with qemu-arm-static
Status in QEMU:
New
Status in Linaro Q
On Tue, Nov 26, 2013 at 07:18:04AM +1000, Richard Henderson wrote:
> On 11/26/2013 06:54 AM, Michael S. Tsirkin wrote:
> > +char s[] = "";
>
> char s[5];
>
> >>
> >> Then do something like
> >>
> >> char s[sizeof("")];
> >>
> >> so that the actual initialization doe
On 11/25/2013 02:15 PM, Laszlo Ersek wrote:
>> +char s[] = "";
>
> char s[5];
>
> Initializing it is a waste of time.
And storage - the string literal occupies space in the binary image.
>>> Then do something like
>>>
>>> char s[sizeof("")];
Not to mention we a
On 11/26/2013 07:02 AM, Michael S. Tsirkin wrote:
> In any case it's too late to play with cosmetic changes for 1.7.
> We can revisit for 1.8.
I beg your pardon? I didn't realize your patch had already been applied. And
since it has mistakes that require respin anyway, why can't we change this t
On 11/26/2013 06:54 AM, Michael S. Tsirkin wrote:
> +char s[] = "";
char s[5];
>>
>> Then do something like
>>
>> char s[sizeof("")];
>>
>> so that the actual initialization doesn't happen.
> Why? As an optimization?
How about failing to pessimize?
With your initi
On 27 September 2013 11:10, Mian M. Hamayun
wrote:
> From: "Mian M. Hamayun"
>
> This commit replaces the constant indices used in bootloaders, such as for
> specifying the Board ID and kernel arguments with variable parameters.
> This change is used as mechanism to minimize code changes for diff
On 11/25/13 21:54, Michael S. Tsirkin wrote:
> On Tue, Nov 26, 2013 at 06:37:43AM +1000, Richard Henderson wrote:
>> On 11/26/2013 06:31 AM, Michael S. Tsirkin wrote:
>>> On Tue, Nov 26, 2013 at 06:24:53AM +1000, Richard Henderson wrote:
On 11/25/2013 09:48 PM, Michael S. Tsirkin wrote:
>
On Mon, Nov 25, 2013 at 06:43:13PM +0100, Paolo Bonzini wrote:
> v2: condition enablement of new mapping to new machine types (Paolo)
> v3: fix changelog
> v4: rebase
> v5: ensure alignment of piecetwo on 2MB GPA (Igor)
> do not register zero-sized piece-one(Igor)
> v6: fix memory leak
On Tue, Nov 26, 2013 at 06:37:43AM +1000, Richard Henderson wrote:
> On 11/26/2013 06:31 AM, Michael S. Tsirkin wrote:
> > On Tue, Nov 26, 2013 at 06:24:53AM +1000, Richard Henderson wrote:
> >> On 11/25/2013 09:48 PM, Michael S. Tsirkin wrote:
> >>> g_string_vprintf was only introduced in 2.24 so
On Mon, Nov 25, 2013 at 09:14:19PM +0100, Erik Rull wrote:
> Michael S. Tsirkin wrote:
> >g_array_get_element_size was only added in glib 2.14,
> >there's no way to find element size in with an older glib.
> >
> >Fortunately we only use a single table (linker) where element size > 1.
> >Switch elem
On 11/25/13 18:43, Paolo Bonzini wrote:
> v2: condition enablement of new mapping to new machine types (Paolo)
> v3: fix changelog
> v4: rebase
> v5: ensure alignment of piecetwo on 2MB GPA (Igor)
> do not register zero-sized piece-one(Igor)
> v6: fix memory leak (Ig
On Mon, Nov 25, 2013 at 09:14:19PM +0100, Erik Rull wrote:
> Michael S. Tsirkin wrote:
> >g_array_get_element_size was only added in glib 2.14,
> >there's no way to find element size in with an older glib.
> >
> >Fortunately we only use a single table (linker) where element size > 1.
> >Switch elem
On Tue, Nov 26, 2013 at 06:37:43AM +1000, Richard Henderson wrote:
> On 11/26/2013 06:31 AM, Michael S. Tsirkin wrote:
> > On Tue, Nov 26, 2013 at 06:24:53AM +1000, Richard Henderson wrote:
> >> On 11/25/2013 09:48 PM, Michael S. Tsirkin wrote:
> >>> g_string_vprintf was only introduced in 2.24 so
On 11/26/2013 06:31 AM, Michael S. Tsirkin wrote:
> On Tue, Nov 26, 2013 at 06:24:53AM +1000, Richard Henderson wrote:
>> On 11/25/2013 09:48 PM, Michael S. Tsirkin wrote:
>>> g_string_vprintf was only introduced in 2.24 so switch to vsnprintf
>>> instead. A bit uglier but name size is fixed at 4
On Mon, Nov 25, 2013 at 09:08:20PM +0100, Erik Rull wrote:
> Michael S. Tsirkin wrote:
> >On Fri, Nov 22, 2013 at 09:19:49PM +0100, Erik Rull wrote:
> >>Paolo Bonzini wrote:
> >>>Il 22/11/2013 12:16, Erik Rull ha scritto:
> It's getting more and more complex to build qemu, is there a reason why
On Tue, Nov 26, 2013 at 06:24:53AM +1000, Richard Henderson wrote:
> On 11/25/2013 09:48 PM, Michael S. Tsirkin wrote:
> > g_string_vprintf was only introduced in 2.24 so switch to vsnprintf
> > instead. A bit uglier but name size is fixed at 4 bytes here so it's
> > easy.
>
> You list 2.24 here,
On 11/25/2013 09:48 PM, Michael S. Tsirkin wrote:
> +#if GLIB_CHECK_VERSION(2, 14, 0)
> +assert(g_array_get_element_size(table) == 1);
> +#endif
https://developer.gnome.org/glib/2.28/glib-Arrays.html#g-array-get-element-size
says "Since 2.22", not 2.14.
r~
On 11/25/2013 09:48 PM, Michael S. Tsirkin wrote:
> g_string_vprintf was only introduced in 2.24 so switch to vsnprintf
> instead. A bit uglier but name size is fixed at 4 bytes here so it's
> easy.
You list 2.24 here,
> -GString *s = g_string_new("");
> +/* It would be nicer to use g_st
On 11/25/13 16:32, Markus Armbruster wrote:
> Laszlo Ersek writes:
>
>> This patch allows the user to usefully specify
>>
>> -drive file=img_1,if=pflash,format=raw,readonly \
>> -drive file=img_2,if=pflash,format=raw
>>
>> on the command line. The flash images will be mapped under 4G in their
Michael S. Tsirkin wrote:
g_array_get_element_size was only added in glib 2.14,
there's no way to find element size in with an older glib.
Fortunately we only use a single table (linker) where element size > 1.
Switch element size to 1 everywhere, then we can just look at len field
to get table
On 25.11.2013 15:40, Kevin Wolf wrote:
Am 22.11.2013 um 17:10 hat Max Reitz geschrieben:
If the filename is not prefixed by "blkverify:" in
blkverify_parse_filename(), the blkverify driver was not selected
through that protocol prefix, but by an explicit command line option
(like file.driver=blk
Michael S. Tsirkin wrote:
On Fri, Nov 22, 2013 at 09:19:49PM +0100, Erik Rull wrote:
Paolo Bonzini wrote:
Il 22/11/2013 12:16, Erik Rull ha scritto:
It's getting more and more complex to build qemu, is there a reason why everyone
needs to build the acpi stuff by himself?
It is only attempted
Performing multiple drive-mirror blockjobs on the same qemu instance
results in the image file used for the block device being replaced by
the newly mirrored file, which is not what we want.
Fix this by performing one dedicated test per sync mode.
Signed-off-by: Max Reitz
---
tests/qemu-iotests
Both code locations cause a compiler warning. Using "%s" instead of "%lu"
would result in a program crash if the wrong code were executed.
Signed-off-by: Stefan Weil
---
qga/commands-win32.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qga/commands-win32.c b/qga/com
From: Stefan Weil
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCm68k-softmmu/hw/m68k/mcf5206.o
hw/i386/acpi-build.c: In function ‘build_append_nameseg’:
hw/i386/acpi-build.c:294:5: error:
function might be possible candidate for ‘gnu_printf’ format attribute
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Weil
Signed-off-by: Michael Tokarev
---
.gitignore |1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 5584b5f..1c9d63d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,6 +3,7 @@ config-all-devices.*
On 11/25/13 16:22, Markus Armbruster wrote:
> Laszlo Ersek writes:
>
>> On 11/22/13 13:21, Markus Armbruster wrote:
>>> Laszlo Ersek writes:
>>>
This patch allows the user to usefully specify
-drive file=img_1,if=pflash,format=raw,readonly \
-drive file=img_2,if=pflash,fo
The migration thread appears to want to allow writeout to occur at full
speed rather than being rate limited during completion of state saving,
but sets the limit to INT_MAX when xfer_limit is INT64_MAX. This causes
problems if there's more than 2GB of state left to save at this point. It
probably
From: Stefan Weil
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCqobject/qerror.o
qobject/qerror.c: In function ‘qerror_from_info’:
qobject/qerror.c:53:5: error:
function might be possible candidate for ‘gnu_printf’ format attribute
[-Werror=suggest-attribute
On 25.11.2013 14:40, Kevin Wolf wrote:
Am 22.11.2013 um 17:10 hat Max Reitz geschrieben:
Use an Error variable in the read_config() function.
Signed-off-by: Max Reitz
---
block/blkdebug.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/block/blkdebug.c b/blo
Here are a few remaining bits from the trivial patches queue.
Paolo already picked some so this time the queue is smaller than usual.
Please pull.
The following changes since commit c0caec178eadbbac4c672110c3914313091e0588:
Merge remote-tracking branch 'mst/tags/for_anthony' into staging (2013
On 11/25/2013 12:28 PM, Max Reitz wrote:
> Performing multiple drive-mirror blockjobs on the same qemu instance
> results in the image file used for the block device being replaced by
> the newly mirrored file, which is not what we want.
>
> Fix this by performing one dedicated test per sync mode.
1 - 100 of 244 matches
Mail list logo
