[Qemu-devel] [PATCH v3] qmp: access the local QemuOptsLists for drive option

2013-11-08 Thread Amos Kong
Currently we have three QemuOptsList (qemu_common_drive_opts, qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts is added to vm_config_groups[]. This patch changes query-command-line-options to access three local QemuOptsLists for drive option, and merge the description items toget

Re: [Qemu-devel] [PATCH v2] qmp: access the local QemuOptsLists for drive option

2013-11-08 Thread Fam Zheng
On 11/09/2013 11:19 AM, Amos Kong wrote: On Fri, Nov 08, 2013 at 05:18:02PM +0800, Fam Zheng wrote: Looks good to me. Two small comments below. On Wed, 11/06 13:16, Amos Kong wrote: Currently we have three QemuOptsList (qemu_common_drive_opts, qemu_legacy_drive_opts, and qemu_drive_opts), only

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

2013-11-08 Thread Amos Kong
On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: > What about this approach? This only updates the monitory when all the > bits have been written to. Hi Vlad, Looks good to me. Using this patch, we don't need to care the writing order. If we add event notify in future, it can red

Re: [Qemu-devel] [PATCH v2] qmp: access the local QemuOptsLists for drive option

2013-11-08 Thread Amos Kong
On Fri, Nov 08, 2013 at 05:18:02PM +0800, Fam Zheng wrote: > Looks good to me. Two small comments below. > > On Wed, 11/06 13:16, Amos Kong wrote: > > Currently we have three QemuOptsList (qemu_common_drive_opts, > > qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts > > is added t

Re: [Qemu-devel] [PATCH 0/4] i440fx-test: check firmware visibility

2013-11-08 Thread Laszlo Ersek
On 11/09/13 01:04, Laszlo Ersek wrote: > Laszlo Ersek (4): > i440fx-test: qtest_start() should be paired with qtest_end() > i440fx-test: give each GTest case its own qtest > i440fx-test: generate temporary firmware blob > i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash

[Qemu-devel] [PATCH 0/4] i440fx-test: check firmware visibility

2013-11-08 Thread Laszlo Ersek
Marcel's commit commit a53ae8e934cd54686875b5bcfc2f434244ee55d6 Author: Marcel Apfelbaum Date: Mon Sep 16 11:21:16 2013 +0300 hw/pci: partially handle pci master abort has exposed a conflict (an unintended, unordered overlap) between the memory ranges "pci-hole" and "system.flash"

[Qemu-devel] [PATCH 1/4] i440fx-test: qtest_start() should be paired with qtest_end()

2013-11-08 Thread Laszlo Ersek
Similarly to commit 1d9358e6 ("libqtest: New qtest_end() to go with qtest_start()"). Signed-off-by: Laszlo Ersek --- tests/i440fx-test.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c index 08ce820..422f7be 100644 --- a/te

Re: [Qemu-devel] [PATCH v2] target-ppc: move POWER7+ to a separate family

2013-11-08 Thread Alexey Kardashevskiy
On 11/09/2013 03:59 AM, Andreas Färber wrote: > Am 08.11.2013 15:54, schrieb Alexey Kardashevskiy: >> On 11/09/2013 12:44 AM, Andreas Färber wrote: >>> Am 08.11.2013 03:37, schrieb Alexey Kardashevskiy: So far POWER7+ was a part of POWER7 family. However it has a different PVR base value

[Qemu-devel] [PATCH 2/4] i440fx-test: give each GTest case its own qtest

2013-11-08 Thread Laszlo Ersek
The current two GTest cases, /i440fx/defaults and /i440fx/pam can share a qemu process, but the next two cases will need dedicated instances. It is messy (and order-dependent) to dynamically configure GTest cases one by one to start, stop, or keep the current qtest (*); let's just have each GTest w

[Qemu-devel] [PATCH 3/4] i440fx-test: generate temporary firmware blob

2013-11-08 Thread Laszlo Ersek
The blob is 64K in size and contains 0x00..0xFF repeatedly. The client code added to main() wouldn't make much sense in the long term. It helps with debugging and it silences gcc about create_firmware() being unused, and we'll replace it in the next patch anyway. Signed-off-by: Laszlo Ersek ---

[Qemu-devel] [PATCH 4/4] i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash

2013-11-08 Thread Laszlo Ersek
Check whether the firmware is not hidden by other memory regions. Qemu is started in paused mode: it shouldn't try to interpret generated garbage. Signed-off-by: Laszlo Ersek --- tests/i440fx-test.c | 81 + 1 file changed, 75 insertions(+), 6

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-11-08 Thread Chris J Arges
** Changed in: qemu-kvm (Ubuntu Quantal) Assignee: Chris J Arges (arges) => (unassigned) ** Changed in: qemu-kvm (Ubuntu Raring) Assignee: Chris J Arges (arges) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU

Re: [Qemu-devel] [PATCH] PPC: fix PCI configuration space MemoryRegions for grackle/uninorth

2013-11-08 Thread Mark Cave-Ayland
On 08/11/13 03:20, Alexander Graf wrote: On 11.10.2013, at 12:53, Mark Cave-Ayland wrote: OpenBIOS prior to SVN r1225 had a horrible bug when accessing PCI configuration space for PPC Mac architectures - instead of writing the PCI configuration data value to the data register address, it woul

Re: [Qemu-devel] [PATCH V5 6/6] qemu-iotests: add test for qcow2 snapshot

2013-11-08 Thread Jeff Cody
On Tue, Nov 05, 2013 at 08:01:29AM +0800, Wenchao Xia wrote: > This test will focus on the low level procedure of qcow2 snapshot > operations, now it covers only the create operation. Overlap error > paths are not checked since no good way to trigger those errors. > > Signed-off-by: Wenchao Xia >

[Qemu-devel] [Bug 1243287] Re: [KVM/QEMU][ARM][SAUCY] fails to boot cloud-image due to host kvm fail

2013-11-08 Thread Andreas Färber
Manoj, dmidecode seems highly x86-specific according to http://www.nongnu.org/dmidecode/, so not running it on arm does seem a correct solution for closing this bug. Suggest you assign it back to cloud-init to have that fixed. An alternative to checking for the command's presence would be checki

[Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

2013-11-08 Thread Vlad Yasevich
What about this approach? This only updates the monitory when all the bits have been written to. -vlad -- >8 -- Subject: [PATCH] e1000/rtl8139: update HMP NIC when every bit is written We currently just update the HMP NIC info when the last bit of macaddr is written. This assumes that guest dri

Re: [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements

2013-11-08 Thread Peter Lieven
Am 08.11.2013 um 19:03 schrieb ronnie sahlberg : > It would mean that any version of libiscsi from 1.1 or later would > work and there would not be the issues such as > UNMAP is only available from 1.2 and forward, WRITESAME* is only > availabel from 1.3. I think 1.3.0 is not a big requireme

Re: [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements

2013-11-08 Thread Peter Lieven
Am 08.11.2013 um 18:52 schrieb ronnie sahlberg : > For better support for older versions of libiscsi > I think it would be good to convert all the > iscsi_unmap_task/iscsi_writesame*_task/iscsi_*_task functions with > calls to the much more genric iscsi_scsi_command_sync(). > > iscsi_scsi_comm

[Qemu-devel] [Bug 1243287] Re: [KVM/QEMU][ARM][SAUCY] fails to boot cloud-image due to host kvm fail

2013-11-08 Thread Peter Maydell
(1) If you are trying to mmap /dev/mem then you are going to be accessing physical addresses. This is obviously totally board specific. In particular the memory layout between a Midway system and a KVM virtual machine is likely to be different (you don't say what QEMU configuration you're using) so

Re: [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements

2013-11-08 Thread ronnie sahlberg
It would mean that any version of libiscsi from 1.1 or later would work and there would not be the issues such as UNMAP is only available from 1.2 and forward, WRITESAME* is only availabel from 1.3. SANITIZE only being available from 1.9 ... On Fri, Nov 8, 2013 at 9:52 AM, ronnie sahlberg wr

Re: [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements

2013-11-08 Thread ronnie sahlberg
For better support for older versions of libiscsi I think it would be good to convert all the iscsi_unmap_task/iscsi_writesame*_task/iscsi_*_task functions with calls to the much more genric iscsi_scsi_command_sync(). iscsi_scsi_command_sync() and iscsi_scsi_command_async() have been available s

[Qemu-devel] [Bug 1243287] Re: [KVM/QEMU][ARM][SAUCY] fails to boot cloud-image due to host kvm fail

2013-11-08 Thread Manoj Iyer
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1243287 Title: [KVM/QEMU][ARM][SAUCY] fails to boot cloud-image due to host kvm fail Status in QEM

Re: [Qemu-devel] [PATCH] virtio-net: Correctly store multicast filter entries

2013-11-08 Thread Vlad Yasevich
On 11/08/2013 11:07 AM, Vlad Yasevich wrote: Commit 921ac5d0f3a0df869db5ce4edf752f51d8b1596a virtio-net: remove layout assumptions for ctrl vq introduced a regression where the multicast address filter entries are written to the beginning of the mac table array, thus overwriting any unic

Re: [Qemu-devel] [RFC PATCH] i386: Add _PXM method to ACPI CPU objects

2013-11-08 Thread Igor Mammedov
On Fri, 8 Nov 2013 12:22:12 +0200 Vasilis Liaskovitis wrote: > Hi, > > On Thu, Nov 07, 2013 at 03:03:42PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 07, 2013 at 01:41:59PM +0100, Vasilis Liaskovitis wrote: > > > This patch adds a _PXM method to ACPI CPU objects for the pc machine. The > >

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Laszlo Ersek
On 11/08/13 18:15, Paolo Bonzini wrote: > Il 08/11/2013 18:09, Andreas Färber ha scritto: >> I don't have personal experience with using external files there yet, >> but I was hoping that using -pflash pc-bios/bios.bin would just work >> since that'll be symlinked for execution from build directory

Re: [Qemu-devel] [PATCH V4 5/5] qemu-iotests: add test for snapshot in qemu-img convert

2013-11-08 Thread Jeff Cody
On Fri, Oct 11, 2013 at 10:33:31AM +0800, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > tests/qemu-iotests/058 | 19 ++- > tests/qemu-iotests/058.out | 12 > 2 files changed, 30 insertions(+), 1 deletions(-) > > diff --git a/tests/qemu-iotests/058 b

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Paolo Bonzini
Il 08/11/2013 18:09, Andreas Färber ha scritto: > I don't have personal experience with using external files there yet, > but I was hoping that using -pflash pc-bios/bios.bin would just work > since that'll be symlinked for execution from build directory iiuc. > > My thinking was the test could th

Re: [Qemu-devel] [PATCH V4 3/5] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

2013-11-08 Thread Jeff Cody
On Fri, Oct 11, 2013 at 10:33:29AM +0800, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > tests/qemu-iotests/058 | 102 > > tests/qemu-iotests/058.out | 32 ++ > tests/qemu-iotests/check |1 + > tests/qemu-iotests/grou

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Andreas Färber
Am 08.11.2013 17:19, schrieb Laszlo Ersek: > On 11/08/13 16:42, Andreas Färber wrote: >> Jordan or Laszlo, >> >> Can either of you please add a small test case to i440fx-test using >> -pflash and doing a read in the PCI hole (or wherever exactly) so that >> we can avoid regressing yet again? :) >

Re: [Qemu-devel] [PATCH v2] target-ppc: move POWER7+ to a separate family

2013-11-08 Thread Andreas Färber
Am 08.11.2013 15:54, schrieb Alexey Kardashevskiy: > On 11/09/2013 12:44 AM, Andreas Färber wrote: >> Am 08.11.2013 03:37, schrieb Alexey Kardashevskiy: >>> So far POWER7+ was a part of POWER7 family. However it has a different >>> PVR base value so in order to support PVR masks, it needs a separat

Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code

2013-11-08 Thread Jan Kiszka
On 2013-11-08 16:39, Gerd Hoffmann wrote: > Hi, > >> OK, then here is the first issue I ran into while trying libusbx (git >> head, i.e. 1.0.17+: The new stack causes significant latency issues that >> makes it almost unusable for pass-through of USB audio devices (some >> headset in my case). R

[Qemu-devel] [PULL 1/3] net: disallow to specify multicast MAC address

2013-11-08 Thread Stefan Hajnoczi
From: Dmitry Krivenok [Assigning a multicast MAC address to a NIC leads to confusing behavior. Reject multicast MAC addresses so users are alerted to their error straight away. The "net/eth.h" in6_addr rename prevents a name collision with on Linux. -- Stefan] Signed-off-by: Dmitry V. Krivenok

[Qemu-devel] [PULL 3/3] virtio-net: broken RX filtering logic fixed

2013-11-08 Thread Stefan Hajnoczi
From: Dmitry Fleytman Upon processing of VIRTIO_NET_CTRL_MAC_TABLE_SET command multicast list overwrites unicast list in mac_table. This leads to broken logic for both unicast and multicast RX filtering. Signed-off-by: Dmitry Fleytman Signed-off-by: Stefan Hajnoczi --- hw/net/virtio-net.c | 3

[Qemu-devel] [PULL for-1.7 0/3] Net patches

2013-11-08 Thread Stefan Hajnoczi
Bug fixes for QEMU 1.7. The following changes since commit 964668b03d26f0b5baa5e5aff0c966f4fcb76e9e: Update version for 1.7.0-rc0 release (2013-11-06 21:49:39 -0800) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetch changes up to cc386e96727442

[Qemu-devel] [PULL 2/3] net: fix qemu_flush_queued_packets() in presence of a hub

2013-11-08 Thread Stefan Hajnoczi
From: Sergey Fedorov Do not return after net_hub_flush(). Always flush callee network client incoming queue. Signed-off-by: Sergey Fedorov Signed-off-by: Stefan Hajnoczi --- net/net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/net.c b/net/net.c index 870d3bb..0a88e68 100644 --- a/

Re: [Qemu-devel] [PATCH 0/2] Re: exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Igor Mammedov
On Thu, 7 Nov 2013 23:23:57 +0100 Laszlo Ersek wrote: > On 11/07/13 22:24, Marcel Apfelbaum wrote: > > > Why pci-hole and system.flash collide? IMHO we should not play with > > priorities here, better solve the collision. > > What about this "beautiful" series? It produces Laszlo, there is pa

Re: [Qemu-devel] [PATCH V6 2/5] qemu-img: Add infinite loop checking in bdrv_new_open()

2013-11-08 Thread Stefan Weil
See more suggestions below. Am 08.11.2013 17:19, schrieb Jeff Cody: > On Tue, Nov 05, 2013 at 10:09:18PM -0500, Xu Wang wrote: >> Every image should be checked if there is infinite loop in backing >> file chain before open it. So infinite loop check was added into. ... if there is an infinite loo

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Paolo Bonzini
Il 08/11/2013 17:19, Laszlo Ersek ha scritto: > I'm not very familiar with external files in tests though. Can I model > it on "qdict-test-data.txt"? > > "qdict-test-data.txt" is located in the root source directory. When > configure runs outside the root source directory (= separate build dir), >

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Marcel Apfelbaum
On Fri, 2013-11-08 at 17:12 +0100, Paolo Bonzini wrote: > Il 08/11/2013 16:08, Marcel Apfelbaum ha scritto: > > Actually, as I see, the default behavior of "system" memory region > > is to use unassigned_mem_ops that has valid.accepts method returning > > false (no read/write methods). I don't see

Re: [Qemu-devel] [PATCH V6 2/5] qemu-img: Add infinite loop checking in bdrv_new_open()

2013-11-08 Thread Jeff Cody
On Tue, Nov 05, 2013 at 10:09:18PM -0500, Xu Wang wrote: > Every image should be checked if there is infinite loop in backing > file chain before open it. So infinite loop check was added into > bdrv_new_open(). If @filename is opened without the flag > BDRV_O_NO_BACKING, the infinite loop check sh

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Laszlo Ersek
On 11/08/13 16:42, Andreas Färber wrote: > Am 07.11.2013 21:27, schrieb Jordan Justen: >> On Sun, Nov 3, 2013 at 12:48 PM, Marcel Apfelbaum >> wrote: >>> The commit: >>> >>> Commit: a53ae8e934cd54686875b5bcfc2f434244ee55d6 >>> Author: Marcel Apfelbaum >>> Date: Mon Sep 16 11:21:16 2013 +0300 >

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Paolo Bonzini
Il 08/11/2013 16:08, Marcel Apfelbaum ha scritto: > Actually, as I see, the default behavior of "system" memory region > is to use unassigned_mem_ops that has valid.accepts method returning > false (no read/write methods). I don't see that read all-ones/ignore > writes is implemented. Right, it's

[Qemu-devel] [PATCH] virtio-net: Correctly store multicast filter entries

2013-11-08 Thread Vlad Yasevich
Commit 921ac5d0f3a0df869db5ce4edf752f51d8b1596a virtio-net: remove layout assumptions for ctrl vq introduced a regression where the multicast address filter entries are written to the beginning of the mac table array, thus overwriting any unicast addresses that may have been programmed in

Re: [Qemu-devel] [PATCH 00/14] VSX Stage 4

2013-11-08 Thread Andreas Färber
Hi, Am 06.11.2013 21:31, schrieb Tom Musta: > This is the fourth and final series of patches that add emulation support > to QEMU for the PowerPC Vector Scalar Extension (VSX). [...] > target-ppc/cpu.h|4 +- > target-ppc/fpu_helper.c | 191 >

Re: [Qemu-devel] [PATCH v2] e1000: initial link negotiation on mac osx

2013-11-08 Thread Gabriel L. Somlo
On Fri, Nov 08, 2013 at 02:39:25PM +0100, Stefan Hajnoczi wrote: > On Fri, Nov 08, 2013 at 12:12:52AM +0100, Alexander Graf wrote: >> We can easily modify SeaBIOS to just loop through all PCI devices, >> look for an e1000 and initialize it far enough for XNU, no? >> After all, it sounds like that's

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Andreas Färber
Am 07.11.2013 21:27, schrieb Jordan Justen: > On Sun, Nov 3, 2013 at 12:48 PM, Marcel Apfelbaum wrote: >> The commit: >> >> Commit: a53ae8e934cd54686875b5bcfc2f434244ee55d6 >> Author: Marcel Apfelbaum >> Date: Mon Sep 16 11:21:16 2013 +0300 >> >> hw/pci: partially handle pci master abort >>

Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code

2013-11-08 Thread Gerd Hoffmann
Hi, > OK, then here is the first issue I ran into while trying libusbx (git > head, i.e. 1.0.17+: The new stack causes significant latency issues that > makes it almost unusable for pass-through of USB audio devices (some > headset in my case). Reverting usb-linux and disabling libusb over QEMU

Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1()

2013-11-08 Thread Peter Maydell
On 8 November 2013 15:27, Laszlo Ersek wrote: > On 11/08/13 16:16, Peter Maydell wrote: >> That said, having to pass the size of a sub-sub-region >> all the way back up the call stack is very odd and makes >> me wonder if it's really the right way to do it... >> The top level shouldn't have to car

Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1()

2013-11-08 Thread Laszlo Ersek
On 11/08/13 16:16, Peter Maydell wrote: > On 8 November 2013 15:07, Laszlo Ersek wrote: >> On 11/08/13 07:09, Jordan Justen wrote: >>> int64_t? :) >> >> Heh, yes, I did cringe when I wrote that, but if you check the >> bottom-most function, where the assignment happens, >> pc_system_flash_init(),

Re: [Qemu-devel] Multi-head support RFC

2013-11-08 Thread John Baboval
On 11/06/2013 06:44 PM, Dave Airlie wrote: On Wed, Nov 6, 2013 at 8:57 PM, Gerd Hoffmann wrote: Hi, It currently just adds multiple DisplaySurfaces to the QemuConsole, now Gerd said he thought I should be using multiple QemuConsoles but I really didn't think this was a good idea, Why? It

Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1()

2013-11-08 Thread Peter Maydell
On 8 November 2013 15:07, Laszlo Ersek wrote: > On 11/08/13 07:09, Jordan Justen wrote: >> int64_t? :) > > Heh, yes, I did cringe when I wrote that, but if you check the > bottom-most function, where the assignment happens, > pc_system_flash_init(), it declares the local "size" variable as > int64

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Marcel Apfelbaum
On Fri, 2013-11-08 at 10:44 +, Peter Maydell wrote: > On 8 November 2013 08:05, Paolo Bonzini wrote: > > Il 07/11/2013 22:51, Peter Maydell ha scritto: > >>> > 1. Not all architectures have the behavior: "Address space that is not > >>> > RAM(and friends) > >>> > is for sure PCI". Only x8

Re: [Qemu-devel] [PATCH v2 00/39] bitmap handling optimization

2013-11-08 Thread Chegu Vinod
On 11/6/2013 5:04 AM, Juan Quintela wrote: Hi [v2] In this version: - fixed all the comments from last versions (thanks Eric) - kvm migration bitmap is synchronized using bitmap operations - qemu bitmap -> migration bitmap is synchronized using bitmap operations If bitmaps are not properly align

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Marcel Apfelbaum
On Fri, 2013-11-08 at 09:05 +0100, Paolo Bonzini wrote: > Il 07/11/2013 22:51, Peter Maydell ha scritto: > >> > 1. Not all architectures have the behavior: "Address space that is not > >> > RAM(and friends) > >> > is for sure PCI". Only x86 behaves like this (I think). > > > > More specifical

Re: [Qemu-devel] [PATCH 00/14] VSX Stage 4

2013-11-08 Thread Tom Musta
On 11/7/2013 6:23 PM, Richard Henderson wrote: > On 11/07/2013 06:31 AM, Tom Musta wrote: >> The single-precision scalar arithmetic instructions all interpret the most >> significant 64 bits of a VSR as a single precision floating point number >> stored in double precision format (similar to the st

Re: [Qemu-devel] [PATCH] 82571 emulation

2013-11-08 Thread Stefan Hajnoczi
On Thu, Nov 07, 2013 at 11:06:06AM -0800, akepner wrote: > First cut at emulating 82571. I'm sure there are lots of rough > edges, but it's working for me. > > Pretty obviously I started with a copy of the e1000 code, and > modified just what was necessary to get it working. I'd like > to also do

Re: [Qemu-devel] [PATCH V6 1/5] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list()

2013-11-08 Thread Jeff Cody
On Fri, Nov 08, 2013 at 06:53:27AM -0700, Eric Blake wrote: > On 11/08/2013 03:19 AM, Fam Zheng wrote: > > > >> +BlockDriverState *bs; > >> +BlockDriver *drv; > >> +char fbuf[1024]; > > > > Could use PATH_MAX. > > PATH_MAX is undefined on some platforms, and could also be defined to

Re: [Qemu-devel] [PATCH] spapr: add "compat" machine option

2013-11-08 Thread Andreas Färber
Am 08.11.2013 15:57, schrieb Alexey Kardashevskiy: > On 11/09/2013 12:20 AM, Andreas Färber wrote: > >> When I am finally through with review of Igor's patches then he can >> implement that for x86 and we/you can copy or adapt it for ppc. No need >> to do big experiments for a concretely needed pp

Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1()

2013-11-08 Thread Laszlo Ersek
On 11/08/13 07:09, Jordan Justen wrote: > On Thu, Nov 7, 2013 at 2:23 PM, Laszlo Ersek wrote: >> ... upwards through the following call chain: >> >> pc_init1() | pc_q35_init() >> pc_memory_init() >> pc_system_firmware_init() >> pc_system_flash_init() >> >> Signed-off-by: Laszlo

Re: [Qemu-devel] [PATCH] spapr: add "compat" machine option

2013-11-08 Thread Alexey Kardashevskiy
On 11/09/2013 12:20 AM, Andreas Färber wrote: > When I am finally through with review of Igor's patches then he can > implement that for x86 and we/you can copy or adapt it for ppc. No need > to do big experiments for a concretely needed ppc feature. Does it mean I better stop wasting your time a

Re: [Qemu-devel] [PATCH v2] target-ppc: move POWER7+ to a separate family

2013-11-08 Thread Alexey Kardashevskiy
On 11/09/2013 12:44 AM, Andreas Färber wrote: > Am 08.11.2013 03:37, schrieb Alexey Kardashevskiy: >> So far POWER7+ was a part of POWER7 family. However it has a different >> PVR base value so in order to support PVR masks, it needs a separate >> family class. >> > > Alexey, > >> Another reason

Re: [Qemu-devel] [PATCH] util/error: Save errno from clobbering

2013-11-08 Thread Stefan Hajnoczi
On Thu, Nov 07, 2013 at 08:10:29PM +0100, Max Reitz wrote: > There may be calls to error_setg() and especially error_setg_errno() > which blindly (and until now wrongly) assume these functions not to > clobber errno (e.g., they pass errno to error_setg_errno() and return > -errno afterwards). Inste

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add netmap maintainers

2013-11-08 Thread Stefan Hajnoczi
On Wed, Nov 06, 2013 at 06:34:55PM +0100, Vincenzo Maffione wrote: > Signed-off-by: Vincenzo Maffione > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) Thanks, applied to my net-next tree: https://github.com/stefanha/qemu/commits/net-next Stefan

Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code

2013-11-08 Thread Jan Kiszka
On 2013-10-09 13:42, Gerd Hoffmann wrote: > Hi, > Only very recent distros fulfill the need of >= 1.0.13, so you naturally fall back to this code. I just realized that even the factory build of OpenSUSE is still on libusb-1.0.9. Current Ubuntu versions are on 1.0.12 at best.

Re: [Qemu-devel] [PATCH V6 1/5] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list()

2013-11-08 Thread Eric Blake
On 11/08/2013 03:19 AM, Fam Zheng wrote: > >> +BlockDriverState *bs; >> +BlockDriver *drv; >> +char fbuf[1024]; > > Could use PATH_MAX. PATH_MAX is undefined on some platforms, and could also be defined to something larger than a page which could lead to nastiness if you end up overf

Re: [Qemu-devel] [PATCH for-1.7 v2] block: Print its file name if backing file opening failed

2013-11-08 Thread Eric Blake
On 11/07/2013 08:26 PM, Fam Zheng wrote: > If backing file doesn't exist, the error message is confusing and > misleading: > > $ qemu /tmp/a.qcow2 > qemu: could not open disk image /tmp/a.qcow2: Could not open file: No > such file or directory > > This is not intuitive. It's better t

Re: [Qemu-devel] [PATCH v2] target-ppc: move POWER7+ to a separate family

2013-11-08 Thread Andreas Färber
Am 08.11.2013 03:37, schrieb Alexey Kardashevskiy: > So far POWER7+ was a part of POWER7 family. However it has a different > PVR base value so in order to support PVR masks, it needs a separate > family class. > Alexey, > Another reason to make a POWER7+ family is that its name in the device >

Re: [Qemu-devel] [PATCH v2] e1000: initial link negotiation on mac osx

2013-11-08 Thread Stefan Hajnoczi
On Fri, Nov 08, 2013 at 12:12:52AM +0100, Alexander Graf wrote: > Am 07.11.2013 um 21:28 schrieb "Gabriel L. Somlo" : > > > Some guest operating systems' drivers (particularly Mac OS X) > > expect the link state to be pre-initialized by an earlier > > component such as a proprietary BIOS. This pat

Re: [Qemu-devel] [PATCH v2 0/2] spapr: add "compat" machine option

2013-11-08 Thread Andreas Färber
Am 08.11.2013 09:22, schrieb Alexey Kardashevskiy: > On 11/08/2013 01:01 AM, Andreas Färber wrote: >> Please do separate these global preparations from the actual new ppc >> property. Elsewhere it was discussed whether to use a readable string >> value, which might hint at a dynamic property of typ

Re: [Qemu-devel] [PATCH] spapr: add "compat" machine option

2013-11-08 Thread Andreas Färber
Am 08.11.2013 09:22, schrieb Alexey Kardashevskiy: > On 11/08/2013 12:36 AM, Igor Mammedov wrote: >> On Thu, 7 Nov 2013 20:11:51 +1100 >> Alexey Kardashevskiy wrote: >> >>> On 11/06/2013 12:53 AM, Andreas Färber wrote:> Am 05.11.2013 10:52, schrieb >>> Paolo Bonzini: > Il 05/11/2013 10:16, A

[Qemu-devel] [PULL v2 12/37] libqtest: rename qmp() to qmp_discard_response()

2013-11-08 Thread Stefan Hajnoczi
Existing qmp() callers do not expect a response object. In order to implement real QMP test cases it will be necessary to inspect the response object. Rename qmp() to qmp_discard_response(). Later patches will introduce a qmp() function that returns the response object and tests that use it. Si

[Qemu-devel] [PULL v2 14/37] blockdev-test: add test case for drive_add duplicate IDs

2013-11-08 Thread Stefan Hajnoczi
The following should work: (qemu) drive_add if=none,id=drive0 (qemu) drive_del drive0 (qemu) drive_add if=none,id=drive0 Previous versions of QEMU produced a duplicate ID error because drive_add leaked the options. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- tests/Makefil

[Qemu-devel] [PULL v2 11/37] blockdev: fix drive_init() opts and bs_opts leaks

2013-11-08 Thread Stefan Hajnoczi
These memory leaks also make drive_add if=none,id=drive0 without a file= option leak the options list. This keeps ID "drive0" around forever. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- blockdev.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-

Re: [Qemu-devel] virtio-net performance on mach-virt.

2013-11-08 Thread Giridhar Maruthy
Hi Paolo, Many apologies to you, I did not reply to you earlier. I somehow missed your email. The command I used was sudo qemu-system-arm -enable-kvm -kernel zImage -machine type=virt -display none -cpu cortex-a15 -m 512 -append 'console=ttyAMA0 root=/dev/vda ip=192.168.42.24:192.168.42.1:192.16

[Qemu-devel] [PULL v2 19/37] block: vhdx - add header update capability.

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody This adds the ability to update the headers in a VHDX image, including generating a new MS-compatible GUID. As VHDX depends on uuid.h, VHDX is now a configurable build option. If VHDX support is enabled, that will also enable uuid as well. The default is to have VHDX enabled.

[Qemu-devel] [PULL v2 17/37] block/vpc: fix virtual size for images created with disk2vhd

2013-11-08 Thread Stefan Hajnoczi
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block/vpc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block/vpc.c b/block/vpc.c index 627d11c..577cc45 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -211,6 +211,15 @@ static int vpc_open(BlockD

Re: [Qemu-devel] [PATCH v3] Fix pc migration from qemu <= 1.5

2013-11-08 Thread David Gibson
On Tue, Nov 05, 2013 at 06:46:27PM -0500, Cole Robinson wrote: > The following commit introduced a migration incompatibility: > > commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe > Author: David Gibson > Date: Thu Jun 6 18:48:49 2013 +1000 > > pci: Replace pci_find_domain() with more genera

[Qemu-devel] reverting commit a53ae8e934cd54686875b5bcfc2f434244ee55d6 Re: [edk2] [PATCH 0/2] Re: exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Paolo Bonzini
Il 07/11/2013 23:23, Laszlo Ersek ha scritto: > On 11/07/13 22:24, Marcel Apfelbaum wrote: >> Why pci-hole and system.flash collide? IMHO we should not play with >> priorities here, better solve the collision. > > What about this "beautiful" series? It produces > > memory > -000ff

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Paolo Bonzini
Il 08/11/2013 11:44, Peter Maydell ha scritto: > On 8 November 2013 08:05, Paolo Bonzini wrote: >> Il 07/11/2013 22:51, Peter Maydell ha scritto: > 1. Not all architectures have the behavior: "Address space that is not > RAM(and friends) > is for sure PCI". Only x86 behaves like t

[Qemu-devel] [PULL v2 02/37] qemu-iotests: Filter out actual image size in 067

2013-11-08 Thread Stefan Hajnoczi
From: Max Reitz The actual size of the image file may differ depending on the Linux kernel currently running on the host. Filtering out this value makes this test pass in such cases. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/067

[Qemu-devel] [PULL v2 32/37] block: vhdx - fix comment typos in header, fix incorrect struct fields

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody VHDXPage83Data and VHDXParentLocatorHeader both incorrectly had their MSGUID fields set as arrays of 16. This is incorrect (it stems from an early version where those fields were uint_8 arrays). Those fields were, up to this patch, unused. Also, there were a couple of typos and

[Qemu-devel] [PULL v2 24/37] block: vhdx code movement - move vhdx_close() above vhdx_open()

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- block/vhdx.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index 241703a..3f06ce3 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -778,6 +778,1

Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size

2013-11-08 Thread Peter Maydell
On 8 November 2013 08:05, Paolo Bonzini wrote: > Il 07/11/2013 22:51, Peter Maydell ha scritto: >>> > 1. Not all architectures have the behavior: "Address space that is not >>> > RAM(and friends) >>> > is for sure PCI". Only x86 behaves like this (I think). >> >> More specifically, the x86 pc

Re: [Qemu-devel] [PATCH V6 5/5] blockdev: Add infinite loop check in drive_init()

2013-11-08 Thread Fam Zheng
On Tue, 11/05 22:09, Xu Wang wrote: > Check the backing file for a loop during image boot, to avoid a lack or > response or segfault. > > Signed-off-by: Xu Wang > --- > blockdev.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/blockdev.c b/blockdev.c > index b260477..7c0927f 100

Re: [Qemu-devel] [PATCH V6 3/5] block: Add check infinite loop in bdrv_img_create()

2013-11-08 Thread Fam Zheng
On Tue, 11/05 22:09, Xu Wang wrote: > Backing file loop should be checked before qemu-img create command > execution. If loop is found, qemu-img create should be stopped and > an error printed. > > Signed-off-by: Xu Wang > --- > block.c | 8 > 1 file changed, 4 insertions(+), 4 deletion

Re: [Qemu-devel] [PATCH V6 2/5] qemu-img: Add infinite loop checking in bdrv_new_open()

2013-11-08 Thread Fam Zheng
On Tue, 11/05 22:09, Xu Wang wrote: > Every image should be checked if there is infinite loop in backing > file chain before open it. So infinite loop check was added into > bdrv_new_open(). If @filename is opened without the flag > BDRV_O_NO_BACKING, the infinite loop check should be called. > >

[Qemu-devel] [PULL v2 35/37] block: qemu-iotests for vhdx, add write test support

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody This removes the IMGFMT_GENERIC blocker for read-only, so existing iotests run read/write tests for vhdx images created by qemu-img (e.g. tests 001, 002, 003). In addition, this updates the sample image test for the Hyper-V created image, to verify we can write it as well. Signe

[Qemu-devel] [PULL v2 28/37] block: vhdx write support

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody This adds support for writing to VHDX image files, using coroutines. Writes into the BAT table goes through the VHDX log. Currently, BAT table writes occur when expanding a dynamic VHDX file, and allocating a new BAT entry. Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnocz

[Qemu-devel] [PULL v2 23/37] block: vhdx - update log guid in header, and first write tracker

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody Allow tracking of first file write in the VHDX image, as well as the ability to update the GUID in the header. This is in preparation for log support. Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- block/vhdx.c | 30 -- block/vhdx.h |

[Qemu-devel] [PULL v2 26/37] block: vhdx - add region overlap detection for image files

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody Regions in the image file cannot overlap - the log, region tables, and metdata must all be unique and non-overlapping. This adds region checking by means of a QLIST; there can be a variable number of regions and metadata (there may be metadata or region tables that we do not reco

[Qemu-devel] [PULL v2 10/37] block: qemu-iotests, add quotes to $TEST_IMG usage in 061

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody When creating images with backing files in the test, the backing file argument was not quoted properly. This caused the test to fail when run from a pathname with a space. Pass the backing argument in with the -b option to _make_test_img, so it can be properly quoted. Signed-of

Re: [Qemu-devel] [RFC PATCH] i386: Add _PXM method to ACPI CPU objects

2013-11-08 Thread Vasilis Liaskovitis
Hi, On Thu, Nov 07, 2013 at 03:03:42PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 07, 2013 at 01:41:59PM +0100, Vasilis Liaskovitis wrote: > > This patch adds a _PXM method to ACPI CPU objects for the pc machine. The > > _PXM > > value is derived from the passed in guest info, same way as CPU

[Qemu-devel] [PULL v2 34/37] block: vhdx - update _make_test_img() to filter out vhdx options

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody The non-global option output is suppresed in _make_test_img() for output verification in the 0?? tests. This adds suppression for the vhdx-unique options as well. This allows check -vhdx to run successfully. Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- tests/q

[Qemu-devel] [PULL v2 22/37] block: vhdx - break endian translation functions out

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody This moves the endian translation functions out from the vhdx.c source, into a separate source file. In addition to the previously defined endian functions, new endian translation functions for log support are added as well. Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnocz

[Qemu-devel] [PULL v2 33/37] block: vhdx - add .bdrv_create() support

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody This adds support for VHDX image creation, for images of type "Fixed" and "Dynamic". "Differencing" types (i.e., VHDX images with backing files) are currently not supported. Options for image creation include: * log size: The size of the journaling log for VHDX. Min

Re: [Qemu-devel] [PATCH V6 1/5] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list()

2013-11-08 Thread Fam Zheng
On Tue, 11/05 22:09, Xu Wang wrote: > If there is a loop in the backing file chain, it could cause problems > such as no response or a segfault during system boot. Hence detecting a > backing file loop is necessary. This patch extracts the loop check from > collect_image_info_list() in block.c into

[Qemu-devel] [PULL v2 15/37] qdev-monitor-test: add device_add leak test cases

2013-11-08 Thread Stefan Hajnoczi
Ensure that the device_add error code path deletes device objects. Failure to do so not only leaks the objects but can also keep other objects (like drive or netdev) alive due to qdev properties holding references. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- tests/Makefile

[Qemu-devel] [PULL v2 36/37] block: vhdx qemu-iotest - log replay of data sector

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody This tests the replay of a data sector in a VHDX image file. The image file is a 10G dynamic image, with 4MB block size. The image was created with qemu-img, and the log left unplayed by modification of the vhdx image format driver. It was verified under both QEMU and Hyper-V t

[Qemu-devel] [PULL v2 07/37] block: qemu-iotests, add quotes to $TEST_IMG usage in 019

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody There were still instances of $TEST_IMG not being properly quoted. This was in the usage of a string built up for a 'for' loop; modify the loop so we can quote $TEST_IMG properly. Signed-off-by: Jeff Cody Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- tests/qemu-i

[Qemu-devel] [PULL v2 31/37] block: vhdx - break out code operations to functions

2013-11-08 Thread Stefan Hajnoczi
From: Jeff Cody This is preperation for vhdx_create(). The ability to write headers, and calculate the number of BAT entries will be needed within the create() functions, so move this relevant code into helper functions. Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- block/vhdx.

  1   2   >