On Thu, 7 Nov 2013 23:23:57 +0100 Laszlo Ersek <ler...@redhat.com> wrote:
> On 11/07/13 22:24, Marcel Apfelbaum wrote: > > > Why pci-hole and system.flash collide? IMHO we should not play with > > priorities here, better solve the collision. > > What about this "beautiful" series? It produces Laszlo, there is patch that removes PCI-hole aliases at all mapping PCI address space with -1 priority in system address space. so all access flash region range will go to it sice it's priority 0 > > memory > 0000000000000000-000fffffffffffff (prio 0, RW): system > [...] > 0000000060000000-00000000ffdfffff (prio 0, RW): alias pci-hole @pci > 0000000060000000-00000000ffdfffff > [...] > 00000000ffe00000-00000000ffffffff (prio 0, R-): system.flash > > and I can run OVMF with it. It also stays within i386/pc. > > Re 2/2, note that "below_4g_mem_size" never exceeds 0xe0000000 in > pc_init1(), so the subtraction is safe. > > Thanks > Laszlo > > Laszlo Ersek (2): > i386/pc: propagate flash size from pc_system_flash_init() to > pc_init1() > i386/pc_piix: the pci-hole should end where the system flash starts > > include/hw/i386/pc.h | 6 ++++-- > hw/i386/pc.c | 5 +++-- > hw/i386/pc_piix.c | 5 +++-- > hw/i386/pc_q35.c | 3 ++- > hw/i386/pc_sysfw.c | 10 +++++++--- > 5 files changed, 19 insertions(+), 10 deletions(-) > > -- > 1.8.3.1 > > -- Regards, Igor
