Hi,
> While the actual interesting change (adding break) looks
> correct, and the whole thing is trivial indeed, this area
> has a maintainer, -- Cc'ing Gerd for this. If he's okay
> I'll pick it up.
Patch is fine.
Acked-by: Gerd Hoffmann
cheers,
Gerd
On Mon, 09/30 12:48, yue-kvm wrote:
> hi,all
> if there any documents about snapshot and backing file's theory.
> as we know vmware has composor which can upgrade images(top of backing chain
> ) by upgrading backing file
>
What does "upgrade images" mean?
Thanks,
Fam
于 2013/9/26 8:16, Wenchao Xia 写道:
> This series allow user to read internal snapshot's contents without qemu-img
> convert.
>
> V2:
> Address Stefan's comments:
> 02: add 'fall through' comments in the case statement.
> 03: add doc about the difference of internal snapshot and backing chain
>
Some code are spent for nest case since the build system
does not support subdir Makefile. It would be nice if
qemu can change the build system like kernel's build system one
day, then we can avoid these troubles.
The code looks fine.
Reviewed-by: Wenchao Xia
Reviewed-by: Wenchao Xia
On Tue, Sep 24, 2013 at 04:09:56PM +0200, Juan Quintela wrote:
>
> Hi
>
> Please, send any topic that you are interested in covering.
>
> Last week I forgot to send the call for topics. We still have a topic there.
>
> Thanks, Juan.
>
> Agenda so far:
> - Talk about qemu reverse executing (1s
Reviewed-by: Wenchao Xia
hi,all
if there any documents about snapshot and backing file's theory.
as we know vmware has composor which can upgrade images(top of backing chain )
by upgrading backing file
so i think we can implement it anyway.
now i need some infomations relevant to my idea.
and hope qemu-img developer
I wanted to explore overhead with the new drive-backup command and I
noticed if I set the target to something like '/dev/null' the guest VM
starts having IO errors and loses write access to its root file
system. Here is the qmp-shell command I'm using:
> drive-backup sync=none device=virtio0 targ
Am 29.09.2013 22:13, schrieb Michael Tokarev:
> 29.09.2013 19:41, Stefan Weil wrote:
>> The QEMU buildbot default_i386_debian_6_0 shows this warning:
>>
>>CCmigration.o
>> migration.c: In function 'qmp_query_migrate_capabilities':
>> migration.c:149: warning:
>> 'caps' may be used uniniti
Am 29.09.2013 21:44, schrieb Michael Tokarev:
> 28.09.2013 13:55, Stefan Weil wrote:
[...]
>> diff --git a/blockdev.c b/blockdev.c
>> index 8aa66a9..8c83f6f 100644
>> --- a/blockdev.c
>> +++ b/blockdev.c
>> @@ -1926,7 +1926,6 @@ void qmp_drive_mirror(const char *device, const
>> char *target,
>>
22.09.2013 00:26, Ján Veselý wrote:
Device communication errors need to be reported to driver.
Add a debug message while at it.
Signed-off-by: Jan Vesely
---
hw/usb/hcd-ohci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 35f0878..0396e33 1
29.09.2013 19:41, Stefan Weil wrote:
The QEMU buildbot default_i386_debian_6_0 shows this warning:
CCmigration.o
migration.c: In function 'qmp_query_migrate_capabilities':
migration.c:149: warning:
'caps' may be used uninitialized in this function
Gah, how disgusting. The code is cor
29.09.2013 23:12, Paolo Bonzini wrote:
sh4 is ~orphan so nobody should complain if qemu-trivial picks this up
as well.
Paolo
Il 14/09/2013 06:04, Guenter Roeck ha scritto:
On 09/08/2013 12:39 AM, Guenter Roeck wrote:
With Linux kernel version 3.3 or later, qemu fails with the following
messag
29.09.2013 19:51, Stefan Weil wrote:
From buildbot default_i386_rhel61:
CCalpha-softmmu/hw/alpha/typhoon.o
hw/alpha/typhoon.c: In function 'typhoon_translate_iommu':
hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type
hw/alpha/typhoon.c:703: warning: integer co
29.09.2013 19:55, Stefan Weil wrote:
From buildbot default_i386_rhel61:
CCi386-softmmu/target-i386/arch_memory_mapping.o
target-i386/arch_memory_mapping.c: In function 'walk_pde':
target-i386/arch_memory_mapping.c:110: warning:
integer constant is too large for 'long' type
Thanks, ap
28.09.2013 13:55, Stefan Weil wrote:
blockdev.c:1929:13: warning: Value stored to 'ret' is never read
ret = 0;
^ ~
Applied to the trivial patches queue.
Signed-off-by: Stefan Weil
---
blockdev.c |1 -
1 file changed, 1 deletion(-)
diff --git a/blockdev.c
27.09.2013 11:28, Paolo Bonzini wrote:
Michael, want to pick this up for -trivial?
Reviewed-by: Paolo Bonzini
Il 27/09/2013 03:25, Amos Kong ha scritto:
Touched some error after enabling DEBUG_SUBPAGE.
Thanks, applied to the trivial patches queue.
/mjt
Thanks,
applied to the trivial patches queue.
/mjt
24.09.2013 11:43, arm...@redhat.com wrote:
From: Markus Armbruster
Commit 4f193e3 added the test, but screwed up in-tree builds
(SRCDIR=.): the tests's output overwrites the expected output, and is
thus compared to itself.
[]
.PHONY: $(patsubst %, check-%, $(check-qapi-schema-y))
$(patsu
sh4 is ~orphan so nobody should complain if qemu-trivial picks this up
as well.
Paolo
Il 14/09/2013 06:04, Guenter Roeck ha scritto:
> On 09/08/2013 12:39 AM, Guenter Roeck wrote:
>> With Linux kernel version 3.3 or later, qemu fails with the following
>> message:
>>
>> sh_serial: unsupported rea
phys_mem_alloc and its assigned values qemu_anon_ram_alloc and
legacy_s390_alloc must have identical argument lists.
legacy_s390_alloc uses the size parameter to call mmap, so size_t is
good enough for all of them.
This patch fixes compiler errors on i686 Linux hosts:
CCalpha-softmmu/exec.
On Fri, 27 Sep 2013 04:30:21 +0200
Ákos Kovács wrote:
I have just tryed 'kconfig' branch from your qemu github repo.
Great work!
But I have found new generated Kconfig.targets file in 'git status' 'Untracked
files' section.
Can we add it to the .gitignore file?
> This patchset contains the n
On 09/29/2013 08:51 AM, Stefan Weil wrote:
>>From buildbot default_i386_rhel61:
>
> CCalpha-softmmu/hw/alpha/typhoon.o
> hw/alpha/typhoon.c: In function 'typhoon_translate_iommu':
> hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type
> hw/alpha/typhoon.c:703: warni
>From buildbot default_i386_rhel61:
CCi386-softmmu/target-i386/arch_memory_mapping.o
target-i386/arch_memory_mapping.c: In function 'walk_pde':
target-i386/arch_memory_mapping.c:110: warning:
integer constant is too large for 'long' type
Signed-off-by: Stefan Weil
---
target-i386/arch_me
>From buildbot default_i386_rhel61:
CCalpha-softmmu/hw/alpha/typhoon.o
hw/alpha/typhoon.c: In function 'typhoon_translate_iommu':
hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type
hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type
Sig
The QEMU buildbot default_i386_debian_6_0 shows this warning:
CCmigration.o
migration.c: In function 'qmp_query_migrate_capabilities':
migration.c:149: warning:
'caps' may be used uninitialized in this function
While changing this code, I also replaced g_malloc0
by the type safe g_new0.
S
On Sun, Sep 29, 2013 at 06:24:48PM +0300, Marcel Apfelbaum wrote:
> removed addresses:
> av1...@comtv.ru
> p...@codesourcery.com
>
>
> On Sun, 2013-09-29 at 18:06 +0300, Michael S. Tsirkin wrote:
> > On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote:
> > > Interrupt pin is selected
removed addresses:
av1...@comtv.ru
p...@codesourcery.com
On Sun, 2013-09-29 at 18:06 +0300, Michael S. Tsirkin wrote:
> On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote:
> > Interrupt pin is selected and saved into PCI_INTERRUPT_PIN
> > register during device initialization. Devic
Am 31.07.2013 15:11, schrieb Markus Armbruster:
> All I wanted to do is exit(1) instead of abort() on guest memory
> allocation failure [07/08]. But that lead me into a minor #ifdef bog,
> and here's what I brought back. Enjoy!
>
> Testing:
> * Christian Borntraeger reports v1 works fine under LP
Btw,
while I got your attention, on a not-really related topic: how do we
feel about adding support for specifying a non-contiguous set of cpus
for a numa node in qemu with the -numa option? I.e., like this, for
example:
x86_64-softmmu/qemu-system-x86_64 -smp 8 -numa node,nodeid=0,cpus=0\;2\;4-5
On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote:
> Interrupt pin is selected and saved into PCI_INTERRUPT_PIN
> register during device initialization. Devices should not call
> directly qemu_set_irq and specify the INTx pin.
>
> Replaced the call to qemu_set_irq with a new wrapper
Interrupt pin is selected and saved into PCI_INTERRUPT_PIN
register during device initialization. Devices should not call
directly qemu_set_irq and specify the INTx pin on each call.
Replaced the call to qemu_set_irq with a new wrapper
pci_set_irq which triggers the irq based on PCI_INTERRUPT_PIN.
Interrupt pin is selected and saved into PCI_INTERRUPT_PIN
register during device initialization. Devices should not call
directly qemu_set_irq and specify the INTx pin.
Replaced the call to qemu_set_irq with a new wrapper
pci_set_irq which triggers the irq based on PCI_INTERRUPT_PIN.
Marcel Apfe
pci_set_irq uses PCI_INTERRUPT_PIN config register
to compute device INTx pin to assert/deassert.
Signed-off-by: Marcel Apfelbaum
---
hw/audio/ac97.c| 4 ++--
hw/audio/es1370.c | 2 +-
hw/audio/intel-hda.c | 2 +-
hw/char/serial-pci.c | 2 +-
hw/char/tpci200.c | 4 ++--
hw/
The PCI_INTERRUPT_PIN will be used by shpc init, so
was moved before the call to shpc_init.
Signed-off-by: Marcel Apfelbaum
---
hw/pci-bridge/pci_bridge_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c
index
I added a rtl8139c netcard to the VM and connected through it by RDP -
no more freezes.
It looks like kvm does not play well with virtio network cards and RDP.
Red Hat virtio net windows driver version: 62.65.104.6500, 6/19/2013
I left the RH adapter on the VM, I just connect via RDP through the
This adds APIs that will be used to fill in
acpi tables, implemented using QOM,
to various ich9 components.
Some information is still missing in QOM,
so we fall back on lookups by type instead.
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/ich9.h| 2 ++
include/hw/i386/ich9.h|
update generated file, not sure what changed
Signed-off-by: Michael S. Tsirkin
---
hw/i386/ssdt-pcihp.hex.generated | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/i386/ssdt-pcihp.hex.generated b/hw/i386/ssdt-pcihp.hex.generated
index 0d32a27..b3c2cd5 100644
--- a/
Update generated ssdt proc hex file (used for systems
lacking IASL) after P_BLK length change.
Signed-off-by: Michael S. Tsirkin
---
hw/i386/ssdt-proc.hex.generated | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/i386/ssdt-proc.hex.generated b/hw/i386/ssdt-proc.
Add API to find pvpanic device and get its io port.
Will be used to fill in guest info structure.
Signed-off-by: Michael S. Tsirkin
---
include/hw/i386/pc.h | 1 +
hw/misc/pvpanic.c| 13 -
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/include/hw/i386/pc.h b/incl
This adds APIs that will be used to fill in guest acpi tables.
Some required information is still lacking in QOM, so we
fall back on lookups by type and returning explicit types.
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/piix4.h | 8
include/hw/i386/pc.h| 1 +
hw/acpi/
Add API to find HPET using QOM.
Signed-off-by: Michael S. Tsirkin
---
include/hw/timer/hpet.h | 2 ++
hw/timer/hpet.c | 5 +
2 files changed, 7 insertions(+)
diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h
index 757f79f..ab44bd3 100644
--- a/include/hw/timer/hpet.h
++
Signed-off-by: Michael S. Tsirkin
---
include/hw/i386/pc.h | 10 ++
hw/acpi/piix4.c | 6 +++---
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 7a343f8..f966cef 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/
This adds a dynamic bios linker/loader.
This will be used by acpi table generation
code to:
- load each table in the appropriate memory segment
- link tables to each other
- fix up checksums after said linking
Signed-off-by: Michael S. Tsirkin
---
hw/i386/bios-linker-loader.h | 27 +
We don't really support CPU throttling, so supply 0 PBLK length.
Since this is the first patch that makes the ACPI tables different from
the builtin ones in seabios, this patch is kept separate to allow easier
bisecting in case of problems.
Signed-off-by: Michael S. Tsirkin
---
hw/i386/ssdt-proc
This defines a structure that will be used to fill in acpi tables
where relevant properties are not yet available using QOM.
Signed-off-by: Michael S. Tsirkin
Reviewed-by: Laszlo Ersek
---
include/hw/i386/pc.h | 10 ++
hw/i386/pc.c | 35 +++
2 fil
Detect presence of IASL compiler and use it
to process ASL source. If not there, use pre-compiled
files in-tree. Add script to update the in-tree files.
Note: distros are known to silently update iasl
so detect correct iasl flags for the installed version on each run as
opposed to at configure tim
Callers pass in the address so it's helpful for
them to be able to decode it.
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 21 +
hw/pci/pcie_host.c | 21 -
2 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/inclu
Don't abort if machine done callbacks add ROMs.
Signed-off-by: Michael S. Tsirkin
---
include/hw/loader.h | 1 +
hw/core/loader.c| 6 +-
vl.c| 3 +++
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/hw/loader.h b/include/hw/loader.h
index e0c576b..58e
Address is already exposed, expose size for symmetry.
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 1 +
hw/pci-host/q35.c | 14 ++
2 files changed, 15 insertions(+)
diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h
index 33d75bd..ac
Avoid a bit of code duplication, make
max file path constant reusable.
Suggested-by: Laszlo Ersek
Signed-off-by: Michael S. Tsirkin
---
include/hw/nvram/fw_cfg.h | 4 +++-
hw/core/loader.c | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/hw/nvram/fw_cfg.h
Make it possible to test unmapped status through QMP.
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 3 +++
hw/pci/pcie_host.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h
index 1228e36
Useful to make it accessible through QOM.
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 2 ++
hw/pci-host/q35.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h
index da0f275..33d75bd 10064
Support ROM blobs not mapped into guest memory:
same as ROM files really but use caller's buffer.
Support incoking callback on access and
return memory pointer making it easier
for caller to update memory if necessary.
Signed-off-by: Michael S. Tsirkin
Reviewed-by: Laszlo Ersek
---
hw/lm32/lm3
Make it easy to add read-only helpers for simple
integer properties in memory.
Reviewed-by: Paolo Bonzini
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 21 ++
qom/object.c | 60
2 files changed, 81 inser
As usual so we can use typedefs without header dependencies.
Reviewed-by: Paolo Bonzini
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/qom/object.h b/include/qom/object.h
index 1a7b71a..5b3b743 100644
--- a/include/qom/obje
Signed-off-by: Michael S. Tsirkin
---
include/hw/nvram/fw_cfg.h | 4
hw/nvram/fw_cfg.c | 33 -
2 files changed, 32 insertions(+), 5 deletions(-)
diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h
index f60dd67..2ab0fc2 100644
--- a/in
This is so qom headers can use it without pulling in
extra headers.
Reviewed-by: Paolo Bonzini
Signed-off-by: Michael S. Tsirkin
---
include/qemu/typedefs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
index a4c1b84..46c3599 100644
--- a/
now that a typedef for struct Error is available,
use it in qom/object.h to match coding style rules.
Reviewed-by: Paolo Bonzini
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 51 +--
1 file changed, 25 insertions(+), 26 deletions(-)
This code can also be found here:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi
While this patch still uses info not available in QOM, I think it's reasonable
to merge it and then refactor as QOM properties cover more ground.
In particular, merging this patchset blocks other projects so
On 09/28/2013 02:56 AM, Hu Yaohui wrote:
> Hi All,
> I am wondering whether virtio has provided polling mode already.
> Instead of sending a event from guest to host through eventfd on guest
> side and inject an interrupt into guest on host side to notify each
> other? Could both sides keep polling
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Signed-off-by: Michael S. Tsirkin
---
hw/i386/smbios.c | 61 +++-
1 file changed, 25 insertions(+), 36 deletions(-)
diff --git a/hw/i386/smbios.c b/hw/i386/smb
From: Markus Armbruster
We allow either tables or fields for the same type. Makes sense,
because SeaBIOS uses fields only when no tables are present.
We do this by searching the SMBIOS blob for a previously added table
or field. Error messages look like this:
qemu-system-x86_64: -smbios t
From: Markus Armbruster
Currently, -smbios type=T,NAME=VAL,... adds one field (T,NAME) with
value VAL to fw_cfg for each unique NAME. If NAME occurs multiple
times, the last one's VAL is used (before the QemuOpts conversion, the
first one was used).
Multiple -smbios can add multiple fields with
From: Hervé Poussineau
This check is useless, as bigger addresses will be ignored when
added to 'io' MemoryRegion, which has a size of 64K.
However, some architectures don't use the 'io' MemoryRegion, like
the alpha and versatile platforms. They create a PCI I/O region
bigger than 64K, so let th
From: Markus Armbruster
It exits on all error conditions but one, where it returns -1.
Normalize, and return void.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Signed-off-by: Michael S. Tsirkin
---
include/hw/i386/smbios.h | 2 +-
arch_init.c | 4 +---
hw/i386/smbi
Detect the 64 bit window programmed by firmware
and configure properties accordingly.
Signed-off-by: Michael S. Tsirkin
---
hw/pci-host/piix.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 221d82b..c041149 100644
From: Markus Armbruster
So that it can be set in config file for -readconfig.
This tightens parsing of -smbios, and makes it more consistent with
other options: unknown parameters are rejected, numbers with trailing
junk are rejected, when a parameter is given multiple times, last
rather than fi
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pci.h | 1 +
hw/pci/pci.c | 50 ++
2 files changed, 51 insertions(+)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 37979aa..4b90e5d 100644
--- a/include/hw/pci/pci.h
+++
Detect the 64 bit window programmed by firmware
and configure properties accordingly.
Signed-off-by: Michael S. Tsirkin
---
hw/pci-host/q35.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 72f6b72..23dbeea 100644
--
Signed-off-by: Michael S. Tsirkin
---
include/qemu/range.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/include/qemu/range.h b/include/qemu/range.h
index 4a0780d..aae9720 100644
--- a/include/qemu/range.h
+++ b/include/qemu/range.h
@@ -17,6 +17,24 @@ struct Range {
will help simplify header dependencies.
Signed-off-by: Michael S. Tsirkin
---
include/qemu/range.h| 2 +-
include/qemu/typedefs.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/qemu/range.h b/include/qemu/range.h
index b76cc0d..4a0780d 100644
--- a/include/qemu/
73 matches
Mail list logo
