22.09.2013 00:26, Ján Veselý wrote:
Device communication errors need to be reported to driver.
Add a debug message while at it.
Signed-off-by: Jan Vesely <jano.ves...@gmail.com>
---
hw/usb/hcd-ohci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 35f0878..0396e33 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -1143,7 +1143,9 @@ static int ohci_service_td(OHCIState *ohci,
struct ohci_ed *ed)
switch (ret) {
case USB_RET_IOERROR:
case USB_RET_NODEV:
+ DPRINTF("usb-ohci: got DEV ERROR\n");
why is this "DEV ERROR" ? Note it is about 2 case statements, not one.
OHCI_SET_BM(td.flags, TD_CC, OHCI_CC_DEVICENOTRESPONDING);
+ break;
case USB_RET_NAK:
DPRINTF("usb-ohci: got NAK\n");
return 1;
While the actual interesting change (adding break) looks
correct, and the whole thing is trivial indeed, this area
has a maintainer, -- Cc'ing Gerd for this. If he's okay
I'll pick it up.
Thanks,
/mjt
