Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-12 Thread Gerd Hoffmann
On Mo, 2013-08-12 at 18:42 -0400, Kevin O'Connor wrote: > On Mon, Aug 12, 2013 at 08:05:08AM +0200, Gerd Hoffmann wrote: > > We'll need some way to make sure the pmbase (also mmconf xbar) set by > > the firmware matches the pmbase address filled into the acpi tables by > > qemu ... > > > > So the

[Qemu-devel] qemu-ppc (prep) crashes with NetBSD guest

2013-08-12 Thread Felix Deichmann
Hi, I tried to install NetBSD/prep 6.1 in qemu-ppc (-M prep), but qemu crashes during installation with "floating point exception" in a reproducible way. qemu is version 1.5.2-1 from Arch Linux (sorry, didn't have the time to build a current one) on a x86_64 host. The same happens with Win qemu 1

[Qemu-devel] [PATCH v2 3/4] qemu-thread: add QemuEvent

2013-08-12 Thread Liu Ping Fan
From: Paolo Bonzini This emulates Win32 manual-reset events using futexes or conditional variables. Typical ways to use them are with multi-producer, single-consumer data structures, to test for a complex condition whose elements come from different threads: for (;;) { qemu_event_re

[Qemu-devel] [PATCH v2 4/4] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-12 Thread Liu Ping Fan
After disabling the QemuClock, we should make sure that no QemuTimers are still in flight. To implement that with light overhead, we resort to QemuEvent. The caller of disabling will wait on QemuEvent of each timerlist. Note, qemu_clock_enable(foo,false) can _not_ be called from timer's cb. And th

[Qemu-devel] [PATCH v2 2/4] timer: protect timers_state's clock with seqlock

2013-08-12 Thread Liu Ping Fan
The vm_clock may be read outside BQL. This will make timers_state --the foundation of vm_clock exposed to race condition. Using private lock to protect it. Note in tcg mode, vm_clock still read inside BQL, so icount is left without private lock's protection. As for cpu_ticks_* in timers_state, it

[Qemu-devel] [PATCH v2 1/4] seqlock: introduce read-write seqlock

2013-08-12 Thread Liu Ping Fan
From: Paolo Bonzini This lets the read-side access run outside the BQL. Signed-off-by: Paolo Bonzini --- include/qemu/seqlock.h | 72 ++ 1 file changed, 72 insertions(+) create mode 100644 include/qemu/seqlock.h diff --git a/include/qemu/seqloc

[Qemu-devel] [PATCH v2 0/4] timers thread-safe stuff

2013-08-12 Thread Liu Ping Fan
This series aim to fix the rest race issue when run timers on multi-thread. (qemu_mod_ns has been fixed by Stefan by separated patches) Have rebased onto Alex's patches "[RFC] [PATCHv10 00/31] aio / timers: Add AioContext timers and use ppoll" v2: 1. fix comment in commit and code 2. fix rac

[Qemu-devel] [PATCH V18 05/25] qemu-option: opt->str store digit, without suffixes

2013-08-12 Thread Dong Xu Wang
To produce same output while using "qemu-img create", opt->str should store pure digit, without suffixes. Signed-off-by: Dong Xu Wang --- util/qemu-option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/qemu-option.c b/util/qemu-option.c index b939e8a..861929d 100644 --- a/util/qemu

[Qemu-devel] [PATCH V18 21/25] block: add QemuOpts support for vpc.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/vpc.c | 125 1 file changed, 125 insertions(+) diff --git a/block/vpc.c b/block/vpc.c index fe4f311..aa1263a 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -786,6 +786,109 @@ static int vpc_create(c

[Qemu-devel] [PATCH V18 01/25] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print

2013-08-12 Thread Dong Xu Wang
qemu_opts_print has no user now, so can re-write the function safely. qemu_opts_print is used while using "qemu-img create", it produces the same output as previous code. The behavior of this function has changed: 1. Print every possible option, whether a value has been set or not. 2. Option des

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Benjamin Herrenschmidt
On Tue, 2013-08-13 at 13:50 +0930, Rusty Russell wrote: > We can have it call once (eg. when the first and storing the status > word) and store the result. And fail with kexec of a different endian kernel :-) Let's not bother yet. Merge it and then we see if we can optimize. Cheers, Ben.

Re: [Qemu-devel] [PATCH RFT qom-cpu for-next] gdbstub: Fix gdb_register_coprocessor() register counting

2013-08-12 Thread Aneesh Kumar K.V
Andreas Färber writes: > Commit a0e372f0c49ac01faeaeb73a6e8f50e8ac615f34 reorganized the register > counting for GDB. While it seems correct not to let the total number of > registers skyrocket in an SMP scenario through a static variable, the > distinction between total register count and 'g' pa

[Qemu-devel] [PATCH V18 24/25] qapi: query-command-line-options outputs def_value_str

2013-08-12 Thread Dong Xu Wang
QMP command query-command-line-options shows details information of parameters, since added def_value_str, also output it in the QMP command. v16->v17: 1) add "Since 1.6" tag. 2) rename def_str_value to "default". Signed-off-by: Dong Xu Wang --- qapi-schema.json | 8 ++-- qmp-commands.hx

[Qemu-devel] [PATCH V18 22/25] block: add QemuOpts support for block.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block.c | 86 ++--- 1 file changed, 39 insertions(+), 47 deletions(-) diff --git a/block.c b/block.c index 25090dc..9f52341 100644 --- a/block.c +++ b/block.c @@ -375,7 +375,7 @@ static void coroutine_fn

[Qemu-devel] [PATCH V18 20/25] block: add QemuOpts support for vmdk.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/vmdk.c | 236 +++ 1 file changed, 236 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index 346bb5c..5452aa2 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1720,6 +1720,197 @@ exit: return

[Qemu-devel] [PATCH V18 17/25] block: add QemuOpts support for sheepdog.c

2013-08-12 Thread Dong Xu Wang
Conflicts: block/sheepdog.c Signed-off-by: Dong Xu Wang --- block/sheepdog.c | 111 +++ 1 file changed, 111 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index afe0533..b09b4fa 100644 --- a/block/sheepdog.c +++ b/block

[Qemu-devel] [PATCH V18 15/25] block: add QemuOpts support for raw.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/raw.c | 20 1 file changed, 20 insertions(+) diff --git a/block/raw.c b/block/raw.c index 4751825..7636f6b 100644 --- a/block/raw.c +++ b/block/raw.c @@ -139,6 +139,24 @@ static QEMUOptionParameter raw_create_options[] = { { NULL }

[Qemu-devel] [PATCH V18 14/25] block: add QemuOpts support for raw-win32.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/raw-win32.c | 36 1 file changed, 36 insertions(+) diff --git a/block/raw-win32.c b/block/raw-win32.c index 9b5b2af..78efc63 100644 --- a/block/raw-win32.c +++ b/block/raw-win32.c @@ -452,6 +452,40 @@ static QEMUOptionPar

[Qemu-devel] [PATCH V18 25/25] qemu-option: remove QEMUOptionParameter related functions and struct

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang Conflicts: include/qemu/option.h --- block.c | 1 - include/qemu/option.h | 39 --- util/qemu-option.c| 285 -- 3 files changed, 325 deletions(-) diff --git a/block.c b/block.c index c11

[Qemu-devel] [PATCH V18 13/25] block: add QemuOpts support for raw-posix.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/raw-posix.c | 73 +++ 1 file changed, 73 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index ba721d3..528b3d1 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -1069,6 +1069,29 @@

[Qemu-devel] [PATCH V18 19/25] block: add QemuOpts support for vdi.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/vdi.c | 128 1 file changed, 128 insertions(+) diff --git a/block/vdi.c b/block/vdi.c index 8a91525..50bf24f 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -736,6 +736,102 @@ static int vdi_create(c

[Qemu-devel] [PATCH V18 18/25] block: add QemuOpts support for ssh.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/ssh.c | 69 + 1 file changed, 69 insertions(+) diff --git a/block/ssh.c b/block/ssh.c index d7e7bf8..7f1d5d7 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -709,6 +709,73 @@ static int ssh_create(con

[Qemu-devel] [PATCH V18 08/25] block: add QemuOpts support for gluster.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/gluster.c | 58 + 1 file changed, 58 insertions(+) diff --git a/block/gluster.c b/block/gluster.c index 645b7f1..eb9d644 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -407,6 +407,43 @@ out:

[Qemu-devel] [PATCH V18 16/25] block: add QemuOpts support for rbd.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/rbd.c | 95 + 1 file changed, 95 insertions(+) diff --git a/block/rbd.c b/block/rbd.c index cb71751..4d5897c 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -368,6 +368,80 @@ static int qemu_rbd_creat

[Qemu-devel] [PATCH V18 11/25] block: add QemuOpts support for qcow2.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/qcow2.c | 265 ++ 1 file changed, 265 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 3376901..1c3249d 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1460,6 +1460,218 @@ static int qc

[Qemu-devel] [PATCH V18 07/25] block: add QemuOpts support for cow.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/cow.c | 79 + 1 file changed, 79 insertions(+) diff --git a/block/cow.c b/block/cow.c index 1cc2e89..3a0d450 100644 --- a/block/cow.c +++ b/block/cow.c @@ -332,6 +332,83 @@ static QEMUOptionParamet

[Qemu-devel] [PATCH V18 12/25] block: add QemuOpts support for qed.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/qed.c | 153 block/qed.h | 3 +- 2 files changed, 155 insertions(+), 1 deletion(-) diff --git a/block/qed.c b/block/qed.c index f767b05..348695f 100644 --- a/block/qed.c +++ b/block/qed.c @@ -651

[Qemu-devel] [PATCH V18 10/25] block: add QemuOpts support for qcow.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/qcow.c | 126 +++ 1 file changed, 126 insertions(+) diff --git a/block/qcow.c b/block/qcow.c index 5239bd6..5b572d3 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -755,6 +755,107 @@ exit: return r

[Qemu-devel] [PATCH V18 09/25] block: add QemuOpts support for iscsi.c

2013-08-12 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/iscsi.c | 61 +++ 1 file changed, 61 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index e7c1c2b..de2fd8c 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1305,6 +1305,65 @@ static QEMUOpti

[Qemu-devel] [PATCH V18 06/25] add interface to block

2013-08-12 Thread Dong Xu Wang
To make patches easy for reviewing, each block format is a single patch. Add a new interface to block layer to make sure origin code can compile and do not change any code logic. Signed-off-by: Dong Xu Wang --- block.c | 51 +++ inclu

[Qemu-devel] [PATCH V18 02/25] qemu-option: avoid duplication of default value in QemuOpts

2013-08-12 Thread Dong Xu Wang
This patch moves the default value entirely to QemuOptDesc. When getting the value of an option that hasn't been set, and QemuOptDesc has a default value, return that. Else, behave as before. Example: qemu_opt_get_number(opts, "foo", 42) If "foo" has been set in opts, return its value. E

[Qemu-devel] [PATCH V18 03/25] qemu-option: create four QemuOptsList related functions

2013-08-12 Thread Dong Xu Wang
This patch creates 4 functions, count_opts_list, qemu_opts_append, qemu_opts_free and qemu_opts_print_help, they are used in following commits. v16->v17: 1) fix indentation. 2) fix typo. v15->v16: 1) discard double-initialization. 2) use pointer directly, not g_strdup. v12->v13: 1) simply assert

[Qemu-devel] [PATCH V18 04/25] qemu-option: create some QemuOpts functons

2013-08-12 Thread Dong Xu Wang
These functions will be used in next commit. qemu_opt_get_(*)_del functions are used to make sure we have the same behaviors as before: in block layer, after parsing a parameter value, parameter list will delete it to avoid parsing it twice. Signed-off-by: Dong Xu Wang v16->v17: 1) return "char

[Qemu-devel] [PATCH V18 00/25] replace QEMUOptionParameter with QemuOpts parser

2013-08-12 Thread Dong Xu Wang
v17->v18: 1) split into small patches, by each image format. 2) opt->str store digit, without suffixes in QemuOpt Dong Xu Wang (25): qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print qemu-option: avoid duplication of default value in QemuOpts qemu-option: c

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Rusty Russell
Anthony Liguori writes: > Benjamin Herrenschmidt writes: > >> On Mon, 2013-08-12 at 17:29 +0930, Rusty Russell wrote: >>> virtio data structures are defined as "target endian", which assumes >>> that's a fixed value. In fact, that actually means it's >>> platform-specific. >>> >>> Hopefully the

[Qemu-devel] [PATCH] pseries: Fix stalls on hypervisor virtual console

2013-08-12 Thread Anton Blanchard
A number of users are reporting stalls when using the pseries hypervisor virtual console. A simple test case is to paste 15 or 17 characters at a time into the console. Pasting 15 characters at a time works fine but pasting 17 characters hangs for a random amount of time. Other activity (network,

Re: [Qemu-devel] [Bug 1205156] [NEW] Errors while compiling version 1.5.2

2013-08-12 Thread Alexander Graf
Am 13.08.2013 um 03:07 schrieb Michael Roth : > Quoting Michael Roth (2013-08-12 20:05:32) >> Quoting Stefan Weil (2013-07-26 00:12:59) >>> Am 26.07.2013 04:03, schrieb jean-christophe manciot: Public bug reported: Environment: Ubuntu 13.04 "hw/ide/macio.c: In function

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Guenter Roeck
On Mon, Aug 12, 2013 at 05:24:50PM +0100, Peter Maydell wrote: [ ... ] > If somebody would like to fix the kernel I am happy to > locate the PCI backplane and test everything (again). > I would suggest that producing some patches which work > with QEMU 1.5 or later would be a good start; then we

[Qemu-devel] [PATCH 3/3] slirp: fill mainloop timeout with more precise value

2013-08-12 Thread Liu Ping Fan
If slirp needs to emulate tcp timeout, then the timeout value for mainloop should be more precise, which is determined by slirp's fasttimo or slowtimo. Signed-off-by: Liu Ping Fan --- main-loop.c | 2 +- slirp/slirp.c | 18 ++ 2 files changed, 19 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH 1/3] slirp: make timeout local

2013-08-12 Thread Liu Ping Fan
Each slirp has its own time to caculate timeout. Signed-off-by: Liu Ping Fan --- slirp/slirp.c | 22 ++ slirp/slirp.h | 3 +++ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 80b28ea..55654d5 100644 --- a/slirp/slirp.c +++

[Qemu-devel] [PATCH 2/3] slirp: define timeout as macro

2013-08-12 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan --- slirp/slirp.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 55654d5..1deaad9 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -47,6 +47,9 @@ static QTAILQ_HEAD(slirp_instances, Slirp) slirp_instances

[Qemu-devel] [PATCH 0/3] slirp: fill mainloop with more precise timeout value

2013-08-12 Thread Liu Ping Fan
These patches is separated from "[PATCH v1 0/5] make slirp subsystem self-contained", as Paolo suggested. lists.nongnu.org/archive/html/qemu-devel/2013-08/msg00980.html With them, we can fill the timeout of mainloop more precise, when slirp has to emulate tcp timeout problem. Liu Ping Fan (

Re: [Qemu-devel] Are there plans to achieve ram live Snapshot feature?

2013-08-12 Thread Wenchao Xia
于 2013-8-12 19:33, Stefan Hajnoczi 写道: On Mon, Aug 12, 2013 at 12:26 PM, Alex Bligh wrote: --On 12 August 2013 11:59:03 +0200 Stefan Hajnoczi wrote: The idea that was discussed on qemu-devel@nongnu.org uses fork(2) to capture the state of guest RAM and then send it back to the parent process

[Qemu-devel] [PATCH] rdma: clean up of qemu_rdma_cleanup()

2013-08-12 Thread Isaku Yamahata
- It can't be determined by RDMAContext::cm_id != NULL if the connection is established or not. - RDMAContext::cm_id is leaked and not destroyed because it is set to NULL too early. - RDMAContext::qp is created by rdma_create_qp() so that it should be destroyed by rdma_destroy_qp(). not ibv_d

Re: [Qemu-devel] [PATCH] qemu-char: fix infinite recursion connecting to monitor pty

2013-08-12 Thread Michael Roth
Quoting James Hogan (2013-08-08 06:09:38) > Since commit bd5c51e (qemu-char: don't issue CHR_EVENT_OPEN in a BH), an > infinite recursion occurs when putting the monitor on a pty (-monitor > pty) and connecting a terminal to the slave port. > > This is because of the qemu_chr_be_event(s, CHR_EVENT

[Qemu-devel] [PATCH v2 3/4] vmdk: support vmfs files

2013-08-12 Thread Fam Zheng
From: Paolo Bonzini VMware ESX hosts also use different create and extent types for flat files, respectively "vmfs" and "VMFS". This is not documented, but it can be found at http://kb.vmware.com/kb/10002511 (Recreating a missing virtual machine disk (VMDK) descriptor file). Signed-off-by: Paol

[Qemu-devel] [PATCH v2 2/4] vmdk: support vmfsSparse files

2013-08-12 Thread Fam Zheng
VMware ESX hosts use a variant of the VMDK3 format, identified by the vmfsSparse create type ad the VMFSSPARSE extent type. It has 16 KB grain tables (L2) and a variable-size grain directory (L1). In addition, the grain size is always 512, but that is not a problem because it is included in the he

[Qemu-devel] [PATCH v2 4/4] vmdk: Move l1_size check into vmdk_add_extent()

2013-08-12 Thread Fam Zheng
This header check is common to VMDK3 and VMDK4, so move it into vmdk_add_extent(). Signed-off-by: Fam Zheng --- block/vmdk.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index b653e2e..63b489d 100644 --- a/block/vmdk.c +++ b/blo

[Qemu-devel] [PATCH v2 1/4] vmdk: fix L1 and L2 table size in vmdk3 open

2013-08-12 Thread Fam Zheng
VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the value. This patch honors the header field. And the L2 table size is 4096 according to VMDK spec[1], instead of 1 << 9 (512). [1]: http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk Signed-off-by: Fam

[Qemu-devel] [PATCH v2 0/4] vmdk: Support ESX files

2013-08-12 Thread Fam Zheng
This series add support for VMFS and VMFSSPARSE extents, these types are found in description file from ESX hosts. - VMFS is in monolithiFlat format (raw), but hosted in ESX. - VMFSSPARSE is the format we call "vmdk3" with magic bytes "COWD". There's no reason to open a image of the same typ

Re: [Qemu-devel] [Bug 1205156] [NEW] Errors while compiling version 1.5.2

2013-08-12 Thread Michael Roth
Quoting Michael Roth (2013-08-12 20:05:32) > Quoting Stefan Weil (2013-07-26 00:12:59) > > Am 26.07.2013 04:03, schrieb jean-christophe manciot: > > > Public bug reported: > > > > > > Environment: Ubuntu 13.04 > > > > > > "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’: > > > hw/ide/macio

Re: [Qemu-devel] [Bug 1205156] [NEW] Errors while compiling version 1.5.2

2013-08-12 Thread Michael Roth
Quoting Stefan Weil (2013-07-26 00:12:59) > Am 26.07.2013 04:03, schrieb jean-christophe manciot: > > Public bug reported: > > > > Environment: Ubuntu 13.04 > > > > "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’: > > hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘lon

Re: [Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH

2013-08-12 Thread Michael Roth
Quoting Michael Roth (2013-08-12 17:43:00) > Quoting Alex Williamson (2013-07-03 16:51:56) > > On Wed, 2013-07-03 at 15:16 -0500, Michael Roth wrote: > > > On Wed, Jul 3, 2013 at 3:10 PM, Alex Williamson > > > wrote: > > > > On Wed, 2013-06-12 at 16:41 -0500, Michael Roth wrote: > > > >> From: And

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Guenter Roeck
On Mon, Aug 12, 2013 at 11:12:50PM +0100, Russell King - ARM Linux wrote: > On Mon, Aug 12, 2013 at 10:36:17PM +0100, Peter Maydell wrote: > > On this point, yes. Equivalent bit from the PB926 TRM: > > http://infocenter.arm.com/help/topic/com.arm.doc.dui0224i/Cacdijji.html > > > > (There are diffe

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Guenter Roeck
On Mon, Aug 12, 2013 at 11:12:50PM +0100, Russell King - ARM Linux wrote: > On Mon, Aug 12, 2013 at 10:36:17PM +0100, Peter Maydell wrote: > > On this point, yes. Equivalent bit from the PB926 TRM: > > http://infocenter.arm.com/help/topic/com.arm.doc.dui0224i/Cacdijji.html > > > > (There are diffe

Re: [Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH

2013-08-12 Thread Michael Roth
Quoting Alex Williamson (2013-07-03 16:51:56) > On Wed, 2013-07-03 at 15:16 -0500, Michael Roth wrote: > > On Wed, Jul 3, 2013 at 3:10 PM, Alex Williamson > > wrote: > > > On Wed, 2013-06-12 at 16:41 -0500, Michael Roth wrote: > > >> From: Andreas Färber > > >> > > >> The implementation of the AT

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-12 Thread Kevin O'Connor
On Mon, Aug 12, 2013 at 08:05:08AM +0200, Gerd Hoffmann wrote: > We'll need some way to make sure the pmbase (also mmconf xbar) set by > the firmware matches the pmbase address filled into the acpi tables by > qemu ... > > So the options we have are: > > (1) Hardcode the address everywhere. Th

[Qemu-devel] [PATCH v3 1/2] memory: export migration page size

2013-08-12 Thread Michael S. Tsirkin
Migration code assumes that each RAM block is a multiple of target page size. We can fix this in a variety of ways, the simplest way is exporting the required page size so callers can make regions large enough. Signed-off-by: Michael S. Tsirkin --- arch_init.c | 6 ++ include/exec/

[Qemu-devel] [PATCH v3 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Michael S. Tsirkin
ROM files that are put in FW CFG are copied to guest ram, by BIOS, but they are not backed by RAM so they don't get migrated. Each time we change two bytes in such a ROM this breaks cross-version migration: since we can migrate after BIOS has read the first byte but before it has read the second o

[Qemu-devel] [PATCH v3 0/2] future proof rom loading for cross versiom migration

2013-08-12 Thread Michael S. Tsirkin
Changes from v2: address comments on v2 by Peter Maydell - switch from global constant to function - use memory_region_init_ram instead of _ram_ptr - disable for 1.6 Changes from v1: address comments by Peter Maydell - drop useless data=data line - rename target_page_size to mi

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Russell King - ARM Linux
On Mon, Aug 12, 2013 at 10:36:17PM +0100, Peter Maydell wrote: > On this point, yes. Equivalent bit from the PB926 TRM: > http://infocenter.arm.com/help/topic/com.arm.doc.dui0224i/Cacdijji.html > > (There are differences between the PCI controllers on > the different boards. Differences I know of

Re: [Qemu-devel] [PATCH 3/8] vfio: Introduce VFIO address spaces

2013-08-12 Thread Alex Williamson
On Wed, 2013-08-07 at 18:21 +1000, Alexey Kardashevskiy wrote: > From: David Gibson > > The only model so far supported for VFIO passthrough devices is the model > usually used on x86, where all of the guest's RAM is mapped into the > (host) IOMMU and there is no IOMMU visible in the guest. > >

Re: [Qemu-devel] [PATCH 6/8] spapr vfio: add vfio_container_spapr_get_info()

2013-08-12 Thread Alex Williamson
On Wed, 2013-08-07 at 18:21 +1000, Alexey Kardashevskiy wrote: > As sPAPR platform supports DMA windows on a PCI bus, the information > about their location and size should be passed into the guest via > the device tree. > > The patch adds a helper to read this info from the container fd. > > Sig

Re: [Qemu-devel] [PATCH 5/8] vfio: Add guest side IOMMU support

2013-08-12 Thread Alex Williamson
On Wed, 2013-08-07 at 18:21 +1000, Alexey Kardashevskiy wrote: > This patch uses the new IOMMU notifiers to allow VFIO pass through devices > to work with guest side IOMMUs, as long as the host-side VFIO iommu has > sufficient capability and granularity to match the guest side. This works > by trac

Re: [Qemu-devel] [PATCH v2 for-1.6 v2 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Paolo Bonzini
Il 12/08/2013 20:37, Peter Maydell ha scritto: > > I seem to recall having a conversation with Paolo along these > lines a few months back (we fixed the exynos devices which > were incorrectly using the _ram_ptr function); he can correct > me if I'm off-base here. Yeah, I think you're right. Pao

[Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic

2013-08-12 Thread Paolo Bonzini
vapic requires the VAPIC ROM to be mapped into RAM. This is not possible without PAM hardware. This fixes a segmentation fault running with -M isapc. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index a19e172..3aa244a 100644 ---

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Peter Maydell
On 12 August 2013 22:21, Russell King - ARM Linux wrote: > On Mon, Aug 12, 2013 at 09:49:54PM +0100, Peter Maydell wrote: >> On 12 August 2013 21:06, Russell King - ARM Linux >> wrote: >> > On Mon, Aug 12, 2013 at 06:33:28PM +0100, Peter Maydell wrote: >> >> /* Slot to IRQ mapping for RealVie

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Russell King - ARM Linux
On Mon, Aug 12, 2013 at 09:49:54PM +0100, Peter Maydell wrote: > On 12 August 2013 21:06, Russell King - ARM Linux > wrote: > > On Mon, Aug 12, 2013 at 06:33:28PM +0100, Peter Maydell wrote: > >> /* Slot to IRQ mapping for RealView EB and PB1176 backplane > >> * nameslotIntA

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] [v3] target-ppc: Enhance CPU nodes of device tree to be PAPR compliant.

2013-08-12 Thread Benjamin Herrenschmidt
On Mon, 2013-08-12 at 21:17 +0200, Thomas Huth wrote: > Am Mon, 12 Aug 2013 16:03:24 +1000 > schrieb Benjamin Herrenschmidt : > > > On Mon, 2013-08-12 at 10:07 +0530, Prerna Saxena wrote: > > > > .../... > > > > > I dont know what context lead to this observation. > > > However, PAPR mentions t

[Qemu-devel] [PATCH for-1.6] rdma: silly ipv6 bugfix

2013-08-12 Thread mrhines
From: "Michael R. Hines" My bad - but it's very important for us to warn the user that IPv6 is broken on RoCE in linux right now, until linux releases a fixed version. Signed-off-by: Michael R. Hines --- migration-rdma.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --

Re: [Qemu-devel] [PATCH 0/2] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-08-12 Thread Alex Bligh
Benoit, --On 12 August 2013 22:31:34 +0200 Benoît Canet wrote: Is there a git tree on which I could rebase my throttling series on top of the new timers ? API wise, mine should do, at: https://github.com/abligh/qemu/tree/aio-timers10 That won't have Stefan's thread-safe stuff in but that

Re: [Qemu-devel] [PATCH for-1.6] mips_malta: do not raise exceptions when accessing invalid memory

2013-08-12 Thread Aurelien Jarno
On Mon, Aug 12, 2013 at 10:38:54PM +0200, Stefan Weil wrote: > Am 12.08.2013 21:44, schrieb Aurelien Jarno: > > Since commit c658b94f6e8c206c59d02aa6fbac285b86b53d2c, MIPS raises > > exceptions when accessing invalid memory. This is not the correct > > behaviour for MIPS Malta Core LV, as the GT-64

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Peter Maydell
On 12 August 2013 20:02, Paul Gortmaker wrote: > > If I recall correctly, I'd showed the patch to Russell at the time (via > IRC, I believe) and he'd told me essentially the same thing as the above > paragraph, which is why I didn't put it in the patch system, and why the > commit log of the yocto

[Qemu-devel] [ANNOUNCE] QEMU 1.6.0-rc3 is now available

2013-08-12 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 1.6 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.6.0-rc3.tar.bz2 You can help improv

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Peter Maydell
On 12 August 2013 21:06, Russell King - ARM Linux wrote: > On Mon, Aug 12, 2013 at 06:33:28PM +0100, Peter Maydell wrote: >> /* Slot to IRQ mapping for RealView EB and PB1176 backplane >> * nameslotIntAIntBIntCIntD >> * A 31 IRQ50 IRQ51 IR

Re: [Qemu-devel] [Qemu-stable] Possible bug in qemu-1.4.2: boot=off not honoured for -drive instances of virtio-scsi devices?

2013-08-12 Thread Michael Roth
Quoting George Diamantopoulos (2013-06-26 12:48:20) > Hello, > >I've been testing out qemu-kvm 1.4.2 with virtio-scsi drives and I think I >might have encountered a bug. The VM is configured with: 1) a virtio-blk >drive, which is the one I want to boot, 2) another virtio-blk cdrom driv

Re: [Qemu-devel] [PATCH for-1.6] mips_malta: do not raise exceptions when accessing invalid memory

2013-08-12 Thread Stefan Weil
Am 12.08.2013 21:44, schrieb Aurelien Jarno: > Since commit c658b94f6e8c206c59d02aa6fbac285b86b53d2c, MIPS raises > exceptions when accessing invalid memory. This is not the correct > behaviour for MIPS Malta Core LV, as the GT-64120A system controller > just ignore undecoded access. This feature i

Re: [Qemu-devel] [PATCH 0/2] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-08-12 Thread Benoît Canet
Hi Stefan, Is there a git tree on which I could rebase my throttling series on top of the new timers ? Best Regards Benoît > Le Monday 12 Aug 2013 à 14:49:27 (+0200), Stefan Hajnoczi a écrit : > These patches are based on Alex Bligh's v10 AioContext timers series. > > The purpose of these pat

Re: [Qemu-devel] [PATCH v2] pc: drop external DSDT loading

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 02:59:24PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Aug 12, 2013 at 10:20:41AM -0500, Anthony Liguori wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Mon, Aug 12, 2013 at 09:01:44AM -0500, Anthony Liguori wrote: > >> >> This brea

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Paul Gortmaker
On 13-08-11 08:40 PM, Guenter Roeck wrote: > On 08/11/2013 03:04 PM, Russell King - ARM Linux wrote: >> On Sun, Aug 11, 2013 at 08:54:43AM -0700, Guenter Roeck wrote: >>> Hi, >>> >>> trying to boot arm versatile images with qemu results in the following error >>> if I try to boot with a disk image.

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Russell King - ARM Linux
On Mon, Aug 12, 2013 at 06:33:28PM +0100, Peter Maydell wrote: > /* Slot to IRQ mapping for RealView EB and PB1176 backplane > * nameslotIntAIntBIntCIntD > * A 31 IRQ50 IRQ51 IRQ48 IRQ49 > * B 30 IRQ49 IRQ50 IRQ51

Re: [Qemu-devel] [PATCH v2] pc: drop external DSDT loading

2013-08-12 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Mon, Aug 12, 2013 at 10:20:41AM -0500, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> > On Mon, Aug 12, 2013 at 09:01:44AM -0500, Anthony Liguori wrote: >> >> This breaks migration and is unneeded with modern SeaBIOS. >> >> >> >> Signed-off-by: A

[Qemu-devel] [PATCH for-1.6] mips_malta: do not raise exceptions when accessing invalid memory

2013-08-12 Thread Aurelien Jarno
Since commit c658b94f6e8c206c59d02aa6fbac285b86b53d2c, MIPS raises exceptions when accessing invalid memory. This is not the correct behaviour for MIPS Malta Core LV, as the GT-64120A system controller just ignore undecoded access. This feature is used by the Linux kernel to probe for some devices.

[Qemu-devel] [RFC 05/14] tcg-aarch64: Support andc, orc, eqv, not

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 44 tcg/aarch64/tcg-target.h | 16 2 files changed, 52 insertions(+), 8 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 3640486..7aeb3

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] [v3] target-ppc: Enhance CPU nodes of device tree to be PAPR compliant.

2013-08-12 Thread Thomas Huth
Am Mon, 12 Aug 2013 16:03:24 +1000 schrieb Benjamin Herrenschmidt : > On Mon, 2013-08-12 at 10:07 +0530, Prerna Saxena wrote: > > .../... > > > I dont know what context lead to this observation. > > However, PAPR mentions the following nomenclature guideline: > > > > "The value of this propert

[Qemu-devel] [RFC 06/14] tcg-aarch64: Handle zero as first argument to sub

2013-08-12 Thread Richard Henderson
In order to properly handle neg, as generated by TCG generic code. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 7aeb3cd..88bbfd2 1

Re: [Qemu-devel] [PATCH v2 for-1.6 v2 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 07:37:21PM +0100, Peter Maydell wrote: > On 12 August 2013 19:16, Michael S. Tsirkin wrote: > > +static void *rom_set_mr(Rom *rom, Object *owner, const char *name) > > +{ > > +/* > > + * Migration code expects that all RAM blocks are full pages. > > + * Round MR

[Qemu-devel] [RFC 14/14] tcg-aarch64: Pass return address to load/store helpers directly.

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 16 +-- tcg/aarch64/tcg-target.c | 69 ++-- 2 files changed, 39 insertions(+), 46 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index b3402a1..10e680d

[Qemu-devel] [RFC 13/14] tcg-aarch64: Use adrp in tcg_out_movi

2013-08-12 Thread Richard Henderson
Loading an qemu pointer as an immediate happens often: - exit_tb $0x7fa8140013 + exit_tb $0x7f81ee0013 ... - : d2800260mov x0, #0x13 - : f2b50280movkx0, #0xa814, lsl #16 - : f2c00fe0movkx0, #0x7f, lsl #32 + : 90ff1000adrpx0, 0x7f81ee + : 910

[Qemu-devel] [RFC 12/14] tcg-aarch64: Avoid add with zero in tlb load

2013-08-12 Thread Richard Henderson
Some guest env are small enough to reach the tlb with only a 12-bit addition. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 02a

[Qemu-devel] [RFC 11/14] tcg-aarch64: Improve tcg_out_movi

2013-08-12 Thread Richard Henderson
Handle small positive and negative numbers early. Check for logical immediates. Check if using MOVN for the first set helps. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 85 +--- 1 file changed, 66 insertions(+), 19 deletions(-) d

[Qemu-devel] [RFC 10/14] tcg-aarch64: Support div, mulu2

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 42 ++ tcg/aarch64/tcg-target.h | 6 +++--- 2 files changed, 45 insertions(+), 3 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 967526b..920c63c 100644 --

[Qemu-devel] [RFC 07/14] tcg-aarch64: Support movcond

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 19 ++- tcg/aarch64/tcg-target.h | 4 ++-- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 88bbfd2..f0febc9 100644 --- a/tcg/aarch64/tcg-targe

[Qemu-devel] [RFC 08/14] tcg-aarch64: Support deposit

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 25 + tcg/aarch64/tcg-target.h | 4 ++-- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index f0febc9..3474ca4 100644 --- a/tcg/aarch64/tcg

[Qemu-devel] [RFC 09/14] tcg-aarch64: Support add2, sub2

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 110 --- tcg/aarch64/tcg-target.h | 8 ++-- 2 files changed, 90 insertions(+), 28 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 3474ca4..967526b 100

[Qemu-devel] [RFC 04/14] tcg-aarch64: Convert from opcode enums to insn enums

2013-08-12 Thread Richard Henderson
The difference being that INSN_* has been pre-shifted into place. This should result in less runtime shifting of constants. The patch could be split into smaller pieces for clarity... Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 518 ---

[Qemu-devel] [RFC 03/14] tcg-aarch64: Allow immediate operands to compare

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 74 +--- 1 file changed, 51 insertions(+), 23 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index e8370a9..76595b4 100644 --- a/tcg/aarch64/tcg-target.c +++

[Qemu-devel] [RFC 01/14] tcg-aarch64: Allow immediate operands to add and sub

2013-08-12 Thread Richard Henderson
Use signed 25-bit operands, because two 12-bit operations is smaller than movz+movk+add. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 107 +++ 1 file changed, 61 insertions(+), 46 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b

[Qemu-devel] [RFC 00/14] tcg aarch64 improvements

2013-08-12 Thread Richard Henderson
Several of these patches need cleaning up, but brings the state of the port in line with the other targets. The last patch is dependant on another patch set I've got in the queue for 1.7 (http://patchwork.ozlabs.org/patch/264736/), but is otherwise independant. The patch set is at git://github.co

Re: [Qemu-devel] [PATCH v2 for-1.6 v2 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Peter Maydell
On 12 August 2013 19:16, Michael S. Tsirkin wrote: > +static void *rom_set_mr(Rom *rom, Object *owner, const char *name) > +{ > +/* > + * Migration code expects that all RAM blocks are full pages. > + * Round MR size up to satisfy this condition. > + */ > +unsigned size = ROUND

  1   2   3   >