Re: [Qemu-devel] default slot used for vga device on q35 machines

2013-08-01 Thread Gerd Hoffmann
Hi, > qemu-kvm -M q35 -nodefaults -nodefconfig -qmp unix:/tmp/qemu,server > -vnc :15 -vga std -usb > > Then ran "query-pci" in the qmp monitor and found that the vga device is > put at slot 1 instead of slot 2. > > My questions: > > 1) Is this difference intentional, or a bug? The vga simp

[Qemu-devel] [Bug 994378] Re: Nested-virt)L1 (kvm on kvm)guest panic with parameter “-cpu host” in qemu command line.

2013-08-01 Thread Yongjie Ren
after "echo 1 > /sys/modules/kvm/parameters/ignore_msrs" in host, the guest (with my own kernel config) boot up fine. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/994378 Title: Nested-virt)L1 (kv

Re: [Qemu-devel] [sheepdog] [PATCH v4 06/10] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers

2013-08-01 Thread MORITA Kazutaka
At Tue, 30 Jul 2013 15:58:58 +0200, Stefan Hajnoczi wrote: > > On Fri, Jul 26, 2013 at 03:10:48PM +0900, MORITA Kazutaka wrote: > > This helper function behaves similarly to co_sleep_ns(), but the > > sleeping coroutine will be resumed when using qemu_aio_wait(). > > > > Signed-off-by: MORITA Kaz

Re: [Qemu-devel] [sheepdog] [PATCH v4 03/10] sheepdog: check return values of qemu_co_recv/send correctly

2013-08-01 Thread MORITA Kazutaka
At Tue, 30 Jul 2013 15:48:02 +0200, Stefan Hajnoczi wrote: > > On Fri, Jul 26, 2013 at 03:10:45PM +0900, MORITA Kazutaka wrote: > > If qemu_co_recv/send doesn't return the specified length, it means > > that an error happened. > > > > Tested-and-reviewed-by: Liu Yuan > > Signed-off-by: MORITA Ka

Re: [Qemu-devel] [PATCH RESEND for-1.6] virtio-console: Use exitfn for virtserialport, too

2013-08-01 Thread Amit Shah
On (Thu) 01 Aug 2013 [01:28:46], Andreas Färber wrote: > virtconsole and virtserialport are identical in every other aspect > except for the distinguishing VirtIOSerialPortClass::is_console field. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Andreas Färber Reviewed-by: Amit Shah Please pick

[Qemu-devel] [PATCH for-1.6] pc: disable pci-info for 1.6

2013-08-01 Thread Michael S. Tsirkin
The BIOS that we ship in 1.6 does not use pci info from host (yet). So it's safest to disable that interface for 1.6 machine types for now, leave it on for 1.7 as we have enough time to fix issues if any. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 9 +++-- hw/i386/pc_q35.c |

Re: [Qemu-devel] [PATCH 3/4] target-arm: Implement the generic timer

2013-08-01 Thread Andreas Färber
Am 30.07.2013 19:55, schrieb Peter Maydell: > The ARMv7 architecture specifies a 'generic timer' which is implemented > via cp15 registers. Newer kernels will prefer to use this rather than > a devboard-level timer. Implement the generic timer for TCG; for KVM > we will already use the hardware's v

Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState

2013-08-01 Thread Fam Zheng
On Thu, 08/01 14:28, Stefan Hajnoczi wrote: > On Wed, Jul 31, 2013 at 06:13:53PM +0800, Fam Zheng wrote: > > BlockDriverState lifecycle management is needed by future features such as > > image fleecing and blockdev-add. This series adds reference count to > > BlockDriverState. > > > > The first t

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-08-01 Thread Qiao Nuohan
On 07/31/2013 09:10 PM, Luiz Capitulino wrote: QMP introspection didn't make it for 1.6. Thanks for your info. I will still wait for introspection. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-08-01 Thread Qiao Nuohan
On 08/02/2013 11:41 AM, Amos Kong wrote: On Fri, Aug 02, 2013 at 11:25:17AM +0800, Qiao Nuohan wrote: On 07/31/2013 09:10 PM, Luiz Capitulino wrote: QMP introspection didn't make it for 1.6. Thanks for your info. I will still wait for introspection. Can you help to review if the output of m

Re: [Qemu-devel] [PATCH] monitor: fix parsing of big int

2013-08-01 Thread Fam Zheng
On Thu, 08/01 10:00, Luiz Capitulino wrote: > On Thu, 01 Aug 2013 07:52:17 -0600 > Eric Blake wrote: > > > On 08/01/2013 12:31 AM, Fam Zheng wrote: > > > Fix it by calling strtoll instead, which will report ERANGE as expected. > > > > > > (HMP) block_set_io_throttle ide0-hd0

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-08-01 Thread Amos Kong
On Fri, Aug 02, 2013 at 11:25:17AM +0800, Qiao Nuohan wrote: > On 07/31/2013 09:10 PM, Luiz Capitulino wrote: > >QMP introspection didn't make it for 1.6. > > Thanks for your info. I will still wait for introspection. Can you help to review if the output of my patch v2 is ok for you? > -- > Re

[Qemu-devel] [PATCH 0/3] rdma fixes and clean ups

2013-08-01 Thread Isaku Yamahata
Small fixes/clean up to rdma. found through code review. Isaku Yamahata (3): rdma: don't use negative index to array rdma: qemu_rdma_post_send_control uses wrongly RDMA_WRID_MAX rdma: use RDMA_WRID_READY migration-rdma.c | 43 +++ 1 file changed, 2

[Qemu-devel] [PATCH 1/3] rdma: don't use negative index to array

2013-08-01 Thread Isaku Yamahata
Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index 4828738..edbae9f 100644 --- a/migration-rdma.c +++ b/migration-rdma.c @@ -1931,10

[Qemu-devel] [PATCH 3/3] rdma: use RDMA_WRID_READY

2013-08-01 Thread Isaku Yamahata
Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index 67069d2..871f9cd 100644 --- a/migration-rdma.c +++ b/migration-rdma.c @@ -2221,7 +2221,7 @@ static int qemu

[Qemu-devel] [PATCH 2/3] rdma: qemu_rdma_post_send_control uses wrongly RDMA_WRID_MAX

2013-08-01 Thread Isaku Yamahata
RDMA_WRID_CONTROL should be used. And remove related work around. Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index edbae9f..67069d2 100644 --- a/mi

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-08-01 Thread Qiao Nuohan
On 07/31/2013 08:23 PM, Laszlo Ersek wrote: Since my series is a bugfix for existing, non-compressed functionality (--> vmcores dumped for 3.5G+ guests are corrupt), *and* you look like a vmcore/dump expert, could you please give it a look? :) I see. Normally, your series *should* take pr

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread liu ping fan
On Thu, Aug 1, 2013 at 9:28 PM, Alex Bligh wrote: > Paolo, > > > --On 1 August 2013 08:19:34 -0400 Paolo Bonzini wrote: > >>> > True, qemu_event basically works only when a single thread resets it. >>> > But there is no race condition here because qemu_run_timers cannot be >>> > executed concurre

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread liu ping fan
On Thu, Aug 1, 2013 at 10:28 PM, Paolo Bonzini wrote: > On Aug 01 2013, Alex Bligh wrote: >> Paolo, >> >> --On 1 August 2013 15:51:11 +0200 Paolo Bonzini wrote: >> >> >>> So actually there is another problem with this patch (both the >> >>> condvar and the event approach are equally buggy). If

Re: [Qemu-devel] [PATCH] monitor: fix parsing of big int

2013-08-01 Thread Fam Zheng
On Thu, 08/01 07:52, Eric Blake wrote: > On 08/01/2013 12:31 AM, Fam Zheng wrote: > > Fix it by calling strtoll instead, which will report ERANGE as expected. > > > > (HMP) block_set_io_throttle ide0-hd0 99 0 0 0 0 0 > > (HMP) block_set_io_throttle ide0-hd0

[Qemu-devel] [PATCH 4/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Storage key global access

2013-08-01 Thread Jason J. Herne
From: "Jason J. Herne" Introduces global access to storage key data so we can set it for each cpu in the S390 cpu initialization routine. Signed-off-by: Jason J. Herne --- hw/s390x/s390-virtio-ccw.c |5 ++--- hw/s390x/s390-virtio.c | 21 - hw/s390x/s390-virtio.h

Re: [Qemu-devel] [PATCH v2 2/9] block: vhdx - add header update capability.

2013-08-01 Thread Jeff Cody
On Thu, Aug 01, 2013 at 03:44:41PM +0200, Stefan Hajnoczi wrote: > On Wed, Jul 31, 2013 at 11:23:47PM -0400, Jeff Cody wrote: > > @@ -212,6 +242,24 @@ bool vhdx_checksum_is_valid(uint8_t *buf, size_t size, > > int crc_offset) > > > > > > /* > > + * This generates a UUID that is compliant with

[Qemu-devel] [PATCH] target-ppc: Add POWER7+ CPU model

2013-08-01 Thread Alexey Kardashevskiy
This patch adds CPU PVR definition for POWER7+. Signed-off-by: Alexey Kardashevskiy --- target-ppc/cpu-models.c | 2 ++ target-ppc/cpu-models.h | 1 + 2 files changed, 3 insertions(+) diff --git a/target-ppc/cpu-models.c b/target-ppc/cpu-models.c index 9578ed8..c97c183 100644 --- a/target-ppc/c

[Qemu-devel] [PATCH 2/2] usb-redir: fix use-after-free

2013-08-01 Thread Gerd Hoffmann
Reinitialize dev->cs to NULL after deleting it, to make sure it isn't used afterwards. Reported-by: Martin Cerveny Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 8b8c010..e3b9f32 100644 --- a/

Re: [Qemu-devel] [PATCH v2 4/9] block: vhdx - log support struct and defines

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 11:23:49PM -0400, Jeff Cody wrote: > @@ -318,6 +323,18 @@ typedef struct VHDXMetadataEntries { > uint16_t present; > } VHDXMetadataEntries; > > +typedef struct VHDXLogEntries { > +uint64_t offset; > +uint64_t length; > +uint32_t head; > +uint32_t tail

Re: [Qemu-devel] [PATCH] monitor: fix parsing of big int

2013-08-01 Thread Luiz Capitulino
On Thu, 01 Aug 2013 07:52:17 -0600 Eric Blake wrote: > On 08/01/2013 12:31 AM, Fam Zheng wrote: > > Fix it by calling strtoll instead, which will report ERANGE as expected. > > > > (HMP) block_set_io_throttle ide0-hd0 99 0 0 0 0 0 > > (HMP) block_set_io_throttle ide0-hd0

Re: [Qemu-devel] [PATCH] cpus: use cpu_is_stopped efficiently

2013-08-01 Thread “tiejun.chen”
On 08/01/2013 07:38 PM, � wrote: Hi, Am 26.07.2013 10:47, schrieb Tiejun Chen: It makes more sense and simple later. Signed-off-by: Tiejun Chen --- cpus.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index c232265..a997632 100644 ---

[Qemu-devel] [v2][PATCH 1/1] cpus: use cpu_is_stopped efficiently

2013-08-01 Thread Tiejun Chen
It makes more sense and simple later. Signed-off-by: Tiejun Chen --- v1 -> v2: To optimize performance slightly, we can reorder the two conditions to avoid the non-inline function call if cpu->stopped. cpus.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH for mst/pci] output nc->name in NIC_RX_FILTER_CHANGED event

2013-08-01 Thread Amos Kong
On Thu, Aug 01, 2013 at 03:30:53PM +0200, Andreas Färber wrote: > Am 01.07.2013 04:55, schrieb Amos Kong: > > On Wed, Jun 26, 2013 at 12:07:53PM +0200, Markus Armbruster wrote: > >> Amos Kong writes: > >> > >>> On Mon, Jun 24, 2013 at 02:34:59PM +0800, Amos Kong wrote: > netclient 'name' entr

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-08-01 Thread Andreas Färber
Am 01.08.2013 11:38, schrieb Stefan Hajnoczi: > On Wed, Jul 31, 2013 at 03:39:05PM +0200, Vincenzo Maffione wrote: >> Ok, but it's unclear how do you prefer to create and "empty" >> PC_COMPAT_1_6 in Patch 1. >> If you want to keep this declaration form >> >> [...] >> .compat_props = (GlobalProperty

[Qemu-devel] [PATCH 1/2] xhci: fix segfault

2013-08-01 Thread Gerd Hoffmann
Guest trying to reset a endpoint of a disconnected device resulted in xhci trying to dereference uport while being NULL, thereby crashing qemu. Fix that by adding a check. Drop unused dev variable while touching that code bit. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann --- hw/usb/

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Marcel Apfelbaum
On Thu, 2013-08-01 at 16:32 +0300, Michael S. Tsirkin wrote: > On Thu, Aug 01, 2013 at 04:08:57PM +0300, Marcel Apfelbaum wrote: > > Hi, > > > > The problem with pvpanic being an internal device is that VMs running > > operating systems without a driver for this device will have problems > > when

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

2013-08-01 Thread Luiz Capitulino
On Mon, 29 Jul 2013 16:37:12 +0200 Laszlo Ersek wrote: > (Apologies for the long To: list, I'm including everyone who > participated in > ). > > Conceptually, the dump-guest-memory command works as follows: > (a) pause the gues

[Qemu-devel] [PULL for-1.6 0/2] usb fixes

2013-08-01 Thread Gerd Hoffmann
Hi, Two more little usb fixes for 1.6. please pull, Gerd The following changes since commit 75e2a4baf1536682d111d9bee0261806737a32dc: Merge remote-tracking branch 'spice/spice.v72' into staging (2013-07-30 18:48:58 -0500) are available in the git repository at: git://git.kraxel.org/

Re: [Qemu-devel] [PATCH] cpus: use cpu_is_stopped efficiently

2013-08-01 Thread Marcelo Tosatti
On Thu, Aug 01, 2013 at 04:12:03PM +0800, "“tiejun.chen”" wrote: > On 07/26/2013 04:47 PM, Tiejun Chen wrote: > >It makes more sense and simple later. > > Any feedback :) > > Tiejun Reviewed-by: Marcelo Tosatti

Re: [Qemu-devel] [edk2] SetVirtualAddressMap and NX bit

2013-08-01 Thread Borislav Petkov
+ Matt. On Wed, Jul 31, 2013 at 02:10:04PM +0200, Laszlo Ersek wrote: > Just random ideas... First of all, thanks for looking. You made me look too and find the fun :-) The fact that you guys didn't say "Oh yeah, we do this because... " but simply shruggingly suggested ideas should've been enoug

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Paolo Bonzini
> KVM disabled HW counters when outside of a guest mode (otherwise result > will be useless), so I do not see how the problem you describe can > happen. Yes, you're right. > On the other hand MPU emulation assumes that counter have to be disabled > while MSR_IA32_PERFCTR0 is written since write t

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2013 at 04:08:57PM +0300, Marcel Apfelbaum wrote: > Hi, > > The problem with pvpanic being an internal device is that VMs running > operating systems without a driver for this device will have problems > when qemu will be upgraded (from qemu without this pvpanic). > > The outcome

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Eric Blake
On 08/01/2013 04:23 PM, Paolo Bonzini wrote: >> Automatic devices with no command line argument have proven to be a >> nightmare for libvirt as well. Although the just-released libvirt 1.1.1 >> now supports the element for controlling the command line >> parameters of qemu related to how qemu wil

Re: [Qemu-devel] [PATCH v3] semaphore: fix a hangup problem under load on NetBSD hosts.

2013-08-01 Thread Paolo Bonzini
On 08/01/2013 05:24 AM, Brad wrote: On 03/07/13 5:41 AM, Laszlo Ersek wrote: On 07/03/13 10:58, Izumi Tsutsui wrote: Fix following bugs in "fallback implementation of counting semaphores with mutex+condvar" added in c166cb72f1676855816340666c3b618beef4b976: - waiting threads are not restarted

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Paolo Bonzini
On 08/01/2013 06:26 PM, Eric Blake wrote: On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: On 08/01/13 15:08, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will be up

[Qemu-devel] [ANNOUNCE] QEMU 1.6.0-rc1 is now available

2013-08-01 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 1.6 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.6.0-rc1.tar.bz2 You can help improv

[Qemu-devel] [PATCH 5/8] [PATCH RFC v3] s390-qemu: cpu hotplug - ipi_states enhancements

2013-08-01 Thread Jason J. Herne
From: "Jason J. Herne" Modify s390_cpu_addr2state to allow fetching state information for cpu addresses above smp_cpus. Hotplug requires this capability. Also add s390_cpu_set_state function to allow modification of ipi_state entries during hotplug. Signed-off-by: Jason J. Herne --- hw/s390x

Re: [Qemu-devel] [PATCH] target-mips: fix 34Kf configuration for DSP ASE

2013-08-01 Thread Eric Johnson
Hi Yongbok, You need to make Status.MX writeable as well. - .CP0_Status_rw_bitmask = 0x3678FF1F, + .CP0_Status_rw_bitmask = 0x3778FF1F, -Eric > -Original Message- > From: qemu-devel-bounces+eric.johnson=imgtec@nongnu.org > [mailto:qemu-devel- > bounces+eric.johnson=

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-08-01 Thread Vincenzo Maffione
Ok, so back to the one-patch version! :) I'll prepare it asap. Thanks, Vincenzo 2013/8/1 Andreas Färber : > Am 01.08.2013 11:38, schrieb Stefan Hajnoczi: >> On Wed, Jul 31, 2013 at 03:39:05PM +0200, Vincenzo Maffione wrote: >>> Ok, but it's unclear how do you prefer to create and "empty" >>> PC

[Qemu-devel] default slot used for vga device on q35 machines

2013-08-01 Thread Laine Stump
libvirt makes an assumption that if you specify "-vga qxl" instead of "-device qxl-vga,...", the vga device will be connected to slot 2. I learned this in a recent discussion about a bug caused by switching over to using the former syntax (in order to support multiheaded QXL): https://bugzilla.r

[Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-08-01 Thread Jason J. Herne
From: "Jason J. Herne" Latest code for cpu Hotplug on S390 architecture. This one is vastly simpler than v2 as we have decided to avoid the command line specification of -device s390-cpu. The last version can be found here: http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg01183.html T

Re: [Qemu-devel] [PATCH v2 2/9] block: vhdx - add header update capability.

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 11:23:47PM -0400, Jeff Cody wrote: > @@ -212,6 +242,24 @@ bool vhdx_checksum_is_valid(uint8_t *buf, size_t size, > int crc_offset) > > > /* > + * This generates a UUID that is compliant with the MS GUIDs used > + * in the VHDX spec (and elsewhere). > + * > + * We can d

[Qemu-devel] [PATCH] xhci: implement warm port reset

2013-08-01 Thread Gerd Hoffmann
Without this patch windows can't do port resets for usb3 devices. https://bugzilla.redhat.com/show_bug.cgi?id=949514 Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c inde

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wrapper

2013-08-01 Thread Luiz Capitulino
On Thu, 01 Aug 2013 18:02:08 +0200 Andreas Färber wrote: > Luiz, > > Am 01.08.2013 16:12, schrieb Jason J. Herne: > > From: "Jason J. Herne" > > > > Add HMP cpu-add wrapper to allow cpu hot plugging via monitor. > > > > Signed-off-by: Jason J. Herne > > What are your thoughts on this? Look

Re: [Qemu-devel] net/tap.c: Possibly a way to stall tap input

2013-08-01 Thread Jan Kiszka
On 2013-08-01 19:15, Jan Kiszka wrote: > Hi all, > > I'm tracking down a nasty stall of tap input over a custom 1.3.x QEMU > version. Under certain load, our tap backend stops reading from the char > device, and that even if we reset the guest. The frontend device > (pcnet32) is able to receive (c

[Qemu-devel] net/tap.c: Possibly a way to stall tap input

2013-08-01 Thread Jan Kiszka
Hi all, I'm tracking down a nasty stall of tap input over a custom 1.3.x QEMU version. Under certain load, our tap backend stops reading from the char device, and that even if we reset the guest. The frontend device (pcnet32) is able to receive (can_receive would return > 0), but the tap's fd is n

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2013 at 10:26:53AM -0600, Eric Blake wrote: > On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: > > On 08/01/13 15:08, Marcel Apfelbaum wrote: > >> Hi, > >> > >> The problem with pvpanic being an internal device is that VMs running > >> operating systems without a driver for this device

Re: [Qemu-devel] qemu virtfs 9p not working on arm?

2013-08-01 Thread Peter Maydell
On 1 August 2013 16:59, Rich Felker wrote: > I'm using -M versatilepb -cpu arm1136-r2, also copied from the > Aboriginal Linux image since that's what the kernel was intended to > run on. I'm on the software side, not the hardware side, so I'm far > from an expert in understanding arm hardware var

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Marcel Apfelbaum
On Thu, 2013-08-01 at 19:31 +0300, Michael S. Tsirkin wrote: > On Thu, Aug 01, 2013 at 10:26:53AM -0600, Eric Blake wrote: > > On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: > > > On 08/01/13 15:08, Marcel Apfelbaum wrote: > > >> Hi, > > >> > > >> The problem with pvpanic being an internal device is

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Eric Blake
On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: > On 08/01/13 15:08, Marcel Apfelbaum wrote: >> Hi, >> >> The problem with pvpanic being an internal device is that VMs running >> operating systems without a driver for this device will have problems >> when qemu will be upgraded (from qemu without this

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wrapper

2013-08-01 Thread Andreas Färber
Luiz, Am 01.08.2013 16:12, schrieb Jason J. Herne: > From: "Jason J. Herne" > > Add HMP cpu-add wrapper to allow cpu hot plugging via monitor. > > Signed-off-by: Jason J. Herne What are your thoughts on this? Thanks, Andreas > --- > hmp-commands.hx | 13 + > hmp.c |

Re: [Qemu-devel] qemu virtfs 9p not working on arm?

2013-08-01 Thread Rich Felker
On Thu, Aug 01, 2013 at 10:43:01AM +0100, Peter Maydell wrote: > On 1 August 2013 00:25, Rich Felker wrote: > > I'm not sure whether this is a kernel problem or a qemu problem (or > > even a user problem). The folks on OFTC #qemu suggested I email the > > list and relevant section maintainers so t

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Gerd Hoffmann
On 08/01/13 15:08, Marcel Apfelbaum wrote: > Hi, > > The problem with pvpanic being an internal device is that VMs running > operating systems without a driver for this device will have problems > when qemu will be upgraded (from qemu without this pvpanic). > > The outcome may be, for example: in

[Qemu-devel] [PATCH 7/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Implement hot_add_cpu hook

2013-08-01 Thread Jason J. Herne
From: "Jason J. Herne" Implement hot_add_cpu for S390 to allow hot plugging of cpus. Signed-off-by: Jason J. Herne --- hw/s390x/s390-virtio-ccw.c |3 +++ target-s390x/cpu.c | 32 target-s390x/cpu.h |2 ++ 3 files changed, 37 insertions

Re: [Qemu-devel] [PATCH v2 4/9] block: vhdx - log support struct and defines

2013-08-01 Thread Jeff Cody
On Thu, Aug 01, 2013 at 05:00:05PM +0200, Stefan Hajnoczi wrote: > On Wed, Jul 31, 2013 at 11:23:49PM -0400, Jeff Cody wrote: > > @@ -318,6 +323,18 @@ typedef struct VHDXMetadataEntries { > > uint16_t present; > > } VHDXMetadataEntries; > > > > +typedef struct VHDXLogEntries { > > +uint

Re: [Qemu-devel] [PATCH v2 5/9] block: vhdx - break endian translation functions out

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 11:23:50PM -0400, Jeff Cody wrote: > diff --git a/block/vhdx.h b/block/vhdx.h > index 2db6615..5e0a1d3 100644 > --- a/block/vhdx.h > +++ b/block/vhdx.h > @@ -398,4 +398,17 @@ static inline void cpu_to_leguids(MSGUID *guid) > cpu_to_le16s(&guid->data3); > } > > +void

[Qemu-devel] [PATCH 2/8] [PATCH RFC v3] s390-qemu: cpu hotplug - SCLP CPU Info

2013-08-01 Thread Jason J. Herne
From: "Jason J. Herne" Implement the CPU data in SCLP "Read SCP Info". And implement "Read CPU Info" SCLP command. This data will be used by the guest to get information about hot plugged cpus. Signed-off-by: Jason J. Herne --- hw/s390x/sclp.c | 51 ++

Re: [Qemu-devel] [PATCH v2 6/9] block: vhdx - update log guid in header, and first write tracker

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 11:23:51PM -0400, Jeff Cody wrote: > @@ -998,6 +1006,16 @@ exit: > > > > +/* Per the spec, on the first write of guest-visible data to the file the > + * data write guid must be updated in the header */ > +void vhdx_user_visible_write(BlockDriverState *bs, BDRVVHDXStat

Re: [Qemu-devel] [PATCH v2 5/9] block: vhdx - break endian translation functions out

2013-08-01 Thread Jeff Cody
On Thu, Aug 01, 2013 at 05:03:39PM +0200, Stefan Hajnoczi wrote: > On Wed, Jul 31, 2013 at 11:23:50PM -0400, Jeff Cody wrote: > > diff --git a/block/vhdx.h b/block/vhdx.h > > index 2db6615..5e0a1d3 100644 > > --- a/block/vhdx.h > > +++ b/block/vhdx.h > > @@ -398,4 +398,17 @@ static inline void cpu_

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

2013-08-01 Thread Luiz Capitulino
On Thu, 1 Aug 2013 09:41:07 -0400 Luiz Capitulino wrote: > Applied to the qmp branch, thanks. Hmm, it brakes the build. Dropping it from the queue for now: /home/lcapitulino/work/src/upstream/qmp-unstable/target-s390x/arch_dump.c:179:5: error: conflicting types for ‘cpu_get_dump_info’ int cpu

[Qemu-devel] [PULL for-1.6 0/2] QMP queue

2013-08-01 Thread Luiz Capitulino
The following changes since commit 1197cbb9eda1dc82e2fa1815ca62bc3de158353e: qdev: Use clz in print_size (2013-07-31 07:54:21 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to 8c0426aed1d2279845e6a2c3355da8b5d9926c

[Qemu-devel] [PULL 2/2] migration: don't use uninitialized variables

2013-08-01 Thread Luiz Capitulino
From: Pawit Pornkitprasan The qmp_migrate method uses the 'blk' and 'inc' parameter without checking if they're valid or not (they may be uninitialized if command is received via QMP) Signed-off-by: Pawit Pornkitprasan Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- migration.c |

[Qemu-devel] [PULL 1/2] migration: send total time in QMP at "completed" stage

2013-08-01 Thread Luiz Capitulino
From: Pawit Pornkitprasan The "completed" stage sets total_time but not has_total_time and thus it is not sent via QMP reply (but sent via HMP nevertheless) Signed-off-by: Pawit Pornkitprasan Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman Signed-off-by: Luiz Capitulino --- migration.c

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Paolo Bonzini
On Aug 01 2013, Alex Bligh wrote: > Paolo, > > --On 1 August 2013 15:51:11 +0200 Paolo Bonzini wrote: > > >>> So actually there is another problem with this patch (both the > >>> condvar and the event approach are equally buggy). If a timer > >>> on clock X disables clock X, qemu_clock_enable

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Alex Bligh
Paolo, --On 1 August 2013 15:51:11 +0200 Paolo Bonzini wrote: > So actually there is another problem with this patch (both the > condvar and the event approach are equally buggy). If a timer > on clock X disables clock X, qemu_clock_enable will deadlock. Yes. I believe there will be a simila

[Qemu-devel] [PATCH 6/8] [PATCH RFC v3] s390-qemu: cpu hotplug - s390 cpu init improvements for hotplug

2013-08-01 Thread Jason J. Herne
From: "Jason J. Herne" s390_new_cpu is created to encapsulate the creation of a new QOM S390CPU object given a cpuid and a model string. All actual cpu initialization code is moved from boot time specific functions to s390_cpu_initfn (qom init routine) or to s390_new_cpu. This i

Re: [Qemu-devel] [RFC] [PATCHv4 10/13] aio / timers: Convert mainloop to use timeout

2013-08-01 Thread Paolo Bonzini
On Aug 01 2013, Alex Bligh wrote: > Paolo, > > >>@@ -449,6 +460,7 @@ int main_loop_wait(int nonblocking) > >> { > >> int ret; > >> uint32_t timeout = UINT32_MAX; > >>+int64_t timeout_ns; > >> > >> if (nonblocking) { > >> timeout = 0; > >>@@ -462,7 +474,21 @@ int main_loop_

[Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wrapper

2013-08-01 Thread Jason J. Herne
From: "Jason J. Herne" Add HMP cpu-add wrapper to allow cpu hot plugging via monitor. Signed-off-by: Jason J. Herne --- hmp-commands.hx | 13 + hmp.c | 10 ++ hmp.h |1 + 3 files changed, 24 insertions(+) diff --git a/hmp-commands.hx b/hmp-comma

[Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Define New SCLP Codes

2013-08-01 Thread Jason J. Herne
From: "Jason J. Herne" Define new SCLP codes to improve code readability. Signed-off-by: Jason J. Herne --- hw/s390x/sclp.c |2 +- include/hw/s390x/sclp.h |8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index 86d6ae0.

[Qemu-devel] [PATCH 3/8] [PATCH RFC v3] s390-qemu: cpu hotplug - SCLP Event integration

2013-08-01 Thread Jason J. Herne
From: "Jason J. Herne" Add an sclp event for "cpu was hot plugged". This allows Qemu to deliver an SCLP interrupt to the guest stating that the requested cpu hotplug was completed. Signed-off-by: Jason J. Herne --- hw/s390x/Makefile.objs|2 +- hw/s390x/event-facility.c

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Paolo Bonzini
On Aug 01 2013, Alex Bligh wrote: > >So actually there is another problem with this patch (both the > >condvar and the event approach are equally buggy). If a timer > >on clock X disables clock X, qemu_clock_enable will deadlock. > > Yes. I believe there will be a similar problem if a timer > cre

[Qemu-devel] [Bug 1207228] [NEW] Qemu (trunk code) crashes when using --soundhw all option in ioport.c

2013-08-01 Thread FredBezies
Public bug reported: After not building qemu (git version) for about 3 weeks, I've done it again this morning. With up-to-date trunk code, I got this error on start, when using --soundhw all option $ qemu-system-i386 -soundhw all qemu-system-i386: /home/fred/Téléchargements/logs/qemu-git/src/qe

[Qemu-devel] qemu virtfs 9p not working on arm?

2013-08-01 Thread Rich Felker
Hi, I'm not sure whether this is a kernel problem or a qemu problem (or even a user problem). The folks on OFTC #qemu suggested I email the list and relevant section maintainers so that's what I'm doing -- hope it's okay. I'm trying to boot qemu-system-arm with rootfs on 9p, and experiencing the

Re: [Qemu-devel] [RFC] [PATCHv4 10/13] aio / timers: Convert mainloop to use timeout

2013-08-01 Thread Alex Bligh
Paolo, @@ -449,6 +460,7 @@ int main_loop_wait(int nonblocking) { int ret; uint32_t timeout = UINT32_MAX; +int64_t timeout_ns; if (nonblocking) { timeout = 0; @@ -462,7 +474,21 @@ int main_loop_wait(int nonblocking) slirp_pollfds_fill(gpollfds); # endif qe

Re: [Qemu-devel] [PATCH] monitor: fix parsing of big int

2013-08-01 Thread Eric Blake
On 08/01/2013 12:31 AM, Fam Zheng wrote: > Fix it by calling strtoll instead, which will report ERANGE as expected. > > (HMP) block_set_io_throttle ide0-hd0 99 0 0 0 0 0 > (HMP) block_set_io_throttle ide0-hd0 999 0 0 0 0 0 > number too large > (HMP)

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Gleb Natapov
On Thu, Aug 01, 2013 at 03:48:29PM +0200, Paolo Bonzini wrote: > On Aug 01 2013, Gleb Natapov wrote: > > On Thu, Aug 01, 2013 at 03:03:12PM +0200, Paolo Bonzini wrote: > > > > KVM disabled HW counters when outside of a guest mode (otherwise result > > > > will be useless), so I do not see how the

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Paolo Bonzini
On Aug 01 2013, Gleb Natapov wrote: > On Thu, Aug 01, 2013 at 03:03:12PM +0200, Paolo Bonzini wrote: > > > KVM disabled HW counters when outside of a guest mode (otherwise result > > > will be useless), so I do not see how the problem you describe can > > > happen. > > > > Yes, you're right. > >

Re: [Qemu-devel] [PATCH for mst/pci] output nc->name in NIC_RX_FILTER_CHANGED event

2013-08-01 Thread Andreas Färber
Am 01.07.2013 04:55, schrieb Amos Kong: > On Wed, Jun 26, 2013 at 12:07:53PM +0200, Markus Armbruster wrote: >> Amos Kong writes: >> >>> On Mon, Jun 24, 2013 at 02:34:59PM +0800, Amos Kong wrote: netclient 'name' entry in event is useful for management to know which device is changed. n-

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Alex Bligh
Paolo, --On 1 August 2013 08:19:34 -0400 Paolo Bonzini wrote: > True, qemu_event basically works only when a single thread resets it. > But there is no race condition here because qemu_run_timers cannot be > executed concurrently by multiple threads (like aio_poll in your > bottom half patches

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Gleb Natapov
On Thu, Aug 01, 2013 at 03:03:12PM +0200, Paolo Bonzini wrote: > > KVM disabled HW counters when outside of a guest mode (otherwise result > > will be useless), so I do not see how the problem you describe can > > happen. > > Yes, you're right. > > > On the other hand MPU emulation assumes that c

[Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Marcel Apfelbaum
Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will be upgraded (from qemu without this pvpanic). The outcome may be, for example: in Windows(let's say XP) the Device manager will open a "ne

Re: [Qemu-devel] [PATCH 2/2] KVM: s390: add floating irq controller

2013-08-01 Thread Jens Freimann
Am 2013 8 1 07:21 schrieb "Heiko Carstens" : > > On Wed, Jul 31, 2013 at 11:08:15AM +0200, Cornelia Huck wrote: > > On Mon, 29 Jul 2013 15:59:53 +0200 > > Jens Freimann wrote: > > > > > This patch adds a floating irq controller as a kvm_device. > > > It will be necesary for migration of floating i

Re: [Qemu-devel] [RFC] [PATCHv4 10/13] aio / timers: Convert mainloop to use timeout

2013-08-01 Thread Paolo Bonzini
On Jul 26 2013, Alex Bligh wrote: > Convert mainloop to use timeout from 3 static timers. > > Signed-off-by: Alex Bligh > --- > main-loop.c | 48 +--- > 1 file changed, 37 insertions(+), 11 deletions(-) > > diff --git a/main-loop.c b/main-loop.c >

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Paolo Bonzini
> > True, qemu_event basically works only when a single thread resets it. But > > there is no race condition here because qemu_run_timers cannot be executed > > concurrently by multiple threads (like aio_poll in your bottom half > > patches). > > ... or, if rebasing on top of my patches, qemu_run

Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 06:13:53PM +0800, Fam Zheng wrote: > BlockDriverState lifecycle management is needed by future features such as > image fleecing and blockdev-add. This series adds reference count to > BlockDriverState. > > The first two patches clean up two odd BlockDriverState use cases,

Re: [Qemu-devel] Using virtio-mmio

2013-08-01 Thread Richard W.M. Jones
On Thu, Aug 01, 2013 at 11:58:15AM +0100, Peter Maydell wrote: > Unfortunately at this point you run into the classic > issue of trying to get an ARM kernel running, which > is that a huge class of config errors all have the > failure mode "just sits there with no serial output". > This is remarkab

Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 06:13:53PM +0800, Fam Zheng wrote: > BlockDriverState lifecycle management is needed by future features such as > image fleecing and blockdev-add. This series adds reference count to > BlockDriverState. > > The first two patches clean up two odd BlockDriverState use cases,

Re: [Qemu-devel] [RFC] [PATCHv4 01/13] aio / timers: add qemu-timer.c utility functions

2013-08-01 Thread Paolo Bonzini
On Jul 26 2013, Alex Bligh wrote: > Add qemu_free_clock and expose qemu_new_clock and clock types. > > Add utility functions to qemu-timer.c for nanosecond timing. > > Add qemu_clock_deadline_ns to calculate deadlines to > nanosecond accuracy. > > Add utility function qemu_soonest_timeout to ca

Re: [Qemu-devel] [PATCH for mst/pci] output nc->name in NIC_RX_FILTER_CHANGED event

2013-08-01 Thread Amos Kong
On Thu, Aug 01, 2013 at 11:59:14AM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 24, 2013 at 02:34:59PM +0800, Amos Kong wrote: > > netclient 'name' entry in event is useful for management to know > > which device is changed. n->netclient_name is not always set. > > This patch changes to use nc->n

Re: [Qemu-devel] [PATCH] cpus: use cpu_is_stopped efficiently

2013-08-01 Thread Andreas Färber
Hi, Am 26.07.2013 10:47, schrieb Tiejun Chen: > It makes more sense and simple later. > > Signed-off-by: Tiejun Chen > --- > cpus.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/cpus.c b/cpus.c > index c232265..a997632 100644 > --- a/cpus.c > +++ b/c

Re: [Qemu-devel] [PATCH] cpus: use cpu_is_stopped efficiently

2013-08-01 Thread “tiejun.chen”
On 07/26/2013 04:47 PM, Tiejun Chen wrote: It makes more sense and simple later. Any feedback :) Tiejun Signed-off-by: Tiejun Chen --- cpus.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index c232265..a997632 100644 --- a/cpus.c +

Re: [Qemu-devel] Using virtio-mmio

2013-08-01 Thread Peter Maydell
On 1 August 2013 11:41, Richard W.M. Jones wrote: > On Thu, Aug 01, 2013 at 10:32:14AM +0100, Peter Maydell wrote: >> You might want to consider -M vexpress-a15, if you >> want a setup that will let you use KVM (will probably >> need to reconfig your kernel appropriately; may >> need to discard "e

Re: [Qemu-devel] Using virtio-mmio

2013-08-01 Thread Richard W.M. Jones
On Thu, Aug 01, 2013 at 10:32:14AM +0100, Peter Maydell wrote: > On 31 July 2013 23:45, Richard W.M. Jones wrote: > > ~/d/qemu/arm-softmmu/qemu-system-arm \ > > -m 512 -M vexpress-a9 -machine kernel_irqchip=on \ > > The combination of 'vexpress-a9' and kernel_irqchip=on > don't make any sense -

[Qemu-devel] [PATCH] target-mips: fix 34Kf configuration for DSP ASE

2013-08-01 Thread Yongbok Kim
34Kf core does support DSP ASE. CP0_Config3 configuration for 34Kf and description are wrong. Please refer to MIPS32(R) 34Kf(TM) Processor Core Datasheet Signed-off-by: Yongbok Kim --- target-mips/translate_init.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/targ

  1   2   >