On Thu, 01 Aug 2013 18:02:08 +0200
Andreas Färber <afaer...@suse.de> wrote:
> Luiz,
>
> Am 01.08.2013 16:12, schrieb Jason J. Herne:
> > From: "Jason J. Herne" <jjhe...@us.ibm.com>
> >
> > Add HMP cpu-add wrapper to allow cpu hot plugging via monitor.
> >
> > Signed-off-by: Jason J. Herne <jjhe...@us.ibm.com>
>
> What are your thoughts on this?
Looks good:
Reviewed-by: Luiz Capitulino <lcapitul...@redhat.com>
>
> Thanks,
> Andreas
>
> > ---
> > hmp-commands.hx | 13 +++++++++++++
> > hmp.c | 10 ++++++++++
> > hmp.h | 1 +
> > 3 files changed, 24 insertions(+)
> >
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index 8c6b91a..cb8712b 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands.hx
> > @@ -1587,6 +1587,19 @@ Executes a qemu-io command on the given block device.
> > ETEXI
> >
> > {
> > + .name = "cpu-add",
> > + .args_type = "id:i",
> > + .params = "id",
> > + .help = "add cpu",
> > + .mhandler.cmd = hmp_cpu_add,
> > + },
> > +
> > +STEXI
> > +@item cpu-add @var{id}
> > +Add CPU with id @var{id}
> > +ETEXI
> > +
> > + {
> > .name = "info",
> > .args_type = "item:s?",
> > .params = "[subcommand]",
> > diff --git a/hmp.c b/hmp.c
> > index c45514b..9465bd4 100644
> > --- a/hmp.c
> > +++ b/hmp.c
> > @@ -1475,6 +1475,16 @@ void hmp_nbd_server_stop(Monitor *mon, const QDict
> > *qdict)
> > hmp_handle_error(mon, &errp);
> > }
> >
> > +void hmp_cpu_add(Monitor *mon, const QDict *qdict)
> > +{
> > + int cpuid;
> > + Error *err = NULL;
> > +
> > + cpuid = qdict_get_int(qdict, "id");
> > + qmp_cpu_add(cpuid, &err);
> > + hmp_handle_error(mon, &err);
> > +}
> > +
> > void hmp_chardev_add(Monitor *mon, const QDict *qdict)
> > {
> > const char *args = qdict_get_str(qdict, "args");
> > diff --git a/hmp.h b/hmp.h
> > index 6c3bdcd..9effca5 100644
> > --- a/hmp.h
> > +++ b/hmp.h
> > @@ -87,5 +87,6 @@ void hmp_nbd_server_stop(Monitor *mon, const QDict
> > *qdict);
> > void hmp_chardev_add(Monitor *mon, const QDict *qdict);
> > void hmp_chardev_remove(Monitor *mon, const QDict *qdict);
> > void hmp_qemu_io(Monitor *mon, const QDict *qdict);
> > +void hmp_cpu_add(Monitor *mon, const QDict *qdict);
> >
> > #endif
> >
>
>
