Re: [Qemu-devel] [PATCH 09/17] memory: iommu support

2013-05-01 Thread David Gibson
On Thu, May 02, 2013 at 07:24:54AM +0200, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 02/05/2013 05:05, David Gibson ha scritto: > >>> I think the problem is that we do not have reference counting, > >>> and this makes it simpler to manage the lifetime. It can be

[Qemu-devel] [PULL] Trivial patches for 2013-05-02

2013-05-01 Thread Michael Tokarev
Hello. As Stefan Hajnoczi mentioned yesterday, I'll try to maintain qemu-trivial patch queue. So here goes the first pull request, with just 3 really trivial patches. For now I push the changes into my repository, available also as http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivia

Re: [Qemu-devel] [PATCH V18 1/6] docs: document for add-cow file format

2013-05-01 Thread Dong Xu Wang
On 2013/4/27 6:45, Eric Blake wrote: On 04/10/2013 02:11 AM, Dong Xu Wang wrote: Document for add-cow format, the usage and spec of add-cow are introduced. Signed-off-by: Dong Xu Wang --- V17->V18: 1) remove version field. 2) header size is maximum value and cluster size value. 3) fix type.

Re: [Qemu-devel] [PATCH 09/17] memory: iommu support

2013-05-01 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 02/05/2013 05:05, David Gibson ha scritto: >>> I think the problem is that we do not have reference counting, >>> and this makes it simpler to manage the lifetime. It can be >>> changed later. > I don't really follow this logic. In the existing ca

Re: [Qemu-devel] [PATCH 1/1 V4] virtio-net: dynamic network offloads configuration

2013-05-01 Thread Michael S. Tsirkin
On Mon, Apr 22, 2013 at 12:58:26PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Sun, Apr 07, 2013 at 09:34:08AM +0300, Dmitry Fleytman wrote: > >> From: Dmitry Fleytman > >> > >> Virtio-net driver currently negotiates network offloads > >> on startup via features mechan

[Qemu-devel] Debug init on Qemu using gdb!

2013-05-01 Thread Muhammad Nouman
Hi ! i want to debug init code on Qemu using gdb. I want to see that which instructions are running in userpace while the init is executing its code.Currently the gdb is showing only the instructions running in kernel space . Can anyone please suggest what should i do? Thanks Nouman

Re: [Qemu-devel] [PATCH 09/17] memory: iommu support

2013-05-01 Thread David Gibson
On Wed, May 01, 2013 at 06:10:47PM +0200, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 01/05/2013 06:35, David Gibson ha scritto: > >> From: Avi Kivity > >> > >> Add a new memory region type that translates addresses it is > >> given, then forwards them to a targ

Re: [Qemu-devel] [PATCH 16/17] spapr_vio: take care of creating our own AddressSpace/DMAContext

2013-05-01 Thread David Gibson
On Wed, May 01, 2013 at 06:09:21PM +0200, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 01/05/2013 07:16, David Gibson ha scritto: > > Lack of atomicity makes me a little nervous there, although I > > guess its ok since qemu is single-threaded. > > Yes. The origin

[Qemu-devel] [PATCH V4 5/5] block: make all steps in qmp_transaction() as callback

2013-05-01 Thread Wenchao Xia
Make it easier to add other operations to qmp_transaction() by using callbacks, with external snapshots serving as an example implementation of the callbacks. Signed-off-by: Wenchao Xia --- blockdev.c | 92 ++- 1 files changed, 71 inserti

[Qemu-devel] [PATCH V4 4/5] block: package rollback code in qmp_transaction()

2013-05-01 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- blockdev.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 26bc78e..77adec8 100644 --- a/blockdev.c +++ b/blockdev.c @@ -882,6 +882,13 @@ static void external_snapshot_commit(BlkTransactionStates *sta

[Qemu-devel] [PATCH V4 2/5] block: move input parsing code in qmp_transaction()

2013-05-01 Thread Wenchao Xia
The code is moved into preparation function, and changed a bit to tip more clearly what it is doing. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- blockdev.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/blockdev.c b/blo

[Qemu-devel] [PATCH V4 1/5] block: package preparation code in qmp_transaction()

2013-05-01 Thread Wenchao Xia
The code before really committing is moved into a function. Most code are simply moved from qmp_transaction(), except that on fail it just return now. Other code such as input parsing is not touched, to make it easier in review. Signed-off-by: Wenchao Xia --- blockdev.c | 139 ++

[Qemu-devel] [PATCH V4 3/5] block: package committing code in qmp_transaction()

2013-05-01 Thread Wenchao Xia
The code is simply moved into a separate function. Signed-off-by: Wenchao Xia --- blockdev.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/blockdev.c b/blockdev.c index 06100d7..26bc78e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -871,6 +871,17 @@ st

[Qemu-devel] [PATCH V4 0/5] block: make qmp_transaction extendable

2013-05-01 Thread Wenchao Xia
This serial will package backing chain snapshot code as one case, to make it possible adding more operations later. v2: Address Kevin's comments: Use the same prototype prepare, commit, rollback model in original code, commit should never fail. v3: Address Stefan's comments: 3/5, 4/5: r

[Qemu-devel] [PATCH v5 5/6] vmdk: store fields of VmdkMetaData in cpu endian

2013-05-01 Thread Fam Zheng
Previously VmdkMetaData.offset is stored little endian while other fields are cpu endian. This changes offset to cpu endian and convert before writing to image. Signed-off-by: Fam Zheng --- block/vmdk.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/block/vm

[Qemu-devel] [PATCH v5 6/6] vmdk: add bdrv_co_write_zeroes

2013-05-01 Thread Fam Zheng
Use special offset to write zeroes efficiently, when zeroed-grain GTE is available. If zero-write an allocated cluster, cluster is leaked because its offset pointer is overwritten by "0x1". Signed-off-by: Fam Zheng --- block/vmdk.c | 86 +++

[Qemu-devel] [PATCH v5 3/6] vmdk: Add option to create zeroed-grain image

2013-05-01 Thread Fam Zheng
Add image create option "zeroed-grain" to enable zeroed-grain GTE feature of vmdk sparse extents. When this option is on, header version of newly created extent will be 2 and VMDK4_FLAG_ZERO_GRAIN flag bit will be set. Signed-off-by: Fam Zheng --- block/vmdk.c | 22 +- 1 file

[Qemu-devel] [PATCH v5 4/6] vmdk: change magic number to macro

2013-05-01 Thread Fam Zheng
Two hard coded flag bits are changed to macros. Signed-off-by: Fam Zheng --- block/vmdk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index cc19e20..0463d3b 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -32,6 +32,7 @@ #define VMDK3_MAGIC ((

[Qemu-devel] [PATCH v5 2/6] vmdk: add support for “zeroed‐grain” GTE

2013-05-01 Thread Fam Zheng
Introduced support for zeroed-grain GTE, as specified in Virtual Disk Format 5.0[1]. Recent VMware hosted platform products support a new “zeroed‐grain” grain table entry (GTE). The zeroed‐grain GTE returns all zeros on read. In other words, the zeroed‐grain GTE indicates that a grain

[Qemu-devel] [PATCH v5 1/6] vmdk: named return code.

2013-05-01 Thread Fam Zheng
Internal routines in vmdk.c previously return -1 on error and 0 on success. More return values are useful for future changes such as zeroed-grain GTE. Change all the magic `return 0` and `return -1` to macro names: * VMDK_OK 0 * VMDK_ERROR (-1) * VMDK_UNALLOC (-2) * VMDK_ZEROED (-3) S

[Qemu-devel] [PATCH v5 0/6] vmdk: zeroed-grain GTE support

2013-05-01 Thread Fam Zheng
Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1]. [1] Virtual Disk Format 5.0 - VMware, http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk Changes since v4: - 6/6: Correct endianess: *m_data->l2_cache_entry = offset; Changes since v3: - 5/6:

Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-01 Thread Wenchao Xia
于 2013-4-30 3:05, Luiz Capitulino 写道: On Fri, 26 Apr 2013 16:46:57 +0200 Stefan Hajnoczi wrote: On Fri, Apr 26, 2013 at 05:31:15PM +0800, Wenchao Xia wrote: @@ -2586,10 +2585,12 @@ void do_info_snapshots(Monitor *mon, const QDict *qdict) } if (total > 0) { -monitor_printf

Re: [Qemu-devel] [PATCH 4/7] block: distinguish id and name in bdrv_find_snapshot()

2013-05-01 Thread Wenchao Xia
于 2013-5-1 2:16, Eric Blake 写道: On 04/26/2013 03:31 AM, Wenchao Xia wrote: To make it clear about id and name in searching, the API is changed a bit to distinguish them, and caller can choose to search by id or name. If not found, *errp will be set to tip why. Note that the caller logic is chan

[Qemu-devel] [v2][Qemu-ppc][PATCH 1/1] PPC: e500: correct params->ram_size with ram_size

2013-05-01 Thread Tiejun Chen
We should sync params->ram_size after we fixup memory size on a alignment boundary. Otherwise Guest would exceed the actual memory region. Signed-off-by: Tiejun Chen --- v2: eliminate that original comment in v1. hw/ppc/e500.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/e500

Re: [Qemu-devel] [PATCH qom-cpu 4/9] target-i386: Replace cpuid_*features fields with a feature word array

2013-05-01 Thread Andreas Färber
Am 22.04.2013 21:00, schrieb Eduardo Habkost: > This replaces the feature-bit fields on both X86CPU and x86_def_t > structs with an array. > > With this, we will be able to simplify code that simply does the same > operation on all feature words (e.g. kvm_check_features_against_host(), > filter_fe

Re: [Qemu-devel] [PATCH 1/2] target-ppc: Fix invalid SPR read/write warnings

2013-05-01 Thread Alexander Graf
On 01.05.2013, at 12:43, Anton Blanchard wrote: > > Invalid and privileged SPR warnings currently print the wrong > address. While fixing that, also make it clear that we are > printing both the decimal and hexadecimal SPR number. > > Before: > > Trying to read invalid spr 896 380 at

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-05-01 Thread Jonathan Jefferson
I used this handy tool to run system call preliminary benchmarks: http://code.google.com/p/byte-unixbench/ In a nutshell, what I found is a confirmation that live migration does indeed degrade performance on precise KVM. I hope the below results help narrow down this critical problem to event

Re: [Qemu-devel] [PATCH qom-cpu 2/9] target-i386/kvm.c: Code formatting changes

2013-05-01 Thread Andreas Färber
Am 22.04.2013 21:00, schrieb Eduardo Habkost: > Add appropriate spaces around operators, and break line where it needs > to be broken to allow feature-words array to be introduced without > having too-long lines. > > Signed-off-by: Eduardo Habkost > Reviewed-By: Igor Mammedov > --- > Changes v9:

Re: [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-01 Thread Andreas Färber
Am 22.04.2013 21:00, schrieb Eduardo Habkost: > This series includes the previous "replace cpuid_*features fields with a > feature > word array" series. > > The first 4 patches already have a Reviewed-by from Igor, they correspond to > v10 > plus a small indent fix requested by him. > > As the

Re: [Qemu-devel] [Bug 1175089] [NEW] Crash why dragon fly 3.4.1

2013-05-01 Thread Venkatesh Srinivas
On Wed, May 1, 2013 at 1:29 AM, BRULE Herman <1175...@bugs.launchpad.net> wrote: > Public bug reported: > > Hello, all is here (kernel 3.8, qemu 1.2.2-r3): > /usr/bin/qemu-system-x86_64 -k fr -alt-grab -m 2048 -vga vmware -net > nic,vlan=0,model=virtio -net user -rtc base=localtime -smp > 4,cores

[Qemu-devel] [PATCH] PPC: Add MMU type for 2.06 with AMR but no TB pages

2013-05-01 Thread Alexander Graf
When running -cpu on a POWER7 system with PR KVM, we mask out the 1TB MMU capability from the MMU type mask, but not the AMR bit. This leads to us having a new MMU type that we don't check for in our MMU management functions. Add the new type, so that we don't have to worry about breakage there.

[Qemu-devel] [Bug 1175089] [NEW] Crash why dragon fly 3.4.1

2013-05-01 Thread BRULE Herman
Public bug reported: Hello, all is here (kernel 3.8, qemu 1.2.2-r3): /usr/bin/qemu-system-x86_64 -k fr -alt-grab -m 2048 -vga vmware -net nic,vlan=0,model=virtio -net user -rtc base=localtime -smp 4,cores=4,sockets=1 -boot once=d -cdrom dfly-x86_64-gui-3.4.1_REL.iso KVM internal error. Suberror

Re: [Qemu-devel] [PATCH 2/2] Add i.MX25 3DS evaluation board support

2013-05-01 Thread Jean-Christophe DUBOIS
Peter, I have submitted a few patch to add support to the i.MX25 processor and the 3DS Freescale evaluation platform. Most of the i.MX devices present on i.MX25 can be reused on other Freescale processors including the i.MX6. So far I did not get that much feedback on this. Is this of any

[Qemu-devel] [PATCH 2/2] Add i.MX device to i.MX25 3DS platform.

2013-05-01 Thread Jean-Christophe DUBOIS
Signed-off-by: Jean-Christophe DUBOIS --- hw/arm/imx25_3ds.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/hw/arm/imx25_3ds.c b/hw/arm/imx25_3ds.c index 9de4941..aba9279 100644 --- a/hw/arm/imx25_3ds.c +++ b/hw/arm/imx25_3ds

[Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-01 Thread Jean-Christophe DUBOIS
Signed-off-by: Jean-Christophe DUBOIS --- default-configs/arm-softmmu.mak | 2 + hw/i2c/Makefile.objs| 1 + hw/i2c/imx_i2c.c| 374 3 files changed, 377 insertions(+) create mode 100644 hw/i2c/imx_i2c.c diff --git a/default

Re: [Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook

2013-05-01 Thread Andreas Färber
Am 30.04.2013 18:00, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > --- > v3: > * use local static variable for saving cpu_model > > v2: > * override .hot_add_cpu statically starting with 1.5 machine Thanks, applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu I

Re: [Qemu-devel] [RFC] Continuous work on sandboxing

2013-05-01 Thread Corey Bryant
On 05/01/2013 01:25 PM, Eduardo Otubo wrote: On 04/30/2013 12:24 PM, Paul Moore wrote: On Monday, April 29, 2013 05:52:10 PM Corey Bryant wrote: On 04/26/2013 05:07 PM, Paul Moore wrote: [snip] 3. Debugging and/or learning mode - third party libraries still have the problem of interferin

Re: [Qemu-devel] [PATCH] softfloat: rebase to version 2a

2013-05-01 Thread Blue Swirl
On Wed, May 1, 2013 at 5:57 PM, Peter Maydell wrote: > On 1 May 2013 18:53, Blue Swirl wrote: >> On Mon, Apr 29, 2013 at 6:05 PM, Anthony Liguori wrote: >>> d07cca0 Add native softfloat fpu functions (Christoph Egger) > >> d07cca0 was supplied by Christoph Egger (cc'd): >> http://lists.n

Re: [Qemu-devel] [PATCH] softfloat: rebase to version 2a

2013-05-01 Thread Peter Maydell
On 1 May 2013 18:53, Blue Swirl wrote: > On Mon, Apr 29, 2013 at 6:05 PM, Anthony Liguori wrote: >> d07cca0 Add native softfloat fpu functions (Christoph Egger) > d07cca0 was supplied by Christoph Egger (cc'd): > http://lists.nongnu.org/archive/html/qemu-devel/2008-11/msg00939.html As i

Re: [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h

2013-05-01 Thread Peter Maydell
On 1 May 2013 18:09, Michael Tokarev wrote: > Also, Peter, does your followup email mean your Rewieved-by > should be added too? As Andreas says, you don't add R-b: tags unless they were explicitly given. However in this case I think I just forgot to write it, so here you are: Reviewed-by: Peter

Re: [Qemu-devel] [RFC] Moving Hard Freeze to Monday, May 6th.

2013-05-01 Thread Peter Maydell
On 30 April 2013 19:36, Anthony Liguori wrote: > > The current release schedule has hard freeze happening tomorrow. There > are a few things still outstanding including cpu hotplug and updating > SeaBIOS. We still need to resolve how to handle the softfloat code > too. I am particularly interes

Re: [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h

2013-05-01 Thread Andreas Färber
Am 01.05.2013 19:09, schrieb Michael Tokarev: > 30.04.2013 06:59, liguang wrote: >> Signed-off-by: liguang >> --- >> translate-all.c |1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) > > Hmm. Does we require S-o-b line even for such a trivial (but nevertheless > important) stuff?

Re: [Qemu-devel] [RFC] Continuous work on sandboxing

2013-05-01 Thread Eduardo Otubo
On 04/30/2013 12:24 PM, Paul Moore wrote: On Monday, April 29, 2013 05:52:10 PM Corey Bryant wrote: On 04/26/2013 05:07 PM, Paul Moore wrote: [snip] 3. Debugging and/or learning mode - third party libraries still have the problem of interfering in the Qemu's signal mask. According to some p

Re: [Qemu-devel] [PATCH] softfloat: rebase to version 2a

2013-05-01 Thread Andreas Färber
Am 29.04.2013 22:18, schrieb Peter Maydell: > On 29 April 2013 19:53, Anthony Liguori wrote: >> Anthony Liguori writes: >> >>> Thiemo Seufer [...] >>> 5fafdf2 find -type f | xargs sed -i 's/[\t ]$//g' # on most files >>> 63a654b trunc() for Solaris 9 / SPARC, by Juergen Keil. >>>

Re: [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h

2013-05-01 Thread Michael Tokarev
30.04.2013 06:59, liguang wrote: > Signed-off-by: liguang > --- > translate-all.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Hmm. Does we require S-o-b line even for such a trivial (but nevertheless important) stuff? Also, Peter, does your followup email mean your Rewieved-by

Re: [Qemu-devel] [PATCH] softfloat: rebase to version 2a

2013-05-01 Thread Andreas Färber
Am 29.04.2013 20:05, schrieb Anthony Liguori: > N.B. If you are on CC, see after the '---' for a requested action! > > The license of SoftFloat-2b is claimed to be GPLv2 incompatible by > the FSF due to an indemnification clause. The previous release, > SoftFloat-2a, did not contain this clause.

Re: [Qemu-devel] [PATCH] softfloat: rebase to version 2a

2013-05-01 Thread Anthony Liguori
Aurelien Jarno writes: > On Mon, Apr 29, 2013 at 01:05:03PM -0500, Anthony Liguori wrote: >> 7) Checkout the latest master branch, apply the diff from (6) >>- There were a lot of comment rejects, confirmed this was only comments >> and then used an emacs macro to rewrite the comments to

Re: [Qemu-devel] [PATCH v3] Throttle-down guest when live migration does not converge.

2013-05-01 Thread Paolo Bonzini
Il 01/05/2013 18:34, Chegu Vinod ha scritto: > On 5/1/2013 8:40 AM, Paolo Bonzini wrote: >>> I shall make the suggested changes. >>> Appreciate your review feedback on this part of the change. > Hi Paolo., > > Thanks for taking a look (BTW, I accidentally left out the "RFC" in the > patch subject

Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.5] pvscsi: fix compilation on 32 bit hosts

2013-05-01 Thread Michael Tokarev
01.05.2013 09:41, Hervé Poussineau wrote: > This fixes the following error: > In file included from qemu/include/trace.h:4:0, > from trace/generated-events.c:3: > ./trace/generated-tracers.h: In function ‘trace_pvscsi_get_sg_list’: > ./trace/generated-tracers.h:4271:9: error: forma

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Trivial grammar and spelling fixes

2013-05-01 Thread Michael Tokarev
28.04.2013 13:49, Stefan Weil wrote: > similiar -> similar > recieve -> receive > transfered -> transferred > preperation -> preparation > > Most changes are in comments, one modifies a parameter name in a function > prototype. > > The spelling fixes were made using codespell. > > Signed-off-by:

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-1.5] configure: Pick up libseccomp include path

2013-05-01 Thread Michael Tokarev
28.04.2013 18:27, Andreas Färber wrote: > openSUSE 12.3 has seccomp.h in /usr/include/libseccomp-1.0.1, > so add `pkg-config --cflags libseccomp` output to QEMU_CFLAGS. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Andreas Färber Thanks, applied to qemu-trivial tree (372e47e9b5e31c493823d7f512

Re: [Qemu-devel] [PATCH v3] Throttle-down guest when live migration does not converge.

2013-05-01 Thread Chegu Vinod
On 5/1/2013 8:40 AM, Paolo Bonzini wrote: I shall make the suggested changes. Appreciate your review feedback on this part of the change. Hi Paolo., Thanks for taking a look (BTW, I accidentally left out the "RFC" in the patch subject line...my bad!). Hi Vinod, I think unfortunately it is n

Re: [Qemu-devel] [PATCH] softfloat: rebase to version 2a

2013-05-01 Thread Aurelien Jarno
On Mon, Apr 29, 2013 at 01:05:03PM -0500, Anthony Liguori wrote: > N.B. If you are on CC, see after the '---' for a requested action! > > The license of SoftFloat-2b is claimed to be GPLv2 incompatible by > the FSF due to an indemnification clause. The previous release, > SoftFloat-2a, did not co

[Qemu-devel] [PATCH 1.5] win32: fix compilation again

2013-05-01 Thread Paolo Bonzini
While commit c02817e5bfbb27955cac970019e6670dc427bc41 fixed compilation without an installed libtool, moving the dependencies to rules.mak does not work because the version-*-y variables are not defined yet. Building in a clean tree thus fails. Revert the commit and remove the dummy /bin/false as

Re: [Qemu-devel] [RFC] Moving Hard Freeze to Monday, May 6th.

2013-05-01 Thread Rob Landley
On 04/30/2013 01:36:39 PM, Anthony Liguori wrote: The current release schedule has hard freeze happening tomorrow. There are a few things still outstanding including cpu hotplug and updating SeaBIOS. We still need to resolve how to handle the softfloat code too. I am particularly intereste

Re: [Qemu-devel] [PATCH 09/17] memory: iommu support

2013-05-01 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 01/05/2013 06:35, David Gibson ha scritto: >> From: Avi Kivity >> >> Add a new memory region type that translates addresses it is >> given, then forwards them to a target address space. This is >> similar to an alias, except that the mapping is m

Re: [Qemu-devel] [PATCH 15/17] pci: use memory core for iommu support

2013-05-01 Thread Paolo Bonzini
Il 01/05/2013 07:06, David Gibson ha scritto: >>> + +/* FIXME: inherit memory region from bus creator */ + >>> memory_region_init_alias(mr, "iommu-nop", get_system_memory(), >>> 0, INT64_MAX); +return mr; > I don't see the reason for creating a new alias for each PCI > device. Can't pci_dev

Re: [Qemu-devel] [PATCH 16/17] spapr_vio: take care of creating our own AddressSpace/DMAContext

2013-05-01 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 01/05/2013 07:16, David Gibson ha scritto: > Lack of atomicity makes me a little nervous there, although I > guess its ok since qemu is single-threaded. Yes. The original plan was to add a boolean return value to address_space_rw, but I left this

[Qemu-devel] [PATCH qom-cpu for-1.5 4/4] target-i386: Change CPUID model of 486 to 8

2013-05-01 Thread Andreas Färber
This changes the model number of 486 to 8 (DX4) which matches the feature set presented, and actually has the CPUID instruction. This adds a compatibility property, to keep model=0 on pc-*-1.4 and older. Signed-off-by: H. Peter Anvin Cc: Eduardo Habkost [AF: Add compat_props entry] Signed-off-b

[Qemu-devel] [PATCH qom-cpu for-1.5 1/4] qdev: Let qdev_prop_parse() pass through Error

2013-05-01 Thread Andreas Färber
Move error reporting to callers. Signed-off-by: Andreas Färber --- hw/core/qdev-properties.c| 25 +++-- hw/core/qdev.c | 7 ++- include/hw/qdev-properties.h | 5 +++-- qdev-monitor.c | 6 +- 4 files changed, 25 insertions(+), 18 dele

[Qemu-devel] [PATCH qom-cpu for-1.5 3/4] target-i386: Emulate X86CPU subclasses for global properties

2013-05-01 Thread Andreas Färber
After initializing the object from its x86_def_t and before setting any additional -cpu arguments, set any global properties for the designated subclass -{i386,x86_64}-cpu. Signed-off-by: Andreas Färber --- target-i386/cpu.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target-i38

[Qemu-devel] [PATCH qom-cpu for-1.5 2/4] qdev: Introduce qdev_prop_set_custom_globals()

2013-05-01 Thread Andreas Färber
Reuse it in qdev_prop_set_globals(). Signed-off-by: Andreas Färber --- hw/core/qdev-properties.c| 35 --- include/hw/qdev-properties.h | 2 ++ 2 files changed, 26 insertions(+), 11 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties

[Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties

2013-05-01 Thread Andreas Färber
Hello, It's easier adapting the infrastructure to our needs than working around it: X86CPU already has QOM properties today. What's lacking is model subclasses, and with the one X86CPU type its global properties are overwritten by models. But we already know the designated naming scheme for the mo

Re: [Qemu-devel] [PATCH v3] Throttle-down guest when live migration does not converge.

2013-05-01 Thread Paolo Bonzini
> I shall make the suggested changes. > Appreciate your review feedback on this part of the change. Hi Vinod, I think unfortunately it is not acceptable to make this patch work only for KVM. (It cannot work for Xen, but that's not a problem since Xen uses a different migration mechanism; but it

Re: [Qemu-devel] [RFC] Continuous work on sandboxing

2013-05-01 Thread Corey Bryant
On 05/01/2013 10:13 AM, Paul Moore wrote: On Tuesday, April 30, 2013 04:28:54 PM Corey Bryant wrote: Just to be clear, I'm thinking you could launch guests in one of two different seccomp sandboxed environments: 1) Using the existing and more permissive whitelist where every QEMU feature work

Re: [Qemu-devel] [PATCH v2] memory: give name every AddressSpace

2013-05-01 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 01/05/2013 05:25, David Gibson ha scritto: >>> Applied to iommu branch, thanks. > I don't see this patch at git://github.com/bonzini/qemu.git yet. > Did you need to do something to push it out? I just applied it locally for now. Paolo -BEGIN P

Re: [Qemu-devel] [PATCH v3 0/4] Initial VHDX support

2013-05-01 Thread Jeff Cody
On Wed, May 01, 2013 at 02:43:04PM +0200, Stefan Hajnoczi wrote: > On Mon, Apr 29, 2013 at 02:48:15PM -0400, Jeff Cody wrote: > > > > Differences from v2: > > > > > > Patch 2/4: changed 2 uint8_t[16] to MSGUID (Kevin) > > renamed all strucs to proper style (Kevin) > > in

Re: [Qemu-devel] [PATCH] audio: Enable all cards

2013-05-01 Thread Paolo Bonzini
Il 01/05/2013 16:14, Jan Kiszka ha scritto: > From: Jan Kiszka > > ...or they will bitrot to death. > > Signed-off-by: Jan Kiszka > --- > default-configs/sound.mak |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) I agree. I didn't want to change the default without hearing f

[Qemu-devel] [PATCH] m25p80.c: Sync Flash chip list with Linux

2013-05-01 Thread Ed Maste
Add new devices for various manufacturers, and re-sort Spansion list to match the order in Linux, which requires chips with a non-zero extended ID to come first. With this commit the outstanding differences to Linux rev 55bf75b are: - Erase size flag differences in s25sl032p, s25sl064p, s25fl016k

Re: [Qemu-devel] [RFC][PATCH v3 00/24] instrument: Let the user wrap/override specific event tracing routines

2013-05-01 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Sun, Apr 28, 2013 at 09:25:15PM +0200, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >> > On Fri, Apr 26, 2013 at 02:15:46PM +0200, Lluís Vilanova wrote: >> > Advanced users will have to modify the QEMU source. >> >> >> > Basically I think putting a stable API

Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-05-01 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Wed, May 01, 2013 at 06:16:33AM -0600, Eric Blake wrote: >> On 05/01/2013 06:05 AM, Stefan Hajnoczi wrote: >> >> >> +error_printf( >> >> + "%4d-%02d-%02d %02d:%02d:%02d.%03lld+ ", >> >> + fields.tm_year + 1900, fields.tm_mon + 1, fiel

Re: [Qemu-devel] [PATCH v4] Add GDB qAttached support

2013-05-01 Thread Jan Kiszka
On 2013-03-14 20:51, Jan Kiszka wrote: > With this patch QEMU handles qAttached request from gdb. When QEMU > replies 1, GDB sends a "detach" command at the end of a debugging > session otherwise GDB sends "kill". > > The default value for qAttached is 1 on system emulation and 0 on user > emulati

[Qemu-devel] [PATCH] audio: Enable all cards

2013-05-01 Thread Jan Kiszka
From: Jan Kiszka ...or they will bitrot to death. Signed-off-by: Jan Kiszka --- default-configs/sound.mak |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/default-configs/sound.mak b/default-configs/sound.mak index ff69c4d..4f22c34 100644 --- a/default-configs/soun

Re: [Qemu-devel] [RFC] Continuous work on sandboxing

2013-05-01 Thread Paul Moore
On Tuesday, April 30, 2013 04:28:54 PM Corey Bryant wrote: > Just to be clear, I'm thinking you could launch guests in one of two > different seccomp sandboxed environments: > > 1) Using the existing and more permissive whitelist where every QEMU > feature works: > > qemu-kvm -sandbox on,default

Re: [Qemu-devel] [PATCH for 1.5] Revert "target-i386: Use movcond to implement rotate flags."

2013-05-01 Thread Hervé Poussineau
Richard Henderson a écrit : On 2013-05-01 07:06, Hervé Poussineau wrote: This commit breaks boot of MS-DOS 6.22, which stops at: MODE CON CODEPAGE PREPARE=((850) C:\DOS\EGA.CPI) This reverts part of commit 34d80a55ff8517fd37bcfea5063b9797e2bd9132. Signed-off-by: Hervé Poussineau I strongly

Re: [Qemu-devel] pause_all_vcpus() TCG bug?

2013-05-01 Thread Peter Maydell
On 1 May 2013 14:33, Andreas Färber wrote: > Hello, > > This is today's function, with annotations and question inline: > > void pause_all_vcpus(void) > { > CPUArchState *penv = first_cpu; > > qemu_clock_enable(vm_clock, false); > while (penv) { > CPUState *pcpu = ENV_GET_CPU(p

[Qemu-devel] pause_all_vcpus() TCG bug?

2013-05-01 Thread Andreas Färber
Hello, This is today's function, with annotations and question inline: void pause_all_vcpus(void) { CPUArchState *penv = first_cpu; qemu_clock_enable(vm_clock, false); while (penv) { CPUState *pcpu = ENV_GET_CPU(penv); pcpu->stop = true; qemu_cpu_kick(pcpu);

Re: [Qemu-devel] [PATCH for 1.5] Revert "target-i386: Use movcond to implement rotate flags."

2013-05-01 Thread Richard Henderson
On 2013-05-01 07:06, Hervé Poussineau wrote: This commit breaks boot of MS-DOS 6.22, which stops at: MODE CON CODEPAGE PREPARE=((850) C:\DOS\EGA.CPI) This reverts part of commit 34d80a55ff8517fd37bcfea5063b9797e2bd9132. Signed-off-by: Hervé Poussineau I strongly suspect the bug is now fixed

Re: [Qemu-devel] [PATCH v3] Throttle-down guest when live migration does not converge.

2013-05-01 Thread Chegu Vinod
On 5/1/2013 5:38 AM, Eric Blake wrote: On 05/01/2013 06:22 AM, Chegu Vinod wrote: Busy enterprise workloads hosted on large sized VM's tend to dirty memory faster than the transfer rate achieved via live guest migration. Despite some good recent improvements (& using dedicated 10Gig NICs between

Re: [Qemu-devel] [PATCH v3 0/4] Initial VHDX support

2013-05-01 Thread Stefan Hajnoczi
On Mon, Apr 29, 2013 at 02:48:15PM -0400, Jeff Cody wrote: > > Differences from v2: > > > Patch 2/4: changed 2 uint8_t[16] to MSGUID (Kevin) > renamed all strucs to proper style (Kevin) > indentations / style (Kevin) > Removed/fixed outdated comments (Stefan)

Re: [Qemu-devel] [PATCH v3] Throttle-down guest when live migration does not converge.

2013-05-01 Thread Eric Blake
On 05/01/2013 06:22 AM, Chegu Vinod wrote: > Busy enterprise workloads hosted on large sized VM's tend to dirty > memory faster than the transfer rate achieved via live guest migration. > Despite some good recent improvements (& using dedicated 10Gig NICs > between hosts) the live migration does NO

Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-05-01 Thread Daniel P. Berrange
On Wed, May 01, 2013 at 06:16:33AM -0600, Eric Blake wrote: > On 05/01/2013 06:05 AM, Stefan Hajnoczi wrote: > > >> +error_printf( > >> + "%4d-%02d-%02d %02d:%02d:%02d.%03lld+ ", > >> + fields.tm_year + 1900, fields.tm_mon + 1, fields.tm_mday, > >> + fields.tm

Re: [Qemu-devel] Michael Tokarev taking over trivial-patches queue

2013-05-01 Thread Anthony Liguori
Stefan Hajnoczi writes: > Michael Tokarev is taking over maintainership of the trivial-patches > queue starting today. Michael maintains KVM in Debian and > participates on IRC and the mailing lists. Thanks Michael! > > The trivial patches queue is a dedicated patch queue for small patches > w

[Qemu-devel] [PATCH v3] Throttle-down guest when live migration does not converge.

2013-05-01 Thread Chegu Vinod
Busy enterprise workloads hosted on large sized VM's tend to dirty memory faster than the transfer rate achieved via live guest migration. Despite some good recent improvements (& using dedicated 10Gig NICs between hosts) the live migration does NOT converge. If a user chooses to force convergence

Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-05-01 Thread Eric Blake
On 05/01/2013 06:05 AM, Stefan Hajnoczi wrote: >> +error_printf( >> + "%4d-%02d-%02d %02d:%02d:%02d.%03lld+ ", >> + fields.tm_year + 1900, fields.tm_mon + 1, fields.tm_mday, >> + fields.tm_hour, fields.tm_min, fields.tm_sec, >> + now % 1000); > > Ca

Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-05-01 Thread Stefan Hajnoczi
On Mon, Apr 29, 2013 at 03:57:25PM -0400, Seiji Aguchi wrote: > diff --git a/util/qemu-error.c b/util/qemu-error.c > index 08a36f4..35ef9ab 100644 > --- a/util/qemu-error.c > +++ b/util/qemu-error.c > @@ -196,6 +196,96 @@ void error_print_loc(void) > } > } > > + > +#define SECS_PER_HOUR (

Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-05-01 Thread Stefan Hajnoczi
On Mon, Apr 29, 2013 at 09:51:47AM -0600, Eric Blake wrote: > On 04/29/2013 03:27 AM, Paolo Bonzini wrote: > > Il 29/04/2013 09:21, Stefan Hajnoczi ha scritto: > >>> I'd really love to see us change 'BlockJobInfo' to use an enum for > >>> 'type', instead of its open-coded 'str'. Likewise, the bloc

Re: [Qemu-devel] [RFC][PATCH v3 00/24] instrument: Let the user wrap/override specific event tracing routines

2013-05-01 Thread Stefan Hajnoczi
On Sun, Apr 28, 2013 at 09:25:15PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Fri, Apr 26, 2013 at 02:15:46PM +0200, Lluís Vilanova wrote: > > Advanced users will have to modify the QEMU source. > > >> > Basically I think putting a stable API in place here isn't going to fly.

[Qemu-devel] Michael Tokarev taking over trivial-patches queue

2013-05-01 Thread Stefan Hajnoczi
Michael Tokarev is taking over maintainership of the trivial-patches queue starting today. Michael maintains KVM in Debian and participates on IRC and the mailing lists. The trivial patches queue is a dedicated patch queue for small patches which may or may not fall into an actively maintained QE

Re: [Qemu-devel] [PATCH] Fix PReP NIP reset value

2013-05-01 Thread Andreas Färber
Am 30.04.2013 17:07, schrieb Fabien Chouteau: > The value was changed by the "PPC: fix hreset_vector..." patch. > > Signed-off-by: Fabien Chouteau > --- > hw/ppc/prep.c |3 +++ > 1 file changed, 3 insertions(+) Thanks, applied to prep-up (with enhanced commit message): http://repo.or.cz/w/q

Re: [Qemu-devel] [RFC 7/7] target-i386: Disable direct passthrough of PMU CPUID leaf by default

2013-05-01 Thread Andreas Färber
Am 30.04.2013 21:57, schrieb Eduardo Habkost: > On Tue, Apr 30, 2013 at 07:04:23PM +0200, Igor Mammedov wrote: >> It's impossible to implement "n270 movbe" fixup with compat props currently, >> so 5/7 + 1/7 looks ok. We can drop them once features converted to static >> properties >> + sub-classe

Re: [Qemu-devel] [PATCH v4 0/6] vmdk: zeroed-grain GTE support

2013-05-01 Thread Stefan Hajnoczi
On Sun, Apr 28, 2013 at 11:27:57AM +0800, Fam Zheng wrote: > Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1]. > > [1] Virtual Disk Format 5.0 - VMware, > http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk > > Changes since v3: > - 5/6: Remove

Re: [Qemu-devel] [PATCH v4 6/6] vmdk: add bdrv_co_write_zeroes

2013-05-01 Thread Stefan Hajnoczi
On Sun, Apr 28, 2013 at 11:27:59AM +0800, Fam Zheng wrote: > @@ -835,6 +836,9 @@ static int vmdk_L2update(VmdkExtent *extent, VmdkMetaData > *m_data) > return VMDK_ERROR; > } > } > +if (m_data->l2_cache_entry) { > +*m_data->l2_cache_entry = m_data->offset; >

Re: [Qemu-devel] [PATCH] linux-user: Fix MIPS16/microMIPS signal handling

2013-05-01 Thread Peter Maydell
On 30 April 2013 19:09, Kwok Cheung Yeung wrote: > Signal handlers written using a compressed MIPS instruction > set will segfault when invoked. This patch fixes this. > > Switch the ISA mode on cores supporting the MIPS16/microMIPS > ISAs according to bit 0 of the signal handler address. Clear

[Qemu-devel] [PATCH 2/2] target-ppc: Add read and write of PPR SPR

2013-05-01 Thread Anton Blanchard
Recent Linux kernels save and restore the PPR across exceptions so we need to handle it. Signed-off-by: Anton Blanchard --- Index: b/target-ppc/translate_init.c === --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.

[Qemu-devel] [PATCH 1/2] target-ppc: Fix invalid SPR read/write warnings

2013-05-01 Thread Anton Blanchard
Invalid and privileged SPR warnings currently print the wrong address. While fixing that, also make it clear that we are printing both the decimal and hexadecimal SPR number. Before: Trying to read invalid spr 896 380 at 0714 After: Trying to read invalid spr 896 (0x380) at 000

Re: [Qemu-devel] [PATCH v2 02/12] ARM: Prepare translation for AArch64 code

2013-05-01 Thread Peter Maydell
On 1 May 2013 11:19, Laurent Desnogues wrote: > On Wednesday, May 1, 2013, Richard Henderson wrote: >> On 2013-04-30 07:36, John Rigby wrote: >>> >>> uint32_t regs[16]; >>> + >>> +/* Regs for A64 mode. */ >>> +uint64_t xregs[31]; >>> +uint64_t pc; >>> +uint64_t sp; >>> +

Re: [Qemu-devel] [PATCH v2 02/12] ARM: Prepare translation for AArch64 code

2013-05-01 Thread Laurent Desnogues
On Wednesday, May 1, 2013, Richard Henderson wrote: > On 2013-04-30 07:36, John Rigby wrote: >> >> uint32_t regs[16]; >> + >> +/* Regs for A64 mode. */ >> +uint64_t xregs[31]; >> +uint64_t pc; >> +uint64_t sp; >> +uint32_t pstate; >> +uint32_t aarch64_state; /* 1 if

Re: [Qemu-devel] [PATCH v2 00/12] AArch64 preparation patch set

2013-05-01 Thread Richard Henderson
On 2013-04-30 14:15, Peter Maydell wrote: (add --suppress-cc, --from, --cc, etc to taste, and you can set these defaults in your .gitconfig rather than using command line arguments. --dry-run is also a useful send-email option.) Also helpful is setting some defaults in your qemu/.git/config. E

Re: [Qemu-devel] [PATCH v2 02/12] ARM: Prepare translation for AArch64 code

2013-05-01 Thread Richard Henderson
On 2013-04-30 07:36, John Rigby wrote: uint32_t regs[16]; + +/* Regs for A64 mode. */ +uint64_t xregs[31]; +uint64_t pc; +uint64_t sp; +uint32_t pstate; +uint32_t aarch64_state; /* 1 if CPU is in aarch64 state */ + How do these registers overlap (or not) in real h

  1   2   >