Re: [Qemu-devel] [Qemu-ppc] [PATCH] prep: Fix software reset

2013-04-16 Thread Julio Guerra
2013/2/25 Andreas Färber : > Am 25.02.2013 12:20, schrieb Alexander Graf: >> >> On 16.02.2013, at 16:08, Julio Guerra wrote: >> >>> The software reset of a PReP machine should reset the entire system >>> and not only the processor. It occurs when changing the 7th bit of >>> port 0092 from 0 to 1. >

Re: [Qemu-devel] [PATCH V12 14/18] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-04-16 Thread Wenchao Xia
于 2013-4-17 7:42, Eric Blake 写道: On 04/13/2013 02:56 AM, Wenchao Xia wrote: This patch introduce a new print function, which will output message to monitor when it present. With it, bdrv_snapshot_dump() need no more buffer and can avoid string truncation, bdrv_image_info_dump() can also be us

[Qemu-devel] [PULL v3 6/7] rdma: print throughput while debugging

2013-04-16 Thread mrhines
From: "Michael R. Hines" It's very helpful when debugging to print out migration throughput after each iteration round to compare the different migration technologies. Signed-off-by: Michael R. Hines --- migration.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PULL v3 3/7] rdma: introduce capability for chunk registration

2013-04-16 Thread mrhines
From: "Michael R. Hines" This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. It is enabled by default. Signed-off-by: Michael R. Hines --- migration.c | 10 ++ qapi-schema.json |2 +- 2 files changed, 11 insertio

[Qemu-devel] [PULL v3 7/7] rdma: add documentation

2013-04-16 Thread mrhines
From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact information. Signed-off-by: Michael R. Hines --- docs/rdma.txt | 357 + 1 file changed, 357 insertions(+) create mode 100644 docs/rdm

[Qemu-devel] [PULL v3 2/7] rdma: new QEMUFileOps hooks

2013-04-16 Thread mrhines
From: "Michael R. Hines" These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be able to override the default save_page function. Also included are the prototypes

[Qemu-devel] [PULL v3 1/7] rdma: introduce qemu_ram_foreach_block

2013-04-16 Thread mrhines
From: "Michael R. Hines" This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. Signed-off-by: Michael R. Hines --- exec.c|9 + include/exec/cpu-common.h |5

[Qemu-devel] [PULL v3 0/7] rdma: migration support

2013-04-16 Thread mrhines
From: "Michael R. Hines" The following changes since commit e0a83fc2c1582dc8d4453849852ebe6c258b7c3a: qom: do nothing on unparent of object without parent (2013-04-16 16:10:21 -0500) are available in the git repository at: g...@github.com:hinesmr/qemu.git rdma_patch_v3 for you to fetch c

[Qemu-devel] [PULL v3 5/7] rdma: send pc.ram

2013-04-16 Thread mrhines
From: "Michael R. Hines" This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps 3. Expose a common way to zap zero pages Signed-off-by: Michael R. Hines ---

Re: [Qemu-devel] [PATCH V2 5/5] block: make all steps in qmp_transaction() as callback

2013-04-16 Thread Wenchao Xia
于 2013-4-16 21:52, Kevin Wolf 写道: Am 13.04.2013 um 13:11 hat Wenchao Xia geschrieben: Now qmp_transaction() can be extended with other operation, external snapshot or backing chain creation, is just one case it. Signed-off-by: Wenchao Xia --- blockdev.c | 68

Re: [Qemu-devel] [PULL 5/8] rdma: core rdma logic

2013-04-16 Thread Michael R. Hines
On 04/16/2013 12:49 AM, Paolo Bonzini wrote: +#define RDMA_CHUNK_REGISTRATION +#define RDMA_LAZY_CLIENT_REGISTRATION Please drop these; no dead code. These are important sender-side-only debugging flags. I'll add an explicit "debug-only" comment. +/* Do not merge data if larger than this. */

Re: [Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find()

2013-04-16 Thread Wenchao Xia
Hi, Pavel I have implemented it at http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg02533.html in patch 1,2. Could u check if it satisfy your requirement, if yes maybe you can directly use them. > Signed-off-by: Pavel Hrdina > --- > savevm.c | 33 +++-- >

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-16 Thread Wenchao Xia
于 2013-4-11 1:33, Pavel Hrdina 写道: On 10.4.2013 19:15, Eric Blake wrote: On 04/10/2013 08:05 AM, Pavel Hrdina wrote: Here is another proposal how to handle vm snapshots: QMP vm-snapshot-save: - { 'command': 'vm-snapshot-save', 'data': { 'name': 'str' }, 'returns': 'Snaps

Re: [Qemu-devel] [PATCH V12 02/18] block: distinguish id and name in bdrv_find_snapshot()

2013-04-16 Thread Eric Blake
On 04/13/2013 02:56 AM, Wenchao Xia wrote: > To make it clear about id and name in searching, the API is changed > a bit to distinguish them, and caller can choose to search by id or name. > Searching will be done with higher priority of id. This function also > returns negative value from bdrv_s

[Qemu-devel] [PATCH] qemu-iotests: send 'rbd rm ...' stderr to /dev/null

2013-04-16 Thread Sage Weil
The rbd cli tool now sends progress info to stderr; send that to the bit bucket too. Signed-off-by: Sage Weil --- tests/qemu-iotests/common.rc |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index a536bf7..d7b0ad1

Re: [Qemu-devel] [RFC PATCH v2 3/6] memory: add memory_region_to_address()

2013-04-16 Thread Scott Wood
On 04/16/2013 03:25:50 AM, Peter Maydell wrote: On 16 April 2013 00:19, Scott Wood wrote: > This is useful for when a user of the memory region API needs to > communicate the absolute bus address to something outside QEMU > (in particular, KVM). > > Signed-off-by: Scott Wood > --- > TODO: Use a

Re: [Qemu-devel] [PATCH][RFC v2 3/7] vl: create power chip device

2013-04-16 Thread li guang
在 2013-04-16二的 15:45 -0500,Anthony Liguori写道: > Paolo Bonzini writes: > > > Il 10/04/2013 15:41, guang li ha scritto: > >> Yes, you're right. > >> The motivation is I want to implement a device > >> called EC which is a notion from laptop for QEMU, > >> EC has some main functions, like keyboard,

Re: [Qemu-devel] [PATCH 09/11] savevm: update error reporting off qemu_savevm_state() and related functions

2013-04-16 Thread Eric Blake
On 04/16/2013 10:05 AM, Pavel Hrdina wrote: I think you meant s/off/of/ in the subject. > Signed-off-by: Pavel Hrdina > --- > include/sysemu/sysemu.h | 7 --- > migration.c | 6 +++--- > savevm.c| 38 +++--- > 3 files changed, 26

[Qemu-devel] qemu-kvm 1.2, after VM cloning, source_VM error

2013-04-16 Thread Shashaankar Reddy
Hi All, We have taken qemu-kvm version 1.2 for developing a patch that would do cloning of a VM using pre-copy based live VM migration in qemu-kvm code. After the migration is completed, we could see the cloned_Vm is up and running, also handled network configuration (assigning new mac and Ip add

Re: [Qemu-devel] [PATCH 08/11] block: update error reporting for bdrv_snapshot_create() and related functions

2013-04-16 Thread Eric Blake
On 04/16/2013 10:05 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > block.c | 23 ++- > block/qcow2-snapshot.c| 18 -- > block/qcow2.h | 4 +++- > block/rbd.c | 20 +++- > block/shee

Re: [Qemu-devel] [PATCH 07/11] qapi: Convert loadvm

2013-04-16 Thread Eric Blake
On 04/16/2013 10:05 AM, Pavel Hrdina wrote: > QMP command vm-snapshot-load and HMP command loadvm behave similar to > vm-snapshot-delete and delvm. The only different is that they will load > the snapshot instead of deleting it. > > Signed-off-by: Pavel Hrdina > --- > hmp-commands.hx | 1

Re: [Qemu-devel] [PATCH V12 14/18] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-04-16 Thread Eric Blake
On 04/13/2013 02:56 AM, Wenchao Xia wrote: > This patch introduce a new print function, which will output message to > monitor when it present. With it, bdrv_snapshot_dump() need no more buffer > and can avoid string truncation, bdrv_image_info_dump() can also be used by > hmp code later, besides

Re: [Qemu-devel] [PATCH] migration: reflect incoming failure to shell

2013-04-16 Thread Anthony Liguori
Eric Blake writes: > Management apps like libvirt don't know to pay attention to > stderr unless there is a non-zero exit status. > > * migration.c (process_incoming_migration_co): Exit with non-zero > status on failure. > > Signed-off-by: Eric Blake It looks like the migration coroutine cleans

[Qemu-devel] [PATCH] migration: reflect incoming failure to shell

2013-04-16 Thread Eric Blake
Management apps like libvirt don't know to pay attention to stderr unless there is a non-zero exit status. * migration.c (process_incoming_migration_co): Exit with non-zero status on failure. Signed-off-by: Eric Blake --- Noticed while reviewing: https://lists.gnu.org/archive/html/qemu-devel/20

Re: [Qemu-devel] [PATCH 06/11] savevm: update error reporting for qemu_loadvm_state()

2013-04-16 Thread Eric Blake
On 04/16/2013 10:05 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > include/sysemu/sysemu.h | 2 +- > migration.c | 9 +++ > savevm.c| 64 > - > 3 files changed, 37 insertions(+), 38 deletions(-) >

Re: [Qemu-devel] [PATCH v2] tpm: Move TPM passthrough specific command line options to backend structure

2013-04-16 Thread Corey Bryant
On 04/12/2013 05:59 PM, Stefan Berger wrote: Move the TPM passthrough specific command line options to the passthrough backend implementation and attach them to the backend's interface structure. Add code to tpm.c for validating the TPM command line options. Signed-off-by: Stefan Berger ---

Re: [Qemu-devel] Is anyone rebasing the tcm_vhost QEMU patches?

2013-04-16 Thread Anthony Liguori
"Nicholas A. Bellinger" writes: > On Tue, 2013-04-16 at 13:45 -0500, Anthony Liguori wrote: >> I know there are a few different trees out there. Not sure if anyone is >> currently working on rebasing the earlier patch series. I had thought >> we were aiming for 1.5 but we're getting pretty late

Re: [Qemu-devel] [PATCH 6/6] qemu-file: do not use stdio for qemu_fdopen

2013-04-16 Thread Anthony Liguori
Paolo Bonzini writes: > This uses system calls directly for Unix file descriptors, so that the > efficient writev_buffer can be used. Pay attention to the possibility > of partial writes in writev. > > Signed-off-by: Paolo Bonzini Needs rebasing: CCi386-softmmu/savevm.o /home/aliguori/g

[Qemu-devel] [PATCH v2] tpm: Simplify creation of cancel path

2013-04-16 Thread Stefan Berger
Simplify the creation of the cancel path given the TPM's device path. Given the path /dev/tpm0 build the path /sys/class/misc/tpm0/device/cancel. Signed-off-by: Stefan Berger Reviewed-by: Eric Blake --- v1->v2: - followed changes in tree --- hw/tpm/tpm_passthrough.c | 74 ++---

Re: [Qemu-devel] Is anyone rebasing the tcm_vhost QEMU patches?

2013-04-16 Thread Nicholas A. Bellinger
On Tue, 2013-04-16 at 13:45 -0500, Anthony Liguori wrote: > I know there are a few different trees out there. Not sure if anyone is > currently working on rebasing the earlier patch series. I had thought > we were aiming for 1.5 but we're getting pretty late for that. > Hi Anthony, The branch

Re: [Qemu-devel] [RFC][PATCH 2 00/23] instrument: Let the user wrap/override specific event tracing routines

2013-04-16 Thread Lluís Vilanova
Please ignore this (incomplete) thread. Sorry for the inconvenience. Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth

Re: [Qemu-devel] [RFC][PATCH v2 00/23] instrument: Let the user wrap/override specific event tracing routines

2013-04-16 Thread Lluís Vilanova
Sorry Stefan; I had an error with stg and did not CC you. Just tell me if you want me to re-send with proper headers. Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as t

Re: [Qemu-devel] [PATCH 05/11] block: update error reporting for bdrv_snapshot_goto() and related functions

2013-04-16 Thread Eric Blake
On 04/16/2013 10:05 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > block.c | 55 > ++- > block/qcow2-snapshot.c| 32 +++ > block/qcow2.h | 8 +-- > block/rbd.c

Re: [Qemu-devel] [PATCH][RFC v2 3/7] vl: create power chip device

2013-04-16 Thread Anthony Liguori
Paolo Bonzini writes: > Il 10/04/2013 15:41, guang li ha scritto: >> Yes, you're right. >> The motivation is I want to implement a device >> called EC which is a notion from laptop for QEMU, >> EC has some main functions, like keyboard, mouse, >> low-speed device control(I2C), special ACPI space,

Re: [Qemu-devel] [PATCH 16/16] add cpu-add qmp command and implement CPU hot-add for target-i386

2013-04-16 Thread Igor Mammedov
On Mon, 15 Apr 2013 16:20:15 -0600 Eric Blake wrote: > On 04/15/2013 04:12 PM, Igor Mammedov wrote: > > ... via current_machine->cpu_hot_add() hook called by cpu-set QMP command, > > for x86 target. > > > > cpu-add's "id" argument is a CPU thread number in a range [0..max-cpus - 1) > > Off by o

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-04-16 Thread C Cormier
Can you clarify what's not 100% reproducible? The only time that it is not reproducible on my system is between different qemu machine types as I listed. If tests are performed on same machine-type they are reproducible 100% of the time on the same host and vm guest as shown in comment #23. I hav

Re: [Qemu-devel] [PATCH 04/11] qapi: Convert delvm

2013-04-16 Thread Eric Blake
On 04/16/2013 10:05 AM, Pavel Hrdina wrote: > QMP command vm-snapshot-delete no takes two parameters name and id. They are s/no// s/parameters/parameters:/ > optional, but one of the name or id must be provided. If both are provided > they > will match only the snapshot with the same name and id

[Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-16 Thread Sander Eikelenboom
Hi Stefano, When trying to start a hvm quest with xen-unstable and qemu-upstream, it ends up stuck: xc: info: VIRTUAL MEMORY ARRANGEMENT: Loader:0010->0019c864 Modules: -> TOTAL: ->2f80

[Qemu-devel] [PATCH qom-cpu 5/5] target-i386: Replace cpuid_*features fields with a feature word array

2013-04-16 Thread Eduardo Habkost
This replaces the feature-bit fields on both X86CPU and x86_def_t structs with an array. With this, we will be able to simplify code that simply does the same operation on all feature words (e.g. kvm_check_features_against_host(), filter_features_for_kvm(), add_flagname_to_bitmaps(), CPU feature-b

[Qemu-devel] [PATCH qom-cpu 4/5] bsd-user/elfload.c: Coding style fix

2013-04-16 Thread Eduardo Habkost
Trivial 4-space indentation fix. Signed-off-by: Eduardo Habkost --- Sending this so Andreas doesn't have to fix the indentation himself before applying. bsd-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index a6cd3ab..

Re: [Qemu-devel] [PATCH qom-cpu 0/4] replace cpuid_*features fields with a featue word array (v9)

2013-04-16 Thread Igor Mammedov
On Tue, 16 Apr 2013 13:12:00 -0300 Eduardo Habkost wrote: > Changes v9: > * Merge patches 1,3 from v8 into a single patch (1/4) > * Merge pathces 4-6 from v8 into a single patch (3/4) > * 1-char alignment change on patch 2/4 > * Improved description text of patch 4/4 > > Except for the 1-cha

Re: [Qemu-devel] [PATCH qom-cpu 4/4] target-i386: Replace cpuid_*features fields with a feature word array

2013-04-16 Thread Igor Mammedov
On Tue, 16 Apr 2013 13:12:04 -0300 Eduardo Habkost wrote: > This replaces the feature-bit fields on both X86CPU and x86_def_t > structs with an array. > > With this, we will be able to simplify code that simply does the same > operation on all feature words (e.g. kvm_check_features_against_host(

[Qemu-devel] Is anyone rebasing the tcm_vhost QEMU patches?

2013-04-16 Thread Anthony Liguori
I know there are a few different trees out there. Not sure if anyone is currently working on rebasing the earlier patch series. I had thought we were aiming for 1.5 but we're getting pretty late for that. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH qom-cpu 3/4] target-i386/cpu.c: Break lines so they don't get too long

2013-04-16 Thread Igor Mammedov
On Tue, 16 Apr 2013 13:12:03 -0300 Eduardo Habkost wrote: > Break lines on kvm_check_features_against_host(), kvm_cpu_fill_host(), > and builtin_x86_defs, so they don't get too long once the *_features > fields are replaced by an array. > > Signed-off-by: Eduardo Habkost > --- > Changes v9: >

Re: [Qemu-devel] [PATCH] tpm: Simplify creation of cancel path

2013-04-16 Thread Anthony Liguori
Stefan Berger writes: > Simplify the creation of the cancel path given the TPM's device path. > Given the path /dev/tpm0 build the path /sys/class/misc/tpm0/device/cancel. > > Signed-off-by: Stefan Berger No longer applies. Had you sent with git-send-patch, git am --3way would have figured it

Re: [Qemu-devel] [PATCH 5/7] i440fx-test: add test to compare default register values

2013-04-16 Thread Anthony Liguori
Eric Blake writes: > On 04/16/2013 09:56 AM, Eric Blake wrote: >> On 04/16/2013 08:45 AM, Anthony Liguori wrote: >>> This test compares all of the default register values against the >>> spec. It turns out we deviate in quite a few places. These >>> places are really only visible to the BIOS th

Re: [Qemu-devel] [PATCH 0/3] target-arm: convert to VMState, fix bugs

2013-04-16 Thread Peter Maydell
Ping for review -- I plan to put these into a target-arm pullreq at the end of the week if nobody has any review comments. thanks -- PMM On 8 April 2013 15:43, Peter Maydell wrote: > This patch series converts target-arm to doing migration via > a VMState structure, and fixes some minor bugs in

Re: [Qemu-devel] [PATCH 03/11] savevm: update bdrv_snapshot_find() to find snapshot by id or name

2013-04-16 Thread Eric Blake
On 04/16/2013 10:05 AM, Pavel Hrdina wrote: > Finding snapshot by a name which could also be an id isn't best way > how to do it. There will be rewrite of savevm, loadvm and delvm to > improve the behavior of these commands. The savevm and loadvm will > have their own patch series. > > Now bdrv_sn

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-04-16 Thread Paolo Bonzini
The results of comment 23 suggest that the issue is not 100% reproducible. Can you please run the benchmark 3-4 times (presave/postrestore) and showall 4 results? One benchmark only, e.g. "simple read" will do. Also please try putting a big file on disk (something like "dd if=/dev/zero of=bigfile

Re: [Qemu-devel] [PATCH 02/11] block: update error reporting for bdrv_snapshot_delete() and related functions

2013-04-16 Thread Eric Blake
On 04/16/2013 10:05 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > block.c | 22 ++ > block/qcow2-snapshot.c| 21 +++-- > block/qcow2.h | 4 +++- > block/rbd.c | 11 --- > block/sheepdog.c

Re: [Qemu-devel] [PATCH 01/11] qemu-img: introduce qemu_img_handle_error()

2013-04-16 Thread Eric Blake
On 04/16/2013 10:05 AM, Pavel Hrdina wrote: > Later in the patch series we will use this function few times. s/few/a few/ > This will avoid of duplicating the code. s/of// > > Signed-off-by: Pavel Hrdina > --- > qemu-img.c | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletio

Re: [Qemu-devel] [PATCH 00/11] covert savevm, loadvm and delvm into qapi

2013-04-16 Thread Eric Blake
On 04/16/2013 10:05 AM, Pavel Hrdina wrote: s/covert/convert/ in the subject, if you send a v2 (but doesn't affect git, so depending on how review goes, you may get lucky :) > I'm sending patches for all commands in one patch series because the > savevm command depends on delvm command. > > This

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-04-16 Thread Serge Hallyn
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1100843 Title: Live Migration Causes Performance Issues Status in QEMU: New Status

Re: [Qemu-devel] SoC Idea: Xbox target

2013-04-16 Thread Niel van der Westhuizen
On 16 April 2013 18:27, Stefan Hajnoczi wrote: > What is the current status of the xbox target and what would a 12-week > GSoC project accomplish? The scope of the project needs to be clearly > defined so this information is critical. > Currently it runs the bios to completion (which includes t

[Qemu-devel] [PATCH qom-cpu 0/4] replace cpuid_*features fields with a featue word array (v9)

2013-04-16 Thread Eduardo Habkost
Changes v9: * Merge patches 1,3 from v8 into a single patch (1/4) * Merge pathces 4-6 from v8 into a single patch (3/4) * 1-char alignment change on patch 2/4 * Improved description text of patch 4/4 Except for the 1-char alignment change on patch 2/4, the tree resulting from this version shou

[Qemu-devel] pointer to patch for [Bug 1169375] [NEW] qemu.git master -> qemu segfaults during tcp migration (and other modes when using MALLOC_PERTURB_=1)

2013-04-16 Thread Paolo Bonzini
Il 16/04/2013 03:10, Lucas Meneghel Rodrigues ha scritto: > Public bug reported: > > Relevant qemu.git master commit: > > 24a6e7f4d91e9ed5f8117ecb083431a23f8609a0 > > When trying to migrate a VM using the TCP protocol, a segfault happened: This fixes it in my tests (didn't get a segfault, but I

[Qemu-devel] [PATCH qom-cpu 4/4] target-i386: Replace cpuid_*features fields with a feature word array

2013-04-16 Thread Eduardo Habkost
This replaces the feature-bit fields on both X86CPU and x86_def_t structs with an array. With this, we will be able to simplify code that simply does the same operation on all feature words (e.g. kvm_check_features_against_host(), filter_features_for_kvm(), add_flagname_to_bitmaps(), CPU feature-b

[Qemu-devel] [PATCH qom-cpu 3/4] target-i386/cpu.c: Break lines so they don't get too long

2013-04-16 Thread Eduardo Habkost
Break lines on kvm_check_features_against_host(), kvm_cpu_fill_host(), and builtin_x86_defs, so they don't get too long once the *_features fields are replaced by an array. Signed-off-by: Eduardo Habkost --- Changes v9: * Merged all "Break lines" patches from previous series into a single pat

[Qemu-devel] [PATCH qom-cpu 2/4] target-i386/kvm.c: Code formatting changes

2013-04-16 Thread Eduardo Habkost
Add appropriate spaces around operators, and break line where it needs to be broken to allow feature-words array to be introduced without having too-long lines. Signed-off-by: Eduardo Habkost --- Changes v9: * 1-char alignment change: keep the opening parenthesis of both sides of the "==" ope

[Qemu-devel] [PATCH qom-cpu 1/4] target-i386: cleanup: Group together level, xlevel, xlevel2 fields

2013-04-16 Thread Eduardo Habkost
Consolidate level, xlevel, xlevel2 fields in x86_def_t and CPUX86State. Signed-off-by: Eduardo Habkost --- Changes v9: * Merged "target-i386: Move cpuid_xlevel, cpuid_xlevel2 fields in X86CPU" and "target-i386: Move xlevel/xlevel2 in struct x86_def_t" in a single patch --- target-i386/cpu

[Qemu-devel] [PATCH 10/11] qapi: Convert savevm

2013-04-16 Thread Pavel Hrdina
QMP command vm-snapshot-save now takes one parameter name and the name is mandatory. The command returns SnapshotInfo on success, otherwise it returns an error message. If there is a snapshot with the same name it also returns an error message and if you want to overwrite that snapshot, you will ha

[Qemu-devel] [PATCH 08/11] block: update error reporting for bdrv_snapshot_create() and related functions

2013-04-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- block.c | 23 ++- block/qcow2-snapshot.c| 18 -- block/qcow2.h | 4 +++- block/rbd.c | 20 +++- block/sheepdog.c | 22 +++--- include/bloc

[Qemu-devel] [PATCH 06/11] savevm: update error reporting for qemu_loadvm_state()

2013-04-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- include/sysemu/sysemu.h | 2 +- migration.c | 9 +++ savevm.c| 64 - 3 files changed, 37 insertions(+), 38 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.

[Qemu-devel] [PATCH 05/11] block: update error reporting for bdrv_snapshot_goto() and related functions

2013-04-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- block.c | 55 ++- block/qcow2-snapshot.c| 32 +++ block/qcow2.h | 8 +-- block/rbd.c | 19 +++- block/sheepdog.c | 33

[Qemu-devel] [PATCH 09/11] savevm: update error reporting off qemu_savevm_state() and related functions

2013-04-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- include/sysemu/sysemu.h | 7 --- migration.c | 6 +++--- savevm.c| 38 +++--- 3 files changed, 26 insertions(+), 25 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index

[Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find()

2013-04-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- savevm.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/savevm.c b/savevm.c index 66753da..bc829a5 100644 --- a/savevm.c +++ b/savevm.c @@ -2195,7 +2195,7 @@ out: } static int bdrv_snapshot_find(BlockDri

[Qemu-devel] [PATCH 07/11] qapi: Convert loadvm

2013-04-16 Thread Pavel Hrdina
QMP command vm-snapshot-load and HMP command loadvm behave similar to vm-snapshot-delete and delvm. The only different is that they will load the snapshot instead of deleting it. Signed-off-by: Pavel Hrdina --- hmp-commands.hx | 16 +- hmp.c | 35 +++

[Qemu-devel] [PATCH 01/11] qemu-img: introduce qemu_img_handle_error()

2013-04-16 Thread Pavel Hrdina
Later in the patch series we will use this function few times. This will avoid of duplicating the code. Signed-off-by: Pavel Hrdina --- qemu-img.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 31627b0..dbacdb7 100644 --- a/qe

[Qemu-devel] [PATCH 04/11] qapi: Convert delvm

2013-04-16 Thread Pavel Hrdina
QMP command vm-snapshot-delete no takes two parameters name and id. They are optional, but one of the name or id must be provided. If both are provided they will match only the snapshot with the same name and id. The command returns SnapshotInfo only if the snapshot exists, if snapshot doesn't exis

[Qemu-devel] [PATCH 02/11] block: update error reporting for bdrv_snapshot_delete() and related functions

2013-04-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- block.c | 22 ++ block/qcow2-snapshot.c| 21 +++-- block/qcow2.h | 4 +++- block/rbd.c | 11 --- block/sheepdog.c | 6 -- include/block/block.h | 4 +++-

[Qemu-devel] [PATCH 03/11] savevm: update bdrv_snapshot_find() to find snapshot by id or name

2013-04-16 Thread Pavel Hrdina
Finding snapshot by a name which could also be an id isn't best way how to do it. There will be rewrite of savevm, loadvm and delvm to improve the behavior of these commands. The savevm and loadvm will have their own patch series. Now bdrv_snapshot_find takes more parameters. The name parameter wi

[Qemu-devel] [PATCH 00/11] covert savevm, loadvm and delvm into qapi

2013-04-16 Thread Pavel Hrdina
I'm sending patches for all commands in one patch series because the savevm command depends on delvm command. This patch series introduces new design of these commands: * QMP vm-snapshot-save: - { 'command': 'vm-snapshot-save', 'data': { 'name': 'str' }, 'returns': 'SnapshotIn

Re: [Qemu-devel] [PATCH 5/7] i440fx-test: add test to compare default register values

2013-04-16 Thread Eric Blake
On 04/16/2013 09:56 AM, Eric Blake wrote: > On 04/16/2013 08:45 AM, Anthony Liguori wrote: >> This test compares all of the default register values against the >> spec. It turns out we deviate in quite a few places. These >> places are really only visible to the BIOS though which is why >> this h

Re: [Qemu-devel] [PATCH 5/7] i440fx-test: add test to compare default register values

2013-04-16 Thread Eric Blake
On 04/16/2013 08:45 AM, Anthony Liguori wrote: > This test compares all of the default register values against the > spec. It turns out we deviate in quite a few places. These > places are really only visible to the BIOS though which is why > this hasn't created any problems. > > The deviation a

Re: [Qemu-devel] [qom-cpu PATCH 0/7] replace cpuid_*features fields with a featue word array (v8)

2013-04-16 Thread Eduardo Habkost
FYI: I will send v9 fixing the issues pointed by Igor, soon. The only difference in the resulting tree should be the indentation issue on patch 2, all the rest will be just patch merging and commit message changes. -- Eduardo

Re: [Qemu-devel] [qom-cpu PATCH 7/7] target-i386: Replace cpuid_*features fields with a feature word array

2013-04-16 Thread Igor Mammedov
On Mon, 15 Apr 2013 16:25:40 -0300 Eduardo Habkost wrote: > This replaces the feature-bit fields on both X86CPU and x86_def_t > structs with an array. > > With this, we will be able to simplify code that simply does the same > operation on all feature words (e.g. kvm_check_features_against_host(

Re: [Qemu-devel] [qom-cpu PATCH 4/7] target-i386/cpu.c: Break lines on kvm_cpu_fill_host()

2013-04-16 Thread Eduardo Habkost
On Tue, Apr 16, 2013 at 05:18:08PM +0200, Igor Mammedov wrote: > On Mon, 15 Apr 2013 16:25:37 -0300 > Eduardo Habkost wrote: > > > Break lines so they don't get too long once the *_features fields are > > replaced by an array. > > > > Signed-off-by: Eduardo Habkost > > --- > > target-i386/cpu.

Re: [Qemu-devel] [PULL 0/8] rdma: migration support

2013-04-16 Thread Anthony Liguori
Paolo Bonzini writes: > Il 16/04/2013 16:32, Anthony Liguori ha scritto: >> Paolo Bonzini writes: >> >>> Il 16/04/2013 04:44, mrhi...@linux.vnet.ibm.com ha scritto: From: "Michael R. Hines" The following changes since commit 24a6e7f4d91e9ed5f8117ecb083431a23f8609a0: >

Re: [Qemu-devel] [PATCH 0/6] migration: followups for writev patches

2013-04-16 Thread Anthony Liguori
Orit Wasserman writes: > On 03/27/2013 06:36 PM, Paolo Bonzini wrote: >> This series fixes a few small problems in Orit's writev patches: >> >> 1) socket_put_buffer is not needed anymore and can be dropped (patch 1); >> >> 2) sendmsg could do a partial write even for a blocking socket, in >> ca

Re: [Qemu-devel] [PATCH V2 5/5] block: make all steps in qmp_transaction() as callback

2013-04-16 Thread Eric Blake
On 04/13/2013 05:11 AM, Wenchao Xia wrote: > Now qmp_transaction() can be extended with other operation, > external snapshot or backing chain creation, is just one case it. This read a bit awkwardly. Might I suggest: block: use callbacks in qmp_transaction() Make it easier to add other operat

Re: [Qemu-devel] USB2.0 disk format failure in windows guest

2013-04-16 Thread Gerd Hoffmann
Hi, > Fixing this will require qemu to copy the beginning and ending parts of > these non-aligned qTDs into separate bounce buffers so that the URB > length can be divisible by 512. Worth trying: http://www.kraxel.org/cgit/qemu/log/?h=usb.80 It puts the qemu usb passthrough code upside down.

Re: [Qemu-devel] [PATCH V2 4/5] block: package rolling back code in qmp_transaction()

2013-04-16 Thread Eric Blake
On 04/13/2013 05:11 AM, Wenchao Xia wrote: In the subject: s/rolling back/rollback/ > Signed-off-by: Wenchao Xia > --- > blockdev.c | 12 +--- > 1 files changed, 9 insertions(+), 3 deletions(-) With the subject fix, feel free to add: Reviewed-by: Eric Blake -- Eric Blake eblake

Re: [Qemu-devel] [PATCH V2 3/5] block: package committing code in qmp_transaction()

2013-04-16 Thread Eric Blake
On 04/13/2013 05:11 AM, Wenchao Xia wrote: > The code is simply moved into a separate function. > > Signed-off-by: Wenchao Xia > --- > blockdev.c | 20 +--- > 1 files changed, 13 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1

Re: [Qemu-devel] USB2.0 disk format failure in windows guest

2013-04-16 Thread Alan Stern
On Tue, 16 Apr 2013, Gonglei (Arei) wrote: > > > Yes, this disk was using EHCI, since guest QEMU and Linux kernel both > > > prints matching EHCI logs, such as transfer types and transfer sizes. > > > There are many buck-out URBs whose sizes are 31 or 4064 that are not > > > multiples of 512. Sinc

Re: [Qemu-devel] [qapi] Cannot use list of strings

2013-04-16 Thread mdroth
On Tue, Apr 16, 2013 at 10:49:19AM +0200, Stefan Hajnoczi wrote: > On Mon, Apr 15, 2013 at 10:04:24PM +0200, Lluís Vilanova wrote: > > Tried using a list of strings as an argument to a command, but the generated > > code references the 'strList' type, which does not exist. > > > > Is a specialized

Re: [Qemu-devel] [PATCH 1/1] rng random backend: check for -EAGAIN errors on read

2013-04-16 Thread Amit Shah
On (Tue) 16 Apr 2013 [15:51:30], Andreas Färber wrote: > Am 16.04.2013 12:28, schrieb Amit Shah: > > Not handling EAGAIN triggers the assert > > > > qemu/backends/rng-random.c:44:entropy_available: assertion failed: (len != > > -1) > > Aborted (core dumped) > > > > This happens when starting a g

Re: [Qemu-devel] [qom-cpu PATCH 4/7] target-i386/cpu.c: Break lines on kvm_cpu_fill_host()

2013-04-16 Thread Igor Mammedov
On Mon, 15 Apr 2013 16:25:37 -0300 Eduardo Habkost wrote: > Break lines so they don't get too long once the *_features fields are > replaced by an array. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a

Re: [Qemu-devel] [PATCH V2] ARM Cortex A9 Global Timer

2013-04-16 Thread Peter Crosthwaite
Hi Francois, On Wed, Apr 17, 2013 at 12:06 AM, François Legal wrote: > Hi Peter, > > Le 16-04-2013 15:23, Peter Crosthwaite a écrit : > > >> Hi Francois, >> >> On Tue, Apr 16, 2013 at 10:50 PM, François Legal >> wrote: >> >>> Le 16-04-2013 14:19, Peter Maydell a écrit : >>> On 16 April 2013

Re: [Qemu-devel] [PATCH V2 1/5] block: package preparation code in qmp_transaction()

2013-04-16 Thread Eric Blake
On 04/13/2013 05:11 AM, Wenchao Xia wrote: > The code before really committing is moved into a function. Most > code are simply moved from qmp_transaction()i, except fail handling s/i,/,/ > label is changed from "delete_and_fail" to "fail". Other code such > as input parsing is not touched, to

Re: [Qemu-devel] [PATCH V2 2/5] block: move input parsing code in qmp_transaction()

2013-04-16 Thread Eric Blake
On 04/13/2013 05:11 AM, Wenchao Xia wrote: > The code is moved into preparation function, and is changed > a bit to tip more clearly what it is doing. > > Signed-off-by: Wenchao Xia > --- > blockdev.c | 38 +++--- > 1 files changed, 19 insertions(+), 19 deleti

Re: [Qemu-devel] [PATCH v2 1/2] hw/sm501: Use correct setter for sysbus-ohci dma-address property

2013-04-16 Thread Aurelien Jarno
On Tue, Apr 09, 2013 at 12:27:52PM +0100, Peter Maydell wrote: > The sysbus-ohci dma-address property is declared as a HEX64 > property, not a TADDR, so use the correct setter for it. > > Signed-off-by: Peter Maydell > --- > hw/display/sm501.c |2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [Qemu-devel] [qom-cpu PATCH 3/7] target-i386: Move xlevel/xlevel2 in struct x86_def_t

2013-04-16 Thread Eduardo Habkost
On Tue, Apr 16, 2013 at 04:32:03PM +0200, Igor Mammedov wrote: > On Mon, 15 Apr 2013 16:25:36 -0300 > Eduardo Habkost wrote: > > > As the *_features fields are going to be replaced with a features array, > > the xlevel & xlevel2 fields won't be close to the corresponding > > *_features fields any

Re: [Qemu-devel] [PULL 0/8] rdma: migration support

2013-04-16 Thread Michael R. Hines
On 04/16/2013 10:32 AM, Anthony Liguori wrote: Paolo Bonzini writes: Il 16/04/2013 04:44, mrhi...@linux.vnet.ibm.com ha scritto: From: "Michael R. Hines" The following changes since commit 24a6e7f4d91e9ed5f8117ecb083431a23f8609a0: virtio-balloon: fix dynamic properties. (2013-04-15 17:0

Re: [Qemu-devel] [PATCH v2 1/2] hw/sm501: Use correct setter for sysbus-ohci dma-address property

2013-04-16 Thread Andreas Färber
Am 09.04.2013 13:27, schrieb Peter Maydell: > The sysbus-ohci dma-address property is declared as a HEX64 > property, not a TADDR, so use the correct setter for it. Actually, it's declared as DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 3), which is in turn defined as DEFINE_PROP

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix _filter_qemu

2013-04-16 Thread Stefan Hajnoczi
On Tue, Apr 16, 2013 at 03:52:14PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > [...] > > The problem with the POSIX shell string replacement is that the syntax > > is horrible. I can never remember what ${%}, ${%%}, ${#} and > > %{##} do. $(basename $QEMU_PROG) is clear (altho

Re: [Qemu-devel] [PATCH v2 1/2] hw/sm501: Use correct setter for sysbus-ohci dma-address property

2013-04-16 Thread Peter Maydell
On 16 April 2013 15:47, Andreas Färber wrote: > Am 09.04.2013 13:27, schrieb Peter Maydell: >> The sysbus-ohci dma-address property is declared as a HEX64 >> property, not a TADDR, so use the correct setter for it. > > Actually, it's declared as > DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState,

[Qemu-devel] [PATCH 4/7] libqos: add malloc support

2013-04-16 Thread Anthony Liguori
This is a very simple allocator for the PC platform. It should be possible to add backends for other platforms. Signed-off-by: Anthony Liguori --- tests/Makefile | 1 + tests/libqos/malloc-pc.c | 71 tests/libqos/malloc-pc.h | 20 +

[Qemu-devel] [PATCH 7/7] fw_cfg: add qtest test case

2013-04-16 Thread Anthony Liguori
This validates some basic characteristics of fw_cfg. Signed-off-by: Anthony Liguori --- tests/Makefile | 2 + tests/fw_cfg-test.c | 141 2 files changed, 143 insertions(+) create mode 100644 tests/fw_cfg-test.c diff --git a/tests/Make

Re: [Qemu-devel] [PULL 0/8] rdma: migration support

2013-04-16 Thread Anthony Liguori
Paolo Bonzini writes: > Il 16/04/2013 04:44, mrhi...@linux.vnet.ibm.com ha scritto: >> From: "Michael R. Hines" >> >> The following changes since commit 24a6e7f4d91e9ed5f8117ecb083431a23f8609a0: >> >> virtio-balloon: fix dynamic properties. (2013-04-15 17:06:58 -0500) >> >> are available in

[Qemu-devel] [PATCH 6/7] i440fx-test: add test for PAM functionality

2013-04-16 Thread Anthony Liguori
This tests PAM settings for the i440fx. This test does a lot of byte MMIO which is fairly slow with qtest today. But the test does complete in under 2 seconds. We don't fully emulate PAM largely because of limitations with KVM so we #if 0 that part of the test case. Signed-off-by: Anthony Liguo

  1   2   3   >