Re: [Qemu-devel] [PATCH-v2 0/2] Add support for vhost-scsi-pci

2013-03-28 Thread Asias He
On Thu, Mar 28, 2013 at 11:48:59PM -0700, Nicholas A. Bellinger wrote: > On Fri, 2013-03-29 at 14:39 +0800, Asias He wrote: > > On Fri, Mar 29, 2013 at 01:08:14AM +, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger > > > > > > Hi QEMU folks, > > > > > > The following is the patch-

Re: [Qemu-devel] [PATCH-v2 0/2] Add support for vhost-scsi-pci

2013-03-28 Thread Nicholas A. Bellinger
On Fri, 2013-03-29 at 14:39 +0800, Asias He wrote: > On Fri, Mar 29, 2013 at 01:08:14AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hi QEMU folks, > > > > The following is the patch-v2 series to support vhost-scsi-pci within > > the upstream QEMU tree. > > > > This

Re: [Qemu-devel] [PATCH-v2 0/2] Add support for vhost-scsi-pci

2013-03-28 Thread Asias He
On Fri, Mar 29, 2013 at 01:08:14AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi QEMU folks, > > The following is the patch-v2 series to support vhost-scsi-pci within > the upstream QEMU tree. > > This includes the refactoring of existing virtio-scsi code from Paolo > to

[Qemu-devel] [Bug 587344] Re: gfxmenu from GRUB or GRUB4DOS hang qemu.

2013-03-28 Thread xie
In addition, CPU is Intel E5520 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/587344 Title: gfxmenu from GRUB or GRUB4DOS hang qemu. Status in QEMU: Fix Released Bug description: When you run

[Qemu-devel] [PATCH] set usb bus name by busno.

2013-03-28 Thread qiaochong
So when we add several usb buses on system, we can add usb device on special usb bus by special usb bus name usb-bus.busno. Signed-off-by: qiaochong --- hw/usb/bus.c | 4 +++- 1 个文件被修改,插入 3 行(+),删除 1 行(-) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index e58cd9a..c31a17c 100644 --- a/hw/usb/bus.c

[Qemu-devel] [Bug 587344] Re: gfxmenu from GRUB or GRUB4DOS hang qemu.

2013-03-28 Thread xie
I think the problem is relate to the cpu arch. I have the same problem in my machine of which the cpu is Nehalem -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/587344 Title: gfxmenu from GRUB or GRU

Re: [Qemu-devel] [PATCH v2 0/7] md: add hot-plug and hot-unplug support

2013-03-28 Thread Liu Yuan
On 03/29/2013 01:42 PM, Liu Yuan wrote: > From: Liu Yuan > > v2: > - fix object stale purging for md > > This is the final part for MD. With this patch set, We even allow group plug, > group unplug and disks/node failure during (un)plugging. > > Also add disk information function for collie.

[Qemu-devel] [PATCH v2 7/7] tsets: add 057 to test md hot-plug and hot-unplug

2013-03-28 Thread Liu Yuan
From: Liu Yuan Signed-off-by: Liu Yuan --- tests/057 | 57 + tests/057.out | 55 +++ tests/group |1 + 3 files changed, 113 insertions(+) create mode 100755 tests/057 crea

[Qemu-devel] [PATCH v2 4/7] md: add hot-plug and hot-unplug support

2013-03-28 Thread Liu Yuan
From: Liu Yuan We allow group plug, group unplug and disks failure during (un)plugging. Also add disk information function for collie. Signed-off-by: Liu Yuan --- collie/collie.c |2 +- include/internal_proto.h | 16 +++ include/sheepdog_proto.h |2 + sheep/md.c

[Qemu-devel] [PATCH v2 6/7] sheep: remove duplicate recovery complete notification

2013-03-28 Thread Liu Yuan
From: Liu Yuan Signed-off-by: Liu Yuan --- sheep/ops.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/sheep/ops.c b/sheep/ops.c index 3839437..204befd 100644 --- a/sheep/ops.c +++ b/sheep/ops.c @@ -624,7 +624,19 @@ static int cluster_recovery_completion(con

[Qemu-devel] [PATCH v2 1/7] md: add support for simultaneous disk failure on the same node

2013-03-28 Thread Liu Yuan
From: Liu Yuan Don't panic out, instead we simply remove this disk for this nested disk failures. Signed-off-by: Liu Yuan --- sheep/md.c | 66 +++- 1 file changed, 48 insertions(+), 18 deletions(-) diff --git a/sheep/md.c b/sheep/md.c

[Qemu-devel] [PATCH v2 5/7] collie: add new commands to manipulate multi-disks

2013-03-28 Thread Liu Yuan
From: Liu Yuan Three command added: $ collie node md info # show information about md of {this node, all nodes} $ collie node md plug path1,{path2,...} # plug disk(s) into node $ collie node md unplug path1,{path2,...} # unplug disk(s) into node Signed-off-by: Liu Yuan --- collie/node.c |

[Qemu-devel] [PATCH v2 3/7] net: enlarge connect_to_addr() scope

2013-03-28 Thread Liu Yuan
From: Liu Yuan This is a prepare patch. Signed-off-by: Liu Yuan --- include/net.h|8 sheep/sockfd_cache.c |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/net.h b/include/net.h index a68c880..75ac197 100644 --- a/include/net.h +++ b/i

[Qemu-devel] [PATCH v2 2/7] tests/055: test simultaneous multiple disk failures on the same node

2013-03-28 Thread Liu Yuan
From: Liu Yuan Signed-off-by: Liu Yuan --- tests/055 |7 +++ tests/055.out |8 2 files changed, 15 insertions(+) diff --git a/tests/055 b/tests/055 index 4c3bfb9..6b99552 100755 --- a/tests/055 +++ b/tests/055 @@ -42,6 +42,13 @@ $COLLIE cluster info | _filter_cluster_i

[Qemu-devel] [PATCH v2 0/7] md: add hot-plug and hot-unplug support

2013-03-28 Thread Liu Yuan
From: Liu Yuan v2: - fix object stale purging for md This is the final part for MD. With this patch set, We even allow group plug, group unplug and disks/node failure during (un)plugging. Also add disk information function for collie. Liu Yuan (7): md: add support for simultaneous disk fai

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-28 Thread H. Peter Anvin
Qemu is absolutely horrid at modeling corner cases. Rob Landley wrote: >On 03/28/2013 03:12:11 PM, H. Peter Anvin wrote: >> On 03/28/2013 12:15 PM, Aurelien Jarno wrote: >> > >> > This really looks like Linux kernel specific. I haven't been able >to >> > test on a real machine, but the documenta

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-28 Thread Rob Landley
On 03/28/2013 03:12:11 PM, H. Peter Anvin wrote: On 03/28/2013 12:15 PM, Aurelien Jarno wrote: > > This really looks like Linux kernel specific. I haven't been able to > test on a real machine, but the documentation I have found suggest that > without and x87 FPU, the FPU instructions are simpl

[Qemu-devel] [PATCH 1/3] virtio: add API to check that ring is setup

2013-03-28 Thread Nicholas A. Bellinger
From: Michael S. Tsirkin virtio scsi makes it legal to only setup a subset of rings. The only way to detect the ring is setup seems to be to check whether PA was written to. Add API to do this, and teach code to use it instead of checking hardware queue size. (nab: use .vring.desc instead of .

[Qemu-devel] [PATCH 3/3] vhost: Check+skip uninitialized VQs in vhost_verify_ring_mappings

2013-03-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger With the virtio_queue_valid() checks in place to skip uninitialized VQs within virtio-pci code, go ahead and skip the same uninitialized VQs during vhost_verify_ring_mappings(). Note this patch does not prevent vhost_virtqueue_start() from executing by checking virtio_qu

[Qemu-devel] [PATCH 2/3] virtio-pci: Add virtio_queue_valid checks ahead of virtio_queue_get_num

2013-03-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a number of virtio_queue_valid() checks to virtio-pci ahead of virtio_queue_get_num() usage in order to skip operation upon the detection of an uninitialized VQ. There is one exception in virtio_ioport_read():VIRTIO_PCI_QUEUE_NUM, where virtio_queue_get_n

[Qemu-devel] [PATCH 0/3] virtio/vhost: Add checks for uninitialized VQs

2013-03-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, This series adds a virtio_queue_valid() for use by virtio-pci code in order to prevent opreations upon uninitialized VQs, that is currently expected to occur during seabios setup of virtio-scsi. This also includes a vhost specific check for uninitialized VQs i

[Qemu-devel] [PATCH uq/master v2 2/2] kvm-all: add kvm_run_exit tracepoint

2013-03-28 Thread Kazuya Saito
This patch enable us to know exit reason of KVM_RUN. It will help us know where the trouble is caused. Signed-off-by: Kazuya Saito --- kvm-all.c|1 + trace-events |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index fdb099c..325f5e7 100644

[Qemu-devel] [PATCH uq/master v2 1/2] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints

2013-03-28 Thread Kazuya Saito
This patch adds tracepoints at ioctl to kvm. Tracing these ioctl is useful for clarification whether the cause of troubles is qemu or kvm. Signed-off-by: Kazuya Saito --- kvm-all.c|4 trace-events |5 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/kvm-all.c

[Qemu-devel] [PATCH uq/master v2 0/2] Add some tracepoints for clarification of the cause of troubles

2013-03-28 Thread Kazuya Saito
This series adds tracepoints for helping us clarify the cause of troubles. Virtualization on Linux is composed of some components such as qemu, kvm, libvirt, and so on. So it is very important to clarify firstly and swiftly the cause of troubles is on what component of them. Although qemu has usefu

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-28 Thread Nicholas A. Bellinger
On Thu, 2013-03-28 at 11:04 +0200, Michael S. Tsirkin wrote: > On Thu, Mar 28, 2013 at 12:35:42AM -0700, Nicholas A. Bellinger wrote: > > On Wed, 2013-03-27 at 23:45 -0700, Nicholas A. Bellinger wrote: > > > On Wed, 2013-03-27 at 15:33 -0700, Nicholas A. Bellinger wrote: > > > > On Wed, 2013-03-27

Re: [Qemu-devel] [RFC PATCH v1 0/7] Reset and Halting modifications + Zynq SMP

2013-03-28 Thread Edgar E. Iglesias
Hi On Mon, Mar 04, 2013 at 10:57:49PM +1000, Peter Crosthwaite wrote: > Hi Andreas, > > On Mon, Mar 4, 2013 at 10:03 PM, Andreas Färber wrote: > > Hi Peter, > > > > Am 04.03.2013 10:01, schrieb Peter Crosthwaite: > >> Hi All. The clock controller module in the Zynq platform has the ability > >>

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-28 Thread Nicholas A. Bellinger
On Thu, 2013-03-28 at 06:13 -0400, Paolo Bonzini wrote: > > I think it's the right thing to do, but maybe not the right place > > to do this, need to reset after all IO is done, before > > ring memory is write protected. > > Our emails are crossing each other unfortunately, but I want to > reinfor

Re: [Qemu-devel] [PATCH V10 17/17] hmp: add parameter device and -b for info block

2013-03-28 Thread Wenchao Xia
于 2013-3-28 19:09, Kevin Wolf 写道: Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben: With these parameters, user can choose the information to be showed, to avoid message flood in the montior. Signed-off-by: Wenchao Xia Aha, so here you actually introduce the 'device' parameter. If you c

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-28 Thread Nicholas A. Bellinger
On Thu, 2013-03-28 at 11:03 +0100, Paolo Bonzini wrote: > Il 28/03/2013 10:04, Michael S. Tsirkin ha scritto: > >>> > > Got ranges_overlap for vq: 0 ring_phys: 0 ring_size: 1028 > >>> > > Checking vq: 1 ring_phys: 0 ring_size: 1028 >>. > >>> > > Got ranges_overlap for vq: 1 ring_phy

Re: [Qemu-devel] [PATCH V10 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block

2013-03-28 Thread Wenchao Xia
于 2013-3-28 17:54, Kevin Wolf 写道: Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben: Now image info will be retrieved as an embbed json object inside BlockDeviceInfo, backing chain info and all related internal snapshot info can be got in the enhanced recursive structure of ImageInfo. Signe

Re: [Qemu-devel] [RFC PATCH 1/8] qtest: add libqos

2013-03-28 Thread Anthony Liguori
Kevin Wolf writes: > Am 13.03.2013 um 15:03 hat Anthony Liguori geschrieben: >> You are correct, it should look something like: >> >> if (addr & PCI_BASE_ADDRESS_SPACE_IO) { >> size = (1ULL << ctzl(addr & PCI_BASE_ADDRESS_IO_MASK)); >> } else { >> size = (1ULL << ctzl(addr & PCI_BASE_ADD

[Qemu-devel] [PATCH-v2 2/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-28 Thread Nicholas A. Bellinger
From: Paolo Bonzini The WWPN specified in configfs is passed to "-device vhost-scsi-pci". The tgpt field of the SET_ENDPOINT ioctl is obsolete now, so it is not available from the QEMU command-line. Instead, I hardcode it to zero. Changes in Patch-v2: - Add vhost_scsi_get_features() in order

[Qemu-devel] [PATCH-v2 1/2] virtio-scsi: create VirtIOSCSICommon

2013-03-28 Thread Nicholas A. Bellinger
From: Paolo Bonzini This patch refactors existing virtio-scsi code into VirtIOSCSICommon in order to allow virtio_scsi_init_common() to be used by both internal virtio_scsi_init() and external vhost-scsi-pci code. Changes in Patch-v2: - Move ->get_features() assignment to virtio_scsi_init() i

[Qemu-devel] [PATCH-v2 0/2] Add support for vhost-scsi-pci

2013-03-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi QEMU folks, The following is the patch-v2 series to support vhost-scsi-pci within the upstream QEMU tree. This includes the refactoring of existing virtio-scsi code from Paolo to allow a VirtIOSCSICommon structure that is shared amoungst existing virtio-scsi-pci devi

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/i386/pc: reject to boot a wrong header magic kernel

2013-03-28 Thread li guang
在 2013-03-28四的 10:42 +0100,Stefan Hajnoczi写道: > On Wed, Mar 27, 2013 at 02:10:31PM +0800, liguang wrote: > > if head magic is missing or wrong unexpectedly, we'd > > better to reject booting. > > e.g. > > I make a mistake to boot a vmlinuz for MIPS(which > > I think it's for x86) like this: > > qem

Re: [Qemu-devel] [PATCH v9 10/24] hw/arm: add FTDMAC020 AHB DMA support

2013-03-28 Thread Peter Crosthwaite
Hi Kuo-Jung, On Mon, Mar 25, 2013 at 10:09 PM, Kuo-Jung Su wrote: > From: Kuo-Jung Su > > The Faraday FTDMAC020 provides eight configurable > channels for the memory-to-memory, memory-to-peripheral, > peripheral-to-peripheral, and peripheral-to-memory transfers. > > Each DMA channel supports cha

Re: [Qemu-devel] [PATCH v9 24/24] hw/arm: add FTSPI020 SPI flash controller support

2013-03-28 Thread Peter Crosthwaite
Hi Kuo-Jung, On Mon, Mar 25, 2013 at 10:10 PM, Kuo-Jung Su wrote: > From: Kuo-Jung Su > > The FTSPI020 is an integrated SPI Flash controller > which supports up to 4 flash chips. > > Signed-off-by: Kuo-Jung Su > --- > hw/arm/Makefile.objs |2 +- > hw/arm/ftplat_a369.c | 16 +++ > hw/ftsp

Re: [Qemu-devel] [PATCH v2 3/3] target-i386: add AES-NI instructions

2013-03-28 Thread Edgar E. Iglesias
On Fri, Mar 29, 2013 at 12:36:29AM +0100, Aurelien Jarno wrote: > Signed-off-by: Aurelien Jarno Hi Aurelien, Nice patches! A question - The sbox tables are already available but in a different format in util/aes.c. Would it make sense to reuse (see Te4 and Td4) ? Cheers, Edgar > --- > targe

Re: [Qemu-devel] [PATCH] Make guest OS bootable when hardware failure happens in log disk

2013-03-28 Thread Paolo Bonzini
Il 28/03/2013 20:43, Seiji Aguchi ha scritto: > [Problem] > Currently, guest OS's messages can be logged to a local disk of host OS by > creating chadevs with options below. > -chardev file,id=charserial0,path= -device > isa-serial,chardev=chardevserial0,id=serial0 > > When a hardware failure

Re: [Qemu-devel] [RFC PATCH 3/3] rbd: remove aio handler when no requests are pending

2013-03-28 Thread Paolo Bonzini
Il 28/03/2013 22:52, Anthony Liguori ha scritto: > This allows us to pass NULL for io_flush by removing the aio > event when no requests are pending. > > Signed-off-by: Anthony Liguori > --- > block/rbd.c | 25 - > 1 file changed, 16 insertions(+), 9 deletions(-) I'm not

Re: [Qemu-devel] [RFC PATCH 2/3] sheepdog: pass NULL for io_flush

2013-03-28 Thread Paolo Bonzini
Il 28/03/2013 22:52, Anthony Liguori ha scritto: > Signed-off-by: Anthony Liguori > --- > block/sheepdog.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/block/sheepdog.c b/block/sheepdog.c > index bb67c4c..2bccd9b 100644 > --- a/block/sheepdog.c > +++ b/blo

Re: [Qemu-devel] [RFC PATCH 1/3] aio-context: if io_flush isn't provided, assume "always busy"

2013-03-28 Thread Paolo Bonzini
Il 28/03/2013 22:52, Anthony Liguori ha scritto: > Today, all callers of qemu_aio_set_fd_handler() pass a valid io_flush > function. Except one: aio_set_event_notifier(ctx, &ctx->notifier, (EventNotifierHandler *) event_notifier_test_and_c

[Qemu-devel] [PATCH v2 2/3] target-i386: enable PCLMULQDQ on Westmere CPU

2013-03-28 Thread Aurelien Jarno
The PCLMULQDQ instruction has been introduced on the Westmere CPU. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target-i386/cpu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 41382c5..5941d40 100644 --- a/

[Qemu-devel] [PATCH v2 3/3] target-i386: add AES-NI instructions

2013-03-28 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-i386/cpu.c|6 +- target-i386/ops_sse.h| 188 ++ target-i386/ops_sse_header.h |6 ++ target-i386/translate.c |7 ++ 4 files changed, 204 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 1/3] target-i386: add pclmulqdq instruction

2013-03-28 Thread Aurelien Jarno
Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target-i386/cpu.c| 19 +-- target-i386/ops_sse.h| 24 target-i386/ops_sse_header.h |5 + target-i386/translate.c |3 +++ 4 files changed, 41 insertio

[Qemu-devel] [PATCH v2 0/3] target-i386: add PCLMULQDQ and AES-NI instructions

2013-03-28 Thread Aurelien Jarno
This patch series adds the PCLMULQDQ and AES-NI instructions to the x86 emulation. Along with the SSE4.1 and SSE4.2 series, this brings the instructions emulation to the level of a Westmere CPU. It has been tested with the valgrind testsuite and with the kernel autotest. Changes v1 -> v2: - Patch

Re: [Qemu-devel] [PATCH v3 11/11] savevm: add force parameter to HMP command and return snapshot info

2013-03-28 Thread Eric Blake
On 03/28/2013 10:47 AM, Pavel Hrdina wrote: > HMP command "savevm" now takes extra optional force parameter to specify > whether replace existing snapshot or not. It also returns information > about created snapshot. > > Signed-off-by: Pavel Hrdina > --- > hmp-commands.hx | 16 >

Re: [Qemu-devel] [PATCH v3 10/11] savevm: update return value from qemu_savevm_state

2013-03-28 Thread Eric Blake
On 03/28/2013 10:47 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > savevm.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org sign

Re: [Qemu-devel] [PATCH v3 08/11] qemu-img: introduce qemu_img_handle_error

2013-03-28 Thread Eric Blake
On 03/28/2013 03:42 PM, Eric Blake wrote: > On 03/28/2013 10:47 AM, Pavel Hrdina wrote: >> Signed-off-by: Pavel Hrdina >> --- >> qemu-img.c | 18 -- >> 1 file changed, 12 insertions(+), 6 deletions(-) > > Reviewed-by: Eric Blake > >> +static int qemu_img_handle_error(Error *err

Re: [Qemu-devel] [PATCH v3 09/11] block: update return value from bdrv_snapshot_create

2013-03-28 Thread Eric Blake
On 03/28/2013 10:47 AM, Pavel Hrdina wrote: > If we provide error message we don't have to also provide return > value because we could check if there is any error message or not. > > Signed-off-by: Pavel Hrdina > --- > block.c | 24 ++-- > block/qcow2-snaps

[Qemu-devel] [RFC PATCH 3/3] rbd: remove aio handler when no requests are pending

2013-03-28 Thread Anthony Liguori
This allows us to pass NULL for io_flush by removing the aio event when no requests are pending. Signed-off-by: Anthony Liguori --- block/rbd.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 1a8ea6d..a7c3645 100644 -

[Qemu-devel] [RFC PATCH 2/3] sheepdog: pass NULL for io_flush

2013-03-28 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- block/sheepdog.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index bb67c4c..2bccd9b 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -503,13 +503,6 @@ static void restart_co_req(void

[Qemu-devel] [RFC PATCH 1/3] aio-context: if io_flush isn't provided, assume "always busy"

2013-03-28 Thread Anthony Liguori
Today, all callers of qemu_aio_set_fd_handler() pass a valid io_flush function. However, the function allows the handler to be omitted and the behavior is a bit strange. It will still add the file descriptor to the GSource but it will not consider the source to be "busy". This could lead to aio_

[Qemu-devel] [RFC PATCH 0/3] aio-context start to eliminate io_flush

2013-03-28 Thread Anthony Liguori
Mike and I spent some time talking about how to move forward with AioContext vs. glib. I think the best proposal so far is to add a common API on top of the *aio* interfaces and the existing qemu_set_fd_handler main loop functions. Then we get code sharing while still having multiple main loop im

Re: [Qemu-devel] [PATCH v3 08/11] qemu-img: introduce qemu_img_handle_error

2013-03-28 Thread Eric Blake
On 03/28/2013 10:47 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > qemu-img.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake > +static int qemu_img_handle_error(Error *err) > +{ > +if (error_is_set(&err)) { > +erro

Re: [Qemu-devel] [PATCH v3 07/11] qapi: Convert savevm

2013-03-28 Thread Eric Blake
On 03/28/2013 10:47 AM, Pavel Hrdina wrote: > QMP command "vm-snapshot-save" has also extra optional force parameter > and name parameter isn't optional anymore. It also returns information > about created snapshot. Commit message is a bit stale from an earlier version of the series, since name is

Re: [Qemu-devel] [PATCH v3 01/11] block: add error parameter to bdrv_snapshot_create() and related functions

2013-03-28 Thread Eric Blake
On 03/28/2013 10:47 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > block.c | 22 -- > block/qcow2-snapshot.c| 9 - > block/qcow2.h | 4 +++- > block/rbd.c | 8 ++-- > block/sheepdog.c | 17 +

Re: [Qemu-devel] [PATCH v3 14/20] tcg-arm: Cleanup goto_tb handling

2013-03-28 Thread Richard Henderson
On 2013-03-28 13:09, Aurelien Jarno wrote: I already proposed such a patch, but it seems to improve things only on some specific cases (kernel boot), while increasing the I/D cache and TLB pressure. See https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg01684.html Hmm. I see that your p

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-28 Thread H. Peter Anvin
On 03/28/2013 12:15 PM, Aurelien Jarno wrote: > > This really looks like Linux kernel specific. I haven't been able to > test on a real machine, but the documentation I have found suggest that > without and x87 FPU, the FPU instructions are simply ignored. The common > way to detect an FPU is ther

Re: [Qemu-devel] [PATCH v3 14/20] tcg-arm: Cleanup goto_tb handling

2013-03-28 Thread Aurelien Jarno
On Thu, Mar 28, 2013 at 08:32:55AM -0700, Richard Henderson wrote: > Eliminate 2 disabled code blocks. Choose the load-to-pc method of > jumping so that we can eliminate the 16M code_gen_buffer limitation. > Remove a test in the indirect jump method that is always true. > > Signed-off-by: Richard

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-28 Thread H. Peter Anvin
On 03/28/2013 12:15 PM, Aurelien Jarno wrote: > > This really looks like Linux kernel specific. I haven't been able to > test on a real machine, but the documentation I have found suggest that > without and x87 FPU, the FPU instructions are simply ignored. The common > way to detect an FPU is ther

[Qemu-devel] [PATCH] Make guest OS bootable when hardware failure happens in log disk

2013-03-28 Thread Seiji Aguchi
[Problem] Currently, guest OS's messages can be logged to a local disk of host OS by creating chadevs with options below. -chardev file,id=charserial0,path= -device isa-serial,chardev=chardevserial0,id=serial0 When a hardware failure happens in the disk, qemu-kvm can't create the chardevs. In

Re: [Qemu-devel] OpenBios in Sparc can't handle long kernel command lines.

2013-03-28 Thread Mark Cave-Ayland
On 22/03/13 05:19, Rob Landley wrote: If I do this: qemu-system-sparc -nographic -no-reboot -kernel image -hda hda.sqf -append 'root=/dev/sda rw init=/sbin/init.sh panic=1 PATH=/usr/distcc:/bin:/sbin console=ttyS0 HOST=sparc CPUS=1 DISTCC_HOSTS=10.0.2.2:31322/1 FTP_SERVER=10.0.2.2 FTP_PORT=3130

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-28 Thread Aurelien Jarno
On Wed, Feb 27, 2013 at 06:12:32PM -0800, H. Peter Anvin wrote: > From: "H. Peter Anvin" > > Add models for 486SX, and pre-CPUID versions of the 486 (DX & SX). > Change the model number for the standard 486DX to a model which > actually had CPUID. > > Note: these models are fairly vestigial, for

Re: [Qemu-devel] [RFC PATCH 2/3] target-i386: Raise #UD on accessing non-existent control registers

2013-03-28 Thread Aurelien Jarno
On Wed, Feb 27, 2013 at 06:12:33PM -0800, H. Peter Anvin wrote: > From: "H. Peter Anvin" > > If we touch control registers that don't exist, either read or write, > raise the #UD exception (undefined opcode). > > This is useful for testing booting on old CPUs. > > CR4 is assumed to exist if and

Re: [Qemu-devel] [PATCH] target-moxie: Fix pointer-to-integer conversion (MinGW-w64)

2013-03-28 Thread Anthony Green
Hi Stefan, This change is fine by me. It's not clear to me, as the author/maintainer of the moxie port, what my responsibility/authority is. Do I simply reply to patches like this with... Looks good to me. Signed-off-by: Anthony Green And then somebody commits it to the tree? Thanks! AG O

Re: [Qemu-devel] [PATCH] hw/milkymist-softusb: set buffer in softusb_read_{dmem, pmem} error path

2013-03-28 Thread Michael Walle
Am Donnerstag 28 März 2013, 19:43:04 schrieb Peter Maydell: > Make sure we set the buffer to something in the softusb_read_{dmem,pmem} > error paths, since the caller will use the buffer unconditionally. > (Newer gcc is smart enough to spot this and complain about 'may be > used uninitialized'.) >

[Qemu-devel] [PATCH] hw/milkymist-softusb: set buffer in softusb_read_{dmem, pmem} error path

2013-03-28 Thread Peter Maydell
Make sure we set the buffer to something in the softusb_read_{dmem,pmem} error paths, since the caller will use the buffer unconditionally. (Newer gcc is smart enough to spot this and complain about 'may be used uninitialized'.) Signed-off-by: Peter Maydell --- This needs to be applied before the

Re: [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM memory regions in the device itself

2013-03-28 Thread Michael Walle
Am Donnerstag 28 März 2013, 19:33:48 schrieb Peter Maydell: > On 28 March 2013 18:31, Michael Walle wrote: > > Am Donnerstag 28 März 2013, 18:55:59 schrieb Anthony Liguori:cc> > > > >> Breaks the build: > >> > >> [aliguori@ccnode4 qemu]$ make > >> > >> CClm32-softmmu/hw/lm32/../milkymist-

[Qemu-devel] [PATCH] spice-qemu-char: vmc_write: Don't write more bytes then we're asked too

2013-03-28 Thread Hans de Goede
This one took me eons to debug, but I've finally found it now, oh well. The usage of the MIN macro in this line: last_out = MIN(len, qemu_chr_be_can_write(scd->chr)); Causes qemu_chr_be_can_write to be called *twice*, since the MIN macro evaluates its arguments twice (bad MIN macro, bad!). An

Re: [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM memory regions in the device itself

2013-03-28 Thread Peter Maydell
On 28 March 2013 18:31, Michael Walle wrote: > Am Donnerstag 28 März 2013, 18:55:59 schrieb Anthony Liguori:cc> >> >> Breaks the build: >> >> [aliguori@ccnode4 qemu]$ make >> CClm32-softmmu/hw/lm32/../milkymist-softusb.o >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c: In function

Re: [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM memory regions in the device itself

2013-03-28 Thread Michael Walle
Am Donnerstag 28 März 2013, 18:55:59 schrieb Anthony Liguori: > Peter Maydell writes: > > Don't map the pmem and dmem RAM memory regions in the milkymist-softusb > > device itself. Instead just expose them as sysbus mmio regions which > > the device creator can map appropriately. This allows us to

Re: [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM memory regions in the device itself

2013-03-28 Thread Anthony Liguori
Peter Maydell writes: > Don't map the pmem and dmem RAM memory regions in the milkymist-softusb > device itself. Instead just expose them as sysbus mmio regions which > the device creator can map appropriately. This allows us to drop the > pmem_base and dmem_base properties. Instead of going via

Re: [Qemu-devel] [RFC PATCH v2 0/4] port network layer onto glib

2013-03-28 Thread mdroth
On Thu, Mar 28, 2013 at 03:55:52PM +0100, Stefan Hajnoczi wrote: > On Thu, Mar 28, 2013 at 03:55:51PM +0800, Liu Ping Fan wrote: > > From: Liu Ping Fan > > > > These series aim to make the whole network re-entrant, here only apply > > backend and frontend, > > and for the netcore, separated patc

Re: [Qemu-devel] [PATCH v3 20/20] tcg-arm: Convert to CONFIG_QEMU_LDST_OPTIMIZATION

2013-03-28 Thread Richard Henderson
On 03/28/2013 09:44 AM, Peter Maydell wrote: >> +/* Prior to that the assembler uses mov r0, r0. Unlike the nop >> + above, this is guaranteed to consume execution resources. */ > > Guaranteed by who? Catching this case in the decoder and treating it > exactly like NOP is a per

Re: [Qemu-devel] vNVRAM / blobstore design

2013-03-28 Thread Michael S. Tsirkin
On Thu, Mar 28, 2013 at 12:27:45PM -0500, Anthony Liguori wrote: > Stefan Berger writes: > > > On 03/27/2013 03:12 PM, Stefan Berger wrote: > >> On 03/27/2013 02:27 PM, Anthony Liguori wrote: > >>> Stefan Berger writes: > >>> > On 03/27/2013 01:14 PM, Anthony Liguori wrote: > > Stefan B

Re: [Qemu-devel] vNVRAM / blobstore design

2013-03-28 Thread Stefan Berger
On 03/28/2013 01:27 PM, Anthony Liguori wrote: Stefan Berger writes: On 03/27/2013 03:12 PM, Stefan Berger wrote: On 03/27/2013 02:27 PM, Anthony Liguori wrote: Stefan Berger writes: On 03/27/2013 01:14 PM, Anthony Liguori wrote: Stefan Berger writes: What I struggle with is that we're

[Qemu-devel] [PATCH v3 04/11] savevm: add error parameter to qemu_savevm_state_iterate()

2013-03-28 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Eric Blake --- include/sysemu/sysemu.h | 2 +- migration.c | 2 +- savevm.c| 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 2f35a05..af4f699 10064

[Qemu-devel] [PATCH v3 07/11] qapi: Convert savevm

2013-03-28 Thread Pavel Hrdina
QMP command "vm-snapshot-save" has also extra optional force parameter and name parameter isn't optional anymore. It also returns information about created snapshot. Signed-off-by: Pavel Hrdina --- hmp-commands.hx | 4 ++-- hmp.c | 11 + hmp.h

[Qemu-devel] [PATCH 20/23] qcow2: Allow requests with multiple l2metas

2013-03-28 Thread Stefan Hajnoczi
From: Kevin Wolf Instead of expecting a single l2meta, have a list of them. This allows to still have a single I/O request for the guest data, even though multiple l2meta may be needed in order to describe both a COW overwrite and a new cluster allocation (typical sequential write case). Signed-

[Qemu-devel] [PATCH v3 09/11] block: update return value from bdrv_snapshot_create

2013-03-28 Thread Pavel Hrdina
If we provide error message we don't have to also provide return value because we could check if there is any error message or not. Signed-off-by: Pavel Hrdina --- block.c | 24 ++-- block/qcow2-snapshot.c| 12 +--- block/qcow2.h | 6

Re: [Qemu-devel] vNVRAM / blobstore design

2013-03-28 Thread Anthony Liguori
Stefan Berger writes: > On 03/27/2013 03:12 PM, Stefan Berger wrote: >> On 03/27/2013 02:27 PM, Anthony Liguori wrote: >>> Stefan Berger writes: >>> On 03/27/2013 01:14 PM, Anthony Liguori wrote: > Stefan Berger writes: > > What I struggle with is that we're calling this a "blo

[Qemu-devel] [PATCH 01/23] vl.c: call bdrv_init_with_whitelist() before cmdline parsing

2013-03-28 Thread Stefan Hajnoczi
From: Peter Lieven commit 4d454574 "qemu-option: move standard option definitions out of qemu-config.c" broke support for commandline option groups that where registered during bdrv_init(). In particular support for -iscsi options was broken since that commit. Fix by moving the bdrv_init_with_wh

Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory

2013-03-28 Thread Peter Maydell
On 28 March 2013 15:56, Anthony Liguori wrote: > I'll apply these.. In the future, please CC me when sending patches > like this. Yes, I tend to forget to CC you on general type patches (as opposed to ones where you're specifically a maintainer for the area); hence the ping with you added to the

[Qemu-devel] [PATCH 05/23] qcow2: Handle dependencies earlier

2013-03-28 Thread Stefan Hajnoczi
From: Kevin Wolf Handling overlapping allocations isn't just a detail of cluster allocation. It is rather one of three ways to get the host cluster offset for a write request: 1. If a request overlaps an in-flight allocations, the cluster offset can be taken from there (this is what handle_de

[Qemu-devel] [PATCH v3 04/20] tcg-arm: Use tcg_out_dat_rIN for compares

2013-03-28 Thread Richard Henderson
This allows us to emit CMN instructions. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 7475142..3152798 100644 --- a/tcg/ar

[Qemu-devel] [PATCH v3 08/11] qemu-img: introduce qemu_img_handle_error

2013-03-28 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- qemu-img.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 21d02bf..d5f81cc 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -322,6 +322,17 @@ static int add_old_style_options(const char *fmt, QEMUO

[Qemu-devel] [PATCH v3 01/11] block: add error parameter to bdrv_snapshot_create() and related functions

2013-03-28 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- block.c | 22 -- block/qcow2-snapshot.c| 9 - block/qcow2.h | 4 +++- block/rbd.c | 8 ++-- block/sheepdog.c | 17 + include/block/block.h | 3 ++- inc

Re: [Qemu-devel] vNVRAM / blobstore design

2013-03-28 Thread Stefan Berger
On 03/28/2013 12:31 PM, Michael S. Tsirkin wrote: On Thu, Mar 28, 2013 at 12:11:22PM -0400, Stefan Berger wrote: On 03/27/2013 03:12 PM, Stefan Berger wrote: On 03/27/2013 02:27 PM, Anthony Liguori wrote: Stefan Berger writes: On 03/27/2013 01:14 PM, Anthony Liguori wrote: Stefan Berger w

[Qemu-devel] [PATCH v3 03/11] savevm: add error parameter to qemu_savevm_state_begin()

2013-03-28 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Eric Blake --- include/sysemu/sysemu.h | 3 ++- migration.c | 2 +- savevm.c| 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 6578782..2f35a05 100

Re: [Qemu-devel] [PATCH v3 08/20] tcg-arm: Implement deposit for armv7

2013-03-28 Thread Peter Maydell
On 28 March 2013 16:22, Richard Henderson wrote: > On 03/28/2013 09:15 AM, Peter Maydell wrote: >> What guarantees us that we won't see a length of 0? >> The tcg/README description doesn't say that's invalid >> and I don't think the optimize pass handles it (maybe I >> missed it). > > We can patch

[Qemu-devel] [PATCH v3 11/11] savevm: add force parameter to HMP command and return snapshot info

2013-03-28 Thread Pavel Hrdina
HMP command "savevm" now takes extra optional force parameter to specify whether replace existing snapshot or not. It also returns information about created snapshot. Signed-off-by: Pavel Hrdina --- hmp-commands.hx | 16 hmp.c | 18 +- 2 files changed,

Re: [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-28 Thread Michael S. Tsirkin
On Wed, Mar 27, 2013 at 11:28:56PM -0700, Nicholas A. Bellinger wrote: > On Thu, 2013-03-28 at 08:19 +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 27, 2013 at 04:24:22PM -0700, Nicholas A. Bellinger wrote: > > > On Thu, 2013-03-28 at 00:53 +0200, Michael S. Tsirkin wrote: > > > > On Thu, Mar 28,

[Qemu-devel] [PATCH v3 00/11] convert savevm to use qapi and introduce qmp command

2013-03-28 Thread Pavel Hrdina
This patch series convert the savevm command into qapi and introduce QMP command vm-snapshot-save. It also rewrite error report for functions used by this command. The last patch introduce new functionality of savevm that you cannot override existing snapshot without using 'force' parameter. If n

[Qemu-devel] [PATCH 21/23] qcow2: Move cluster gathering to a non-looping loop

2013-03-28 Thread Stefan Hajnoczi
From: Kevin Wolf This patch is mainly to separate the indentation change from the semantic changes. All that really changes here is that everything moves into a while loop, all 'goto done' become 'break' and at the end of the loop a new 'break is inserted. Signed-off-by: Kevin Wolf Signed-off-b

[Qemu-devel] [PATCH v3 10/11] savevm: update return value from qemu_savevm_state

2013-03-28 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- savevm.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/savevm.c b/savevm.c index 0dce456..1e9ab4b 100644 --- a/savevm.c +++ b/savevm.c @@ -1910,7 +1910,7 @@ void qemu_savevm_state_cancel(void) } } -static int qemu_savevm_stat

[Qemu-devel] [PATCH 15/23] qcow2: handle_copied(): Get rid of nb_clusters parameter

2013-03-28 Thread Stefan Hajnoczi
From: Kevin Wolf handle_copied() uses its bytes parameter now to determine how many clusters it should try to find. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/qcow2-cluster.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/

[Qemu-devel] [PATCH v3 06/11] savevm: add error parameter to qemu_savevm_state()

2013-03-28 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Eric Blake --- savevm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/savevm.c b/savevm.c index 7598934..3c1ac9e 100644 --- a/savevm.c +++ b/savevm.c @@ -1910,7 +1910,7 @@ void qemu_savevm_state_cancel(void) } }

[Qemu-devel] [PATCH 14/23] qcow2: Factor out handle_copied()

2013-03-28 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/qcow2-cluster.c | 134 +++--- trace-events | 1 + 2 files changed, 95 insertions(+), 40 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-clus

[Qemu-devel] [PATCH 06/23] qcow2: Improve check for overlapping allocations

2013-03-28 Thread Stefan Hajnoczi
From: Kevin Wolf The old code detected an overlapping allocation even when the allocations didn't actually overlap, but were only adjacent. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/qcow2-cluster.c | 2 +- tests/qemu-iotests/038.out | 10

  1   2   3   >