[Qemu-devel] [PATCH] memory: fix a bug of detection of memory region collision

2013-03-14 Thread Hu Tao
The collision reports before and after this patch are: before: warning: subregion collision cfc/4 (pci-conf-data) vs cf8/4 (pci-conf-idx) warning: subregion collision 800/f800 (pci-hole) vs 0/800 (ram-below-4g) warning: subregion collision 1/4000 (pci-hole64) vs

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-14 Thread Wenchao Xia
于 2013-3-14 20:53, Kevin Wolf 写道: Am 14.03.2013 um 13:10 hat Markus Armbruster geschrieben: Kevin Wolf writes: But you have to do it right. This specific patch would introduce a copyright violation. It's really not that hard to conform to the terms of the MIT license, but that doesn't mean tha

Re: [Qemu-devel] [PATCH] Fix TAGS creation

2013-03-14 Thread Markus Armbruster
David Gibson writes: > Currently the Makefile creates TAGS for emacs with the command: > find "$(SRC_PATH)" -name '*.[hc]' -print0 | xargs -0 etags > That works only if xargs ends up invoking etags just once. If xargs runs > etags several times, as it will if there are enough files, then the

Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info

2013-03-14 Thread Wenchao Xia
于 2013-3-13 20:40, Stefan Hajnoczi 写道: On Wed, Mar 13, 2013 at 06:29:18AM -0600, Eric Blake wrote: On 03/13/2013 05:34 AM, Stefan Hajnoczi wrote: { 'type': 'BlockDeviceInfo', 'data': { 'file': 'str', 'ro': 'bool', 'drv': 'str', '*backing_file': 'str', 'backing_file_depth': 'int

Re: [Qemu-devel] [0/6] Simple extensions to VMStateDescription features

2013-03-14 Thread David Gibson
On Thu, Mar 14, 2013 at 01:42:24PM +0100, Juan Quintela wrote: > David Gibson wrote: > > Jean, Anthony, > > > > This series contains a bunch of straightforward extensions to the > > suite of functions and macros for using in VMStateDescription > > structures. Mostly these fill fairly obvious gaps

Re: [Qemu-devel] [PATCH 4/6] savevm: Add VMSTATE_STRUCT_VARRAY_POINTER_UINT32

2013-03-14 Thread David Gibson
On Thu, Mar 14, 2013 at 01:40:37PM +0100, Juan Quintela wrote: > David Gibson wrote: > > Currently the savevm code contains a VMSTATE_STRUCT_VARRAY_POINTER_INT32 > > helper (a variably sized array with the number of elements in an int32_t), > > but not VMSTATE_STRUCT_VARRAY_POINTER_UINT32 (... wit

Re: [Qemu-devel] [PATCH 4/9] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-14 Thread Peter Crosthwaite
On Fri, Mar 15, 2013 at 1:52 PM, Michael Roth wrote: > On Thu, Mar 14, 2013 at 10:31 PM, Peter Crosthwaite > wrote: >> Hi Michael, Anthony, >> >> On Tue, Mar 12, 2013 at 10:53 AM, Michael Roth >> wrote: >>> Hosts hold on to handles provided by guest-file-open for periods that can >>> span beyond

[Qemu-devel] [PATCH build-breaker] qga/main.c: Don't use g_key_file_get/set_int64

2013-03-14 Thread Peter Crosthwaite
These functions don't exist until glib version 2.26. QEMU is currently only mandating glib 2.12. This patch replaces the functions with g_key_file_get/set_integer. Unbreaks the build on Ubuntu 10.04 and RHEL 5.6. Regression was introduced by 39097daf15c42243742667607d2cad2c9dc4f764 Signed-off-b

[Qemu-devel] [PATCH] pseries: Fix breakage in CPU QOM conversion

2013-03-14 Thread David Gibson
Commit 259186a7d2f7184efc96ae99bc5658e6159f53ad "cpu: Move halted and interrupt_request fields to CPUState" broke the pseries machine. That's because it uses CPU() instead of ENV_GET_CPU() to convert from the global first_cpu pointer (still a CPUArchState) to a CPUState. This patch fixes the brea

Re: [Qemu-devel] [PATCH 4/9] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-14 Thread Michael Roth
On Thu, Mar 14, 2013 at 10:31 PM, Peter Crosthwaite wrote: > Hi Michael, Anthony, > > On Tue, Mar 12, 2013 at 10:53 AM, Michael Roth > wrote: >> Hosts hold on to handles provided by guest-file-open for periods that can >> span beyond the life of the qemu-ga process that issued them. Since these >

Re: [Qemu-devel] [PATCH 4/9] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-14 Thread Peter Crosthwaite
Hi Michael, Anthony, On Tue, Mar 12, 2013 at 10:53 AM, Michael Roth wrote: > Hosts hold on to handles provided by guest-file-open for periods that can > span beyond the life of the qemu-ga process that issued them. Since these > are issued starting from 0 on every restart, we run the risk of issu

Re: [Qemu-devel] [PATCH 0/2 v6] Add Windows support for time resync by qemu-ga

2013-03-14 Thread Lei Li
On 03/15/2013 05:41 AM, mdroth wrote: On Thu, Mar 14, 2013 at 11:05:51PM +0800, Lei Li wrote: This patch series attempts to add Windows implementation for qemu-ga commands guest-get-time and guest-set-time. The previous thread about the interfaces introduced and the POSIX-specific command imple

[Qemu-devel] [PATCH] multiboot: Clean up mmap loop and report correct mmap_length

2013-03-14 Thread Austin Clements
Previously, the multiboot option ROM set the mmap_length field of the multiboot info structure to the length of the mmap array *excluding* the final element of the array, rather than the total length of the array. The multiboot specification indicates that this is incorrect, and it's incompatible

Re: [Qemu-devel] [PATCH v2] Use proper term in TCG README

2013-03-14 Thread Wei-Ren Chen
Thanks, Peter. On Thu, Mar 14, 2013 at 09:03:15AM +, Peter Maydell wrote: > On 14 March 2013 08:06, 陳韋任 (Wei-Ren Chen) wrote: > > In TCG, "target" means the host architecture for which TCG generates > > the code. Using "guest" rather than "target" to make the document more > > consistent

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread Stefan Berger
On 03/14/2013 05:06 PM, mdroth wrote: On Thu, Mar 14, 2013 at 11:24:03AM -0400, Stefan Berger wrote: On 03/14/2013 11:11 AM, mdroth wrote: On Thu, Mar 14, 2013 at 10:51:49AM -0400, Stefan Berger wrote: On 03/14/2013 10:28 AM, mdroth wrote: On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berg

[Qemu-devel] [PATCH 2/2] virtio-scsi: Pack struct virtio_scsi_{req_cmd, resp_cmd}

2013-03-14 Thread Asias He
Device needs the exact size of these data structure. Prevent padding. This fixes guest hang when booting seabios + tcm_vhost. Signed-off-by: Asias He --- src/virtio-scsi.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/virtio-scsi.h b/src/virtio-scsi.h index bbfbf30

[Qemu-devel] [PATCH 1/2] virtio-scsi: Set _DRIVER_OK flag before scsi target scanning

2013-03-14 Thread Asias He
Before we start scsi target scanning, we need to set the VIRTIO_CONFIG_S_DRIVER_OK flag so the device can do setup properly. This fix a bug when booting tcm_vhost with seabios. Signed-off-by: Asias He Acked-by: Paolo Bonzini --- src/virtio-scsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 d

[Qemu-devel] [PATCH 0/2] Fix booting tcm_vhost + seabios

2013-03-14 Thread Asias He
Asias He (2): virtio-scsi: Set _DRIVER_OK flag before scsi target scanning virtio-scsi: Pack struct virtio_scsi_{req_cmd,resp_cmd} src/virtio-scsi.c | 5 +++-- src/virtio-scsi.h | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) -- 1.8.1.4

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-14 Thread li guang
Hi, Anthony Sorry to bother you, can you please help to see it this work is worth to go on, or ... or someone else can help to see this patch-set. Thanks All. 在 2013-03-13三的 16:01 +0800,liguang写道: > By now, all devices of QEMU do not have much more > power management consideration, for example

Re: [Qemu-devel] [PATCH V2 WIP 0/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-14 Thread Asias He
On Thu, Mar 14, 2013 at 11:00:24AM +0100, Paolo Bonzini wrote: > > >> --- 8 ---> seabios patch: > >> diff --git a/src/virtio-scsi.c b/src/virtio-scsi.c > >> index 879ddfb..4de1255 100644 > >> --- a/src/virtio-scsi.c > >> +++ b/src/virtio-scsi.c > >> @@ -147,6 +147,9 @@ init

Re: [Qemu-devel] [PATCH V2 WIP 0/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-14 Thread Asias He
On Thu, Mar 14, 2013 at 11:46:43AM +0200, Michael S. Tsirkin wrote: > On Thu, Mar 14, 2013 at 05:25:42PM +0800, Asias He wrote: > > On Thu, Mar 14, 2013 at 12:25:14PM +0800, Asias He wrote: > > > On Tue, Mar 12, 2013 at 02:29:40PM +0800, Asias He wrote: > > > > This is on top of Paolo and Nick's wo

Re: [Qemu-devel] [libvirt] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Eric Blake
On 03/14/2013 06:22 AM, Michael S. Tsirkin wrote: >>> Just this. Try this: rmmod acpiphp in guest, then: >>> >>> device_del >>> system_reset >>> >>> and see the device disappear even though it was not acked by guest. >> >> Cool, I didn't know that. >> >> Just to make sure: does this automatic remov

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2013-03-14 Thread Davide Guerri
Yes this is definitely an option :) Just for curiosity, what is the effect of "in-kernel irqchip"? Is it possible to disable it on a "live" domain? Cheers, Davide On 14/mar/2013, at 19:21, Peter Lieven wrote: > > Am 14.03.2013 um 19:15 schrieb Davide Guerri : > >> Of course I can do some t

Re: [Qemu-devel] [libvirt] [PATCH v8 0/3] DEVICE_DELETED event

2013-03-14 Thread Eric Blake
On 03/14/2013 06:40 AM, Michael S. Tsirkin wrote: > libvirt has a long-standing bug: when removing the device, > it can request removal but does not know when the > removal completes. Add an event so we can fix this in a robust way. > > First patch only adds the event with ID, second patch adds a

[Qemu-devel] [PATCH 7/7] pcie: Mangle types to match topology

2013-03-14 Thread Alex Williamson
Windows will fail to start drivers for devices with an Endpoint type PCIe capability attached to a Root Complex (code 10 - Device cannot start). The proper type for such a device is Root Complex Integrated Endpoint. Devices don't care which they are, so do this conversion automatically. This all

[Qemu-devel] [RFC 6/6] prep: QOM'ify System I/O

2013-03-14 Thread Hervé Poussineau
Most of the functionality is extracted from hw/ppc/prep.c. Also add support for board identification/equipment registers. Document it for the IBM 43p emulation. Signed-off-by: Hervé Poussineau --- docs/ibm_43p.cfg |5 + hw/ppc/Makefile.objs |1 + hw/ppc/prep_systemio.c | 290 ++

[Qemu-devel] [RFC 5/6] m48t59: hack(?) to make it work on IBM 43p

2013-03-14 Thread Hervé Poussineau
Document it for the IBM 43p emulation. --- docs/ibm_43p.cfg |6 ++ hw/m48t59.c |2 ++ 2 files changed, 8 insertions(+) diff --git a/docs/ibm_43p.cfg b/docs/ibm_43p.cfg index 92c9e8f..55329e3 100644 --- a/docs/ibm_43p.cfg +++ b/docs/ibm_43p.cfg @@ -11,6 +11,12 @@ # them all. [

[Qemu-devel] [RFC 3/6] prep: add RS/6000 debug device

2013-03-14 Thread Hervé Poussineau
Document it for the IBM 43p emulation. Signed-off-by: Hervé Poussineau --- docs/ibm_43p.cfg |3 + hw/ppc/Makefile.objs |1 + hw/ppc/rs6000_debug.c | 260 + 3 files changed, 264 insertions(+) create mode 100644 hw/ppc/rs6000_debug.c

[Qemu-devel] [RFC 2/6] prep: add IBM RS/6000 7248 (43p) machine emulation

2013-03-14 Thread Hervé Poussineau
Machine is very simple (only one PCI host bridge and an ISA bridge). Provide a ibm_43p.cfg file to add more devices to this machine. Syntax is: qemu-system-ppc -M 43p -readconfig ibm_43p.cfg --- docs/ibm_43p.cfg | 34 hw/ppc/prep.c| 94

[Qemu-devel] [RFC 4/6] m48t59: move ISA ports registration to QOM constructor

2013-03-14 Thread Hervé Poussineau
-device m48t59 can now be used to create a fully functional nvram, and m48t59_init_isa() becomes a much simpler helper. Signed-off-by: Hervé Poussineau --- hw/m48t59.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/m48t59.c b/hw/m48t59.c index 39a9d80..1093716

[Qemu-devel] [RFC 1/6] pci: add MPC105 PCI host bridge emulation

2013-03-14 Thread Hervé Poussineau
Missing parts are: - set_irq() and map_irq() functions - missing handling of non-contiguous I/O - migration There is also somewhere a bug in the memory controller, which means that some real firmwares may not detect the correct amount of memory. This can be bypassed by adding '-m 1G' on the comman

[Qemu-devel] [RFC 0/6] ppc/prep: add IBM RS/6000 43p machine

2013-03-14 Thread Hervé Poussineau
Hi, This patchset (sent as RFC) adds an emulation of the IBM RS/6000 43p, also known as 7248. It contains the strict minimum to be able to boot a PReP boot partition on a IDE hard disk. It has been tested with the official firmware, named P93H1904.IMG. However, Andreas has already some prelimin

Re: [Qemu-devel] [PATCH v7 0/8] virtio-blk refactoring.

2013-03-14 Thread Anthony Liguori
Breaks hotplug: Running tests/device-add.sh Using RANDOM seed 24922 Formatting '.tmp-28149/disk.img', fmt=qcow2 size=10737418240 encryption=off cluster_size=65536 lazy_refcounts=off /home/aliguori/build/qemu/x86_64-softmmu/qemu-system-x86_64 -kernel /usr/local/share/qemu-jeos/kernel-x86_64-pc

[Qemu-devel] [PATCH 6/7] pci: Create and use API to determine root buses

2013-03-14 Thread Alex Williamson
Signed-off-by: Alex Williamson --- hw/pci/pci.c | 13 + hw/pci/pci.h |1 + 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 9c394ab..a023d9c 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -302,6 +302,11 @@ bool pci_bus_is_express

[Qemu-devel] [PATCH 5/7] pci: Create pci_bus_is_express helper

2013-03-14 Thread Alex Williamson
For testing the bus type. Signed-off-by: Alex Williamson --- hw/pci/pci.c |5 + hw/pci/pci.h |1 + 2 files changed, 6 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index f18d3ea..9c394ab 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -297,6 +297,11 @@ static void pci_bus_i

[Qemu-devel] [PATCH 3/7] pci: Allow PCI bus creation interfaces to specify the type of bus

2013-03-14 Thread Alex Williamson
No change to any types. Signed-off-by: Alex Williamson --- hw/alpha_typhoon.c |2 +- hw/apb_pci.c|4 ++-- hw/bonito.c |2 +- hw/dec_pci.c|7 ++- hw/grackle_pci.c|2 +- hw/gt64xxx.c|2 +- hw/i82801b11.c

[Qemu-devel] [PATCH 2/7] pci: Move PCI and PCIE type defines

2013-03-14 Thread Alex Williamson
Move these so that we can reference them from a more common header instead of including pci_bus.h everywhere. Signed-off-by: Alex Williamson --- hw/pci/pci.h |5 + hw/pci/pci_bus.h |4 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.h b/hw/pci/pci.h

[Qemu-devel] [PATCH 4/7] pci: Q35, Root Ports, and Switches create PCI Express buses

2013-03-14 Thread Alex Williamson
Convert q35, ioh3420, xio3130_upstream, and xio3130_downstream to use the new TYPE_PCIE_BUS. Signed-off-by: Alex Williamson --- hw/ioh3420.c|2 +- hw/q35.c|2 +- hw/xio3130_downstream.c |2 +- hw/xio3130_upstream.c |2 +- 4 files changed, 4 insertion

[Qemu-devel] [PATCH 1/7] pci: Create and register a new PCI Express TypeInfo

2013-03-14 Thread Alex Williamson
This will allow us to differentiate Express and Legacy buses. Signed-off-by: Alex Williamson --- hw/pci/pci.c |6 ++ hw/pci/pci_bus.h |1 + 2 files changed, 7 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index f24c389..e74b43d 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci

[Qemu-devel] [PATCH 0/7] pci: Create PCI Express bus type

2013-03-14 Thread Alex Williamson
When setting PCIe capabilities we need to know the type of bus we have. On secondary buses we could poke around on the parent bridge device to infer this data, but on root buses there's no parent device. By creating a new PCIE TypeInfo we can inherit everything about PCI buses while still allowing

Re: [Qemu-devel] [RFC 4/8] block: add block_backup QMP command

2013-03-14 Thread Eric Blake
On 03/09/2013 03:22 PM, Stefan Hajnoczi wrote: > @block-backup > > Start a point-in-time copy of a block device to a new destination. > I'm trying to figure out how this is different from drive-mirror. If I understand correctly: After starting drive-mirror, a write to the block device is also

Re: [Qemu-devel] [RFC 4/8] block: add block_backup QMP command

2013-03-14 Thread Eric Blake
On 03/09/2013 03:22 PM, Stefan Hajnoczi wrote: > @block-backup > > Start a point-in-time copy of a block device to a new destination. > Is a BLOCK_JOB_COMPLETED event emitted when the copy is completed? If not, it should be. > +# Since 1.5 > +## > +{ 'command': 'block-backup', > + 'data': { '

Re: [Qemu-devel] [PATCH 0/2 v6] Add Windows support for time resync by qemu-ga

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 11:05:51PM +0800, Lei Li wrote: > This patch series attempts to add Windows implementation > for qemu-ga commands guest-get-time and guest-set-time. > > The previous thread about the interfaces introduced and > the POSIX-specific command implementation has already > been a

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 11:05:52PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-win32.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index 7e8ecb3..b395bd5 100644 > --- a/qga/commands-wi

Re: [Qemu-devel] [PATCH] qemu-char: Fix typo in virtual console registration

2013-03-14 Thread Anthony Liguori
Jan Kiszka writes: > Regression of 01f45d986f. > > Signed-off-by: Jan Kiszka Yeah, another version of this will be pushed shortly from Gerd. Regards, Anthony Liguori > --- > ui/console.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/ui/console.c b/ui/console

Re: [Qemu-devel] [PATCH 06/13] block: Support driver specific options in drive_init()

2013-03-14 Thread Anthony Liguori
Kevin Wolf writes: > Any non-default -drive options are now passed down to the block drivers. > > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > Reviewed-by: Stefan Hajnoczi According to git-bisect, this breaks virtio-blk serial property. Here's the output from qemu-test: Using RANDO

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 11:24:03AM -0400, Stefan Berger wrote: > On 03/14/2013 11:11 AM, mdroth wrote: > >On Thu, Mar 14, 2013 at 10:51:49AM -0400, Stefan Berger wrote: > >>On 03/14/2013 10:28 AM, mdroth wrote: > >>>On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berger wrote: > On 03/14/2013

Re: [Qemu-devel] [PATCH v4] Add GDB qAttached support

2013-03-14 Thread Jesse Larrew
On 03/14/2013 02:51 PM, Jan Kiszka wrote: > With this patch QEMU handles qAttached request from gdb. When QEMU > replies 1, GDB sends a "detach" command at the end of a debugging > session otherwise GDB sends "kill". > > The default value for qAttached is 1 on system emulation and 0 on user > emul

Re: [Qemu-devel] [PATCH v14 4/4] pvevent: add document to describe the usage

2013-03-14 Thread Eric Blake
On 03/14/2013 02:15 AM, Hu Tao wrote: > Signed-off-by: Hu Tao > --- > docs/pvevent.txt | 16 > 1 file changed, 16 insertions(+) > create mode 100644 docs/pvevent.txt > > diff --git a/docs/pvevent.txt b/docs/pvevent.txt > new file mode 100644 > index 000..749b87c > --- /dev/

Re: [Qemu-devel] [PATCH V3 2/3] Revert "gdbstub: Do not kill target in system emulation mode"

2013-03-14 Thread Jan Kiszka
On 2013-03-12 18:31, Fabien Chouteau wrote: > The requirements described in this patch are implemented by "Add GDB > qAttached support". > > This reverts commit 00e94dbc7fd0110b0555d59592b004333adfb4b8. > > Signed-off-by: Fabien Chouteau > --- > gdbstub.c |2 -- > 1 file changed, 2 deletion

[Qemu-devel] [PATCH v4] Add GDB qAttached support

2013-03-14 Thread Jan Kiszka
With this patch QEMU handles qAttached request from gdb. When QEMU replies 1, GDB sends a "detach" command at the end of a debugging session otherwise GDB sends "kill". The default value for qAttached is 1 on system emulation and 0 on user emulation. Based on original version by Fabien Chouteau.

Re: [Qemu-devel] [PULL v4 00/20] chardev: qapi conversion continued

2013-03-14 Thread Anthony Liguori
Eric Blake writes: > On 03/14/2013 02:57 AM, Gerd Hoffmann wrote: >> Hi, >> >> v5 if the series, completing the chardev convwersion to qapi. > > v4 in subject, v5 in contents - hope Anthony's scripts don't get confused... It's fine. Newest mail wins if there are two with the same version. R

[Qemu-devel] [PATCH] qemu-char: Fix typo in virtual console registration

2013-03-14 Thread Jan Kiszka
Regression of 01f45d986f. Signed-off-by: Jan Kiszka --- ui/console.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ui/console.c b/ui/console.c index 83a6fa3..0f96177 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1742,7 +1742,7 @@ PixelFormat qemu_default_pixelforma

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2013-03-14 Thread Peter Lieven
Am 14.03.2013 um 19:15 schrieb Davide Guerri : > Of course I can do some test but a kernel upgrade is not an option here :( disabling the in-kernel irqchip (default since 1.2.0) should also help, maybe this is an option. Peter

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2013-03-14 Thread Davide Guerri
Of course I can do some test but a kernel upgrade is not an option here :( However I don't think this is only a guest problem since it has been triggered by something between KVM 1.0 and 1.2. On 14/mar/2013, at 18:50, Michael S. Tsirkin wrote: > > Could be one of the bugs fixed in guest dr

[Qemu-devel] [PATCH v2 2/2] configure: Don't fall back to gthread coroutine backend

2013-03-14 Thread Peter Maydell
The gthread coroutine backend is broken and does not produce a working QEMU; it is only useful for some very limited debugging situations. Clean up the backend selection logic in configure so that it now runs "if on windows use windows; else prefer ucontext; else sigaltstack". To do this we refact

[Qemu-devel] [PATCH v2 0/2] configure: fix coroutine backend selection logic

2013-03-14 Thread Peter Maydell
The main aim of this patchset is patch 2, which changes the coroutine backend selection logic so that it goes 'ucontext -> sigaltstack' rather than 'ucontext -> gthread', since the gthread backend is broken. To do this properly on all platforms we have to refactor the code a bit (which it needed an

[Qemu-devel] [PATCH v2 1/2] configure: Provide and use convenience error reporting function

2013-03-14 Thread Peter Maydell
Provide a convenience function for reporting an error and exiting, and update various places in the configure script to use it. This allows us to be a little more consistent about how format our error messages and makes the calling code shorter. Signed-off-by: Peter Maydell --- configure | 193

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2013-03-14 Thread Michael S. Tsirkin
Could be one of the bugs fixed in guest drivers since 2.6.32. For example, 39d321577405e8e269fd238b278aaf2425fa788a ? Does it help if you try a more recent guest? On Thu, Mar 14, 2013 at 11:43:30AM +0100, Alexandre DERUMIER wrote: > I don't think it's fixed in 1.3 or 1.4, some proxmox users have

[Qemu-devel] [PATCH 0/4] Fix JSON string formatter

2013-03-14 Thread Markus Armbruster
This should unbreak "make check" on machines where char is unsigned. Blue, please give it a whirl. The JSON parser is still as broken as ever. Left for another day. Markus Armbruster (4): unicode: New mod_utf8_codepoint() check-qjson: Fix up a few bogus comments check-qjson: Test noncharac

[Qemu-devel] [PATCH 3/4] check-qjson: Test noncharacters other than U+FFFE, U+FFFF in strings

2013-03-14 Thread Markus Armbruster
These are all broken, too. A few test cases use noncharacters U+ and U+10. Risks testing noncharacters some more instead of what they're supposed to test. Use U+FFFD and U+10FFFD instead. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 85 +++

[Qemu-devel] [PATCH 4/4] qjson: to_json() case QTYPE_QSTRING is buggy, rewrite

2013-03-14 Thread Markus Armbruster
Known bugs in to_json(): * A start byte for a three-byte sequence followed by less than two continuation bytes is split into one-byte sequences. * Start bytes for sequences longer than three bytes get misinterpreted as start bytes for three-byte sequences. Continuation bytes beyond byte th

[Qemu-devel] [PATCH 1/4] unicode: New mod_utf8_codepoint()

2013-03-14 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- include/qemu-common.h | 3 ++ util/Makefile.objs| 1 + util/unicode.c| 96 +++ 3 files changed, 100 insertions(+) create mode 100644 util/unicode.c diff --git a/include/qemu-common.h b/include/qe

[Qemu-devel] [PATCH 2/4] check-qjson: Fix up a few bogus comments

2013-03-14 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/check-qjson.c b/tests/check-qjson.c index ec85a0c..852124a 100644 --- a/tests/check-qjson.c +++ b/tests/check-qjson.c @@ -4,7 +4,7 @@ * * Authors: * Anth

[Qemu-devel] [PATCH v7 4/8] virtio-blk-s390: switch to the new API.

2013-03-14 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-s390 is modified for the new API. The device virtio-blk-s390 extends virtio-s390-device as before. It creates and connects a virtio-blk during the init. The properties are not modified. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/

[Qemu-devel] [PATCH 6/8] spice-qemu-char: Move spice_chr_close down

2013-03-14 Thread Hans de Goede
This puts it in a more logical place and avoids the need for forward declarations in the next patch of this series. Note no code changes, just moving it around. Signed-off-by: Hans de Goede --- spice-qemu-char.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) d

Re: [Qemu-devel] [PATCH] block: drop bs_snapshots global variable

2013-03-14 Thread Eric Blake
On 03/14/2013 10:04 AM, Stefan Hajnoczi wrote: > The bs_snapshots global variable points to the BlockDriverState which > will be used to save vmstate. This is really a savevm.c concept but was > moved into block.c:bdrv_snapshots() when it became clear that hotplug > could result in a dangling poin

[Qemu-devel] [PATCH v7 8/8] virtio-blk: cleanup: remove qdev field.

2013-03-14 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed, just drop it. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/virtio-blk.c | 3 +-- hw/virtio-blk.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 663edcd..

Re: [Qemu-devel] [PATCH 3/3] configure: Don't fall back to gthread coroutine backend

2013-03-14 Thread Peter Maydell
On 14 March 2013 15:54, Paolo Bonzini wrote: > Il 14/03/2013 16:25, Peter Maydell ha scritto: >> The gthread coroutine backend is broken and does not produce a working >> QEMU; it is only useful for some very limited debugging situations. >> Clean up the backend selection logic in configure so tha

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2013-03-14 Thread Davide Guerri
I'd like to reopen this thread because this problem is still here and it's really annoying. Another possible work-around is to pin the virtio nic irq to one virtual CPU (with /proc/smp_affinity) but (of course) this is still sub-optimal. Here are some graphs showing the performance of a heavy lo

[Qemu-devel] [PATCH 4/8] spice-qemu-char: Add watch support

2013-03-14 Thread Hans de Goede
Signed-off-by: Hans de Goede --- spice-qemu-char.c | 67 +++ 1 file changed, 63 insertions(+), 4 deletions(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index b810b30..ddaf5b3 100644 --- a/spice-qemu-char.c +++ b/spice-qemu-char.c @@ -1

Re: [Qemu-devel] [PATCH] spice-qemu-char: register interface on post load

2013-03-14 Thread Alon Levy
> Hi, > > On 03/14/2013 04:12 PM, Alon Levy wrote: > > The target has not seen the guest_connected event via > > spice_chr_guest_open or spice_chr_write, and so spice server > > wrongly > > assumes there is no agent active, while the client continues to > > send > > motion events only by the agent

[Qemu-devel] [PATCH 5/8] spice-qemu-char: Remove intermediate buffer

2013-03-14 Thread Hans de Goede
From: Alon Levy virtio-serial's buffer is valid when it calls us, and we don't access it otherwise: vmc_read is only called in response to wakeup, or else we set datalen=0 and throttle. Then vmc_read is called back, we return 0 (not accessing the buffer) and set the timer to unthrottle. Also mak

[Qemu-devel] [PATCH 3/8] spice-qemu-char: Remove #ifdef-ed code for old spice-server compat

2013-03-14 Thread Hans de Goede
We now require spice-server to be >= 0.12.0 so this is no longer needed. Signed-off-by: Hans de Goede --- spice-qemu-char.c | 27 +-- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 8a9236d..b810b30 100644 --- a/sp

[Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support

2013-03-14 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/redirect.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index c519b9b..9ba714d 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -104,6 +104,8 @@ struct US

Re: [Qemu-devel] [PATCH] spice-qemu-char: register interface on post load

2013-03-14 Thread Hans de Goede
Hi, On 03/14/2013 04:12 PM, Alon Levy wrote: The target has not seen the guest_connected event via spice_chr_guest_open or spice_chr_write, and so spice server wrongly assumes there is no agent active, while the client continues to send motion events only by the agent channel, which the server i

[Qemu-devel] [PATCH 1/8] virtio-console: Also throttle when less was written then requested

2013-03-14 Thread Hans de Goede
This is necessary so that we get properly woken up to write the rest. Signed-off-by: Hans de Goede Acked-by: Amit Shah --- hw/virtio-console.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index e2d1c58..1d87c5b 100644 --- a/h

[Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load

2013-03-14 Thread Hans de Goede
From: Alon Levy The target has not seen the guest_connected event via spice_chr_guest_open or spice_chr_write, and so spice server wrongly assumes there is no agent active, while the client continues to send motion events only by the agent channel, which the server ignores. The net effect is that

[Qemu-devel] Spice / usb-redir chardev flowcontrol patches v2

2013-03-14 Thread Hans de Goede
Here is v2 of the series adding watch support to the spicevmc chardev backend and flowcontrol support to the usb-redir device. It also includes a few virtio-consoled bugfixes which were found during the development of this series. Note that this series is based *on top of* Gerd Hoffmann's chardev.

[Qemu-devel] [PATCH 2/8] virtio-console: Remove any pending watches on close

2013-03-14 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/virtio-console.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 1d87c5b..8ef76e2 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -18,6 +18,7 @@ typedef

Re: [Qemu-devel] [PATCH V3 3/3] New option -gdb-opts

2013-03-14 Thread Fabien Chouteau
On 03/14/2013 01:34 PM, Markus Armbruster wrote: > Fabien Chouteau writes: > >> On 03/14/2013 09:44 AM, Markus Armbruster wrote: >>> Fabien Chouteau writes: >>> We introduce a new command line option. It's a generic option to customize the gdb server: -gdb-opts [attached=on|o

Re: [Qemu-devel] [PATCH 3/3] configure: Don't fall back to gthread coroutine backend

2013-03-14 Thread Paolo Bonzini
Il 14/03/2013 16:25, Peter Maydell ha scritto: > The gthread coroutine backend is broken and does not produce a working > QEMU; it is only useful for some very limited debugging situations. > Clean up the backend selection logic in configure so that it now runs > "if on windows use windows; else pr

Re: [Qemu-devel] [PATCH v7 2/8] virtio-blk: add the virtio-blk device.

2013-03-14 Thread Peter Maydell
On 14 March 2013 16:04, wrote: > From: KONRAD Frederic > > Create virtio-blk which extends virtio-device, so it can be connected on > virtio-bus. > > Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] QEMU aarch64 TCG target

2013-03-14 Thread Peter Maydell
On 14 March 2013 15:57, Claudio Fontana wrote: > I am currently working on an aarch64 tcg target implementation, > based on the available gdb patches contributed by ARM and the results > of the linaro toolchain. Doing a target implementation based on the gdb/binutils patches and not the actual do

Re: [Qemu-devel] [PATCH v14 3/4] introduce pvevent device to deal with panicked event

2013-03-14 Thread Paolo Bonzini
Il 14/03/2013 16:59, Gleb Natapov ha scritto: > On Thu, Mar 14, 2013 at 04:50:40PM +0100, Paolo Bonzini wrote: >> Il 14/03/2013 15:23, Gleb Natapov ha scritto: >>> On Thu, Mar 14, 2013 at 03:05:22PM +0100, Paolo Bonzini wrote: Il 14/03/2013 14:56, Gleb Natapov ha scritto: > On Thu, Mar 14,

[Qemu-devel] [PATCH] qemu-iotests: use -nographic in test case 007

2013-03-14 Thread Stefan Hajnoczi
A comment explains that -nographic hangs test case 007. This is no longer the case so add -nographic. This makes the test suite faster and more pleasant to run since no windows pop up. I am not sure exactly when -nographic starting working for this case but there is no fundamental reason why gra

[Qemu-devel] [PATCH v7 6/8] virtio-blk: cleanup: init and exit functions.

2013-03-14 Thread fred . konrad
From: KONRAD Frederic As all virtio-blk-* are switched to the new API, we can remove the separate init/exit for the old API. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/virtio-blk.c | 85 ++--- hw/virtio.h | 2 -- 2

[Qemu-devel] [PATCH v7 3/8] virtio-blk-pci: switch to new API.

2013-03-14 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-pci is modified for the new API. The device virtio-blk-pci extends virtio-pci. It creates and connects a virtio-blk during the init. The properties are not changed. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/virtio-pci.c | 121 ++

[Qemu-devel] [PATCH v7 7/8] virtio-blk: cleanup: QOM cast

2013-03-14 Thread fred . konrad
From: KONRAD Frederic Use QOM casts inside virtio-blk. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/virtio-blk.c | 33 ++--- hw/virtio-blk.h | 2 +- 2 files changed, 15 insertions(+), 20 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-bl

[Qemu-devel] [PATCH v7 2/8] virtio-blk: add the virtio-blk device.

2013-03-14 Thread fred . konrad
From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 98 ++--- hw/virtio-blk.h | 21 + hw/virtio-pci.c | 8 + 3 files

[Qemu-devel] [PATCH v7 5/8] virtio-blk-ccw switch to new API.

2013-03-14 Thread fred . konrad
From: KONRAD Frederic Here the virtio-ccw-s390 is modified for the new API. The device virtio-ccw-s390 extends virtio-ccw-device as before. It creates and connects a virtio-ccw during the init. The properties are not modified. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/s

[Qemu-devel] [PATCH] block: drop bs_snapshots global variable

2013-03-14 Thread Stefan Hajnoczi
The bs_snapshots global variable points to the BlockDriverState which will be used to save vmstate. This is really a savevm.c concept but was moved into block.c:bdrv_snapshots() when it became clear that hotplug could result in a dangling pointer. While auditing the block layer's global state I c

[Qemu-devel] [PATCH v7 1/8] virtio-blk: don't use pointer for configuration.

2013-03-14 Thread fred . konrad
From: KONRAD Frederic The configuration field must not be a pointer as it will be used for virtio-blk properties. So *blk is replaced by blk in VirtIOBlock structure. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/virtio-blk.c | 8 hw/virtio-blk.h | 2 +- 2 files ch

[Qemu-devel] [PATCH v7 0/8] virtio-blk refactoring.

2013-03-14 Thread fred . konrad
From: KONRAD Frederic This is the next part of virtio-refactoring. Basically it creates virtio-blk device which extends virtio-device. Then a virtio-blk can be connected on a virtio-bus. virtio-blk-pci, virtio-blk-s390x, virtio-blk-ccw are created too, they extend respectively virtio-pci, virtio

[Qemu-devel] QEMU aarch64 TCG target

2013-03-14 Thread Claudio Fontana
Hello all, I am currently working on an aarch64 tcg target implementation, based on the available gdb patches contributed by ARM and the results of the linaro toolchain. I have implemented most opcodes, but I still need to clean up and also implement the op_qemu_ld/st stuff, which seems the mos

Re: [Qemu-devel] [PATCH v14 3/4] introduce pvevent device to deal with panicked event

2013-03-14 Thread Gleb Natapov
On Thu, Mar 14, 2013 at 04:50:40PM +0100, Paolo Bonzini wrote: > Il 14/03/2013 15:23, Gleb Natapov ha scritto: > > On Thu, Mar 14, 2013 at 03:05:22PM +0100, Paolo Bonzini wrote: > >> Il 14/03/2013 14:56, Gleb Natapov ha scritto: > >>> On Thu, Mar 14, 2013 at 02:49:48PM +0100, Paolo Bonzini wrote: >

Re: [Qemu-devel] [PATCH v14 3/4] introduce pvevent device to deal with panicked event

2013-03-14 Thread Paolo Bonzini
Il 14/03/2013 15:23, Gleb Natapov ha scritto: > On Thu, Mar 14, 2013 at 03:05:22PM +0100, Paolo Bonzini wrote: >> Il 14/03/2013 14:56, Gleb Natapov ha scritto: >>> On Thu, Mar 14, 2013 at 02:49:48PM +0100, Paolo Bonzini wrote: Il 14/03/2013 13:34, Gleb Natapov ha scritto: >> * it can be an

Re: [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable

2013-03-14 Thread Laszlo Ersek
On 03/14/13 15:57, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > After rebasing this I saw that Anthony already committed a fix that is > very close to my v1. I don't intend to actually change that code, but as > I've already done this, just for comparison what it would look like with > er

[Qemu-devel] [PATCH 3/3] configure: Don't fall back to gthread coroutine backend

2013-03-14 Thread Peter Maydell
The gthread coroutine backend is broken and does not produce a working QEMU; it is only useful for some very limited debugging situations. Clean up the backend selection logic in configure so that it now runs "if on windows use windows; else prefer ucontext; else sigaltstack". To do this we refact

[Qemu-devel] [PATCH 1/3] configure: Provide and use convenience error reporting function

2013-03-14 Thread Peter Maydell
Provide a convenience function for reporting an error and exiting, and update various places in the configure script to use it. This allows us to be a little more consistent about how format our error messages and makes the calling code shorter. Signed-off-by: Peter Maydell --- configure | 193

  1   2   3   >