Re: [Qemu-devel] [PATCH 2/2] qga: add windows implementation for guest-set-time

2013-03-13 Thread Lei Li
On 03/14/2013 04:25 AM, mdroth wrote: On Wed, Mar 13, 2013 at 06:10:31PM +0800, li...@linux.vnet.ibm.com wrote: From: Lei Li Signed-off-by: Lei Li --- qga/commands-win32.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/qga/command

Re: [Qemu-devel] [PATCH] Use proper term in TCG README

2013-03-13 Thread Wei-Ren Chen
On Fri, Mar 08, 2013 at 11:13:24AM +0100, Stefan Hajnoczi wrote: > On Fri, Mar 08, 2013 at 05:29:29PM +0800, Peter Maydell wrote: > > On 8 March 2013 17:21, Stefan Hajnoczi wrote: > > > On Thu, Mar 07, 2013 at 11:33:01AM +0800, 陳韋任 (Wei-Ren Chen) wrote: > > >> In TCG, "target" means the host arc

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-13 Thread Lei Li
On 03/14/2013 04:07 AM, mdroth wrote: On Wed, Mar 13, 2013 at 06:10:30PM +0800, li...@linux.vnet.ibm.com wrote: From: Lei Li Signed-off-by: Lei Li --- qga/commands-win32.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/qga/commands-

[Qemu-devel] kvm-unit-test poweroff qemu-kvm via acpi

2013-03-13 Thread Qiu, Shuang
Hello there, I tried to run kvm-unit-test on uq/master branch commit 3e41a753551a906dd9ed66fb0fc34167a6af3ba0 but failed. The symptom is that qume cannot exit/poweroff gracefully and keeps rebooting. After investigating the code, I find the misbehaviors may be introduced by commint 9ee59f341f9

Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction

2013-03-13 Thread Wenchao Xia
于 2013-3-13 18:18, Kevin Wolf 写道: Am 12.03.2013 um 09:30 hat Wenchao Xia geschrieben: I redesigned the structure, Following is the fake code: typedef struct BdrvActionOps { /* check the request's validation, allocate p_opaque if needed */ int (*check)(BlockdevAction *action, void *

Re: [Qemu-devel] [PATCH V2 WIP 0/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-13 Thread Asias He
On Tue, Mar 12, 2013 at 02:29:40PM +0800, Asias He wrote: > This is on top of Paolo and Nick's work. > > Current status: > Works now (guest boots fine, no hang any more) with seabios's virtio-scsi > disabled. > Rebased to latest qemu.org/master > Change details are in commit log. > > TODO: > Mak

Re: [Qemu-devel] BUG: RTC issue when Windows guest is idle

2013-03-13 Thread Matthew Anderson
Thanks for the suggestion but so far it hasn't made any difference. I thought I may be an issue with the mainline kernel I was using so I changed over to Ubuntu 12.10 and QEMU 1.2.0. Stability is slightly better but I still get 2-3 VM's a day out of about 120 experiencing this bug in the exact s

Re: [Qemu-devel] [PATCH v2 4/5] net: introduce lock to protect NetClientState's peer's access

2013-03-13 Thread liu ping fan
On Wed, Mar 13, 2013 at 6:39 PM, Paolo Bonzini wrote: > Il 13/03/2013 02:26, liu ping fan ha scritto: >> On Tue, Mar 12, 2013 at 4:55 PM, Paolo Bonzini wrote: >>> Il 07/03/2013 03:53, Liu Ping Fan ha scritto: From: Liu Ping Fan Introduce nc->send_lock, it shield off the race of nc

Re: [Qemu-devel] dataplane bug: fail to start VM with dataplane enable

2013-03-13 Thread Dunrong Huang
On Wed, Mar 13, 2013 at 7:28 PM, Stefan Hajnoczi wrote: > On Wed, Mar 13, 2013 at 06:01:40PM +0800, Dunrong Huang wrote: >> Hi, Paolo && Stefan: >> >> When I test the dataplane feature with git master, I find that VM will >> hang if dataplane is enabled. But if I use qemu-1.4.0, VM can start >> n

[Qemu-devel] [PATCH 5/5] pseries: Move XICS initialization before cpu initialization

2013-03-13 Thread David Gibson
Currently, the pseries machine initializes the cpus, then the XICS interrupt controller. However, to support the upcoming in-kernel XICS implementation we will need to initialize the irq controller before the vcpus. This patch makes the necesssary rearrangement. This means the xics init code can

[Qemu-devel] [PATCH 3/5] pseries: Fixes and enhancements to L1 cache properties

2013-03-13 Thread David Gibson
PAPR requires that the device tree's CPU nodes have several properties with information about the L1 cache. We already create two of these properties, but with incorrect names - "[id]cache-block-size" instead of "[id]-cache-block-size" (note the extra hyphen). We were also missing some of the req

[Qemu-devel] [0/5] Assorted pending pseries machine patches

2013-03-13 Thread David Gibson
Hi Alex, Here's a handful of patches I've had pending in my tree for a while. They've now been polished up and are ready for merge.

[Qemu-devel] [PATCH 2/5] pseries: Remove "busname" property for PCI host bridge

2013-03-13 Thread David Gibson
Currently the "spapr-pci-host-bridge" device has a "busname" property which can be used to override the default assignment of qbus names for the bus subordinate to the PHB. We use that for the default primary PCI bus, to make libvirt happy, which expects there to be a bus named simply "pci". The d

[Qemu-devel] [PATCH 1/5] target-ppc: Synchronize VPA state with KVM

2013-03-13 Thread David Gibson
For PAPR guests, KVM tracks the various areas registered with the H_REGISTER_VPA hypercall. For full emulation, of course, these are tracked within qemu. At present these values are not synchronized. This is a problem for reset (qemu's reset of the VPA address is not pushed to KVM) and will also

[Qemu-devel] [PATCH 4/5] target-ppc: Remove CONFIG_PSERIES dependency in kvm.c

2013-03-13 Thread David Gibson
target-ppc/kvm.c has an #ifdef on CONFIG_PSERIES, for the handling of KVM exits due to a PAPR hypercall from the guest. However, since commit e4c8b28cde12d01ada8fe869567dc5717a2dfcb7 "ppc: express FDT dependency of pSeries and e500 boards via default-configs/", this hasn't worked properly. That pa

Re: [Qemu-devel] [PATCH 7/9] asn1_input-visitor.diff

2013-03-13 Thread Stefan Berger
On 03/13/2013 09:22 PM, Joel Schopp wrote: +case 0x41: +case 0x40: +num.mpn.sign = ((number.first & 0x1) != 0); +num.mpn.biased_exponent = ~0; +num.mpn.mantissa_low = 0; +num.mpn.mantissa_high = 0; +*obj = num.v_double; Is this really portable en

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread Stefan Berger
On 03/13/2013 07:18 PM, mdroth wrote: On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: On 03/13/2013 04:52 PM, mdroth wrote: Visitors don't have any knowledge of the data structures they're visiting outside of what we tell them via the visit_*() API. [...] For example, a visito

Re: [Qemu-devel] [PATCH 7/9] asn1_input-visitor.diff

2013-03-13 Thread Joel Schopp
+case 0x41: +case 0x40: +num.mpn.sign = ((number.first & 0x1) != 0); +num.mpn.biased_exponent = ~0; +num.mpn.mantissa_low = 0; +num.mpn.mantissa_high = 0; +*obj = num.v_double; Is this really portable enough? In other words, do we really require

Re: [Qemu-devel] [PATCH] virtio-pci: guest notifier mask without non-irqfd

2013-03-13 Thread Alexey Kardashevskiy
Michael, yes, that works fine on ppc64 with vhost=on. Thanks! On 14/03/13 06:46, Michael S. Tsirkin wrote: non-irqfd setups are currently broken with vhost: we start up masked and nothing unmasks the interrupts. Fix by using mask notifiers, same as the irqfd path. Sharing irqchip/non irqchip

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: > On 03/13/2013 04:52 PM, mdroth wrote: > >On Wed, Mar 13, 2013 at 01:56:24PM -0500, Joel Schopp wrote: > >>Add a sized buffer interface to qapi. > >Isn't this just a special case of the visit_*_carray() interfaces? We > >should avoid n

Re: [Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread Stefan Berger
On 03/13/2013 06:47 PM, mdroth wrote: On Wed, Mar 13, 2013 at 05:41:33PM -0500, mdroth wrote: On Wed, Mar 13, 2013 at 05:28:56PM -0400, Stefan Berger wrote: On 03/13/2013 05:11 PM, mdroth wrote: On Wed, Mar 13, 2013 at 01:56:23PM -0500, Joel Schopp wrote: This patch adds support functions for

Re: [Qemu-devel] [PATCH 2/9] qapi_c_arrays.diff

2013-03-13 Thread Stefan Berger
On 03/13/2013 02:56 PM, Joel Schopp wrote: Forward ported Mike's previously sent patch (see http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05782.html ) in my series since it implements a qapi array interface the ASN.1 BER visitor needs. Generally these will be serialized into lists, but

Re: [Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 05:41:33PM -0500, mdroth wrote: > On Wed, Mar 13, 2013 at 05:28:56PM -0400, Stefan Berger wrote: > > On 03/13/2013 05:11 PM, mdroth wrote: > > >On Wed, Mar 13, 2013 at 01:56:23PM -0500, Joel Schopp wrote: > > >>This patch adds support functions for operating on in memory siz

Re: [Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 05:28:56PM -0400, Stefan Berger wrote: > On 03/13/2013 05:11 PM, mdroth wrote: > >On Wed, Mar 13, 2013 at 01:56:23PM -0500, Joel Schopp wrote: > >>This patch adds support functions for operating on in memory sized file > >>buffers. > >There's been some past refactorings to

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread Stefan Berger
On 03/13/2013 04:52 PM, mdroth wrote: On Wed, Mar 13, 2013 at 01:56:24PM -0500, Joel Schopp wrote: Add a sized buffer interface to qapi. Isn't this just a special case of the visit_*_carray() interfaces? We should avoid new interfaces if possible, since it adds to feature disparities between vi

Re: [Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread Stefan Berger
On 03/13/2013 05:11 PM, mdroth wrote: On Wed, Mar 13, 2013 at 01:56:23PM -0500, Joel Schopp wrote: This patch adds support functions for operating on in memory sized file buffers. There's been some past refactorings to remove non-migration users of QEMUFile, and AFAIK that's still the case toda

Re: [Qemu-devel] [PATCH 7/9] asn1_input-visitor.diff

2013-03-13 Thread Stefan Berger
On 03/13/2013 04:51 PM, Eric Blake wrote: On 03/12/2013 09:09 PM, Joel Schopp wrote: Implement an input visitor for ASN.1 BER encoding. Cc: Michael Tsirkin Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- include/qapi/ber-input-visitor.h | 30 ++ qapi/Makefile.objs

Re: [Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 01:56:23PM -0500, Joel Schopp wrote: > This patch adds support functions for operating on in memory sized file > buffers. There's been some past refactorings to remove non-migration users of QEMUFile, and AFAIK that's still the case today. QEMUFile satisfies funky requirem

Re: [Qemu-devel] [PATCH 3/9] two new file wrappers

2013-03-13 Thread Eric Blake
On 03/13/2013 12:56 PM, Joel Schopp wrote: > Add a 3 very short file wrapper functions to make code that follows more s/a 3/3/ > readable. Also export an existing function that is currently static. > > Cc: Michael Tsirkin > Signed-off-by: Stefan Berger > Signed-off-by: Joel Schopp > --- > i

Re: [Qemu-devel] Problems with live migration

2013-03-13 Thread Eric Blake
On 03/13/2013 12:01 PM, Toni F. [ackstorm] wrote: > Hi all, > > I have working with Openstack Folsom and with Glusterfs as shared > storage for /instances. All working fine, but when i'm trying to use > "nova live-migration": > > 2013-03-07 18:33:42 3140 ERROR nova.virt.libvirt.driver [-] [instan

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 01:56:24PM -0500, Joel Schopp wrote: > Add a sized buffer interface to qapi. Isn't this just a special case of the visit_*_carray() interfaces? We should avoid new interfaces if possible, since it adds to feature disparities between visitor implementations. > > Cc: Michae

Re: [Qemu-devel] [PATCH 9/9] update_maintainers.diff

2013-03-13 Thread Eric Blake
On 03/12/2013 09:09 PM, Joel Schopp wrote: > Since I'm throwing all this code out there I'm also signing up to maintain it. > Send me your bug reports. > > Cc: Michael Tsirkin > Cc: Stefan Berger > Signed-off-by: Joel Schopp > --- > MAINTAINERS |8 > 1 file changed, 8 insertions(+

Re: [Qemu-devel] [PATCH 7/9] asn1_input-visitor.diff

2013-03-13 Thread Eric Blake
On 03/12/2013 09:09 PM, Joel Schopp wrote: > Implement an input visitor for ASN.1 BER encoding. > > Cc: Michael Tsirkin > Signed-off-by: Stefan Berger > Signed-off-by: Joel Schopp > --- > include/qapi/ber-input-visitor.h | 30 ++ > qapi/Makefile.objs |2 +- > qapi/ber-input

Re: [Qemu-devel] [PATCH 6/9] asn1_output-visitor.diff

2013-03-13 Thread Eric Blake
On 03/12/2013 09:09 PM, Joel Schopp wrote: > Implement an output visitor for ASN.1 BER encoding. > > Cc: Michael Tsirkin > Signed-off-by: Stefan Berger > Signed-off-by: Joel Schopp > --- > +++ b/include/qapi/ber-output-visitor.h > @@ -0,0 +1,28 @@ > +/* > + * BER Output Visitor header > + * >

Re: [Qemu-devel] [PATCH] Introduce query-cpu-max QMP command and cpu_max HMP counterpart

2013-03-13 Thread Eric Blake
On 03/12/2013 10:02 AM, Michal Novotny wrote: > This is the patch to introduce the query-cpu-max QMP command to get > the maximum number of CPUs supported by the currently running emulator > instance. This may differ machine from machine as defined by -machine > settings and max_cpus member of QEMU

Re: [Qemu-devel] [PATCH V9 12/14] block: move dump_human_image_info() to block/qapi.c

2013-03-13 Thread Eric Blake
On 03/11/2013 05:23 AM, Wenchao Xia wrote: > This function is needed later in hmp command, it is also renamed to > bdrv_image_info_dump(). > > Signed-off-by: Wenchao Xia > --- > block/qapi.c | 67 > include/block/qapi.h |1 + > qem

Re: [Qemu-devel] [PATCH V9 04/14] block: move collect_snapshots() and collect_image_info() to block/qapi.c

2013-03-13 Thread Eric Blake
On 03/12/2013 01:41 PM, Eric Blake wrote: > On 03/11/2013 05:23 AM, Wenchao Xia wrote: >> This patch adds block/qapi.c and moves the functions there. To avoid >> conflict and tip better, macro in header file is BLOCK_QAPI_H instead >> of QAPI_H. The moving is for making review easier, those funct

Re: [Qemu-devel] [PATCH 2/2] qga: add windows implementation for guest-set-time

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 06:10:31PM +0800, li...@linux.vnet.ibm.com wrote: > From: Lei Li > > Signed-off-by: Lei Li > --- > qga/commands-win32.c | 34 ++ > 1 files changed, 34 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-win32.c b/qga/commands-wi

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-13 Thread Eric Blake
On 03/13/2013 12:19 PM, Markus Armbruster wrote: > But this isn't relicensing. This is exercising your *right* to > incorporate permissively-licensed stuff into work covered by a > compatible, stronger license. That right was irrevocably granted to you > by the copyright holders. You don't have

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 03:07:52PM -0500, mdroth wrote: > On Wed, Mar 13, 2013 at 06:10:30PM +0800, li...@linux.vnet.ibm.com wrote: > > From: Lei Li > > > > Signed-off-by: Lei Li > > --- > > qga/commands-win32.c | 32 > > 1 files changed, 32 insertions(+), 0 d

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 06:10:30PM +0800, li...@linux.vnet.ibm.com wrote: > From: Lei Li > > Signed-off-by: Lei Li > --- > qga/commands-win32.c | 32 > 1 files changed, 32 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-win32.c b/qga/commands-win3

[Qemu-devel] [PATCH] virtio-pci: guest notifier mask without non-irqfd

2013-03-13 Thread Michael S. Tsirkin
non-irqfd setups are currently broken with vhost: we start up masked and nothing unmasks the interrupts. Fix by using mask notifiers, same as the irqfd path. Sharing irqchip/non irqchip code is always a good thing, in this case it will help non irqchip benefit from backend masking optimization. R

Re: [Qemu-devel] [PATCH 2/9] qapi_c_arrays.diff

2013-03-13 Thread Anthony Liguori
You need to adjust your patch script. This will make the summary in git be: qapi_c_arrays.gdiff Forward ported Mike's previously sent patch (see http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05782.html ) ... Regards, Anthony Liguori Joel Schopp writes: > Forward porte

[Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread Joel Schopp
This patch adds support functions for operating on in memory sized file buffers. Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- include/migration/qemu-file.h | 12 +++ include/qemu-common.h | 15 util/qemu-file.c | 184

[Qemu-devel] [PATCH 7/9] asn1_input-visitor.diff

2013-03-13 Thread Joel Schopp
Implement an input visitor for ASN.1 BER encoding. Cc: Michael Tsirkin Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- include/qapi/ber-input-visitor.h | 30 ++ qapi/Makefile.objs |2 +- qapi/ber-input-visitor.c | 1073 +++

[Qemu-devel] [PATCH 6/9] asn1_output-visitor.diff

2013-03-13 Thread Joel Schopp
Implement an output visitor for ASN.1 BER encoding. Cc: Michael Tsirkin Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- configure |2 +- include/qapi/ber-output-visitor.h | 28 ++ include/qapi/ber.h| 107 +++ qapi/Makefile.objs

[Qemu-devel] [PATCH 8/9] asn1_test_visitor_serialization.diff

2013-03-13 Thread Joel Schopp
Add BER Visitor hooks to test-visitor-serialization Cc: Michael Tsirkin Cc: Stefan Berger Signed-off-by: Joel Schopp --- tests/Makefile |2 +- tests/test-visitor-serialization.c | 72 2 files changed, 73 insertions(+), 1 deletion(-

[Qemu-devel] [PATCH 3/9] two new file wrappers

2013-03-13 Thread Joel Schopp
Add a 3 very short file wrapper functions to make code that follows more readable. Also export an existing function that is currently static. Cc: Michael Tsirkin Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- include/migration/qemu-file.h |3 +++ util/qemu-file.c

[Qemu-devel] [PATCH 1/9] qemu-file

2013-03-13 Thread Joel Schopp
This patch reorganizes qemu file operations to be in their own source file instead of being lumped in savevm.c. Besides being more logical for maintenance it also makes it easier for future users of the file functions to add tests. v4 move qemu-file.c into util/ , leave the bdrv functions where t

[Qemu-devel] [PATCH 9/9] update_maintainers.diff

2013-03-13 Thread Joel Schopp
Since I'm throwing all this code out there I'm also signing up to maintain it. Send me your bug reports. Cc: Michael Tsirkin Cc: Stefan Berger Signed-off-by: Joel Schopp --- MAINTAINERS |8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0ca7e1d..8a2f

[Qemu-devel] [PATCH 2/9] qapi_c_arrays.diff

2013-03-13 Thread Joel Schopp
Forward ported Mike's previously sent patch (see http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05782.html ) in my series since it implements a qapi array interface the ASN.1 BER visitor needs. Generally these will be serialized into lists, but the representation can be of any form so lon

[Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread Joel Schopp
Add a sized buffer interface to qapi. Cc: Michael Tsirkin Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- include/qapi/visitor-impl.h |2 ++ include/qapi/visitor.h |2 ++ qapi/qapi-visit-core.c |8 3 files changed, 12 insertions(+) diff --git a/inclu

[Qemu-devel] [PATCH 0/9 v3] Implement and test asn1 ber visitors

2013-03-13 Thread Joel Schopp
These patches implement asn1 ber visitors for encoding and decoding data. changed since v2: Moved qemu-file.c to util/ Left the bdrv functions in savevm.c Fixed a typo in the introduction to qapi c arrays patch Fixed two indendations in the qapi c arrays patch changed since v1: Moved .c files in

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Anthony Liguori
Paolo Bonzini writes: >> 1) It has no facility for timer events > > Yup, it's on the todo list. > >> 2) It's tied to file descriptors (only a problem for win32) > > The other way round: it's not tied to file descriptors for win32, > which is already a problem for e.g. networked backends. main-lo

[Qemu-devel] [PATCH v4] Move File operations to qemu-file.c

2013-03-13 Thread Joel Schopp
This patch reorganizes qemu file operations to be in their own source file instead of being lumped in savevm.c. Besides being more logical for maintenance it also makes it easier for future users of the file functions to add tests. v4 move qemu-file.c into util/ , leave the bdrv functions where t

[Qemu-devel] Problems with live migration

2013-03-13 Thread Toni F. [ackstorm]
Hi all, I have working with Openstack Folsom and with Glusterfs as shared storage for /instances. All working fine, but when i'm trying to use "nova live-migration": 2013-03-07 18:33:42 3140 ERROR nova.virt.libvirt.driver [-] [instance: 773164b5-5e5c-4328-a762-d91f50f2ac33] Live Migration fa

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.03.2013 um 06:01 hat Wenchao Xia geschrieben: >> Oops, Since it belongs to block layer I hope it can be LGPL2. Do you >> know how to contact Fabrice Bellard to ask for a change? > > Fabrice is not the only copyright owner of this file. > > Just copy the license as it

Re: [Qemu-devel] [PATCH v3] Move File operations to qemu-file.c

2013-03-13 Thread Joel Schopp
-util-obj-y = util/ qobject/ qapi/ trace/ +util-obj-y = util/ qobject/ qapi/ trace/ qemu-file.o Please either move it to util/ (and the include file to include/qemu/file.h), or leave it in common-obj-y. I prefer the former, since as a rule of thumb util-obj-y includes code that should be easy

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Wed, Mar 13, 2013 at 06:31:57PM +0100, Paolo Bonzini wrote: >> > We could do that purely >> > with AioContexts as well, but that rules out a large class of >> > backends that offloaded event loops can interact with, such as Chardevs, >> > so I think modelling how

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Paolo Bonzini
> 1) It has no facility for timer events Yup, it's on the todo list. > 2) It's tied to file descriptors (only a problem for win32) The other way round: it's not tied to file descriptors for win32, which is already a problem for e.g. networked backends. main-loop.c has the code that is needed,

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-13 Thread Markus Armbruster
Eric Blake writes: > On 03/11/2013 05:23 AM, Wenchao Xia wrote: >> This patch adds block/snapshot.c and then moves the function >> there. It also fixes small code style errors reported by check script. >> >> Signed-off-by: Wenchao Xia >> --- >> block/Makefile.objs |1 + >> block/sna

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Anthony Liguori
Paolo Bonzini writes: > Il 13/03/2013 18:23, Anthony Liguori ha scritto: >> I think the nesting is also a bit strange. > > Nesting's gone since we added coroutines. :) Okay, deeper isn't that hard apparently. There's not a lot in AioContext. Specifically: 1) It has no facility for timer event

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Michael S. Tsirkin
On Wed, Mar 13, 2013 at 06:31:57PM +0100, Paolo Bonzini wrote: > > We could do that purely > > with AioContexts as well, but that rules out a large class of > > backends that offloaded event loops can interact with, such as Chardevs, > > so I think modelling how to handle both will provide a thread

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Anthony Liguori
Paolo Bonzini writes: > Il 13/03/2013 18:23, Anthony Liguori ha scritto: >> I think the nesting is also a bit strange. > > Nesting's gone since we added coroutines. :) Okay, I owe AioContext a deeper look then. Regards, Anthony Liguori >>> I would like the dataplane virtio code to >>> grow ev

[Qemu-devel] [PATCH v6 3/3] qmp: add path to device_deleted event

2013-03-13 Thread Michael S. Tsirkin
Add QOM path to device deleted event. Signed-off-by: Michael S. Tsirkin --- QMP/qmp-events.txt | 4 +++- hw/qdev.c | 9 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index 24cf3e8..dcc826d 100644 --- a/QMP/qmp-events.txt

[Qemu-devel] [PATCH v6 2/3] qom: pass original path to unparent method

2013-03-13 Thread Michael S. Tsirkin
We need to know the original path since unparenting loses this state. Signed-off-by: Michael S. Tsirkin --- hw/qdev.c| 4 ++-- include/qom/object.h | 3 ++- qom/object.c | 4 +++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index bebc4

[Qemu-devel] [PATCH v6 0/3] DEVICE_DELETED event

2013-03-13 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. First patch only adds the event with ID, second patch adds a path field. Split this way for ease of backport (stable down

[Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-13 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- QMP/qmp-events.txt| 16 hw/qdev.c | 12 +

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 18:23, Anthony Liguori ha scritto: > I think the nesting is also a bit strange. Nesting's gone since we added coroutines. :) >> and AioContext's code is vastly simpler than GMainLoop's. > > For now. Fair enough. :) >> AioContext is also documented and unit tested, with tests >> f

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 18:06, mdroth ha scritto: > But isn't there also an effort to make virtio-blk/virtio-net a model for > threaded devices/subsystems in general, as opposed to "accelerators" for > specific use-cases like tap-based backends? I think this is the main > question, because most of the planni

Re: [Qemu-devel] [PATCH] chardev: add vte chardev

2013-03-13 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > >>> Also: Once I'm done with the console cleanup it will be easy to make >>> 'vc' actually work with gtk. >> >> Please no. 'vc' needs to die. I don't want anyone using it... > > Likewise easy. > 'vc' is a graphical chardev and it should be up to what UI la

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Anthony Liguori
Paolo Bonzini writes: > Il 13/03/2013 13:34, Anthony Liguori ha scritto: >> Paolo Bonzini writes: >> >>> Il 13/03/2013 06:59, Liu Ping Fan ha scritto: These series aim to port network backend onto glib, and prepare for moving towards making network layer mutlit-thread. The brief

Re: [Qemu-devel] [PATCH 17/20] qemu-char: move text console init to console.c

2013-03-13 Thread Anthony Liguori
Amit Shah writes: > From: Anthony Liguori > > Signed-off-by: Anthony Liguori > Signed-off-by: Amit Shah This patch broke vc switching in GTK. > --- > qemu-char.c | 1 - > ui/console.c | 7 +++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/qemu-char.c b/qemu-char.c

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 05:21:02PM +0100, Paolo Bonzini wrote: > Il 13/03/2013 13:34, Anthony Liguori ha scritto: > > Paolo Bonzini writes: > > > >> Il 13/03/2013 06:59, Liu Ping Fan ha scritto: > >>> These series aim to port network backend onto glib, and > >>> prepare for moving towards making

Re: [Qemu-devel] [PATCHv5 0/3] DEVICE_DELETED event

2013-03-13 Thread Michael S. Tsirkin
On Wed, Mar 13, 2013 at 08:45:51AM +0100, Markus Armbruster wrote: > Anthony asked for a space between "PATCH" and "v" in the subject. > Please try to remember next time. > > "Michael S. Tsirkin" writes: > > > libvirt has a long-standing bug: when removing the device, > > it can request removal

Re: [Qemu-devel] [PATCH] chardev: add vte chardev

2013-03-13 Thread Gerd Hoffmann
Hi, >> Also: Once I'm done with the console cleanup it will be easy to make >> 'vc' actually work with gtk. > > Please no. 'vc' needs to die. I don't want anyone using it... Likewise easy. >>> 'vc' is a graphical chardev and it should be up to what UI layer to >>> decide how to express it

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 13:34, Anthony Liguori ha scritto: > Paolo Bonzini writes: > >> Il 13/03/2013 06:59, Liu Ping Fan ha scritto: >>> These series aim to port network backend onto glib, and >>> prepare for moving towards making network layer mutlit-thread. >>> The brief of the whole aim and plan is doc

Re: [Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction

2013-03-13 Thread Hans de Goede
Looks good, Acked-by: Hans de Goede On 03/13/2013 04:58 PM, Alon Levy wrote: No change for 64 bit arches, but for 32 bit previously we zeroed half the surfaces cmd array, instead of all of it. Signed-off-by: Alon Levy --- hw/qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [Qemu-devel] [PATCH] chardev: add vte chardev

2013-03-13 Thread Anthony Liguori
Gerd Hoffmann writes: > On 03/13/13 13:29, Anthony Liguori wrote: >> Gerd Hoffmann writes: >> >>> Kill the dirty hack which hooks gtk vte initialization into the >>> qemu consoles subsystem. The vte terminals are not related to qemu >>> consoles at all. This simply doesn't belong there and it

[Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction

2013-03-13 Thread Alon Levy
No change for 64 bit arches, but for 32 bit previously we zeroed half the surfaces cmd array, instead of all of it. Signed-off-by: Alon Levy --- hw/qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index ef69348..4cbab45 100644 --- a/hw/qxl.c +++ b/hw/

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-13 Thread KONRAD Frédéric
On 13/03/2013 09:24, KONRAD Frédéric wrote: On 12/03/2013 17:31, Cornelia Huck wrote: On Tue, 12 Mar 2013 16:22:22 +0100 KONRAD Frédéric wrote: On 12/03/2013 16:12, Peter Maydell wrote: On 12 March 2013 15:08, KONRAD Frédéric wrote: On 12/03/2013 15:42, Peter Maydell wrote: Yes, I see you

Re: [Qemu-devel] Block I/O optimizations

2013-03-13 Thread Stefan Hajnoczi
On Thu, Feb 21, 2013 at 9:11 AM, Stefan Hajnoczi wrote: > On Mon, Feb 18, 2013 at 7:19 PM, Loic Dachary wrote: >> I recently tried to figure out the best and easiest ways to increase block >> I/O performances with qemu. Not being a qemu expert, I expected to find a >> few optimization tricks. M

[Qemu-devel] [PATCH] qemu-iotests: add tests for rebasing zero clusters

2013-03-13 Thread Paolo Bonzini
If zero clusters are erroneously treated as unallocated, "qemu-img rebase" will copy the backing file's contents onto the cluster. The bug existed also in image streaming, but since the root cause was in qcow2's is_allocated implementation it is enough to test it with qemu-img. Signed-off-by: Pao

Re: [Qemu-devel] [RFC PATCH 8/8] libqos: add malloc

2013-03-13 Thread Anthony Liguori
Kevin Wolf writes: > Am 05.03.2013 um 14:53 hat Anthony Liguori geschrieben: >> Signed-off-by: Anthony Liguori > >> --- /dev/null >> +++ b/tests/libqos/malloc.h >> @@ -0,0 +1,26 @@ >> +#ifndef LIBQOS_MALLOC_H >> +#define LIBQOS_MALLOC_H >> + >> +#include >> +#include >> + >> +typedef struct QG

[Qemu-devel] [PATCH] dataplane: fix hang introduced by AioContext transition

2013-03-13 Thread Paolo Bonzini
The bug is that the EventNotifiers do have a NULL io_flush callback. Because _none_ of the callbacks on the dataplane AioContext have such a callback, aio_poll will simply do nothing. Fixed by adding the callbacks: the ioeventfd will always be polled (this can change in the future to pause/resume

Re: [Qemu-devel] [PATCH] chardev: add vte chardev

2013-03-13 Thread Gerd Hoffmann
On 03/13/13 13:29, Anthony Liguori wrote: > Gerd Hoffmann writes: > >> Kill the dirty hack which hooks gtk vte initialization into the >> qemu consoles subsystem. The vte terminals are not related to qemu >> consoles at all. This simply doesn't belong there and it stands in >> the way when clea

Re: [Qemu-devel] [RFC PATCH 1/8] qtest: add libqos

2013-03-13 Thread Anthony Liguori
Kevin Wolf writes: > Am 05.03.2013 um 14:53 hat Anthony Liguori geschrieben: >> This includes basic PCI support. >> >> Signed-off-by: Anthony Liguori > >> +static void *qpci_pc_iomap(QPCIBus *bus, QPCIDevice *dev, int barno) >> +{ >> +QPCIBusPC *s = container_of(bus, QPCIBusPC, bus); >> +

[Qemu-devel] [PATCH 7/7] usb-redir: Add flow control support

2013-03-13 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/redirect.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index c519b9b..9ba714d 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -104,6 +104,8 @@ struct US

[Qemu-devel] [PATCH 6/7] spice-qemu-char.c: Remove intermediate buffer

2013-03-13 Thread Hans de Goede
From: Alon Levy virtio-serial's buffer is valid when it calls us, and we don't access it otherwise: vmc_read is only called in response to wakeup, or else we set datalen=0 and throttle. Then vmc_read is called back, we return 0 (not accessing the buffer) and set the timer to unthrottle. Also mak

[Qemu-devel] [PATCH 4/7] spice-qemu-char: Remove dead debugging code

2013-03-13 Thread Hans de Goede
Since commit d62e5f7036a018b2ad09f17ebd481bd28953d783 "chardev: add spice support to qapi" It is impossible to set the debug parameter, so all the dprintf calls are essentially nops. Since we've not needed the debug parameter in ages this is not a problem, if it later turns out we do need some mor

[Qemu-devel] [PATCH 1/7] virtio-console: Also throttle when less was written then requested

2013-03-13 Thread Hans de Goede
This is necessary so that we get properly woken up to write the rest. Signed-off-by: Hans de Goede Acked-by: Amit Shah --- hw/virtio-console.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index e2d1c58..1d87c5b 100644 --- a/h

[Qemu-devel] [PATCH 5/7] spice-qemu-char: Add watch support

2013-03-13 Thread Hans de Goede
Signed-off-by: Hans de Goede --- spice-qemu-char.c | 67 +++ 1 file changed, 63 insertions(+), 4 deletions(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 8a9236d..e9eea0d 100644 --- a/spice-qemu-char.c +++ b/spice-qemu-char.c @@ -1

[Qemu-devel] [PATCH 3/7] spice-qemu-char: Fix name parameter issues after qapi-ifying

2013-03-13 Thread Hans de Goede
The strings passed in through the qapi calls are dynamic memory, since we want to have them stick around longer then just the call to qemu_chr_open_spice_* we need to strdup them. Signed-off-by: Hans de Goede --- spice-qemu-char.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) d

[Qemu-devel] [PATCH 2/7] virtio-console: Remove any pending watches on close

2013-03-13 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/virtio-console.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 1d87c5b..ec0f91b 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -18,6 +18,7 @@ typedef struct

[Qemu-devel] [PATCH 0/7] Spice / usb-redir chardev flowcontrol patches

2013-03-13 Thread Hans de Goede
Here is a series adding watch support to the spicevmc chardev backend and flowcontrol support to the usb-redir device. It begins with a few chardev related bugfixes which were found during the development of this series. Note that this series is based *on top of* Gerd Hoffmann's chardev.4 series t

Re: [Qemu-devel] [PATCH v2 0/9] tcg-arm improvements

2013-03-13 Thread Laurent Desnogues
On Tue, Mar 12, 2013 at 7:43 AM, Richard Henderson wrote: > Changes v1-v2: > * Use more helper functions to handle K and N constraints. > * Improve add2/sub2. > * Improve epilogues, as suggested in the previous thread. > * Fix a typo in the name of the deposit helper. > * Implement divis

Re: [Qemu-devel] [RFC PATCH 8/8] libqos: add malloc

2013-03-13 Thread Kevin Wolf
Am 05.03.2013 um 14:53 hat Anthony Liguori geschrieben: > Signed-off-by: Anthony Liguori > --- /dev/null > +++ b/tests/libqos/malloc.h > @@ -0,0 +1,26 @@ > +#ifndef LIBQOS_MALLOC_H > +#define LIBQOS_MALLOC_H > + > +#include > +#include > + > +typedef struct QGuestAllocator QGuestAllocator; > +

Re: [Qemu-devel] [PATCH v2 0/7] threadpool: support multiple ThreadPools

2013-03-13 Thread Stefan Hajnoczi
On Thu, Mar 07, 2013 at 01:41:43PM +0100, Stefan Hajnoczi wrote: > This patch series changes the global thread pool to a one ThreadPool per > AioContext model. We still only use the main loop AioContext so in practice > there is just one ThreadPool. But this opens the door to refactoring the > b

Re: [Qemu-devel] cg6 implementation in QEMU

2013-03-13 Thread Jean-Michel SCHRAMM
Hi Artyom, Hi Artyom, Thanks again for your interest. Le 07/03/2013 23:58, Artyom Tarasenko a écrit : Hi Jean Michel, On Thu, Mar 7, 2013 at 4:09 PM, Jean-Michel SCHRAMM wrote: Hello Artyom, Thanks for taking time to consider my needs for serial ports. I went on board Thalassa this mo

Re: [Qemu-devel] [PATCH] Added cleanup for Win32 TAP interface

2013-03-13 Thread Stefan Hajnoczi
On Wed, Mar 13, 2013 at 04:23:52PM +0400, Pavel Dovgaluk wrote: > Added cleanup for Win32 TAP interface. > > Signed-off-by: Pavel Dovgalyuk > --- > net/tap-win32.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/net/tap-win32.c b/net/tap-win32.c > index 91e9e

  1   2   >