Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-06 Thread Lei Li
On 03/06/2013 11:31 PM, Eric Blake wrote: On 03/06/2013 06:45 AM, Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-win32.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 7e8ecb3..4febe

[Qemu-devel] [PATCH] Fix the wrong description in qemu manual

2013-03-06 Thread Lei Li
Fix LP#1151450 the wrong description in qemu manual: 'qemu-system-x86_84' should be 'qemu-system-x86_64'. Signed-off-by: Lei Li --- qemu-options.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 6f9334a..cd76f2a 100644 --- a/qem

Re: [Qemu-devel] [PATCH v6 08/24] hw/arm: add Faraday FTRTC011 RTC timer support

2013-03-06 Thread Paolo Bonzini
> From Makefile.target, qtest is built when you build softmmu target. > I guess there is no need to add "--enable-qtest" option. However, I > don't know how to run qtest... make check-qtest-arm Paolo

Re: [Qemu-devel] [PATCH V12 0/4] replace QEMUOptionParameter with QemuOpts parser

2013-03-06 Thread Markus Armbruster
Stefan Hajnoczi writes: > Looks fine at the high level. Markus had specific comments in the last > version, please wait for his review before applying. I intend to review it again. Unfortunately, I'm struggling with getting my review queue under control. Please be patient.

Re: [Qemu-devel] [PATCH V8 00/20] qmp/hmp interfaces for internal snapshot info

2013-03-06 Thread Markus Armbruster
I intend to review at least the QMP interfaces. Unfortunately, I'm struggling with getting my review queue under control. Please be patient.

Re: [Qemu-devel] [PATCH] Fix TAGS creation

2013-03-06 Thread Markus Armbruster
David Gibson writes: > Currently the Makefile creates TAGS for emacs with the command: > find "$(SRC_PATH)" -name '*.[hc]' -print0 | xargs -0 etags > That works only if xargs ends up invoking etags just once. If xargs runs > etags several times, as it will if there are enough files, then the

Re: [Qemu-devel] [PATCH v6 08/24] hw/arm: add Faraday FTRTC011 RTC timer support

2013-03-06 Thread Wei-Ren Chen
> Excuse me, could you please show me the way how to build the test cases > and launch the test case. > > I do have found a web page to qtest at the following link: > http://wiki.qemu.org/Features/QTest > > But it's wrong at both 'build/example usage' and 'Additional > Details/Status', please se

Re: [Qemu-devel] [PATCH v6 08/24] hw/arm: add Faraday FTRTC011 RTC timer support

2013-03-06 Thread Paolo Bonzini
Il 07/03/2013 07:39, Kuo-Jung Su ha scritto: > I do have found a web page to qtest at the following link: > http://wiki.qemu.org/Features/QTest > > But it's wrong at both 'build/example usage' and 'Additional > Details/Status', please see the logs bellow: > > dante@vmware:/pub/qemu$ ./configure

Re: [Qemu-devel] [Qemu-stable] [SeaBIOS] problems with freeBSD

2013-03-06 Thread Michael Tokarev
07.03.2013 10:12, Doug Goldstein wrote: > On Wed, Mar 6, 2013 at 7:58 PM, Peter Stuge wrote: >> Yeah, it is very common. Lots of distributions patch their >> toolchains such that they don't compile firmware code correctly. >> >> Firmware isn't a common target, so I understand that it happens. >>

[Qemu-devel] qemu-img do not verify encrytption

2013-03-06 Thread yue-kvm
i create qcow2 format image with -o encryption, and assign password. but when i qemu-img info encryt.qcow2 , it display encryt.qcow2 info no master what i input, even just hit enter. the 'Password Authentication ' of qemu-img may be invalid. thanks. my steps: Create an encrypted

[Qemu-devel] [PATCH V8 20/20] block: rename bdrv_query_info() to bdrv_query_block_info()

2013-03-06 Thread Wenchao Xia
Now that we have bdrv_query_image_info, rename this function to make it more obvious what it is doing. Reviewed-by: Eric Blake Signed-off-by: Wenchao Xia --- block.c |4 ++-- include/block/block.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bloc

[Qemu-devel] [PATCH V8 16/20] hmp: add command info images

2013-03-06 Thread Wenchao Xia
This command will show block image's information, including internal snapshots. Signed-off-by: Wenchao Xia --- hmp.c | 38 ++ hmp.h |1 + monitor.c |7 +++ 3 files changed, 46 insertions(+), 0 deletions(-) diff --git a/hmp.c b/hmp.c in

Re: [Qemu-devel] [PATCH v6 08/24] hw/arm: add Faraday FTRTC011 RTC timer support

2013-03-06 Thread Kuo-Jung Su
2013/3/6 Paolo Bonzini : > Il 06/03/2013 08:27, Kuo-Jung Su ha scritto: >> It provides separate second, minute, hour, and day counters. The second >> counter is toggled each second, the minute counter is toggled each minute, >> the hour counter is toggled each hour, and the day counter is toggled e

[Qemu-devel] [PATCHv3 1/2] bridge helper: unified error cleanup for parse_acl_file

2013-03-06 Thread Doug Goldstein
Handle errors and cleanup from the error in a unified place for parse_acl_file(). Signed-off-by: Doug Goldstein CC: Anthony Liguori CC: Richa Marwaha CC: Corey Bryant TO: qemu-devel@nongnu.org --- qemu-bridge-helper.c | 28 1 file changed, 16 insertions(+), 12 del

Re: [Qemu-devel] [Qemu-stable] [SeaBIOS] problems with freeBSD

2013-03-06 Thread Peter Maydell
On 7 March 2013 14:12, Doug Goldstein wrote: > On Wed, Mar 6, 2013 at 7:58 PM, Peter Stuge wrote: >> For coreboot we recommend to build a vanilla toolchain using known >> good versions. We also have a script to do that. (The script is at >> util/crossgcc/buildgcc in the coreboot repo.) > Would q

[Qemu-devel] [PATCHv3 2/2] bridge helper: support conf dirs

2013-03-06 Thread Doug Goldstein
Allow the bridge helper to take a config directory rather than having to specify every file in the directory manually via an include statement. Signed-off-by: Doug Goldstein CC: Anthony Liguori CC: Richa Marwaha CC: Corey Bryant TO: qemu-devel@nongnu.org --- qemu-bridge-helper.c | 55

[Qemu-devel] [PATCHv3 0/2] bridge helper: includedir conf arg

2013-03-06 Thread Doug Goldstein
The goal is to support an 'includedir' to include all files within a directory specified in the bridge.conf file. The rationale is to allow libvirt to be able to configure interfaces to for use by unprivileged users by just simply generating a new configuration file to the directory. Change from v

Re: [Qemu-devel] [Qemu-stable] [SeaBIOS] problems with freeBSD

2013-03-06 Thread Doug Goldstein
On Wed, Mar 6, 2013 at 7:58 PM, Peter Stuge wrote: > Laszlo Ersek wrote: >> Going out on a limb, I suspect qemu commit 5f876756 instead. > .. >> I think the gcc version Anthony was using miscompiled SeaBIOS > > Yeah, it is very common. Lots of distributions patch their > toolchains such that they

[Qemu-devel] [PATCH V8 18/20] block: move snapshot related functions to block/snapshot.c

2013-03-06 Thread Wenchao Xia
bdrv_snapshots() ref to a static variable used by other functions in block.c, and it returns *bs like a general block function, so this function was not moved to avoid trouble. bdrv_snapshot_dump() will goto block/api.c later, and block/snapshot.h is included to make build pass for it, which will

[Qemu-devel] [PATCH V8 19/20] block: move bdrv_snapshot_dump() to block/qapi.c

2013-03-06 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- block.c | 33 - block/qapi.c | 33 + include/block/block.h |2 -- include/block/block_int.h |1 + include/block/qapi.h |2 ++ 5 files changed, 36

[Qemu-devel] [PATCH V8 14/20] block: move dump_human_image_info() to block/qapi.c

2013-03-06 Thread Wenchao Xia
This function is needed later in hmp command, it is also renamed to for bdrv_image_info_dump(). Signed-off-by: Wenchao Xia --- block/qapi.c | 67 include/block/qapi.h |1 + qemu-img.c | 69 +-

[Qemu-devel] [PATCH V8 15/20] block: dump to buffer for bdrv_image_info_dump()

2013-03-06 Thread Wenchao Xia
This allow hmp use this function, just like qemu-img. Signed-off-by: Wenchao Xia --- block/qapi.c | 67 +++-- include/block/qapi.h |2 +- qemu-img.c |6 +++- 3 files changed, 54 insertions(+), 21 deletions(-) diff --git a

[Qemu-devel] [PATCH V8 01/20] build: add block/snapshot.c

2013-03-06 Thread Wenchao Xia
This file will have internal snapshot related functions. Signed-off-by: Wenchao Xia --- block/Makefile.objs |1 + block/snapshot.c | 14 ++ include/block/snapshot.h |4 3 files changed, 19 insertions(+), 0 deletions(-) create mode 100644 block/snapshot.

[Qemu-devel] [PATCH V8 10/20] qmp: add interface query-snapshots

2013-03-06 Thread Wenchao Xia
This interface now return valid internal snapshots for whole vm. Signed-off-by: Wenchao Xia --- block/qapi.c | 22 + qapi-schema.json | 14 + qmp-commands.hx | 55 ++ 3 files changed, 91 insertions(+

[Qemu-devel] [PATCH V8 13/20] hmp: switch snapshot info function to qmp based one

2013-03-06 Thread Wenchao Xia
This patch using new added function in last commit which retrieve info from qmp for snapshot info. Signed-off-by: Wenchao Xia --- monitor.c |2 +- savevm.c | 64 - 2 files changed, 1 insertions(+), 65 deletions(-) diff --git a

[Qemu-devel] [PATCH V8 17/20] block: return bool for bdrv_can_snapshot()

2013-03-06 Thread Wenchao Xia
This function should return bool instead of int, just as bdrv_can_read_snapshot(). Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- block.c |8 include/block/block.h |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c in

[Qemu-devel] [PATCH V8 09/20] block: add image info query function bdrv_query_image_info()

2013-03-06 Thread Wenchao Xia
This patch adds function bdrv_query_image_info(), which will retrieve image info in qmp object format. The implementation are based on the code moved from qemu-img.c, but use block layer function to get snapshot info. Signed-off-by: Wenchao Xia --- block/qapi.c | 39 +

[Qemu-devel] [PATCH V8 06/20] block: move collect_snapshots() and collect_image_info() to block/qapi.c

2013-03-06 Thread Wenchao Xia
This patch is just for making review easier, those two functions will be modified and renamed later. Signed-off-by: Wenchao Xia --- block/qapi.c | 82 +++ include/block/qapi.h |8 + qemu-img.c | 86 ++

[Qemu-devel] [PATCH V8 12/20] hmp: add function hmp_info_snapshots()

2013-03-06 Thread Wenchao Xia
This function will simply call qmp interface qmp_query_snapshots() added in last commit and then dump information in monitor console. To get snapshot info, Now qemu and qemu-img both call block layer function bdrv_query_snapshot_info_list() in their calling path, and then they just translate th

[Qemu-devel] [PATCH V8 11/20] qmp: add interface query-images

2013-03-06 Thread Wenchao Xia
This mirror function will return image info including snapshots, if specified backing image's info will also be returned. Now Qemu have both query-images and query-block interfaces. Signed-off-by: Wenchao Xia --- block/qapi.c | 83 qap

[Qemu-devel] [PATCH V8 05/20] qemu-img: remove unused parameter in collect_image_info()

2013-03-06 Thread Wenchao Xia
Parameter *fmt was not used, so remove it. Reviewed-by: Eric Blake Signed-off-by: Wenchao Xia --- qemu-img.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 471de7d..f4e5d90 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1640,8 +1640,7

[Qemu-devel] [PATCH V8 04/20] block: distinguish id and name in bdrv_find_snapshot()

2013-03-06 Thread Wenchao Xia
To make it clear about id and name in searching, the API was changed a bit to distinguish them. Caller can choose to search by id or name now. Searching will be done with higher priority of id. This function also return negative value from bdrv_snapshot_list() instead of -ENOENT on error. Signed

[Qemu-devel] [PATCH V8 00/20] qmp/hmp interfaces for internal snapshot info

2013-03-06 Thread Wenchao Xia
In the use of snapshot a way to retrieve related info at runtime is needed, so this serial of patches will merge some code for qemu and qemu-img, and add following interfaces for qemu: 1) qmp: query-images, show image info for a block device Example: -> { "execute": "query-images" } <- { "

[Qemu-devel] [PATCH V8 08/20] block: add filter for vm snapshot in bdrv_query_snapshot_info_list()

2013-03-06 Thread Wenchao Xia
This patch adds a parameter to tell whether return valid snapshots for whole VM only. Signed-off-by: Wenchao Xia --- block/qapi.c | 39 +-- include/block/qapi.h |1 + qemu-img.c |3 ++- 3 files changed, 40 insertions(+), 3 deletio

[Qemu-devel] [PATCH V8 07/20] block: add snapshot info query function bdrv_query_snapshot_info_list()

2013-03-06 Thread Wenchao Xia
This patch adds function bdrv_query_snapshot_info_list(), which will retrieve snapshot info of an image in qmp object format. The implementation is based on the code moved from qemu-img.c with modification to fit more for qmp based block layer API. Signed-off-by: Wenchao Xia --- block/qapi.c

[Qemu-devel] [PATCH V8 03/20] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-06 Thread Wenchao Xia
This patch also fix small code style error reported by check script. Signed-off-by: Wenchao Xia --- block/snapshot.c | 23 +++ include/block/snapshot.h |9 + savevm.c | 23 +-- 3 files changed, 33 insertions(+), 22

[Qemu-devel] [PATCH V8 02/20] build: add block/qapi.c

2013-03-06 Thread Wenchao Xia
This file will have qmp related functions for block. To avoid conflict and tip better, macro in header file is BLOCK_QAPI_H instead of QAPI_H. Signed-off-by: Wenchao Xia --- block/Makefile.objs |2 +- block/qapi.c | 14 ++ include/block/qapi.h |4 3 files ch

Re: [Qemu-devel] [PATCH v6 07/24] hw/arm: add Faraday FTWDT010 watchdog timer support

2013-03-06 Thread Kuo-Jung Su
2013/3/7 Kuo-Jung Su : > 2013/3/6 Paolo Bonzini : >>> > > It doesn't work while running under ROM mode. ( no -kernel ) >>> > > Because Faraday SoC Platform usually designed to boot from ROM and >>> > > followed by an AHB remapping process (i.e. remap ROM/RAM address). >>> > >>> > What doesn't work

[Qemu-devel] [Bug 668799] Re: qemu-arm segfaults executing msgmerge (gettext)

2013-03-06 Thread Peter Maydell
** Changed in: qemu-linaro Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/668799 Title: qemu-arm segfaults executing msgmerge (gettext) Status in QEMU: Fix Commi

Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

2013-03-06 Thread Kuo-Jung Su
2013/3/7 Peter Crosthwaite : > Hi Peter, Kuo-Jung, > > On Thu, Mar 7, 2013 at 12:28 PM, Peter Maydell > wrote: >> On 7 March 2013 10:18, Peter Crosthwaite >> wrote: >>> This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in >>> v5, I realise the desire to fix this properly by re

[Qemu-devel] propose to implement ower device

2013-03-06 Thread li guang
Hi, Anthony and all By now all devices of QEMU do not have much more power management consideration, for example, if system do suspend, it will call all registered notifiers, this was loosely required, and the code to do power management state transition seems just do 'ugly emulation', rather than

Re: [Qemu-devel] [PATCH v6 11/24] hw/nand.c: correct the sense of the BUSY/READY status bit

2013-03-06 Thread Kuo-Jung Su
2013/3/7 Peter Crosthwaite : > Hi Kuo Jung, Peter, > > This patch fixes bugs for us in Zynq Nand (cc Wendy Liang). Can we get > a cherry pick of this? > Why not? Please go ahead. > Regards, > Peter > > On Wed, Mar 6, 2013 at 5:27 PM, Kuo-Jung Su wrote: >> The BIT6 of Status Register(SR): >> >> S

Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

2013-03-06 Thread Kuo-Jung Su
2013/3/7 Peter Maydell : > On 7 March 2013 10:18, Peter Crosthwaite wrote: >> This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in >> v5, I realise the desire to fix this properly by rewriting that >> if-else mess, but can we get a merge on this one more immediately to >> get QEM

[Qemu-devel] [PATCH] Use proper term in TCG README

2013-03-06 Thread Wei-Ren Chen
In TCG, "target" means the host architecture for which TCG generates the code. Using "guest" rather than "target" to make the document more consistent. Signed-off-by: Chen Wei-Ren --- tcg/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/README b/tcg/README index 9

Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

2013-03-06 Thread Peter Crosthwaite
Hi Peter, Kuo-Jung, On Thu, Mar 7, 2013 at 12:28 PM, Peter Maydell wrote: > On 7 March 2013 10:18, Peter Crosthwaite wrote: >> This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in >> v5, I realise the desire to fix this properly by rewriting that >> if-else mess, but can we get

Re: [Qemu-devel] [PATCH v6 17/24] qemu/bitops.h: add the bit ordering reversal functions stolen from linux

2013-03-06 Thread Kuo-Jung Su
2013/3/6 Paolo Bonzini : > Il 06/03/2013 08:27, Kuo-Jung Su ha scritto: >> Signed-off-by: Kuo-Jung Su >> --- >> include/qemu/bitops.h | 63 >> - >> 1 file changed, 62 insertions(+), 1 deletion(-) >> >> diff --git a/include/qemu/bitops.h b/include

[Qemu-devel] [PATCH v2 5/5] net: make netclient re-entrant with refcnt

2013-03-06 Thread Liu Ping Fan
From: Liu Ping Fan With refcnt, NetClientState's caller can run agaist reclaimer. Signed-off-by: Liu Ping Fan --- hw/qdev-properties-system.c | 14 + include/net/net.h |3 ++ net/hub.c |3 ++ net/net.c | 46 +

[Qemu-devel] [PATCH v2 4/5] net: introduce lock to protect NetClientState's peer's access

2013-03-06 Thread Liu Ping Fan
From: Liu Ping Fan Introduce nc->send_lock, it shield off the race of nc->peer's reader and deleter. With it, after deleter finish, no new qemu_send_packet_xx() can reach ->send_queue, so no new reference(packet->sender) to nc will be appended to nc->peer->send_queue. Signed-off-by: Liu Ping Fan

[Qemu-devel] [PATCH v2 3/5] net: introduce lock to protect NetQueue

2013-03-06 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- net/queue.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/net/queue.c b/net/queue.c index 67959f8..f7ff020 100644 --- a/net/queue.c +++ b/net/queue.c @@ -53,6 +53,7 @@ struct NetQueue { uint32_t nq_max

[Qemu-devel] [PATCH v2 2/5] net: hub use lock to protect ports list

2013-03-06 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- net/hub.c | 27 ++- 1 files changed, 26 insertions(+), 1 deletions(-) diff --git a/net/hub.c b/net/hub.c index 73c1f26..47fe72c 100644 --- a/net/hub.c +++ b/net/hub.c @@ -39,6 +39,8 @@ struct NetHub { int id;

[Qemu-devel] [PATCH v2 1/5] net: spread hub on AioContexts

2013-03-06 Thread Liu Ping Fan
From: Liu Ping Fan Forward packet to other hub ports by their AioContext. Signed-off-by: Liu Ping Fan --- hw/qdev-properties-system.c |1 + include/block/aio.h |1 + include/net/net.h |5 + include/net/queue.h | 14 ++ main-loop.c

[Qemu-devel] [PATCH v2 0/5] make netlayer re-entrant

2013-03-06 Thread Liu Ping Fan
From: Liu Ping Fan changes v1->v2 Because the NetQueue is exposed not just from qemu_send_queue_xx(), so separating locks -- use NetQueue(NetQueue->lock) to protect the queue, and use nc->send_lock for the access of nc->peer so we can protect the sender from the remover. Question: Us

[Qemu-devel] [PATCH] Fix TAGS creation

2013-03-06 Thread David Gibson
Currently the Makefile creates TAGS for emacs with the command: find "$(SRC_PATH)" -name '*.[hc]' -print0 | xargs -0 etags That works only if xargs ends up invoking etags just once. If xargs runs etags several times, as it will if there are enough files, then the later invocations will overwri

Re: [Qemu-devel] [PATCH v6 07/24] hw/arm: add Faraday FTWDT010 watchdog timer support

2013-03-06 Thread Kuo-Jung Su
2013/3/6 Paolo Bonzini : >> > > It doesn't work while running under ROM mode. ( no -kernel ) >> > > Because Faraday SoC Platform usually designed to boot from ROM and >> > > followed by an AHB remapping process (i.e. remap ROM/RAM address). >> > >> > What doesn't work exactly? Why aren't these cal

Re: [Qemu-devel] default guest RAM size?

2013-03-06 Thread Anthony Liguori
Peter Maydell writes: > On 5 March 2013 13:26, Michael Tokarev wrote: >> For many years, qemu defaults to 128Mb of guest RAM size. >> Today, this is just too small, and many OSes fails to boot >> with this size, more, they fail to produce any reasonable >> messages either (eg, windows7 just cras

Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

2013-03-06 Thread Peter Maydell
On 7 March 2013 10:18, Peter Crosthwaite wrote: > This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in > v5, I realise the desire to fix this properly by rewriting that > if-else mess, but can we get a merge on this one more immediately to > get QEMU working again? Rewriting this

Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions

2013-03-06 Thread Peter Maydell
On 7 March 2013 10:00, Peter Crosthwaite wrote: > Not 100% accurate. My goal here it to control (or wrap) only guest > accesses, in the first instance via the Memory API, but other forms of > guest access are perfectly valid as well, and PCI config space, would > be a good example. If we are going

Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

2013-03-06 Thread Peter Crosthwaite
Hi Kuo Jung, Peter, This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in v5, I realise the desire to fix this properly by rewriting that if-else mess, but can we get a merge on this one more immediately to get QEMU working again? Rewriting this is probably not at the top of eithe

Re: [Qemu-devel] [PATCH v6 11/24] hw/nand.c: correct the sense of the BUSY/READY status bit

2013-03-06 Thread Peter Crosthwaite
Hi Kuo Jung, Peter, This patch fixes bugs for us in Zynq Nand (cc Wendy Liang). Can we get a cherry pick of this? Regards, Peter On Wed, Mar 6, 2013 at 5:27 PM, Kuo-Jung Su wrote: > The BIT6 of Status Register(SR): > > SR[6] behaves the same as R/B# pin > SR[6] = 0 indicates the device is b

Re: [Qemu-devel] [PATCH 0/3] *** make netlayer re-entrant ***

2013-03-06 Thread liu ping fan
On Wed, Mar 6, 2013 at 5:30 AM, mdroth wrote: > On Sun, Mar 03, 2013 at 09:21:19PM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> This series aim to make netlayer re-entrant, so netlayer can >> run out of biglock safely. > > I think most of the locking considerations are still applicable

Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions

2013-03-06 Thread Peter Crosthwaite
Hi All, I have brought myself up to speed with this PCI stuff. First of all I am assuming you are talking about the PCI Config space only? This (hw/pci.h): struct PCIDevice { DeviceState qdev; /* PCI config space */ uint8_t *config; [snip] /* Used to implement RW1C(Write 1 t

Re: [Qemu-devel] [RFC v1 3/3] make address_space_map safe

2013-03-06 Thread liu ping fan
On Wed, Feb 13, 2013 at 8:12 PM, Vasilis Liaskovitis wrote: > Hi, > > I am looking at this old ref/unref patchset for safely removing hot-plugged > dimms/MemoryRegions. I am not sure if the set is still actively worked on or > relevant for qemu-master, but I had a small comment below: > > On Fri,

Re: [Qemu-devel] [SeaBIOS] problems with freeBSD

2013-03-06 Thread Peter Stuge
Laszlo Ersek wrote: > Going out on a limb, I suspect qemu commit 5f876756 instead. .. > I think the gcc version Anthony was using miscompiled SeaBIOS Yeah, it is very common. Lots of distributions patch their toolchains such that they don't compile firmware code correctly. Firmware isn't a common

Re: [Qemu-devel] default guest RAM size?

2013-03-06 Thread Peter Maydell
On 7 March 2013 09:21, Rob Landley wrote: > On 03/06/2013 12:34:53 PM, Peter Maydell wrote: >> On 6 March 2013 11:59, Rob Landley wrote: >> > 256 can be handled by most things. >> >> I'm going to take a wild guess that Windows 7 doesn't do any >> better in 256MB than it does with 128 :-) > > > Wh

Re: [Qemu-devel] problems with freeBSD

2013-03-06 Thread Laszlo Ersek
On 03/07/13 01:53, Kevin O'Connor wrote: > On Thu, Mar 07, 2013 at 12:12:08AM +0100, Aurelien Jarno wrote: >> On Wed, Mar 06, 2013 at 08:21:11AM +, Dietmar Maurer wrote: >>> Using qemu 1.4.0: >>> >>> # qemu -hda test.raw -m 512 -cdrom >>> pfSense-LiveCD-2.0.2-RELEASE-amd64-20121207-2239.iso >>

Re: [Qemu-devel] default guest RAM size?

2013-03-06 Thread Rob Landley
On 03/06/2013 12:34:53 PM, Peter Maydell wrote: On 6 March 2013 11:59, Rob Landley wrote: > On 03/05/2013 12:09:27 AM, Peter Maydell wrote: >> On 5 March 2013 14:07, 陳韋任 (Wei-Ren Chen) >> wrote: >> > On Tue, Mar 05, 2013 at 01:40:38PM +0800, Peter Maydell wrote: >> >> On 5 March 2013 13:26,

Re: [Qemu-devel] [Seabios PATCH v2] make reboot-timeout to static for using it after POST phase

2013-03-06 Thread Kevin O'Connor
On Tue, Mar 05, 2013 at 05:52:21PM +0800, Amos Kong wrote: > From: Kevin O'Connor > > Memory allocated with malloc_tmp() can't be used after the POST > phase. The reboot-timeout inside romfile could not be loaded in > boot_fail(). The patch saved reboot-timeout to a static variable, > it fixed th

Re: [Qemu-devel] problems with freeBSD

2013-03-06 Thread Kevin O'Connor
On Thu, Mar 07, 2013 at 12:12:08AM +0100, Aurelien Jarno wrote: > On Wed, Mar 06, 2013 at 08:21:11AM +, Dietmar Maurer wrote: > > Using qemu 1.4.0: > > > > # qemu -hda test.raw -m 512 -cdrom > > pfSense-LiveCD-2.0.2-RELEASE-amd64-20121207-2239.iso > > > > Results in: > > > > trap 12: page f

Re: [Qemu-devel] [PATCH v2 3/3] qga: implement qmp_guest_set_vcpus() for Linux with sysfs

2013-03-06 Thread Laszlo Ersek
On 03/07/13 00:20, Eric Blake wrote: > On 03/06/2013 02:59 PM, Laszlo Ersek wrote: >> Signed-off-by: Laszlo Ersek >> --- >> qga/commands-posix.c | 38 -- >> 1 files changed, 32 insertions(+), 6 deletions(-) >> >> >> +int64_t qmp_guest_set_vcpus(GuestLogical

Re: [Qemu-devel] [PATCH v2 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-06 Thread Laszlo Ersek
On 03/07/13 00:15, Eric Blake wrote: > On 03/06/2013 02:59 PM, Laszlo Ersek wrote: >> Signed-off-by: Laszlo Ersek >> --- >> qga/commands-posix.c | 146 >> +++-- >> 1 files changed, 140 insertions(+), 6 deletions(-) >> > >> @@ -1027,6 +1031,136 @@ err

Re: [Qemu-devel] [PATCH v2 1/3] qga: introduce guest-get-vcpus / guest-set-vcpus with stubs

2013-03-06 Thread mdroth
On Wed, Mar 06, 2013 at 11:48:14PM +0100, Laszlo Ersek wrote: > On 03/06/13 23:32, Eric Blake wrote: > > On 03/06/2013 02:59 PM, Laszlo Ersek wrote: > > >> +## > >> +# @GuestLogicalProcessor: > >> +# > >> +# @logical-id: Arbitrary guest-specific unique identifier of the VCPU. > >> +# > >> +# @onli

Re: [Qemu-devel] [PATCH v2 3/3] qga: implement qmp_guest_set_vcpus() for Linux with sysfs

2013-03-06 Thread Eric Blake
On 03/06/2013 02:59 PM, Laszlo Ersek wrote: > Signed-off-by: Laszlo Ersek > --- > qga/commands-posix.c | 38 -- > 1 files changed, 32 insertions(+), 6 deletions(-) > > > +int64_t qmp_guest_set_vcpus(GuestLogicalProcessorList *vcpus, Error **errp) > +{ > +

Re: [Qemu-devel] [PATCH v2 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-06 Thread Eric Blake
On 03/06/2013 02:59 PM, Laszlo Ersek wrote: > Signed-off-by: Laszlo Ersek > --- > qga/commands-posix.c | 146 +++-- > 1 files changed, 140 insertions(+), 6 deletions(-) > > @@ -1027,6 +1031,136 @@ error: > return NULL; > } > > +#define SYSCON

Re: [Qemu-devel] problems with freeBSD

2013-03-06 Thread Aurelien Jarno
On Wed, Mar 06, 2013 at 08:21:11AM +, Dietmar Maurer wrote: > Using qemu 1.4.0: > > # qemu -hda test.raw -m 512 -cdrom > pfSense-LiveCD-2.0.2-RELEASE-amd64-20121207-2239.iso > > Results in: > > trap 12: page fault while in kernel mode > ... > stopped at x86bios_emu_rdw+0x2f: movzwl (%rbx),%

Re: [Qemu-devel] [PATCH v2 1/3] qga: introduce guest-get-vcpus / guest-set-vcpus with stubs

2013-03-06 Thread Laszlo Ersek
On 03/06/13 23:32, Eric Blake wrote: > On 03/06/2013 02:59 PM, Laszlo Ersek wrote: >> +## >> +# @GuestLogicalProcessor: >> +# >> +# @logical-id: Arbitrary guest-specific unique identifier of the VCPU. >> +# >> +# @online: Whether the VCPU is enabled. >> +# >> +# @can-offline: Whether offlining the

Re: [Qemu-devel] [PATCH v2 1/3] qga: introduce guest-get-vcpus / guest-set-vcpus with stubs

2013-03-06 Thread Eric Blake
On 03/06/2013 02:59 PM, Laszlo Ersek wrote: > Signed-off-by: Laszlo Ersek > --- > qga/qapi-schema.json | 72 > ++ > qga/commands-posix.c | 12 > qga/commands-win32.c | 12 > 3 files changed, 96 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 09/12] target-lm32: flush tlb after clearing env

2013-03-06 Thread Michael Walle
The tlb data is stored within the CPU env. Therefore, the initialization has to be done after we clear the environment. Otherwise the tlb will have a valid entry for address 0x0. Signed-off-by: Michael Walle --- target-lm32/cpu.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) dif

[Qemu-devel] [PATCH v2 0/3] qga/Linux: online/offline/query VCPUs via guest sysfs

2013-03-06 Thread Laszlo Ersek
Until the uncomparably harder task of real VCPU hotplug / hot-unplug is completed, here's a small guest agent series that imitates the same thing through the sysfs of the Linux guest. We've heard that people migrating from another VMM might be transitorily interested in this. In v2: addressing the

[Qemu-devel] [PATCH 10/12] target-lm32: use HELPER() macro

2013-03-06 Thread Michael Walle
Instead of hardcoding the function name, use the HELPER() macro for this. Signed-off-by: Michael Walle --- target-lm32/op_helper.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/target-lm32/op_helper.c b/target-lm32/op_helper.c index 53410b1..ab249e

[Qemu-devel] [PATCH 07/12] target-lm32: fix cmpgui and cmpgeui opcodes

2013-03-06 Thread Michael Walle
For unsigned compares the immediate has to be zero extended. Signed-off-by: Michael Walle --- target-lm32/translate.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/target-lm32/translate.c b/target-lm32/translate.c index f51ffc5..e885bb3 100644 --- a/t

[Qemu-devel] [PATCH 12/12] configure: rename OpenGL feature to GLX

2013-03-06 Thread Michael Walle
As the probe now actually checks for the availability of GLX, rename it accordingly. The only user of this feature is the milkymist-tmu2 model. Signed-off-by: Michael Walle --- configure | 30 +++--- hw/lm32/Makefile.objs |2 +- hw/milkymist-hw.h |

[Qemu-devel] [PATCH 11/12] configure: proper OpenGL/GLX probe

2013-03-06 Thread Michael Walle
Probe for GL and GLX symbols and X11 library. This fixes a build error where the header files are available but the libraries are not. Signed-off-by: Michael Walle --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 2f98c5a..4f0d0

[Qemu-devel] [PATCH 05/12] target-lm32: don't log cpu state in translation

2013-03-06 Thread Michael Walle
Don't dump the cpu state because it can also be enabled by the "-d cpu" parameter. Signed-off-by: Michael Walle --- target-lm32/translate.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/target-lm32/translate.c b/target-lm32/translate.c index 695d9c5..f51ffc5 100644

[Qemu-devel] [PATCH 06/12] tests: tcg: lm32: add more test cases

2013-03-06 Thread Michael Walle
Esp. for testing zero/sign extend in compare operations. Signed-off-by: Michael Walle --- tests/tcg/lm32/test_cmpgei.S | 15 +++ tests/tcg/lm32/test_cmpgeui.S | 15 +++ tests/tcg/lm32/test_cmpgi.S | 15 +++ tests/tcg/lm32/test_cmpgui.S | 17 +++

[Qemu-devel] [PATCH 08/12] target-lm32: remove dead code

2013-03-06 Thread Michael Walle
Signed-off-by: Michael Walle --- target-lm32/cpu.h | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/target-lm32/cpu.h b/target-lm32/cpu.h index 6948d0e..03db008 100644 --- a/target-lm32/cpu.h +++ b/target-lm32/cpu.h @@ -232,18 +232,8 @@ static inline void cpu_set

[Qemu-devel] [PATCH 01/12] target-lm32: fix debug memory access

2013-03-06 Thread Michael Walle
CPU models which have the LM32_FLAG_IGNORE_MSB flag set will shadow the lower 2GB to the upper 2GB memory space. This will fix the debug memory access used by qemu console and GDB to match this behaviour. Signed-off-by: Michael Walle --- target-lm32/helper.c |7 ++- 1 files changed, 6 in

[Qemu-devel] [PATCH 04/12] lm32_uart: fix receive buffering

2013-03-06 Thread Michael Walle
Inform qemu-char when more input data can be received. Signed-off-by: Michael Walle --- hw/lm32_uart.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/lm32_uart.c b/hw/lm32_uart.c index 9c89cca..5b44f7f 100644 --- a/hw/lm32_uart.c +++ b/hw/lm32_uart.c @@ -137,6 +137,7

[Qemu-devel] [PATCH 02/12] lm32-dis: fix NULL pointer dereference

2013-03-06 Thread Michael Walle
Signed-off-by: Michael Walle --- disas/lm32.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/disas/lm32.c b/disas/lm32.c index a8eefe0..1718c86 100644 --- a/disas/lm32.c +++ b/disas/lm32.c @@ -303,11 +303,11 @@ int print_insn_lm32(bfd_vma memaddr, struct disassem

[Qemu-devel] [PATCH 00/12] target-lm32: various fixes

2013-03-06 Thread Michael Walle
This patchset contains various minor fixes and cleanups for the LatticeMico32 target and its supported hardware models. Patch 11 and 12 were already posted on this list, but never picked up. If there are no objections, i'll send a pull request next week. Michael Walle (12): target-lm32: fix de

[Qemu-devel] [PATCH 03/12] milkymist-uart: fix receive buffering

2013-03-06 Thread Michael Walle
Inform qemu-char when more input data can be received. Signed-off-by: Michael Walle --- hw/milkymist-uart.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/milkymist-uart.c b/hw/milkymist-uart.c index e73eb84..29572b7 100644 --- a/hw/milkymist-uart.c +++ b/hw/milkymis

[Qemu-devel] [PATCH v2 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-06 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- qga/commands-posix.c | 146 +++-- 1 files changed, 140 insertions(+), 6 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 7257145..fd38e14 100644 --- a/qga/commands-posix.c +++ b/qga/commands-

[Qemu-devel] [PATCH v2 1/3] qga: introduce guest-get-vcpus / guest-set-vcpus with stubs

2013-03-06 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- qga/qapi-schema.json | 72 ++ qga/commands-posix.c | 12 qga/commands-win32.c | 12 3 files changed, 96 insertions(+), 0 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json

[Qemu-devel] [PATCH v2 3/3] qga: implement qmp_guest_set_vcpus() for Linux with sysfs

2013-03-06 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- qga/commands-posix.c | 38 -- 1 files changed, 32 insertions(+), 6 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index fd38e14..29898a4 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -

[Qemu-devel] [Bug 1129571] Re: libreoffice armhf FTBFS

2013-03-06 Thread Serge Hallyn
javac switched from hanging forever to segfaulting. ** Changed in: qemu (Ubuntu) Assignee: Serge Hallyn (serge-hallyn) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1129571 Titl

Re: [Qemu-devel] [PATCH 1/7] block: only force IO completion in .bdrv_truncate if we are shrinking

2013-03-06 Thread Paolo Bonzini
Il 06/03/2013 20:03, Peter Lieven ha scritto: > Am 06.03.2013 19:48, schrieb Jeff Cody: >> On Wed, Mar 06, 2013 at 07:31:51PM +0100, Paolo Bonzini wrote: >>> Il 06/03/2013 19:14, Jeff Cody ha scritto: QCOW breaks with it using a normal raw posix file as a device. As a test: qemu-img crea

Re: [Qemu-devel] [PATCH 1/7] block: only force IO completion in .bdrv_truncate if we are shrinking

2013-03-06 Thread Paolo Bonzini
Il 06/03/2013 19:32, Jeff Cody ha scritto: > On Wed, Mar 06, 2013 at 06:50:56PM +0100, Peter Lieven wrote: >> Looking at the source I have not found a place where bs->growable is set to >> 0 for any >> block driver, maybe I miss something. Having bs->growable for iSCSI would >> also be ok. >> >>

Re: [Qemu-devel] [PATCH 11/12] KVM/MIPS: MIPS specfic APIs for KVM.

2013-03-06 Thread Sanjay Lal
On Mar 2, 2013, at 7:45 AM, Peter Maydell wrote: > On 2 March 2013 15:18, Sanjay Lal wrote: >> +/* If we have an interrupt but the guest is not ready to receive an >> + * interrupt, request an interrupt window exit. This will >> + * cause a return to userspace as soon as the guest i

Re: [Qemu-devel] [PATCH 03/12] KVM/MIPS: Add save/restore state APIs for saving/restoring KVM guests.

2013-03-06 Thread Sanjay Lal
On Mar 2, 2013, at 7:27 AM, Peter Maydell wrote: > 2013/3/2 Sanjay Lal : >> +static void gt64xxx_save(QEMUFile *f, void *opaque) >> +{ >> +GT64120State *s = opaque; >> + >> +/* CPU Configuration */ >> +qemu_put_be32s(f, &s->regs[GT_CPU]); >> +qemu_put_be32s(f, &s->regs[GT_MULTI]);

Re: [Qemu-devel] [PATCH 01/12] KVM/MIPS: Bootcode for MIPS SMP configurations with a GCMP

2013-03-06 Thread Sanjay Lal
On Mar 2, 2013, at 12:03 PM, Peter Maydell wrote: > On 2 March 2013 15:18, Sanjay Lal wrote: >> --- /dev/null >> +++ b/hw/mips_cps_bootcode.h >> @@ -0,0 +1,310 @@ >> +/* Sample boot code for 1004K CPS (Coherent Processing System.) >> + * Not Generic for all Release 2 or higher MIPS32 or MIPS64 p

Re: [Qemu-devel] [PATCH v7 00/11] QEMU: Support KVM on ARM

2013-03-06 Thread Christoffer Dall
On Tue, Feb 26, 2013 at 05:40:10PM +, Peter Maydell wrote: > KVM ARM support has just hit Linus' kernel tree, so we can > finally commit this series to QEMU. Since all the patches got > reviewed last time round this should be ready to commit. > I plan to commit this via arm-devs.next. > > NB:

  1   2   3   >