Re: [Qemu-devel] [PATCH][QEMU] vmxcap: Augment reported information

2013-02-13 Thread Gleb Natapov
On Wed, Feb 13, 2013 at 12:44:06PM +0100, Jan Kiszka wrote: > Parse the Basic VMX Information MSR and add the bit for the new posted > interrupts. > > Signed-off-by: Jan Kiszka Applied, thanks. > --- > scripts/kvm/vmxcap | 14 ++ > 1 files changed, 14 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH][QEMU] vmxcap: Open MSR file in unbuffered mode

2013-02-13 Thread Gleb Natapov
On Wed, Feb 13, 2013 at 12:43:10PM +0100, Jan Kiszka wrote: > Python may otherwise decide to to read larger chunks, applying the seek > only on the software buffer. This will return results from the wrong > MSRs. > > Signed-off-by: Jan Kiszka Applied, thanks. > --- > scripts/kvm/vmxcap |4 +

[Qemu-devel] [PATCH] hw/mc146818rtc.c: Fix reading and writing of time registers

2013-02-13 Thread Antoine Mathys
This patch consolidates the bit twidling involved in reading and writing the time registers to four functions that are used consistently. This also has the effect of fixing bug 1090558. Signed-off-by: Antoine Mathys --- hw/mc146818rtc.c | 163 +--

[Qemu-devel] [RFC PATCH 09/10] QMP/qemu-ga-client: make timeout longer for guest-fsfreeze-freeze command

2013-02-13 Thread Tomoki Sekiyama
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy disk I/O is running. To avoid unexpected timeout, this changes the timeout to 30 seconds. Signed-off-by: Tomoki Sekiyama --- QMP/qemu-ga-client |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/QMP/qe

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Stefan Priebe - Profihost AG
Hi, no VM crashed this morning. Stefan Am 13.02.2013 16:24, schrieb Paolo Bonzini: > Il 13/02/2013 15:30, Stefan Priebe - Profihost AG ha scritto: >> I added this: >> -trace events=/tmp/events,file=/root/qemu.123.trace >> >> and put the events in the events file as i couldn't handle \n in my app

[Qemu-devel] [RFC ppc-next PATCH 5/6] kvm: export result of irqchip config check

2013-02-13 Thread Scott Wood
This allows platform code to register in-kernel irqchips that don't use the legacy KVM_CAP_IRQCHIP/KVM_CREATE_IRQCHIP interface. Signed-off-by: Scott Wood --- include/sysemu/kvm.h | 10 ++ kvm-all.c| 11 +-- 2 files changed, 19 insertions(+), 2 deletions(-) diff

[Qemu-devel] [RFC PATCH 10/10] QMP/qmp.py: set locale for exceptions to display non-ascii messages correctly

2013-02-13 Thread Tomoki Sekiyama
qemu-ga in Windows might return error message with multibyte characters when the guest OS language is set to other than English. To display such messages correctly, this decodes the message based on locale settings. Signed-off-by: Tomoki Sekiyama --- QMP/qmp.py |4 +++- 1 file changed, 3 ins

[Qemu-devel] [RFC ppc-next PATCH 3/6] memory: add memory_region_to_address()

2013-02-13 Thread Scott Wood
This is useful for when a user of the memory region API needs to communicate the absolute bus address to something outside QEMU (in particular, KVM). Signed-off-by: Scott Wood --- include/exec/memory.h |9 + memory.c | 38 ++ 2 files

[Qemu-devel] [RFC PATCH 03/10] qemu-ga: Add an configure option to specify path to Windows VSS SDK

2013-02-13 Thread Tomoki Sekiyama
To enable VSS support in qemu-ga for Windows, header files included in VSS SDK is required. The VSS support is enabled when the option like below: ./configure --with-vss-sdk="/pass/to/VSS SDK" VSS SDK is available from: http://www.microsoft.com/en-us/download/details.aspx?id=23490 To cross-co

[Qemu-devel] [RFC ppc-next PATCH 2/6] kvm: hw/kvm is not x86-specific

2013-02-13 Thread Scott Wood
Signed-off-by: Scott Wood --- hw/Makefile.objs |1 + hw/i386/Makefile.objs |1 - hw/kvm/Makefile.objs |2 +- 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/Makefile.objs b/hw/Makefile.objs index 447e32a..46bc395 100644 --- a/hw/Makefile.objs +++ b/hw/Makefile.

[Qemu-devel] [RFC PATCH 01/10] configure: Support configuring c++ compiler

2013-02-13 Thread Tomoki Sekiyama
Add configuration for c++ compiler (${corss_prefix}g++ as default) in configure and Makefiles. Currently, usage of c++ language is only for access to Windows VSS using COM+ services in qemu-guest-agent for Windows. Signed-off-by: Tomoki Sekiyama --- configure |6 ++ rules.mak |7 +++

[Qemu-devel] [RFC ppc-next PATCH 0/6] kvm/openpic: in-kernel irqchip

2013-02-13 Thread Scott Wood
This allows QEMU to use the in-kernel KVM MPIC on some PPC platforms. Scott Wood (6): kvm: update linux-headers kvm: hw/kvm is not x86-specific memory: add memory_region_to_address() openpic: factor out some common defines into openpic.h kvm: export result of irqchip config check kvm/o

[Qemu-devel] [RFC PATCH 02/10] Fix errors and warnings while compiling with c++ compilier

2013-02-13 Thread Tomoki Sekiyama
Rename 'class' member in class_info of PciDeviceInfo to 'dev_class', and add some casts to avoid errors from c++ compiler. Signed-off-by: Tomoki Sekiyama --- hmp.c|2 +- hw/pci/pci.c |2 +- qapi-schema.json |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) di

[Qemu-devel] [RFC ppc-next PATCH 1/6] kvm: update linux-headers

2013-02-13 Thread Scott Wood
These headers have not yet been merged into Linux -- this is an RFC patchset. Signed-off-by: Scott Wood --- linux-headers/linux/kvm.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 5af9357..860

[Qemu-devel] [RFC PATCH 07/10] qemu-ga: install Windows VSS provider on `qemu-ga -s install'

2013-02-13 Thread Tomoki Sekiyama
Register QGA VSS provider library into Windows when qemu-ga is installed as Windows service ('-s install' option). It is deregistered when the service is uninstalled ('-s uninstall' option). Signed-off-by: Tomoki Sekiyama --- qga/main.c |8 1 file changed, 8 insertions(+) diff --gi

[Qemu-devel] [RFC ppc-next PATCH 6/6] kvm/openpic: in-kernel mpic support

2013-02-13 Thread Scott Wood
This depends on RFC kernel interfaces proposed at: http://patchwork.ozlabs.org/patch/220359/ http://patchwork.ozlabs.org/patch/220362/ Signed-off-by: Scott Wood --- hw/kvm/Makefile.objs |1 + hw/kvm/openpic.c | 295 ++ hw/ppc/e500.c

[Qemu-devel] [RFC ppc-next PATCH 4/6] openpic: factor out some common defines into openpic.h

2013-02-13 Thread Scott Wood
...for use by the KVM in-kernel irqchip stub. Signed-off-by: Scott Wood --- hw/openpic.c | 40 ++-- hw/openpic.h | 11 +++ 2 files changed, 29 insertions(+), 22 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index 20a479c..0d55ef4 100644 --

[Qemu-devel] [RFC PATCH 08/10] qemu-ga: Add VSS provider .tlb file in the repository

2013-02-13 Thread Tomoki Sekiyama
To build type library (.tlb) from COM IDL (.idl), MIDL program in VisualC++ is required. Because MinGW does not support building .tlb files, this file cannot be cross-compiled in non-Windows systems. This patch adds pre-compiled .tlb file in the repository in order to enable cross-compile qemu-ga

[Qemu-devel] [RFC PATCH 04/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-02-13 Thread Tomoki Sekiyama
Implements a basic stub of software VSS provider. Currently, this modules only provides a relay function of events between qemu-guest-agent and Windows VSS when VSS finished filesystem freeze and when qemu snapshot is done. In the future, this module could be extended to support the other VSS func

[Qemu-devel] [RFC PATCH 06/10] qemu-ga: call Windows VSS requester in fsfreeze command handler

2013-02-13 Thread Tomoki Sekiyama
Support guest-fsfreeze-freeze and guest-fsfreeze-thaw commands for Windows guests. When fsfreeze command is issued, it calls the VSS requester to freeze filesystems and applications. On thaw command, it again tells the VSS requester to thaw them. This also adds calling of initialize functions for

[Qemu-devel] [RFC PATCH 05/10] qemu-ga: Add Windows VSS requester to quisce applications and filesystems

2013-02-13 Thread Tomoki Sekiyama
This adds VSS requester functions for to qemu-ga. This provides facility to request VSS service in Windows guest to quisce applications and filesystems. This function is only supported in Windows 2003 or later. In older guests, this function does nothing. Signed-off-by: Tomoki Sekiyama --- qga/M

[Qemu-devel] [RFC PATCH 00/10] qemu-ga: support fsfreeze on Windows using VSS

2013-02-13 Thread Tomoki Sekiyama
Hi, This patch series attempts to add fsfreeze support for Windows qemu-guest-agent. In Windows, VSS (Volume Shadow Copy Service) can provide a facility to quiesce filesystems and applications before snapshots are taken. VSS consists from some components. - VSS Writers:applications to be qu

[Qemu-devel] [Bug 1123975] Re: QEmu 1.3.90 cannot restore a 1.1.2 live snapshot

2013-02-13 Thread Michael Tokarev
And one more thing -- from what to what are you trying to migrate? I see you have qemu-kvm installed too, -- were you using it previously? Note that qemu-kvm 1.1 had the same video ram size = 16Mb as current qemu have. But my cross-version migration comment stays and in this case it becomes even

[Qemu-devel] [Bug 1123975] Re: QEmu 1.3.90 cannot restore a 1.1.2 live snapshot

2013-02-13 Thread Michael Tokarev
This sounds pretty much like a prob with video ram size. In 1.1.x, we had video ram of 8Mb, in 1.3 it is 16Mb... should this be a problem, to come from smaller to larger size? Besides that, debian uses almost unmodified qemu, so the same prob should exist for upstream qemu too. But at any rate,

Re: [Qemu-devel] using -net dump with tap networking

2013-02-13 Thread Alexey Kardashevskiy
On 14/02/13 05:02, Laszlo Ersek wrote: On 02/13/13 15:48, Alexey Kardashevskiy wrote: Hi! I am running qemu as: qemu/ppc64-softmmu/qemu-system-ppc64 -m 1024 -M pseries -trace events=trace_events -netdev user,id=virtnet,hostfwd=tcp::5000-:22 -device virtio-net-pci,netdev=virtnet -nographic -vga

[Qemu-devel] [PATCH 09/10] bitops: Replace bitops_ctol with ctzl

2013-02-13 Thread Richard Henderson
The is the only remaining user. Signed-off-by: Richard Henderson --- util/bitops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/bitops.c b/util/bitops.c index 50b4a81..e72237a 100644 --- a/util/bitops.c +++ b/util/bitops.c @@ -109,7 +109,7 @@ found_first: ret

[Qemu-devel] [PATCH 05/10] memory: Use non-bitops ctzl

2013-02-13 Thread Richard Henderson
A memory size of zero is invalid, and so that edge condition does not occur. Signed-off-by: Richard Henderson --- memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index cd7d5e0..92a2196 100644 --- a/memory.c +++ b/memory.c @@ -855,7 +855,7 @@ s

[Qemu-devel] [PATCH 04/10] bitops: Use non-bitops ctzl

2013-02-13 Thread Richard Henderson
The use of ctz has already eliminated zero, and thus the difference in edge conditions between the two routines is irrelevant. Signed-off-by: Richard Henderson --- util/bitops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/bitops.c b/util/bitops.c index 7b853cf..9cd1c

[Qemu-devel] [PATCH v2 00/10] Cleanup bitops vs host-utils

2013-02-13 Thread Richard Henderson
Version 1 merely tried to adjust bitops_flsl, here I instead eliminate it all from bitops.h, and standardizes on the routines from host-utils.h. r~ Richard Henderson (10): host-utils: Add host long specific aliases for clz, ctz, ctpop host-utils: Fix coding style and add comments hbitmap:

[Qemu-devel] [PATCH 06/10] bitops: Write bitops_flsl in terms of clzl

2013-02-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/qemu/bitops.h | 29 + 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index 8b88791..b50629b 100644 --- a/include/qemu/bitops.h +++ b/include/qemu/bitops.h @@ -57,3

[Qemu-devel] [PATCH 08/10] bitops: Inline bitops_flsl

2013-02-13 Thread Richard Henderson
This is the only remaining user. Signed-off-by: Richard Henderson --- util/bitops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/bitops.c b/util/bitops.c index 9cd1c3a..50b4a81 100644 --- a/util/bitops.c +++ b/util/bitops.c @@ -133,7 +133,7 @@ unsigned long find_last_

[Qemu-devel] [PATCH 01/10] host-utils: Add host long specific aliases for clz, ctz, ctpop

2013-02-13 Thread Richard Henderson
We will standardize on these names, rather than the similar routines currently residing in qemu/bitops.h. Signed-off-by: Richard Henderson --- include/qemu/host-utils.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/qemu/host-utils.h b/include/qemu/host-utils.h

Re: [Qemu-devel] [PATCH v2] Move File operations to qemu-file.c

2013-02-13 Thread Anthony Liguori
Joel Schopp writes: >>> +if(popen_file == NULL) { >> >> Please make a preparatory patch which adds missing spaces between 'if' >> statements and '('. > > I'll do a preparatory style cleanup patch of existing code if it is > deemed necessary by the maintainers, but I don't think it's a good >

Re: [Qemu-devel] [PATCH moxie 2/5] Add moxie disassembler

2013-02-13 Thread Anthony Liguori
Anthony Green writes: > This patch adds the disassembler logic for moxie. > > > Signed-off-by: Anthony Green > diff --git a/disas/moxie.c b/disas/moxie.c >  new file mode 100644 > index 000..20ae0eb > --- /dev/null > +++ b/disas/moxie.c > @@ -0,0 +1,369 @@ > +/* Disassemble moxie instruction

[Qemu-devel] [PATCH 07/10] target-i386: Inline bitops_flsl

2013-02-13 Thread Richard Henderson
Use clz32 directly. Which makes slightly more sense given that the input is type "int" and not type "long". Signed-off-by: Richard Henderson --- target-i386/topology.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target-i386/topology.h b/target-i386/topology.h index

[Qemu-devel] [PATCH 03/10] hbitmap: Use non-bitops ctzl

2013-02-13 Thread Richard Henderson
Both uses of ctz have already eliminated zero, and thus the difference in edge conditions between the two routines is irrelevant. Signed-off-by: Richard Henderson --- include/qemu/hbitmap.h | 3 ++- util/hbitmap.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/in

[Qemu-devel] [PATCH 10/10] bitops: Remove routines redundant with host-utils

2013-02-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/qemu/bitops.h | 48 1 file changed, 48 deletions(-) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index b50629b..affcc96 100644 --- a/include/qemu/bitops.h +++ b/include/qemu/bitops.h @@ -2

[Qemu-devel] [PATCH 02/10] host-utils: Fix coding style and add comments

2013-02-13 Thread Richard Henderson
Add function comments to the routines, documenting the corner cases upon which we are standardizing. Fix the few instances of non-standard coding style. Signed-off-by: Richard Henderson --- include/qemu/host-utils.h | 100 +- 1 file changed, 82 insert

[Qemu-devel] [PATCH moxie 5/5] Top level changes for moxie port

2013-02-13 Thread Anthony Green
The final patch adds top level changes in support of the new moxie port. Thanks, AG Signed-off-by: Anthony Green ---  hw/moxie/Makefile.objs     |   5 ++  hw/moxiesim.c              | 200 +  include/sysemu/arch_init.h |   1 +  3 files changed, 206 in

[Qemu-devel] [PATCH moxie 2/5] Add moxie disassembler

2013-02-13 Thread Anthony Green
This patch adds the disassembler logic for moxie. Signed-off-by: Anthony Green ---  disas.c             |   6 +  disas/Makefile.objs |   1 +  disas/moxie.c       | 369  include/disas/bfd.h |   2 +  4 files changed, 378 insertions(+)  create mo

[Qemu-devel] [PATCH moxie 1/5] New processor port

2013-02-13 Thread Anthony Green
Hello qemu maintainers,   I have been maintaining a qemu port for moxie on github for a few years now, and would now like to submit it upstream.  Moxie is a soft-core architecture, similar to lm32 and microblaze.  The GNU toolchain has supported moxie for several years now.  The qemu port is very

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Revert "Update OpenBIOS images"

2013-02-13 Thread Alexander Graf
On 14.02.2013, at 01:54, Mark Cave-Ayland wrote: > On 14/02/13 00:17, Alexander Graf wrote: > >> With the following patch fixing the issue at hand for me. Though I don't >> fully understand why str would be NULL yet: >> >> >> diff --git a/packages/mac-parts.c b/packages/mac-parts.c >> index a

Re: [Qemu-devel] [PATCH] Fix guest OS hangs on boot when 64bit PCI BAR present

2013-02-13 Thread Alexey Korolev
On 13/02/13 23:26, Michael S. Tsirkin wrote: > On Wed, Feb 13, 2013 at 06:14:33PM +1300, Alexey Korolev wrote: >> At the moment may_overlap flag of MemoryRegion structure >> is ignored by the address range assignment process. >> This may lead to guest OS hangs if critical qemu >> resources are over

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Revert "Update OpenBIOS images"

2013-02-13 Thread Mark Cave-Ayland
On 14/02/13 00:17, Alexander Graf wrote: With the following patch fixing the issue at hand for me. Though I don't fully understand why str would be NULL yet: diff --git a/packages/mac-parts.c b/packages/mac-parts.c index a286870..443455e 100644 --- a/packages/mac-parts.c +++ b/packages/mac-pa

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Revert "Update OpenBIOS images"

2013-02-13 Thread Alexander Graf
On 14.02.2013, at 01:01, Mark Cave-Ayland wrote: > On 13/02/13 23:45, Alexander Graf wrote: > >>> The release is basically done. I don't think we have time for any fix >>> beyond reverting the commit. And I'd rather have it reverted, since we >>> regress heavily against 1.3 with the updated Op

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Revert "Update OpenBIOS images"

2013-02-13 Thread Alexander Graf
On 14.02.2013, at 01:04, Alexander Graf wrote: > > On 14.02.2013, at 01:01, Mark Cave-Ayland wrote: > >> On 13/02/13 23:45, Alexander Graf wrote: >> The release is basically done. I don't think we have time for any fix beyond reverting the commit. And I'd rather have it reverted, si

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Revert "Update OpenBIOS images"

2013-02-13 Thread Mark Cave-Ayland
On 13/02/13 23:45, Alexander Graf wrote: The release is basically done. I don't think we have time for any fix beyond reverting the commit. And I'd rather have it reverted, since we regress heavily against 1.3 with the updated OpenBIOS. [12:43am]aliguori:agraf, i can wait until the very star

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Revert "Update OpenBIOS images"

2013-02-13 Thread Alexander Graf
On 14.02.2013, at 00:41, Alexander Graf wrote: > > On 14.02.2013, at 00:38, Mark Cave-Ayland wrote: > >> On 13/02/13 22:58, Alexander Graf wrote: >> >>> This reverts commit 10442558ab1797bfbb01285b909e34c5cf038f12. >>> >>> With the updated OpenBIOS image, -M g3beige fails to boot quik. >> >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Revert "Update OpenBIOS images"

2013-02-13 Thread Alexander Graf
On 14.02.2013, at 00:38, Mark Cave-Ayland wrote: > On 13/02/13 22:58, Alexander Graf wrote: > >> This reverts commit 10442558ab1797bfbb01285b909e34c5cf038f12. >> >> With the updated OpenBIOS image, -M g3beige fails to boot quik. > > Hi Alex, > > Can you point me towards a test ISO image for t

Re: [Qemu-devel] [PATCH] Revert "Update OpenBIOS images"

2013-02-13 Thread Mark Cave-Ayland
On 13/02/13 22:58, Alexander Graf wrote: This reverts commit 10442558ab1797bfbb01285b909e34c5cf038f12. With the updated OpenBIOS image, -M g3beige fails to boot quik. Hi Alex, Can you point me towards a test ISO image for this? There are so many other PPC fixes in OpenBIOS worth having that

[Qemu-devel] [PATCH moxie 4/5] Add sample moxie system

2013-02-13 Thread Anthony Green
Add a simple moxie target, similar to what we have in the gdb simulator today. Signed-off-by: Anthony Green --- hw/moxie/Makefile.objs | 5 ++ hw/moxiesim.c | 200 + include/sysemu/arch_init.h | 1 + 3 files changed, 206 insertion

Re: [Qemu-devel] using -net dump with tap networking

2013-02-13 Thread Paolo Bonzini
Il 13/02/2013 19:02, Laszlo Ersek ha scritto: >> > I am running qemu as: >> > >> > qemu/ppc64-softmmu/qemu-system-ppc64 -m 1024 -M pseries -trace >> > events=trace_events -netdev user,id=virtnet,hostfwd=tcp::5000-:22 >> > -device virtio-net-pci,netdev=virtnet -nographic -vga none -enable-kvm >> > -

Re: [Qemu-devel] [BUG] Guest OS hangs on boot when 64bit BAR present (kvm-apic -msi resource conflict)

2013-02-13 Thread Alexey Korolev
> On Wed, Feb 13, 2013 at 11:34:52AM +0100, Jan Kiszka wrote: >> On 2013-02-13 11:24, Michael S. Tsirkin wrote: >>> On Wed, Feb 13, 2013 at 06:06:37PM +1300, Alexey Korolev wrote: Sometime ago I reported an issue about guest OS hang when 64bit BAR present. http://lists.gnu.org/arch

Re: [Qemu-devel] [PATCH v2] Move File operations to qemu-file.c

2013-02-13 Thread Joel Schopp
+if(popen_file == NULL) { Please make a preparatory patch which adds missing spaces between 'if' statements and '('. I'll do a preparatory style cleanup patch of existing code if it is deemed necessary by the maintainers, but I don't think it's a good idea. The patch as it stands now

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-13 Thread Eduardo Habkost
TL;DR: I still disagree about some points, but those points aren't so relevant anymore because I am starting to like having KVM-specific/TCG-specific subclasses (because of other problems that would be solved by them). On Wed, Feb 13, 2013 at 04:20:43PM +0100, Igor Mammedov wrote: [...] > > > >

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2013-02-13 Thread Dereck Wonnacott
I wouldn't mind giving this patch a test if given some instructions on doing so. I am also unable to compile pcl because of this bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title: cm

Re: [Qemu-devel] [PATCH v2] Move File operations to qemu-file.c

2013-02-13 Thread Blue Swirl
On Wed, Feb 13, 2013 at 8:43 PM, Joel Schopp wrote: > This patch reorganizes qemu file operations to be in their own source file > instead of being lumped in savevm.c. Besides being more logical for > maintenance > it also makes it easier for future users of the file functions to add tests. > >

Re: [Qemu-devel] [RFC PATCH v2 13/23] qcow2: handle_copied(): Implement non-zero host_offset

2013-02-13 Thread Blue Swirl
On Wed, Feb 13, 2013 at 1:22 PM, Kevin Wolf wrote: > Look only for clusters that start at a given physical offset. > > Signed-off-by: Kevin Wolf > --- > block/qcow2-cluster.c | 26 ++ > 1 files changed, 18 insertions(+), 8 deletions(-) > > diff --git a/block/qcow2-clust

Re: [Qemu-devel] [PATCH v2] ui/vnc: VA API based H.264 encoding for VNC

2013-02-13 Thread Blue Swirl
On Wed, Feb 13, 2013 at 10:45 AM, David Verbeiren wrote: > This patch implements H.264 encoding of the VNC framebuffer updates > using hardware acceleration through the VA API. > > This is experimental support to let the community explore the possibilities > offered by the potential bandwidth and

Re: [Qemu-devel] [Qemu-ppc] [0/8] RFC: target-ppc: Start disentangling different MMU types

2013-02-13 Thread Blue Swirl
On Tue, Feb 12, 2013 at 10:40 AM, Andreas Färber wrote: > Am 12.02.2013 03:00, schrieb David Gibson: >> The target-ppc code supports CPUs with a number of different MMU >> types: there's both the 32-bit and 64-bit versions of the "classic" >> hash page table based powerpc mmu and there's also the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/8] target-ppc: Disentangle 64-bit hash MMU get_physical_address() paths

2013-02-13 Thread Blue Swirl
On Tue, Feb 12, 2013 at 2:00 AM, David Gibson wrote: > Depending on the MSR state, for 64-bit hash MMUs, get_physical_address > can either call check_physical (which has further tests for mmu type) > or get_segment64. > > This patch splits off the whole get_physical_addresss() path for 64-bit > ha

Re: [Qemu-devel] [PATCH V18 08/10] libqblock: libqblock API implement

2013-02-13 Thread Blue Swirl
On Wed, Feb 13, 2013 at 2:08 AM, Wenchao Xia wrote: > >> On Sat, Feb 9, 2013 at 7:42 AM, Wenchao Xia >> wrote: >>> >>>This patch contains implemention for APIs. Basically it is a layer >>> above qemu block general layer now. >>>qb_image_new() will try do init for this library. >>> >>> Sig

Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names

2013-02-13 Thread Blue Swirl
On Mon, Feb 11, 2013 at 4:41 PM, Peter Maydell wrote: > This patchset is just cleanups; it has two major aims: > * remove 'cpu' from public-facing qemu_log function/type/etc >names, since the logging is now entirely generic and not >tied to TCG CPU debug logging at all > * remove unneces

[Qemu-devel] [PATCH v2] Move File operations to qemu-file.c

2013-02-13 Thread Joel Schopp
This patch reorganizes qemu file operations to be in their own source file instead of being lumped in savevm.c. Besides being more logical for maintenance it also makes it easier for future users of the file functions to add tests. v2 forward port to resolve conflicts, strip trailing whitespace d

[Qemu-devel] [PATCH for-1.4 4/7] doc: Fix texinfo @table markup in qemu-options.hx

2013-02-13 Thread Markus Armbruster
End tables before headings, start new ones afterwards. Fixes incorrect indentation of headings "File system options" and "Virtual File system pass-through options" in manual page and qemu-doc. Normalize markup some to increase chances it survives future edits. Signed-off-by: Markus Armbruster -

Re: [Qemu-devel] [PATCH for-1.4 v2 1/6] error: Clean up error strings with embedded newlines

2013-02-13 Thread Luiz Capitulino
On Fri, 08 Feb 2013 20:48:18 +0100 Markus Armbruster wrote: > It's a cleanup. It's only user-visible effect is getting rid of an > extra newline on stderr. I'm fixing those globally. Tiny improvement > in user experience, but next to no risk, thus proposed for 1.4. Since I > need to touch thi

[Qemu-devel] [PATCH for-1.4 7/7] doc help: Collect block device stuff under its own heading

2013-02-13 Thread Markus Armbruster
Collect them from "Standard options", "File system options", "Virtual File system pass-through options", "Debug/Expert options". Signed-off-by: Markus Armbruster --- qemu-options.hx | 722 1 file changed, 356 insertions(+), 366 deletions(-

[Qemu-devel] [PATCH for-1.4 6/7] doc help: A few options are under inappropriate headings, fix

2013-02-13 Thread Markus Armbruster
--device is under heading "USB options". --name and --uuid are under "Virtual File system pass-through options". Move all three to "Standard options". Signed-off-by: Markus Armbruster --- qemu-options.hx | 80 - 1 file changed, 39 inserti

Re: [Qemu-devel] [PATCH for-1.4 v2 4/6] qemu-option: Disable two helpful messages that got broken recently

2013-02-13 Thread Luiz Capitulino
On Fri, 08 Feb 2013 20:34:20 +0100 Markus Armbruster wrote: > > The real problem here is that the k, M, G suffixes, for example, are not > > good to be reported by QMP. So maybe we should refactor the code in a way > > that we separate what's done in QMP from what is done in HMP/command-line. >

[Qemu-devel] [PATCH for-1.4 0/7] Option doc fixes for -help and qemu-doc

2013-02-13 Thread Markus Armbruster
Hope it's not too late for -help and doc fixes. Markus Armbruster (7): help: Drop bogus help on -qtest and -qtest-log doc: Fix some option entries in qemu-doc's function index doc: Fill some option doc gaps in manual page and qemu-doc doc: Fix texinfo @table markup in qemu-options.hx hel

[Qemu-devel] [PATCH for-1.4 3/7] doc: Fill some option doc gaps in manual page and qemu-doc

2013-02-13 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qemu-options.hx | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 932d6c5..d57cf2b 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -326,9 +326,9 @@ DEF("set", HAS_ARG, QEMU_OPTI

Re: [Qemu-devel] [PATCH for-1.4 1/7] help: Drop bogus help on -qtest and -qtest-log

2013-02-13 Thread Anthony Liguori
Haven't seen all the patches, but just FYI, this is too late for 1.4. I'm already testing a locally tagged version. But looks like it will potentially be a nice cleanup! Regards, Anthony Liguori Markus Armbruster writes: > Signed-off-by: Markus Armbruster > --- > qemu-options.hx | 10 +++--

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Stefan Priebe
Hi, Am 13.02.2013 16:24, schrieb Paolo Bonzini: Il 13/02/2013 15:30, Stefan Priebe - Profihost AG ha scritto: I added this: -trace events=/tmp/events,file=/root/qemu.123.trace and put the events in the events file as i couldn't handle \n in my app starting the kvm process. But even when doing

[Qemu-devel] [PATCH for-1.4 2/7] doc: Fix some option entries in qemu-doc's function index

2013-02-13 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qemu-options.hx | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 3800c9c..932d6c5 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -446,6 +446,7 @@ DEF("mem-path", HAS_ARG, QEMU_OPTION_mem

[Qemu-devel] [Bug 1123975] [NEW] QEmu 1.3.90 cannot restore a 1.1.2 live snapshot

2013-02-13 Thread Francois Gouget
Public bug reported: I have upgraded to QEmu 1.3.90 (Debian 1.4.0~rc0+dfsg-1exp) but now when I try to restore a live snapshot made in QEmu 1.1.2 (Debian 1.1.2+dfsg-5) I get the following message: virsh # snapshot-revert fgtbbuild wtb error: operation failed: Error -22 while loading VM state I h

[Qemu-devel] qemu / KVM modification to yield to external component (how to make it ignore the time the external component is running)

2013-02-13 Thread Lloret, Luis
Hi, qemu experts, We are using qemu with KVM for some experiments that involve qemu yielding to an external process periodically. By yielding, what I mean is that qemu will stop executing for some time while the external process does its job and reports back to qemu. The external process is a r

[Qemu-devel] [PATCH for-1.4 5/7] help: Fix markup of heading "USB options" so it appears in -help

2013-02-13 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qemu-options.hx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8d288f5..071b1b3 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -538,9 +538,10 @@ ETEXI STEXI @end table ETEXI +DEFHEADING(

[Qemu-devel] [PATCH for-1.4 1/7] help: Drop bogus help on -qtest and -qtest-log

2013-02-13 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qemu-options.hx | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 046bdc0..3800c9c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2928,13 +2928,9 @@ the @var{simple} tracing backend.

Re: [Qemu-devel] [PATCH for-1.4 0/2] chardev-add

2013-02-13 Thread Anthony Liguori
Eric Blake writes: > On 02/13/2013 07:54 AM, Markus Armbruster wrote: >> Why am I proposing these patches for 1.4? >> >> PATCH 1/2 is a straightforward doc fix. >> >> PATCH 2/2 cleans up a part of QAPI that has never been released, >> before it's too late. If we're already beyond the point whe

Re: [Qemu-devel] using -net dump with tap networking

2013-02-13 Thread Laszlo Ersek
On 02/13/13 15:48, Alexey Kardashevskiy wrote: > Hi! > > I am running qemu as: > > qemu/ppc64-softmmu/qemu-system-ppc64 -m 1024 -M pseries -trace > events=trace_events -netdev user,id=virtnet,hostfwd=tcp::5000-:22 > -device virtio-net-pci,netdev=virtnet -nographic -vga none -enable-kvm > -kernel vm

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Fix circular dependency for HOST_LONG_BITS qemu-common.h <-> bswap.h

2013-02-13 Thread Andreas Färber
Am 13.02.2013 18:41, schrieb Anthony Liguori: > David Gibson writes: > >> On Tue, Feb 05, 2013 at 11:42:30AM +0100, Andreas Färber wrote: >>> Am 05.02.2013 01:07, schrieb Peter Maydell: On 4 February 2013 23:52, Richard Henderson wrote: > On 2013-02-04 15:30, David Gibson wrote: >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Fix circular dependency for HOST_LONG_BITS qemu-common.h <-> bswap.h

2013-02-13 Thread Anthony Liguori
David Gibson writes: > On Tue, Feb 05, 2013 at 11:42:30AM +0100, Andreas Färber wrote: >> Am 05.02.2013 01:07, schrieb Peter Maydell: >> > On 4 February 2013 23:52, Richard Henderson wrote: >> >> On 2013-02-04 15:30, David Gibson wrote: >> >>> Anthony, Richard, anyone? >> >>> >> >>> Please apply

Re: [Qemu-devel] [PATCH] pseries: Add cleanup hook for PAPR virtual LAN device

2013-02-13 Thread Anthony Liguori
Andreas Färber writes: > Am 11.02.2013 05:59, schrieb David Gibson: >> Currently the spapr-vlan device does not supply a cleanup call for its >> NetClientInfo structure. With current qemu versions, that leads to a SEGV >> on exit, when net_cleanup() attempts to call the cleanup handlers on all >

Re: [Qemu-devel] [PATCH for-1.4 0/2] chardev-add

2013-02-13 Thread Eric Blake
On 02/13/2013 07:54 AM, Markus Armbruster wrote: > Why am I proposing these patches for 1.4? > > PATCH 1/2 is a straightforward doc fix. > > PATCH 2/2 cleans up a part of QAPI that has never been released, > before it's too late. If we're already beyond the point where we can > do that, too bad,

Re: [Qemu-devel] [PATCH for-1.4 0/2] chardev-add

2013-02-13 Thread Laszlo Ersek
On 02/13/13 15:54, Markus Armbruster wrote: > Why am I proposing these patches for 1.4? > > PATCH 1/2 is a straightforward doc fix. > > PATCH 2/2 cleans up a part of QAPI that has never been released, > before it's too late. If we're already beyond the point where we can > do that, too bad, we'l

Re: [Qemu-devel] [PATCH 0/2] block: refuse negative iops and bps values

2013-02-13 Thread Kevin Wolf
Am 13.02.2013 16:53, schrieb Stefan Hajnoczi: > These patches report an error if negative values are given for I/O throttling > iops or bps. > > Patch 1 gets do_check_io_limits() into shape so that we can add checks. > > Patch 2 adds the negative check. > > Stefan Hajnoczi (2): > block: use Er

Re: [Qemu-devel] [RFC ppc-next 39/39] target-ppc: Convert CPU definitions

2013-02-13 Thread Andreas Färber
Am 12.02.2013 17:48, schrieb Andreas Färber: > Am 12.02.2013 11:13, schrieb Andreas Färber: >> Turn the array of model definitions into a set of self-registering QOM >> types with their own class_init. Unique identifiers are obtained from >> the combination of PVR, SVR and family identifiers; this

[Qemu-devel] [PATCH 0/2] block: refuse negative iops and bps values

2013-02-13 Thread Stefan Hajnoczi
These patches report an error if negative values are given for I/O throttling iops or bps. Patch 1 gets do_check_io_limits() into shape so that we can add checks. Patch 2 adds the negative check. Stefan Hajnoczi (2): block: use Error in do_check_io_limits() block: refuse negative iops and bp

[Qemu-devel] [PATCH 2/2] block: refuse negative iops and bps values

2013-02-13 Thread Stefan Hajnoczi
Negative I/O throttling iops and bps values do not make sense so reject them with an error message. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/blockdev.c b/blockdev.c index 9b03513..ba3759c 100644 --- a/blockdev.c +++ b/blockdev.

[Qemu-devel] [RFC PATCH v2 07/23] qcow2: handle_alloc(): Get rid of keep_clusters parameter

2013-02-13 Thread Kevin Wolf
handle_alloc() is now called with the offset at which the actual new allocation starts instead of the offset at which the whole write request starts, part of which may already be processed. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 44 +++- b

[Qemu-devel] [PATCH 1/2] block: use Error in do_check_io_limits()

2013-02-13 Thread Stefan Hajnoczi
The do_check_io_limits() function returns false when I/O limits are invalid but it doesn't set an Error to indicate why. The two do_check_io_limits() callers duplicate error reporting. Solve this by passing an Error pointer into do_check_io_limits(). Note that the two callers report slightly dif

[Qemu-devel] [RFC PATCH v2 09/23] qcow2: Clean up handle_alloc()

2013-02-13 Thread Kevin Wolf
Things can be simplified a bit now. No semantic changes. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 110 +++- 1 files changed, 53 insertions(+), 57 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index e32bfe3..0642

[Qemu-devel] [RFC v5] target-i386: Slim conversion to X86CPU subclasses + KVM subclasses

2013-02-13 Thread Igor Mammedov
From: Andreas Färber Depends on http://lists.gnu.org/archive/html/qemu-devel/2013-02/msg00677.html Move x86_def_t definition to header and embed into X86CPUClass. Register types per built-in model definition. Move version initialization from x86_cpudef_setup() to class_init(). Move default set

[Qemu-devel] [RFC PATCH v2 12/23] qcow2: handle_copied(): Get rid of keep_clusters parameter

2013-02-13 Thread Kevin Wolf
Now *bytes is used to return the length of the area that can be written to without performing an allocation or COW. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/block/qcow2-cluster.c b/block/q

[Qemu-devel] [RFC PATCH v2 03/23] qcow2: Change handle_dependency to byte granularity

2013-02-13 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 40 block/qcow2.h | 11 +++ 2 files changed, 39 insertions(+), 12 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 0e804ba..a3b2447 100644 --- a/block/q

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Paolo Bonzini
Il 13/02/2013 15:30, Stefan Priebe - Profihost AG ha scritto: > I added this: > -trace events=/tmp/events,file=/root/qemu.123.trace > > and put the events in the events file as i couldn't handle \n in my app > starting the kvm process. But even when doing an fstrim the trace file > stays at 24 byt

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-13 Thread Igor Mammedov
On Tue, 12 Feb 2013 12:48:47 -0200 Eduardo Habkost wrote: > On Mon, Feb 11, 2013 at 02:52:49AM +0100, Igor Mammedov wrote: > > On Fri, 8 Feb 2013 16:13:02 -0200 > > Eduardo Habkost wrote: > > > > > On Fri, Feb 08, 2013 at 05:54:50PM +0100, Andreas Färber wrote: > > > > Am 08.02.2013 15:52, schr

[Qemu-devel] [RFC PATCH v2 13/23] qcow2: handle_copied(): Implement non-zero host_offset

2013-02-13 Thread Kevin Wolf
Look only for clusters that start at a given physical offset. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 26 ++ 1 files changed, 18 insertions(+), 8 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 5ce2c88..90fe36c 100644 --- a/b

[Qemu-devel] [RFC PATCH v2 23/23] qcow2: Gather clusters in a looping loop

2013-02-13 Thread Kevin Wolf
Instead of just checking once in exactly this order if there are dependendies, non-COW clusters and new allocation, this starts looping around these. This way we can, for example, gather non-COW clusters after new allocations as long as the host cluster offsets stay contiguous. More importantly, a

[Qemu-devel] [RFC PATCH v2 15/23] qcow2: Allow requests with multiple l2metas

2013-02-13 Thread Kevin Wolf
Instead of expecting a single l2meta, have a list of them. This allows to still have a single I/O request for the guest data, even though multiple l2meta may be needed in order to describe both a COW overwrite and a new cluster allocation (typical sequential write case). Signed-off-by: Kevin Wolf

  1   2   >