On Thu, Feb 7, 2013 at 4:59 PM, Kuo-Jung Su wrote:
> \
>
> 2013/2/7 Peter Crosthwaite :
>> Hi Kuo-Jung,
>>
>> On Wed, Feb 6, 2013 at 7:45 PM, Kuo-Jung Su wrote:
>>> From: Kuo-Jung Su
>>>
>>> The FTSPI020 is an integrated SPI Flash controller
>>> which supports upto 4 flash chips.
>>>
>>> Signed-
Allows for repeating of -sd arguments in the same way as -pflash and -mtdblock.
Acked-by: Igor Mitsyanko
Reviewed-by: Peter Maydell
Signed-off-by: Peter Crosthwaite
---
vl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index a8dc73d..a6cd940 100644
---
\
2013/2/7 Peter Crosthwaite :
> Hi Kuo-Jung,
>
> On Wed, Feb 6, 2013 at 7:45 PM, Kuo-Jung Su wrote:
>> From: Kuo-Jung Su
>>
>> The FTSPI020 is an integrated SPI Flash controller
>> which supports upto 4 flash chips.
>>
>> Signed-off-by: Kuo-Jung Su
>> ---
>> hw/arm/Makefile.objs |1 +
>>
From: Liming Wang
The IRQ number of the second EHCI controller should be 76, not 75.
Signed-off-by: Liming Wang
Tested-by: Peter Crosthwaite
---
hw/xilinx_zynq.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c
index 0ac33b5..311f79
The Xilinx Zynq device has two SDHCI controllers. Added to the machine model.
Reviewed-by: Peter Maydell
Signed-off-by: Peter Crosthwaite
---
hw/xilinx_zynq.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c
index 0ac33b5..3
[Original cover by Igor]
First patch introduces standard SD host controller model. This is accumulated
version of my previous patch I sent a while ago and a recent SDHCI patch by
Peter A. G. Crosthwaite. Second patch introduces Exynos4210-specific SDHCI
built on top of standard SDHCI model.
Sec
Add dtc submodule as a fallback for old distros.
Picking version 1.3.0. as this is the most recently tagged stable version.
Signed-off-by: Peter Crosthwaite
---
.gitmodules |3 +++
dtc |1 +
2 files changed, 4 insertions(+), 0 deletions(-)
create mode 16 dtc
diff --git a/.g
On 02/07/2013 08:25 AM, Michael Roth wrote:
> 1ceef9f27359cbe92ef124bf74de6f792e71f6fb added handling for cleaning
> up multiple queues in qemu_del_nic() for cases where multiqueue is in
> use. To determine the number of queues it looks at nic->conf->queues,
> then iterates through all the queues t
Configure to use the DTC submodule to build libfdt when no system libfdt
is found. Prompt to install the DTC submodule if --enable-fdt is set but
no DTC can be found.
DTC has no out-of-tree build capability, so the configure will symlink
the Makefile and scripts directory in the out of tree build
These two patches add and use dtc as a submodule as per the RFC:
http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg05000.html
There is a remaining action item to mandate libfdt for arm/microblaze and PPC
which is left as follow up work for after review of this series.
Peter Crosthwaite (2
Factor out the hexdumper functionality from iov for all to use. Useful for
creating verbose debug printfery that dumps packet data.
Signed-off-by: Peter Crosthwaite
---
See v9 of the pl330 series for example usage.
include/qemu/hexdump.h |3 +++
util/Makefile.objs |1 +
util/hexdump
mdroth writes:
> On Wed, Feb 06, 2013 at 09:14:12PM +0100, Markus Armbruster wrote:
>> mdroth writes:
>>
>> > On Wed, Feb 06, 2013 at 10:06:03AM +0100, Markus Armbruster wrote:
[...]
>> >> --
>> >> in : 1
>> >> out:
>> >> b64:
>> >> in : 1=
>> >> out:
>> >> b64:
>> >> in : 1==
>> >> out:
Currently, M25P80 uses an object property to differentiate between flash parts.
Changed this over to use QOM sub-classes - the actual names of the different
parts
are used to create a set of dynamic classes which passes the part info as class
data. The object no longer needs to search the known_de
On Mon, Feb 04, 2013 at 10:28:00AM +0800, liguang wrote:
> the old numa format got form fw_cfg is:
> number of nodes
> node id of cpu (array)
> node memory size (array)
>
> now, format it like array of:
> apci_map,
> memory_size,
>
> it has the advantage of simple and clear.
With this change, wi
"Michael S. Tsirkin" writes:
> Maybe we should ask for some centrally assigned vendor id?
> We could ask IANA to keep the database.
Or we could make it the task of the virtio spec. I don't think it's
vital...
Cheers,
Rusty.
On Mon, Feb 04, 2013 at 10:27:59AM +0800, liguang wrote:
> Signed-off-by: liguang
Thanks. Some comments.
[...]
> --- a/src/acpi.h
> +++ b/src/acpi.h
[...]
> +#include "acpi-dsdt.hex"
Moving the acpi structure defines to the header is fine, but moving
the DSDT code into the header is definitely
Hi,
On behalf of the QEMU Team, I'd like to announce the availability of the
second release candidate for the QEMU 1.4 release. This release is meant
for testing purposes and should not be used in a production environment.
http://wiki.qemu.org/download/qemu-1.4.0-rc1.tar.bz2
You can help improv
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Jesse Larrew writes:
> This patch set fixes an issue with virtio Windows drivers when multiqueue
> is enabled. This is a narrow fix for 1.4, and I intend to generalize the
> approach for all virtio devices in 1.5.
I applied these for -rc1 because I like this better than hard coding the
old confi
Applied. Thanks.
Regards,
Anthony Liguori
Vadim Rozenfeld writes:
> On Tue, 2013-02-05 at 13:58 +0200, Michael S. Tsirkin wrote:
>> On Tue, Feb 05, 2013 at 03:45:38PM +0400, Michael Tokarev wrote:
>> Is it really
>> > that bad that the config space size changed? Why it has this effect?
> Because in this case it's hard to distinguish bet
On 02/05/2013 11:49 PM, Lucas Meneghel Rodrigues wrote:
On 02/05/2013 09:58 AM, Michael S. Tsirkin wrote:
Vadim, can you please describe in a bit more details what the actual
issue
here is, from the windows or windows driver point of view? Is it really
that bad that the config space size change
1ceef9f27359cbe92ef124bf74de6f792e71f6fb added handling for cleaning
up multiple queues in qemu_del_nic() for cases where multiqueue is in
use. To determine the number of queues it looks at nic->conf->queues,
then iterates through all the queues to cleanup the associated
NetClientStates. If no queu
On Wed, Feb 06, 2013 at 10:22:32PM +, Auld, Will wrote:
> Marcelo, Hi,
>
> I have been watching for this patch in the upstream but have not seen it yet.
> What version of QEMU should it be in?
>
> Thanks,
>
> Will
Will, its in the GIT tree:
https://github.com/qemu/qemu/commit/f28558d3d37ad
On Tue, Feb 05, 2013 at 09:00:21PM +0200, Michael S. Tsirkin wrote:
> Fixes a couple of regression bugs introduced by
> b9d03e352cb6b31a66545763f6a1e20c9abf0c2c and related to
> auto-negotiation:
> - Auto-negotiation currently sets link up even if it was
> forced down from the monitor.
> -
On 02/06/2013 05:52 PM, Cole Robinson wrote:
> On 01/22/2013 05:09 AM, Gerd Hoffmann wrote:
>> From: Alon Levy
>>
>> This is a simpler solution to 869981, where migration breaks since qxl's
>> rom bar size has changed. Instead of ignoring fields in QXLRom, which is
>> what has
>> actually changed
On 01/22/2013 05:09 AM, Gerd Hoffmann wrote:
> From: Alon Levy
>
> This is a simpler solution to 869981, where migration breaks since qxl's
> rom bar size has changed. Instead of ignoring fields in QXLRom, which is what
> has
> actually changed, we remove some of the modes, a mechanism already
>
On Mon, Feb 4, 2013 at 7:56 PM, Kuo-Jung Su wrote:
> From: Kuo-Jung Su
>
> Atmel, SST and Intel/Numonyx serial flash tend to power up
> with the software protection bits set.
> And thus the new m25p80.c in linux kernel would always tries
> to use WREN(0x06) + WRSR(0x01) to turn-off the protection
Hi Kuo-Jung,
On Wed, Feb 6, 2013 at 7:45 PM, Kuo-Jung Su wrote:
> From: Kuo-Jung Su
>
> The FTSPI020 is an integrated SPI Flash controller
> which supports upto 4 flash chips.
>
> Signed-off-by: Kuo-Jung Su
> ---
> hw/arm/Makefile.objs |1 +
> hw/arm/faraday_a369.c | 12 ++
> hw/arm/fts
Marcelo, Hi,
I have been watching for this patch in the upstream but have not seen it yet.
What version of QEMU should it be in?
Thanks,
Will
> -Original Message-
> From: Marcelo Tosatti [mailto:mtosa...@redhat.com]
> Sent: Friday, November 30, 2012 12:40 PM
> To: Auld, Will
> Cc: qemu
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
The data returned has a well-defined size, which makes the size
returned along with it redundant at best. Drop it.
Signed-off-by: Markus Armbruster
---
hmp.c| 11 ---
qapi-schema.json | 18 ++
qemu-char.c | 21 +
qmp-commands.hx | 2
On Wed, Feb 06, 2013 at 09:14:12PM +0100, Markus Armbruster wrote:
> mdroth writes:
>
> > On Wed, Feb 06, 2013 at 10:06:03AM +0100, Markus Armbruster wrote:
> >> Markus Armbruster writes:
> >>
> >> > Eric Blake writes:
> >> >
> >> >> On 02/05/2013 09:22 AM, Markus Armbruster wrote:
> >> >>> Co
This patch enables us to know state of migration (MigrationState.state)
transition. We added migstate_set() to make it easier to trace state
transition, and added a tracepoint in this function.
Signed-off-by: Kazuya Saito
---
include/migration/migration.h |2 ++
migration.c
Command memchar-write takes data and size parameter. Begs the
question what happens when data doesn't match size.
With format base64, qmp_memchar_write() copies the full data argument,
regardless of size argument.
With format utf8, qmp_memchar_write() copies size bytes from data,
happily reading
This patchset implements asynchronous deduplication in QCOW2 on top of the
"QCOW2 deduplication metrics" V2 patchset.
It's a work in progress posted so reviewers can see where the feature is
heading.
v2:
Merge qmp-pause-dedup and qmp-resume-dedup qmp-dedup control. [Eric]
Simplify error h
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
On Wed, Feb 06, 2013 at 01:31:41PM +0100, Benoît Canet wrote:
> @@ -291,7 +297,11 @@ static int
> qcow2_clear_l2_copied_flag_if_needed(BlockDriverState *bs,
> /* remember that we dont't need to clear QCOW_OFLAG_COPIED again */
> hash_node->first_logical_sect &= first_logical_sect;
>
>
Inline trivial cirmem_chr_is_empty() into its only caller.
Rename qemu_chr_cirmem_count() to cirmem_count().
Fast ring buffer index wraparound. Without this, there's no point in
restricting size to a power two.
qemu_is_chr(chr, "memory") returns *zero* when chr is a memory
character device, whi
Signed-off-by: Markus Armbruster
---
hmp-commands.hx | 2 ++
hmp.c | 15 ++-
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 66ec716..4c100d7 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -869,6 +869,8 @@ STEXI
We have a serious design bug in memchar-write [PATCH 01], and a less
serious one in memchar-read [PATCH 02]. I really, really want them
fixed before the API gets calcified by the release.
While discussing v1, I mentioned to Luiz how much I dislike the messy
naming, and he encouraged me to fix it
New errors should be generic unless there's a real use case for rich
errors.
Signed-off-by: Markus Armbruster
---
qapi-schema.json | 2 --
qemu-char.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index d8fa1c3..6f63791 100644
-
Signed-off-by: Markus Armbruster
---
qemu-char.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index b1c6132..4dd01e6 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2782,6 +2782,10 @@ void qmp_memchar_write(const char *device, const char
*data,
ret =
On 02/04/13 13:12, Stefan Hajnoczi wrote:
> aio-posix.c could not take advantage of G_IO_HUP and G_IO_ERR because
> select(2) does not have equivalent events. Now that g_poll(3) is used
> we can support G_IO_HUP and G_IO_ERR.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> aio-posix.c | 12 ++---
Undocumented misfeature, get rid of it while we can.
Signed-off-by: Markus Armbruster
---
qemu-char.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index b0e4b41..2f59a61 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2678,11 +2678,6 @@ static int cirmem_chr_w
Signed-off-by: Markus Armbruster
---
qemu-char.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 8a35403..a3ba021 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -98,7 +98,6 @@
#include "ui/qemu-spice.h"
#define READ_BUF_LEN 4096
-#def
Signed-off-by: Markus Armbruster
---
qemu-char.c | 4
1 file changed, 4 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 4dd01e6..9d1c02c 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2818,10 +2818,6 @@ char *qmp_memchar_read(const char *device, int64_t size,
}
count
Const-correctness, consistently use standard C types instead of mixing
them with GLib types.
Signed-off-by: Markus Armbruster
---
qemu-char.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 2bdd1bb..b1c6132 100644
--- a/qemu-char.c
+++ b/
On Wed, Feb 06, 2013 at 01:31:40PM +0100, Benoît Canet wrote:
> +/* Deduplicate all the cluster that can be deduplicated.
> + *
> + * Next it compute the number of non deduplicable sectors to come while
> storing
s/compute/computes/
> + * the hashes of these sectors in a linked list for later us
On 02/06/2013 01:27 PM, Markus Armbruster wrote:
> We have a serious design bug in memchar-write [PATCH 01], and a less
> serious one in memchar-read [PATCH 02]. I really, really want them
> fixed before the API gets calcified by the release.
Series:
Reviewed-by: Eric Blake
--
Eric Blake ebl
---
include/block/block_int.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 62c72fc..69fbe8a 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -205,6 +205,9 @@ struct BlockDriver {
*/
int (*b
---
block.c | 15 +++
include/block/block.h |1 +
2 files changed, 16 insertions(+)
diff --git a/block.c b/block.c
index fec29f4..e9d7764 100644
--- a/block.c
+++ b/block.c
@@ -4291,6 +4291,21 @@ void bdrv_lock_medium(BlockDriverState *bs, bool locked)
}
}
comments in-line
On 02/04/13 13:12, Stefan Hajnoczi wrote:
> AioHandler already has a GPollFD so we can directly use its
> events/revents.
>
> Add the int pollfds_idx field to AioContext so we can map g_poll(3)
> results back to AioHandlers.
>
> Reuse aio_dispatch() to invoke handlers after g_poll
From: Andreas Färber
Signed-off-by: Andreas Färber
---
hw/tmp105.c | 27 +--
1 Datei geändert, 25 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
diff --git a/hw/tmp105.c b/hw/tmp105.c
index 3ad2d2f..5dafa37 100644
--- a/hw/tmp105.c
+++ b/hw/tmp105.c
@@ -23,6 +23,18 @@
#
Signed-off-by: Markus Armbruster
---
qemu-char.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qemu-char.c b/qemu-char.c
index 9d1c02c..b0e4b41 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2819,7 +2819,7 @@ char *qmp_memchar_read(const char *device, int64_t size,
New device, has never been released, so we can still improve things
without worrying about compatibility.
Naming is a mess. The code calls the device driver CirMemCharDriver,
the public API calls it "memory", "memchardev", or "memchar", and the
special commands are named like "memchar-FOO". "mem
This is a new device, so there's no compatibility to maintain, and its
use case isn't common enough to justify shorthand syntax.
Signed-off-by: Markus Armbruster
---
qemu-char.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 2f59a61..cdbbafe 100644
--- a/
On Wed, 2013-02-06 at 14:13 -0500, Laine Stump wrote:
> Now that qemu is getting the q35 machine type, libvirt needs to
> support it.
>
> As far as I understand, from libvirt's point of view, q35 is just
> another x86_64 system, but with a different set of implicit devices,
> and possibly some ext
mdroth writes:
> On Wed, Feb 06, 2013 at 10:06:03AM +0100, Markus Armbruster wrote:
>> Markus Armbruster writes:
>>
>> > Eric Blake writes:
>> >
>> >> On 02/05/2013 09:22 AM, Markus Armbruster wrote:
>> >>> Command memchar-write takes data and size parameter. Begs the
>> >>> question what hap
---
include/block/block.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/block/block.h b/include/block/block.h
index 162f8a9..4d61ff4 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -29,6 +29,9 @@ typedef struct BlockDriverInfo {
/* offset at which the VM
This reverts commit 9ca111544c64b5abed2e79cf52e19a8f227b347b.
That commit has added a weird side effect to QMP: on shutdown,
QMP emits the DEVICE_TRAY_MOVED event for all empty drives
that have closed trays.
This happens because the tray state actually changes in
the following code path:
main
Now that qemu is getting the q35 machine type, libvirt needs to support it.
As far as I understand, from libvirt's point of view, q35 is just another
x86_64 system, but with a different set of implicit devices, and possibly some
extra rules limiting which devices can be plugged into which bus/sl
From: Andreas Färber
The libqos driver for omap_i2c currently does not work on Big Endian.
Introduce helpers for reading from and writing to 16-bit armel registers.
This fixes tmp105-test failures on ppc.
To prepare for a QTest-level endianness solution, poison mem{read,write}
and always use th
Introduce [qtest_]{read,write}[bwlq]() libqtest functions and
corresponding QTest protocol commands to replace local versions in
libi2c-omap.c.
Signed-off-by: Andreas Färber
---
qtest.c | 53 +
tests/libi2c-omap.c | 23 -
From: Andreas Färber
Instead of comparing bytes individually, compare the full values.
This aids spotting endianness issues.
Signed-off-by: Andreas Färber
---
tests/tmp105-test.c |8
1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-)
diff --git a/tests/tmp105-test.c
On 32-bit hosts, unsigned long may be uint32_t and uint64_t may be
unsigned long long. Account for this by always using strtoull().
We were already using strtoll() for int64_t.
Signed-off-by: Andreas Färber
---
qtest.c |8
1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt
Hello Anthony,
Here's my enhanced attempt to resolve our QTest endianness crisis. :)
Patch 1 fixes some minor type inconsistencies I noticed in qtest.c.
Patch 2 uses helpers to fix libi2c-omap.c asserting on Big Endian hosts.
Patch 3 improves the readability of assertions in tmp105-test.c.
Patch
Am 06.02.2013 17:39, schrieb Paolo Bonzini:
> In order to finish the implementation of thin provisioning, we need to
> add a -drive option to describe how guest discard requests are mapped to
> host requests.
>
> We have three possibilities:
>
> - hide them and make them always succeed
> - transl
On 02/04/13 13:12, Stefan Hajnoczi wrote:
> We will need to loop over AioHandlers calling ->io_read()/->io_write()
> when aio_poll() is converted from select(2) to g_poll(2).
>
> Luckily the code for this already exists, extract it into the new
> aio_dispatch() function.
>
> Two small changes:
>
---
block.c | 16
include/block/block.h |1 +
2 files changed, 17 insertions(+)
diff --git a/block.c b/block.c
index e9d7764..3f0bccc 100644
--- a/block.c
+++ b/block.c
@@ -4306,6 +4306,22 @@ bool bdrv_has_dedup(BlockDriverState *bs)
return bdi.has_dedup;
On 02/04/13 13:12, Stefan Hajnoczi wrote:
> Now that all *_fill() and *_poll() functions use GPollFD we no longer
> need rfds/wfds/xfds or pollfds_from_select()/pollfds_to_select().
>
> From now on everything uses GPollFD.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> main-loop.c | 77
> ++---
> > +/*
> > + * Build a QCowHashNode from a given QCowHash and insert it into the tree
> > + *
> > + * @hash: the given QCowHash
> > + */
> > +static void qcow2_build_and_insert_hash_node(BlockDriverState *bs,
> > + QCowHash *hash)
> > +{
> > +BDRVQco
On 02/06/2013 05:31 AM, Benoît Canet wrote:
> This function is used to read missing data when unaligned writes are
> done. This function also concatenate missing data with the given
> qiov data in order to prepare a buffer used to look for duplicated
> clusters.
>
> +/*
> + * Prepare a buffer con
On 02/06/2013 05:31 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/qcow2-dedup.c | 325
> ++-
> block/qcow2.h |5 +
> 2 files changed, 329 insertions(+), 1 deletion(-)
>
> +
> +/* Remember that this QCowHashNod
On 02/04/13 13:12, Stefan Hajnoczi wrote:
> Convert iohandler_select_fill() and iohandler_select_poll() to use
> GPollFD instead of rfds/wfds/xfds.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> include/qemu/main-loop.h | 4 ++--
> iohandler.c | 40 ++---
On 02/06/2013 05:31 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/qcow2-refcount.c |6 +-
> block/qcow2.h |2 ++
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> @@ -413,7 +409,7 @@ fail_block:
> }
>
> /* XXX: cache several refcount block clus
On Wed, Feb 06, 2013 at 01:31:37PM +0100, Benoît Canet wrote:
> +/*
> + * Prepare a buffer containing all the required data required to compute
> cluster
Easier to read this way:
s/all the required data required/everything required/
> + * sized deduplication hashes.
> + * If sector_num or nb_sec
On 02/06/13 15:35, Markus Armbruster wrote:
> As a general rule, HMP commands must be built on top of the QMP API.
> Luiz and others have worked long & hard to make HMP conform to this
> rule.
>
> However, a new command has crept in that violates it.
>
> QMP's chardev-add runs qmp_chardev_add(),
On Mon, Feb 04, 2013 at 12:36:25AM +0400, Michael Tokarev wrote:
> As reported in http://bugs.debian.org/697641 , some Hungarian keys
> does not work with qemu when using vnc display.
>
> This is because while the Hungarian keymap mentions these symbols,
> qemu know nothing about them. So add the
On Wed, Feb 06, 2013 at 01:31:40PM +0100, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/qcow2-dedup.c | 436
> +++
> block/qcow2.h |5 +
> 2 files changed, 441 insertions(+)
>
> diff --git a/block/qcow2-dedup.c b/block
---
qapi-schema.json | 40 +++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index cf4e9d6..ec61f6a 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -814,6 +814,40 @@
From: Petar Jovanovic
The change corrects sign-related issue with MULQ_S.PH. It also includes
extension to the already existing test which will trigger the issue.
Signed-off-by: Petar Jovanovic
---
target-mips/dsp_helper.c|2 +-
tests/tcg/mips/mips32-dspr2/mulq_s_ph.c | 1
On 2013-02-06 06:49, Stefan Hajnoczi wrote:
$ echo "int main() {return 0;}" | gcc -D_FORTIFY_SOURCE=2 -x c -
:0:0: warning: "_FORTIFY_SOURCE" redefined [enabled by default]
:1:0: note: this is the location of the previous definition
in which case we must undefine it. However, if the _FORTIFY_SOU
On Wed, Feb 06, 2013 at 01:31:39PM +0100, Benoît Canet wrote:
> diff --git a/block/qcow2.h b/block/qcow2.h
> index 8867091..95bf848 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -63,6 +63,10 @@
> #define DEFAULT_CLUSTER_SIZE 65536
>
> #define HASH_LENGTH 32
> +/* indicate that the has
On Wed, Feb 06, 2013 at 01:31:36PM +0100, Benoît Canet wrote:
> diff --git a/block/qcow2.h b/block/qcow2.h
> index 718b52b..c7b6860 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -43,6 +43,10 @@
> #define QCOW_OFLAG_COPIED (1LL << 63)
> /* indicate that the cluster is compressed (the
On Wed, Feb 06, 2013 at 01:31:38PM +0100, Benoît Canet wrote:
> /* XXX: cache several refcount block clusters ? */
> -static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
> +int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
Public functions are prefixed with qc
On Wed, Feb 06, 2013 at 10:06:03AM +0100, Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > Eric Blake writes:
> >
> >> On 02/05/2013 09:22 AM, Markus Armbruster wrote:
> >>> Command memchar-write takes data and size parameter. Begs the
> >>> question what happens when data doesn't mat
In order to finish the implementation of thin provisioning, we need to
add a -drive option to describe how guest discard requests are mapped to
host requests.
We have three possibilities:
- hide them and make them always succeed
- translate them to ANCHOR requests, i.e. mark the space as discarde
On 02/06/2013 05:31 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/qcow2.h | 69
> -
> 1 file changed, 68 insertions(+), 1 deletion(-)
>
> diff --git a/block/qcow2.h b/block/qcow2.h
> index 718b52b..c7b6860 100644
>
On Tue, 5 Feb 2013 17:22:03 +0100
Markus Armbruster wrote:
> We have a serious design bug in memchar-write [PATCH 01], and a less
> serious one in memchar-read [PATCH 02]. I really, really want them
> fixed before the API gets calcified by the release.
Nice series, just minor comments from me.
On 02/06/2013 05:31 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> docs/specs/qcow2.txt | 105
> +-
> 1 file changed, 103 insertions(+), 2 deletions(-)
>
> diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
> index 36a559d..8
On 02/06/13 17:07, Markus Armbruster wrote:
> Disable the HMP command for now, along with its chardev-remove buddy.
qmp and hmp chardev-remove are identical
Makes sense nevertheless for symmetry reasons.
Acked-by: Gerd Hoffmann
cheers,
Gerd
Luiz Capitulino writes:
> On Tue, 5 Feb 2013 17:22:07 +0100
> Markus Armbruster wrote:
>
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> qemu-char.c | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/qemu-char.c b/qemu-char.c
>> index 892d5bb..9bf53e0 100644
>> --- a/qemu-cha
1 - 100 of 249 matches
Mail list logo
