[Qemu-devel] [PATCH V4 RESEND 17/22] virtio: introduce virtio_del_queue()

2013-01-31 Thread Jason Wang
Some device (such as virtio-net) needs the ability to destroy or re-order the virtqueues, this patch adds a helper to do this. Signed-off-by: Jason Wang Signed-off-by: Michael S. Tsirkin --- hw/virtio.c |9 + hw/virtio.h |2 ++ 2 files changed, 11 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH V11 2/4] Create four opts list related functions

2013-01-31 Thread Dong Xu Wang
于 2013-1-26 2:13, Blue Swirl 写道: On Thu, Jan 24, 2013 at 6:59 PM, Markus Armbruster wrote: Dong Xu Wang writes: This patch will create 4 functions, count_opts_list, append_opts_list, free_opts_list and print_opts_list, they will used in following commits. Signed-off-by: Dong Xu Wang --- v6

[Qemu-devel] [PATCH V4 RESEND 15/22] tap: multiqueue support

2013-01-31 Thread Jason Wang
Recently, linux support multiqueue tap which could let userspace call TUNSETIFF for a signle device many times to create multiple file descriptors as independent queues. User could also enable/disabe a specific queue through TUNSETQUEUE. The patch adds the generic infrastructure to create multique

Re: [Qemu-devel] [PATCH for-1.4] Revert "e1000: no need auto-negotiation if link was down"

2013-01-31 Thread Amos Kong
On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: > On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: > > This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. > > > > I'm not sure what issue the original commit was meant to fix, or if > > the logic is actually wrong,

[Qemu-devel] [PATCH V4 RESEND 19/22] virtio-net: separate virtqueue from VirtIONet

2013-01-31 Thread Jason Wang
To support multiqueue virtio-net, the first step is to separate the virtqueue related fields from VirtIONet to a new structure VirtIONetQueue. The following patches will add an array of VirtIONetQueue to VirtIONet based on this patch. Signed-off-by: Jason Wang Signed-off-by: Michael S. Tsirkin -

[Qemu-devel] [PATCH V4 RESEND 14/22] tap: introduce a helper to get the name of an interface

2013-01-31 Thread Jason Wang
This patch introduces a helper tap_get_ifname() to get the device name of tap device. This is needed when ifname is unspecified in the command line and qemu were asked to create tap device by itself. In this situation, the name were allocated by kernel, so if multiqueue is asked, we need to fetch i

[Qemu-devel] [PATCH V4 RESEND 08/22] net: introduce NetClientState destructor

2013-01-31 Thread Jason Wang
To allow allocating an array of NetClientState and free it once, this patch introduces destructor of NetClientState. Which could do type specific free, which could be used by multiqueue to free the array once. Signed-off-by: Jason Wang Signed-off-by: Michael S. Tsirkin --- include/net/net.h |

[Qemu-devel] [PATCH V4 RESEND 07/22] net: introduce qemu_net_client_setup()

2013-01-31 Thread Jason Wang
This patch separates the setup of NetClientState from its allocation, this will allow allocating an arrays of NetClientState and does the initialization one by one which is what multiqueue needs. Signed-off-by: Jason Wang Signed-off-by: Michael S. Tsirkin --- net/net.c | 29 ++

[Qemu-devel] [PATCH V4 RESEND 03/22] net: introduce qemu_get_queue()

2013-01-31 Thread Jason Wang
To support multiqueue, the patch introduce a helper qemu_get_queue() which is used to get the NetClientState of a device. The following patches would refactor this helper to support multiqueue. Signed-off-by: Jason Wang Signed-off-by: Michael S. Tsirkin --- hw/cadence_gem.c|9 +++--

[Qemu-devel] [PATCH V4 RESEND 00/22] Multiqueue virtio-net

2013-01-31 Thread Jason Wang
Hello all: This seires is an update of last version of multiqueue virtio-net support. This series tries to brings multiqueue support to virtio-net through a multiqueue support tap backend and multiple vhost threads. Patch 1 converts bitfield in TAPState to bool. Patch 2 replace assert(0) with ab

Re: [Qemu-devel] [PATCH v3 0/5] XBZRLE fixes

2013-01-31 Thread Juan Quintela
Orit Wasserman wrote: > Changes for V3: > Fix year in xbzrle.c copyright notice > Add copyright notice to test-xbzrle.c, use stack variable > for 2 byte array and fix spacing. > > This series add some testing to the XBZRLE compression > and fixes the error in loading a guest from a compressed file

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Avi Kivity
On Jan 31, 2013 11:14 PM, "Michael S. Tsirkin" wrote: > > On Thu, Jan 31, 2013 at 05:20:02PM +0200, Avi Kivity wrote: > > On Thu, Jan 31, 2013 at 4:42 PM, Gleb Natapov wrote: > > > On Thu, Jan 31, 2013 at 04:36:25PM +0200, Avi Kivity wrote: > > >> On Thu, Jan 31, 2013 at 4:30 PM, Gleb Natapov wr

Re: [Qemu-devel] [PATCH for-1.4] Revert "e1000: no need auto-negotiation if link was down"

2013-01-31 Thread Amos Kong
On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: > This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. > > I'm not sure what issue the original commit was meant to fix, or if > the logic is actually wrong, but it causes e1000 to stop working > after a guest issues a reset.

Re: [Qemu-devel] [PATCH V17 07/10] libqblock: libqblock API design and type defines

2013-01-31 Thread Wenchao Xia
Thank u for reviewing so many code. + +#ifndef LIBQBLOCK_ERROR +#define LIBQBLOCK_ERROR + +#include "libqblock-types.h" + +#define QB_ERR_INTERNAL_ERR (-1) +#define QB_ERR_FATAL_ERR (-2) +#define QB_ERR_INVALID_PARAM (-100) +#define QB_ERR_BLOCK_OUT_OF_RANGE (-101) + +/* error handling */ +/** +

Re: [Qemu-devel] [PATCH WIP 0/4] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-01-31 Thread Asias He
On 01/31/2013 07:12 PM, Michael S. Tsirkin wrote: > On Wed, Jan 30, 2013 at 05:41:22PM +0100, Paolo Bonzini wrote: >> Ok, so here is my attempt at a vhost-scsi device. I'm creating an >> entirely separate device, with the common parts of virtio-scsi and >> vhost-scsi (actually little more than the

Re: [Qemu-devel] [PATCH V17 04/10] libqblock: build: add rule for libqblock.la

2013-01-31 Thread Wenchao Xia
于 2013-1-31 22:36, Stefan Hajnoczi 写道: On Thu, Jan 31, 2013 at 04:53:44PM +0800, Wenchao Xia wrote: diff --git a/libqblock/Makefile b/libqblock/Makefile index 8173da7..a6be721 100644 --- a/libqblock/Makefile +++ b/libqblock/Makefile @@ -1,4 +1,29 @@ all: libqblock.la -libqblock.la: - @t

Re: [Qemu-devel] [PATCH v2 01/20] arm: add Faraday a36x SoC platform support

2013-01-31 Thread Kuo-Jung Su
2013/2/1 Kuo-Jung Su : > 2013/2/1 Igor Mitsyanko >> >> Hi, Kuo-Jung, please see several comments bellow. >> >> >> >> On 01/25/2013 12:19 PM, Kuo-Jung Su wrote: >>> >>> From: Kuo-Jung Su >>> >>> The Faraday A360/A369 EVB is a Faraday platform main board used for the >>> Faraday IP functional verif

[Qemu-devel] [PATCH 4/4] target-s390x: Pass S390CPU to s390_{add, del}_running_cpu()

2013-01-31 Thread Alexander Graf
From: Andreas Färber This prepares for moving the halted field to CPUState. Most call sites can already supply S390CPU, for some env becomes unused. Signed-off-by: Andreas Färber Acked-by: Cornelia Huck Signed-off-by: Alexander Graf --- hw/s390x/ipl.c |6 -- hw/s390x/s390-vir

Re: [Qemu-devel] [PATCH V17 03/10] libqblock: build: add configure support

2013-01-31 Thread Wenchao Xia
于 2013-1-31 22:18, Stefan Hajnoczi 写道: On Thu, Jan 31, 2013 at 04:53:43PM +0800, Wenchao Xia wrote: +## +# libqblock probe +if test "$libqblock" != "no"; then +if test -n "$libtool" && +$pkg_config --atleast-version=$glib_req_ver glib-2.0 >

[Qemu-devel] [PULL 00/12] QOM CPUState patch queue 2013-02-01

2013-01-31 Thread Andreas Färber
Hello, This is my current QOM CPU patch queue to complete the Soft Freeze. Please pull. It includes various cleanups: * unmigratable CPUs, * CPU model types as --cpu, * x86 preparations for further CPUState refactorings, * x86 double CPU reset (partial fix). Regards, Andreas Cc: Anthony Liguori

[Qemu-devel] [PATCH 06/12] target-m68k: Mark as unmigratable

2013-01-31 Thread Andreas Färber
It neither defined CPU_SAVE_VERSION nor implemented cpu_{save,load}(). Mark M68kCPU as unmigratable at device level. Signed-off-by: Andreas Färber Reviewed-by: Juan Quintela --- target-m68k/Makefile.objs |1 - target-m68k/cpu.c |8 2 Dateien geändert, 8 Zeilen hinzugefü

[Qemu-devel] [PATCH 12/12] linux-user: bsd-user: Don't reset X86CPU twice

2013-01-31 Thread Andreas Färber
Since commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386: move cpu_reset and reset callback to cpu.c) the x86 CPU is reset through cpu_init() but was still reset immediately after in linux-user and bsd-user. Clean this up. Similarly in linux-user/syscall.c it is also reset after cpu_copy

[Qemu-devel] [PATCH 10/12] target-unicore32: Rename CPU subtypes

2013-01-31 Thread Andreas Färber
In the initial conversion of CPU models to QOM types, model names were mapped 1:1 to type names. As a side effect this gained us a type "any", which is now a device. To avoid "-device any" silliness and to pave the way for compiling multiple targets into one executable, adopt a --cpu scheme. No f

[Qemu-devel] [PATCH 1/4] target-s390x: Fix debug output (continued)

2013-01-31 Thread Alexander Graf
From: Andreas Färber Since its introduction in d5a439645a5a70fed5431318c3bce9dc2caa950f (s390x: helper functions for system emulation) the variable name was raddr. Fix this. Signed-off-by: Andreas Färber Signed-off-by: Alexander Graf --- target-s390x/helper.c |4 ++-- 1 files changed, 2 i

[Qemu-devel] [PATCH 11/12] target-i386: Pass X86CPU to cpu_x86_set_a20()

2013-01-31 Thread Andreas Färber
Prepares for cpu_interrupt() changing argument to CPUState. While touching it, rename to x86_cpu_...() now that it takes an X86CPU. Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- hw/pc.c |7 --- target-i386/cpu.h|2 +- target-i386/helper.c |4 ++

[Qemu-devel] [PATCH 03/12] target-xtensa: Mark as unmigratable

2013-01-31 Thread Andreas Färber
There was no CPU_SAVE_VERSION defined, so neither "cpu_common" VMState nor cpu_{save,load}() were registered. Their implementation was no-op. Therefore there is no backwards compatibility to keep, so mark XtensaCPU as unmigratable at device level. Signed-off-by: Andreas Färber Reviewed-by: Juan Q

[Qemu-devel] [PATCH 2/4] target-s390x: Fix debug output

2013-01-31 Thread Alexander Graf
From: Andreas Färber Commit 71e470886fb6092504503a5fe41092ace71c096c (target-s390x: fix style) renamed the cpu_s390x_handle_mmu_fault() argument from _vaddr to orig_vaddr. Update the debug output code. Signed-off-by: Andreas Färber Signed-off-by: Alexander Graf --- target-s390x/helper.c |

[Qemu-devel] [PATCH 01/12] target-unicore32: Mark as unmigratable

2013-01-31 Thread Andreas Färber
CPU_SAVE_VERSION 2 was bogus as both save and load would just throw a hw_error(). Therefore we can without problems suppress registration of "cpu_common" VMState by dropping CPU_SAVE_VERSION define and provide an unmigratable "cpu" VMStateDescription for UniCore32CPU at device level instead, where

[Qemu-devel] [PATCH 02/12] target-microblaze: Mark as unmigratable

2013-01-31 Thread Andreas Färber
cpu_{save,load} were no-ops, so de facto it is unmigratable and no backwards compatibility to keep. Therefore mark the MicroBlazeCPU as unmigratable at device level the QOM way and suppress "cpu_common" VMState registration by dropping CPU_SAVE_VERSION. Signed-off-by: Juan Quintela Signed-off-by:

[Qemu-devel] [PATCH 07/12] target-m68k: Rename CPU subtypes

2013-01-31 Thread Andreas Färber
In the initial conversion of CPU models to QOM types, model names were mapped 1:1 to type names. As a side effect this gained us a type "any", which is now a device. To avoid "-device any" silliness and to pave the way for compiling multiple targets into one executable, adopt a --cpu scheme. No f

Re: [Qemu-devel] [PATCH 2/2] usb-ehci: add Faraday FUSBH200 support

2013-01-31 Thread Kuo-Jung Su
2013/1/31 Andreas Färber : > Am 30.01.2013 01:44, schrieb Kuo-Jung Su: >> >> 2013/1/29 Andreas Färber mailto:afaer...@suse.de>> >> >> Gerd, what are your thoughts? If Kuo-Jung doesn't mind, I would offer to >> send a v2 implementing the changes I suggested in the way you prefer. >> >> >> Do

Re: [Qemu-devel] [PATCH v2 01/20] arm: add Faraday a36x SoC platform support

2013-01-31 Thread Kuo-Jung Su
2013/2/1 Igor Mitsyanko > > Hi, Kuo-Jung, please see several comments bellow. > > > > On 01/25/2013 12:19 PM, Kuo-Jung Su wrote: >> >> From: Kuo-Jung Su >> >> The Faraday A360/A369 EVB is a Faraday platform main board used for the >> Faraday IP functional verification based on the well-known ARM

[Qemu-devel] [PATCH 3/4] target-s390x: Clean up cpu_inject_*() signatures

2013-01-31 Thread Alexander Graf
From: Andreas Färber Despite cautioning that S390CPU is needed for upcoming CPUState refactorings, commit 5d69c547d947798cba92d836d06f6e017ba2b19d (s390: I/O interrupt and machine check injection.) added functions cpu_inject_io() and cpu_inject_crw_mchk() with CPUS390XState argument, claiming con

[Qemu-devel] [PATCH 04/12] target-sh4: Mark as unmigratable

2013-01-31 Thread Andreas Färber
It neither defined CPU_SAVE_VERSION nor implemented cpu{save,load}(). Mark it as unmigratable at device level. Signed-off-by: Andreas Färber Reviewed-by: Juan Quintela --- target-sh4/Makefile.objs |1 - target-sh4/cpu.c |9 + 2 Dateien geändert, 9 Zeilen hinzugefügt(+),

[Qemu-devel] [PATCH 08/12] target-openrisc: TYPE_OPENRISC_CPU should be abstract

2013-01-31 Thread Andreas Färber
A basic assumption of CPU subtypes is that only specific models get instantiated. A user is not supposed to instantiate an -cpu. Suppress it via abstract = true, which also drops or32-cpu from -cpu ? output. Cc: qemu-sta...@nongnu.org Cc: Jia Liu Signed-off-by: Andreas Färber --- target-openris

[Qemu-devel] [PATCH 09/12] target-openrisc: Rename CPU subtypes

2013-01-31 Thread Andreas Färber
Model names were mapped 1:1 to type names. As a side effect this registered a type "any", which is now a device. To avoid "-device any" silliness and to pave the way for compiling multiple targets into one executable, adopt a --cpu scheme. No functional changes for -cpu arguments or -cpu ? output

[Qemu-devel] [PULL 0/4] s390 patch queue 2013-02-01

2013-01-31 Thread Alexander Graf
Hi Blue / Aurelien, This is my final pre-hard-freeze patch queue for s390. Please pull. Alex The following changes since commit 6b2578d678497dbce44ed7999d269fc973ae6e8f: Andreas Färber (1): ide/mmio: QOM'ify MMIO IDE for R2D are available in the git repository at: git://repo.or.

Re: [Qemu-devel] [PATCH for-1.4 0/2] target-s390x: CPU cleanups preparing for 1.5

2013-01-31 Thread Alexander Graf
On 31.01.2013, at 17:15, Andreas Färber wrote: > Am 31.01.2013 16:48, schrieb Alexander Graf: >> >> On 31.01.2013, at 16:23, Andreas Färber wrote: >> >>> Am 30.01.2013 23:48, schrieb Andreas Färber: As a reminder here's a link to one of my original discussions of the new types:

[Qemu-devel] [PATCH 1/3] PPC: Unify dcbzl code path

2013-01-31 Thread Alexander Graf
The bit that makes a dcbz instruction a dcbzl instruction was declared as reserved in ppc32 ISAs. However, hardware simply ignores the bit, making code valid if it simply invokes dcbzl instead of dcbz even on 750 and G4. Thus, mark the bit as unreserved so that we properly emulate a simple dcbz in

[Qemu-devel] [PATCH 2/3] target-ppc: Fix unused variable warning for FLUSH_ALL_TLBS

2013-01-31 Thread Alexander Graf
From: Andreas Färber Signed-off-by: Andreas Färber Signed-off-by: Alexander Graf --- target-ppc/mmu_helper.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/target-ppc/mmu_helper.c b/target-ppc/mmu_helper.c index 0aee7a9..f190133 100644 --- a/target-ppc/mmu_helper.c

[Qemu-devel] [PATCH 3/3] target-ppc: Fix build for PPC_DEBUG_DISAS

2013-01-31 Thread Alexander Graf
From: Andreas Färber In r5949 / 76db3ba44ee8db671f804755f13b016eefd13288 (target-ppc: memory load/store rework) variable little_endian was replaced with ctx.le_mode. Update the debug code. Signed-off-by: Andreas Färber Signed-off-by: Alexander Graf --- target-ppc/translate.c |2 +- 1 file

[Qemu-devel] [PULL 0/3] ppc patch queue 2013-02-01

2013-01-31 Thread Alexander Graf
Hi Blue / Aurelien, This is my final pre-hard-freeze patch queue for ppc. Please pull. Alex The following changes since commit 6b2578d678497dbce44ed7999d269fc973ae6e8f: Andreas Färber (1): ide/mmio: QOM'ify MMIO IDE for R2D are available in the git repository at: git://repo.or.c

[Qemu-devel] [PATCH 05/12] target-s390x: Mark as unmigratable

2013-01-31 Thread Andreas Färber
CPU_SAVE_VERSION was undefined, so "cpu_common" VMState and cpu_{save,load}() were not registered. They were no-ops. Therefore there is no backwards compatibility to keep, so we can mark S390CPU as unmigratable at device level. Signed-off-by: Andreas Färber Acked-by: Alexander Graf Reviewed-by:

Re: [Qemu-devel] [PATCH for-1.4] libqtest: Wait for the right child PID after killing QEMU

2013-01-31 Thread Andreas Färber
Am 30.01.2013 03:14, schrieb Anthony Liguori: > Andreas Färber writes: > >> Am 28.01.2013 19:15, schrieb Eduardo Habkost: >>> When running "make check" with gcov enabled, we get the following >>> message: >>> >>>hw/tmp105.gcda:cannot open data file, assuming not executed >>> >>> The problem h

Re: [Qemu-devel] [PATCH for-1.4] libqtest: Wait for the right child PID after killing QEMU

2013-01-31 Thread Andreas Färber
Am 28.01.2013 19:15, schrieb Eduardo Habkost: > When running "make check" with gcov enabled, we get the following > message: > >hw/tmp105.gcda:cannot open data file, assuming not executed > > The problem happens because: > > * tmp105-test exits before QEMU exits, because waitpid() at >q

Re: [Qemu-devel] [PATCH for-1.4 v3] linux-user: bsd-user: Don't reset X86CPU twice

2013-01-31 Thread Andreas Färber
Am 31.01.2013 21:40, schrieb Andreas Färber: > Since commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386: > move cpu_reset and reset callback to cpu.c) the x86 CPU is reset through > cpu_init() but was still reset immediately after in linux-user and > bsd-user. Clean this up. > > Similarl

[Qemu-devel] [PATCH for-1.4] Revert "e1000: no need auto-negotiation if link was down"

2013-01-31 Thread Michael Roth
This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. I'm not sure what issue the original commit was meant to fix, or if the logic is actually wrong, but it causes e1000 to stop working after a guest issues a reset. >From what I can tell a guest with an e1000 nic has no way of changing t

Re: [Qemu-devel] [PATCH for-1.4?] target-i386: Pass X86CPU to cpu_x86_set_a20()

2013-01-31 Thread Andreas Färber
Am 31.01.2013 16:49, schrieb Eduardo Habkost: > On Thu, Jan 31, 2013 at 04:08:44PM +0100, Andreas Färber wrote: >> Prepares for cpu_interrupt() changing argument to CPUState. >> >> While touching it, rename to x86_cpu_...() now that it takes an X86CPU. >> >> Signed-off-by: Andreas Färber > > Revi

Re: [Qemu-devel] [PATCH for-1.4 v2] target-unicore32: Rename CPU subtypes

2013-01-31 Thread Andreas Färber
Am 31.01.2013 19:09, schrieb Andreas Färber: > Am 29.01.2013 23:27, schrieb Andreas Färber: >> In the initial conversion of CPU models to QOM types, model names were >> mapped 1:1 to type names. As a side effect this gained us a type "any", >> which is now a device. >> >> To avoid "-device any" sil

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-openrisc: Rename CPU subtypes

2013-01-31 Thread Andreas Färber
Am 27.01.2013 22:55, schrieb Andreas Färber: > Model names were mapped 1:1 to type names. As a side effect this > registered a type "any", which is now a device. > > To avoid "-device any" silliness and to pave the way for compiling > multiple targets into one executable, adopt a --cpu scheme. >

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-openrisc: TYPE_OPENRISC_CPU should be abstract

2013-01-31 Thread Andreas Färber
Am 30.01.2013 00:15, schrieb Andreas Färber: > Am 27.01.2013 22:47, schrieb Andreas Färber: >> A basic assumption of CPU subtypes is that only specific models get >> instantiated. A user is not supposed to instantiate an -cpu. >> Suppress it via abstract = true, which also drops or32-cpu from >> -c

Re: [Qemu-devel] [PATCH for-1.4?] ide/mmio: QOM'ify MMIO IDE for R2D

2013-01-31 Thread Aurelien Jarno
On Thu, Jan 24, 2013 at 08:33:56PM +0100, Andreas Färber wrote: > It was not qdev'ified before, so turn it into a SysBusDevice. > Keep mmio_ide_init_drives() around to attach the hard drive. > > Signed-off-by: Andreas Färber > Cc: Markus Armbruster > --- > hw/ide.h |5 +--- > hw/ide/mm

Re: [Qemu-devel] [PATCH] target-mips: Sign-extend the result of LWR

2013-01-31 Thread Aurelien Jarno
On Sun, Jan 20, 2013 at 07:30:54PM +, Richard Sandiford wrote: > Sign-extend the result of LWR, as is already done for LWL. This is necessary > in the case where LWR loads the full word (i.e. the address is actually > aligned). In the other cases, it is implementation defined whether the > up

Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O

2013-01-31 Thread Alex Williamson
On Fri, 2013-02-01 at 08:44 +1100, Benjamin Herrenschmidt wrote: > On Thu, 2013-01-31 at 09:34 -0700, Alex Williamson wrote: > > > Luckily guests do not seem to be worried as long as we use ACPI. > > > > Yes, in fact I just figured out last night that Windows is unhappy with > > assigned PCI devic

Re: [Qemu-devel] [PATCH] target-mips: fix incorrect test for MTHLIP

2013-01-31 Thread Aurelien Jarno
On Wed, Jan 23, 2013 at 04:17:41AM +0100, Petar Jovanovic wrote: > The pos field in the DSPControl register is not correctly initialized. > Per documentation, the result of MTHLIP is unpredictable if the value of the > pos field before the execution is greater than 32. > > Signed-off-by: Petar Jov

Re: [Qemu-devel] [PATCH] target-mips: enable access to DSP ASE if implemented

2013-01-31 Thread Aurelien Jarno
On Wed, Jan 23, 2013 at 03:57:02AM +0100, Petar Jovanovic wrote: > From: Petar Jovanovic > > compute_hflags() will reset DSP h-flags, so MX bit should be initially set > for usermode in cpu_state_reset() if DSP ASE is implemented. > This change will bring back user-mode support for DSP ASE, since

Re: [Qemu-devel] [PATCH] target-mips: Fix signedness of loads in MIPS16 RESTOREs

2013-01-31 Thread Aurelien Jarno
On Sun, Jan 20, 2013 at 07:28:48PM +, Richard Sandiford wrote: > Make RESTORE use sign-extending rather than zero-extending loads. > > Signed-off-by: Richard Sandiford > --- > target-mips/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-mips/transl

Re: [Qemu-devel] [PULL 0/2] target-arm queue

2013-01-31 Thread Aurelien Jarno
On Wed, Jan 30, 2013 at 04:13:53PM +, Peter Maydell wrote: > Last few target-arm patches to go in before hardfreeze. Please > pull. > > -- PMM > > The following changes since commit 0893d46014b0300fb8aec92df94effea34d04b61: > > Merge remote-tracking branch 'qemu-kvm/uq/master' into staging

Re: [Qemu-devel] [PATCH] target-mips: Unfuse {,N}M{ADD,SUB}.fmt

2013-01-31 Thread Aurelien Jarno
On Tue, Jan 22, 2013 at 05:16:00PM +, Richard Sandiford wrote: > Turn MADD.fmt, MSUB.fmt, NMADD.fmt and NMSUB.fmt from fused to unfused > operations, so that they behave in the same way as a separate multiplication > and addition. The instructions were only fused in early MIPS IV processors. >

Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O

2013-01-31 Thread Michael S. Tsirkin
> > Here's a more interesting example: > > > > -+-[:01]-+-00.0 NVIDIA Corporation GT218 [GeForce G210M] > > | \-00.1 NVIDIA Corporation High Definition Audio Controller > > \-[:00]-+-00.0 Intel Corporation Mobile 4 Series Chipset Memory > > Controller Hub > > +

Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O

2013-01-31 Thread Michael S. Tsirkin
On Fri, Feb 01, 2013 at 08:22:33AM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2013-01-31 at 12:49 +0200, Michael S. Tsirkin wrote: > > > OK but this appears behind a bridge. So the bridge configuration tells > > the root complex where to send accesses to the VGA. > > Sort-of, again the root

Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O

2013-01-31 Thread Michael S. Tsirkin
On Thu, Jan 31, 2013 at 02:21:50PM -0700, Alex Williamson wrote: > On Thu, 2013-01-31 at 23:11 +0200, Michael S. Tsirkin wrote: > > On Thu, Jan 31, 2013 at 09:34:03AM -0700, Alex Williamson wrote: > > > > > > On Thu, 2013-01-31 at 12:49 +0200, Michael S. Tsirkin wrote: > > > > On Wed, Jan 30, 2013

[Qemu-devel] [PATCH 1/2] TCG: Final globals clean-up

2013-01-31 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- tcg/tcg.c |2 +- tcg/tcg.h | 14 ++-- translate-all.c | 97 --- 3 files changed, 61 insertions(+), 52 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 9275e37..c8a843e 100644 --- a

[Qemu-devel] [PATCH 2/2] cocoa: Replace non-portable asprintf() by g_strdup_printf()

2013-01-31 Thread Andreas Färber
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Andreas Färber --- ui/cocoa.m |6 +++--- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index fbd7386..ca42413 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -828,9 +828,9 @@ Qem

[Qemu-devel] [PATCH 1/2] cocoa: Fix VBE function Set Display Start

2013-01-31 Thread Andreas Färber
From: Henry Harrington Register a dpy_gfx_setdata callback so that the Cocoa code is notified whenever the screen start address changes. Commit 1d3323d has a similar fix for the VNC UI. Signed-off-by: Henry Harrington Cc: qemu-sta...@nongnu.org (1.3.x) Signed-off-by: Andreas Färber --- ui/co

[Qemu-devel] [PULL 0/2] Cocoa patch queue 2013-01-31

2013-01-31 Thread Andreas Färber
Hello, This is the Cocoa queue for v1.4. Please pull. The following changes since commit 321f211707822b4c87f0bb89e4f46586fff43163: Merge remote-tracking branch 'pmaydell/arm-devs.next' into staging (2013-01-30 10:51:47 -0600) are available in the git repository at: git://repo.or.cz/qemu/

[Qemu-devel] [PATCH 2/2] TCG: Move translation block variables to new context inside tcg_ctx: tb_ctx

2013-01-31 Thread Evgeny Voevodin
It's worth to clean-up translation blocks variables and move them into one context as was suggested by Swirl. Also if we use this context directly inside tcg_ctx, then it speeds up code generation a bit. Signed-off-by: Evgeny Voevodin --- cpu-exec.c | 18 - include/exec/ex

[Qemu-devel] [PATCH 0/2] Fainal TCG clean-up patches

2013-01-31 Thread Evgeny Voevodin
This set of patches moves rest global variables to tcg_ctx. Also second patch introduces new TBContext for translation blocks ans moves translation block globals there. We place tb_ctx inside tcg_ctx and get noticable speed-up. After this patchset was aplied, I noticed ~4-5% speed-up of code gen

Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O

2013-01-31 Thread Benjamin Herrenschmidt
On Thu, 2013-01-31 at 09:34 -0700, Alex Williamson wrote: > > Luckily guests do not seem to be worried as long as we use ACPI. > > Yes, in fact I just figured out last night that Windows is unhappy with > assigned PCI devices on bus 0 that claim to be an endpoint in their PCIe > capability rather

Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O

2013-01-31 Thread Benjamin Herrenschmidt
On Thu, 2013-01-31 at 12:49 +0200, Michael S. Tsirkin wrote: > OK but this appears behind a bridge. So the bridge configuration tells > the root complex where to send accesses to the VGA. Sort-of, again the root complex isn't "sending" anything targeted here. PCIe is point to point and any devic

Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O

2013-01-31 Thread Alex Williamson
On Thu, 2013-01-31 at 23:11 +0200, Michael S. Tsirkin wrote: > On Thu, Jan 31, 2013 at 09:34:03AM -0700, Alex Williamson wrote: > > > > On Thu, 2013-01-31 at 12:49 +0200, Michael S. Tsirkin wrote: > > > On Wed, Jan 30, 2013 at 04:28:30PM -0700, Alex Williamson wrote: > > > > On Thu, 2013-01-31 at

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Michael S. Tsirkin
On Thu, Jan 31, 2013 at 05:20:02PM +0200, Avi Kivity wrote: > On Thu, Jan 31, 2013 at 4:42 PM, Gleb Natapov wrote: > > On Thu, Jan 31, 2013 at 04:36:25PM +0200, Avi Kivity wrote: > >> On Thu, Jan 31, 2013 at 4:30 PM, Gleb Natapov wrote: > >> >> > > >> >> > Avi/Michael do you remember why mincore

Re: [Qemu-devel] [PATCH WIP 0/4] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-01-31 Thread Nicholas A. Bellinger
On Thu, 2013-01-31 at 13:12 +0200, Michael S. Tsirkin wrote: > On Wed, Jan 30, 2013 at 05:41:22PM +0100, Paolo Bonzini wrote: > > Another small bug I found is an ordering problem between > > VHOST_SET_VRING_KICK and VHOST_SCSI_SET_ENDPOINT. Starting the vq > > causes a "vhost_scsi_handle_vq end

Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O

2013-01-31 Thread Michael S. Tsirkin
On Thu, Jan 31, 2013 at 09:34:03AM -0700, Alex Williamson wrote: > > On Thu, 2013-01-31 at 12:49 +0200, Michael S. Tsirkin wrote: > > On Wed, Jan 30, 2013 at 04:28:30PM -0700, Alex Williamson wrote: > > > On Thu, 2013-01-31 at 10:02 +1100, Benjamin Herrenschmidt wrote: > > > > On Thu, 2013-01-31 a

[Qemu-devel] [PATCH for-1.4 v3] linux-user: bsd-user: Don't reset X86CPU twice

2013-01-31 Thread Andreas Färber
Since commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386: move cpu_reset and reset callback to cpu.c) the x86 CPU is reset through cpu_init() but was still reset immediately after in linux-user and bsd-user. Clean this up. Similarly it is also reset after cpu_copy(), but that's a bug of

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-01-31 Thread Michael R. hines
Sorry, I didn't go into enough detail about the problem I'm having in the loop: The loop that's not breaking is inside qemu_loadvm_state(), not ram_save_block(). This do-while loop is not exiting... is it necessary for me to maintain this loop for RDMA purposes? Since there is explicit

[Qemu-devel] [PATCH][v5] linux-user: correct semctl() and shmctl()

2013-01-31 Thread Laurent Vivier
The parameter "union semun" of semctl() is not a value but a pointer to the value. Moreover, all fields of target_su must be swapped (if needed). The third argument of shmctl is a pointer. WITHOUT this patch: $ ipcs kernel not configured for shared memory qemu: uncaught target signal 11 (Segm

Re: [Qemu-devel] [PATCH][v4] linux-user: correct semctl() and shmctl()

2013-01-31 Thread Laurent Vivier
Sorry, this one is wrong, I missed some returns... Regards, LAurent Le jeudi 31 janvier 2013 à 20:36 +0100, Laurent Vivier a écrit : > The parameter "union semun" of semctl() is not a value > but a pointer to the value. > > Moreover, all fields of target_su must be swapped (if needed). > > The

[Qemu-devel] [PATCH][v4] linux-user: correct semctl() and shmctl()

2013-01-31 Thread Laurent Vivier
The parameter "union semun" of semctl() is not a value but a pointer to the value. Moreover, all fields of target_su must be swapped (if needed). The third argument of shmctl is a pointer. WITHOUT this patch: $ ipcs kernel not configured for shared memory qemu: uncaught target signal 11 (Segm

Re: [Qemu-devel] [PATCH v2 01/20] arm: add Faraday a36x SoC platform support

2013-01-31 Thread Igor Mitsyanko
Hi, Kuo-Jung, please see several comments bellow. On 01/25/2013 12:19 PM, Kuo-Jung Su wrote: From: Kuo-Jung Su The Faraday A360/A369 EVB is a Faraday platform main board used for the Faraday IP functional verification based on the well-known ARM AMBA 2.0 architecture. This main board provides

Re: [Qemu-devel] [PATCH 02/11] poller: add Poller for growable GPollFD arrays

2013-01-31 Thread Anthony Liguori
Stefan Hajnoczi writes: > On Thu, Jan 31, 2013 at 06:56:56AM -0600, Anthony Liguori wrote: >> Stefan Hajnoczi writes: >> >> > QEMU currently uses select(2)-style rfds/wfds/xfds for file descriptor >> > event polling. Unfortunately the underlying fd_set type and its macros >> > (FD_SET()) have

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-01-31 Thread Orit Wasserman
On 01/31/2013 05:08 PM, Michael R. hines wrote: > Yes, I was hoping for a comment about this in particular (before I send out > another patchest with the proper coverletter and so forth). > > So here's the problem I was experiencing inside savevm.c, qemu_loadvm_state(): > > I was having a little

Re: [Qemu-devel] What to do about non-qdevified devices?

2013-01-31 Thread Markus Armbruster
Andreas Färber writes: > Am 30.01.2013 13:35, schrieb Markus Armbruster: >> Peter Maydell writes: >> >>> On 30 January 2013 07:02, Markus Armbruster wrote: Anthony Liguori writes: [...] > The problems I ran into were (1) this is a lot of work (2) it basically > requires

Re: [Qemu-devel] [PATCH qom-cpu for-1.4 0/6] Unmigratable CPUs for 1.4

2013-01-31 Thread Andreas Färber
Am 29.01.2013 15:04, schrieb Juan Quintela: > Andreas Färber wrote: >> Hello, >> >> Prompted by earlier patches from Juan, this series cleans up some targets >> that don't implement migration - be it by no-op implementations, by erroring >> out in the implementation or by lack of implementation. >

[Qemu-devel] [PATCH qom-cpu for-next 3/4] mcf_intc: Pass M68kCPU to mcf_intc_init()

2013-01-31 Thread Andreas Färber
Store it in mcf_intc_state. Prepares for passing it to m68k_set_irq_level(). Signed-off-by: Andreas Färber --- hw/mcf.h |2 +- hw/mcf5208.c | 11 +++ hw/mcf_intc.c |8 3 Dateien geändert, 12 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff --git a/hw/mcf.h b/hw/

[Qemu-devel] [PATCH qom-cpu for-next 1/4] target-m68k: Return M68kCPU from cpu_m68k_init()

2013-01-31 Thread Andreas Färber
Turn cpu_init() into a static inline function for backwards compatibility. Signed-off-by: Andreas Färber --- target-m68k/cpu.h| 12 ++-- target-m68k/helper.c |4 ++-- 2 Dateien geändert, 12 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/target-m68k/cpu.h b/target-m68

Re: [Qemu-devel] [RFC 2/2] qbus_find_recursive(): the "free slots" constraint needs a dedicated error

2013-01-31 Thread Peter Maydell
On 31 January 2013 18:19, Laszlo Ersek wrote: > On 01/31/13 17:55, Peter Maydell wrote: > >> You probably need to pass in an Error** then, so the leaf can >> provide useful information at the point of error and then the >> top level code can deal with it appropriately whether hmp or qmp. > > That'

[Qemu-devel] [PATCH qom-cpu for-next 0/4] target-m68k: CPU cleanups preparing for 1.5

2013-01-31 Thread Andreas Färber
Hello, This series propagates M68kCPU arguments along the call chain in preparation for CPU_COMMON -> CPUState interrupt field movements and function changes. It is based on my current qom-cpu-next queue: https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next If there are no objections, I'll

Re: [Qemu-devel] [RFC 2/2] qbus_find_recursive(): the "free slots" constraint needs a dedicated error

2013-01-31 Thread Laszlo Ersek
On 01/31/13 17:55, Peter Maydell wrote: > You probably need to pass in an Error** then, so the leaf can > provide useful information at the point of error and then the > top level code can deal with it appropriately whether hmp or qmp. That's what I'm doing, yes. > For Error** error_setg() is th

[Qemu-devel] [PATCH qom-cpu for-next 2/4] mcf5206: Pass M68kCPU to mcf5206_init()

2013-01-31 Thread Andreas Färber
Store it in m5206_mbar_state. Prepares for passing M68kCPU to m68k_set_irq_level(). Signed-off-by: Andreas Färber --- hw/an5206.c | 11 +++ hw/mcf.h |2 +- hw/mcf5206.c |8 3 Dateien geändert, 12 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff --git a/hw/an5206.

Re: [Qemu-devel] [PATCH for-1.4 v2] target-unicore32: Rename CPU subtypes

2013-01-31 Thread Andreas Färber
Am 29.01.2013 23:27, schrieb Andreas Färber: > In the initial conversion of CPU models to QOM types, model names were > mapped 1:1 to type names. As a side effect this gained us a type "any", > which is now a device. > > To avoid "-device any" silliness and to pave the way for compiling > multiple

[Qemu-devel] [PATCH qom-cpu for-next 4/4] target-m68k: Pass M68kCPU to m68k_set_irq_level()

2013-01-31 Thread Andreas Färber
Simplifies use of cpu_reset_interrupt() et al. Signed-off-by: Andreas Färber --- hw/mcf5206.c |2 +- hw/mcf_intc.c|2 +- target-m68k/cpu.h|2 +- target-m68k/helper.c |4 +++- 4 Dateien geändert, 6 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/hw/mc

Re: [Qemu-devel] [PATCH V17 07/10] libqblock: libqblock API design and type defines

2013-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2013 at 04:53:47PM +0800, Wenchao Xia wrote: > Public API design header files: libqblock.h, libqblock-error.h. > Public type define header files: libqblock-types.h. Private internal used > header files: libqblock-internal. For ABI some reserved bytes are used in > structure define

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Avi Kivity
On Jan 31, 2013 12:29 PM, "Orit Wasserman" wrote: > > On 01/31/2013 11:48 AM, Gleb Natapov wrote: > > On Thu, Jan 31, 2013 at 09:47:24AM +0200, Orit Wasserman wrote: > >> On 01/31/2013 08:57 AM, Peter Lieven wrote: > >>> Hi, > >>> > >>> I just came across an idea and would like to have feedback if

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Erlon Cruz
On Thu, Jan 31, 2013 at 1:12 PM, Luiz Capitulino wrote: > On Thu, 31 Jan 2013 05:12:25 -0800 > "Erlon Cruz" wrote: > > > Legal Disclaimer: > > The information contained in this message may be privileged and > confidential. It is intended to be read only by the individual or entity to > whom it is

Re: [Qemu-devel] [RFC 2/2] qbus_find_recursive(): the "free slots" constraint needs a dedicated error

2013-01-31 Thread Peter Maydell
On 31 January 2013 16:36, Laszlo Ersek wrote: > On 01/31/13 17:13, Peter Maydell wrote: >> On 31 January 2013 16:05, Laszlo Ersek wrote: >>> On 01/31/13 16:54, Peter Maydell wrote: I thought we weren't adding any new QERR errors any more? >>> >>> How do you intend to inform the user about ne

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Avi Kivity
On Thu, Jan 31, 2013 at 4:42 PM, Gleb Natapov wrote: > On Thu, Jan 31, 2013 at 04:36:25PM +0200, Avi Kivity wrote: >> On Thu, Jan 31, 2013 at 4:30 PM, Gleb Natapov wrote: >> >> > >> >> > Avi/Michael do you remember why mincore can't be used to check if a >> >> > guest >> >> page is unmapped? >>

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Avi Kivity
On Jan 31, 2013 4:03 PM, "Peter Lieven" wrote: > > > Am 31.01.2013 um 14:59 schrieb Avi Kivity : > >> >> On Jan 31, 2013 12:29 PM, "Orit Wasserman" wrote: >> > >> > On 01/31/2013 11:48 AM, Gleb Natapov wrote: >> > > On Thu, Jan 31, 2013 at 09:47:24AM +0200, Orit Wasserman wrote: >> > >> On 01/31/

Re: [Qemu-devel] RFC migration of zero pages

2013-01-31 Thread Avi Kivity
On Thu, Jan 31, 2013 at 4:30 PM, Gleb Natapov wrote: >> > >> > Avi/Michael do you remember why mincore can't be used to check if a guest >> page is unmapped? >> >> A page may be not in core, but also nonzero (for example swap). > Yes, mincore() should not be used as zero page check, but it can be

[Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-01-31 Thread Gal Hammer
Hi, How many msi-x vectors should be allocated for the virtio-serial device? I'm asking this as it seems that a proposed patch (http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg02094.html) was not accepted and I re-encountered this issue while trying to upgrade the virtio-serial's Wind

  1   2   3   >