Re: [Qemu-devel] [PATCH] vmdk: Allow space in file name

2013-01-29 Thread Andreas Färber
Am 29.01.2013 22:50, schrieb Philipp Hahn: > The previous scanf() format string stopped parsing the file name on the > first white white space, which seems to be allowed at least by VMware > Wokrstation. "Workstation" - hopefully can be fixed when applied. > > Change the format string to collect

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-01-29 Thread Lei Li
On 01/29/2013 04:45 AM, Eric Blake wrote: On 01/27/2013 11:14 AM, Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 76 ++ qga/qapi-schema.json | 42 +++ 2 files changed, 118 insertions(+), 0 deletions(

Re: [Qemu-devel] [PATCH for-1.4 1/2] linux-user: Fix cpu_copy() usage

2013-01-29 Thread Andreas Färber
Am 30.01.2013 08:18, schrieb Igor Mammedov: > On Wed, 30 Jan 2013 01:34:18 +0100 > Andreas Färber wrote: > >> Commit b4558d7481aefc865b0b52bf9b285ebcf2e8b59f ((x86/Sparc/PPC)-user: >> fix cpu_copy) added a CPU reset after cpu_copy() inside linux-user code. >> This reverses the register copying th

Re: [Qemu-devel] [PATCH] vmdk: Allow space in file name

2013-01-29 Thread Philipp Hahn
Hello, On Tuesday 29 January 2013 22:50:31 Philipp Hahn wrote: > The previous scanf() format string stopped parsing the file name on the > first white white space, which seems to be allowed at least by VMware > Wokrstation. > > Change the format string to collect everything between the first and >

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-29 Thread Lei Li
On 01/29/2013 04:24 AM, Anthony Liguori wrote: Eric Blake writes: On 01/27/2013 11:14 AM, Lei Li wrote: Signed-off-by: Lei Li --- include/qapi/qmp/qerror.h |3 +++ qga/commands-posix.c | 30 ++ qga/qapi-schema.json | 38 ++

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-29 Thread Lei Li
On 01/29/2013 02:29 AM, Eric Blake wrote: On 01/27/2013 11:14 AM, Lei Li wrote: Signed-off-by: Lei Li --- include/qapi/qmp/qerror.h |3 +++ qga/commands-posix.c | 30 ++ qga/qapi-schema.json | 38 ++ 3 files

Re: [Qemu-devel] [PATCH for-1.4 1/2] linux-user: Fix cpu_copy() usage

2013-01-29 Thread Igor Mammedov
On Wed, 30 Jan 2013 01:34:18 +0100 Andreas Färber wrote: > Commit b4558d7481aefc865b0b52bf9b285ebcf2e8b59f ((x86/Sparc/PPC)-user: > fix cpu_copy) added a CPU reset after cpu_copy() inside linux-user code. > This reverses the register copying that cpu_copy() does. > > Clean this up by moving the

Re: [Qemu-devel] [BUG, RFC] block/vmdk.c: File name with space fails to open

2013-01-29 Thread Philipp Hahn
Hello, On Friday 25 January 2013 09:37:39 Markus Armbruster wrote: > Suggest to include '\n' in the stop set, like \"%511[^\"\n]\", to better > detect malformed input. Will do, also \r. > > I don't know how portable %[ together with a maximum width is, because > > the manual page for sscanf() do

[Qemu-devel] [PATCH] vmdk: Allow space in file name

2013-01-29 Thread Philipp Hahn
The previous scanf() format string stopped parsing the file name on the first white white space, which seems to be allowed at least by VMware Wokrstation. Change the format string to collect everything between the first and second quote as the file name, disallowing line breaks. Signed-off-by: Ph

Re: [Qemu-devel] [PATCH for-1.4] *-user: Don't reset X86CPU again

2013-01-29 Thread Igor Mammedov
On Wed, 30 Jan 2013 01:38:47 +0100 Andreas Färber wrote: > Am 21.01.2013 16:54, schrieb Igor Mammedov: > > On Sun, 20 Jan 2013 08:39:35 +0100 > > Andreas Färber wrote: > > Subj could be more specific, something along the lines: > > Fix broken breakpoints duplication for i386-{bds,linux}-user >

[Qemu-devel] What to do about non-qdevified devices? (was: KVM call minutes 2013-01-29)

2013-01-29 Thread Markus Armbruster
Anthony Liguori writes: [...] > The problems I ran into were (1) this is a lot of work (2) it basically > requires that all bus children have been qdev/QOM-ified. Even with > something like the ISA bus which is where I started, quite a few devices > were not qdevified still. So what's the plan

Re: [Qemu-devel] [PATCH V11 3/4] Use QemuOpts support in block layer

2013-01-29 Thread Dong Xu Wang
于 2013-1-29 17:45, Markus Armbruster 写道: > Dong Xu Wang writes: > >> Markus Armbruster writes: >>> Dong Xu Wang writes: >>> Markus Armbruster writes: > Dong Xu Wang writes: > [...] >> @@ -264,17 +264,13 @@ static int cow_create(const char *filename, >> QEMUOptionParameter *o

Re: [Qemu-devel] [PATCH v4 4/5] sheepdog: use inet_connect to simplify connect code

2013-01-29 Thread MORITA Kazutaka
At Tue, 29 Jan 2013 10:11:44 -0700, Eric Blake wrote: > > On 01/29/2013 01:56 AM, MORITA Kazutaka wrote: > > This uses the form ":" for the representation of the > > sheepdog server to use inet_connect. > > > > Signed-off-by: MORITA Kazutaka > > --- > > block/sheepdog.c | 111 > >

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2013-01-29 Thread Serge Hallyn
** Description changed: + + SRU Justification: + 1. Impact: usb devices which worked with qemu previously stop working + 2. Development fix: a patch upstream entitled uhci: Don't queue up packets after one with the SPD flag set fixes the problem + 3. Stable fi

Re: [Qemu-devel] [qemu-devel]The problem of QMP command getfd.

2013-01-29 Thread Li Zhang
On 2013年01月29日 00:30, Eric Blake wrote: On 01/28/2013 07:16 AM, Li Zhang wrote: The QMP client must send '{ "execute": "getfd", "arguments": { "fdname": "fd1" } }' together with SCM_RIGHTS CMSG. You are getting the error because you sent the "getfd" command but forgot to include a file descript

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 1/5] add openfabrics RDMA libraries and base RDMA code to build

2013-01-29 Thread Anthony Liguori
Andreas Färber writes: > Hello, > > Am 28.01.2013 23:01, schrieb mrhi...@linux.vnet.ibm.com: >> From: "Michael R. Hines" >> >> >> Signed-off-by: Michael R. Hines >> --- >> Makefile.target |5 +- >> include/qemu/rdma.h | 249 ++ >> qemu-rdma.c | 1357 >> +

Re: [Qemu-devel] [PATCH for-1.4] libqtest: Wait for the right child PID after killing QEMU

2013-01-29 Thread Anthony Liguori
Andreas Färber writes: > Am 28.01.2013 19:15, schrieb Eduardo Habkost: >> When running "make check" with gcov enabled, we get the following >> message: >> >>hw/tmp105.gcda:cannot open data file, assuming not executed >> >> The problem happens because: >> >> * tmp105-test exits before QEMU

Re: [Qemu-devel] a probem about qemu doesn't support for setting ma

2013-01-29 Thread liequan . che
 Hi  Paolo:  I recompile the qemu-kvm-0.12.1.2-2.295.el6.10.src.rpm with --enable-mixemu. It makes no effect yet. Did the new version 1.3.1 slove this problem? Best Regards! - Original Message - From: Paolo Bonzini To: liequan@i-soft.com.cn Cc: qemu-devel Subject: Re: [Qemu-deve

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 1/5] add openfabrics RDMA libraries and base RDMA code to build

2013-01-29 Thread Andreas Färber
Hello, Am 28.01.2013 23:01, schrieb mrhi...@linux.vnet.ibm.com: > From: "Michael R. Hines" > > > Signed-off-by: Michael R. Hines > --- > Makefile.target |5 +- > include/qemu/rdma.h | 249 ++ > qemu-rdma.c | 1357 > +++

Re: [Qemu-devel] [PATCH v2] target-arm: add Faraday ARMv5TE processors support

2013-01-29 Thread Kuo-Jung Su
Hi Peter: Thanks for the comments. I'll double if the ARM_FEATURE_TCM is indetical to Faraday's I/D-scrtachpad, , add the missing MPU functions for FT606TE, and avoid using CP_ANY in next patch. Best Wishes Dante 2013/1/28 Peter Maydell > On 25 January 2013 07:18, Kuo-Jung Su wrote: > > +stat

Re: [Qemu-devel] [PATCH 2/2] usb-ehci: add Faraday FUSBH200 support

2013-01-29 Thread Kuo-Jung Su
2013/1/29 Andreas Färber > Am 29.01.2013 06:43, schrieb Kuo-Jung Su: > > From: Kuo-Jung Su > > > > Add Faraday FUSBH200 support, which is slightly different from EHCI spec. > > (Or maybe simply a bad/wrong implementation...) > > > > Signed-off-by: Kuo-Jung Su > > Cc: Gerd Hoffmann > > Cc: Andr

Re: [Qemu-devel] [PATCH for-1.4] libqtest: Wait for the right child PID after killing QEMU

2013-01-29 Thread Andreas Färber
Am 28.01.2013 19:15, schrieb Eduardo Habkost: > When running "make check" with gcov enabled, we get the following > message: > >hw/tmp105.gcda:cannot open data file, assuming not executed > > The problem happens because: > > * tmp105-test exits before QEMU exits, because waitpid() at >q

Re: [Qemu-devel] [PATCH for-1.4] *-user: Don't reset X86CPU again

2013-01-29 Thread Andreas Färber
Am 21.01.2013 16:54, schrieb Igor Mammedov: > On Sun, 20 Jan 2013 08:39:35 +0100 > Andreas Färber wrote: > Subj could be more specific, something along the lines: > Fix broken breakpoints duplication for i386-{bds,linux}-user > >> Since commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i3

[Qemu-devel] [PATCH for-1.4 2/2] linux-user: bsd-user: Don't reset X86CPU twice

2013-01-29 Thread Andreas Färber
Since commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386: move cpu_reset and reset callback to cpu.c) the x86 CPU is reset through cpu_init() but was still reset immediately after in linux-user and bsd-user. Similarly it was reset as part of cpu_copy(). Clean this up. Cc: Igor Mammedov

[Qemu-devel] [PATCH for-1.4 1/2] linux-user: Fix cpu_copy() usage

2013-01-29 Thread Andreas Färber
Commit b4558d7481aefc865b0b52bf9b285ebcf2e8b59f ((x86/Sparc/PPC)-user: fix cpu_copy) added a CPU reset after cpu_copy() inside linux-user code. This reverses the register copying that cpu_copy() does. Clean this up by moving the cpu_reset() call to after cpu_init() but before memcpy(). This matche

[Qemu-devel] [PATCH for-1.4 0/2] linux-user/bsd-user cpu_reset() cleanups

2013-01-29 Thread Andreas Färber
Hello, Here's an extended version of my cpu_reset() cleanup for x86, prompted by a discussion about the commit message: v2 first generally cleans up cpu_copy() by moving cpu_reset() into cpu_copy() before dropping x86 cpu_reset(). Rebased onto master. Beyond the scope of this 1.4 series is replac

Re: [Qemu-devel] [PULL] virtio,make,pci,e1000

2013-01-29 Thread Anthony Liguori
Andreas Färber writes: > Am 30.01.2013 00:28, schrieb Michael S. Tsirkin: >> On Tue, Jan 29, 2013 at 04:54:35PM -0600, Anthony Liguori wrote: >>> ERROR:/home/aliguori/git/qemu/tests/fdc-test.c:84:floppy_send: assertion >>> failed ((msr) & (RQM) == (RQM)): (0x == 0x0080) >>> GTester:

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2013-01-29 Thread Serge Hallyn
** No longer affects: qemu-kvm (Ubuntu Raring) ** Changed in: qemu-kvm (Ubuntu Quantal) Assignee: (unassigned) => Serge Hallyn (serge-hallyn) ** No longer affects: qemu (Ubuntu Quantal) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PULL] virtio,make,pci,e1000

2013-01-29 Thread Andreas Färber
Am 30.01.2013 00:28, schrieb Michael S. Tsirkin: > On Tue, Jan 29, 2013 at 04:54:35PM -0600, Anthony Liguori wrote: >> ERROR:/home/aliguori/git/qemu/tests/fdc-test.c:84:floppy_send: assertion >> failed ((msr) & (RQM) == (RQM)): (0x == 0x0080) >> GTester: last random seed: R02S4b841f715

Re: [Qemu-devel] [PATCH 4/7 v2] KVM regsync: Add register bitmap parameter to do_kvm_cpu_synchronize_state

2013-01-29 Thread Marcelo Tosatti
On Mon, Jan 28, 2013 at 12:49:26PM -0500, Jason J. Herne wrote: > On 01/24/2013 07:01 PM, Marcelo Tosatti wrote: > >On Thu, Jan 24, 2013 at 06:44:50PM -0200, Marcelo Tosatti wrote: > > > >What 'subtle errors' are you thinking of? > > > >It should be easy to convert as its greppable. > > > >>S/390 n

[Qemu-devel] [PATCH v2] vmdk: Allow selecting SCSI adapter in image creation

2013-01-29 Thread Othmar Pasteka
Introduce a new option "adapter_type" when converting to vmdk images. It can be one of the following: ide (default), buslogic, lsilogic or legacyESX (according to the vmdk spec from vmware). In case of a non-ide adapter, heads is set to 255 instead of the 16. The latter is used for "ide". Also se

Re: [Qemu-devel] [PULL] virtio,make,pci,e1000

2013-01-29 Thread Michael S. Tsirkin
On Tue, Jan 29, 2013 at 04:54:35PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > The following changes since commit 1356b98d3e95a85071e6bf9a99e8799e1ae1bbee: > > > > sysbus: Drop sysbus_from_qdev() cast macro (2013-01-21 13:52:24 -0600) > > > > are available in the git repo

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-openrisc: TYPE_OPENRISC_CPU should be abstract

2013-01-29 Thread Andreas Färber
Am 27.01.2013 22:47, schrieb Andreas Färber: > A basic assumption of CPU subtypes is that only specific models get > instantiated. A user is not supposed to instantiate an -cpu. > Suppress it via abstract = true, which also drops or32-cpu from > -cpu ? output. > > Cc: qemu-sta...@nongnu.org > Cc:

Re: [Qemu-devel] [PATCH V2 11/20] tap: support enabling or disabling a queue

2013-01-29 Thread Michael S. Tsirkin
On Tue, Jan 29, 2013 at 04:55:25PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Tue, Jan 29, 2013 at 08:10:26PM +, Blue Swirl wrote: > >> On Tue, Jan 29, 2013 at 1:50 PM, Jason Wang wrote: > >> > On 01/26/2013 03:13 AM, Blue Swirl wrote: > >> >> On Fri, Jan 25, 2013

Re: [Qemu-devel] [PATCH V2 11/20] tap: support enabling or disabling a queue

2013-01-29 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Tue, Jan 29, 2013 at 08:10:26PM +, Blue Swirl wrote: >> On Tue, Jan 29, 2013 at 1:50 PM, Jason Wang wrote: >> > On 01/26/2013 03:13 AM, Blue Swirl wrote: >> >> On Fri, Jan 25, 2013 at 10:35 AM, Jason Wang wrote: >> >>> This patch introduce a new bit - enabl

[Qemu-devel] [PATCH 03/19] s390: Add mapping helper functions.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck Add s390_cpu_physical_memory_{map,unmap} with special handling for the lowcore. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- target-s390x/cpu.h|4 target-s390x/helper.c | 25 + 2 files changed, 29 insertions(+), 0 de

Re: [Qemu-devel] [PULL] virtio,make,pci,e1000

2013-01-29 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > The following changes since commit 1356b98d3e95a85071e6bf9a99e8799e1ae1bbee: > > sysbus: Drop sysbus_from_qdev() cast macro (2013-01-21 13:52:24 -0600) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_an

[Qemu-devel] [PATCH 14/19] s390-virtio: Check for NULL device in reset hypercall

2013-01-29 Thread Alexander Graf
From: Andreas Färber s390_virtio_bus_find_mem() may return a NULL VirtIOS390Device. If called with, e.g., args[0] == 0, this leads to a segfault. Fix this by adding error handling as done for other hypercalls. Present since baf0b55a9e57b909b1f8b0f732c0b10242867418 (Implement virtio reset). Sign

[Qemu-devel] [PATCH 11/19] s390: Make typeinfo const

2013-01-29 Thread Alexander Graf
All TypeInfo definitions should be const. Signed-off-by: Alexander Graf --- hw/s390x/ipl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 7cbbf99..86e8415 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -159,7 +159,7 @@ static

[Qemu-devel] [PATCH 08/19] s390: Wire up channel I/O in kvm.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck Trigger the code for our virtual css in case of instruction intercepts for I/O instructions. Handle the tsch exit for the subchannel-related part of tsch. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- target-s390x/cpu.h | 11 +++ target-s390x/kvm.c | 2

[Qemu-devel] buildbot failure in qemu on default_x86_64_debian_6_0

2013-01-29 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_debian_6_0/builds/526 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

[Qemu-devel] [PATCH 09/19] s390-virtio: Factor out some initialization code.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck Some of the machine initialization for s390-virtio will be reused by virtio-ccw. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- hw/s390-virtio.c | 118 ++--- hw/s390-virtio.h |5 ++ 2 files changed, 72 in

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-m68k: Rename CPU types

2013-01-29 Thread Andreas Färber
Am 27.01.2013 20:18, schrieb Andreas Färber: > In the initial conversion of CPU models to QOM types, model names were > mapped 1:1 to type names. As a side effect this gained us a type "any", > which is now a device. > > To avoid "-device any" silliness and to pave the way for compiling > multiple

[Qemu-devel] [PATCH 19/19] s390: Drop set_bit usage in virtio_ccw.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck set_bit on indicators doesn't go well on 32 bit targets: note: expected 'long unsigned int *' but argument is of type 'uint64_t *' Switch to bit shifts instead. Signed-off-by: Cornelia Huck [agraf: use 1ULL instead] Signed-off-by: Alexander Graf --- hw/s390x/virtio-ccw.c

Re: [Qemu-devel] [PATCH 3/3] tests: Add unit tests for mulu64 and muls64

2013-01-29 Thread Richard Henderson
On 01/29/2013 12:06 PM, Blue Swirl wrote: +static const Test test_u_data[] = { +{ 1, 1, 0, 1 }, +{ 1, 1, 0, 1 }, +{ -1ull, 2, 1, -2ull }, Shouldn't '1' be '-1'? How can this test pass? This is 0x___ * 2 = 0x1____fffe with the knowledge

[Qemu-devel] [PATCH 15/19] s390: Add s390-ccw-virtio machine.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck Add a new machine type, s390-ccw-virtio, making use of the virtio-ccw transport to present virtio devices as channel devices. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- hw/s390x/Makefile.objs |1 + hw/s390x/s390-virtio-ccw.c | 134 +

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-29 Thread Nicholas A. Bellinger
On Tue, 2013-01-29 at 16:03 -0500, Paolo Bonzini wrote: > > Also, I'm not exactly sure what's involved with a vhost=on/off > > frontend > > option discussed above, so if you or Paolo could handle this bit it > > would be very helpful. > > I can do the forward port, if you take care of testing we h

[Qemu-devel] [PATCH 01/19] s390: Add default support for SCLP console

2013-01-29 Thread Alexander Graf
The current s390 machine uses the virtio console as default console, but this doesn't mean that we always want to keep it that way for new machines. This patch introduces a way for a machine type to specify that it wants the default console to be an SCLP console, which is a lot closer to what real

Re: [Qemu-devel] KVM call minutes 2013-01-29

2013-01-29 Thread Anthony Liguori
Alexander Graf writes: > On 01/29/2013 04:41 PM, Juan Quintela wrote: >>Alex will fill this > > When using -device, we can not specify an IRQ line to attach to the > device. This works for some special buses like PCI, but not in the > generic case. We need it generically for virtio-mmio and

[Qemu-devel] [PATCH 13/19] s390: Move hw files to hw/s390x

2013-01-29 Thread Alexander Graf
This moves all files only used by s390 system emulation to hw/s390x. Signed-off-by: Alexander Graf Acked-by: Christian Borntraeger --- hw/s390x/Makefile.objs |2 -- hw/{ => s390x}/s390-virtio-bus.c |8 hw/{ => s390x}/s390-virtio-bus.h | 12 ++-- hw/s390x/s39

[Qemu-devel] [PATCH for-1.4 v2] target-unicore32: Rename CPU subtypes

2013-01-29 Thread Andreas Färber
In the initial conversion of CPU models to QOM types, model names were mapped 1:1 to type names. As a side effect this gained us a type "any", which is now a device. To avoid "-device any" silliness and to pave the way for compiling multiple targets into one executable, adopt a --cpu scheme. No f

[Qemu-devel] [PATCH 05/19] s390: I/O interrupt and machine check injection.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck I/O interrupts are queued per isc. Only crw pending machine checks are supported. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- target-s390x/cpu.h| 69 +++- target-s390x/helper.c | 141

[Qemu-devel] [PATCH 12/19] virtio-s390: add a reset function to virtio-s390 devices

2013-01-29 Thread Alexander Graf
From: Paolo Bonzini virtio-s390 devices are not being reset when their bus is. To fix this, add a reset method that forwards to virtio_reset. This is only needed because of the "strange" modeling of virtio devices; the ->vdev link is being handled manually rather than through qdev. Signed-off-

[Qemu-devel] [PULL 00/19] s390 patch queue 2013-01-29

2013-01-29 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for s390. This time without build breakage hopefully :). Please pull. Alex The following changes since commit ec9466ff2e50213c8318ffdd7003f345278ab795: Anthony Liguori (1): Merge remote-tracking branch 'afaerber/qom-cpu' into staging

[Qemu-devel] [PATCH 02/19] s390: Lowcore mapping helper.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck Create a lowcore mapping helper that includes a check for sufficient length. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- target-s390x/helper.c | 34 +- 1 files changed, 25 insertions(+), 9 deletions(-) diff --git a/targ

[Qemu-devel] [PATCH] sparc: disable qtest in make check

2013-01-29 Thread Anthony Liguori
We've seen this repeatedly in buildbot but I can now reliably reproduce it myself too. With a few hundred runs of 'make check', qemu-system-sparc will hang consuming 100% CPU. I've attached GDB to the hung process and unfortunately, I can't get anything useful out of GDB (RIP is not a valid simpl

[Qemu-devel] [PATCH 16/19] sclpconsole: Don't instantiate sclpconsole with -nodefaults

2013-01-29 Thread Alexander Graf
From: Christian Borntraeger libvirt specifies nodefaults and creates an sclp console with special parameters. Let qemu follow nodefaults and don't create an sclp console if nodefaults is specified. Signed-off-by: Christian Borntraeger Signed-off-by: Alexander Graf --- vl.c |1 + 1 files c

[Qemu-devel] [PATCH 04/19] s390: Channel I/O basic definitions.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck Basic channel I/O structures and helper function. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- target-s390x/Makefile.objs |2 +- target-s390x/cpu.h |1 + target-s390x/ioinst.c | 36 target-s390x/ioinst.h | 207 +++

Re: [Qemu-devel] [PATCH V2 11/20] tap: support enabling or disabling a queue

2013-01-29 Thread Michael S. Tsirkin
On Tue, Jan 29, 2013 at 08:10:26PM +, Blue Swirl wrote: > On Tue, Jan 29, 2013 at 1:50 PM, Jason Wang wrote: > > On 01/26/2013 03:13 AM, Blue Swirl wrote: > >> On Fri, Jan 25, 2013 at 10:35 AM, Jason Wang wrote: > >>> This patch introduce a new bit - enabled in TAPState which tracks whether

[Qemu-devel] [Bug 659351] Re: QEMU uses obsolete gethostbyname and inet_aton rather than getaddrinfo

2013-01-29 Thread Jesse Larrew
** Changed in: qemu Assignee: (unassigned) => Jesse Larrew (jlarrew) ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/659351 Title: QEMU use

[Qemu-devel] [PATCH 06/19] s390: Add channel I/O instructions.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck Provide handlers for (most) channel I/O instructions. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- target-s390x/cpu.h| 100 +++ target-s390x/ioinst.c | 716 + target-s390x/ioinst.h | 16 ++ trace

[Qemu-devel] [PATCH 18/19] s390: css error codes.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck Changed error codes in the channel subsystem / virtio-ccw code (-EOPNOTSUPP -> -ENOSYS, -ERESTART -> -EINPROGRESS). This should hopefully fix building on mingw32. Signed-off-by: Cornelia Huck Reviewed-by: Stefan Weil Signed-off-by: Alexander Graf --- hw/s390x/css.c

[Qemu-devel] [PATCH 17/19] s390: Use s390_cpu_physical_memory_map for tpi.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck Map the I/O interruption code before calling into css. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- hw/s390x/css.c|2 +- target-s390x/cpu.h|4 ++-- target-s390x/ioinst.c | 19 ++- target-s390x/ioinst.h |7 +++

[Qemu-devel] [PATCH v3] PPC: Unify dcbzl code path

2013-01-29 Thread Alexander Graf
The bit that makes a dcbz instruction a dcbzl instruction was declared as reserved in ppc32 ISAs. However, hardware simply ignores the bit, making code valid if it simply invokes dcbzl instead of dcbz even on 750 and G4. Thus, mark the bit as unreserved so that we properly emulate a simple dcbz in

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-29 Thread Paolo Bonzini
> Also, I'm not exactly sure what's involved with a vhost=on/off > frontend > option discussed above, so if you or Paolo could handle this bit it > would be very helpful. I can do the forward port, if you take care of testing we have enough time to make it into 1.4. Paolo

Re: [Qemu-devel] KVM call minutes 2013-01-29

2013-01-29 Thread Alexander Graf
On 01/29/2013 04:41 PM, Juan Quintela wrote: * Buildbot: discussed on the list (Andreas retired it) * Replacing select(2) so that we will not hit the 1024 fd_set limit in the future. (stefan) Add checks for fd's bigger than 1024? multifunction devices uses lot of fd's for device. P

[Qemu-devel] [PATCH 07/19] s390: Virtual channel subsystem support.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck Provide a mechanism for qemu to provide fully virtual subchannels to the guest. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- hw/s390x/Makefile.objs |1 + hw/s390x/css.c | 1277 hw/s390x/css.h

[Qemu-devel] [PATCH 10/19] s390: Add new channel I/O based virtio transport.

2013-01-29 Thread Alexander Graf
From: Cornelia Huck Add a new virtio transport that uses channel commands to perform virtio operations. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- hw/s390x/Makefile.objs |1 + hw/s390x/virtio-ccw.c | 960 hw/s390x/virt

Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions.

2013-01-29 Thread Alexander Graf
On 01/29/2013 09:12 PM, Blue Swirl wrote: On Tue, Jan 29, 2013 at 3:45 PM, Cornelia Huck wrote: On Tue, 29 Jan 2013 16:09:38 +0100 Alexander Graf wrote: On 01/28/2013 10:59 AM, Cornelia Huck wrote: On Fri, 25 Jan 2013 20:28:31 +0100 Alexander Graf wrote: However, I do agree that this du

[Qemu-devel] [PATCH v2] PPC: Unify dcbzl code path

2013-01-29 Thread Alexander Graf
The bit that makes a dcbz instruction a dcbzl instruction was declared as reserved in ppc32 ISAs. However, hardware simply ignores the bit, making code valid if it simply invokes dcbzl instead of dcbz even on 750 and G4. Thus, mark the bit as unreserved so that we properly emulate a simple dcbz in

Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions.

2013-01-29 Thread Blue Swirl
On Tue, Jan 29, 2013 at 3:45 PM, Cornelia Huck wrote: > On Tue, 29 Jan 2013 16:09:38 +0100 > Alexander Graf wrote: > >> On 01/28/2013 10:59 AM, Cornelia Huck wrote: >> > On Fri, 25 Jan 2013 20:28:31 +0100 >> > Alexander Graf wrote: >> > >> >> However, I do agree that this duplicates logic. Corne

Re: [Qemu-devel] [PATCH V2 11/20] tap: support enabling or disabling a queue

2013-01-29 Thread Blue Swirl
On Tue, Jan 29, 2013 at 1:50 PM, Jason Wang wrote: > On 01/26/2013 03:13 AM, Blue Swirl wrote: >> On Fri, Jan 25, 2013 at 10:35 AM, Jason Wang wrote: >>> This patch introduce a new bit - enabled in TAPState which tracks whether a >>> specific queue/fd is enabled. The tap/fd is enabled during init

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-29 Thread Blue Swirl
On Tue, Jan 29, 2013 at 9:56 AM, Peter Maydell wrote: > On 29 January 2013 08:42, Andreas Färber wrote: >> Am 28.01.2013 22:10, schrieb Peter Maydell: >> Where we disagree is that you suggest that do { ... while (0) is any >> better than G_STMT_START ... G_STMT_END. I disagree and find *both* >>

Re: [Qemu-devel] [PATCH v2] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-29 Thread Eric Blake
On 01/29/2013 09:58 AM, Michal Privoznik wrote: > Currently, we are using 'tray_open' in QMP and 'tray-open' in > HMP. However, the QMP documentation was mistakenly using the > HMP version. > > Signed-off-by: Michal Privoznik > --- > > diff to v1: > -add S-o-b line > > qmp-commands.hx | 2 +- >

Re: [Qemu-devel] [PATCH 3/3] tests: Add unit tests for mulu64 and muls64

2013-01-29 Thread Blue Swirl
On Mon, Jan 28, 2013 at 10:09 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tests/Makefile | 7 +- > tests/test-mul64.c | 69 > ++ > 2 files changed, 75 insertions(+), 1 deletion(-) > create mode 100644 test

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-29 Thread Nicholas A. Bellinger
Hi MST, Paolo & Co, On Mon, 2013-01-28 at 15:39 +0200, Michael S. Tsirkin wrote: > On Mon, Jan 28, 2013 at 02:33:44PM +0100, Paolo Bonzini wrote: > > Il 28/01/2013 14:36, Michael S. Tsirkin ha scritto: > > > On Mon, Jan 28, 2013 at 02:29:23PM +0100, Paolo Bonzini wrote: > > >> Il 28/01/2013 14:11,

Re: [Qemu-devel] [PATCH] PPC: Allow book3s ppc32 to run dcbzl

2013-01-29 Thread Andreas Färber
Am 29.01.2013 19:29, schrieb Alexander Graf: > On 01/29/2013 07:02 PM, Scott Wood wrote: >> On 01/29/2013 07:52:58 AM, Alexander Graf wrote: >>> The bit that makes a dcbz instruction a dcbzl instruction was >>> declared as >>> reserved in ppc32 ISAs. However, hardware simply ignores the bit, making

Re: [Qemu-devel] [PATCH] PPC: Allow book3s ppc32 to run dcbzl

2013-01-29 Thread Alexander Graf
On 01/29/2013 07:02 PM, Scott Wood wrote: On 01/29/2013 07:52:58 AM, Alexander Graf wrote: The bit that makes a dcbz instruction a dcbzl instruction was declared as reserved in ppc32 ISAs. However, hardware simply ignores the bit, making code valid if it simply invokes dcbzl instead of dcbz eve

Re: [Qemu-devel] [PATCH] PPC: Allow book3s ppc32 to run dcbzl

2013-01-29 Thread Scott Wood
On 01/29/2013 07:52:58 AM, Alexander Graf wrote: The bit that makes a dcbz instruction a dcbzl instruction was declared as reserved in ppc32 ISAs. However, hardware simply ignores the bit, making code valid if it simply invokes dcbzl instead of dcbz even on 750 and G4. Thus, mark the bit a

Re: [Qemu-devel] a probem about qemu doesn't support for setting master volume/mute when guest is winxp

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 08:35, liequan@i-soft.com.cn ha scritto: > Hi all: > I found a bug that qemu doesn't support for setting master volume/mute > when guest is winxp. but the wave volume in the volume control works > fine.I don't know why it does. > Any help is welcome. > Best Regards! You pro

[Qemu-devel] [PATCH v2] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-29 Thread Michal Privoznik
Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly using the HMP version. Signed-off-by: Michal Privoznik --- diff to v1: -add S-o-b line qmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qmp-comman

[Qemu-devel] [Bug 1062220] Re: qemu-system-arm crashed with SIGABRT in cpu_abort()

2013-01-29 Thread Peter Maydell
qemu-system-arm -M versatilepb -kernel u-boot.bin [...] Trying to execute code outside RAM or ROM This almost always means that you tried to execute a guest binary which wasn't for the VersatilePB. Without more info about exactly what this u-boot.bin file was this bug report can't progress any fur

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-29 Thread Stefan Hajnoczi
On Tue, Jan 29, 2013 at 2:32 PM, Paolo Bonzini wrote: > Il 29/01/2013 14:27, Stefan Hajnoczi ha scritto: >>> > and in step 5, may need export the delta data, not the whole disk >>> > data. >> NBD doesn't have a way to perform bdrv_is_allocated(). Either we need >> to enhance the protocol or we ne

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 17:44, Stefan Hajnoczi ha scritto: >> > >> > I'm planning to add offline mirroring to qemu-img. If you use an NBD >> > server as the destination, it can be used to send only the delta between >> > two snapshots via NBD. >> > >> > I think this is the opposite of what you suggested, wh

Re: [Qemu-devel] KVM call minutes 2013-01-29

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 17:47, Anthony Liguori ha scritto: > Paolo Bonzini writes: > >> Il 29/01/2013 16:41, Juan Quintela ha scritto: >>> * Replacing select(2) so that we will not hit the 1024 fd_set limit in the >>> future. (stefan) >>> >>> Add checks for fd's bigger than 1024? multifunction devices

Re: [Qemu-devel] [PATCH v4 4/5] sheepdog: use inet_connect to simplify connect code

2013-01-29 Thread Eric Blake
On 01/29/2013 01:56 AM, MORITA Kazutaka wrote: > This uses the form ":" for the representation of the > sheepdog server to use inet_connect. > > Signed-off-by: MORITA Kazutaka > --- > block/sheepdog.c | 111 ++--- > 1 files changed, 30 insertions(

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Benoît Canet
Le Tuesday 29 Jan 2013 à 16:21:43 (+0100), Kevin Wolf a écrit : > Am 29.01.2013 16:03, schrieb Benoît Canet: > >> base1 [file] --- base1 [qcow2] --- snap1.qcow2 --\ > >> base2 [file] --- base2 [qcow2] --- snap2.qcow2 --->-- quorum > >> base3 [file] --- base3 [qcow2] --- snap3.qcow2 --/ > > > > I t

Re: [Qemu-devel] KVM call minutes 2013-01-29

2013-01-29 Thread Anthony Liguori
Paolo Bonzini writes: > Il 29/01/2013 16:41, Juan Quintela ha scritto: >> * Replacing select(2) so that we will not hit the 1024 fd_set limit in the >> future. (stefan) >> >> Add checks for fd's bigger than 1024? multifunction devices uses lot >> of fd's for device. >> >> Portability? >

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] vnc: Clean up vncws_send_handshake_response()

2013-01-29 Thread Stefan Hajnoczi
On Fri, Jan 25, 2013 at 10:31:16AM +0100, Markus Armbruster wrote: > Use appropriate types, drop superfluous casts, use sizeof, don't > exploit that this particular call of gnutls_fingerprint() doesn't > change its last argument. > > Signed-off-by: Markus Armbruster > --- > ui/vnc-ws.c | 11

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Eric Blake
On 01/29/2013 07:27 AM, Benoît Canet wrote: >> base1 [file] --- base1 [qcow2] --- snap1.qcow2 --\ >> base2 [file] --- base2 [qcow2] --- snap2.qcow2 --->-- quorum >> base3 [file] --- base3 [qcow2] --- snap3.qcow2 --/ For that matter, I think it would be useful to have a quorum where the data is dup

Re: [Qemu-devel] [RFC V8 11/13] quorum: Add quorum_snapshot_img_create.

2013-01-29 Thread Eric Blake
On 01/28/2013 10:07 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet Now that you delayed open() to later in the series, it would be useful to have this commit document the format of what a valid input string will be (that is, some of your commit comments on 13/13 are more useful here, where

Re: [Qemu-devel] [PATCH] qemu-iotests: Test qcow2 image creation options

2013-01-29 Thread Kevin Wolf
Am 29.01.2013 17:12, schrieb Eric Blake: > On 01/29/2013 03:01 AM, Kevin Wolf wrote: >> Just create lots of images and try out each of the creation options that >> qcow2 provides (except backing_file/fmt for now) >> >> I'm not totally happy with the behaviour of qemu-img in each of the >> cases, bu

Re: [Qemu-devel] [PATCH] qemu-iotests: Test qcow2 image creation options

2013-01-29 Thread Eric Blake
On 01/29/2013 03:01 AM, Kevin Wolf wrote: > Just create lots of images and try out each of the creation options that > qcow2 provides (except backing_file/fmt for now) > > I'm not totally happy with the behaviour of qemu-img in each of the > cases, but let's be explicit and update the test when we

[Qemu-devel] [Bug 1062220] Re: qemu-system-arm crashed with SIGABRT in cpu_abort()

2013-01-29 Thread Serge Hallyn
Marked as affecting Ubuntu's qemu package, as bug 1103405 (a dup of this one) happened with the new qemu, not qemu-linaro, package. ** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: New => Confirmed ** Changed in: qemu (Ubuntu)

Re: [Qemu-devel] QEMU buildbot maintenance state

2013-01-29 Thread Christian Berendt
On 01/28/2013 03:29 PM, Daniel Gollub wrote: JFYI, the main buildbot configuration which controls everything (beside buildslave credentials) is accessible to everyone: http://people.b1-systems.de/~gollub/buildbot/ If you are familiar with buildbot feel free to incorporate your suggested changes

Re: [Qemu-devel] KVM call minutes 2013-01-29

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 16:41, Juan Quintela ha scritto: > * Replacing select(2) so that we will not hit the 1024 fd_set limit in the > future. (stefan) > > Add checks for fd's bigger than 1024? multifunction devices uses lot > of fd's for device. > > Portability? > Use glib? and let it use poll

Re: [Qemu-devel] [PATCH] Add a disk format named iROW, supporting high-efficiency VM snapshot

2013-01-29 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding styl

Re: [Qemu-devel] [PATCH v2 0/6] bdrv_open() error return fixes

2013-01-29 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding styl

Re: [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-29 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding styl

Re: [Qemu-devel] [PATCH V16 0/9] libqblock qemu block layer library

2013-01-29 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. This patch breaks the build by causing make to fail. Here's the output: GEN i386-softmmu/config-devices.mak GEN x86_64-softmmu/config-devices.mak GEN alpha-softmmu/config-devices.mak GEN arm-softmmu/config-devices.mak GEN cris-

  1   2   3   >