[Qemu-devel] a probem about qemu doesn't support for setting master volume/mute when guest is winxp

2013-01-28 Thread liequan . che
 Hi all:  I found a bug that qemu doesn't support for setting master volume/mute when guest is winxp. but the wave volume in the volume control works fine.I don't know why it does.   Any help is welcome.   Best Regards!  

[Qemu-devel] the patch about win7 guest unable to disable the sound completely

2013-01-28 Thread liequan . che
Hi all: I slove the problem that qemu doesn't support to disable the sound completely when someone choose ich6 sound card. I test it in centos 6.3,guest win7,ich6 sound card.it works fine. my patch: --- qemu-kvm-0.12.1.2/hw/hda-audio.c    2013-01-29 10:07:34.750968170 +0800 +++ qemu-kvm-0.12.1.

Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

2013-01-28 Thread Gerd Hoffmann
Hi, > hw/usb/hcd-ehci-sysbus.c |6 ++ > hw/usb/hcd-ehci.c| 21 + > hw/usb/hcd-ehci.h| 12 ++-- > +s->portscbase = sec->portscbase; > +s->portnr = sec->portnr; These two must be initialized in usb_ehci_pci_initfn too. Otherwise th

Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

2013-01-28 Thread Kuo-Jung Su
Hi Gerd: Thanks for reminding me of the usb_ehci_pci_initfn. But I have a stupid question... Which one do the upcoming path v2 looks like ? 1. It contains only the diff to usb_ehci_pci_initfn, for example: [Qemu-devel][PATCH v2 0/1] usb-ehci: add Faraday FUSBH200 support [Qemu-deve

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-28 Thread Dietmar Maurer
>The solution seems OK in improving the performance, I just wondering if it > is possible to put it in lower level component, not qemu? It will make qemu > block layer more complicate, Not that I am aware off - it just add a few lines to block.c, and only uses existing functionality already

[Qemu-devel] [PATCH V16 1/9] build: add command check-clean

2013-01-28 Thread Wenchao Xia
This command will package the clean operations in tests, to make it easy to be extended. Now root Makefile simply calls the command and do not care the details of it any more. Signed-off-by: Wenchao Xia --- Makefile |1 - tests/Makefile | 12 +++- 2 files changed, 11 insert

[Qemu-devel] [PATCH V16 2/9] libqblock: build: add configure support

2013-01-28 Thread Wenchao Xia
Rule for libqblock.la will be included if it is enabled, and will be added to 'all' to be automatically built. Signed-off-by: Wenchao Xia --- Makefile |3 +++ configure | 26 ++ libqblock/Makefile |4 3 files changed, 33 insertions(+),

[Qemu-devel] [PATCH V16 5/9] block: export function path_has_protocol()

2013-01-28 Thread Wenchao Xia
libqblock need to use it. Signed-off-by: Wenchao Xia --- block.c |2 +- include/block/block.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index ba67c0d..44db62f 100644 --- a/block.c +++ b/block.c @@ -195,7 +195,7 @@ static void

[Qemu-devel] [PATCH V16 4/9] libqblock: build: add packaging support

2013-01-28 Thread Wenchao Xia
Now libqblock can be packaged and installed by "sudo make install-libqblock'. Signed-off-by: Wenchao Xia --- libqblock/Makefile | 35 ++- libqblock/libqblock.pc.in | 13 + 2 files changed, 43 insertions(+), 5 deletions(-) create mode

[Qemu-devel] [PATCH V16 8/9] libqblock: build: add rules for test case

2013-01-28 Thread Wenchao Xia
Libtool will be used for final link, the rules do nothing if libqblock was disabled. Temp directory was used to store image created in test, which will be deleted in clean. Signed-off-by: Wenchao Xia --- tests/Makefile | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) di

Re: [Qemu-devel] [PATCH V2 00/20] Multiqueue virtio-net

2013-01-28 Thread Jason Wang
On 01/29/2013 01:36 PM, Wanlong Gao wrote: > On 01/28/2013 12:24 PM, Jason Wang wrote: >> On 01/28/2013 11:27 AM, Wanlong Gao wrote: >>> On 01/25/2013 06:35 PM, Jason Wang wrote: Hello all: This seires is an update of last version of multiqueue virtio-net support. This seri

[Qemu-devel] [PATCH 2/2] usb-ehci: add Faraday FUSBH200 support

2013-01-28 Thread Kuo-Jung Su
From: Kuo-Jung Su Add Faraday FUSBH200 support, which is slightly different from EHCI spec. (Or maybe simply a bad/wrong implementation...) Signed-off-by: Kuo-Jung Su Cc: Gerd Hoffmann Cc: Andreas Cc: Peter Crosthwaite --- hw/usb/hcd-ehci-sysbus.c | 66

[Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

2013-01-28 Thread Kuo-Jung Su
From: Kuo-Jung Su Replace PORTSC macros with variables which could then be configured in ehci__class_init(...) Signed-off-by: Kuo-Jung Su Cc: Gerd Hoffmann Cc: Andreas Cc: Peter Crosthwaite --- hw/usb/hcd-ehci-sysbus.c |6 ++ hw/usb/hcd-ehci.c| 21 +

[Qemu-devel] [PATCH 0/2] usb-ehci: add Faraday FUSBH200 support

2013-01-28 Thread Kuo-Jung Su
From: Kuo-Jung Su First of all, Andreas's QOM realizefn patch for hcd-ehci-sysbus must be applied prior to this patch set. Here is the link to Andreas's QOM realizefn patch: http://patchwork.ozlabs.org/patch/215919/ Now return to the topic, this patch set has 2 parts: 1. Replace PORTSC macro

Re: [Qemu-devel] [PATCH V2 00/20] Multiqueue virtio-net

2013-01-28 Thread Wanlong Gao
On 01/28/2013 12:24 PM, Jason Wang wrote: > On 01/28/2013 11:27 AM, Wanlong Gao wrote: >> On 01/25/2013 06:35 PM, Jason Wang wrote: >>> Hello all: >>> >>> This seires is an update of last version of multiqueue virtio-net support. >>> >>> This series tries to brings multiqueue support to virtio-net

[Qemu-devel] [PATCH V16 7/9] libqblock: libqblock API implement

2013-01-28 Thread Wenchao Xia
This patch contains implemention for APIs. Basically it is a layer above qemu block general layer now. Signed-off-by: Wenchao Xia --- libqblock/libqblock-error.c | 57 +++ libqblock/libqblock.c | 1069 +++ 2 files changed, 1126 insertions(+), 0 d

[Qemu-devel] [PATCH V16 9/9] libqblock: test: libqblock test example

2013-01-28 Thread Wenchao Xia
In this example, first it will create some qcow2 images, then try get information including backing file relationship, then it will do sync IO on the image. Signed-off-by: Wenchao Xia --- tests/check-libqblock-qcow2.c | 392 + 1 files changed, 392 inser

[Qemu-devel] [PATCH V16 3/9] libqblock: build: add rule for libqblock.la

2013-01-28 Thread Wenchao Xia
Now libqblock.la can be built with neccessary object files, and can be automatically cleaned by make clean in root directory. make libqblock-clean also clean it. -fvisibility=hidden was used to hide symbols, and a special macro was introduced to export symbols that marked as public. Signed-off-b

[Qemu-devel] [PATCH V16 6/9] libqblock: libqblock API design and type defines

2013-01-28 Thread Wenchao Xia
Public API design header files: libqblock.h, libqblock-error.h. Public type define header files: libqblock-types.h. Private internal used header files: libqblock-internal. For ABI some reserved bytes are used in structure defines. Macro LIBQB_DLL_PUBLIC was used to export symbols. Important APIs

[Qemu-devel] [PATCH V16 0/9] libqblock qemu block layer library

2013-01-28 Thread Wenchao Xia
These patches introduce libqblock API, make subdir-libqblock and make check-libqblock could build this library. Functionalities: 1 create a new image. 2 sync access of an image. 3 basic image information retrieving such as backing file. 4 detect if a sector is allocated in an image. Supported

[Qemu-devel] [PATCH 34/37] target-unicore32: Use type_register() instead of type_register_static()

2013-01-28 Thread Andreas Färber
According to its documentation, type_register_static()'s TypeInfo argument should exist for the life type of the type. Therefore use type_register() when registering the list of CPU subtypes. No functional change with the current implementation. Cf. 918fd0839eeafc83bd4984364321a947d29041fe for ar

[Qemu-devel] [PATCH 37/37] kvm: Pass CPUState to kvm_on_sigbus_vcpu()

2013-01-28 Thread Andreas Färber
Since commit 20d695a9254c1b086a456d3b79a3c311236643ba (kvm: Pass CPUState to kvm_arch_*) CPUArchState is no longer needed. Allows to change qemu_kvm_eat_signals() argument as well. Signed-off-by: Andreas Färber Reviewed-by: Gleb Natapov --- cpus.c |8 include/sysemu/

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-28 Thread Wenchao Xia
于 2013-1-28 21:00, Stefan Hajnoczi 写道: On Fri, Jan 25, 2013 at 05:16:46PM +0800, Wenchao Xia wrote: 于 2013-1-24 17:47, Stefan Hajnoczi 写道: Case 3: * What does "blank data" mean? Besides that the use case makes sense. Will remove the words. * When discussing this use case in t

[Qemu-devel] [PATCH 31/37] target-openrisc: Catch attempt to instantiate abstract type in cpu_init()

2013-01-28 Thread Andreas Färber
There is no abstract OpenRISCCPU yet, but that seems a bug of its own. Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- target-openrisc/cpu.c |3 ++- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index e

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-28 Thread Wenchao Xia
于 2013-1-28 21:38, Dietmar Maurer 写道: If you've been using it for 4 years then it was without dm-thin, which is a new snapshot mechanism that solves limitations of classic LVM snapshot volumes. So if you're referring to inefficient LVM snapshots then that should be solvable now. Are you sure t

[Qemu-devel] [PATCH 36/37] cpu: Unconditionalize CPUState fields

2013-01-28 Thread Andreas Färber
Commits fc8c5b8c41ee5ba69d7a2be63b02a08c7b0b155b (Makefile.user: Define CONFIG_USER_ONLY for libuser/) and dd83b06ae61cfa2dc4381ab49f365bd0995fc930 (qom: Introduce CPU class) specifically prepared the qom/cpu.c file to be compiled differently for softmmu and *-user. This broke as part of build syst

Re: [Qemu-devel] [PATCH V11 3/4] Use QemuOpts support in block layer

2013-01-28 Thread Dong Xu Wang
于 2013-1-29 1:41, Markus Armbruster 写道: > Dong Xu Wang writes: > >> Markus Armbruster writes: >>> Dong Xu Wang writes: >>> This patch will use QemuOpts related functions in block layer, add a member bdrv_create_options to BlockDriver struct, it will return a QemuOptsList pointer,

[Qemu-devel] qemu-1.2.2 black screen when the winxp guest change the resolution

2013-01-28 Thread zhou link
hello, i reproduce the problem: when i use qemu-1.2.2 on centos6.3 with spice-0.12.2, run winxp guest like that: qemu-system-x86_64 -localtime --enable-kvm -spice port=,disable-ticketing -m 2048 -smp 2 -vga qxl -drive file=.xp32_full_stable.qcow2 the win32 xp has install the spice-gue

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/6] target-ppc: Synchronize more SPRs to KVM using ONE_REG interface

2013-01-28 Thread David Gibson
On Fri, Jan 25, 2013 at 12:24:06PM +0100, Alexander Graf wrote: > On 25.01.2013, at 03:39, David Gibson wrote: > > On Thu, Jan 24, 2013 at 05:32:42PM +0100, Alexander Graf wrote: [snip] > >>> +static void kvm_get_one_spr(CPUState *cs, uint64_t id, int spr) > >>> +{ > >>> +PowerPCCPU *cpu = POWE

[Qemu-devel] [PATCH v3 4/5] sheepdog: use inet_connect to simplify connect code

2013-01-28 Thread MORITA Kazutaka
This uses the form ":" for the representation of the sheepdog server to use inet_connect. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 111 ++--- 1 files changed, 30 insertions(+), 81 deletions(-) diff --git a/block/sheepdog.c b/block/sh

[Qemu-devel] [PATCH v3 0/5] sheepdog: unix domain socket support

2013-01-28 Thread MORITA Kazutaka
This series makes sheepdog accept URI syntax, and adds a unix domain socket support for a connection between qemu and local sheepdog server based on the syntax. Changes from v2: - fix coding style in tcp_connect - accept URI syntax Changes from v1: - split patch for easy review - move set_nod

Re: [Qemu-devel] [PATCH 0/3] accel:some cleanup work for vm accelerator

2013-01-28 Thread li guang
ping ... 在 2013-01-24四的 13:03 +0800,liguang写道: > do some cleanup work fo vm accelerator > > patch 1/3: skip init accelerator if it's not available > patch 2/3: correct error message when fail to init kvm > patch 3/3: change {xen,kvm,tcg,qtest}_allowed from int to bool > > hw/xen.h

[Qemu-devel] [PATCH v3 5/5] sheepdog: add support for connecting to unix domain socket

2013-01-28 Thread MORITA Kazutaka
This patch adds support for a unix domain socket for a connection between qemu and local sheepdog server. You can use the unix domain socket with the following syntax: $ qemu sheepdog+unix:///?[#snapid] Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 82 +++

[Qemu-devel] [PATCH v3 3/5] sheepdog: accept URIs

2013-01-28 Thread MORITA Kazutaka
The URI syntax is consistent with the NBD and Gluster syntax. The syntax is sheepdog[+tcp]://[host:port]/vdiname[#snapid|#tag] Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 139 - qemu-doc.texi| 16 +++--- qemu-options.hx |

[Qemu-devel] [PATCH v3 1/5] slirp/tcp_subr.c: fix coding style in tcp_connect

2013-01-28 Thread MORITA Kazutaka
Fix coding style in tcp_connect before the next patch. Signed-off-by: MORITA Kazutaka --- slirp/tcp_subr.c | 140 -- 1 files changed, 72 insertions(+), 68 deletions(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index 1542e43..317dc07 10

[Qemu-devel] [PATCH v3 2/5] move socket_set_nodelay to osdep.c

2013-01-28 Thread MORITA Kazutaka
Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 11 +-- gdbstub.c |5 ++--- include/qemu/sockets.h |1 + qemu-char.c|6 -- slirp/tcp_subr.c |3 +-- util/osdep.c |6 ++ 6 files changed, 11 insertions(+), 21

Re: [Qemu-devel] [PATCH] vmdk: Allow selecting SCSI adapter in image creation

2013-01-28 Thread Othmar Pasteka
Hello, On Mon, Jan 28, 2013 at 11:56:47PM +0100, Othmar Pasteka wrote: > @@ -1453,6 +1454,7 @@ static int vmdk_create(const char *filename, > QEMUOptionParameter *options) > const char *desc_extent_line; > char parent_desc_line[BUF_SIZE] = ""; > uint32_t parent_cid = 0x; >

[Qemu-devel] [PATCH] vmdk: Allow selecting SCSI adapter in image creation

2013-01-28 Thread Othmar Pasteka
Introduce a new option "adapter_type" when converting to vmdk images. It can be one of the following: ide (default), buslogic, lsilogic or legacyESX (according to the vmdk spec from vmware). In case of a non-ide adapter, heads is set to 255 instead of the 16. The latter is used for "ide". Also se

[Qemu-devel] qemu-system-i386 -machine pc-0.15 -usb -usbdevice host:xxxx:yyyy usb_handle_packet: Assertion

2013-01-28 Thread Peter Stuge
Hi list! I have an XP guest originally from qemu-kvm-0.15 which I use for a smart card application by passing a full-speed USB CCID card reader from the host per subject, on an x86_64 host with kvm. Avi's qemu-kvm.git at old tag v0.15.1 with -machine pc works fine. qemu.git master commit 6034fe7

[Qemu-devel] [PATCH 1/2] qemu-ga: Plug memory leak in guest_fsfreeze_cleanup()

2013-01-28 Thread Michael Roth
From: Markus Armbruster Neglects to free errors allocated by qmp_guest_fsfreeze_thaw(). Spotted by Coverity. While there, drop the test whether return value is negative (it's never true), and improve logging. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulin

[Qemu-devel] [PATCH 3/3] tests: Add unit tests for mulu64 and muls64

2013-01-28 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/Makefile | 7 +- tests/test-mul64.c | 69 ++ 2 files changed, 75 insertions(+), 1 deletion(-) create mode 100644 tests/test-mul64.c diff --git a/tests/Makefile b/tests/Makefile index 442b286.

[Qemu-devel] [PATCH 2/3] host-utils: Improve mulu64 and muls64

2013-01-28 Thread Richard Henderson
The new formulation makes better use of add-with-carry type insns that the host may have. Use gcc's sign adjustment trick to avoid having to perform a 128-bit negation. Signed-off-by: Richard Henderson --- util/host-utils.c | 92 +++ 1 file ch

[Qemu-devel] [PATCH 1/3] host-utils: Use __int128_t for mul[us]64

2013-01-28 Thread Richard Henderson
Replace some x86_64 specific inline assembly with something that all 64-bit hosts ought to optimize well. At worst this becomes a call to the gcc __multi3 routine, which is no worse than our implementation in util/host-utils.c. With gcc 4.7, we get identical code generation for x86_64. We now ge

[Qemu-devel] [PATCH v2 0/3] Improve 128-bit multiply primitives

2013-01-28 Thread Richard Henderson
Changes v1->v2: * Use __[u]int128_t as per Blue's comment. I'd actually forgotten that gcc automatically addeds those typedefs. * Keep the internal mul64 routine, but mark it inline. The v1 patch relied in gcc's pre-c99 inlining semantics. The v2 patch ought to compile in strict

[Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-01-28 Thread mrhines
From: "Michael R. Hines" Signed-off-by: Michael R. Hines --- arch_init.c | 116 +++-- include/migration/qemu-file.h |1 + savevm.c | 90 +++- 3 files changed, 189 insertions(+), 18 del

[Qemu-devel] [RFC PATCH RDMA support v1: 4/5] connection-setup code between client/server

2013-01-28 Thread mrhines
From: "Michael R. Hines" Signed-off-by: Michael R. Hines --- migration-tcp.c | 53 + migration.c | 41 + 2 files changed, 94 insertions(+) diff --git a/migration-tcp.c b/migration-tcp.c index e

[Qemu-devel] [RFC PATCH RDMA support v1: 3/5] initialize RDMA options when QEMU first runs on command-line

2013-01-28 Thread mrhines
From: "Michael R. Hines" Signed-off-by: Michael R. Hines --- exec.c | 27 +++ vl.c | 10 ++ 2 files changed, 37 insertions(+) diff --git a/exec.c b/exec.c index b85508b..4fc56d1 100644 --- a/exec.c +++ b/exec.c @@ -25,6 +25,8 @@ #endif #include "qemu-

[Qemu-devel] [RFC PATCH RDMA support v1: 1/5] add openfabrics RDMA libraries and base RDMA code to build

2013-01-28 Thread mrhines
From: "Michael R. Hines" Signed-off-by: Michael R. Hines --- Makefile.target |5 +- include/qemu/rdma.h | 249 ++ qemu-rdma.c | 1357 +++ 3 files changed, 1609 insertions(+), 2 deletions(-) create mode 100644 include/qem

[Qemu-devel] [RFC PATCH RDMA support v1: 2/5] install new monitor commands to configure RDMA

2013-01-28 Thread mrhines
From: "Michael R. Hines" Signed-off-by: Michael R. Hines --- hmp-commands.hx | 56 ++ hmp.c| 23 ++ hmp.h|4 qapi-schema.json | 56 +++

[Qemu-devel] [PULL for-1.4 0/2] qemu-ga: fix memory/filehandle leaks

2013-01-28 Thread Michael Roth
The following changes since commit 6034fe7bdb555c43022706e228cde8d52a8b341a: xilinx_ethlite: Avoid build warnings in debug code (2013-01-27 01:05:00 +0100) are available in the git repository at: git://github.com/mdroth/qemu.git qga-pull-1-28-13 for you to fetch changes up to 10a2158f52796e

[Qemu-devel] [ANNOUNCE] QEMU 1.3.1 Stable released

2013-01-28 Thread mdroth
Hi everyone, I am pleased to announce that the QEMU v1.3.1 stable release is now available at: http://wiki.qemu.org/download/qemu-1.3.1.tar.bz2 The official stable-1.3 repository has also been updated to v1.3.1: http://git.qemu.org/?p=qemu-stable-1.3.git;a=summary This release includes 29 buil

[Qemu-devel] [PATCH 2/2] qemu-ga: Plug leaks on qmp_guest_network_get_interfaces() error paths

2013-01-28 Thread Michael Roth
From: Markus Armbruster Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino Signed-off-by: Michael Roth --- qga/commands-posix.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/qga/commands-posix.c b/qg

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-28 Thread Peter Maydell
On 28 January 2013 19:14, Andreas Färber wrote: > Am 28.01.2013 19:59, schrieb Peter Maydell: >> Er, what? "do ... while (0)" is completely standard practice >> for writing robust macros in C. Patches which don't do that >> should fail code review. > > Oh really? None of our QOM cast macros use it

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-01-28 Thread Eric Blake
On 01/27/2013 11:14 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 76 > ++ > qga/qapi-schema.json | 42 +++ > 2 files changed, 118 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-p

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-28 Thread Gleb Natapov
On Mon, Jan 28, 2013 at 12:48:43PM -0600, Anthony Liguori wrote: > Gleb Natapov writes: > > > On Mon, Jan 28, 2013 at 10:10:06AM -0600, Anthony Liguori wrote: > >> David Woodhouse writes: > >> > >> > On Sun, 2013-01-27 at 18:53 -0600, Anthony Liguori wrote: > >> >> Are you just trying to persis

Re: [Qemu-devel] [PATCH 1/2] host-utils: Use __int128 for mul[us]64

2013-01-28 Thread Blue Swirl
On Mon, Jan 28, 2013 at 6:52 PM, Richard Henderson wrote: > Replace some x86_64 specific inline assembly with something that > all 64-bit hosts ought to optimize well. At worst this becomes a > call to the gcc __multi3 routine, which is no worse than our > implementation in util/host-utils.c. > >

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-28 Thread Anthony Liguori
Eric Blake writes: > On 01/27/2013 11:14 AM, Lei Li wrote: >> Signed-off-by: Lei Li >> --- >> include/qapi/qmp/qerror.h |3 +++ >> qga/commands-posix.c | 30 ++ >> qga/qapi-schema.json | 38 ++ >> 3 files changed,

Re: [Qemu-devel] [PATCHv4 1/2] qemu-img: find the image end offset during check

2013-01-28 Thread Blue Swirl
On Mon, Jan 28, 2013 at 11:59 AM, Federico Simoncelli wrote: > This patch adds the support for reporting the image end offset (in > bytes). This is particularly useful after a conversion (or a rebase) > where the destination is a block device in order to find the first > unused byte at the end of

Re: [Qemu-devel] [PATCH v2 2/3] VFIO-AER: Vfio-pci driver changes for supporting AER

2013-01-28 Thread Alex Williamson
On Mon, 2013-01-28 at 09:54 +, Pandarathil, Vijaymohan R wrote: > - New VFIO_SET_IRQ ioctl option to pass the eventfd that is signalled > when > an error occurs in the vfio_pci_device > > - Register pci_error_handler for the vfio_pci driver > > - When the device e

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-28 Thread Andreas Färber
Am 28.01.2013 19:22, schrieb Richard Henderson: > On 01/27/2013 05:32 AM, Andreas Färber wrote: >> Make LOG_DISAS() arguments compile-testable even if disabled. >> >> Signed-off-by: Andreas Färber >> --- >> target-alpha/translate.c | 12 ++-- >> 1 Datei geändert, 6 Zeilen hinzugefügt(

Re: [Qemu-devel] [PATCH 0/2] Improve 128-bit multiply primitives

2013-01-28 Thread Andreas Färber
Am 28.01.2013 19:52, schrieb Richard Henderson: > Richard Henderson (2): > host-utils: Use __int128 for mul[us]64 > host-utils: Improve mulu64 and muls64 Please fix Coding Style warnings in the latter (e.g., no space before parenthesis, spacing aroung = ). More importantly I wonder if we coul

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-28 Thread Andreas Färber
Am 28.01.2013 19:59, schrieb Peter Maydell: > On 28 January 2013 18:54, Andreas Färber wrote: >> Am 28.01.2013 19:22, schrieb Richard Henderson: >>> On 01/27/2013 05:32 AM, Andreas Färber wrote: +#define LOG_DISAS(...) G_STMT_START \ +if (ALPHA_DEBUG_DISAS) { \ +qemu_log

Re: [Qemu-devel] [PATCH 1/2] host-utils: Use __int128 for mul[us]64

2013-01-28 Thread Richard Henderson
On 01/28/2013 11:02 AM, Peter Maydell wrote: Have you written the test like this because you know there are compilers out there that implement addition but not multiplication (or unsigned but not signed, or whatever), or just out of a vague sense of caution? Vague sense of caution. I tried to

Re: [Qemu-devel] [PATCH 1/2] host-utils: Use __int128 for mul[us]64

2013-01-28 Thread Peter Maydell
On 28 January 2013 18:52, Richard Henderson wrote: > Replace some x86_64 specific inline assembly with something that > all 64-bit hosts ought to optimize well. At worst this becomes a > call to the gcc __multi3 routine, which is no worse than our > implementation in util/host-utils.c. Hurrah fo

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-28 Thread Andreas Färber
Am 28.01.2013 19:29, schrieb Peter Maydell: > On 28 January 2013 18:22, Richard Henderson wrote: >> On 01/27/2013 05:32 AM, Andreas Färber wrote: >>> +#define LOG_DISAS(...) G_STMT_START \ >>> +if (ALPHA_DEBUG_DISAS) { \ >>> +qemu_log_mask(CPU_LOG_TB_IN_ASM, ## __VA_ARGS__); \ >>> +

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-28 Thread Peter Maydell
On 28 January 2013 18:54, Andreas Färber wrote: > Am 28.01.2013 19:22, schrieb Richard Henderson: >> On 01/27/2013 05:32 AM, Andreas Färber wrote: >>> +#define LOG_DISAS(...) G_STMT_START \ >>> +if (ALPHA_DEBUG_DISAS) { \ >>> +qemu_log_mask(CPU_LOG_TB_IN_ASM, ## __VA_ARGS__); \ >>> +

[Qemu-devel] [PATCH 1/2] host-utils: Use __int128 for mul[us]64

2013-01-28 Thread Richard Henderson
Replace some x86_64 specific inline assembly with something that all 64-bit hosts ought to optimize well. At worst this becomes a call to the gcc __multi3 routine, which is no worse than our implementation in util/host-utils.c. With gcc 4.7, we get identical code generation for x86_64. We now ge

[Qemu-devel] [PATCH 2/2] host-utils: Improve mulu64 and muls64

2013-01-28 Thread Richard Henderson
The new formulation makes better use of add-with-carry type insns that the host may have. Use gcc's sign adjustment trick to avoid having to perform a 128-bit negation. Signed-off-by: Richard Henderson --- util/host-utils.c | 98 +-- 1 file ch

[Qemu-devel] [PATCH 0/2] Improve 128-bit multiply primitives

2013-01-28 Thread Richard Henderson
This improves code generation for mul[us]64 for all hosts. In the case of ia64 and s390x we see immediate benefit as we get to use the native 128-bit multiply insn. In the case of ppc64, we need a patch to gcc to enable this; I hope to get such a patch into gcc 4.8.0, but it may have to wait for

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-28 Thread Anthony Liguori
Gleb Natapov writes: > On Mon, Jan 28, 2013 at 10:10:06AM -0600, Anthony Liguori wrote: >> David Woodhouse writes: >> >> > On Sun, 2013-01-27 at 18:53 -0600, Anthony Liguori wrote: >> >> Are you just trying to persist a single blob of a fixed maximum size? >> > >> > That would suffice. >> > >>

Re: [Qemu-devel] memcpy speed (Re: [PATCH v2] netmap backend (revised))

2013-01-28 Thread Luigi Rizzo
On Thu, Jan 24, 2013 at 11:24 PM, Stefan Hajnoczi wrote: > On Thu, Jan 24, 2013 at 6:35 PM, Luigi Rizzo wrote: > > >> > > >> > never mind, pilot error. in my test program i had swapped the > >> > arguments to __builtin_memcpy(). With the correct ones, > >> > __builtin_memcpy() == bcopy == memc

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-28 Thread Gleb Natapov
On Mon, Jan 28, 2013 at 10:10:06AM -0600, Anthony Liguori wrote: > David Woodhouse writes: > > > On Sun, 2013-01-27 at 18:53 -0600, Anthony Liguori wrote: > >> Are you just trying to persist a single blob of a fixed maximum size? > > > > That would suffice. > > > >> Why not just have a second fla

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-28 Thread Peter Maydell
On 28 January 2013 18:22, Richard Henderson wrote: > On 01/27/2013 05:32 AM, Andreas Färber wrote: >> +#define LOG_DISAS(...) G_STMT_START \ >> +if (ALPHA_DEBUG_DISAS) { \ >> +qemu_log_mask(CPU_LOG_TB_IN_ASM, ## __VA_ARGS__); \ >> +} \ >> +G_STMT_END > > > I see zero advantage

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-28 Thread Eric Blake
On 01/27/2013 11:14 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > include/qapi/qmp/qerror.h |3 +++ > qga/commands-posix.c | 30 ++ > qga/qapi-schema.json | 38 ++ > 3 files changed, 71 insertions(+), 0 deletion

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-28 Thread Richard Henderson
On 01/27/2013 05:32 AM, Andreas Färber wrote: Make LOG_DISAS() arguments compile-testable even if disabled. Signed-off-by: Andreas Färber --- target-alpha/translate.c | 12 ++-- 1 Datei geändert, 6 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) Acked-by: Richard Henderson +#defin

[Qemu-devel] [PATCH V2 4/4] block: Optionally block drivers to optionally reopen images after snapshot creation.

2013-01-28 Thread Benoît Canet
Protocols like quorum will be able to queue multiple reopens. Signed-off-by: Benoit Canet --- block.c | 25 + blockdev.c|5 +++-- include/block/block.h |2 ++ include/block/block_int.h |3 +++ 4 files changed, 33 inserti

[Qemu-devel] [PULL 00/37] QOM CPUState patch queue 2013-01-28

2013-01-28 Thread Andreas Färber
Hello, This is my current QOM CPU patch queue. Please pull. It includes: * x86 APIC ID topology fixes, * -cpu bugfixes related to QOM CPU subtypes for alpha, arm, m68k, or32 and uc32, * a new QOM accessor object_class_is_abstract(), * a CPUClass::class_by_name hook and cpu_class_by_name() wrapper

[Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet --- blockdev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 0ce45c5..b1f388b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -800,7 +800,8 @@ void qmp_transaction(BlockdevActionList *dev_list, Error **errp)

[Qemu-devel] [PATCH 01/37] target-openrisc: Drop OpenRISCCPUList

2013-01-28 Thread Andreas Färber
It was missed in 92a3136174f60ee45b113296cb2c2a5225b00369 (cpu: Introduce CPUListState struct) because its naming did not match the *CPUListState pattern. Use the generalized CPUListState instead. Signed-off-by: Andreas Färber --- target-openrisc/cpu.c |9 ++--- 1 Datei geändert, 2 Zeile

[Qemu-devel] [PATCH for-1.4] libqtest: Wait for the right child PID after killing QEMU

2013-01-28 Thread Eduardo Habkost
When running "make check" with gcov enabled, we get the following message: hw/tmp105.gcda:cannot open data file, assuming not executed The problem happens because: * tmp105-test exits before QEMU exits, because waitpid() at qtest_quit() fails; * waitpid() fails because there's another pr

[Qemu-devel] [RFC V8 04/13] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/blkverify.c | 108 + include/qemu-common.h |2 + util/iov.c| 103 ++ 3 files changed, 107 insertions(+), 106 deletions(-) diff --git a/block/blk

[Qemu-devel] [PATCH 29/37] target-arm: Catch attempt to instantiate abstract type in cpu_init()

2013-01-28 Thread Andreas Färber
This fixes -cpu arm-cpu asserting. Cc: qemu-sta...@nongnu.org Acked-by: Peter Maydell Signed-off-by: Andreas Färber --- target-arm/cpu.c |3 ++- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index 57126b6..d1a4c82 100644 ---

[Qemu-devel] [PATCH 04/37] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-28 Thread Andreas Färber
From: Eduardo Habkost This is a cleanup that tries to solve two small issues: - We don't need a separate kvm_pv_eoi_features variable just to keep a constant calculated at compile-time, and this style would require adding a separate variable (that's declared twice because of the CONFIG

[Qemu-devel] [RFC V8 00/13] Quorum block filter.

2013-01-28 Thread Benoît Canet
This patchset is rebased on top of "cutils: unsigned int parsing functions" by "Eduardo Habkost". It must be applied on top of "Pave the way for protocol snapshot creation" This patchset create a block driver implementing a quorum using total qemu disk images. Writes are mirrored on the $total fi

Re: [Qemu-devel] [PATCHv4 2/2] qemu-img: add json output option to the check command

2013-01-28 Thread Eric Blake
On 01/28/2013 04:59 AM, Federico Simoncelli wrote: > This option --output=[human|json] makes qemu-img check output a human > or JSON representation at the choice of the user. > > Signed-off-by: Federico Simoncelli > --- > qapi-schema.json | 46 +++ > qemu-img-cmds.hx |4 +- > qemu-

[Qemu-devel] [PATCH 35/37] target-m68k: Use type_register() instead of type_register_static()

2013-01-28 Thread Andreas Färber
According to its documentation, type_register_static()'s TypeInfo argument should exist for the life type of the type. Therefore use type_register() when registering the list of CPU subtypes. No functional change with the current implementation. Cf. 918fd0839eeafc83bd4984364321a947d29041fe for ar

[Qemu-devel] [PATCH 09/37] fw_cfg: Remove FW_CFG_MAX_CPUS from fw_cfg_init()

2013-01-28 Thread Andreas Färber
From: Eduardo Habkost PC will not use max_cpus for that field, so move it outside the common code so it can use a different value on PC. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- hw/fw_cfg.c |1 - hw/pc.c |2 +- hw/ppc/mac_newworld.c |

Re: [Qemu-devel] [RFC 6/6] tests: Workaround gcov being unable to open .gcda file

2013-01-28 Thread Eduardo Habkost
On Mon, Jan 28, 2013 at 03:26:36PM -0200, Eduardo Habkost wrote: > On Sat, Jan 26, 2013 at 12:45:15PM +0100, Andreas Färber wrote: > > Resolve the following error: > > > > hw/tmp105.gcda:cannot open data file, assuming not executed > > > > by adding a sleep before running gcov after the qtest c

Re: [Qemu-devel] [PATCH V2 2/4] block: make path_hash_protocol public.

2013-01-28 Thread Eric Blake
On 01/28/2013 10:04 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block.c |2 +- > include/block/block.h |1 + > 2 files changed, 2 insertions(+), 1 deletion(-) s/hash/has/ in the subject line. > /* check if the path starts with ":" */ > -static int path_

[Qemu-devel] [RFC V8 09/13] quorum: Add quorum_co_is_allocated.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 53 + 1 file changed, 53 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 1c50ed5..459434f 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -134,6 +134,22 @@ static int quoru

[Qemu-devel] [PATCH V2 1/4] block: Add option to do external snapshot image creation in the block drivers.

2013-01-28 Thread Benoît Canet
This patch will allow protocols to implements snapshots as the image creation can now delegated to the block driver. Signed-off-by: Benoit Canet --- block.c | 26 ++ blockdev.c|8 include/block/block.h |6 ++ in

[Qemu-devel] [RFC V8 13/13] quorum: Add quorum_open() and quorum_close().

2013-01-28 Thread Benoît Canet
Valid quorum resources look like quorum:threshold/total:path/to/image_1: ... :path/to/image_total ':' is used as a separator '\' is the escaping character for filename containing ':' '\' escape itself ',' must be escaped with ',' On the command line for quorum files "img:test.raw", "img2,raw" and

Re: [Qemu-devel] [PATCHv4 1/2] qemu-img: find the image end offset during check

2013-01-28 Thread Eric Blake
On 01/28/2013 04:59 AM, Federico Simoncelli wrote: > This patch adds the support for reporting the image end offset (in > bytes). This is particularly useful after a conversion (or a rebase) > where the destination is a block device in order to find the first > unused byte at the end of the image.

Re: [Qemu-devel] [PATCH v2 1/3] VFIO: Wrappers for getting/putting reference to vfio_device

2013-01-28 Thread Alex Williamson
On Mon, 2013-01-28 at 09:54 +, Pandarathil, Vijaymohan R wrote: > - Added vfio_device_get_from_vdev(), vfio_device_put_vdev() > as wrappers to get/put reference to vfio_device from struct device. > > - Added vfio_device_data() as a wrapper to get device_data from >

Re: [Qemu-devel] [PATCH 4/7 v2] KVM regsync: Add register bitmap parameter to do_kvm_cpu_synchronize_state

2013-01-28 Thread Jason J. Herne
On 01/24/2013 07:01 PM, Marcelo Tosatti wrote: On Thu, Jan 24, 2013 at 06:44:50PM -0200, Marcelo Tosatti wrote: What 'subtle errors' are you thinking of? It should be easy to convert as its greppable. S/390 not synchronizing the env-> copy of the FULL register set is still a bug, though (beca

Re: [Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

2013-01-28 Thread Stefan Weil
Am 28.01.2013 18:34, schrieb Cornelia Huck: > On Mon, 28 Jan 2013 18:08:10 +0100 > Stefan Weil wrote: > >> Am 28.01.2013 17:06, schrieb Cornelia Huck: >>> On Sat, 26 Jan 2013 14:17:36 + >>> Blue Swirl wrote: >>> On Fri, Jan 25, 2013 at 12:48 PM, Alexander Graf wrote: > Hi Blue / Aur

[Qemu-devel] [RFC V8 02/13] quorum: Create BDRVQuorumState and BlkDriver and do init.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 8dc6e4c..d8fffbe 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,13 @@ #include "block/block_int.h" +typedef struct

Re: [Qemu-devel] [PATCH V11 3/4] Use QemuOpts support in block layer

2013-01-28 Thread Markus Armbruster
Dong Xu Wang writes: > Markus Armbruster writes: >> Dong Xu Wang writes: >> >>> This patch will use QemuOpts related functions in block layer, add >>> a member bdrv_create_options to BlockDriver struct, it will return >>> a QemuOptsList pointer, which includes the image format's create >>> opt

[Qemu-devel] [PATCH 33/37] target-openrisc: Use type_register() instead of type_register_static()

2013-01-28 Thread Andreas Färber
According to its documentation, type_register_static()'s TypeInfo argument should exist for the life type of the type. Therefore use type_register() when registering the list of CPU subtypes. No functional change with the current implementation. Cf. 918fd0839eeafc83bd4984364321a947d29041fe for ar

[Qemu-devel] [PATCH 32/37] target-unicore32: Catch attempt to instantiate abstract type in cpu_init()

2013-01-28 Thread Andreas Färber
Fixes -cpu unicore32-cpu asserting. Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- target-unicore32/cpu.c |3 ++- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/target-unicore32/cpu.c b/target-unicore32/cpu.c index 9239d49..6735b25 100644 --- a/tar

  1   2   3   >