Am 28.01.2013 19:22, schrieb Richard Henderson:
> On 01/27/2013 05:32 AM, Andreas Färber wrote:
>> Make LOG_DISAS() arguments compile-testable even if disabled.
>>
>> Signed-off-by: Andreas Färber <afaer...@suse.de>
>> ---
>> target-alpha/translate.c | 12 ++++++------
>> 1 Datei geändert, 6 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-)
>
> Acked-by: Richard Henderson <r...@twiddle.net>
>
>> +#define LOG_DISAS(...) G_STMT_START \
>> + if (ALPHA_DEBUG_DISAS) { \
>> + qemu_log_mask(CPU_LOG_TB_IN_ASM, ## __VA_ARGS__); \
>> + } \
>> + G_STMT_END
>
> I see zero advantage to using G_STMT_START/END over the
> shorter and significantly more obvious direct use of do/while.
Well, I see close to zero advantage in using a loop at all. We could
just as well review all callers and just code the pure logic. An inline
function by comparison would relieve us from all that \ ugliness, too.
> We just zapped useless gtype typedefs. Do we have to add
> yet another useless glib thing?
We didn't. It was proposed and rejected in that form.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
