[Qemu-devel] [PATCH v12 rebased 7/8] allower the user to disable pv event support

2013-01-22 Thread Hu Tao
Signed-off-by: Wen Congyang Signed-off-by: Hu Tao --- hw/pc_piix.c| 9 - qemu-options.hx | 3 ++- vl.c| 4 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index fed6ccf..507c98b 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c

[Qemu-devel] [PATCH v12 rebased 4/8] add a new runstate: RUN_STATE_GUEST_PANICKED

2013-01-22 Thread Hu Tao
The guest will be in this state when it is panicked. If guest is panicked during live migration, the runstate RUN_STATE_GUEST_PANICKED will be transferred to dest machine. Signed-off-by: Wen Congyang Signed-off-by: Hu Tao --- migration.c | 1 + qapi-schema.json | 6 +- qmp.c

[Qemu-devel] [PATCH v12 rebased 6/8] introduce a new qom device to deal with panicked event

2013-01-22 Thread Hu Tao
If the target is x86/x86_64, the guest's kernel will write 0x01 to the port KVM_PV_EVENT_PORT when it is panciked. This patch introduces a new qom device kvm_pv_ioport to listen this I/O port, and deal with panicked event according to panicked_action's value. The possible actions are: 1. emit QEVEN

[Qemu-devel] [PATCH v12 rebased 3/8] update kernel headers

2013-01-22 Thread Hu Tao
update kernel headers to add pv event macros. Signed-off-by: Wen Congyang Signed-off-by: Hu Tao --- linux-headers/asm-x86/kvm_para.h | 1 + linux-headers/linux/kvm_para.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/linux-headers/asm-x86/kvm_para.h b/linux-headers/asm-x86/kvm_pa

[Qemu-devel] [PATCH v12 rebased] kvm: notify host when the guest is panicked

2013-01-22 Thread Hu Tao
We can know the guest is panicked when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can do auto dump when the guest is panicked. If management app does not do auto dump, the guest's user can do dump by hand

[Qemu-devel] [PATCH v12 rebased 2/8] start vm after resetting it

2013-01-22 Thread Hu Tao
From: Wen Congyang The guest should run after resetting it, but it does not run if its old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. We don't set runstate to RUN_STATE_PAUSED when resetting the guest, so the runstate will be changed from RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED

[Qemu-devel] [PATCH v12 rebased 0/8] pv event to notify host when the guest is panicked

2013-01-22 Thread Hu Tao
This series implements a new interface, kvm pv event, to notify host when some events happen in guest. Right now there is one supported event: guest panic. Also, the cpu runstate is preserved during save/load vm and migration. Thus, if vm is panicked during migration, we can still know it by qurin

[Qemu-devel] msi interrupts to the guest

2013-01-22 Thread Rishi Agrawal
Hi All, I am trying to send a msi interrupt to the guest linux image. My code is something like msi_init(DEVICE_STRUCT) msi_notify(DEVICE _STRUCT) But as I call msi_notify qemu crashes with SIGABRT. -- Regards, Rishi Agrawal

[Qemu-devel] [PATCH v10 3/5] Common definitions for VMWARE devices

2013-01-22 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 143 ++ hw/vmxnet_debug.h | 115 ++ include/net/eth.h | 347 ++ net/Makefile.objs | 1 + net/eth.c | 218

Re: [Qemu-devel] Updated CPUhotplug wiki page

2013-01-22 Thread li guang
Hi, Igor Thanks for your description, I am not so clear with last 2 items, * Add acpi code to handle CPU hot-add event the original acpi-dsdt-cpu-hotplug.dsl of seabios is not working correctly now? how do yo know it? *ACPI guest notification is not impl. yet what's job for it? do you also mean

[Qemu-devel] [PATCH v10 2/5] iovec checksum calculation fuction

2013-01-22 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- include/net/checksum.h | 8 net/checksum.c | 28 2 files changed, 36 insertions(+) diff --git a/include/net/checksum.h b/include/net/checksum.h index 3e7b93d..b1cf18a 100644 --- a/inc

[Qemu-devel] [PATCH v10 4/5] Packet abstraction for VMWARE network devices

2013-01-22 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/Makefile.objs | 1 + hw/vmxnet_rx_pkt.c | 187 ++ hw/vmxnet_rx_pkt.h | 174 hw/vmxnet_tx_pkt.c | 567 + hw/vmxnet_tx_pkt.h | 148 ++

[Qemu-devel] [PATCH v10 1/5] Checksum-related utility functions

2013-01-22 Thread Dmitry Fleytman
net_checksum_add_cont() checksum calculation for scattered data with odd chunk sizes net_raw_checksum() checksum calculation for a buffer Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- include/net/checksum.h | 14 +- net/checksum.c | 13 +++-- 2 fi

[Qemu-devel] [PATCH V10 0/5] VMXNET3 paravirtual NIC device implementation

2013-01-22 Thread Dmitry Fleytman
This set of patches implements VMWare VMXNET3 paravirtual NIC device. The device supports of all the device features including offload capabilties, VLANs and etc. The device is tested on different OSes: Fedora 15 Ubuntu 10.4 Centos 6.2 Windows 2008R2 Windows 2008 64bit Windo

[Qemu-devel] [PATCH 2/5] pseries: Improve handling of multiple PCI host bridges

2013-01-22 Thread David Gibson
Multiple - even many - PCI host bridges (i.e. PCI domains) are very common on real PAPR compliant hardware. For reasons related to the PAPR specified IOMMU interfaces, PCI device assignment with VFIO will generally require at least two (virtual) PHBs and possibly more depending on which devices ar

[Qemu-devel] [PATCH 3/5] target-ppc: Synchronize more SPRs to KVM using ONE_REG interface

2013-01-22 Thread David Gibson
There are currently a batch of occasionally used SPRs whose state we do not synchronize with KVM. This might be a problem for debugging, and will definitely be a problem for savevm / migration. KVM now supports accessing these registers via the KVM_{GET,SET}_ONE_REG interface, so this patch wires

[Qemu-devel] [PATCH 4/5] target-ppc: Synchronize FPU state with KVM

2013-01-22 Thread David Gibson
Currently qemu does not get and put the state of the floating point and vector registers to KVM. This is obviously a problem for savevm, as well as possibly being problematic for debugging of FP-using guests. This patch fixes this by using new extensions to the ONE_REG interface to synchronize th

Re: [Qemu-devel] [PATCH v9 1/5] Adding utility function net_checksum_add_cont() that allows checksum calculation of scattered data with odd chunk sizes

2013-01-22 Thread Dmitry Fleytman
Thanks Markus, I'll fix this. Dmitry On Mon, Jan 21, 2013 at 2:48 PM, Markus Armbruster wrote: > Dmitry Fleytman writes: > > > Adding utility function net_raw_checksum() that calculates checksum > > of buffer given > > Your subject is excessively long. Please stick to the standard commit > m

Re: [Qemu-devel] [PATCH v9 3/5] Adding common definitions for VMWARE devices

2013-01-22 Thread Dmitry Fleytman
On Tue, Jan 22, 2013 at 11:02 AM, Stefan Hajnoczi wrote: > On Mon, Jan 21, 2013 at 02:16:35PM +0200, Dmitry Fleytman wrote: > > I've checked origin of headers, some of them are self-made, other came > from > > following places: > > 1. file rtl8139.c from QEMU codebase > > 2. /usr/include/n

[Qemu-devel] [PATCH 5/5] target-ppc: Synchronize VPA state with KVM

2013-01-22 Thread David Gibson
For PAPR guests, KVM tracks the various areas registered with the H_REGISTER_VPA hypercall. For full emulation, of course, these are tracked within qemu. At present these values are not synchronized. This is a problem for reset (qemu's reset of the VPA address is not pushed to KVM) and will also

[Qemu-devel] [PATCH 1/5] target-ppc: Give a meaningful error if too many threads are specified

2013-01-22 Thread David Gibson
From: Mike Qiu Currently the target-ppc tcg code only supports a single thread. You can specify more, but they're treated identically to multiple cores. On KVM we obviously can't support more threads than the hardware; if more are specified it will cause strange and cryptic errors. This patch

[Qemu-devel] [0/5] Pending pseries patches

2013-01-22 Thread David Gibson
Hi Alex, Here are several patches for pseries that have been in my local tree for a while. The first two I think I've sent before. They've been updated for upstream changes but otherwise are unchanged. The remaining ones are now unblocked since more of Paul's kvm work has gone into the upstream

Re: [Qemu-devel] [PATCH 2/3] QAPI: Introduce memchar-write QMP command

2013-01-22 Thread Lei Li
On 01/23/2013 12:27 AM, Luiz Capitulino wrote: On Tue, 22 Jan 2013 16:12:51 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 16 hmp.c| 13 + hmp.h|1 + qapi-schema.json | 41 ++

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Add new char backend CirMemCharDriver

2013-01-22 Thread Lei Li
On 01/23/2013 12:14 AM, Luiz Capitulino wrote: On Tue, 22 Jan 2013 16:12:50 +0800 Lei Li wrote: Signed-off-by: Lei Li --- qemu-char.c | 120 +++ qemu-options.hx | 10 + 2 files changed, 130 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH] target-mips: fix incorrect test for MTHLIP

2013-01-22 Thread Petar Jovanovic
The pos field in the DSPControl register is not correctly initialized. Per documentation, the result of MTHLIP is unpredictable if the value of the pos field before the execution is greater than 32. Signed-off-by: Petar Jovanovic --- tests/tcg/mips/mips32-dsp/mthlip.c |2 +- 1 files changed,

[Qemu-devel] [PATCH] target-mips: enable access to DSP ASE if implemented

2013-01-22 Thread Petar Jovanovic
From: Petar Jovanovic compute_hflags() will reset DSP h-flags, so MX bit should be initially set for usermode in cpu_state_reset() if DSP ASE is implemented. This change will bring back user-mode support for DSP ASE, since one of the recent changes broke it. Signed-off-by: Petar Jovanovic ---

[Qemu-devel] [PATCH] ich9: add support for pci assignment

2013-01-22 Thread Alex Williamson
Fills out support for the pci assignment API. Added: PCIINTxRoute ich9_route_intx_pin_to_irq(void *opaque, int pirq_pin) Add calls to pci_bus_fire_intx_routing_notifier() when routing changes are made. From: Jason Baron Signed-off-by: Alex Williamson --- Jason posted this back in October, th

Re: [Qemu-devel] [PATCH v3 11/11] qemu-ga: Fix unchecked strdup() by converting to g_strdup()

2013-01-22 Thread Luiz Capitulino
On Tue, 22 Jan 2013 11:08:06 +0100 Markus Armbruster wrote: > I figure it's freed somewhere deep down in QAPI, with g_free(). It is, by qapi_dealloc_type_str(). > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino > --- > qga/commands.c | 2 +- > 1 fil

[Qemu-devel] [PATCH v2] q35: Add new PCI slot to irq routing function

2013-01-22 Thread Alex Williamson
q35/ich9 doesn't use the same interrupt mapping function as i440fx/piix. PIRQA:D and PIRQE:H are programmed identically, but we start at index 0, not index -1. Slots 25 through 31 are also programmed independently. When running qemu w/o this patch, a device at address 0:6.0 will have its PCI int

Re: [Qemu-devel] [PATCH 1.4 0/2] iscsi: add support for iovectors

2013-01-22 Thread Anthony Liguori
Anthony Liguori writes: > Hi, > > Thank you for submitting your patch series. This note is to inform > you that this patch series no longer applies against the latest > qemu.git tree. FYI, I checked this before I let it send this. It definitely doesn't apply either with --3way or even with fuz

[Qemu-devel] [QEMU PATCH v5 0/3] virtio-net: fix of ctrl commands

2013-01-22 Thread Amos Kong
Currently virtio-net code relys on the layout of descriptor, this patchset removed the assumptions and introduced a control command to set mac address. Last patch is a trivial renaming. V2: check guest's iov_len V3: fix of migration compatibility make mac field in config space read-only when n

Re: [Qemu-devel] [PATCH v2] netmap backend (revised)

2013-01-22 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding styl

Re: [Qemu-devel] [PATCH v4 0/3] re-enable balloon stats

2013-01-22 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding styl

Re: [Qemu-devel] [PATCH 1.4 0/2] iscsi: add support for iovectors

2013-01-22 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. This note is to inform you that this patch series no longer applies against the latest qemu.git tree. If it's been at least a few days since you submitted this series, please resubmit a new version of your patch series so it can be considered for i

Re: [Qemu-devel] [PATCH 2/2] q35: Add new PCI slot to irq routing function

2013-01-22 Thread Alex Williamson
On Tue, 2013-01-22 at 15:12 -0700, Alex Williamson wrote: > q35/ich9 doesn't use the same interrupt mapping function as > i440fx/piix. PIRQA:D and PIRQE:H are programmed identically, but we > start at index 0, not index -1. Slots 25 through 31 are also > programmed independently. > > When runnin

[Qemu-devel] [PATCH 2/2] q35: Add new PCI slot to irq routing function

2013-01-22 Thread Alex Williamson
q35/ich9 doesn't use the same interrupt mapping function as i440fx/piix. PIRQA:D and PIRQE:H are programmed identically, but we start at index 0, not index -1. Slots 25 through 31 are also programmed independently. When running qemu w/o this patch, a device at address 0:6.0 will have its PCI int

[Qemu-devel] [PATCH 1/2] q35: Enable all PIRQn IRQs at startup

2013-01-22 Thread Alex Williamson
We seem to use the IRQEN bit of the PIRQn registers interchangeably to select APIC mode or to disable an IRQ. I can't decide if we're intending to disable the IRQ or select APIC mode here, but in either case it prevents PIC mode assigned devices from working. When seabios writes IRQEN to these re

[Qemu-devel] [PATCH 0/2] q35: Fix seabios IRQ mapping and setup

2013-01-22 Thread Alex Williamson
This seems like the easier approach from my RFC yesterday. Instead of trying to make ich9 interrupt mapping look like piix, just add a new slot-to-irq function so we can not only get bus 0 devices, but root ports fixed as well. The change from piix mapping is subtle, but required for device assig

Re: [Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats

2013-01-22 Thread Eric Blake
On 01/22/2013 09:57 AM, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > docs/virtio-balloon-stats.txt | 104 > ++ > 1 file changed, 104 insertions(+) > create mode 100644 docs/virtio-balloon-stats.txt > Reviewed-by: Eric Blake -- Eric

Re: [Qemu-devel] [RFC V7 03/11] quorum: Add quorum_open() and quorum_close().

2013-01-22 Thread Eric Blake
On 01/18/2013 10:30 AM, Benoît Canet wrote: > Valid quorum resources look like > quorum:threshold/total:path/to/image_1: ... :path/to/image_total > > ':' is used as a separator > '\' is the escaping character for filename containing ':' > '\' escape itself These are true of the protocol itself,

Re: [Qemu-devel] [PATCH for-1.4 01/12] kvm: Add fake KVM_FEATURE_CLOCKSOURCE_STABLE_BIT for builds withou KVM

2013-01-22 Thread Marcelo Tosatti
On Tue, Jan 22, 2013 at 05:59:14AM +0100, Andreas Färber wrote: > Am 22.01.2013 02:43, schrieb Marcelo Tosatti: > > On Thu, Jan 17, 2013 at 06:59:27PM -0200, Eduardo Habkost wrote: > >> Signed-off-by: Eduardo Habkost > >> --- > >> Cc: k...@vger.kernel.org > >> Cc: Michael S. Tsirkin > >> Cc: Gleb

[Qemu-devel] [PATCH for-1.4 qom-cpu 2/9] target-i386: kvm: Set vcpu_id to APIC ID instead of CPU index

2013-01-22 Thread Eduardo Habkost
The CPU ID in KVM is supposed to be the APIC ID, so change the KVM_CREATE_VCPU call to match it. The current behavior didn't break anything yet because today the APIC ID is assumed to be equal to the CPU index, but this won't be true in the future. Signed-off-by: Eduardo Habkost Reviewed-by: Marc

[Qemu-devel] [PATCH for-1.4 qom-cpu 1/9] kvm: Create kvm_arch_vcpu_id() function

2013-01-22 Thread Eduardo Habkost
This will allow each architecture to define how the VCPU ID is set on the KVM_CREATE_VCPU ioctl call. Signed-off-by: Eduardo Habkost --- Cc: k...@vger.kernel.org Cc: Michael S. Tsirkin Cc: Gleb Natapov Cc: Marcelo Tosatti Changes v2: - Get CPUState as argument instead of CPUArchState Change

[Qemu-devel] [PATCH for-1.4 qom-cpu 0/9] target-i386: Fix APIC-ID-based topology (v5)

2013-01-22 Thread Eduardo Habkost
Changes since v4: - Patch 1/9: Convert KVM_CREATE_VCPU ioctl() argument to void*, so the argument type matches the type expected by kvm_vm_ioctl() - Patch 4/9: rename apic_id_for_cpu() to x86_cpu_apic_id_from_index() - Patch 6/9: refresh after function renames - Patch 8/9: Remove trailing ba

[Qemu-devel] [PATCH for-1.4 qom-cpu 7/9] tests: Support target-specific unit tests

2013-01-22 Thread Eduardo Habkost
To make unit tests that depend on target-specific files, use check-unit--y and test-obj--y. Signed-off-by: Eduardo Habkost --- tests/Makefile | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index d86e95a..41172d6 100644 --- a/tes

[Qemu-devel] [PATCH for-1.4 qom-cpu 8/9] target-i386: Topology & APIC ID utility functions

2013-01-22 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- Changes v2: - Support 32-bit APIC IDs (in case x2APIC is going to be used) - Coding style changes - Use TARGET_I386_TOPOLOGY_H instead of __QEMU_X86_TOPOLOGY_H__ - Rename topo_make_apic_id() to topo_apicid_for_cpu() - Rename __make_apicid() to topo_make_apic

[Qemu-devel] [PATCH for-1.4 qom-cpu 5/9] cpus.h: Make constant smp_cores/smp_threads available on *-user

2013-01-22 Thread Eduardo Habkost
The code that calculates the APIC ID will use smp_cores/smp_threads, so just define them as 1 on *-user to avoid #ifdefs in the code. Signed-off-by: Eduardo Habkost --- include/sysemu/cpus.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/sysemu/cpus.h b/include/sysemu/cpus.h

[Qemu-devel] [PATCH for-1.4 qom-cpu 9/9] pc: Generate APIC IDs according to CPU topology

2013-01-22 Thread Eduardo Habkost
This keeps compatibility on machine-types pc-1.2 and older, and prints a warning in case the requested configuration won't get the correct topology. I couldn't think of a better way to warn about broken topology when in compat mode other than using error_report(). The warning message will be proba

[Qemu-devel] [PATCH for-1.4 qom-cpu 3/9] fw_cfg: Remove FW_CFG_MAX_CPUS from fw_cfg_init()

2013-01-22 Thread Eduardo Habkost
PC will not use max_cpus for that field, so move it outside the common code so it can use a different value on PC. Signed-off-by: Eduardo Habkost --- hw/fw_cfg.c | 1 - hw/pc.c | 2 +- hw/ppc_newworld.c | 1 + hw/ppc_oldworld.c | 1 + hw/sun4m.c| 3 +++ hw/sun4u.c

[Qemu-devel] [PATCH for-1.4 qom-cpu 6/9] pc: Set fw_cfg data based on APIC ID calculation

2013-01-22 Thread Eduardo Habkost
This changes FW_CFG_MAX_CPUS and FW_CFG_NUMA to use apic_id_for_cpu(), so the NUMA table can be based on the APIC IDs, instead of CPU index (SeaBIOS knows nothing about CPU indexes, just APIC IDs). Signed-off-by: Eduardo Habkost --- Changes v2: - Get PC object as argument - Add more detailed co

[Qemu-devel] [PATCH for-1.4 qom-cpu 4/9] target-i386/cpu: Introduce x86_cpu_apic_id_from_index() function

2013-01-22 Thread Eduardo Habkost
This function will be used by both the CPU initialization code and the fw_cfg table initialization code. Later this function will be updated to generate APIC IDs according to the CPU topology. Signed-off-by: Eduardo Habkost --- Changes v2: - Rename to x86_cpu_apic_id_from_index() --- target-i3

[Qemu-devel] [QEMU PATCH v5 3/3] virtio-net: rename ctrl rx commands

2013-01-22 Thread Amos Kong
This patch makes rx commands consistent with specification. Signed-off-by: Amos Kong --- hw/virtio-net.c | 14 +++--- hw/virtio-net.h | 14 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index acef5a5..ac4434e 100644

Re: [Qemu-devel] [QEMU]Where are debug logs

2013-01-22 Thread harryxiyou
On Wed, Jan 23, 2013 at 2:12 AM, Brendan Dolan-Gavitt wrote: > These are runtime options to QEMU. For example: "qemu-system-x86_64 -D > ~/qemu_debug.log -d in_asm". Ok, i will have a try. Thanks very much. > > Or are you trying to add *new* debugging statements to QEMU? If so, > look at the funct

Re: [Qemu-devel] [Qemu PATCH v2] add a boot option to do strict boot

2013-01-22 Thread Anthony Liguori
Eric Blake writes: > On 01/22/2013 08:52 AM, Amos Kong wrote: > Libvirt will need to expose an attribute that lets the user control whether to use this new option; how do we probe via QMP whether the new -boot strict=on command-line option is available? >>> >>> Hi all, >>

Re: [Qemu-devel] [PATCH v9 3/7] trace: Provide a detailed event control interface

2013-01-22 Thread Stefan Hajnoczi
On Thu, Jan 10, 2013 at 08:23:13PM +0100, Lluís Vilanova wrote: > diff --git a/trace/control-internal.h b/trace/control-internal.h > new file mode 100644 > index 000..188253a > --- /dev/null > +++ b/trace/control-internal.h > @@ -0,0 +1,67 @@ > +/* > + * Interface for configuring and controllin

Re: [Qemu-devel] [QEMU]Where are debug logs

2013-01-22 Thread Brendan Dolan-Gavitt
These are runtime options to QEMU. For example: "qemu-system-x86_64 -D ~/qemu_debug.log -d in_asm". Or are you trying to add *new* debugging statements to QEMU? If so, look at the functions in qemu-log.h, and at the constants defined in exec.c. -Brendan On Tue, Jan 22, 2013 at 12:59 PM, harryxiy

Re: [Qemu-devel] [QEMU]Where are debug logs

2013-01-22 Thread harryxiyou
On Wed, Jan 23, 2013 at 12:58 AM, Brendan Dolan-Gavitt wrote: > Assuming you're using one of the -d options to qemu, they will by > default go into /tmp/qemu.log. How to add -d options to qemu.(Configure qemu/configure or Makefile?) > You can also specify where to put the debug log using the -D

[Qemu-devel] [PATCH] target-mips: Unfuse {,N}M{ADD,SUB}.fmt

2013-01-22 Thread Richard Sandiford
Turn MADD.fmt, MSUB.fmt, NMADD.fmt and NMSUB.fmt from fused to unfused operations, so that they behave in the same way as a separate multiplication and addition. The instructions were only fused in early MIPS IV processors. Signed-off-by: Richard Sandiford --- target-mips/op_helper.c | 25 +

Re: [Qemu-devel] [PULL for-1.4 0/2] spice patch queue

2013-01-22 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > > Here comes the spice patch queue with two little bugfixes for qxl. > > please pull, The commit messages could use some love, see my reply on Alon's PATCH v3.

Re: [Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192

2013-01-22 Thread Markus Armbruster
Alon Levy writes: > This is a simpler solution to 869981, where migration breaks since qxl's s/869981/RHBZ#869981/ > rom bar size has changed. Instead of ignoring fields in QXLRom, which is what > has Long line, please wrap. > actually changed, we remove some of the modes, a mechanism alread

Re: [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4

2013-01-22 Thread Markus Armbruster
Alon Levy writes: > Signed-off-by: Alon Levy Why do we want to stop supporting capabilities and monitors config with old revisions? A brief explanation would be nice to have in the commit message.

Re: [Qemu-devel] [PATCH] softfloat: Handle float_muladd_negate_c when product is zero

2013-01-22 Thread Richard Sandiford
Richard Sandiford writes: > BTW, I'm not sure it's right to be using *_muladd for MIPS. MADD.fmt & > co. were fused operations in the early MIPS IV processors, but they've > had an intermediate rounding step since then (i.e. they're equivalent > to a separate multiplication and addition). I'm no

Re: [Qemu-devel] [PATCH 2/2] rtl8139: preserve link state across device reset

2013-01-22 Thread Jan Kiszka
On 2012-12-28 10:29, Amos Kong wrote: > A device reset does not affect the link state, only set_link does. > > Signed-off-by: Amos Kong > --- > hw/rtl8139.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/rtl8139.c b/hw/rtl8139.c > index c59ec6b..3e08062 100644

Re: [Qemu-devel] [PATCH v2] softfloat: Handle float_muladd_negate_c when product is zero

2013-01-22 Thread Peter Maydell
On 22 January 2013 17:03, Richard Sandiford wrote: > Honour float_muladd_negate_c in the case where the product is zero and > c is nonzero. Previously we would fail to negate c. > > Seen in (and tested against) the gfortran testsuite on MIPS. > > Signed-off-by: Richard Sandiford Reviewed-by: Pe

[Qemu-devel] [PATCH v2] softfloat: Handle float_muladd_negate_c when product is zero

2013-01-22 Thread Richard Sandiford
Honour float_muladd_negate_c in the case where the product is zero and c is nonzero. Previously we would fail to negate c. Seen in (and tested against) the gfortran testsuite on MIPS. Signed-off-by: Richard Sandiford --- fpu/softfloat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 2/3] balloon: re-enable balloon stats

2013-01-22 Thread Luiz Capitulino
The statistics are now available through device properties via a polling mechanism. First a client has to enable polling, then it can query available stats. Polling is enabled by setting an update interval (in seconds) to a property named guest-stats-polling-interval, like this: { "execute": "qom

Re: [Qemu-devel] [QEMU]Where are debug logs

2013-01-22 Thread Brendan Dolan-Gavitt
Assuming you're using one of the -d options to qemu, they will by default go into /tmp/qemu.log. You can also specify where to put the debug log using the -D option. -Brendan On Tue, Jan 22, 2013 at 11:49 AM, harryxiyou wrote: > Hi all, > > When i debug our block driver in QEMU source codes, i c

[Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2013-01-22 Thread Luiz Capitulino
Next commit will re-enable balloon stats with a different interface, but this old code conflicts with it. Let's drop it. It's important to note that the QMP and HMP interfaces are also dropped by this commit. That shouldn't be a problem though, because: 1. All QMP fields are optional 2. This fe

Re: [Qemu-devel] [PATCH v3 10/11] qapi: Fix unchecked strdup() by converting to g_strdup()

2013-01-22 Thread Luiz Capitulino
On Tue, 22 Jan 2013 11:08:05 +0100 Markus Armbruster wrote: > Note that we already free with g_free(). > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino > --- > qapi/qmp-registry.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

[Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats

2013-01-22 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- docs/virtio-balloon-stats.txt | 104 ++ 1 file changed, 104 insertions(+) create mode 100644 docs/virtio-balloon-stats.txt diff --git a/docs/virtio-balloon-stats.txt b/docs/virtio-balloon-stats.txt new file mode 100644 i

[Qemu-devel] [PATCH v4 0/3] re-enable balloon stats

2013-01-22 Thread Luiz Capitulino
This series re-enables the virtio-balloon device stats feature. It now uses QOM properties via a polling mechanism as suggested by Anthony here: http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02390.html o v4 - doc fixes and small changes Luiz Capitulino (3): balloon: drop old stats

Re: [Qemu-devel] [PATCH] gdbstub: Implement "Xfer:spaces" requests. This is a part of Codebench IDE integration.

2013-01-22 Thread Jan Kiszka
On 2013-01-09 09:50, Stefan Hajnoczi wrote: > On Tue, Jan 08, 2013 at 01:31:36AM +0200, Alex Rozenman wrote: >> Signed-off-by: Alex Rozenman >> --- >> gdbstub.c | 113 >> + >> 1 file changed, 113 insertions(+) > > Also worth CCing Jan

Re: [Qemu-devel] trace: weird issues with makefile dependencies

2013-01-22 Thread Paolo Bonzini
Il 22/01/2013 15:59, Stefan Hajnoczi ha scritto: > Why not seriously default to ./build/ for build products and get rid of > class in-tree builds? > > The build still happens inside the working tree by default but it will > be in a dedicated ./build/ directory. We can easily rm -rf that > directo

[Qemu-devel] [QEMU]Where are debug logs

2013-01-22 Thread harryxiyou
Hi all, When i debug our block driver in QEMU source codes, i cannot find the debug logs for QEMU. I have searched /var/log/messages and /var/log/dmesg but i cannot find debug logs. Could anyone tell me how to find debug logs? Thanks in advance ;-) -- Thanks Harry Wei

[Qemu-devel] [PATCH 1.4 2/2] iscsi: add support for iovectors

2013-01-22 Thread Paolo Bonzini
From: Peter Lieven This patch adds support for directly passing the iovec array from QEMUIOVector if libiscsi supports it. Signed-off-by: Peter Lieven [Preserve the improvements from commit 4cc841b, iscsi: partly avoid iovec linearization in iscsi_aio_writev, 2012-11-19 - Paolo] Signed-off-by:

Re: [Qemu-devel] [Qemu PATCH v2] add a boot option to do strict boot

2013-01-22 Thread Eric Blake
On 01/22/2013 08:52 AM, Amos Kong wrote: >>> >>> Libvirt will need to expose an attribute that lets the user control >>> whether to use this new option; how do we probe via QMP whether the >>> new >>> -boot strict=on command-line option is available? >> >> Hi all, >> >> How about add new info/quer

[Qemu-devel] [PATCH 1.4 1/2] iscsi: do not leak acb->buf when commands are aborted

2013-01-22 Thread Paolo Bonzini
acb->buf is freed in the WRITE(16) callback, but this may not get called at all when commands are aborted. Add another free in the ABORT TASK callback, which requires setting acb->buf to NULL everywhere. Signed-off-by: Paolo Bonzini --- block/iscsi.c | 8 +++- 1 file changed, 7 insertions(+

[Qemu-devel] [PATCH 1.4 0/2] iscsi: add support for iovectors

2013-01-22 Thread Paolo Bonzini
Help testing these patches is welcome. Paolo Bonzini (1): iscsi: do not leak acb->buf when commands are aborted Peter Lieven (1): iscsi: add support for iovectors block/iscsi.c | 53 +++-- 1 file changed, 43 insertions(+), 10 deletions(-) --

Re: [Qemu-devel] [PATCH 3/3] QAPI: Introduce memchar-read QMP command

2013-01-22 Thread Luiz Capitulino
On Tue, 22 Jan 2013 16:12:52 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > hmp-commands.hx | 19 ++ > hmp.c| 17 > hmp.h|1 + > qapi-schema.json | 25 +++ > qemu-char.c | 57 > +

Re: [Qemu-devel] [PATCH 2/3] QAPI: Introduce memchar-write QMP command

2013-01-22 Thread Luiz Capitulino
On Tue, 22 Jan 2013 16:12:51 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > hmp-commands.hx | 16 > hmp.c| 13 + > hmp.h|1 + > qapi-schema.json | 41 + > qemu-char.c | 48 +++

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Add new char backend CirMemCharDriver

2013-01-22 Thread Luiz Capitulino
On Tue, 22 Jan 2013 16:12:50 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > qemu-char.c | 120 > +++ > qemu-options.hx | 10 + > 2 files changed, 130 insertions(+), 0 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c >

[Qemu-devel] [QEMU PATCH v5 2/3] virtio-net: introduce a new macaddr control

2013-01-22 Thread Amos Kong
In virtio-net guest driver, currently we write MAC address to pci config space byte by byte, this means that we have an intermediate step where mac is wrong. This patch introduced a new control command to set MAC address, it's atomic. VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature bit for compatibili

Re: [Qemu-devel] [QEMU]Add new entries for qemu/configure questions

2013-01-22 Thread harryxiyou
On Tue, Jan 22, 2013 at 4:43 PM, harryxiyou wrote: > Hi all, > > We add new entries for qemu/configure(QEMU v1.3.0), which > can locate our libraries and header files to compile our driver > for QEMU. The new entries in qemu/configure are like following. > > [...] > 2828 ##

[Qemu-devel] [QEMU PATCH v5 1/3] virtio-net: remove layout assumptions for ctrl vq

2013-01-22 Thread Amos Kong
From: Michael S. Tsirkin Virtio-net code makes assumption about virtqueue descriptor layout (e.g. sg[0] is the header, sg[1] is the data buffer). This patch makes code not rely on the layout of descriptors. Signed-off-by: Michael S. Tsirkin Signed-off-by: Amos Kong --- hw/virtio-net.c | 129

[Qemu-devel] [PATCH] target-or32: fix masking in openrisc_pic_cpu_handler()

2013-01-22 Thread Xi Wang
A correct mask should be `x & (1 << i)', rather than `x && (1 << i)'. Also, in C99 signed shift (1 << 31) is undefined behavior, since the result exceeds INT_MAX; use 1U instead. Signed-off-by: Xi Wang --- hw/openrisc_pic.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

Re: [Qemu-devel] [Qemu PATCH v2] add a boot option to do strict boot

2013-01-22 Thread Amos Kong
On Tue, Jan 22, 2013 at 10:23:32AM -0500, Amos Kong wrote: > - Original Message - > > On 01/09/2013 01:39 AM, Amos Kong wrote: > > > Current seabios will try to boot from selected devices first, > > > if they are all failed, seabios will also try to boot from > > > un-selected devices. > >

Re: [Qemu-devel] [PATCH for-1.4 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-22 Thread Eduardo Habkost
On Mon, Jan 21, 2013 at 07:35:22AM -0700, Eric Blake wrote: > On 01/21/2013 06:14 AM, Andreas Färber wrote: > >> glibc is already responsible from converting the 'unsigned long > >> int' of the user declaration back into the 'unsigned int' that the > >> kernel expects for the second argument. The

Re: [Qemu-devel] [PATCH v2 0/3] sheepdog: unix domain socket support

2013-01-22 Thread MORITA Kazutaka
At Tue, 22 Jan 2013 10:38:51 +0100, Stefan Hajnoczi wrote: > > On Mon, Jan 21, 2013 at 09:23:27AM +0900, MORITA Kazutaka wrote: > > This series adds support for a unix domain socket for a connection > > between qemu and local sheepdog server. The first two patches are > > cleanups for the third p

Re: [Qemu-devel] [PATCH v2 03/11] hw/9pfs: Fix unchecked strdup() by converting to g_strdup()

2013-01-22 Thread Markus Armbruster
KONRAD Frédéric writes: > On 22/01/2013 11:23, Markus Armbruster wrote: >> Markus Armbruster writes: >> >>> Stefan Hajnoczi writes: >>> On Wed, Jan 16, 2013 at 06:32:12PM +0100, Markus Armbruster wrote: > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c > index

Re: [Qemu-devel] [PATCH v2] checkpatch: add a little script to run checkpatch against a git refspec

2013-01-22 Thread Eric Blake
On 01/21/2013 02:56 PM, Anthony Liguori wrote: >>> +ret=0 >>> +git log --format="%H %s" "$@" | while read LINE; do >>> +commit="`echo $LINE | cut -f1 -d' '`" >>> +subject="`echo $LINE | cut -f2- -d' '`" >>> +echo "Subject: $subject" >> >> This won't work if $subject contains backslash.

Re: [Qemu-devel] [Qemu PATCH v2] add a boot option to do strict boot

2013-01-22 Thread Amos Kong
- Original Message - > On 01/09/2013 01:39 AM, Amos Kong wrote: > > Current seabios will try to boot from selected devices first, > > if they are all failed, seabios will also try to boot from > > un-selected devices. > > > > We need to make it configurable. I already posted a seabios > >

Re: [Qemu-devel] [PATCH 0/2] Follow-up for MALLOC_CHECK_=xx failure of test-hbitmap

2013-01-22 Thread Eric Blake
On 01/22/2013 07:01 AM, Paolo Bonzini wrote: > Here is a follow-up for the failure that Kevin reported. > > Paolo Bonzini (2): > mirror: do nothing on zero-sized disk > hbitmap: add assertion on hbitmap_iter_init > > block/mirror.c | 2 +- > include/qemu/hbitmap.h | 3 ++- > tests/

Re: [Qemu-devel] [PATCH v4 0/3] AHCI migration

2013-01-22 Thread Kevin Wolf
Am 18.01.2013 11:28, schrieb Stefan Hajnoczi: > On Thu, Jan 17, 2013 at 11:01:52AM +0100, Kevin Wolf wrote: >> Let's get Jason's patches merged while they still apply. I addressed the >> review >> comments (mostly my own) that came up during the v3 review, otherwise this is >> unchanged. >> >> Ple

Re: [Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2013-01-22 Thread Jan Kiszka
On 2013-01-22 15:04, Fabien Chouteau wrote: > Hello Qemu folks, > > I'm sorry to be (very) late, but I do not agree with this patch. > > Your modification just makes the "kill" command behave like "detach", so > why not use "detach" instead? gdb automatically issues kill when you quite. This is

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3 00/11] Trivial memory allocation fixes & cleanups

2013-01-22 Thread Stefan Hajnoczi
On Tue, Jan 22, 2013 at 11:07:55AM +0100, Markus Armbruster wrote: > v3: const tweak suggested by stefanha in PATCH 08/11, rest identical > except 03/11's commit message mentions leak (thanks stefanha!) > > v2: Windows compile fix in PATCH 08/11 (thanks eblake!), rest identical > > Markus Arm

Re: [Qemu-devel] trace: weird issues with makefile dependencies

2013-01-22 Thread Stefan Hajnoczi
On Tue, Jan 22, 2013 at 03:27:26PM +0100, Paolo Bonzini wrote: > Il 22/01/2013 11:00, Stefan Hajnoczi ha scritto: > >> > I also just spent a long time trying to figure out why > >> > my MacOS system wouldn't build after a git pull; turns > >> > out that: > >> > (1) we used to have a generated trace

Re: [Qemu-devel] [PATCH] Add option to mlock guest and qemu memory

2013-01-22 Thread Jan Kiszka
On 2013-01-22 15:45, Satoru Moriya wrote: > On 01/21/2013 04:43 PM, Marcelo Tosatti wrote: >> On Fri, Sep 28, 2012 at 10:05:09AM +0200, Jan Kiszka wrote: >>> On 2012-09-28 01:21, Satoru Moriya wrote: This is a first time for me to post a patch to qemu-devel. If there is something missing/

Re: [Qemu-devel] KVM call agenda for 2013-01-22

2013-01-22 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. As there are no topics, no call Today. See you next week. Later, Juan.

Re: [Qemu-devel] [QEMU PATCH v4 1/3] virtio-net: remove layout assumptions for ctrl vq

2013-01-22 Thread Stefan Hajnoczi
On Tue, Jan 22, 2013 at 10:38:14PM +0800, Amos Kong wrote: > On Mon, Jan 21, 2013 at 05:03:30PM +0100, Stefan Hajnoczi wrote: > > On Sat, Jan 19, 2013 at 09:54:26AM +0800, ak...@redhat.com wrote: > > > From: "Michael S. Tsirkin" > > > > > > Virtio-net code makes assumption about virtqueue descrip

Re: [Qemu-devel] [PATCH] Add option to mlock guest and qemu memory

2013-01-22 Thread Satoru Moriya
On 01/21/2013 04:43 PM, Marcelo Tosatti wrote: > On Fri, Sep 28, 2012 at 10:05:09AM +0200, Jan Kiszka wrote: >> On 2012-09-28 01:21, Satoru Moriya wrote: >>> This is a first time for me to post a patch to qemu-devel. >>> If there is something missing/wrong, please let me know. >>> >>> We have some

  1   2   >