[Qemu-devel] [PATCH 17/18] hw: add QEMU model for Faraday a369 keypad controller

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftkbc010.c | 214 + 1 file changed, 214 insertions(+) create mode 100644 hw/ftkbc010.c diff --git a/hw/ftkbc010.c b/hw/ftkbc010.c new file mode 100644 index 000..0727b5a --- /dev/null +++ b/hw/ftkbc01

Re: [Qemu-devel] [PATCH for-1.4 00/12] target-i386: Fix APIC-ID-based topology (v4)

2013-01-17 Thread li guang
在 2013-01-17四的 18:59 -0200,Eduardo Habkost写道: > I am hoping to get this bug fixed in 1.4. I didn't get much feedback on the > RFC > I sent last week, though. > > Igor argued that APIC ID should be set by the board and not by the CPU itself, per Intel's SPEC, seems APIC ID really based on design

[Qemu-devel] [PATCH 18/18] hw: add QEMU model for embedded ROM of SoC chips

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/rom.c | 126 ++ 1 file changed, 126 insertions(+) create mode 100644 hw/rom.c diff --git a/hw/rom.c b/hw/rom.c new file mode 100644 index 000..260b78b --- /dev/null +++ b/hw/rom.c @@ -0,0 +1,126 @

[Qemu-devel] [PATCH 12/18] hw: add QEMU model for Faraday high-speed SPI-NOR flash controller

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftspi020.c | 338 + hw/ftspi020.h | 71 2 files changed, 409 insertions(+) create mode 100644 hw/ftspi020.c create mode 100644 hw/ftspi020.h diff --git a/hw/ftspi020.c b/hw/ftspi020.c new

[Qemu-devel] [PATCH 13/18] hw: add QEMU model for Faraday multi-function SSP controller: SPI and I2S

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftssp010.c | 526 + hw/ftssp010.h | 103 +++ 2 files changed, 629 insertions(+) create mode 100644 hw/ftssp010.c create mode 100644 hw/ftssp010.h diff --git a/hw/ftssp010.c b/hw/ftssp010.c new f

[Qemu-devel] [PATCH 09/18] hw: add QEMU model for Faraday NAND flash controller

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftnandc021.c | 528 +++ hw/ftnandc021.h | 58 ++ 2 files changed, 586 insertions(+) create mode 100644 hw/ftnandc021.c create mode 100644 hw/ftnandc021.h diff --git a/hw/ftnandc021.c b/hw/ftnandc021.c

[Qemu-devel] [PATCH 11/18] hw: add QEMU model for Faraday touchscreen controller

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/fttsc010.c | 239 + hw/fttsc010.h | 35 + 2 files changed, 274 insertions(+) create mode 100644 hw/fttsc010.c create mode 100644 hw/fttsc010.h diff --git a/hw/fttsc010.c b/hw/fttsc010.c new fil

[Qemu-devel] [PATCH 10/18] hw: add QEMU model for Faraday MMC/SD host controller

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftsdc010.c | 360 + hw/ftsdc010.h | 103 + 2 files changed, 463 insertions(+) create mode 100644 hw/ftsdc010.c create mode 100644 hw/ftsdc010.h diff --git a/hw/ftsdc010.c b/hw/ftsdc010.c

[Qemu-devel] [PATCH 16/18] hw: add QEMU model for Faraday RTC timer

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftrtc011.c | 308 + 1 file changed, 308 insertions(+) create mode 100644 hw/ftrtc011.c diff --git a/hw/ftrtc011.c b/hw/ftrtc011.c new file mode 100644 index 000..466cbb6 --- /dev/null +++ b/hw/ftrtc01

[Qemu-devel] [PATCH 15/18] hw: add QEMU model for Faraday watchdog timers

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftwdt010.c | 224 + 1 file changed, 224 insertions(+) create mode 100644 hw/ftwdt010.c diff --git a/hw/ftwdt010.c b/hw/ftwdt010.c new file mode 100644 index 000..47f7f94 --- /dev/null +++ b/hw/ftwdt01

[Qemu-devel] [PATCH 14/18] hw: add QEMU model for Faraday system timers

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftpwmtmr010.c | 226 hw/fttmr010.c| 442 ++ 2 files changed, 668 insertions(+) create mode 100644 hw/ftpwmtmr010.c create mode 100644 hw/fttmr010.c diff --git a/hw/ftpwmtmr0

[Qemu-devel] [PATCH 08/18] hw: add QEMU model for Faraday LCD controller

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftlcdc200.c | 494 +++ hw/ftlcdc200.h | 101 ++ hw/ftlcdc200_template.h | 395 + 3 files changed, 990 insertions(+) create mode 100644 hw/ftlcdc200.c cr

[Qemu-devel] [PATCH 06/18] hw: add QEMU model for Faraday I2C master controller

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/fti2c010.c | 209 + hw/fti2c010.h | 77 + 2 files changed, 286 insertions(+) create mode 100644 hw/fti2c010.c create mode 100644 hw/fti2c010.h diff --git a/hw/fti2c010.c b/hw/fti2c0

[Qemu-devel] [PATCH 07/18] hw: add QEMU model for Faraday interrupt controller

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftintc020.c | 342 1 file changed, 342 insertions(+) create mode 100644 hw/ftintc020.c diff --git a/hw/ftintc020.c b/hw/ftintc020.c new file mode 100644 index 000..2f78390 --- /dev/null +++ b/hw/ftin

[Qemu-devel] [PATCH 03/18] hw: add QEMU model for Faraday AHB DMA

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftdmac020.c | 625 hw/ftdmac020.h | 117 +++ 2 files changed, 742 insertions(+) create mode 100644 hw/ftdmac020.c create mode 100644 hw/ftdmac020.h diff --git a/hw/ftdmac020.c b/hw/ftdmac020.c

[Qemu-devel] [PATCH 05/18] hw: add QEMU model for Faraday 10/100Mbps Ethernet MAC

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftmac110.c | 567 + hw/ftmac110.h | 130 + 2 files changed, 697 insertions(+) create mode 100644 hw/ftmac110.c create mode 100644 hw/ftmac110.h diff --git a/hw/ftmac110.c b/hw/ftmac110.c new

[Qemu-devel] [PATCH 02/18] hw: add QEMU model for Faraday APB DMA

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftapbbrg020.c | 485 ++ hw/ftapbbrg020.h | 43 + 2 files changed, 528 insertions(+) create mode 100644 hw/ftapbbrg020.c create mode 100644 hw/ftapbbrg020.h diff --git a/hw/ftapbbrg020.c b/hw/ftapbbrg02

[Qemu-devel] [PATCH 04/18] hw: add QEMU model for Faraday 1Gbps Ethernet MAC

2013-01-17 Thread Dante
Signed-off-by: Kuo-Jung Su --- hw/ftgmac100.c | 621 hw/ftgmac100.h | 191 + 2 files changed, 812 insertions(+) create mode 100644 hw/ftgmac100.c create mode 100644 hw/ftgmac100.h diff --git a/hw/ftgmac100.c b/hw/ftgmac

[Qemu-devel] [PATCH 01/18] hw: add Faraday a369 SoC platform support

2013-01-17 Thread Dante
Faraday A369, is an ARM SoC prototype chip, highly integrated with common SoC features, including a 533MHz ARM v5TE master CPU, a 133MHz ARM v5TE slave CPU, a 32-bit DDR-2 533MHz memory controller, 2 USB 2.0 host/OTG ports, SATA host/device port, 10/100/1000 Ethernet port, MPEG4 codec, H.264 decode

[Qemu-devel] [PATCH] target-arm: add Faraday ARMv5TE processors support

2013-01-17 Thread Dante
Faraday processors are a series of ARMv4/ARMv5TE clone. * ARMv4 series (FA526, FA626). All of them are now out-of-date, so I have no plan for them. * ARMv5TE series (FA606TE, FA626TE, FA616TE, FA726TE) All the single core RISC listed above are included in this patch. And there are two

[Qemu-devel] [PATCH] hw/wm8731: add WM8731 codec support

2013-01-17 Thread Dante
Wolfson WM8731 is a simple audio codec for embedded systems. It contains 2 input and 1 output ports: ** Input ** 1. Linue-In 2. Microphone ** Output ** 1. Headphone out BTW it's based on hw/wm8750.c with 16bit I2S support by default. Signed-off-by: Kuo-Jung Su --- default-configs/

[Qemu-devel] [PATCH 2/2] hw/nand.c: bug fix to erase operation

2013-01-17 Thread Dante
The s->addr is supposed to be reset along with the s->addrlen, or it might be contains the previous address at last address cycle, and causes problem to nand erase operation. Signed-off-by: Kuo-Jung Su --- hw/nand.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/nand.c b/hw/nand.c ind

[Qemu-devel] [PATCH 1/2] hw/nand.c: bug fix to BUSY/READY status bit

2013-01-17 Thread Dante
The status register coding for BUSY/READY(BIT6) is actually [Busy:0, Ready:1]. BTW, this patch not only apply the bug fix to status bit, but also update the Busy/Ready status upon nand flash read/write/erase. Signed-off-by: Kuo-Jung Su --- hw/nand.c | 16 +++- 1 file changed, 15 in

[Qemu-devel] [PATCH] hw/m25p80.c: add WRSR(0x01) support

2013-01-17 Thread Dante
Atmel, SST and Intel/Numonyx serial flash tend to power up with the software protection bits set. And thus the new m25p80.c in linux kernel would always tries to use WREN(0x06) + WRSR(0x01) to turn-off the protection. The WEL(0x02) of status register is supposed to be cleared after WRSR(0x01). Ther

[Qemu-devel] qemu-kvm command-line compat

2013-01-17 Thread Michael Tokarev
Hello. I was thinking about switching users from (old) qemu-kvm to (new) qemu, and am trying to understand the difference and how to compensate for them. So far we had several discussions about this topic, first of all touching live migration ([1]), which is about different side, and some mentio

Re: [Qemu-devel] [QEMU PATCH v2] virtio-net: introduce a new macaddr control

2013-01-17 Thread Amos Kong
On Thu, Jan 17, 2013 at 02:13:08PM +0200, Michael S. Tsirkin wrote: > On Thu, Jan 17, 2013 at 11:49:20AM +1030, Rusty Russell wrote: > > ak...@redhat.com writes: > > > @@ -349,6 +351,14 @@ static int virtio_net_handle_mac(VirtIONet *n, > > > uint8_t cmd, > > > { > > > struct virtio_net_ctrl_

Re: [Qemu-devel] [PATCH V4 04/13] block: add snapshot info query function bdrv_query_snapshot_infolist()

2013-01-17 Thread Wenchao Xia
于 2013-1-18 5:53, Eric Blake 写道: On 01/17/2013 12:40 AM, Wenchao Xia wrote: This patch add function bdrv_query_snapshot_infolist(), which will return snapshot info of an image in qmp object format. The implementation code are mostly copied from qemu-img.c with modification to fit more for qmp

[Qemu-devel] [PATCH 3/3] PPC: KVM: Add support for EPR with KVM

2013-01-17 Thread Alexander Graf
This patch links KVM EPR support to the existing TCG support we have now. Signed-off-by: Alexander Graf --- hw/ppc.c |6 ++ target-ppc/kvm.c | 21 + target-ppc/kvm_ppc.h |5 + 3 files changed, 32 insertions(+), 0 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 1/3] Update Linux kernel headers

2013-01-17 Thread Alexander Graf
Based on kvm.git a843fac (next) plus dfdebc24 (master). Signed-off-by: Alexander Graf --- linux-headers/asm-powerpc/kvm.h |6 +- linux-headers/linux/kvm.h | 27 +++ 2 files changed, 32 insertions(+), 1 deletions(-) diff --git a/linux-headers/asm-powerpc/k

[Qemu-devel] [PATCH 2/3] openpic: export e500 epr enable into a ppc.c function

2013-01-17 Thread Alexander Graf
Enabling and disabling the EPR capability (mpic_proxy) is a system wide operation. As such, it belongs into the ppc.c file, since that's where PPC specific machine wide logic happens. Signed-off-by: Alexander Graf --- hw/openpic.c | 11 +-- hw/ppc.c | 11 +++ hw/ppc.h

[Qemu-devel] [PATCH 0/3] PPC: EPR support when using KVM

2013-01-17 Thread Alexander Graf
This patch set implements the External PRoxy facility capability when running an e500 target with KVM. Alexander Graf (3): Update Linux kernel headers openpic: export e500 epr enable into a ppc.c function PPC: KVM: Add support for EPR with KVM hw/openpic.c| 11 +--

Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format

2013-01-17 Thread Eric Blake
On 01/17/2013 03:25 PM, Stefan Weil wrote: >>> * Use error code EMEDIUMTYPE instead of inventing a new one. >>> >> Alas, EMEDIUMTYPE is non-standard, and doesn't exist outside of Linux. >> If you are providing fallbacks for half the platforms because you don't >> want to use a standard errno

[Qemu-devel] [RFC V6 01/11] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/Makefile.objs |1 + block/quorum.c | 45 + 2 files changed, 46 insertions(+) create mode 100644 block/quorum.c diff --git a/block/Makefile.objs b/block/Makefile.objs index c067f38..4143e34 100644 --- a/

[Qemu-devel] [RFC V6 02/11] quorum: Create BDRVQuorumState and BlkDriver and do init.

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index ce094a1..1f12438 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,13 @@ #include "block/block_int.h" +typedef struct

Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions

2013-01-17 Thread Eduardo Habkost
On Thu, Jan 17, 2013 at 05:06:50PM -0200, Eduardo Habkost wrote: > There are lots of duplicate parsing code using strto*() in QEMU, and > most of that code is broken in one way or another. Even the visitors > code have duplicate integer parsing code[1]. This introduces functions > to help parsing u

Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format

2013-01-17 Thread Stefan Weil
Am 17.01.2013 22:28, schrieb Eric Blake: On 01/17/2013 01:45 PM, Stefan Weil wrote: These patches improve the error report if the file format was specified explicitly (example: -drive file=myfile,format=qcow2) and the given format does not match the real format. They fix those bugs: https:

Re: [Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism.

2013-01-17 Thread Eric Blake
On 01/17/2013 08:51 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block/quorum.c | 278 > +++- > 1 file changed, 277 insertions(+), 1 deletion(-) > > diff --git a/block/quorum.c b/block/quorum.c > index 98052eb..2b4 100644

Re: [Qemu-devel] [RFC V6 03/11] quorum: Add quorum_open() and quorum_close().

2013-01-17 Thread Eric Blake
On 01/17/2013 08:51 AM, Benoît Canet wrote: > Valid quorum resources look like > quorum:threshold/total:path/to/image_1: ... :path/to/image_total > > ':' is used as a separator > '\' is the escaping character for filename containing ':' > '\' escape itself > ',' must be escaped with ',' > > On th

Re: [Qemu-devel] [PATCH V4 04/13] block: add snapshot info query function bdrv_query_snapshot_infolist()

2013-01-17 Thread Eric Blake
On 01/17/2013 12:40 AM, Wenchao Xia wrote: > This patch add function bdrv_query_snapshot_infolist(), which will > return snapshot info of an image in qmp object format. The implementation > code are mostly copied from qemu-img.c with modification to fit more > for qmp based block layer API. > T

[Qemu-devel] [PATCH for-1.4 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-17 Thread Eduardo Habkost
This is a cleanup that tries to solve two small issues: - We don't need a separate kvm_pv_eoi_features variable just to keep a constant calculated at compile-time, and this style would require adding a separate variable (that's declared twice because of the CONFIG_KVM ifdef) for each fea

[Qemu-devel] [PATCH for-1.4 05/12] target-i386: kvm: Set vcpu_id to APIC ID instead of CPU index

2013-01-17 Thread Eduardo Habkost
The CPU ID in KVM is supposed to be the APIC ID, so change the KVM_CREATE_VCPU call to match it. The current behavior didn't break anything yet because today the APIC ID is assumed to be equal to the CPU index, but this won't be true in the future. Signed-off-by: Eduardo Habkost --- Cc: k...@vger

Re: [Qemu-devel] [PATCH 3/4] rules/mak: make clean should blow away timestamp files

2013-01-17 Thread Michael S. Tsirkin
On Thu, Jan 17, 2013 at 11:28:46AM +0100, Stefan Hajnoczi wrote: > On Tue, Jan 15, 2013 at 06:57:34PM +0200, Michael S. Tsirkin wrote: > > Using a global pattern makes it easier to clean out > > old generated files. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > rules.mak | 5 + > > 1

[Qemu-devel] [PATCH for-1.4 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-17 Thread Eduardo Habkost
This will allow each architecture to define how the VCPU ID is set on the KVM_CREATE_VCPU ioctl call. Signed-off-by: Eduardo Habkost --- Cc: k...@vger.kernel.org Cc: Michael S. Tsirkin Cc: Gleb Natapov Cc: Marcelo Tosatti Changes v2: - Get CPUState as argument instead of CPUArchState --- in

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-17 Thread Nicholas A. Bellinger
Hi MST & Co, On Thu, 2013-01-17 at 18:43 +0200, Michael S. Tsirkin wrote: > On Fri, Sep 07, 2012 at 06:48:14AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hello Anthony & Co, > > > > This is the fourth installment to add host virtualized target support for > > the m

[Qemu-devel] [PATCH for-1.4 09/12] pc: Set fw_cfg data based on APIC ID calculation

2013-01-17 Thread Eduardo Habkost
This changes FW_CFG_MAX_CPUS and FW_CFG_NUMA to use apic_id_for_cpu(), so the NUMA table can be based on the APIC IDs, instead of CPU index (SeaBIOS knows nothing about CPU indexes, just APIC IDs). Signed-off-by: Eduardo Habkost --- Changes v2: - Get PC object as argument - Add more detailed co

[Qemu-devel] [PATCH for-1.4 12/12] pc: Generate APIC IDs according to CPU topology

2013-01-17 Thread Eduardo Habkost
This keeps compatibility on machine-types pc-1.2 and older, and prints a warning in case the requested configuration won't get the correct topology. I couldn't think of a better way to warn about broken topology when in compat mode other than using error_report(). The warning message will be proba

Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format

2013-01-17 Thread Eric Blake
On 01/17/2013 01:45 PM, Stefan Weil wrote: > These patches improve the error report if the file format was > specified explicitly (example: -drive file=myfile,format=qcow2) > and the given format does not match the real format. > > They fix those bugs: > > https://bugzilla.redhat.com/show_bug.cgi

[Qemu-devel] [PATCH for-1.4 10/12] tests: Support target-specific unit tests

2013-01-17 Thread Eduardo Habkost
To make unit tests that depend on target-specific files, use check-unit--y and test-obj--y. Signed-off-by: Eduardo Habkost --- tests/Makefile | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index d86e95a..41172d6 100644 --- a/tes

[Qemu-devel] [PATCH for-1.4 06/12] fw_cfg: Remove FW_CFG_MAX_CPUS from fw_cfg_init()

2013-01-17 Thread Eduardo Habkost
PC will not use max_cpus for that field, so move it outside the common code so it can use a different value on PC. Signed-off-by: Eduardo Habkost --- hw/fw_cfg.c | 1 - hw/pc.c | 2 +- hw/ppc_newworld.c | 1 + hw/ppc_oldworld.c | 1 + hw/sun4m.c| 3 +++ hw/sun4u.c

[Qemu-devel] [PATCH v2 2/5] block: Use error code EMEDIUMTYPE for wrong format in some block drivers

2013-01-17 Thread Stefan Weil
This improves error reports for bochs, cow, qcow, qcow2, qed and vmdk when a file with the wrong format is selected. Signed-off-by: Stefan Weil --- block/bochs.c |2 +- block/cow.c |2 +- block/qcow.c |2 +- block/qcow2.c |2 +- block/qed.c |2 +- block/vmdk.c |4 ++

Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW

2013-01-17 Thread Blue Swirl
On Thu, Jan 17, 2013 at 8:54 PM, Stefan Weil wrote: > Am 17.01.2013 21:45, schrieb Blue Swirl: > >> On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weil wrote: >>> >>> MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h. >>> We must also fix the include statements in util/envlist.c to in

[Qemu-devel] [PATCH for-1.4 08/12] cpus.h: Make constant smp_cores/smp_threads available on *-user

2013-01-17 Thread Eduardo Habkost
The code that calculates the APIC ID will use smp_cores/smp_threads, so just define them as 1 on *-user to avoid #ifdefs in the code. Signed-off-by: Eduardo Habkost --- include/sysemu/cpus.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/sysemu/cpus.h b/include/sysemu/cpus.h

[Qemu-devel] [PATCH for-1.4 03/12] pc: Reverse pc_init_pci() compatibility logic

2013-01-17 Thread Eduardo Habkost
Currently, the pc-1.4 machine init function enables PV EOI and then calls the pc-1.2 machine init function. The problem with this approach is that now we can't enable any additional compatibility code inside the pc-1.2 init function because it would end up enabling the compatibility behavior on pc-

[Qemu-devel] [PATCH for-1.4 07/12] target-i386/cpu: Introduce apic_id_for_cpu() function

2013-01-17 Thread Eduardo Habkost
This function will be used by both the CPU initialization code and the fw_cfg table initialization code. Later this function will be updated to generate APIC IDs according to the CPU topology. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 17 - target-i386/cpu.h | 2 ++

Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions

2013-01-17 Thread Blue Swirl
On Thu, Jan 17, 2013 at 7:06 PM, Eduardo Habkost wrote: > There are lots of duplicate parsing code using strto*() in QEMU, and > most of that code is broken in one way or another. Even the visitors > code have duplicate integer parsing code[1]. This introduces functions > to help parsing unsigned

[Qemu-devel] [PATCH v2 1/5] block: Add special error code for wrong format

2013-01-17 Thread Stefan Weil
The block drivers need a special error code for "wrong format". >From the available error codes EMEDIUMTYPE fits best. It is not available on all platforms, so a definition in qemu-common.h and a specific error report are needed. Signed-off-by: Stefan Weil --- blockdev.c|9 ++

[Qemu-devel] [PATCH for-1.4 11/12] target-i386: Topology & APIC ID utility functions

2013-01-17 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: - Support 32-bit APIC IDs (in case x2APIC is going to be used) - Coding style changes - Use TARGET_I386_TOPOLOGY_H instead of __QEMU_X86_TOPOLOGY_H__ - Rename topo_make_apic_id() to topo_apicid_for_cpu() - Rename __make_apicid() to topo_mak

[Qemu-devel] [PATCH for-1.4 00/12] target-i386: Fix APIC-ID-based topology (v4)

2013-01-17 Thread Eduardo Habkost
I am hoping to get this bug fixed in 1.4. I didn't get much feedback on the RFC I sent last week, though. Igor argued that APIC ID should be set by the board and not by the CPU itself, but I am not doing that because: - I want to keep the bug fix simple and isolated as we are past soft freeze -

[Qemu-devel] [PATCH for-1.4 01/12] kvm: Add fake KVM_FEATURE_CLOCKSOURCE_STABLE_BIT for builds withou KVM

2013-01-17 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- Cc: k...@vger.kernel.org Cc: Michael S. Tsirkin Cc: Gleb Natapov Cc: Marcelo Tosatti --- include/sysemu/kvm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 6bdd513..22acf91 100644 --- a/include/sysemu/kv

Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW

2013-01-17 Thread Stefan Weil
Am 17.01.2013 21:45, schrieb Blue Swirl: On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weil wrote: MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h. We must also fix the include statements in util/envlist.c to include that file. We currently don't need an implementation of strtok

Re: [Qemu-devel] [PATCH 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename()

2013-01-17 Thread Blue Swirl
On Wed, Jan 16, 2013 at 4:06 PM, Markus Armbruster wrote: > Eric Blake writes: > >> On 01/16/2013 07:36 AM, Markus Armbruster wrote: >>> Signed-off-by: Markus Armbruster >>> --- >>> qemu-log.c | 13 + >>> 1 file changed, 9 insertions(+), 4 deletions(-) >>> >>> diff --git a/qemu-log.

[Qemu-devel] [PATCH v2 4/5] block/vdi: Improved return values from vdi_open

2013-01-17 Thread Stefan Weil
vdi_open returned -1 in case of any error, but it should return an error code (negative value of errno or -EMEDIUMTYPE). Signed-off-by: Stefan Weil --- block/vdi.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 0e1ed61..8b

[Qemu-devel] [PATCH v2 5/5] block/vdi: Check for bad signature

2013-01-17 Thread Stefan Weil
vdi_open did not check for a bad signature. This check was only in vdi_probe. Signed-off-by: Stefan Weil --- block/vdi.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block/vdi.c b/block/vdi.c index 8b768bf..257a592 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -392

[Qemu-devel] [PATCH v2 3/5] block/vdi: Improve debug output for signature

2013-01-17 Thread Stefan Weil
The signature is a 32 bit value and needs up to 8 hex digits for printing. Signed-off-by: Stefan Weil --- block/vdi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vdi.c b/block/vdi.c index 021abaa..0e1ed61 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -246,7 +246,

Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW

2013-01-17 Thread Blue Swirl
On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weil wrote: > MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h. > We must also fix the include statements in util/envlist.c to include > that file. > > We currently don't need an implementation of strtok_r because the > code is compiled b

[Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format

2013-01-17 Thread Stefan Weil
These patches improve the error report if the file format was specified explicitly (example: -drive file=myfile,format=qcow2) and the given format does not match the real format. They fix those bugs: https://bugzilla.redhat.com/show_bug.cgi?id=556482 https://bugs.launchpad.net/qemu/+bug/1090600

Re: [Qemu-devel] [PATCH] tests: adjust gcov variables for directory movement

2013-01-17 Thread Blue Swirl
On Tue, Jan 15, 2013 at 8:49 AM, Paolo Bonzini wrote: > I had missed the introduction of the gcov-files-* variables. > > Cc: Blue Swirl > Signed-off-by: Paolo Bonzini > --- > Blue, can you look at introducing a common variable for the coroutine > backend? Like > > corout

Re: [Qemu-devel] Go along with glib's basic type typedef silliness? (was: [PATCH 01/10] qom: Make object_resolve_path_component() path argument const)

2013-01-17 Thread Blue Swirl
On Mon, Jan 14, 2013 at 7:01 PM, Markus Armbruster wrote: > [Thread hijack, dropping cc: qemu-trivial, qemu-ppc] > > Andreas Färber writes: > >> Am 14.01.2013 13:19, schrieb Markus Armbruster: >>> Andreas Färber writes: > [...] diff --git a/qom/object.c b/qom/object.c index 351b88c..03

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

2013-01-17 Thread Blue Swirl
On Mon, Jan 14, 2013 at 9:13 AM, Stefan Hajnoczi wrote: > On Sat, Jan 12, 2013 at 12:00:45PM +, Blue Swirl wrote: >> On Fri, Jan 11, 2013 at 7:27 AM, 马磊 wrote: >> > >> > >> > On Fri, Jan 11, 2013 at 2:28 PM, Wanlong Gao >> > wrote: >> >> >> >> On 01/11/2013 11:39 AM, 马磊 wrote: >> >> > >> >>

Re: [Qemu-devel] [[PATCH v2]] Add option to slow qemu down

2013-01-17 Thread Stefan Weil
Hello Wolfgang, please see comment below. Am 17.01.2013 18:10, schrieb Wolfgang Mauerer: For slow targets and fast hosts, the emulation may be faster than the actual hardware, which can be undesirable for various reasons. Add a run-time option to slow down the emulation by sleeping in the CPU e

Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions

2013-01-17 Thread Blue Swirl
On Mon, Jan 14, 2013 at 9:09 AM, Stefan Hajnoczi wrote: > On Sat, Jan 12, 2013 at 10:46:18AM +, Blue Swirl wrote: >> On Thu, Jan 10, 2013 at 12:43 PM, Stefan Hajnoczi wrote: >> > On Wed, Jan 09, 2013 at 08:43:51PM +, Blue Swirl wrote: >> >> On Tue, Jan 8, 2013 at 9:03 AM, Stefan Hajnoczi

[Qemu-devel] [PATCH for-1.4] tcg/target-arm: Add missing parens to assertions

2013-01-17 Thread Peter Maydell
Silence a (legitimate) complaint about missing parentheses: tcg/arm/tcg-target.c: In function ‘tcg_out_qemu_ld’: tcg/arm/tcg-target.c:1148:5: error: suggest parentheses around comparison in operand of ‘&’ [-Werror=parentheses] tcg/arm/tcg-target.c: In function ‘tcg_out_qemu_st’: tcg/arm/tcg-target

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

2013-01-17 Thread Anthony Liguori
Vadim Evard writes: > Signed-off-by: Vadim Evard Please post this as a top-level patch. (no in-reply-to) Regards, Anthony Liguori > --- > configure |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 4ebb60d..6211db9 100755 > --- a/confi

Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions

2013-01-17 Thread Eric Blake
On 01/17/2013 12:06 PM, Eduardo Habkost wrote: > There are lots of duplicate parsing code using strto*() in QEMU, and > most of that code is broken in one way or another. Even the visitors > code have duplicate integer parsing code[1]. This introduces functions > to help parsing unsigned int values

[Qemu-devel] [Bug 1096712] Re: qemu 1.3.0: Windows XP doesn't boot with BSOD STOP 7E in acpi.sys

2013-01-17 Thread Michael Tokarev
*** This bug is a duplicate of bug 1091115 *** https://bugs.launchpad.net/bugs/1091115 ** This bug has been marked a duplicate of bug 1091115 qemu-1.3.0 crashes when installing windows xp -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] ChangeLog for 1.4

2013-01-17 Thread Luiz Capitulino
On Tue, 15 Jan 2013 17:45:10 +0100 Paolo Bonzini wrote: > Hi, I've been somewhat busy with other things during the early 1.3 cycle > so I have no idea what changes went in. > > I created a stub at http://wiki.qemu.org/ChangeLog/1.4, please fill it > in. You're CCed if you sent pull requests dur

[Qemu-devel] [Bug 1091115] Re: windowsXP install in qemu-system-i386 1.3.0 ends with a BSOD 0x7E in acpi.sys

2013-01-17 Thread Michael Tokarev
It is most likely the seabios bits missing in 1.3.0, namely this change: http://git.qemu.org/?p=seabios.git;a=commitdiff;h=f64a472a481784231fbf8541825501df411b11d1 You may try this bios file: http://git.qemu.org/?p=qemu.git;a=blob;f=pc- bios/bios.bin;h=3910875311ceaed814f902e9e4e7e29cdf340fc6

Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions

2013-01-17 Thread Laszlo Ersek
On 01/17/13 20:06, Eduardo Habkost wrote: > Changes v4: > - Return -EINVAL in case a minus sign is found > - Make endptr point to beginning of string in case -EINVAL >is returned (like the strtoull() behavior) Reviewed-by: Laszlo Ersek

[Qemu-devel] [Bug 1091115] Re: windowsXP install in qemu-system-i386 1.3.0 ends with a BSOD 0x7E in acpi.sys

2013-01-17 Thread Michael Tokarev
** Summary changed: - qemu-1.3.0 crashes when installing windows xp + windowsXP install in qemu-system-i386 1.3.0 ends with a BSOD 0x7E in acpi.sys -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/10911

[Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions

2013-01-17 Thread Eduardo Habkost
There are lots of duplicate parsing code using strto*() in QEMU, and most of that code is broken in one way or another. Even the visitors code have duplicate integer parsing code[1]. This introduces functions to help parsing unsigned int values: parse_uint() and parse_uint_full(). Parsing function

Re: [Qemu-devel] [PATCH for-1.4] qom: Extend documentation on QOM method concepts

2013-01-17 Thread Anthony Liguori
Eduardo Habkost writes: > On Thu, Jan 17, 2013 at 08:31:50AM +0100, Andreas Färber wrote: >> + * Alternatively, object_class_by_name() can be used to obtain the class and >> + * its non-overridden methods for a specific type. This would correspond to >> + * |[ MyClass::method(...) ]| in C++. > >

Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions

2013-01-17 Thread Eduardo Habkost
On Thu, Jan 17, 2013 at 07:29:17PM +0100, Laszlo Ersek wrote: > On 01/16/13 19:28, Eduardo Habkost wrote: > > > +static void test_parse_uint_negative(void) > > +{ > > +unsigned long long i = 999; > > +char f = 'X'; > > +char *endptr = &f; > > +const char *str = " \t -321"; > > +

Re: [Qemu-devel] [RFC 00/12] target-i386: Fix APIC-ID-based topology (v4)

2013-01-17 Thread Eduardo Habkost
On Wed, Jan 09, 2013 at 04:53:40PM -0200, Eduardo Habkost wrote: > This series uses a much simpler approach than the previous versions: > > - The APIC ID calculation code is now inside cpu.c > - It doesn't require touching the PC CPU creation code at all > - It simply uses a static variable to

Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions

2013-01-17 Thread Laszlo Ersek
On 01/16/13 19:28, Eduardo Habkost wrote: > +static void test_parse_uint_negative(void) > +{ > +unsigned long long i = 999; > +char f = 'X'; > +char *endptr = &f; > +const char *str = " \t -321"; > +int r; > + > +r = parse_uint(str, &i, &endptr, 0); > + > +g_assert_cmpi

[Qemu-devel] [Bug 1091115] Re: qemu-1.3.0 crashes when installing windows xp

2013-01-17 Thread Sven
Same as Bug 1096712 I reported -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1091115 Title: qemu-1.3.0 crashes when installing windows xp Status in QEMU: New Bug description: These are the co

Re: [Qemu-devel] [PATCH 4/5] target-i386: set custom features/properties without intermediate x86_def_t

2013-01-17 Thread Eduardo Habkost
On Thu, Jan 17, 2013 at 04:16:33PM +0100, Igor Mammedov wrote: > Move custom features parsing after built-in cpu_model defaults are set > and set custom features directly on CPU instance. That allows to make > clear distinction between built-in cpu model defaults that eventually > should go into cl

[Qemu-devel] [[PATCH v2]] Add option to slow qemu down

2013-01-17 Thread Wolfgang Mauerer
For slow targets and fast hosts, the emulation may be faster than the actual hardware, which can be undesirable for various reasons. Add a run-time option to slow down the emulation by sleeping in the CPU emulation. Signed-off-by: Wolfgang Mauerer --- cpus.c| 29 +++

Re: [Qemu-devel] [PATCH] Add option to slow down qemu

2013-01-17 Thread Wolfgang Mauerer
On 11/01/13 20:58, Stefan Weil wrote: > Am 11.01.2013 14:40, schrieb Wolfgang Mauerer: >> > For slow targets and fast hosts, the emulation may be faster >> > than the actual hardware, which can be undesirable for various >> > reasons. Add a run-time option to slow down the emulation >> > by sleepin

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-17 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 05:59:17PM +0200, Michael S. Tsirkin wrote: > On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: > > The viostor virtio-blk driver for Windows does not use the > > VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK > > bit. > > > > The vio

Re: [Qemu-devel] [PATCH 04/12] Update linux headers.

2013-01-17 Thread Alexander Graf
On 17.01.2013, at 17:20, Cornelia Huck wrote: > On Thu, 17 Jan 2013 15:05:46 + > Peter Maydell wrote: > >> On 17 January 2013 14:23, Cornelia Huck wrote: >>> Base is kvm-next as of 2013/01/16. >> >>> --- a/linux-headers/asm-powerpc/kvm_para.h >>> +++ b/linux-headers/asm-powerpc/kvm_para.h

Re: [Qemu-devel] [PATCH 22/43] tcg/arm: fix TLB access in qemu-ld/st ops

2013-01-17 Thread Peter Maydell
On 3 December 2012 22:08, Michael Roth wrote: > +assert(tlb_offset & ~0xf == 0); This doesn't compile if configured with --enable-debug: In file included from /home/petmay01/git/qemu/tcg/tcg.c:174:0: /home/petmay01/git/qemu/tcg/arm/tcg-target.c: In function ‘tcg_out_qemu_ld’: /home/petma

Re: [Qemu-devel] [PATCH for-1.4] qom: Extend documentation on QOM method concepts

2013-01-17 Thread Eduardo Habkost
On Thu, Jan 17, 2013 at 08:31:50AM +0100, Andreas Färber wrote: > Add a documentation section "Methods" and discuss among others how to > handle overriding virtual methods. > > Clarify DeviceClass::realize documentation and refer to the above. > > Signed-off-by: Andreas Färber > --- > hw/qdev-c

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-17 Thread Michael S. Tsirkin
On Fri, Sep 07, 2012 at 06:48:14AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hello Anthony & Co, > > This is the fourth installment to add host virtualized target support for > the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. > > The series i

Re: [Qemu-devel] [PATCH 04/12] Update linux headers.

2013-01-17 Thread Cornelia Huck
On Thu, 17 Jan 2013 15:05:46 + Peter Maydell wrote: > On 17 January 2013 14:23, Cornelia Huck wrote: > > Base is kvm-next as of 2013/01/16. > > > --- a/linux-headers/asm-powerpc/kvm_para.h > > +++ b/linux-headers/asm-powerpc/kvm_para.h > > @@ -78,7 +78,7 @@ struct kvm_vcpu_arch_shared { > >

[Qemu-devel] [RFC V6 11/11] quorum: Add quorum_co_flush().

2013-01-17 Thread Benoît Canet
Makes a vote to select error if any. Signed-off-by: Benoit Canet --- block/quorum.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 4bea906..dba2918 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -652,6 +652,35 @@ s

[Qemu-devel] [PATCH] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-17 Thread Peter Maydell
Remove an unnecessary mutual inclusion loop between qemu-pixman.h and console.h, since the former was only including the latter for 'PixelFormat*', which can be provided by typedefs.h. This requires a minor adjustment to qemu-pixman.c, which was relying on the implicit inclusion of console.h for t

[Qemu-devel] [RFC V6 09/11] quorum: Add quorum_invalidate_cache().

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 261e9b6..bd478ab 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -611,6 +611,16 @@ static int64_t quorum_getlength(BlockDriverState *bs)

Re: [Qemu-devel] [PATCH 2/4] Makefile: clean timestamp generation rule

2013-01-17 Thread Stefan Hajnoczi
On Tue, Jan 15, 2013 at 06:57:37PM +0200, Michael S. Tsirkin wrote: > create timestamp by rule without sideeffects. > > Signed-off-by: Michael S. Tsirkin > --- > trace/Makefile.objs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] kvm_virtio_pci_irqfd_release: Assertion `ret == 0' failed

2013-01-17 Thread Luiz Capitulino
On Thu, 17 Jan 2013 17:50:09 +0200 "Michael S. Tsirkin" wrote: > On Thu, Jan 17, 2013 at 01:28:48PM -0200, Luiz Capitulino wrote: > > Hi Michael, > > > > To trigger this I just: > > Yes you need > virtio-pci: fix irqfd cleanup argument order Oh, ok, so it's already known. I assume the fix is i

[Qemu-devel] [RFC V6 00/11] Quorum block filter.

2013-01-17 Thread Benoît Canet
Hello I am resuming the work on the quorum patchset. This patchset create a block driver implementing a quorum using total qemu disk images. Writes are mirrored on the $total files. For the reading part the $total files are read at the same time and a vote is done to determine if a qiov version is

  1   2   3   >