Re: [Qemu-devel] [PATCH 1/2] rtc-test: skip year-2038 overflow check in case time_t is 32bit only

2013-01-10 Thread Gerd Hoffmann
On 01/10/13 16:03, Andreas Färber wrote: > Am 10.01.2013 15:49, schrieb Gerd Hoffmann: >> Signed-off-by: Gerd Hoffmann > > Where did my Reviewed-by go? :) Anyone happens to have a script to pick up those? thanks, Gerd

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-10 Thread MORITA Kazutaka
At Thu, 10 Jan 2013 13:38:16 +0800, Liu Yuan wrote: > > On 01/09/2013 11:10 PM, Paolo Bonzini wrote: > > Il 09/01/2013 14:04, Liu Yuan ha scritto: > 2 The upper layer software which relies on the 'cache=xxx' to choose > cache mode will fail its assumption against new QEMU. > >>> > >>>

Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command

2013-01-10 Thread Lei Li
On 01/09/2013 09:33 PM, Luiz Capitulino wrote: On Sun, 6 Jan 2013 18:06:59 +0800 Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 12 qga/qapi-schema.json | 17 + 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/qga/commands-p

Re: [Qemu-devel] [RFC PATCH 0/2] make mac programming for virtio net more robust

2013-01-10 Thread Michael S. Tsirkin
On Fri, Jan 11, 2013 at 12:53:07PM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Jan 10, 2013 at 10:45:39PM +0800, ak...@redhat.com wrote: > >> From: Amos Kong > >> > >> Currenly mac is programmed byte by byte. This means that we > >> have an intermediate step where m

Re: [Qemu-devel] [PATCH 03/10] uhci: stop using portio lists

2013-01-10 Thread Gerd Hoffmann
On 01/10/13 18:18, Andreas Färber wrote: > Am 04.01.2013 22:29, schrieb Hervé Poussineau: >> From: Gerd Hoffmann >> >> Signed-off-by: Gerd Hoffmann >> Tested-by: Hervé Poussineau > > This is missing your Sob, but I believe it was merged through Gerd's USB > queue already. Yes, it's in already

Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command

2013-01-10 Thread Lei Li
On 01/08/2013 06:04 AM, Eric Blake wrote: On 01/06/2013 03:06 AM, Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 12 qga/qapi-schema.json | 17 + 2 files changed, 29 insertions(+), 0 deletions(-) +++ b/qga/qapi-schema.json @@ -100,6 +100,23

Re: [Qemu-devel] [RFC PATCH 0/3] Time resync support by qemu-ga

2013-01-10 Thread Lei Li
On 01/08/2013 03:01 AM, Eric Blake wrote: On 01/06/2013 03:06 AM, Lei Li wrote: This patch series attempts to add time resync support to qemu-ga by introducing qemu-ga commands guest-get-time and guest-set-time. The interface for these commands like: { 'command': 'guest-get-time', 'returns': '

Re: [Qemu-devel] [PATCH v2] sheepdog: implement direct write semantics

2013-01-10 Thread MORITA Kazutaka
At Thu, 10 Jan 2013 16:03:47 +0800, Liu Yuan wrote: > > From: Liu Yuan > > Sheepdog supports both writeback/writethrough write but has not yet supported > DIRECTIO semantics which bypass the cache completely even if Sheepdog daemon > is > set up with cache enabled. > > Suppose cache is enabled

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

2013-01-10 Thread 马磊
On Fri, Jan 11, 2013 at 2:28 PM, Wanlong Gao wrote: > On 01/11/2013 11:39 AM, 马磊 wrote: > > > > > > On Thu, Jan 10, 2013 at 8:20 PM, Daniel P. Berrange > > berra...@redhat.com>> wrote: > > > > On Wed, Jan 09, 2013 at 09:37:54PM +, Blue Swirl wrote: > > > On Wed, Jan 9, 2013 at 7:31 A

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-10 Thread Lei Li
On 01/09/2013 11:36 PM, mdroth wrote: On Sun, Jan 06, 2013 at 06:06:58PM +0800, Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 18 ++ qga/qapi-schema.json | 17 + 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/qga/commands

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-10 Thread Lei Li
On 01/09/2013 09:32 PM, Luiz Capitulino wrote: On Sun, 6 Jan 2013 18:06:58 +0800 Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 18 ++ qga/qapi-schema.json | 17 + 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/qga/comm

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-10 Thread Lei Li
On 01/08/2013 05:52 AM, Eric Blake wrote: On 01/06/2013 03:06 AM, Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 18 ++ qga/qapi-schema.json | 17 + 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

2013-01-10 Thread Wanlong Gao
On 01/11/2013 11:39 AM, 马磊 wrote: > > > On Thu, Jan 10, 2013 at 8:20 PM, Daniel P. Berrange > wrote: > > On Wed, Jan 09, 2013 at 09:37:54PM +, Blue Swirl wrote: > > On Wed, Jan 9, 2013 at 7:31 AM, 马磊 > wrote: > > > > >

Re: [Qemu-devel] [PATCH 3/3 v2] Enable kvm emulated watchdog

2013-01-10 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Thursday, January 10, 2013 9:07 PM > To: Bhushan Bharat-R65777 > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Bhushan Bharat-R65777 > Subject: Re: [PATCH 3/3 v2] Enable kvm emulated watchdog > > > On 28.12.201

Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-10 Thread Matthew Ogilvie
On Tue, Jan 08, 2013 at 09:31:19AM +0200, Gleb Natapov wrote: > On Mon, Jan 07, 2013 at 06:17:22PM -0600, mmogi...@miniinfo.net wrote: > > On Mon, 7 Jan 2013 11:39:18 +0200, Gleb Natapov wrote: > > > On Wed, Dec 26, 2012 at 10:39:53PM -0700, Matthew Ogilvie wrote: > > >> Reading the spec, it is cl

Re: [Qemu-devel] [PATCH KVM v2 2/4] KVM: additional i8254 output fixes

2013-01-10 Thread Matthew Ogilvie
On Tue, Jan 08, 2013 at 09:41:36AM +0200, Gleb Natapov wrote: > On Mon, Jan 07, 2013 at 06:35:47PM -0600, mmogi...@miniinfo.net wrote: > > On Mon, 7 Jan 2013 14:04:03 +0200, Gleb Natapov wrote: > > > On Wed, Dec 26, 2012 at 10:39:54PM -0700, Matthew Ogilvie wrote: > > >> Make git_get_out() consist

Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction

2013-01-10 Thread Wenchao Xia
于 2013-1-10 20:41, Stefan Hajnoczi 写道: On Thu, Jan 10, 2013 at 11:21:22AM +0800, Wenchao Xia wrote: 于 2013-1-9 20:44, Stefan Hajnoczi 写道: On Mon, Jan 07, 2013 at 03:28:06PM +0800, Wenchao Xia wrote: This patch switch to internal common API to take group external snapshots from qmp_transacti

Re: [Qemu-devel] [RFC PATCH 2/2] virtio-net: introduce a new control to set macaddr

2013-01-10 Thread Rusty Russell
"Michael S. Tsirkin" writes: >> +if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) { >> +/* Set MAC address by writing config space */ >> vdev->config->set(vdev, offsetof(struct virtio_net_config, mac), >>dev->dev_addr, dev->addr_len); >>

Re: [Qemu-devel] [RFC PATCH 0/2] make mac programming for virtio net more robust

2013-01-10 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Thu, Jan 10, 2013 at 10:45:39PM +0800, ak...@redhat.com wrote: >> From: Amos Kong >> >> Currenly mac is programmed byte by byte. This means that we >> have an intermediate step where mac is wrong. >> >> Second patch introduced a new vq control command to set

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

2013-01-10 Thread 马磊
On Thu, Jan 10, 2013 at 8:20 PM, Daniel P. Berrange wrote: > On Wed, Jan 09, 2013 at 09:37:54PM +, Blue Swirl wrote: > > On Wed, Jan 9, 2013 at 7:31 AM, 马磊 wrote: > > > > > > > > >>> Hi, > > >>> The final effect is as follows: > > >>> > > >>> > > >>> [malei@xentest-4-1 Fri Dec 28 ~/honeyp

Re: [Qemu-devel] [PATCH 06/17] target-i386: remove vendor_override field from CPUX86State

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 03:10:20AM +0100, Igor Mammedov wrote: > commit 8935499831312 makes cpuid return to guest host's vendor value > instead of built-in one by default if kvm_enabled() == true and allows > to override this behavior if 'vendor' is specified on -cpu command line. > > But every ti

[Qemu-devel] [PATCH qom-cpu 0/2] replace cpuid_*features fields with a featue word array (v5)

2013-01-10 Thread Eduardo Habkost
Now that some new stuff entered qom-cpu, I am resending this patch hoping that it gets reviewed in time before it has to be rebased again. :-) Changes in v4 and v5: - Simple rebases done by updating and re-running the sed script (v4 was not submitted to qemu-devel, but I am naming this version

[Qemu-devel] [PATCH 16/17] target-i386: set custom 'tsc-frequency' without intermediate x86_def_t

2013-01-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: make patch independent of visit_type_freq() --- target-i386/cpu.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ec27cf6..c3e1792 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c

[Qemu-devel] [PATCH 06/17] target-i386: remove vendor_override field from CPUX86State

2013-01-10 Thread Igor Mammedov
commit 8935499831312 makes cpuid return to guest host's vendor value instead of built-in one by default if kvm_enabled() == true and allows to override this behavior if 'vendor' is specified on -cpu command line. But every time guest calls cpuid to get 'vendor' value, host's value is read again an

Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function

2013-01-10 Thread Wenchao Xia
于 2013-1-10 21:36, Eric Blake 写道: On 01/09/2013 10:43 PM, Wenchao Xia wrote: v2: Generally, the v2 information should go... Do you know how to put change log under "---" in "git commit"? I found it inconvenient to edit every ".patch" file, so added the log directly in commit message.

Re: [Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command

2013-01-10 Thread Wenchao Xia
于 2013-1-10 21:12, Luiz Capitulino 写道: On Thu, 10 Jan 2013 16:32:32 +0800 Wenchao Xia wrote: This patch make parsing of hmp command aware of that it may have sub command. Also discard simple encapsulation function monitor_find_command() and qmp_find_cmd(). You don't qmp_find_cmd() anymore

[Qemu-devel] [PATCH 04/17] target-i386: add x86_cpu_vendor_words2str()

2013-01-10 Thread Igor Mammedov
Make for() cycle reusable for the next patch Signed-off-by: Igor Mammedov --- v4: - rename x86cpu_vendor_words2str() to x86_cpu_vendor_words2str() Suggested-By: Andreas Färber v3: -replace e[bcd]x arguments naming with vendor[123] -fix/swap vendor2 and vendor3 order

Re: [Qemu-devel] [PATCH V4 1/4] HMP: add QDict to info callback handler

2013-01-10 Thread Wenchao Xia
于 2013-1-10 21:10, Luiz Capitulino 写道: On Thu, 10 Jan 2013 16:32:31 +0800 Wenchao Xia wrote: diff --git a/monitor.c b/monitor.c index 9cf419b..c7b3014 100644 --- a/monitor.c +++ b/monitor.c @@ -123,7 +123,7 @@ typedef struct mon_cmd_t { const char *help; void (*user_print)(Monitor

[Qemu-devel] [PATCH 17/17] target-i386: remove setting tsc-frequency from x86_def_t

2013-01-10 Thread Igor Mammedov
Setting tsc-frequency from x86_def_t is NOP because default tsc_khz in x86_def_t is 0 and CPUX86State.tsc_khz is also initialized to 0 by default. So there is not need to set ovewrite tsc_khz with default 0 because field was already initialized to 0. custom tsc-frequency setting is not affected du

Re: [Qemu-devel] [PATCH V4 4/4] HMP: add sub command table to info

2013-01-10 Thread Wenchao Xia
于 2013-1-10 18:24, Markus Armbruster 写道: > Wenchao Xia writes: > >>Now info command takes a table of sub info commands, >> and changed do_info() to do_info_help() to do help funtion >> only. > > Commit message should document that info no longer lists > the topics. > OK. -- Best Regar

Re: [Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command

2013-01-10 Thread Wenchao Xia
> Wenchao Xia writes: > >>This patch make parsing of hmp command aware of that it may >> have sub command. Also discard simple encapsulation function >> monitor_find_command() and qmp_find_cmd(). >> >> Signed-off-by: Wenchao Xia >> --- >> monitor.c | 31 +++ >>

Re: [Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command

2013-01-10 Thread Wenchao Xia
于 2013-1-10 18:23, Markus Armbruster 写道: > Wenchao Xia writes: > >>This patch make parsing of hmp command aware of that it may >> have sub command. Also discard simple encapsulation function >> monitor_find_command() and qmp_find_cmd(). >> >> Signed-off-by: Wenchao Xia >> --- >> monitor.c

Re: [Qemu-devel] [PATCH 06/17] target-i386: remove vendor_override field from CPUX86State

2013-01-10 Thread Igor Mammedov
On Fri, 11 Jan 2013 00:42:13 -0200 Eduardo Habkost wrote: > On Fri, Jan 11, 2013 at 03:10:20AM +0100, Igor Mammedov wrote: > > commit 8935499831312 makes cpuid return to guest host's vendor value > > instead of built-in one by default if kvm_enabled() == true and allows > > to override this behav

[Qemu-devel] [PATCH qom-cpu 00/17] x86 CPU cleanup, part 3

2013-01-10 Thread Igor Mammedov
It's rebase of "PATCH 00/20 v4] x86 CPU cleanup (wave 2)" including changes asked by Andreas on IRC. See below (v5) for detailed changes. This series is several cleanups, moved out from CPU properties series, since they do not really depend on CPU properties re-factoring and could simplify CPU sub

[Qemu-devel] [PATCH 07/17] target-i386: prepare cpu_x86_parse_featurestr() to return a set of key, value property pairs

2013-01-10 Thread Igor Mammedov
It prepares for converting "+feature,-feature,feature=foo,feature" into a set of key,value property pairs that will be applied to CPU by x86_cpu_set_props(). It separates legacy format parsing from property setting, later it could be transformed into code that sets global properties for a given CP

[Qemu-devel] [PATCH 04/17 v2] target-i386: add x86_cpu_vendor_words2str()

2013-01-10 Thread Igor Mammedov
Make for() cycle reusable for the next patch Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- v5: - style fix: added extra space to align arguments Spotted-By: Eduardo Habkost v4: - rename x86cpu_vendor_words2str() to x86_cpu_vendor_words2str() Suggested-B

[Qemu-devel] [PATCH 03/17] target-i386: move kvm_check_features_against_host() check to realize time

2013-01-10 Thread Igor Mammedov
kvm_check_features_against_host() should be called when features can't be changed and when features are convereted to properties it would be possible to change them until realize time, so correct way is to call kvm_check_features_against_host() in x86_cpu_realize() Signed-off-by: Igor Mammedov --

[Qemu-devel] [PATCH 12/17] target-i386: set custom 'model-id' without intermediate x86_def_t

2013-01-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target-i386/cpu.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b84bde6..635f126 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1385,8 +1385,7 @@ sta

Re: [Qemu-devel] [PATCH 05/17] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 03:10:19AM +0100, Igor Mammedov wrote: > Vendor property setter takes string as vendor value but cpudefs > use uint32_t vendor[123] fields to define vendor value. It makes it > difficult to unify and use property setter for values from cpudefs. > > Simplify code by using ve

Re: [Qemu-devel] [PATCH 04/17] target-i386: add x86_cpu_vendor_words2str()

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 03:10:18AM +0100, Igor Mammedov wrote: > Make for() cycle reusable for the next patch > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Very minor style comment below. > --- > v4: >- rename x86cpu_vendor_words2str() to x86_cpu_vendor_words2str() >

Re: [Qemu-devel] [PATCH 03/17] target-i386: move kvm_check_features_against_host() check to realize time

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 03:10:17AM +0100, Igor Mammedov wrote: > kvm_check_features_against_host() should be called when features can't be > changed and when features are convereted to properties it would be possible to > change them until realize time, so correct way is to call > kvm_check_feature

Re: [Qemu-devel] [PATCH 02/17] target-i386: cpu_x86_register() consolidate freeing resources

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 03:10:16AM +0100, Igor Mammedov wrote: > freeing resources in one place would require setting 'error' > to not NULL, so add some more error reporting before jumping to > exit branch. > > Signed-off-by: Igor Mammedov > Reviewed-by: Eduardo Habkost To confirm that this reb

Re: [Qemu-devel] [PATCH 01/17] target-i386: move setting defaults out of cpu_x86_parse_featurestr()

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 03:10:15AM +0100, Igor Mammedov wrote: > No functional change, needed for simplifying conversion to properties. > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost > --- > v2: > - rebased on top of "disable kvm_mmu + -cpu "enforce" fixes (v3)" > --- > targ

[Qemu-devel] [PATCH qom-cpu 1/2] target-i386/cpu.c: Coding style fixes

2013-01-10 Thread Eduardo Habkost
* Add braces to 'if' statements; * Remove last TAB character from the source. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 9a48e3f..0b44dea 100644 --- a/target-i386/cp

[Qemu-devel] [PATCH 15/17] target-i386: set custom 'family' without intermediate x86_def_t

2013-01-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target-i386/cpu.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 51411aa..ec27cf6 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1341,13 +1341,7

[Qemu-devel] [PATCH 14/17] target-i386: set custom 'model' without intermediate x86_def_t

2013-01-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target-i386/cpu.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 6cb9bed..51411aa 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1349,13 +1349,7

[Qemu-devel] [PATCH 13/17] target-i386: set custom 'stepping' without intermediate x86_def_t

2013-01-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target-i386/cpu.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 635f126..6cb9bed 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1357,13 +1357,7

[Qemu-devel] [PATCH 09/17] target-i386: print deprecated warning if xlevel < 0x80000000

2013-01-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 485154d..9cf0ade 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1380,6 +1380,8 @@ static int cpu_x86_parse_featurest

[Qemu-devel] [PATCH 10/17] target-i386: set custom 'xlevel' without intermediate x86_def_t

2013-01-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- v2: use qstring_append_int() for converting xlevel to string Suggested-By: Eduardo Habkost --- target-i386/cpu.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c

[Qemu-devel] [PATCH 05/17] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2013-01-10 Thread Igor Mammedov
Vendor property setter takes string as vendor value but cpudefs use uint32_t vendor[123] fields to define vendor value. It makes it difficult to unify and use property setter for values from cpudefs. Simplify code by using vendor property setter, vendor[123] fields are converted into vendor[13] ar

[Qemu-devel] [PATCH 11/17] target-i386: set custom 'level' without intermediate x86_def_t

2013-01-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target-i386/cpu.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b00c651..b84bde6 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1365,13 +1365,7

[Qemu-devel] [PATCH 08/17] target-i386: set custom 'vendor' without intermediate x86_def_t

2013-01-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target-i386/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index c55f137..485154d 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1384,7 +1384,7 @@ stat

[Qemu-devel] [PATCH 02/17] target-i386: cpu_x86_register() consolidate freeing resources

2013-01-10 Thread Igor Mammedov
freeing resources in one place would require setting 'error' to not NULL, so add some more error reporting before jumping to exit branch. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- v4: - rebased with "target-i386: move out CPU features initialization in separate func

[Qemu-devel] [PATCH 01/17] target-i386: move setting defaults out of cpu_x86_parse_featurestr()

2013-01-10 Thread Igor Mammedov
No functional change, needed for simplifying conversion to properties. Signed-off-by: Igor Mammedov --- v2: - rebased on top of "disable kvm_mmu + -cpu "enforce" fixes (v3)" --- target-i386/cpu.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/target-i386/cpu.

Re: [Qemu-devel] [PATCH v4 1/3] target-i386:define name of breakpoint bit in dr7

2013-01-10 Thread li guang
Hi, Andreas can these patches get an ack from you? or they were obsoleted? 在 2012-12-10一的 10:22 +0800,liguang写道: > Signed-off-by: liguang > --- > target-i386/cpu.h |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > index

Re: [Qemu-devel] [PATCH qom-cpu 0/7] disable kvm_mmu + -cpu "enforce" fixes (v3)

2013-01-10 Thread Andreas Färber
Am 07.01.2013 19:20, schrieb Eduardo Habkost: > Eduardo Habkost (7): > kvm: Add fake KVM constants to avoid #ifdefs on KVM-specific code [...] > target-i386: Disable kvm_mmu by default > target-i386/cpu: Introduce FeatureWord typedefs > target-i386: kvm_check_features_against_host(): Use fe

Re: [Qemu-devel] [PATCH qom-cpu 0/7] QOM CPUState, part 7: CPU_COMMON for topology

2013-01-10 Thread Andreas Färber
Am 08.01.2013 22:25, schrieb Eduardo Habkost: > On Mon, Jan 07, 2013 at 06:18:14PM +0100, Andreas Färber wrote: >> Am 19.12.2012 16:31, schrieb Andreas Färber: >>> Hello, >>> >>> This series moves more fields from CPU_COMMON / CPU*State to CPUState, >>> allowing access from target-independent code.

Re: [Qemu-devel] [RFC 01/12] kvm: add KVM_FEATURE_CLOCKSOURCE_STABLE_BIT fake #define

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 12:15:16AM +0100, Igor Mammedov wrote: [...] > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > > index 6bdd513..22acf91 100644 > > --- a/include/sysemu/kvm.h > > +++ b/include/sysemu/kvm.h > > @@ -36,6 +36,7 @@ > > #define KVM_FEATURE_ASYNC_PF 0 > > #defin

Re: [Qemu-devel] [RFC 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 12:07:40AM +0100, Igor Mammedov wrote: [...] > > @@ -1343,13 +1337,15 @@ static int cpu_x86_parse_featurestr(x86_def_t > > *x86_cpu_def, char *features) > > unsigned int i; > > char *featurestr; /* Single 'key=value" string being parsed */ > > /* Features to

Re: [Qemu-devel] [RFC 07/12] target-i386/cpu: Introduce apic_id_for_cpu() function

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 12:31:23AM +0100, Igor Mammedov wrote: > On Wed, 9 Jan 2013 16:53:47 -0200 > Eduardo Habkost wrote: > > > This function will be used by both the CPU initialization code and the > > fw_cfg table initialization code. > > > > Later this function will be updated to generate

Re: [Qemu-devel] [RFC 12/12] pc: Generate APIC IDs according to CPU topology

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 12:36:35AM +0100, Igor Mammedov wrote: [...] > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index 33787dc..f34192c 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c > > @@ -23,6 +23,8 @@ > > > > #include "cpu.h" > > #include "sysemu/kvm.h" > > +#

Re: [Qemu-devel] [RFC 07/12] target-i386/cpu: Introduce apic_id_for_cpu() function

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 12:31:23AM +0100, Igor Mammedov wrote: > On Wed, 9 Jan 2013 16:53:47 -0200 > Eduardo Habkost wrote: > > > This function will be used by both the CPU initialization code and the > > fw_cfg table initialization code. > > > > Later this function will be updated to generate

Re: [Qemu-devel] [RFC 12/12] pc: Generate APIC IDs according to CPU topology

2013-01-10 Thread Igor Mammedov
On Wed, 9 Jan 2013 16:53:52 -0200 Eduardo Habkost wrote: > This keeps compatibility on machine-types pc-1.2 and older, and prints a > warning in case the requested configuration won't get the correct > topology. > > I couldn't think of a better way to warn about broken topology when in > compat

[Qemu-devel] [PULL v2] PReP patch queue 2013-01-11

2013-01-10 Thread Andreas Färber
Hello, Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. This contains a fix for runtime errors trying to use -M prep on qemu-system-ppc64 and some progress QOM'ifying the pc87312 Super I/O chipset. The pc87312 serves as example for the ongoing ppc IDE QOM'ifications

Re: [Qemu-devel] [PULL 0/2] two little testcase fixes

2013-01-10 Thread Anthony Liguori
Pulled, thanks. N.B. This note may be extraneous because the pull request was sent by a version of git older than 1.7.9 making the pull request ambigious. Please consider upgrading to a newer version of git. Regards, Anthony Liguori

Re: [Qemu-devel] [RFC 07/12] target-i386/cpu: Introduce apic_id_for_cpu() function

2013-01-10 Thread Igor Mammedov
On Wed, 9 Jan 2013 16:53:47 -0200 Eduardo Habkost wrote: > This function will be used by both the CPU initialization code and the > fw_cfg table initialization code. > > Later this function will be updated to generate APIC IDs according to > the CPU topology. > > Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [RFC 01/12] kvm: add KVM_FEATURE_CLOCKSOURCE_STABLE_BIT fake #define

2013-01-10 Thread Igor Mammedov
On Wed, 9 Jan 2013 16:53:41 -0200 Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > Cc: k...@vger.kernel.org > Cc: Michael S. Tsirkin > Cc: Gleb Natapov > Cc: Marcelo Tosatti > --- > include/sysemu/kvm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/sysemu/

Re: [Qemu-devel] [PULL] PReP patch queue 2012-08-15

2013-01-10 Thread Anthony Liguori
Andreas Färber writes: > Am 15.08.2012 22:27, schrieb Andreas Färber: >> Hello Anthony, >> >> Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. >> >> With Alex' and Hervé's blessing this contains both fixes for runtime errors >> trying to use -M prep on qemu-system-p

Re: [Qemu-devel] [PATCH qom-cpu 6/7] target-i386/cpu.c: Add feature name array for ext4_features

2013-01-10 Thread Andreas Färber
Am 07.01.2013 19:20, schrieb Eduardo Habkost: > Feature names were taken from the X86_FEATURE_* constants in the Linux > kernel code. > > Signed-off-by: Eduardo Habkost > --- > Cc: Gleb Natapov > --- > target-i386/cpu.c | 17 + > 1 file changed, 17 insertions(+) > > diff --git

Re: [Qemu-devel] [RFC 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-10 Thread Igor Mammedov
On Wed, 9 Jan 2013 16:53:42 -0200 Eduardo Habkost wrote: > This is a cleanup that tries to solve two small issues: > > - We don't need a separate kvm_pv_eoi_features variable just to keep a >constant calculated at compile-time, and this style would require >adding a separate variable (

[Qemu-devel] [PATCH v2] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Meador Inge
GCC and GAS are capable of generating traps or breaks to check for division by zero. Additionally, GAS is capable of generating traps or breaks to check for overflow on certain division and multiplication operations. The Linux kernel translates these traps and breaks into signals. This patch imp

Re: [Qemu-devel] [PATCH qom-cpu 3/7] target-i386: Disable kvm_mmu by default

2013-01-10 Thread Andreas Färber
Am 07.01.2013 19:20, schrieb Eduardo Habkost: > KVM_CAP_PV_MMU capability reporting was removed from the kernel since > v2.6.33 (see commit a68a6a7282373), and was completely removed from the > kernel since v3.3 (see commit fb92045843). It doesn't make sense to keep > it enabled by default, as it w

Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Meador Inge
On 01/10/2013 04:12 PM, Peter Maydell wrote: > This is an OS/ABI specific define, right? I don't think it > belongs in the target-mips header file. Since it only has one > user, I think you could reasonably just put it in linux-user/main.c. The enum will only be used in the MIPS CPU loop. I orig

Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Meador Inge
On 01/10/2013 03:57 PM, Stefan Weil wrote: > please check your patch before submitting it to qemu-devel. > See also http://wiki.qemu.org/Contribute/SubmitAPatch. Ah, thanks for the pointer. I have fixed the style violations. -- Meador Inge CodeSourcery / Mentor Embedded

Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Peter Maydell
On 10 January 2013 21:46, Meador Inge wrote: > --- a/target-mips/cpu.h > +++ b/target-mips/cpu.h > @@ -620,6 +620,12 @@ enum { > /* Dummy exception for conditional stores. */ > #define EXCP_SC 0x100 > > +/* Break codes */ > +enum { > +BRK_OVERFLOW = 6, > +BRK_DIVZERO = 7 > +}; This is

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2013-01-10 Thread Peter Schaefer
Hi again! The good news: 1.3.0 works (at least with my setup). The bad news is that this might lower the motivation to fix 1.1.2 ;-) ... Attached is the USB trace file from the non-working case with V 1.1.2. If decompressed, it's an 185 MB text file and - honestly - i cannot make any sense of it

Re: [Qemu-devel] [PATCH] Check return values from g_poll and select

2013-01-10 Thread Anthony Liguori
Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Stefan Weil
Am 10.01.2013 22:46, schrieb Meador Inge: GCC and GAS are capable of generating traps or breaks to check for division by zero. Additionally, GAS is capable of generating traps or breaks to check for overflow on certain division and multiplication operations. The Linux kernel translates these tr

Re: [Qemu-devel] [PATCH][v2] linux-user,alpha: correct select()

2013-01-10 Thread Richard Henderson
On 01/10/2013 01:30 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- v2: remove unused TARGET_S390 and simplify ifdefs linux-user/syscall.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

2013-01-10 Thread Meador Inge
GCC and GAS are capable of generating traps or breaks to check for division by zero. Additionally, GAS is capable of generating traps or breaks to check for overflow on certain division and multiplication operations. The Linux kernel translates these traps and breaks into signals. This patch imp

Re: [Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2013-01-10 Thread Erik de Castro Lopo
Matt Robinson wrote: > Is this patch available for public consumption? It doesn't seem to be > upstream. Unfortunately not yet. I'm working on getting permission to release it. Cheers, Erik -- -- Erik de Castro Lopo http://www.

Re: [Qemu-devel] [PULL] PReP patch queue 2012-08-15

2013-01-10 Thread Andreas Färber
Am 15.08.2012 22:27, schrieb Andreas Färber: > Hello Anthony, > > Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. > > With Alex' and Hervé's blessing this contains both fixes for runtime errors > trying to use -M prep on qemu-system-ppc64 and well as some progress >

[Qemu-devel] [PATCH][v2] linux-user,alpha: correct select()

2013-01-10 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- v2: remove unused TARGET_S390 and simplify ifdefs linux-user/syscall.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 94f79dd..693e66f 100644 --- a/linux-user/syscall.c +++ b/li

Re: [Qemu-devel] [PATCH][v2] linux-user, alpha: l_type of fcntl() flock differs

2013-01-10 Thread Richard Henderson
On 01/10/2013 12:42 PM, Laurent Vivier wrote: +static const bitmask_transtbl flock_tbl[] = { +TRANSTBL_CONVERT(F_RDLCK), +TRANSTBL_CONVERT(F_WRLCK), +TRANSTBL_CONVERT(F_UNLCK), +TRANSTBL_CONVERT(F_EXLCK), +TRANSTBL_CONVERT(F_SHLCK), +{ 0, 0, 0, 0 } +}; Oh, I forgot to me

Re: [Qemu-devel] [PATCH 0/2] qemu-ga: don't leak fds to exec()ed processes

2013-01-10 Thread mdroth
On Tue, Jan 08, 2013 at 07:26:24PM -0200, Luiz Capitulino wrote: > Please, check individual patches for details. > > Luiz Capitulino (2): > qemu-ga: ga_open_pidfile(): use qemu_open() > qemu-ga: add ga_open_logfile() Thanks, applied to qga branch. > > qga/main.c | 19 --- >

Re: [Qemu-devel] [PULL 0/2] vfio-pci: Fixes for 1.4 & stable

2013-01-10 Thread Anthony Liguori
Pulled, thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH][v2] linux-user, alpha: l_type of fcntl() flock differs

2013-01-10 Thread Laurent Vivier
Le jeudi 10 janvier 2013 à 13:05 -0800, Richard Henderson a écrit : > On 01/10/2013 12:42 PM, Laurent Vivier wrote: > > +static const bitmask_transtbl flock_tbl[] = { > > +TRANSTBL_CONVERT(F_RDLCK), > > +TRANSTBL_CONVERT(F_WRLCK), > > +TRANSTBL_CONVERT(F_UNLCK), > > +TRANSTBL_CONVER

[Qemu-devel] [PATCH][v2] linux-user, alpha: l_type of fcntl() flock differs

2013-01-10 Thread Laurent Vivier
on alpha, F_RDLCK, F_WRLCK, F_UNLCK, F_EXLCK, F_SHLCK are not the standard ones. This patch allows to run "dpkg" (database lock). Signed-off-by: Laurent Vivier --- v2: use bitmask_transtbl linux-user/syscall.c | 28 ++-- linux-user/syscall_defs.h | 18 +

Re: [Qemu-devel] [PATCH] ui/vnc: VA API based H.264 encoding for VNC framebuffer updates

2013-01-10 Thread Anthony Liguori
"Verbeiren, David" writes: > Thanks for your comments, Anthony. > > Anthony Liguori wrote: >> David Verbeiren writes: >> > This patch provides the VNC server side support. Corresponding VNC >> > client side support is required. To this end, we are also contributing a >> > patch >> > to the lib

[Qemu-devel] [PATCH v9 5/7] trace: [default] Port to generic event information and new control interface

2013-01-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- trace/default.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/trace/default.c b/trace/default.c index c9b27a2..6e07a47 100644 --- a/trace/default.c +++ b/trace/default.c @@ -1,7 +1,7 @@ /* * Default implementation for backend init

[Qemu-devel] [PATCH v9 6/7] trace: [simple] Port to generic event information and new control interface

2013-01-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/simple.py | 18 +- trace/simple.c | 32 +--- trace/simple.h |6 +- 3 files changed, 11 insertions(+), 45 deletions(-) diff --git a/scripts

[Qemu-devel] [PATCH v9 2/7] trace: Provide a generic tracing event descriptor

2013-01-10 Thread Lluís Vilanova
Uses tracetool to generate a backend-independent tracing event description (struct TraceEvent). The values for such structure are generated with the non-public "events" backend ("events-c" frontend). The generation of the defines to check if an event is statically enabled is also moved to the "ev

[Qemu-devel] [PATCH v9 4/7] trace: [monitor] Use new event control interface

2013-01-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- monitor.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 9cf419b..4c40541 100644 --- a/monitor.c +++ b/monitor.c @@ -735,10 +735,24 @@ static void do_trace_event_set_state(Monitor *mon, cons

Re: [Qemu-devel] [PATCH v2 10/10] chardev: add pty chardev support to chardev-add (qmp)

2013-01-10 Thread Eric Blake
On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: > The ptsname is returned directly, so there is no need to > use query-chardev to figure the pty device path. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json |3 ++- > qemu-char.c | 13 + > qmp-commands.hx |5

Re: [Qemu-devel] [PATCH v2 09/10] chardev: add socket chardev support to chardev-add (qmp)

2013-01-10 Thread Eric Blake
On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: > qemu_chr_open_socket is splitted into two functions. All initialization s/splitted/split/ > after creating the socket file handler is splitted away into the new and again > qemu_chr_open_socket_fd function. > > chr->filename doesn't get filled fr

Re: [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev support to chardev-add (qmp)

2013-01-10 Thread Eric Blake
On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: > Also alias the old parport name to parallel for -chardev. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json |3 ++- > qemu-char.c | 44 > qemu-options.hx |5 - > 3 files change

Re: [Qemu-devel] [PATCH v2 07/10] chardev: add serial chardev support to chardev-add (qmp)

2013-01-10 Thread Eric Blake
On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: > Simliar to file, except that no separate in/out files are supported s/Simliar/Similar/ > because it's pointless for direct device access. Also the special > tty ioctl hooks (pass through linespeed settings etc) are activated > on Unix. > > Signed-o

Re: [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp)

2013-01-10 Thread Eric Blake
On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: > Add support for file chardevs. Output file is mandatory, > input file is optional. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 13 ++- > qemu-char.c | 61 > ++ >

Re: [Qemu-devel] [PATCH 10/10] memory: remove old_portio-style callbacks support

2013-01-10 Thread Hervé Poussineau
Andreas Färber a écrit : Am 04.01.2013 22:29, schrieb Hervé Poussineau: Signed-off-by: Hervé Poussineau --- include/exec/memory.h |4 memory.c | 44 2 files changed, 48 deletions(-) diff --git a/include/exec/memory.h b/inclu

Re: [Qemu-devel] [PATCH 04/10] sun4u: create VGA card after ISA bus

2013-01-10 Thread Hervé Poussineau
Andreas Färber a écrit : Am 04.01.2013 22:29, schrieb Hervé Poussineau: Signed-off-by: Hervé Poussineau --- hw/sun4u.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Doesn't look wrong to me, cc'ing Blue. I figure this is for 07/10, which switches to isa_register_portio_list().

  1   2   3   4   >