On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: > qemu_chr_open_socket is splitted into two functions. All initialization
s/splitted/split/
> after creating the socket file handler is splitted away into the new
and again
> qemu_chr_open_socket_fd function.
>
> chr->filename doesn't get filled from QemuOpts any more. Qemu gathers
> the information using getsockname and getnameinfo instead. This way it
> will also work correctly for file handles passed via file descriptor
> passing.
>
> Finally qmp_chardev_open_socket() is the actual qmp hotplug
> implementation which basically just calls socket_listen or
> socket_connect and the new qemu_chr_open_socket_fd function.
>
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
> ---
> +# @ChardevSocket:
> +#
> +# Configuration info for socket chardevs.
Do you need any further doc details for individual fields?
> +#
> +# Since: 1.4
> +##
> +{ 'type': 'ChardevSocket', 'data': { 'addr' : 'SocketAddress',
> + '*server' : 'bool',
> + '*wait' : 'bool',
> + '*delay' : 'bool',
> + '*telnet' : 'bool' } }
> +
>
> -static CharDriverState *qemu_chr_open_socket(QemuOpts *opts)
> +static CharDriverState *qemu_chr_open_socket_fd(int fd, int do_nodelay,
> + int is_listen, int is_telnet,
> + int is_waitconnect,
> + Error **errp)
You didn't pick up on my v1 comment of converting these parameters to bool.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
