Hi list,
After discuss with Stefan Yesterday here some more info:
(this is for stable qemu 1.3, it was working fine with qemu 1.2)
The problem seem that whesettings a migrate_set_downtime to 1sec,
the transfert of the vm seem to send all the memory of the vm in 1 step, and
not by increment.
So
Disable the semaphores fallback code for OpenBSD as modern OpenBSD
releases now have sem_timedwait().
Signed-off-by: Brad Smith
diff --git a/include/qemu/thread-posix.h b/include/qemu/thread-posix.h
index 380bae2..0f30dcc 100644
--- a/include/qemu/thread-posix.h
+++ b/include/qemu/thread-posix.h
As reported in bug 1087114 the semaphores fallback code is broken which
results in QEMU crashing and making QEMU unusable.
This patch is from Paolo.
This needs to be back ported to the 1.3 stable tree as well.
Signed-off-by: Paolo Bonzini
Signed-off-by: Brad Smith
diff --git a/util/qemu-thre
This patch install the timer reset handler. This will be called when
the guest is reset.
Signed-off-by: Bharat Bhushan
---
v2: same as v1
hw/ppc_booke.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/ppc_booke.c b/hw/ppc_booke.c
index d51e7fa..837a5b6 1
Enable the KVM emulated watchdog if KVM supports (use the
capability enablement in watchdog handler). Also watchdog exit
(KVM_EXIT_WATCHDOG) handling is added.
Watchdog state machine is cleared whenever VM state changes to running.
This is to handle the cases like return from debug halt etc.
Signe
This is needed for the watchdog patches (follow up patches)
Signed-off-by: Bharat Bhushan
---
v2: same as v1
linux-headers/asm-generic/kvm_para.h |4 +
linux-headers/asm-powerpc/epapr_hcalls.h | 98 ++
linux-headers/asm-powerpc/kvm.h | 86 ++
The Patchset enables and handle the in-kernel watchdog emulation
if KVM supports.
The first Patch is synchronizes the Linux-headers as this is needed
for enabling the in-kernel watchdog emulation.
The Second Patch installs the timer reset handler and the Third patch
enables and handles the watchdog
Hello list,
i'm using qemu 1.3 and migration works fine if i do not set
migrate_downtime.
If i set migrate_downtime to 1s or 0.5s or 0.3s the VM halts immediatly
i cannot even connect to the qmp socket anymore and migration takes 5-10
minutes or never finishes.
I see high cpu usage on sour
On Thu, Dec 27, 2012 at 03:59:36PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
> ---
> target-i386/cpu.c |8 +---
> 1 files changed, 1 insertions(+), 7 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 8c65012..fd5
On Thu, Dec 27, 2012 at 08:15:18PM +0100, Igor Mammedov wrote:
> On Thu, 27 Dec 2012 16:41:47 -0200
> Eduardo Habkost wrote:
>
> > On Thu, Dec 27, 2012 at 03:59:17PM +0100, Igor Mammedov wrote:
> > > Signed-off-by: Igor Mammedov
> > > Reviewed-by: Eduardo Habkost
> > > Signed-off-by: Eduardo Ha
On Thu, Dec 27, 2012 at 03:59:35PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
> ---
> target-i386/cpu.c |8 +---
> 1 files changed, 1 insertions(+), 7 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 3ee4c65..8c65
On Thu, Dec 27, 2012 at 03:59:34PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
> ---
> target-i386/cpu.c |8 +---
> 1 files changed, 1 insertions(+), 7 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index aab5f6f..3ee4
On Thu, Dec 27, 2012 at 03:59:33PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
> ---
> target-i386/cpu.c |3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 1cb2f08..aab5f6f
On Thu, Dec 27, 2012 at 03:59:32PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
Now I am starting to see why you are using featurestr in the qdict_put()
calls. :-)
> ---
> target-i386/cpu.c |8 +---
> 1 files changed, 1 insertions(+), 7 dele
On Thu, Dec 27, 2012 at 03:59:31PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
> ---
> target-i386/cpu.c |4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 0764015..d8af528 100644
> --- a/target-i386/cpu.c
On Thu, Dec 27, 2012 at 03:59:29PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
I would write it as
qdict_put(*props, "vendor", qstring_from_str(val))
instead. It would make the property-setting code more greppable (and
easier to read IMO).
On the o
On Thu, 27 Dec 2012 17:09:16 -0200
Eduardo Habkost wrote:
> On Thu, Dec 27, 2012 at 03:59:30PM +0100, Igor Mammedov wrote:
> > Signed-off-by: Igor Mammedov
> > ---
> > target-i386/cpu.c |2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/target-i386/cpu.c b/tar
On Thu, 27 Dec 2012 16:41:47 -0200
Eduardo Habkost wrote:
> On Thu, Dec 27, 2012 at 03:59:17PM +0100, Igor Mammedov wrote:
> > Signed-off-by: Igor Mammedov
> > Reviewed-by: Eduardo Habkost
> > Signed-off-by: Eduardo Habkost
>
> Patch is OK, but Subject line needs to be fixed. You are moving t
On Thu, Dec 27, 2012 at 03:59:28PM +0100, Igor Mammedov wrote:
> It prepares for converting "+feature,-feature,feature=foo,feature" into
> a set of key,value property pairs that will be applied to CPU by
> cpu_x86_set_props().
>
> It separates legacy format parsing from property setting, later it
On Thu, Dec 27, 2012 at 03:59:30PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
> ---
> target-i386/cpu.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 084faeb..0764015 100644
> --- a/target-i386/cpu.c
>
On Thu, Dec 27, 2012 at 03:59:27PM +0100, Igor Mammedov wrote:
> commit 8935499831312 makes cpuid return to guest host's vendor value
> instead of built-in one by default if kvm_enabled() == true and allows
> to override this behavior if 'vendor' is specified on -cpu command line.
>
> But every ti
On Thu, Dec 27, 2012 at 03:59:26PM +0100, Igor Mammedov wrote:
> Vendor property setter takes string as vendor value but cpudefs
> use uint32_t vendor[123] fields to define vendor value. It makes it
> difficult to unify and use property setter for values from cpudefs.
>
> Simplify code by using ve
On Thu, Dec 27, 2012 at 03:59:25PM +0100, Igor Mammedov wrote:
> Make for() cycle reusable for the next patch
>
> Signed-off-by: Igor Mammedov
> Reviewed-by: Eduardo Habkost
To confirm that this specific submission looks OK to me:
Reviewed-by: Eduardo Habkost
> ---
> target-i386/cpu.c | 2
On Thu, Dec 27, 2012 at 03:59:24PM +0100, Igor Mammedov wrote:
> kvm_check_features_against_host() should be called when features can't be
> changed
> and when features are convereted to properties it would be possible to change
> them
> until realize time, so correct way is to call
> kvm_check_
On Thu, Dec 27, 2012 at 03:59:23PM +0100, Igor Mammedov wrote:
> freeing resources in one place would require setting 'error'
> to not NULL, so add some more error reporting before jumping to
> exit branch.
>
> Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
> ---
> v2:
>- add
On Thu, Dec 27, 2012 at 03:59:22PM +0100, Igor Mammedov wrote:
> No functional change, a simple code movement to simplify following
> refactoring.
>
> Signed-off-by: Igor Mammedov
> Reviewed-by: Eduardo Habkost
To confirm that this specific submission is OK to me:
Reviewed-by: Eduardo Habkost
On Thu, Dec 27, 2012 at 03:59:21PM +0100, Igor Mammedov wrote:
> No functional change, needed for simplifying conversion to properties.
>
> Signed-off-by: Igor Mammedov
> Reviewed-by: Eduardo Habkost
To confirm that this specific submission is OK to me:
Reviewed-by: Eduardo Habkost
> ---
>
On Thu, Dec 27, 2012 at 03:59:20PM +0100, Igor Mammedov wrote:
> since cpu_def config is not supported anymore and all remaining sources now
> always set x86_def_t.vendor[123] fields remove setting default vendor to
> simplify future re-factoring.
>
> Signed-off-by: Igor Mammedov
> Reviewed-by: E
On Thu, Dec 27, 2012 at 03:59:18PM +0100, Igor Mammedov wrote:
> when CPU properties are implemented, ext2_features may change
> between object_new(CPU) and cpu_realize_fn(). Sanitizing
> ext2_features for AMD based CPU at realize() time will keep
> current behavior after CPU features are converted
On Thu, Dec 27, 2012 at 03:59:19PM +0100, Igor Mammedov wrote:
> it will help to get rid of setting default.
>
> Signed-off-by: Igor Mammedov
> Reviewed-by: Eduardo Habkost
To confirm that this specific submission is OK to me:
Reviewed-by: Eduardo Habkost
> ---
> target-i386/cpu.c | 27 +++
On Thu, Dec 27, 2012 at 03:59:17PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
> Reviewed-by: Eduardo Habkost
> Signed-off-by: Eduardo Habkost
Patch is OK, but Subject line needs to be fixed. You are moving the
filtering for both KVM and non-KVM cases, not just the TCG filtering.
Ok,I'll try to bisect it tomorrow and will do more tests.
I'll keep you in touch!
Alexandre
- Mail original -
De: "Paolo Bonzini"
À: "Alexandre DERUMIER"
Cc: qemu-devel@nongnu.org, anth...@codemonkey.ws, "Juan Quintela"
Envoyé: Jeudi 27 Décembre 2012 17:08:23
Objet: Re: [Qemu-devel
Hi guys,
I am working on the time drift issue as background info here.
http://mid.gmane.org/87pq5r5otp@codemonkey.ws
As Anthony proposed, one part of the solutions is that we want
to add a qemu-ga command to resync the guest clock by reading the
wallclock time when the tick overflow the lim
Il 13/12/2012 10:19, Paolo Bonzini ha scritto:
> Five small, boring patches. Inspired by Gerd's patch at
> http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05229.html which
> unfortunately is already out of date.
Ping...
Paolo
> Paolo Bonzini (5):
> docs: move pci-ids.txt to docs/specs
Il 27/12/2012 16:51, Alexandre DERUMIER ha scritto:
>>> 1) What happened before these patches? If something different, can you
>>> bisect it?
> Well, qemu 1.3 stable release, was working slowly (bigger downtime), but no
> crash.
> I don't see any changes since 1.3 and theses patches.
These patc
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
Signed-off-by: Eduardo Habkost
---
target-i386/cpu.c | 31 ---
1 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 7be3ad8..63aae86 100644
--- a/targe
Vendor property setter takes string as vendor value but cpudefs
use uint32_t vendor[123] fields to define vendor value. It makes it
difficult to unify and use property setter for values from cpudefs.
Simplify code by using vendor property setter, vendor[123] fields
are converted into vendor[13] ar
No functional change, needed for simplifying conversion to properties.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 99fd3f3..e534254
it will help to get rid of setting default.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 64b7637..1497980 100644
---
>>1) What happened before these patches? If something different, can you
>>bisect it?
Well, qemu 1.3 stable release, was working slowly (bigger downtime), but no
crash.
I don't see any changes since 1.3 and theses patches.
>>2) Do you get anything on the console (stdout)? See
>>kvm_handle_intern
No functional change, a simple code movement to simplify following refactoring.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
v2:
- rebased on top of "i386: cpu: remove duplicate feature names"
http://www.mail-archive.com/qemu-devel@nongnu.org/msg129458.html
v3:
- re
when CPU properties are implemented, ext2_features may change
between object_new(CPU) and cpu_realize_fn(). Sanitizing
ext2_features for AMD based CPU at realize() time will keep
current behavior after CPU features are converted to properties.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Hab
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 3ead1f4..084faeb 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1338,7 +1338,7 @@ static int cpu_x86_parse_featurest
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index aab5f6f..3ee4c65 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1311,13 +1311,7 @@ static int cpu_x86_parse_fe
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 3ee4c65..8c65012 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1303,13 +1303,7 @@ static int cpu_x86_parse_fe
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 8c65012..fd53b41 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1295,13 +1295,7 @@ static int cpu_x86_parse_fe
Il 27/12/2012 16:30, Alexandre DERUMIER ha scritto:
> Hi,
> I'm currently testing new migration code with last qemu.git,
>
> it's working pretty fine (around 30ms downtime with standard workload).
>
>
> But I have add some problem, with high memory workload vm. (playing an HD
> video for exampl
Hi,
I'm currently testing new migration code with last qemu.git,
it's working pretty fine (around 30ms downtime with standard workload).
But I have add some problem, with high memory workload vm. (playing an HD video
for example).
Target vm is pause after migration,
# info status
VM status: pa
Make for() cycle reusable for the next patch
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c | 21 ++---
1 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index d93bf5a..935bc42 100644
--- a/ta
It prepares for converting "+feature,-feature,feature=foo,feature" into
a set of key,value property pairs that will be applied to CPU by
cpu_x86_set_props().
It separates legacy format parsing from property setting, later it could be
transformed into code that sets global properties for a given CP
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index d8af528..1cb2f08 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1319,13 +1319,7 @@ static int cpu_x86_parse_fe
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 084faeb..0764015 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1334,6 +1334,8 @@ static int cpu_x86_parse_featurest
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 0764015..d8af528 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1338,7 +1338,9 @@ static int cpu_x86_parse_feature
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 1cb2f08..aab5f6f 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1338,8 +1338,7 @@ static int cpu_x86_parse_features
commit 8935499831312 makes cpuid return to guest host's vendor value
instead of built-in one by default if kvm_enabled() == true and allows
to override this behavior if 'vendor' is specified on -cpu command line.
But every time guest calls cpuid to get 'vendor' value, host's value is
read again an
kvm_check_features_against_host() should be called when features can't be
changed
and when features are convereted to properties it would be possible to change
them
until realize time, so correct way is to call kvm_check_features_against_host()
in
x86_cpu_realize()
- calling kvm_check_features
since cpu_def config is not supported anymore and all remaining sources now
always set x86_def_t.vendor[123] fields remove setting default vendor to
simplify future re-factoring.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c | 13 -
1 files change
freeing resources in one place would require setting 'error'
to not NULL, so add some more error reporting before jumping to
exit branch.
Signed-off-by: Igor Mammedov
---
v2:
- add missing 'return -1' on exit if error is not NULL,
Spotted-By: Eduardo Habkost
v3:
- set error
This series is several cleanups, moved out from CPU properties series,
since they do not really depend on CPU properties re-factoring and could
simplify CPU subclasses work as well.
Series doesn't depend on cpu as device or any other series, and applies
to current master.
git tree for testing:
On Thu, Dec 27, 2012 at 03:33:04PM +0100, Igor Mammedov wrote:
> On Fri, 21 Dec 2012 11:50:26 -0200
> Eduardo Habkost wrote:
>
> > On Fri, Dec 21, 2012 at 01:56:56AM +0100, Igor Mammedov wrote:
> > [...]
> > > > All above said, I am not strongly against your approach, but I believe
> > > > we cou
On Fri, 21 Dec 2012 11:50:26 -0200
Eduardo Habkost wrote:
> On Fri, Dec 21, 2012 at 01:56:56AM +0100, Igor Mammedov wrote:
> [...]
> > > All above said, I am not strongly against your approach, but I believe
> > > we could try to make the feature string parsing code generic and
> > > reusable (wi
> -Original Message-
> From: Alexander Graf [mailto:ag...@suse.de]
> Sent: Monday, December 17, 2012 8:09 PM
> To: Bhushan Bharat-R65777
> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Bhushan Bharat-R65777
> Subject: Re: [PATCH 3/3] Enable kvm emulated watchdog
>
>
> On 17.12.2012, a
Il 27/12/2012 05:26, Brad Smith ha scritto:
> Paolo,
>
> As you wrote the fallback code which is used when sem_timedwait() is
> missing could you please take a look at this when you have some time? I
> can test any patches you might come up with.
Can you try this:
diff --git a/util/qemu-thread-p
Before submitting a proper patch, I'd like to hear feedback on the
following proposed change to hw/e1000.c to properly implement
interrupt mitigation.
This is joint work with Vincenzo Maffione and Giuseppe Lettieri (in Cc),
and is a followup to a similar patch i posted in july
https://lists.gnu.o
Because mon_cmds may use info_cmds, so adjust the declare sequence
of them.
Signed-off-by: Wenchao Xia
---
monitor.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index e4d4c59..a392df4 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2422,
This patch change all info call back function to take
additional QDict * parameter, which allow those command
take parameter. Now it is set to NULL at default case.
Signed-off-by: Wenchao Xia
---
v2: rebased, and better doc.
v3: move changelog position.
hmp.c | 36
Now info command takes a table of sub info commands,
and changed do_info() to do_info_help() to do help funtion
only.
Signed-off-by: Wenchao Xia
---
hmp-commands.hx |3 ++-
monitor.c | 22 +-
2 files changed, 3 insertions(+), 22 deletions(-)
diff --git a/hmp-co
These patches enhance HMP to allow it parse 2nd level of commands, such
as info sub command list, which means now foldered command with parameter
is possible.
V2:
Follow the way supposed by Markus, which make the infrastructure knows
there is possible a 2nd level of command exist, instead of a
This patch make parsing of hmp command aware of that it may
have sub command. Also discard simple encapsulation function
monitor_find_command() and qmp_find_cmd().
Signed-off-by: Wenchao Xia
---
monitor.c | 44 +++-
1 files changed, 27 insertions(+), 1
Sorry I forgot to change the version number, pls ignore this serial.
> On Thu, Dec 27, 2012 at 04:56:27PM +0800, Wenchao Xia wrote:
This patch change all info call back function to take
additional QDict * parameter, which allow those command
take parameter. Now it is set to NULL at defaul
> On Thu, Dec 27, 2012 at 04:56:27PM +0800, Wenchao Xia wrote:
This patch change all info call back function to take
additional QDict * parameter, which allow those command
take parameter. Now it is set to NULL at default case.
v2: rebased, and better doc.
Signed-off-by: Wenchao Xia
---
This patch change all info call back function to take
additional QDict * parameter, which allow those command
take parameter. Now it is set to NULL at default case.
Signed-off-by: Wenchao Xia
---
v2: rebased, and better doc.
v3: move changelog position.
hmp.c | 36
Because mon_cmds may use info_cmds, so adjust the declare sequence
of them.
Signed-off-by: Wenchao Xia
---
monitor.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index e4d4c59..a392df4 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2422,
This patch make parsing of hmp command aware of that it may
have sub command. Also discard simple encapsulation function
monitor_find_command() and qmp_find_cmd().
Signed-off-by: Wenchao Xia
---
monitor.c | 44 +++-
1 files changed, 27 insertions(+), 1
These patches enhance HMP to allow it parse 2nd level of commands, such
as info sub command list, which means now foldered command with parameter
is possible.
V2:
Follow the way supposed by Markus, which make the infrastructure knows
there is possible a 2nd level of command exist, instead of a
On Thu, Dec 27, 2012 at 04:56:27PM +0800, Wenchao Xia wrote:
> This patch change all info call back function to take
> additional QDict * parameter, which allow those command
> take parameter. Now it is set to NULL at default case.
>
> v2: rebased, and better doc.
>
> Signed-off-by: Wenchao Xia
Now info command takes a table of sub info commands,
and changed do_info() to do_info_help() to do help funtion
only.
Signed-off-by: Wenchao Xia
---
hmp-commands.hx |3 ++-
monitor.c | 34 +++---
2 files changed, 9 insertions(+), 28 deletions(-)
diff --
This patch change all info call back function to take
additional QDict * parameter, which allow those command
take parameter. Now it is set to NULL at default case.
v2: rebased, and better doc.
Signed-off-by: Wenchao Xia
---
hmp.c | 36 ++--
This patch make parsing of hmp command aware of that it may
have sub command. Also discard simple encapsulation function
monitor_find_command() and qmp_find_cmd().
Signed-off-by: Wenchao Xia
---
monitor.c | 44 +++-
1 files changed, 27 insertions(+), 1
These patches enhance HMP to allow it parse 2nd level of commands, such
as info sub command list, which means now foldered command with parameter
is possible.
V2:
Follow the way supposed by Markus, which make the infrastructure knows
there is possible a 2nd level of command exist, instead of a
80 matches
Mail list logo
