[Qemu-devel] [PATCH 1/1] atapi: reset cdrom tray statuses on ide_reset

2012-12-10 Thread Pavel Hrdina
Tray statuses should be also reseted. Some guests may lock the tray and after reset before any kernel is loaded the tray should be unlocked. Also if you reset the real computer the tray is closed. We should do the same in qemu. Signed-off-by: Pavel Hrdina --- hw/ide/core.c | 2 ++ 1 file change

Re: [Qemu-devel] [RFC PATCH 0/2] live backup vm

2012-12-10 Thread Dietmar Maurer
OK, I will try to give a short overview on the functionality. First, we decided to use 'internal' snapshots for our 'live snapshot' implementation. Internal snapshots almost always use some kind of reference counting, making snapshot action (like 'create/delete snapshot') quite efficient and fast

[Qemu-devel] [PATCH 1/1] seabios: update to e8a76b0f225bba5ba9d63ab227e0a37b3beb1059

2012-12-10 Thread Gerd Hoffmann
This patch updates seabios to latest git master. Changes: (1) q35 patches merged. (2) some acpi cleanups. (3) fixes irq 8 conflict. (3) makes this a candidate for the stable branch Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann --- pc-bios/acpi-dsdt.aml | Bin 4540 -> 4438

[Qemu-devel] [PULL 0/1] seabios update

2012-12-10 Thread Gerd Hoffmann
Hi, This pull updates seabios, bringing the q35 updates which missed the 1.3 boat and a fix for the winxp bsod due to the irq 8 ressource conflict. please pull, Gerd The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: Merge remote-tracking branch 'afaerber/qom-cpu

Re: [Qemu-devel] [RFC PATCH 0/2] live backup vm

2012-12-10 Thread Wenchao Xia
于 2012-12-10 14:23, Dietmar Maurer 写道: I can do the clean up or rebase from the url you have given, and include them as part of my serials. Just want to avoid conflict between your patch next year and mine by include yours as sub patches. :) That would be great. I have read the code fr

Re: [Qemu-devel] qemu 1.3: windows 2003 SP2 x64 boot crash with hpet enabled (was ok with qemu-kvm 1.2)

2012-12-10 Thread Alexandre DERUMIER
seem to be related to seabios update: seabios: q35 update http://lists.gnu.org/archive/html/qemu-devel/2012-12/msg00113.html - Mail original - De: "Alexandre DERUMIER" À: "qemu-devel" Envoyé: Mardi 11 Décembre 2012 07:30:58 Objet: Re: [Qemu-devel] qemu 1.3: windows 2003 SP2 x64 boot

Re: [Qemu-devel] qemu 1.3: windows 2003 SP2 x64 boot crash with hpet enabled (was ok with qemu-kvm 1.2)

2012-12-10 Thread Alexandre DERUMIER
My bsod screenshot was not full, here a new one: this seem to hang on acpi.sys ACPI.SYS address F735EE64 base at F7352000) I have tested xith host kernel 3.2,26,27 and 2.6.32 from rhel6, same problem. - Mail original - De: "Alexandre DERUMIER" À: "qemu-devel" Envoyé: Lundi 10 Décem

Re: [Qemu-devel] [PATCH v7 00/10] i8254, i8259 and running Microport UNIX (ca 1987)

2012-12-10 Thread Matthew Ogilvie
On Mon, Dec 10, 2012 at 10:47:59AM -0600, Anthony Liguori wrote: > Jan Kiszka writes: > > > On 2012-12-10 06:14, Matthew Ogilvie wrote: > >> On Sun, Nov 25, 2012 at 02:51:36PM -0700, Matthew Ogilvie wrote: > >>> This series makes a series of mostly-unrelated fixes to allow > >>> running an old Mi

Re: [Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c

2012-12-10 Thread Stefan Weil
Am 11.12.2012 02:23, schrieb John Spencer: On 12/10/2012 06:49 PM, Stefan Weil wrote: Am 10.12.2012 07:59, schrieb John Spencer: +#include This is a workaround for a missing declaration of function syscall in musl's unistd.h. See my comment to patch 1 for more information. thanks for not

[Qemu-devel] Network isn't clean when qemu exits

2012-12-10 Thread Amos Kong
In vl.c:main(), tap device would be created when net_init_clients() is called. "device" option is parsed after calling net_init_clients() by: # "qemu_opts_foreach(qemu_find_opts("device"), device_init_func, NULL, 1) Qemu will exit if fails to parse device parameters without calling net_cleanup().

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-12-10 Thread Xu, Dongxiao
> -Original Message- > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > Sent: Saturday, December 08, 2012 12:34 AM > To: Ian Campbell > Cc: Stefano Stabellini; Xu, Dongxiao; xen-de...@lists.xensource.com; > qemu-devel@nongnu.org > Subject: Re: [Xen-devel] [PATCH 0/2] QEMU/xen: simplif

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-10 Thread Dietmar Maurer
Can't we enable stat queries by default (10s interval), and simply return all stats with one API call (query-ballon)? That qom-get interface forces me to do 6 API calls to get all information! > -Original Message- > From: qemu-devel-bounces+dietmar=proxmox@nongnu.org > [mailto:qemu-

[Qemu-devel] [PATCH 2/2] target-i386: replace cpuid_*features fields with a feature word array

2012-12-10 Thread Eduardo Habkost
This replaces the feature-bit fields on both X86CPU and x86_def_t structs with arrays. With this, we will be able to simplify code that simply repeats the same operation on all feature words (e.g. kvm_check_features_against_host(), filter_features_for_kvm(), and CPU feature-bit property lookup/reg

[Qemu-devel] [PATCH 1/2] target-i386: add EXT2_PPRO_FEATURES #define

2012-12-10 Thread Eduardo Habkost
Instead of repeating the (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) expression everywhere, use EXT2_PPRO_FEATURES. Signed-off-by: Eduardo Habkost --- I have done this only to help me keep my sanity while redoing the 80-column line-wrap in the next patch. --- target-i386/cpu.c | 13 +++-- 1

[Qemu-devel] [PATCH 0/2] replace cpuid_*features fields with a featue word array

2012-12-10 Thread Eduardo Habkost
I was planning to implement this only after we finished the rest of the work, the changes are a bit intrusive. But now it looks like the CPUID feature bits are getting into our way (e.g. the feature word array will allow us to simplify the -cpu host and -cpu check/enforce code a lot, making it easi

Re: [Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c

2012-12-10 Thread John Spencer
On 12/10/2012 06:49 PM, Stefan Weil wrote: Am 10.12.2012 07:59, schrieb John Spencer: +#include This is a workaround for a missing declaration of function syscall in musl's unistd.h. See my comment to patch 1 for more information. thanks for noticing! fixed in musl: http://git.musl-libc.

Re: [Qemu-devel] [PATCH 3/4] virtio: modify savevm to have a stable wire format

2012-12-10 Thread Anthony Liguori
Rusty Russell writes: > Anthony Liguori writes: >> We were memcpy()'ing a structure to the wire :-/ Since savevm really >> only works on x86 today, lets just declare that this element is sent >> over the wire as a little endian value in order to fix the bitness. >> >> Unfortunately, we also sen

Re: [Qemu-devel] [PATCH 3/4] virtio: modify savevm to have a stable wire format

2012-12-10 Thread Rusty Russell
Anthony Liguori writes: > We were memcpy()'ing a structure to the wire :-/ Since savevm really > only works on x86 today, lets just declare that this element is sent > over the wire as a little endian value in order to fix the bitness. > > Unfortunately, we also send raw pointers and size_t which

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/19] openpic: add Shared MSI support

2012-12-10 Thread Scott Wood
On 12/08/2012 07:44:39 AM, Alexander Graf wrote: The OpenPIC allows MSI access through shared MSI registers. Implement them for the MPC8544 MPIC, so we can support MSIs. Signed-off-by: Alexander Graf --- hw/openpic.c | 150 ++ 1 files

[Qemu-devel] [Bug 602336] Re: bad network performance with 10Gbit

2012-12-10 Thread john fisher
Depending on your networking hardware, you may need to use a virtual function to access the 10G from a guest. On mine, failing to set up the xml file correctly resulted in a NAT connection or a bridge connection instead of the full-speed connection. This requires libvirt 1.0x BTW. the xml that wo

[Qemu-devel] [PATCH 2/2] target-i386: make cpu_x86_create() get Error argument

2012-12-10 Thread Eduardo Habkost
Instead of forcing the caller to guess what went wrong while creating the CPU object, return error information in a Error argument. Also, as cpu_x86_create() won't print error messages itself anymore, change cpu_x86_init() to print any error returned by cpu_x86_create() or cpu_x86_realize(). Sign

[Qemu-devel] [PATCH 0/2] target-i386: move CPU object creation to cpu.c

2012-12-10 Thread Eduardo Habkost
This small series moves the X86CPU object creation to the cpu.c code, as the object creation will depend on the CPU class lookup, that will be done inside cpu.c. I expect this to make the x86 CPU subclass work simpler. Maybe it will help simplify some of the CPU properties work, too. Eduardo Habk

[Qemu-devel] [PATCH 1/2] target-i386: move CPU object creation to cpu.c

2012-12-10 Thread Eduardo Habkost
As we will need to create the CPU object after splitting the CPU model string (because we're going to use different subclasses for each CPU model), move the CPU object creation to cpu_x86_register(), and at the same time rename cpu_x86_register() to cpu_x86_create(). This will also simplify the CP

Re: [Qemu-devel] [PATCH 3/8] s390: I/O interrupt and machine check injection.

2012-12-10 Thread Rob Landley
What do you actually use to run Linux under this target? There are some leads at http://virtuallyfun.superglobalmegacorp.com/?p=1206 which more or less leads to http://ftp.nl.debian.org/debian/dists/Debian6.0.6/main/installer-s390/current/images/generic/ but I dunno what qemu command line wou

Re: [Qemu-devel] [PATCH 14/19] openpic: convert to qdev

2012-12-10 Thread Scott Wood
On 12/08/2012 07:44:37 AM, Alexander Graf wrote: This patch converts the OpenPIC device to qdev. Along the way it renames the "openpic" target to "raven" and the "mpic" target to "mpc8544", to better reflect the actual models they implement. This way we have a generic OpenPIC device now that can

[Qemu-devel] buildbot failure in qemu on block_x86_64_debian_6_0

2012-12-10 Thread qemu
The Buildbot has detected a new failure on builder block_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_x86_64_debian_6_0/builds/476 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Buil

Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/19] mpic: Unify numbering scheme

2012-12-10 Thread Scott Wood
On 12/08/2012 07:44:25 AM, Alexander Graf wrote: MPIC interrupt numbers in Linux (device tree) and in QEMU are different, because QEMU takes the sparseness of the IRQ number space into account. Remove that cleverness and instead assume a flat number space. This makes the code easier to und

[Qemu-devel] buildbot failure in qemu on block_i386_debian_6_0

2012-12-10 Thread qemu
The Buildbot has detected a new failure on builder block_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_i386_debian_6_0/builds/476 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Re

Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?)

2012-12-10 Thread Rusty Russell
Anthony Liguori writes: > Rusty Russell writes: > >> "Michael S. Tsirkin" writes: >> >> No, because I don't understand it. Is it true for the case of >> virtio_blk, which has outstanding requests? >> Currently we dump a massive structure; it's inelegant at the very least. > > Inelega

Re: [Qemu-devel] [Qemu-ppc] [PATCH 10/19] openpic: remove unused type variable

2012-12-10 Thread Scott Wood
On 12/08/2012 07:44:33 AM, Alexander Graf wrote: The openpic source irqs are carrying around a type indicator that is never accessed by anything. Remove it. Signed-off-by: Alexander Graf --- hw/openpic.c | 27 ++- 1 files changed, 2 insertions(+), 25 deletions(-) dif

Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/19] mpic: Unify numbering scheme

2012-12-10 Thread Scott Wood
On 12/10/2012 05:34:19 PM, Scott Wood wrote: On 12/08/2012 07:44:25 AM, Alexander Graf wrote: /* Interrupt definitions */ -#define MPIC_EXT_IRQ 0 -#define MPIC_INT_IRQ (MPIC_EXT_IRQ + MPIC_MAX_EXT) -#define MPIC_TMR_IRQ (MPIC_INT_IRQ + MPIC_MAX_INT) -#define MPIC_MSG_IRQ (MP

Re: [Qemu-devel] [PATCH qom-cpu 3/4] Really finally kill cpudef config section support

2012-12-10 Thread Eduardo Habkost
On Tue, Dec 11, 2012 at 12:12:23AM +0100, Andreas Färber wrote: > Am 10.12.2012 19:09, schrieb Eduardo Habkost: > > On Sun, Dec 09, 2012 at 08:45:52PM +0100, Andreas Färber wrote: > >> Commit 511c68d3af626cb0a39034cb77e7ac64d3a26c0c (finally kill cpudef > >> config section support) removed the cpud

Re: [Qemu-devel] [PATCH qom-cpu 1/4] target-i386: Inline -cpu host check into cpu_x86_register()

2012-12-10 Thread Eduardo Habkost
On Tue, Dec 11, 2012 at 12:21:10AM +0100, Andreas Färber wrote: > Am 10.12.2012 19:55, schrieb Igor Mammedov: > > On Mon, 10 Dec 2012 10:46:13 -0200 > > Eduardo Habkost wrote: > > > >> On Sun, Dec 09, 2012 at 08:45:50PM +0100, Andreas Färber wrote: > >>> Simplifies the upcoming cleanup of cpu_x86

[Qemu-devel] [RFC qom-cpu v2 2/2] target-i386: Turn Haswell into subclass of SandyBridge

2012-12-10 Thread Andreas Färber
ehabkost: "When adding the Haswell CPU model, I intended to make it a superset of the features present on the SandyBridge model" Inherit from SandyBridge to keep only the delta for Haswell. Signed-off-by: Andreas Färber Cc: Eduardo Habkost --- target-i386/cpu.c | 24 ++---

Re: [Qemu-devel] [PATCH qom-cpu 1/4] target-i386: Inline -cpu host check into cpu_x86_register()

2012-12-10 Thread Andreas Färber
Am 10.12.2012 19:55, schrieb Igor Mammedov: > On Mon, 10 Dec 2012 10:46:13 -0200 > Eduardo Habkost wrote: > >> On Sun, Dec 09, 2012 at 08:45:50PM +0100, Andreas Färber wrote: >>> Simplifies the upcoming cleanup of cpu_x86_find_by_name(). >> >> ...by making cpu_x86_register() more complicated, and

Re: [Qemu-devel] [PATCH qom-cpu 3/4] Really finally kill cpudef config section support

2012-12-10 Thread Andreas Färber
Am 10.12.2012 19:09, schrieb Eduardo Habkost: > On Sun, Dec 09, 2012 at 08:45:52PM +0100, Andreas Färber wrote: >> Commit 511c68d3af626cb0a39034cb77e7ac64d3a26c0c (finally kill cpudef >> config section support) removed the cpudef parsing support but left >> cpudef_* hooks behind. Remove those. > >

[Qemu-devel] [RFC qom-cpu v2 0/2] target-i386: X86CPU subclasses

2012-12-10 Thread Andreas Färber
Hello, Had some long train rides today, so here's a new throw at X86CPU subclasses: After having initially proposed a "minimal" conversion by reusing the list/array of CPU definitions, public opinion seems to have shifted from preferring initfns to preferring class_inits. Combined with per-type Ty

[Qemu-devel] [PATCH 0/2 v2] introduce visitor for parsing suffixed integer

2012-12-10 Thread Igor Mammedov
v2: * Naming changes: - s/visit_type_uint_suffixed_int/visit_type_suffixed_int/ - use 'suffix_factor' instead of 'unit' * Added documentation to visit_type_suffixed_int() * Fixed errp check. * Style fixes Reference to previous version dicussion: http://lists.gnu.org/archive/html/q

[Qemu-devel] [PATCH 1/2] add visitor for parsing int[KMGT] input string

2012-12-10 Thread Igor Mammedov
Caller of visit_type_suffixed_int() have to specify value of 'K' suffix using suffix_factor argument. Example of selecting suffix_factor value: * Kbytes: 1024 * Khz: 1000 Signed-off-by: Igor Mammedov --- v3: - Fix errp check. Spotted-By: Andreas Färber - s/type_unit_suffixed_int/type_suff

[Qemu-devel] [PATCH 2/2] target-i386: use visit_type_suffixed_int() to parse tsc_freq property value

2012-12-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v3: - s/visit_type_unit_suffixed_int/visit_type_suffixed_int/ v2: - replace visit_type_freq() with visit_type_unit_suffixed_int() in x86_cpuid_set_tsc_freq() --- target-i386/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value

2012-12-10 Thread Igor Mammedov
On Fri, 07 Dec 2012 20:00:09 +0100 Andreas Färber wrote: > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > Signed-off-by: Igor Mammedov > > --- > > v2: > >- replace visit_type_freq() with visit_type_unit_suffixed_int() > > in x86_cpuid_set_tsc_freq() > > --- > > target-i386/cpu.c | 2

Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?)

2012-12-10 Thread Michael S. Tsirkin
On Wed, Dec 05, 2012 at 01:08:07PM +0200, Michael S. Tsirkin wrote: > Add sanity check to address the following concern: > > On Wed, Dec 05, 2012 at 09:47:22AM +1030, Rusty Russell wrote: > > All we need is the index of the request; the rest can be re-read from > > the ring. > > I'd like to point

[Qemu-devel] [Bug 1088617] [NEW] qemu-system-mipsel save/restore broken

2012-12-10 Thread Brendan Dolan-Gavitt
Public bug reported: Save and restore on mipsel seems to be broken (tested with commit 1c97e303d4ea80a2691334b0febe87a50660f99d). To reproduce: 1. Download debian_squeeze_mipsel_standard.qcow2 and vmlinux-2.6.32-5 -4kc-malta from from http://people.debian.org/~aurel32/qemu/mipsel/ 2. Boot the sy

[Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats

2012-12-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- docs/virtio-balloon-stats.txt | 87 +++ 1 file changed, 87 insertions(+) create mode 100644 docs/virtio-balloon-stats.txt diff --git a/docs/virtio-balloon-stats.txt b/docs/virtio-balloon-stats.txt new file mode 100644 in

[Qemu-devel] [PATCH 1/3] virtio-balloon: drop old stats code

2012-12-10 Thread Luiz Capitulino
Next commit will re-enable balloon stats with a different interface, but this old code conflicts with it. Drop it. Signed-off-by: Luiz Capitulino --- hw/virtio-balloon.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index dd1

[Qemu-devel] [PATCH 2/3] virtio-balloon: re-enable balloon stats

2012-12-10 Thread Luiz Capitulino
The statistics are now available through device properties via a polling mechanism. First a client has to enable polling, then it can query each stat individually. The following control properties are introduced: o stats-polling-interval: a value greater than zero enables polling in the speci

[Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-10 Thread Luiz Capitulino
This new try to re-enable the virtio-balloon driver stats uses QOM properties via a polling mechanism as suggested by Anthony here: http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02390.html o Changes from the rfc - avoid balloon_stats_poll_cb() and virtio_balloon_handle_output() ru

Re: [Qemu-devel] [PATCH 1/2] cpu_ioreq_pio, cpu_ioreq_move: introduce read_phys_req_item, write_phys_req_item

2012-12-10 Thread Stefano Stabellini
On Mon, 10 Dec 2012, Ian Jackson wrote: > Replace a lot of formulaic multiplications (containing casts, no less) > with calls to a pair of functions. This encapsulates in a single > place the operations which require care relating to integer overflow. > > Cc: Dongxiao Xu > Cc: Stefano Stabellini

[Qemu-devel] [PATCH 1/1] vfio-pci: Don't use kvm_irqchip_in_kernel

2012-12-10 Thread Alex Williamson
kvm_irqchip_in_kernel() has an architecture specific meaning, so we shouldn't be using it to determine whether to enabled KVM INTx bypass. kvm_irqfds_enabled() seems most appropriate. Also use this to protect our other call to kvm_check_extension() as that explodes when KVM isn't enabled. Signed

[Qemu-devel] [PULL 0/1] vfio-pci: fix kvm disabled path

2012-12-10 Thread Alex Williamson
The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 08:35:15 -0600) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-pci-for-qemu-20121210.0 for you t

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-10 Thread Igor Mammedov
On Mon, 10 Dec 2012 11:27:46 -0600 mdroth wrote: > On Mon, Dec 10, 2012 at 05:01:38PM +0100, Igor Mammedov wrote: > > On Fri, 07 Dec 2012 19:57:35 +0100 > > Andreas Färber wrote: > > > > > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > > > Caller of visit_type_unit_suffixed_int() will have to

Re: [Qemu-devel] [PATCH qom-cpu 1/4] target-i386: Inline -cpu host check into cpu_x86_register()

2012-12-10 Thread Igor Mammedov
On Mon, 10 Dec 2012 10:46:13 -0200 Eduardo Habkost wrote: > On Sun, Dec 09, 2012 at 08:45:50PM +0100, Andreas Färber wrote: > > Simplifies the upcoming cleanup of cpu_x86_find_by_name(). > > ...by making cpu_x86_register() more complicated, and having CPU model > name lookup spread into differen

Re: [Qemu-devel] [PATCH qom-cpu 2/4] target-i386: Drop redundant list of CPU definitions

2012-12-10 Thread Eduardo Habkost
On Sun, Dec 09, 2012 at 08:45:51PM +0100, Andreas Färber wrote: > Since we are no longer parsing cpudefs from config files, only the array > of built-in definitions remains. > > Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost But this probably has to be redone if you remove patch 1/

[Qemu-devel] [RFC PATCH v7 6/8] virtio-blk : Add the virtio-blk device.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 107 +++- hw/virtio-blk.h | 6 2 files changed, 104 insertions(+), 9 deleti

[Qemu-devel] [RFC PATCH v7 3/8] virtio-pci-bus : Introduce virtio-pci-bus.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-pci-bus, which extends virtio-bus. It is used with virtio-pci transport device. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 37 + hw/virtio-pci.h | 19 +-- 2 files changed, 54 insertions(+), 2 d

[Qemu-devel] [RFC PATCH v7 5/8] virtio-device : Refactor virtio-device.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic Create the virtio-device which is abstract. All the virtio-device can extend this class. Signed-off-by: KONRAD Frederic --- hw/virtio.c | 50 +++--- hw/virtio.h | 28 2 files changed, 67 insertions(+

[Qemu-devel] qemu 1.3: windows 2003 SP2 x64 boot crash with hpet enabled (was ok with qemu-kvm 1.2)

2012-12-10 Thread Alexandre DERUMIER
Hi list, I have a bsod when booting windows 2003 SP2 x64 with hpet enabled, with qemu 1.3. (screenshot attached) /usr/bin/kvm -id 9 -chardev socket,id=qmp,path=/var/run/qemu-server/9.qmp,server,nowait -mon chardev=qmp,mode=control -vnc unix:/var/run/qemu-server/9.vnc,x509,password

Re: [Qemu-devel] [PATCH qom-cpu 3/4] Really finally kill cpudef config section support

2012-12-10 Thread Eduardo Habkost
On Sun, Dec 09, 2012 at 08:45:52PM +0100, Andreas Färber wrote: > Commit 511c68d3af626cb0a39034cb77e7ac64d3a26c0c (finally kill cpudef > config section support) removed the cpudef parsing support but left > cpudef_* hooks behind. Remove those. The cpudef_* functions have nothing to do with the cpu

Re: [Qemu-devel] [PULL 0/6] usb patch queue

2012-12-10 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > Flushing the usb patch queue, there are a few bits sent during the > freeze I didn't feel like merging that close to the release, so > merge them now. Series reduces the ehci emulation cpu overhead and > allows to connect the usb tablet to ehci. > > please pull,

[Qemu-devel] [PATCH 2/2] cpu_ioreq_pio, cpu_ioreq_move: i should be uint32_t rather than int

2012-12-10 Thread Ian Jackson
The current code compare i (int) with req->count (uint32_t) in a for loop, risking an infinite loop if req->count is equal to UINT_MAX. Also i is only used in comparisons or multiplications with unsigned integers. Signed-off-by: Stefano Stabellini Cc: Dongxiao Xu Cc: Stefano Stabellini Signed-

[Qemu-devel] [PATCH 1/2] cpu_ioreq_pio, cpu_ioreq_move: introduce read_phys_req_item, write_phys_req_item

2012-12-10 Thread Ian Jackson
Replace a lot of formulaic multiplications (containing casts, no less) with calls to a pair of functions. This encapsulates in a single place the operations which require care relating to integer overflow. Cc: Dongxiao Xu Cc: Stefano Stabellini Signed-off-by: Ian Jackson --- xen-all.c | 73

[Qemu-devel] [PATCH 0/2] cpu_ioreq_pio, cpu_ioreq_move: simply and fix

2012-12-10 Thread Ian Jackson
These two patches fix a potential infinite loop if an ioreq has a very large count, and also simplifies the code.

Re: [Qemu-devel] [PULL] VirtFS update

2012-12-10 Thread Anthony Liguori
"Aneesh Kumar K.V" writes: > The following changes since commit 16c6c80ac3a772b42a87b77dfdf0fdac7c607b0e: > > Open up 1.4 development branch (2012-12-03 14:08:40 -0600) > > are available in the git repository at: > > git://github.com/kvaneesh/qemu.git for-upstream > > for you to fetch changes

Re: [Qemu-devel] [PATCH] finally kill cpudef config section support

2012-12-10 Thread Eduardo Habkost
On Sat, Dec 08, 2012 at 07:02:39PM +0100, Andreas Färber wrote: > Am 08.12.2012 18:54, schrieb Blue Swirl: > > Thanks, applied. > > As discussed this still leaves some cpudef cruft behind. > > Eduardo, can you please send a follow-up to move the versioning code and > kills all cpudef_*(), now tha

Re: [Qemu-devel] [PATCH V17 5/6] add-cow file format core code.

2012-12-10 Thread Kevin Wolf
Am 06.12.2012 07:51, schrieb Dong Xu Wang: > add-cow file format core code. It use block-cache.c as cache code. > It lacks of snapshot_blkdev support. > > v16->v17: > 1) Use stringify. > > v15->v16: > 1) Judge if opts is null in add_cow_create function. > > Signed-off-by: Dong Xu Wang > --- >

[Qemu-devel] [RFC PATCH v7 8/8] virtio-blk : QOM modifications.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic As the virtio-blk-pci is switched to the new API, we can use QOM casts and remove the separate init for the old API. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 69 ++--- 1 file changed, 26 insertions(+), 43 del

Re: [Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c

2012-12-10 Thread Stefan Weil
Am 10.12.2012 07:59, schrieb John Spencer: Signed-off-by: John Spencer --- linux-user/syscall.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 31d5276..fabbcd7 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscal

Re: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-10 Thread Stefan Weil
Am 10.12.2012 07:59, schrieb John Spencer: this declaration is wrong: the correct prototype on linux is: int setgroups(size_t size, const gid_t *list); since by default musl libc exposes this symbol in unistd.h additionally to grp.h, the wrong declaration causes a build error. the proper fix is

[Qemu-devel] [PATCH 2/2] qemu-img: add json output option to the check command

2012-12-10 Thread Federico Simoncelli
This option --output=[human|json] make qemu-img check output an human or JSON representation at the choice of the user. Signed-off-by: Federico Simoncelli --- qapi-schema.json | 38 + qemu-img-cmds.hx |4 +- qemu-img.c | 246 +++---

Re: [Qemu-devel] [PATCH 2/4] fix build error on ARM due to wrong glibc check

2012-12-10 Thread Stefan Weil
Am 10.12.2012 07:59, schrieb John Spencer: the test for glibc< 2 "succeeds" wrongly for any non-glibc C library, and breaks the build on musl libc. we must first test if __GLIBC__ is defined at all, before using it unconditionally. Signed-off-by: John Spencer --- user-exec.c |2 +- 1 fi

Re: [Qemu-devel] [PATCH 1/4] fix implicit declaration of syscall() in linux-user/mmap.c

2012-12-10 Thread Stefan Weil
Am 10.12.2012 07:59, schrieb John Spencer: on glibc, this header is getting pulled in automatically via another header, however on musl we need to include it explicitly. linux-user/mmap.c:705:9: warning: implicit declaration of function 'syscall' linux-user/mmap.c:705:9: warning: nested extern d

Re: [Qemu-devel] Some patch about mips, gen_HILO bug fix.

2012-12-10 Thread Richard Henderson
On 12/10/2012 12:37 AM, Elta Era wrote: > tcg_gen_movi_tl(cpu_gpr[ret], \ > -(target_long)((int32_t)imm << 16 | \ > +(target_long)(int32_t)((int32_t)imm << 16 | \ > (uint32_t)(uint16_t)

[Qemu-devel] [RFC PATCH v7 0/8] Virtio refactoring.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic You can clone that from here : git.greensocs.com/home/greensocs/git/qemu_virtio.git virtio_refactoring_v7 These are the two last steps of refactoring ( only for virtio-blk device. ): * It modifies virtio-blk-pci to extend virtio-pci and to connect a virtio-blk du

[Qemu-devel] [PATCHv2 1/2] qemu-img: find the highest offset in use during check

2012-12-10 Thread Federico Simoncelli
This patch adds the support for reporting the highest offset in use by an image. This is particularly useful after a conversion (or a rebase) where the destination is a block device in order to find the actual amount of space in use. Signed-off-by: Federico Simoncelli --- block.h

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-10 Thread mdroth
On Mon, Dec 10, 2012 at 05:01:38PM +0100, Igor Mammedov wrote: > On Fri, 07 Dec 2012 19:57:35 +0100 > Andreas Färber wrote: > > > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > > Caller of visit_type_unit_suffixed_int() will have to specify > > > value of 'K' suffix via unit argument. > > > For

Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value

2012-12-10 Thread mdroth
On Mon, Dec 10, 2012 at 05:13:45PM +0100, Igor Mammedov wrote: > On Fri, 7 Dec 2012 18:09:06 -0200 > Eduardo Habkost wrote: > > > On Fri, Dec 07, 2012 at 08:00:09PM +0100, Andreas Färber wrote: > > > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > > > Signed-off-by: Igor Mammedov > > > > --- > >

[Qemu-devel] [PATCH v2] tcg-i386: Perform cmov detection at runtime for 32-bit.

2012-12-10 Thread Richard Henderson
Cc: Aurelien Jarno Cc: Peter Maydell Signed-off-by: Richard Henderson --- configure | 19 +++ tcg/i386/tcg-target.c | 31 ++- tcg/i386/tcg-target.h | 5 - 3 files changed, 49 insertions(+), 6 deletions(-) Changes v1->v2: * Configur

[Qemu-devel] [RFC PATCH v7 4/8] virtio-pci : Refactor virtio-pci device.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic Create the virtio-pci device. This transport device will create a virtio-pci-bus, so one VirtIODevice can be connected. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 127 hw/virtio-pci.h | 19 + 2 fi

Re: [Qemu-devel] [PATCH qom-cpu v2 0/5] target-alpha: CPU subclasses

2012-12-10 Thread Richard Henderson
On 12/08/2012 05:40 PM, Andreas Färber wrote: > Andreas Färber (5): > target-alpha: Let cpu_alpha_init() return AlphaCPU > alpha: Pass AlphaCPU array to Typhoon > target-alpha: Avoid leaking the alarm timer over reset > target-alpha: Turn CPU definitions into subclasses > target-alpha: Ad

Re: [Qemu-devel] [PATCH V17 6/6] qemu-iotests: add add-cow iotests support.

2012-12-10 Thread Kevin Wolf
Am 06.12.2012 07:51, schrieb Dong Xu Wang: > This patch will use qemu-iotests to test add-cow file format. > > Signed-off-by: Dong Xu Wang > --- > tests/qemu-iotests/017 |2 +- > tests/qemu-iotests/020 |2 +- > tests/qemu-iotests/common|6 ++ > tests/qemu-iotests/

Re: [Qemu-devel] [PATCH V17 4/6] rename qcow2-cache.c to block-cache.c

2012-12-10 Thread Kevin Wolf
Am 06.12.2012 07:51, schrieb Dong Xu Wang: > We will re-use qcow2-cache as block layer common cache code, > so change its name and made some changes, define a struct named > BlockTableType, pass BlockTableType and table size parameters to > block cache initialization function. > > Signed-off-by: D

[Qemu-devel] [PATCH v2] kvm: Detect number of available memory slots from the host kernel

2012-12-10 Thread Alex Williamson
The kernel already exposes an interface for this, x86 returns a proper value and for the rest we can default to the defacto standard of 32. The primary motivation for this is to support more PCI assigned devices, both through pci-assign and vfio-pci. Signed-off-by: Alex Williamson --- v2: Test (!

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-06

2012-12-10 Thread Paolo Bonzini
Il 10/12/2012 17:57, Anthony Liguori ha scritto: > Andreas Färber writes: > >> Hello, >> >> This is my current QOM CPU patch queue. Please pull. >> >> Regards, >> Andreas > > Pulled. Thanks. Thanks, I'll rebase the directory stuff as soon as possible, please help reviewing it in the meantime! :

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-12-10 Thread Ian Jackson
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move"): > On Fri, 7 Dec 2012, Ian Jackson wrote: ... > > +if (req->df) addr -= offset; > > +else addr -= offset; > > This can't be right, can it? Indeed not. v2 has this fixed. > The

Re: [Qemu-devel] [PULL 00/18] acpi: switch to memory api

2012-12-10 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > Same patches as posted last week. No review comments, 1.4 tree > open, so it should be ready to go in now. > > cheers, > Gerd > > The following changes since commit 16c6c80ac3a772b42a87b77dfdf0fdac7c607b0e: > > Open up 1.4 development branch (2012-12-03 14:0

Re: [Qemu-devel] [PULL 00/13] Trivial patches for 2 to 7 November

2012-12-10 Thread Anthony Liguori
Stefan Hajnoczi writes: > These patches were mostly submitted during the 1.3 hard freeze. I'll catch up > with the new trivial patches next week. > > The following changes since commit 80625b97b52836b944a6438e8e3e9d992e6a00b6: > > xilinx_uartlite: Accept input after rx FIFO pop (2012-12-05 09:

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-06

2012-12-10 Thread Anthony Liguori
Andreas Färber writes: > Hello, > > This is my current QOM CPU patch queue. Please pull. > > Regards, > Andreas Pulled. Thanks. Regards, Anthony Liguori > > Cc: Eduardo Habkost > Cc: Igor Mammedov > Cc: Paolo Bonzini > > > The following changes since commit 19e6c50d2d843220efbdd3b2db21d83c

Re: [Qemu-devel] [PULL] Memory API ioport cleanups

2012-12-10 Thread Anthony Liguori
Andreas Färber writes: > Hello, > > As coordinated with Avi and Gerd, here's some ioport conversions to Memory > API. > > Cc: Avi Kivity > Cc: Gerd Hoffmann > Cc: Julien Grall > Cc: Jason Baron > > Pulled. Thanks. Regards, Anthony Liguori > The following changes since commit 16c6c80ac3a7

Re: [Qemu-devel] [PATCH v7 00/10] i8254, i8259 and running Microport UNIX (ca 1987)

2012-12-10 Thread Anthony Liguori
Jan Kiszka writes: > On 2012-12-10 06:14, Matthew Ogilvie wrote: >> On Sun, Nov 25, 2012 at 02:51:36PM -0700, Matthew Ogilvie wrote: >>> This series makes a series of mostly-unrelated fixes to allow >>> running an old Microport UNIX (ca 1987) guest under qemu. >>> >>> Changes since version 6: >>>

[Qemu-devel] [PATCH] xen: fix trivial PCI passthrough MSI-X bug

2012-12-10 Thread Stefano Stabellini
We are currently passing entry->data as address parameter. Pass entry->addr instead. Signed-off-by: Stefano Stabellini Tested-by: Sander Eikelenboom Xen-devel: http://marc.info/?l=xen-devel&m=135515462613715 diff --git a/hw/xen_pt_msi.c b/hw/xen_pt_msi.c index 6807672..db757cd 100644 --- a/hw/x

[Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-pci is modified for the new API. The device virtio-pci-blk extends virtio-pci. It creates and connects a virtio-blk during the init. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 113 +++- hw/v

[Qemu-devel] [RFC PATCH v7 2/8] virtio-bus : Introduce virtio-bus

2012-12-10 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-bus. Refactored transport device will create a bus which extends virtio-bus. Signed-off-by: KONRAD Frederic --- hw/Makefile.objs | 1 + hw/virtio-bus.c | 120 +++ hw/virtio-bus.h | 83 ++

[Qemu-devel] [RFC PATCH v7 1/8] qdev : add a maximum device allowed field for the bus.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic Add a max_dev field to BusState to specify the maximum amount of devices allowed on the bus ( have no effect if max_dev=0 ) Signed-off-by: KONRAD Frederic --- hw/qdev-core.h| 2 ++ hw/qdev-monitor.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/hw

[Qemu-devel] What is the current state of the various usb implementations?

2012-12-10 Thread tom289332
Hello, I sent this to qemu-discuss a week ago and got no responses, so I'm trying here. Looking at `qemu-kvm -device ?`, there seem to be multiple usb implementations: ich9-usb-uhci2 ich9-usb-uhci3 ich9-usb-uhci1 piix3-usb-uhci piix4-usb-uhci vt82c686b-usb-uhci ich9-usb-ehci1 usb-ehci nec-usb-xhc

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-10 Thread Busch, Keith
On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi wrote: > Quick pointers to get started on Kevin's suggestion: > > bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and > bdrv_aio_discard() provide the block device operations that emulated > storage controllers use. > > Take a look at hw/vi

[Qemu-devel] [PATCH] target-mips: Use EXCP_SC rather than a magic number

2012-12-10 Thread Wei-Ren Chen
From the discussion on the ML [1], the exception limit defined by magic number 0x100 is actually EXCP_SC defined in cpu.h. Replace the magic number with EXCP_SC. Remove "#if 1 .. #endif" as well. [1] http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg03080.html Signed-off-by: Chen Wei-Ren

Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value

2012-12-10 Thread Igor Mammedov
On Fri, 7 Dec 2012 18:09:06 -0200 Eduardo Habkost wrote: > On Fri, Dec 07, 2012 at 08:00:09PM +0100, Andreas Färber wrote: > > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > > Signed-off-by: Igor Mammedov > > > --- > > > v2: > > >- replace visit_type_freq() with visit_type_unit_suffixed_i

Re: [Qemu-devel] Some patch about mips, gen_HILO bug fix.

2012-12-10 Thread Jovanovic, Petar
> 0002-Make-repl_ph-to-sign-extended-to-target_long.patch > 0003-Fix-gen_HILO-to-make-it-adapt-each-arch-which-use-ac.patch Can you send examples/tests for the issues that you fix? It makes easier to review if you provide a simple example of a failing test. Petar

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-12-10 Thread Stefano Stabellini
On Fri, 7 Dec 2012, Ian Jackson wrote: > Stefano Stabellini writes ("[Xen-devel] [PATCH 0/2] QEMU/xen: simplify > cpu_ioreq_pio and cpu_ioreq_move"): > > after reviewing the patch "fix multiply issue for int and uint types" > > with Ian Jackson, we realized that cpu_ioreq_pio and cpu_ioreq_move ar

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-10 Thread Igor Mammedov
On Fri, 07 Dec 2012 19:57:35 +0100 Andreas Färber wrote: > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > Caller of visit_type_unit_suffixed_int() will have to specify > > value of 'K' suffix via unit argument. > > For Kbytes it's 1024, for Khz it's 1000. > > > > Signed-off-by: Igor Mammedov >

  1   2   >