On Sun, Dec 09, 2012 at 08:45:52PM +0100, Andreas Färber wrote: > Commit 511c68d3af626cb0a39034cb77e7ac64d3a26c0c (finally kill cpudef > config section support) removed the cpudef parsing support but left > cpudef_* hooks behind. Remove those.
The cpudef_* functions have nothing to do with the cpudef config section since QEMU 1.2, it is just about initializing CPU-definition-related data structures, so the patch subject is a bit misleading. But I agree with the changes done here, and patch looks good to me, so: Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> > > Since TYPE_X86_CPU currently is the only CPU class and CPUs are > instantiated exclusively through QOM (i.e., cpu_x86_init()), we can use > its class_init to bootstrap the list of model definitions until we have > these as subclasses. Avoid code movements for x86_cpudef_setup() to not > interfere with the various approaches to drop it in favor of subclasses. > > Signed-off-by: Andreas Färber <afaer...@suse.de> > Cc: Eduardo Habkost <ehabk...@redhat.com> > Cc: Blue Swirl <blauwir...@gmail.com> > --- > arch_init.c | 7 ------- > arch_init.h | 1 - > bsd-user/main.c | 3 --- > linux-user/main.c | 3 --- > target-i386/cpu.c | 7 ++++++- > target-i386/cpu.h | 2 -- > vl.c | 7 ------- > 7 Dateien geändert, 6 Zeilen hinzugefügt(+), 24 Zeilen entfernt(-) > [...] -- Eduardo