[Qemu-devel] [PATCH 10/15] pseries: Allow RTAS tokens without a qemu handler

2012-10-17 Thread David Gibson
From: Ben Herrenschmidt Kernel-based RTAS calls will not have a qemu handler, but will still be registered in qemu in order to be assigned a token number and appear in the device-tree. Let's test for the name being NULL rather than the handler when deciding to skip an entry while building the de

[Qemu-devel] [PATCH 07/15] pseries: Cleanup duplications of ics_valid_irq() code

2012-10-17 Thread David Gibson
A couple of places in xics.c open-coded the same logic as is already implemented in ics_valid_irq(). This patch fixes the code duplication. Signed-off-by: David Gibson --- hw/xics.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/xics.c b/hw/xics.c index db01fe3.

[Qemu-devel] [PATCH 12/15] pseries: Split xics irq configuration from state information

2012-10-17 Thread David Gibson
Currently the XICS irq controller code has a per-irq state structure which amongst other things includes whether the interrupt is level or message triggered - this is configured by the platform code, and is not directly visible to the guest. This leads to a slightly awkward construct at reset time

[Qemu-devel] [PATCH 13/15] target-pcc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-10-17 Thread David Gibson
Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models to represent a TLB entry contains a target_phys_addr_t. That works reasonably for now, but is troublesome for saving the state, which we'll want to do in future. target_phys_addr_t is a large enough type to contain a physi

[Qemu-devel] [PATCH 08/15] pseries: Move XICS initialization before cpu initialization

2012-10-17 Thread David Gibson
From: Ben Herrenschmidt Currently, the pseries machine initializes the cpus, then the XICS interrupt controller. However, to support the upcoming in-kernel XICS implementation we will need to initialize the irq controller before the vcpus. This patch makes the necesssary rearrangement. This me

[Qemu-devel] [0/15] pseries patch queue

2012-10-17 Thread David Gibson
Hi Alex, Here's the current state of the pseries pending patch queue. Some of these I think you already have, but I've lost track of what's in your tree but not in mainline yet. The biggest thing is the PAPR NVRAM implementation, and the SLOF update to use it. This doesn't yet implement all the

[Qemu-devel] [Bug 1065325] Re: qemu-system-arm hangs on SIGUSR1 on OS X 10.8.2

2012-10-17 Thread Paolo Bonzini
This seems like an OS bug (kernel or Cocoa). The usage of the signal is common to all QEMU system emulation targets, so it's not dependent on Stellaris. Try an older version of OS X, or try a different video backend (e.g. VNC). That may help isolating the problem. -- You received this bug notifi

Re: [Qemu-devel] hdd and ssd passthrough

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 23:20, Mario Giammarco ha scritto: > Hello, > I hope I am in the right list. > I would like to pass a real disk to a guest (freenas) in kvm/qemu without > iommu/vt-d. > > I need guest to be able to: > > - use hdd smart; > - configure hdd params like power saving; > - understand real

Re: [Qemu-devel] [PATCH 13/15] target-pcc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-10-17 Thread Alexander Graf
On 18.10.2012, at 07:50, David Gibson wrote: > Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models > to represent a TLB entry contains a target_phys_addr_t. That works > reasonably for now, but is troublesome for saving the state, which we'll > want to do in future. tar

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-17 Thread Jan Kiszka
On 2012-10-17 22:14, Eduardo Habkost wrote: > On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: > [...] >> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c >> new file mode 100644 >> index 000..8b0d0ff >> --- /dev/null >> +++ b/hw/qdev-properties.c >> @@ -0,0 +1,246 @@ > >

Re: [Qemu-devel] nvram and boot order

2012-10-17 Thread Alexander Graf
On 18.10.2012, at 03:18, Benjamin Herrenschmidt wrote: > On Thu, 2012-10-18 at 11:09 +1100, David Gibson wrote: > That's horrible; if you use -boot just once it will clobber a persistent NVRAM's boot order. I see that a means of changing the default boot order from management

Re: [Qemu-devel] [PATCH v2] pci: Return PCI_INTX_DISABLED when no bus INTx routing support

2012-10-17 Thread Michael S. Tsirkin
On Wed, Oct 17, 2012 at 04:13:12PM -0600, Alex Williamson wrote: > Rather than assert, simply return PCI_INTX_DISABLED when we don't > have a pci_route_irq_fn. PIIX already returns DISABLED for an > invalid pin, so users already deal with this state. Users of this > interface should only be actin

Re: [Qemu-devel] Disabling KVM "on the fly"

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 20:37, Jan Kiszka ha scritto: > On 2012-10-17 18:44, Paolo Bonzini wrote: >> Il 17/10/2012 18:37, Clemens Kolbitsch ha scritto: >>> Guys, >>> >>> I know this is question might seem a bit odd, but I'm curious: >>> >>> Has anyone ever tried to write code to disable KVM on the fly / is i

[Qemu-devel] [PATCH 05/15] pseries: Clean up inconsistent variable name in xics.c

2012-10-17 Thread David Gibson
Throughout xics.c 'nr' is used to refer to a global interrupt number, and 'server' is used to refer to an interrupt server number (i.e. CPU number). Except in icp_set_mfrr(), where 'nr' is used as a server number. Fix this confusing inconsistency. Signed-off-by: David Gibson --- hw/xics.c |

[Qemu-devel] [PATCH 06/15] pseries: Use #define for XICS base irq number

2012-10-17 Thread David Gibson
From: Ben Herrenschmidt Currently the lowest "real" irq number for the XICS irq controller (as opposed to numbers reserved for IPIs and other special purposes) is hard coded as 16 in two places - in xics_system_init() and in spapr.c. As well as being generally bad practice, we're going to need t

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-17 Thread Christian Borntraeger
On 17/10/12 22:14, Eduardo Habkost wrote: > On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: > [...] >> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c >> new file mode 100644 >> index 000..8b0d0ff >> --- /dev/null >> +++ b/hw/qdev-properties.c >> @@ -0,0 +1,246 @@ > > G

[Qemu-devel] [PATCH 02/15] target-ppc: Rework storage of VPA registration state

2012-10-17 Thread David Gibson
With PAPR guests, hypercalls allow registration of the Virtual Processor Area (VPA), SLB shadow and dispatch trace log (DTL), each of which allow for certain communication between the guest and hypervisor. Currently, we store the addresses of the three areas and the size of the dtl in CPUPPCState.

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-17 Thread Gerd Hoffmann
On 10/17/12 22:14, Eduardo Habkost wrote: > On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: > [...] >> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c >> new file mode 100644 >> index 000..8b0d0ff >> --- /dev/null >> +++ b/hw/qdev-properties.c >> @@ -0,0 +1,246 @@ > > G

[Qemu-devel] 1.1.1 -> 1.1.2 migrate / managed save issue

2012-10-17 Thread Doug Goldstein
I'm using libvirt 0.10.2 and I had qemu-kvm 1.1.1 running all my VMs. I used libvirt's managedsave command to pause all the VMs and write them to disk and when I brought up the machine again I had upgraded to qemu-kvm 1.1.2 and attempted to resume the VMs from their state. It unfortunately fails. D

Re: [Qemu-devel] [PATCH v2] pci: Return PCI_INTX_DISABLED when no bus INTx routing support

2012-10-17 Thread Jan Kiszka
On 2012-10-18 00:13, Alex Williamson wrote: > Rather than assert, simply return PCI_INTX_DISABLED when we don't > have a pci_route_irq_fn. PIIX already returns DISABLED for an > invalid pin, so users already deal with this state. Users of this > interface should only be acting on an ENABLED or IN

Re: [Qemu-devel] [PATCH 3/7] serial: add windows inf file for the pci card to docs

2012-10-17 Thread Gerd Hoffmann
On 10/17/12 22:12, Hervé Poussineau wrote: >> Signed-off-by: Gerd Hoffmann > >> --- >> docs/qemupciserial.inf | 109 >> >> 1 files changed, 109 insertions(+), 0 deletions(-) >> create mode 100644 docs/qemupciserial.inf > [...] > > Did you try to

[Qemu-devel] [PATCH v3] qemu-img: document 'info --backing-chain'

2012-10-17 Thread Kashyap Chamarthy
Signed-off-by: Kashyap Chamarthy --- qemu-img-cmds.hx | 4 ++-- qemu-img.texi| 21 - 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index 0ef82e9ac7a89d607e1f2c8e38461cee5b438dba..a18136302d2ca7a7540672f1b9ef89603e89ed

Re: [Qemu-devel] [PATCH v11 01/14] target-mips: Add ASE DSP internal functions

2012-10-17 Thread Aurelien Jarno
On Thu, Oct 18, 2012 at 09:53:20AM +0800, Jia Liu wrote: > Hi Aurelien, > > On Wed, Oct 17, 2012 at 11:15 PM, Aurelien Jarno wrote: > > On Wed, Oct 17, 2012 at 11:39:00AM +0800, Jia Liu wrote: > >> Hi Aurelien, > >> > >> On Wed, Oct 17, 2012 at 7:20 AM, Aurelien Jarno > >> wrote: > >> > On Tue,

[Qemu-devel] [PATCH 03/15] pseries: Implement qemu initiated shutdowns using EPOW events

2012-10-17 Thread David Gibson
At present, using 'system_powerdown' from the monitor or otherwise instructing qemu to (cleanly) shut down a pseries guest will not work, because we did not have a method of signalling the shutdown request to the guest. PAPR does include a usable mechanism for this, though it is rather more involv

Re: [Qemu-devel] [PATCH 14/22] usb: Add packet combining functions

2012-10-17 Thread Gerd Hoffmann
Hi, > For handle_combined_data, yes, as usb_ep_combine_input_packets can > cause multiple packets to get submitted, since if a combined packet > ends with a packet, which does not have its short_not_ok flag set, > another packet can be safely pipelined after it. This is not > useful for usb mass

[Qemu-devel] [PATCH 14/15] pseries: Implement PAPR NVRAM

2012-10-17 Thread David Gibson
The PAPR specification requires a certain amount of NVRAM, accessed via RTAS, which we don't currently implement in qemu. This patch addresses this deficiency, implementing the NVRAM as a VIO device, with some glue to instantiate it automatically based on a machine option. The machine option spec

[Qemu-devel] [PATCH 11/15] pseries: Add tracepoints to the XICS interrupt controller

2012-10-17 Thread David Gibson
This patch adds tracing / debugging calls to the XICS interrupt controller implementation used on the pseries machine. Signed-off-by: Ben Herrenschmidt Signed-off-by: David Gibson --- hw/xics.c| 23 --- trace-events | 13 + 2 files changed, 33 insertions(

[Qemu-devel] [PATCH v2] tcg-i386: Use %gs prefixes for x86_64 GUEST_BASE

2012-10-17 Thread Richard Henderson
When we allocate a reserved_va for the guest, the kernel will likely choose an address well above 4G. At which point we must use a pair of movabsq+addq to form the host address. If we have OS support, set up a segment register to point to guest_base instead. Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH] tcg-i386: Use %gs prefixes for x86_64 GUEST_BASE

2012-10-17 Thread Richard Henderson
When we allocate a reserved_va for the guest, the kernel will likely choose an address well above 4G. At which point we must use a pair of movabsq+addq to form the host address. If we have OS support, set up a segment register to point to guest_base instead. Signed-off-by: Richard Henderson ---

Re: [Qemu-devel] [PATCH v6 3/3] tcg: Optimize qemu_ld/st by generating slow paths at the end of a block

2012-10-17 Thread Yeongkyoon Lee
On 2012년 10월 18일 08:44, Richard Henderson wrote: On 2012-10-16 17:23, Yeongkyoon Lee wrote: +/* Code generation of qemu_ld/st's slow path calling MMU helper + + PRE_PROC ... + call MMU helper + jmp POST_PROC (2b) : short forward jump <- GETRA() + jmp next_code (5b) :

Re: [Qemu-devel] [PATCH v11 01/14] target-mips: Add ASE DSP internal functions

2012-10-17 Thread Jia Liu
Hi Aurelien, On Wed, Oct 17, 2012 at 11:15 PM, Aurelien Jarno wrote: > On Wed, Oct 17, 2012 at 11:39:00AM +0800, Jia Liu wrote: >> Hi Aurelien, >> >> On Wed, Oct 17, 2012 at 7:20 AM, Aurelien Jarno wrote: >> > On Tue, Oct 16, 2012 at 12:39:05AM +0800, Jia Liu wrote: >> >> +/* a[0] is LO, a[1] is

Re: [Qemu-devel] nvram and boot order

2012-10-17 Thread Benjamin Herrenschmidt
On Thu, 2012-10-18 at 11:09 +1100, David Gibson wrote: > > > That's horrible; if you use -boot just once it will clobber a > > > persistent NVRAM's boot order. I see that a means of changing the > > > default boot order from management tools is desirable, but that > > > shouldn't be the normal be

Re: [Qemu-devel] nvram and boot order

2012-10-17 Thread David Gibson
On Wed, Oct 17, 2012 at 01:17:28PM -0500, Anthony Liguori wrote: > David Gibson writes: > > > On Tue, Oct 16, 2012 at 02:55:21PM -0500, Anthony Liguori wrote: > >> > >> We discussed nvram and it's interaction with boot order in today's KVM > >> call. Here's the outcome. This list is completely

Re: [Qemu-devel] [PATCH v11 09/14] target-mips: Add ASE DSP bit/manipulation instructions

2012-10-17 Thread Jia Liu
On Thu, Oct 18, 2012 at 4:07 AM, Aurelien Jarno wrote: > On Wed, Oct 17, 2012 at 05:16:11PM +1000, Richard Henderson wrote: >> On 2012-10-17 16:05, Aurelien Jarno wrote: >> > >> +target_long temp; >> > >> + >> > >> +imm = (ctx->opcode >> 16) & 0xFF; >

Re: [Qemu-devel] [PATCH v6 3/3] tcg: Optimize qemu_ld/st by generating slow paths at the end of a block

2012-10-17 Thread Richard Henderson
On 2012-10-16 17:23, Yeongkyoon Lee wrote: > +/* Code generation of qemu_ld/st's slow path calling MMU helper > + > + PRE_PROC ... > + call MMU helper > + jmp POST_PROC (2b) : short forward jump <- GETRA() > + jmp next_code (5b) : dummy long backward jump which is never

[Qemu-devel] [PATCHv2] qemu: enable PV EOI for qemu 1.3

2012-10-17 Thread Michael S. Tsirkin
Enable KVM PV EOI by default. You can still disable it with -kvm_pv_eoi cpu flag. To avoid breaking cross-version migration, enable only for qemu 1.3 (or in the future, newer) machine type. Signed-off-by: Michael S. Tsirkin --- Changes from v1: Address comments by Eduardo: use includ

[Qemu-devel] [PATCH v2] pci: Return PCI_INTX_DISABLED when no bus INTx routing support

2012-10-17 Thread Alex Williamson
Rather than assert, simply return PCI_INTX_DISABLED when we don't have a pci_route_irq_fn. PIIX already returns DISABLED for an invalid pin, so users already deal with this state. Users of this interface should only be acting on an ENABLED or INVERTED return value (though we really have no suppor

Re: [Qemu-devel] [PATCHv2 1/2] signal: added a wrapper for sigprocmask function

2012-10-17 Thread Alex Barcelo
On Wed, Oct 17, 2012 at 5:01 PM, Peter Maydell wrote: > On 17 October 2012 15:18, Alex Barcelo wrote: >> Create a wrapper for signal mask changes initiated by the guest; >> this will give us a place to put code which prevents the guest >> from changing the handling of signals used by QEMU itself

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2012 at 11:05:22PM +0200, Stefan Weil wrote: > > On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: > > [...] > >> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c > >> new file mode 100644 > >> index 000..8b0d0ff > >> --- /dev/null > >> +++ b/hw/qdev-propert

[Qemu-devel] hdd and ssd passthrough

2012-10-17 Thread Mario Giammarco
Hello, I hope I am in the right list. I would like to pass a real disk to a guest (freenas) in kvm/qemu without iommu/vt-d. I need guest to be able to: - use hdd smart; - configure hdd params like power saving; - understand real make and model of hdd; - understand when the hdd is an ssd. How can

Re: [Qemu-devel] [PATCH] qemu: enable PV EOI for qemu 1.3

2012-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2012 at 10:48:58PM +0200, Michael S. Tsirkin wrote: > On Wed, Oct 17, 2012 at 05:03:02PM -0300, Eduardo Habkost wrote: > > On Wed, Oct 17, 2012 at 09:40:59PM +0200, Michael S. Tsirkin wrote: > > > Enable KVM PV EOI by default. You can still disable it with > > > -kvm_pv_eoi cpu flag

Re: [Qemu-devel] [PATCH 2/2] qemu queue: fix uninitialized removals

2012-10-17 Thread Tim Hardeck
Hi Andreas, On Wednesday 17 October 2012 17:00:15 Andreas Färber wrote: > Tim, > > Am 14.10.2012 15:08, schrieb Tim Hardeck: > > When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list > > QEMU segfaults. > > Can this be reproduced by a user today? Or is this just fixing the case > that

[Qemu-devel] [PATCH] i386/cpu: name new CPUID bits

2012-10-17 Thread Andre Przywara
Update QEMU's knowledge of CPUID bit names. This allows to enable/disable those new features on QEMU's command line when using KVM and prepares future feature enablement in QEMU. This adds F16C, RDRAND, LWP, TBM, TopoExt, PerfCtr_Core, PerfCtr_NB, FSGSBASE, BMI1, AVX2, BMI2, ERMS, InvPCID, RTM, RD

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-17 Thread Stefan Weil
> On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: > [...] >> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c >> new file mode 100644 >> index 000..8b0d0ff >> --- /dev/null >> +++ b/hw/qdev-properties.c >> @@ -0,0 +1,246 @@ > > Gerd, could you clarify what's the copyright

Re: [Qemu-devel] [PATCH] qemu: enable PV EOI for qemu 1.3

2012-10-17 Thread Michael S. Tsirkin
On Wed, Oct 17, 2012 at 05:03:02PM -0300, Eduardo Habkost wrote: > On Wed, Oct 17, 2012 at 09:40:59PM +0200, Michael S. Tsirkin wrote: > > Enable KVM PV EOI by default. You can still disable it with > > -kvm_pv_eoi cpu flag. To avoid breaking cross-version migration, > > enable only for qemu 1.3 or

[Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object

2012-10-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qemu-img.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 12fb6c2..dfde588 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -302,6 +302,7 @@ static int img_create(int argc, char **argv) const char *ba

[Qemu-devel] [PATCH 6/8] qemu-img: img_create(): simplify

2012-10-17 Thread Luiz Capitulino
Drop unneeded goto and ret variable. Signed-off-by: Luiz Capitulino --- qemu-img.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index dfde588..0634402 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -294,7 +294,7 @@ static int add_old_s

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-17 Thread Eduardo Habkost
On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: [...] > diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c > new file mode 100644 > index 000..8b0d0ff > --- /dev/null > +++ b/hw/qdev-properties.c > @@ -0,0 +1,246 @@ Gerd, could you clarify what's the copyright/license of t

[Qemu-devel] [PATCH 3/7] serial: add windows inf file for the pci card to docs

2012-10-17 Thread Hervé Poussineau
> Signed-off-by: Gerd Hoffmann --- docs/qemupciserial.inf | 109 1 files changed, 109 insertions(+), 0 deletions(-) create mode 100644 docs/qemupciserial.inf [...] Did you try to add emulation of a PCI serial card natively recognized by Windo

[Qemu-devel] [PATCH 2/8] block: bdrv_img_create(): add param_list argument

2012-10-17 Thread Luiz Capitulino
If set returns a copy of the parameter list used by the block driver to create the new image. Signed-off-by: Luiz Capitulino --- block.c| 7 ++- block.h| 3 ++- blockdev.c | 2 +- qemu-img.c | 2 +- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c ind

Re: [Qemu-devel] [PATCH v11 09/14] target-mips: Add ASE DSP bit/manipulation instructions

2012-10-17 Thread Aurelien Jarno
On Wed, Oct 17, 2012 at 05:16:11PM +1000, Richard Henderson wrote: > On 2012-10-17 16:05, Aurelien Jarno wrote: > > >> +target_long temp; > > >> + > > >> +imm = (ctx->opcode >> 16) & 0xFF; > > >> +temp = imm; > > >> +

[Qemu-devel] [PATCH 4/8] block: bdrv_img_create(): add Error ** argument

2012-10-17 Thread Luiz Capitulino
This commit adds an Error ** argument to bdrv_img_create() and set it appropriately on error. Callers of bdrv_img_create() pass NULL for the new argument and still rely on bdrv_img_create()'s return value. Next commits will change callers to use the Error object instead. Signed-off-by: Luiz Capit

Re: [Qemu-devel] [PATCH] qemu: enable PV EOI for qemu 1.3

2012-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2012 at 09:40:59PM +0200, Michael S. Tsirkin wrote: > Enable KVM PV EOI by default. You can still disable it with > -kvm_pv_eoi cpu flag. To avoid breaking cross-version migration, > enable only for qemu 1.3 or newer machine type. > > Signed-off-by: Michael S. Tsirkin > --- > hw/

Re: [Qemu-devel] [PATCH v11 09/14] target-mips: Add ASE DSP bit/manipulation instructions

2012-10-17 Thread Richard Henderson
On 2012-10-17 16:05, Aurelien Jarno wrote: > >> +target_long temp; > >> + > >> +imm = (ctx->opcode >> 16) & 0xFF; > >> +temp = imm; > >> +temp = (temp << 8) | temp; > >> +temp = (temp << 16

[Qemu-devel] [PATCH 7/8] qmp: qmp_transaction(): pass Error object to bdrv_img_create()

2012-10-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- blockdev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index 01be90f..af02480 100644 --- a/blockdev.c +++ b/blockdev.c @@ -701,6 +701,7 @@ void qmp_transaction(BlockdevActionList *dev_list, Error **e

[Qemu-devel] [PATCH] block: bdrv_create(): don't leak cco.filename on error

2012-10-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- block.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 5e8184f..63bf768 100644 --- a/block.c +++ b/block.c @@ -379,7 +379,8 @@ int bdrv_create(BlockDriver *drv, const char* filename, }; if (!drv->bd

[Qemu-devel] [PATCH 8/8] block: bdrv_img_create(): drop unused error handling code

2012-10-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- block.c | 41 ++--- block.h | 8 2 files changed, 10 insertions(+), 39 deletions(-) diff --git a/block.c b/block.c index 83bcab5..5e8184f 100644 --- a/block.c +++ b/block.c @@ -4292,10 +4292,10 @@ bdrv_acct_done(Blo

[Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

2012-10-17 Thread Doug Goldstein
Which has also been released. ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/816370 Title: compile error in QEMU 0.15.0-rc0 and 0.1

[Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1

2012-10-17 Thread Doug Goldstein
Fixed by: http://lists.freedesktop.org/archives/spice- devel/2011-January/002259.html ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/816370 Tit

[Qemu-devel] [PATCH] qemu: enable PV EOI for qemu 1.3

2012-10-17 Thread Michael S. Tsirkin
Enable KVM PV EOI by default. You can still disable it with -kvm_pv_eoi cpu flag. To avoid breaking cross-version migration, enable only for qemu 1.3 or newer machine type. Signed-off-by: Michael S. Tsirkin --- hw/pc.h | 2 ++ hw/pc_piix.c | 14 +- target-i386/cpu.c |

[Qemu-devel] [PATCH 3/8] block: bdrv_img_create(): move parameter list printing to qemu-img

2012-10-17 Thread Luiz Capitulino
Today, bdrv_img_create() prints the parameter list used to create the new image to stdout, like this: Formatting '/tmp/a', fmt=qcow2 size=10737418240 encryption=off cluster_size=65536 lazy_refcounts=off As the transaction QMP command calls bdrv_img_create(), this message is also printed when

[Qemu-devel] [PATCH 1/8] error: add error_set_errno and error_setg_errno

2012-10-17 Thread Luiz Capitulino
From: Paolo Bonzini These functions help maintaining homogeneous formatting of error messages that include strerror values. Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- error.c | 28 error.h | 9 + 2 files changed, 37 insertions(+) dif

[Qemu-devel] [PATCH 0/8] block: bdrv_img_create(): propagate errors

2012-10-17 Thread Luiz Capitulino
This series is a first step to propagate errors from bdrv_open(), but it also improves qmp_transaction() error messages on bdrv_img_create() failures plus some other improvements. Please, check individual patches for details. o From the RFC - Better testing - improved changelogs - small simpl

Re: [Qemu-devel] [PATCH 11/12] include core qdev code into *-user, too

2012-10-17 Thread Peter Maydell
On 17 October 2012 19:11, Anthony Liguori wrote: > It's dangerously close to bike-shedding, but i don't think qdev belongs > in qom/. It's not core infrastructure. It's the device base class and > belongs IMHO in hw/. "-user emulators don't get anything from hw/" is one of those semi arbitrary

Re: [Qemu-devel] [PATCH] pci: Return PCI_INTX_DISABLED when no bus INTx routing support

2012-10-17 Thread Michael S. Tsirkin
On Wed, Oct 17, 2012 at 12:54:36PM -0600, Alex Williamson wrote: > On Wed, 2012-10-17 at 20:40 +0200, Jan Kiszka wrote: > > On 2012-10-17 20:25, Alex Williamson wrote: > > > Rather than assert, simply return PCI_INTX_DISABLED when we don't > > > have a pci_route_irq_fn. PIIX already returns DISABL

Re: [Qemu-devel] [PATCH] pci: Return PCI_INTX_DISABLED when no bus INTx routing support

2012-10-17 Thread Alex Williamson
On Wed, 2012-10-17 at 20:40 +0200, Jan Kiszka wrote: > On 2012-10-17 20:25, Alex Williamson wrote: > > Rather than assert, simply return PCI_INTX_DISABLED when we don't > > have a pci_route_irq_fn. PIIX already returns DISABLED for an > > invalid pin, so users already deal with this state. Users

[Qemu-devel] [Bug 1065325] Re: qemu-system-arm hangs on SIGUSR1 on OS X 10.8.2

2012-10-17 Thread Oliver
Is there anything else I can do to help debug this problem? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1065325 Title: qemu-system-arm hangs on SIGUSR1 on OS X 10.8.2 Status in QEMU: New Bug

Re: [Qemu-devel] Disabling KVM "on the fly"

2012-10-17 Thread Jan Kiszka
On 2012-10-17 18:44, Paolo Bonzini wrote: > Il 17/10/2012 18:37, Clemens Kolbitsch ha scritto: >> Guys, >> >> I know this is question might seem a bit odd, but I'm curious: >> >> Has anyone ever tried to write code to disable KVM on the fly / is it >> at all possible? I have a situation where I nee

Re: [Qemu-devel] [PATCH] pci: Return PCI_INTX_DISABLED when no bus INTx routing support

2012-10-17 Thread Michael S. Tsirkin
On Wed, Oct 17, 2012 at 08:40:05PM +0200, Jan Kiszka wrote: > On 2012-10-17 20:25, Alex Williamson wrote: > > Rather than assert, simply return PCI_INTX_DISABLED when we don't > > have a pci_route_irq_fn. PIIX already returns DISABLED for an > > invalid pin, so users already deal with this state.

[Qemu-devel] [PATCH 2/2] Add check_rxov into VMState.

2012-10-17 Thread Dmitry Fleytman
E1000State::check_rxov field must be preserved on live migration. Signed-off-by: Dmitry Fleytman --- hw/e1000.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 606bf3a..26ad03c 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -92,7 +92,7 @@

[Qemu-devel] [PATCH 1/2] Ignore RX tail kicks when RX disabled.

2012-10-17 Thread Dmitry Fleytman
Device RX initization from driver's side consists of following steps: 1. Initialize head and tail of RX ring to 0 2. Enable Rx (set bit in RCTL register) 3. Allocate buffers, fill descriptors 4. Write ring tail Forth operation signals hardware that RX buffers available and it may start pac

[Qemu-devel] [PATCH 0/2] E1000 RX/Live migration bugs fixed

2012-10-17 Thread Dmitry Fleytman
Following patches fix 2 problems in E1000 code: 1st patch fixes race condition between RX enable and RX buffers allocation See commit description for detailed explanation 2nd patch adds forgotten field into live migration list I'm not really sure this is a proper solution with no

Re: [Qemu-devel] [PATCH] pci: Return PCI_INTX_DISABLED when no bus INTx routing support

2012-10-17 Thread Jan Kiszka
On 2012-10-17 20:25, Alex Williamson wrote: > Rather than assert, simply return PCI_INTX_DISABLED when we don't > have a pci_route_irq_fn. PIIX already returns DISABLED for an > invalid pin, so users already deal with this state. Users of this > interface should only be acting on an ENABLED or IN

Re: [Qemu-devel] [PATCH 07/12] qdev-core: isolate reset register/unregister code

2012-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2012 at 01:08:23PM -0500, Anthony Liguori wrote: > Eduardo Habkost writes: > > > The reset register/unregister code is specific to qemu-system-*, so > > isolate it so it can be moved to qdev-system.c. > > > > Signed-off-by: Eduardo Habkost > > --- > > hw/qdev-core.c | 24 +++

[Qemu-devel] [PATCH] pci: Return PCI_INTX_DISABLED when no bus INTx routing support

2012-10-17 Thread Alex Williamson
Rather than assert, simply return PCI_INTX_DISABLED when we don't have a pci_route_irq_fn. PIIX already returns DISABLED for an invalid pin, so users already deal with this state. Users of this interface should only be acting on an ENABLED or INVERTED return value (though we really have no suppor

Re: [Qemu-devel] nvram and boot order

2012-10-17 Thread Anthony Liguori
David Gibson writes: > On Tue, Oct 16, 2012 at 02:55:21PM -0500, Anthony Liguori wrote: >> >> We discussed nvram and it's interaction with boot order in today's KVM >> call. Here's the outcome. This list is completely incremental so it's >> fine to start with 1-4, for instance, as long as we e

Re: [Qemu-devel] [PATCH 03/12] qdev: separate core from the code used only by qemu-system-*

2012-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2012 at 01:00:55PM -0500, Anthony Liguori wrote: > Igor Mammedov writes: > > > From: Eduardo Habkost > > > > This change should help on two things: > > - Allowing DeviceState to be used by *-user; > > - Writing qdev unit tests without pulling too many dependencies. > > > > Note

Re: [Qemu-devel] [PATCH 09/12] move qemu_irq typedef out of cpu-common.h

2012-10-17 Thread Anthony Liguori
Eduardo Habkost writes: > From: Igor Mammedov > > it's necessary for making CPU child of DEVICE without > causing circular header deps. > > Signed-off-by: Igor Mammedov Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > Changes v2 -> v3: > imammedo: sysemu.h doesn't need irq.h

Re: [Qemu-devel] [PATCH 07/12] qdev-core: isolate reset register/unregister code

2012-10-17 Thread Anthony Liguori
Eduardo Habkost writes: > The reset register/unregister code is specific to qemu-system-*, so > isolate it so it can be moved to qdev-system.c. > > Signed-off-by: Eduardo Habkost > --- > hw/qdev-core.c | 24 ++-- > 1 file changed, 18 insertions(+), 6 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH 05/12] qdev-core: isolate vmstate handling into separate functions

2012-10-17 Thread Anthony Liguori
Eduardo Habkost writes: > Those functions will eventually be moved somewhere else, and won't get > included on *-user. > > Signed-off-by: Eduardo Habkost > --- > hw/qdev-core.c | 26 ++ > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/hw/qdev-core.c b/

Re: [Qemu-devel] [PATCH 00/11] Pending Linux-user patches

2012-10-17 Thread Peter Maydell
On 17 October 2012 19:00, Riku Voipio wrote: > On 17 October 2012 18:15, Aurelien Jarno wrote: >> This is not very clear if it is a pull request or a call for review. > > It was for review, pull request would come with [PULL] in subject. I > wanted to wait a week for comments before sending them

Re: [Qemu-devel] [PATCH] target-arm/translate: Fix RRX operands

2012-10-17 Thread Aurelien Jarno
On Wed, Oct 17, 2012 at 05:43:55PM +0100, Peter Maydell wrote: > On 16 October 2012 10:15, Peter Crosthwaite > wrote: > > Instructions that both use the RRX second operand and update CS were > > incorrect, as the Carry flag was updated too early. An example of such an > > instruction would be: > >

Re: [Qemu-devel] [PATCH 03/12] qdev: separate core from the code used only by qemu-system-*

2012-10-17 Thread Anthony Liguori
Igor Mammedov writes: > From: Eduardo Habkost > > This change should help on two things: > - Allowing DeviceState to be used by *-user; > - Writing qdev unit tests without pulling too many dependencies. > > Note that there are two parts that depend on code compiled only on > qemu-system-*, but

Re: [Qemu-devel] [PATCH 00/11] Pending Linux-user patches

2012-10-17 Thread Riku Voipio
On 17 October 2012 18:15, Aurelien Jarno wrote: > This is not very clear if it is a pull request or a call for review. It was for review, pull request would come with [PULL] in subject. I wanted to wait a week for comments before sending them in a pull request. Riku

[Qemu-devel] [PATCH] net/tap-win32: Fix compiler warning caused by missing include statement

2012-10-17 Thread Stefan Weil
The include file for net_init_tap was missing: net/tap-win32.c:703: warning: no previous prototype for ‘net_init_tap’ Signed-off-by: Stefan Weil --- net/tap-win32.c |1 + 1 file changed, 1 insertion(+) diff --git a/net/tap-win32.c b/net/tap-win32.c index f1801e2..22dad3f 100644 --- a/net/

Re: [Qemu-devel] [RFC V2 00/20] QCOW2 deduplication

2012-10-17 Thread Avi Kivity
On 10/17/2012 06:00 PM, Benoît Canet wrote: > This patchset is a not yet working draft starting to implement deduplication > in QCOW2. > > The Kernel red black trees are indented in kernel style. > I'll be happy to know what is the policy regarding this kind of inclusion > and what tools can be us

[Qemu-devel] [Bug 1060928] Re: Error in launch virtual server port

2012-10-17 Thread javier navarro altimira
My english language is very bad, sorry. Recompiled by configure whith --enable-debug quit the problem, I have testesd the serial port with minicom, it works!!!, sorry .- steps .- configure .- make .- make install .- ifup tap0 .- ifconfig .- run script 1 .- run script 2

[Qemu-devel] [PATCH] configure: Fix CONFIG_QEMU_HELPERDIR generation

2012-10-17 Thread Jan Kiszka
We need to evaluate $libexecdir in configure, otherwise we literally end up with "${prefix}/libexec" instead of the absolute path as CONFIG_QEMU_HELPERDIR. Signed-off-by: Jan Kiszka --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure inde

Re: [Qemu-devel] [PULL for Luiz 00/25] Combined qemu-sockets cleanup v2 + NBD server

2012-10-17 Thread Markus Armbruster
Paolo Bonzini writes: > Luiz, > > The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade: > > ssi: Add slave autoconnect helper (2012-10-10 11:13:32 +1000) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git nbd-next > > for you to fetch chan

Re: [Qemu-devel] Disabling KVM "on the fly"

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 18:37, Clemens Kolbitsch ha scritto: > Guys, > > I know this is question might seem a bit odd, but I'm curious: > > Has anyone ever tried to write code to disable KVM on the fly / is it > at all possible? I have a situation where I need to use TCG for > certain parts of the code, bu

Re: [Qemu-devel] [PATCH 20/25] qapi: add socket address types

2012-10-17 Thread Luiz Capitulino
On Wed, 17 Oct 2012 18:48:08 +0200 Paolo Bonzini wrote: > Il 17/10/2012 18:43, Markus Armbruster ha scritto: > > Paolo Bonzini writes: > > > >> Acked-by: Luiz Capitulino > >> Signed-off-by: Paolo Bonzini > >> --- > >> qapi-schema.json | 53 > >> ++

Re: [Qemu-devel] [PATCH 21/25] qemu-sockets: return IPSocketAddress from inet_parse

2012-10-17 Thread Markus Armbruster
Paolo Bonzini writes: > Reviewed-by: Luiz Capitulino > Signed-off-by: Paolo Bonzini > --- > qemu-sockets.c | 119 > + > 1 file modificato, 78 inserzioni(+), 41 rimozioni(-) > > diff --git a/qemu-sockets.c b/qemu-sockets.c > index a37f35d

Re: [Qemu-devel] [PATCH 20/25] qapi: add socket address types

2012-10-17 Thread Markus Armbruster
Paolo Bonzini writes: > Acked-by: Luiz Capitulino > Signed-off-by: Paolo Bonzini > --- > qapi-schema.json | 53 + > 1 file modificato, 53 inserzioni(+) > > diff --git a/qapi-schema.json b/qapi-schema.json > index f9dbdae..d40b5fc 100644 > ---

Re: [Qemu-devel] [PATCH 20/25] qapi: add socket address types

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 18:43, Markus Armbruster ha scritto: > Paolo Bonzini writes: > >> Acked-by: Luiz Capitulino >> Signed-off-by: Paolo Bonzini >> --- >> qapi-schema.json | 53 + >> 1 file modificato, 53 inserzioni(+) >> >> diff --git a/qapi-schema

[Qemu-devel] [RFC V2 14/20] qcow2: Extract qcow2_add_feature and qcow2_remove_feature.

2012-10-17 Thread Benoît Canet
These functions will be use to mark that deduplication is activatedi on an image. --- block/qcow2.c | 40 +++- block/qcow2.h |4 ++-- 2 files changed, 29 insertions(+), 15 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 18cb85d..b11b6a7 1006

Re: [Qemu-devel] [PATCH] target-arm/translate: Fix RRX operands

2012-10-17 Thread Peter Maydell
On 16 October 2012 10:15, Peter Crosthwaite wrote: > Instructions that both use the RRX second operand and update CS were > incorrect, as the Carry flag was updated too early. An example of such an > instruction would be: > > ands r12,r13,RRX > > Ands, because of the "s" flag will update the carry

Re: [Qemu-devel] [PATCH v2 00/10] Double-word tcg/optimize improvements

2012-10-17 Thread Aurelien Jarno
On Tue, Oct 02, 2012 at 11:32:20AM -0700, Richard Henderson wrote: > Changes v1->v2: > > * Patch 1 changes the exact swap condition. This helps add2 for e.g. > > add2 tmp4,tmp5,tmp4,tmp5,c1,c2 > > where tmp5, c1, and c2 are all input constants. Since tmp4 is variable, > we cannot const

[Qemu-devel] [RFC V2 06/20] qcow2: Add qcow2_dedup and related functions.

2012-10-17 Thread Benoît Canet
--- block/qcow2-dedup.c | 332 +++ block/qcow2.h |7 ++ 2 files changed, 339 insertions(+) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index 9955843..ae45130 100644 --- a/block/qcow2-dedup.c +++ b/block/qcow2-dedup.c @@ -29,6 +

[Qemu-devel] [RFC V2 11/20] qcow2: Load and save deduplication table header extension.

2012-10-17 Thread Benoît Canet
--- block/qcow2.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index c1ff31f..18cb85d 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -53,9 +53,15 @@ typedef struct { uint32_t len; } QCowExtension; +typedef struc

[Qemu-devel] [RFC V2 02/20] qcow2: Add kernel red black trees

2012-10-17 Thread Benoît Canet
--- Makefile.objs |1 + rbtree.c | 389 + rbtree.h | 160 3 files changed, 550 insertions(+) create mode 100644 rbtree.c create mode 100644 rbtree.h diff --git a/Makefile.objs b/Makefile.objs index

  1   2   3   >