Re: [Qemu-devel] [PATCH v6 2/4] exynos4210: Added SD host controller model

2012-09-17 Thread Igor Mitsyanko
On 09/18/2012 06:41 AM, Peter Crosthwaite wrote: Ping! Igor, are you able to provide a diff of this patch so I can send the next revision? Sure, but I still don't understand what to do with QEMU-lockup issue, I believe the same topic was discussed here http://thread.gmane.org/gmane.comp.emul

[Qemu-devel] Doubts on SMP, VCPU and CONFIG_IOTHREAD

2012-09-17 Thread Alex Barcelo
Sorry for being so confused, I am sure that there is some manual which I haven't read, but I am not able to find it :-\ I saw some things[1] about multiple vcpu, smp and things like that. It seemed to me that --enable-io-thread enables it. But, it only works for KVM, doesn't it? I assume that ther

Re: [Qemu-devel] [RFC v2 04/12] hw/qdev-properties.c: Add "transport" property.

2012-09-17 Thread Evgeny Voevodin
On 09/17/2012 04:42 PM, Paolo Bonzini wrote: Il 17/09/2012 12:00, Evgeny Voevodin ha scritto: Virtio back-end devices can be plugged into both transports: VIRTIO_PCI and VIRTIO_MMIO. In order to choose the desired transport we have a property "transport" in every back-end state struct. By specif

[Qemu-devel] [PATCH v6 11/13] xilinx_spips: Xilinx Zynq SPI cntrlr device model

2012-09-17 Thread Peter A. G. Crosthwaite
Added device model for the Xilinx Zynq SPI controller (SPIPS). Signed-off-by: Peter A. G. Crosthwaite --- hw/arm/Makefile.objs |1 + hw/xilinx_spips.c| 352 ++ 2 files changed, 353 insertions(+), 0 deletions(-) create mode 100644 hw/xili

[Qemu-devel] [PATCH v6 09/13] xilinx_spi: Initial impl. of Xilinx SPI controller

2012-09-17 Thread Peter A. G. Crosthwaite
Device model for xilinx XPS SPI controller (v2.0) Signed-off-by: Peter A. G. Crosthwaite --- changed from v4 (Near total rewrite): removed timer delay. This was innacturate anyways removed for simlicity. updated for new SSI interface. factored out txrx fifos using fifo.h changed from v3: typedef'

[Qemu-devel] [PATCH v6 07/13] hw: Added generic FIFO API.

2012-09-17 Thread Peter A. G. Crosthwaite
Added a FIFO API that can be used to create and operate byte FIFOs. Signed-off-by: Peter A. G. Crosthwaite --- hw/Makefile.objs |1 + hw/fifo.c| 78 ++ hw/fifo.h| 47 3 files changed, 12

[Qemu-devel] [PATCH v6 06/13] stellaris: Removed SSI mux

2012-09-17 Thread Peter A. G. Crosthwaite
Removed the explicit SSI mux and wired the CS line directly up to the SSI devices. Signed-off-by: Peter A. G. Crosthwaite --- hw/ssd0323.c |1 + hw/ssi-sd.c|1 + hw/stellaris.c | 98 ++-- 3 files changed, 19 insertions(+), 81 d

[Qemu-devel] [PATCH v6 04/13] qdev: allow multiple qdev_init_gpio_in() calls

2012-09-17 Thread Peter A. G. Crosthwaite
Allow multiple qdev_init_gpio_in() calls for the one device. The first call will define GPIOs 0-N-1, the next GPIOs N- ... . Allows different GPIOs to be handled with different handlers. Needed when two levels of the QOM class heirachy both define GPIO functionality, as a single GPIO handler with a

Re: [Qemu-devel] [PATCH v6 2/4] exynos4210: Added SD host controller model

2012-09-17 Thread Peter Crosthwaite
Ping! Igor, are you able to provide a diff of this patch so I can send the next revision? Regards, Peter On Mon, 2012-08-06 at 16:29 +0400, Igor Mitsyanko wrote: > On 08/06/2012 02:56 PM, Peter Maydell wrote: > > On 6 August 2012 04:25, Peter A. G. Crosthwaite > > wrote: > > > >> +static uint64

[Qemu-devel] [PATCH v6 02/13] ssi: Implemented CS behaviour

2012-09-17 Thread Peter A. G. Crosthwaite
Added default CS behaviour for SSI slaves. SSI devices can set a property to enable CS behaviour which will create a GPIO on the device which is the CS. Tristating of the bus on SSI transfers is implemented. Signed-off-by: Peter A. G. Crosthwaite --- Changed since v5: Addressed PMM review. Collap

[Qemu-devel] [PATCH v6 13/13] MAINTAINERS: Added maintainerships for SSI

2012-09-17 Thread Peter A. G. Crosthwaite
Added maintainership for SSI, M25P80 and the Xilinx SPI controllers. Signed-off-by: Peter A. G. Crosthwaite --- MAINTAINERS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 61f8b45..0ebe247 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[Qemu-devel] [PATCH v6 12/13] xilinx_zynq: Added SPI controllers + flashes

2012-09-17 Thread Peter A. G. Crosthwaite
Added the two SPI controllers to the zynq machine model. Attached two SPI flash devices to each controller. Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_zynq.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/hw/xilinx_zynq.c b/h

[Qemu-devel] [PATCH v6 10/13] petalogix-ml605: added SPI controller with n25q128

2012-09-17 Thread Peter A. G. Crosthwaite
Added SPI controller to the reference design, with two n25q128 spi-flashes connected. Signed-off-by: Peter A. G. Crosthwaite --- Changed since v5: Removed redundant (char*) cast with qdev_get_prop_string hw/petalogix_ml605_mmu.c | 27 +++ 1 files changed, 27 insertions

[Qemu-devel] [PATCH v6 05/13] hw/stellaris: Removed gpio_out init array.

2012-09-17 Thread Peter A. G. Crosthwaite
stellaris_init() defines arrays of qemu_irq to decides what each of the GPIO pins are connected to. This is ok for inputs (as an input can only have one source) but is flawed for outputs as an output can connect to any number of sinks. Removed the gpio_out array completely and just replaced its set

[Qemu-devel] [PATCH v6 08/13] m25p80: Initial implementation of SPI flash device

2012-09-17 Thread Peter A. G. Crosthwaite
Added device model for m25p80 style SPI flash family. Signed-off-by: Peter A. G. Crosthwaite --- changed from v4: Added write-1 flag (EEPROM mode). n25q128 table entry indentation fix. updated for new SSI interface. various debug messages cleaned up and added. changed from v3: changed licence to

[Qemu-devel] [PATCH v6 03/13] ssi: Added create_slave_no_init()

2012-09-17 Thread Peter A. G. Crosthwaite
Slave creation function that can be used to create an SSI slave without qdev_init() being called. This give machine models a chance to set properties. Signed-off-by: Peter A. G. Crosthwaite --- hw/ssi.c |9 +++-- hw/ssi.h |1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH v6 01/13] ssi: Support for multiple attached devices

2012-09-17 Thread Peter A. G. Crosthwaite
Removed assertion that only one device is attached to the SSI bus. When multiple devices are attached, all slaves have their transfer function called for transfers. Each device is responsible for knowing whether or not its CS is active, and if not returning 0. The returned data is the logical or o

[Qemu-devel] [PATCH v6 00/13] Ehnahced SSI bus support + M25P80 SPI flash + Xilinx SPI controller

2012-09-17 Thread Peter A. G. Crosthwaite
This series reworks the SSI bus framework for SPI and add some new SPI controllers and devices: Patches 1-4 reworks SSI to add chip-select support to SPI devices and allow for multiple SPI devices attached to the same bus. Patches 5-6 fix the SPI setup in the stellaris machine model. Patch 7 is

Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-17 Thread Wen Congyang
At 09/18/2012 01:56 AM, Luiz Capitulino Wrote: > Hi Wen, > > We've re-reviewed the dump-guest-memory command and found some > possible issues with the -p option. > > The main issue is that it seems possible for a malicious guest to set > page tables in a way that we allocate a MemoryMapping struc

Re: [Qemu-devel] [PATCH 1/2] qemu-char: BUGFIX, don't call FD_ISSET with negative fd

2012-09-17 Thread David Gibson
On Mon, Sep 17, 2012 at 01:24:51PM -0500, Anthony Liguori wrote: > David Gibson writes: > > > tcp_chr_connect(), unlike for example udp_chr_update_read_handler() does > > not check if the fd it is using is valid (>= 0) before passing it to > > qemu_set_fd_handler2(). If using e.g. a TCP serial p

[Qemu-devel] buildbot failure in qemu on default_i386_rhel61

2012-09-17 Thread qemu
The Buildbot has detected a new failure on builder default_i386_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_rhel61/builds/368 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61_32bit

Re: [Qemu-devel] [PATCH v1 5/6] xilinx: fix names of ethernet and dma links.

2012-09-17 Thread Peter Crosthwaite
On Tue, Sep 18, 2012 at 1:13 AM, Andreas Färber wrote: > Hi, > > Am 17.09.2012 10:47, schrieb Peter A. G. Crosthwaite: >> These names were incorrect. Fixed to match to actual link names >> >> Signed-off-by: Peter A. G. Crosthwaite >> --- >> hw/xilinx.h |6 -- >> 1 files changed, 4 insert

Re: [Qemu-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-09-17 Thread Xu, Dongxiao
Hi Stefano, Is these patches merged with Xen 4.2? I didn't see them in the upstream. The uint/int fix is critical to fix the nested guest boot issue. Thanks, Dongxiao > -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: Tuesday, September 11,

Re: [Qemu-devel] Breakage

2012-09-17 Thread Max Filippov
On Tue, Sep 18, 2012 at 12:15 AM, Eduardo Habkost wrote: > On Mon, Sep 17, 2012 at 11:54:42PM +0400, malc wrote: >> On Mon, 17 Sep 2012, Anthony Liguori wrote: >> >> > malc writes: >> > >> > > Some(thing|one) broke compilation with pcspk enabled. >> > > Symptoms being: >> > > >> > > ../libhw32/hw

[Qemu-devel] [PATCH 3/7] target-mips: Always evaluate debugging macro arguments

2012-09-17 Thread Richard Henderson
Done inside an if (0) so that it is easily eliminated as dead code. But this will prevent some of the compilation errors with debugging enabled from creeping back in. Signed-off-by: Richard Henderson --- target-mips/translate.c | 48 +++- 1 file change

[Qemu-devel] [PATCH 4/7] target-mips: Pass DisasContext to fpr32 load/store routines

2012-09-17 Thread Richard Henderson
The large mechanical change in support of a follow-on patch that changes the representation of the fp registers. Signed-off-by: Richard Henderson --- target-mips/translate.c | 312 1 file changed, 153 insertions(+), 159 deletions(-) diff --git a/

[Qemu-devel] [PATCH v2 0/7] target-mips improvements

2012-09-17 Thread Richard Henderson
The thread that Aurelien replied to was from March. Going back to revive that patch I found I'd done some further work in April, which I may never have got around to posting. The first three patches fix compilation errors when MIPS_DEBUG_DISAS is defined. The second three patches change the mips

[Qemu-devel] [PATCH 5/7] target-mips: Use TCG registers for the FPU.

2012-09-17 Thread Richard Henderson
With normal FP, this doesn't have much affect on the generated code, because most of the FP operations are not CONST/PURE, and so we spill registers in about the same frequency as the explicit load/stores. But with Loongson multimedia instructions, which are all integral and whose helpers are in f

[Qemu-devel] [PATCH 7/7] target-mips: Implement Loongson Multimedia Instructions

2012-09-17 Thread Richard Henderson
Implements all of the COP2 instructions except for the S family of comparisons. The documentation is unclear for those. Signed-off-by: Richard Henderson --- target-mips/Makefile.objs | 2 +- target-mips/helper.h | 59 target-mips/lmi_helper.c | 744

Re: [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error)

2012-09-17 Thread Anthony Liguori
Jan Kiszka writes: > On 2012-09-17 22:14, Stefan Weil wrote: >> This configuration requires CONFIG_i8254: >> >> configure --target-list=xtensa-softmmu --audio-card-list=pcspk > > This is wrong. The pcspk "audio card" is registered automatically for > those targets that support it. > >> >> Repor

[Qemu-devel] [PATCH 6/7] target-mips: Add accessors for the two 32-bit halves of a 64-bit FPR

2012-09-17 Thread Richard Henderson
Not much used yet, but more users to come. Signed-off-by: Richard Henderson --- target-mips/translate.c | 64 + 1 file changed, 38 insertions(+), 26 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index df92cec..57454f0

[Qemu-devel] [PATCH 2/7] target-mips: Fix MIPS_DEBUG.

2012-09-17 Thread Richard Henderson
The macro uses the DisasContext. Pass it around as needed. Signed-off-by: Richard Henderson --- target-mips/translate.c | 74 + 1 file changed, 38 insertions(+), 36 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index

Re: [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error)

2012-09-17 Thread Jan Kiszka
On 2012-09-17 22:14, Stefan Weil wrote: > This configuration requires CONFIG_i8254: > > configure --target-list=xtensa-softmmu --audio-card-list=pcspk This is wrong. The pcspk "audio card" is registered automatically for those targets that support it. > > Reported-by: Vassili Karpov (malc) > S

[Qemu-devel] [PATCH 1/7] target-mips: Set opn in gen_ldst_multiple.

2012-09-17 Thread Richard Henderson
Used by MIPS_DEBUG, when enabled. Signed-off-by: Richard Henderson --- target-mips/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-mips/translate.c b/target-mips/translate.c index 52eeb2b..50153a9 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@

Re: [Qemu-devel] [PATCH 04/13] tcg-sparc: Assume v9 cpu always, i.e. force v8plus in 32-bit mode.

2012-09-17 Thread Richard Henderson
On 09/17/2012 12:25 PM, Blue Swirl wrote: > Would it make sense to break up tcg/sparc into tcg/sparc32 and > tcg/sparc64? That way it would be possible to give Sparc32 a chance of > getting fixed. But I wouldn't object removal either. IMO someone would have to actively step forward to maintain spa

Re: [Qemu-devel] [RFC PATCH 05/10] exec: small adjustments for TCG separation

2012-09-17 Thread Richard Henderson
On 09/17/2012 12:17 PM, Blue Swirl wrote: >> > +void tcg_exec_init(unsigned long tb_size) >> > +{ >> > +#ifndef CONFIG_TCG >> > +/* We cannot yet use tcg_enabled() here, it is set below. */ >> > +return; > This leaves a lot of unreachable code after return, possibly > introducing warnings

Re: [Qemu-devel] Block Migration Assertion in qemu-kvm 1.2.0

2012-09-17 Thread Peter Lieven
On 09/17/12 10:41, Kevin Wolf wrote: Am 16.09.2012 12:13, schrieb Peter Lieven: Hi, when trying to block migrate a VM from one node to another, the source VM crashed with the following assertion: block.c:3829: bdrv_set_in_use: Assertion `bs->in_use != in_use' failed. Is this sth already addres

Re: [Qemu-devel] Breakage

2012-09-17 Thread Jan Kiszka
On 2012-09-17 21:54, malc wrote: > On Mon, 17 Sep 2012, Anthony Liguori wrote: > >> malc writes: >> >>> Some(thing|one) broke compilation with pcspk enabled. >>> Symptoms being: >>> >>> ../libhw32/hw/pcspk.o: In function `pcspk_io_write': >>> /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined re

[Qemu-devel] [PATCH] xtensa: Fix broken build (linker error)

2012-09-17 Thread Stefan Weil
This configuration requires CONFIG_i8254: configure --target-list=xtensa-softmmu --audio-card-list=pcspk Reported-by: Vassili Karpov (malc) Signed-off-by: Stefan Weil --- default-configs/xtensa-softmmu.mak |1 + default-configs/xtensaeb-softmmu.mak |1 + 2 files changed, 2 insertions

Re: [Qemu-devel] Breakage

2012-09-17 Thread Eduardo Habkost
On Mon, Sep 17, 2012 at 11:54:42PM +0400, malc wrote: > On Mon, 17 Sep 2012, Anthony Liguori wrote: > > > malc writes: > > > > > Some(thing|one) broke compilation with pcspk enabled. > > > Symptoms being: > > > > > > ../libhw32/hw/pcspk.o: In function `pcspk_io_write': > > > /home/malc/x/rcs/git

[Qemu-devel] [PATCH v2 2/2] Versatile Express: add modelling of NOR flash

2012-09-17 Thread Francesco Lavra
This patch adds modelling of the two NOR flash banks found on the Versatile Express motherboard. Tested with U-Boot running on an emulated Versatile Express, with either A9 or A15 CoreTile. Signed-off-by: Francesco Lavra --- Changes in v2: Use drive_get_next() instead of drive_get() to get a back

[Qemu-devel] [PATCH v2 1/2] Versatile Express: Fix NOR flash 0 address and remove flash alias

2012-09-17 Thread Francesco Lavra
In the A series memory map (implemented in the Cortex A15 CoreTile), the first NOR flash bank (flash 0) is mapped to address 0x0800, while address 0x can be configured as alias to either the first or the second flash bank. This patch fixes the definition of flash 0 address, and for simp

[Qemu-devel] [PATCH v2 0/2] Versatile Express: add modelling of NOR flash

2012-09-17 Thread Francesco Lavra
This patch series adds modelling of the two NOR flash banks found on the Versatile Express motherboard. Tested with U-Boot running on an emulated Versatile Express, with either A9 or A15 CoreTile. The alias of the first NOR flash in the Cortex-A Series memory map is not modelled. Changes in v2: Fi

Re: [Qemu-devel] [PATCH 3/5] target-arm: convert shl and shr helpers to TCG

2012-09-17 Thread Aurelien Jarno
On Mon, Sep 17, 2012 at 11:47:05AM -0700, Richard Henderson wrote: > On 09/17/2012 11:09 AM, Aurelien Jarno wrote: > > If you insist, maybe we can just add a movcond op that uses setcond, so > > it makes the code more readable? > > Well, that's certainly a good first step. And an easy fall back f

Re: [Qemu-devel] Breakage

2012-09-17 Thread malc
On Mon, 17 Sep 2012, Anthony Liguori wrote: > malc writes: > > > Some(thing|one) broke compilation with pcspk enabled. > > Symptoms being: > > > > ../libhw32/hw/pcspk.o: In function `pcspk_io_write': > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to > > `pit_set_gate' > > ../

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-09-17 Thread Eric Blake
On 09/17/2012 01:38 PM, Anthony Liguori wrote: > Mike Frysinger writes: > >> We should not quote the PKG_CONFIG setting as this deviates from the >> canonical upstream behavior that gets integrated with all other build >> systems, and deviates from how we treat all other toolchain variables >> th

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-09-17 Thread Anthony Liguori
Mike Frysinger writes: > We should not quote the PKG_CONFIG setting as this deviates from the > canonical upstream behavior that gets integrated with all other build > systems, and deviates from how we treat all other toolchain variables > that we get from the environment. > > Ultimately, the poi

Re: [Qemu-devel] Breakage

2012-09-17 Thread Anthony Liguori
malc writes: > Some(thing|one) broke compilation with pcspk enabled. > Symptoms being: > > ../libhw32/hw/pcspk.o: In function `pcspk_io_write': > /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to > `pit_set_gate' > ../libhw32/hw/pcspk.o: In function `pcspk_io_read': > /home/malc/x

Re: [Qemu-devel] PING Re: [PATCH v2] hw: Add VMware's GETHZ command.

2012-09-17 Thread Anthony Liguori
Don Slutz writes: > On 09/05/12 16:24, Don Slutz wrote: >> On 08/31/12 13:27, Jan Kiszka wrote: >>> On 2012-08-31 19:20, Don Slutz wrote: This is known is linux as VMWARE_PORT_CMD_GETHZ. Signed-off-by: Don Slutz --- hw/vmport.c | 23 ++- 1 f

Re: [Qemu-devel] [PATCH v3 00/17] Allow changing of Hypervisor CPUIDs.

2012-09-17 Thread Eduardo Habkost
On Mon, Sep 17, 2012 at 10:00:50AM -0400, Don Slutz wrote: > Resend with new id so the backup files are not included. > > Also known as Paravirtualization CPUIDs. > > This is primarily done so that the guest will think it is running > under vmware when hypervisor-vendor=vmware is specified as a >

Re: [Qemu-devel] [PATCH 04/13] tcg-sparc: Assume v9 cpu always, i.e. force v8plus in 32-bit mode.

2012-09-17 Thread Blue Swirl
On Mon, Sep 17, 2012 at 5:05 PM, Richard Henderson wrote: > On 09/17/2012 09:04 AM, Andreas Färber wrote: >> Without knowing the code, this does not strike me as the best of ideas: >> SPARC CPUs are rather uncommon these days, so being able to emulate it >> in sparc32-softmmu may be helpful for ke

Re: [Qemu-devel] [RFC PATCH 00/10] Add --disable-tcg

2012-09-17 Thread Blue Swirl
On Mon, Sep 17, 2012 at 4:00 PM, Paolo Bonzini wrote: > This is an old series from Anthony that was never committed. Now > that QEMU does not use ARG0 anymore, it is much simpler to move things > to and from the helper.c files as needed to remove most of the TCG code > from non-TCG builds. > > Of

Re: [Qemu-devel] [RFC PATCH 05/10] exec: small adjustments for TCG separation

2012-09-17 Thread Blue Swirl
On Mon, Sep 17, 2012 at 4:00 PM, Paolo Bonzini wrote: > Add stubs for cpu_restore_state and tlb_fill, which should respectively > have no effect and never be used outside TCG mode. > > Add assertions that TCG is enabled around code that calls to TCG from > exec.c, so that the compiler can remove t

Re: [Qemu-devel] [RFC PATCH 01/10] configure: factor out list of supported Xen/KVM targets

2012-09-17 Thread Peter Maydell
On 17 September 2012 19:53, Stefano Stabellini wrote: > On Mon, 17 Sep 2012, Stefano Stabellini wrote: >> On Mon, 17 Sep 2012, Peter Maydell wrote: >> > This is a change in behaviour, isn't it? The old configure code >> > enables CONFIG_XEN based only on $target_arch2, it doesn't try >> > to ensur

Re: [Qemu-devel] [RFC PATCH 09/10] i386: move TCG functions out of helper.o, non-TCG functions to cpu.o

2012-09-17 Thread Blue Swirl
On Mon, Sep 17, 2012 at 4:00 PM, Paolo Bonzini wrote: > This lets non-TCG build remove *_helper.c from the build. > > Signed-off-by: Paolo Bonzini > --- > target-i386/cpu.c | 18 ++ > target-i386/excp_helper.c | 24 > target-i386/fpu_helper.c | 1

Re: [Qemu-devel] [PATCH V2 2/6] libqblock type and structure defines

2012-09-17 Thread Blue Swirl
On Mon, Sep 17, 2012 at 2:23 AM, Wenchao Xia wrote: > 于 2012-9-15 2:11, Blue Swirl 写道: > >> On Thu, Sep 13, 2012 at 3:49 AM, Eric Blake wrote: >>> >>> On 09/12/2012 09:33 PM, Eric Blake wrote: > > OK ,then I think > #if __GNUC__ >= 4 > > #else >[warn name space

Re: [Qemu-devel] [PATCH v2] target-mips: Implement Loongson Multimedia Instructions

2012-09-17 Thread Aurelien Jarno
On Mon, Sep 17, 2012 at 11:54:59AM -0700, Richard Henderson wrote: > On 09/07/2012 05:32 PM, Aurelien Jarno wrote: > >> +do_shift: > >> +switch (opc) { > >> +case OPC_SLL_CP2: > >> +case OPC_DSLL_CP2: > >> +tcg_gen_shl_i64(t0, t0, t1); > >> +break

Re: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void

2012-09-17 Thread Peter Maydell
On 17 September 2012 19:25, Paolo Bonzini wrote: > Il 17/09/2012 19:20, Peter Maydell ha scritto: >>> > Couldn't that mean simply that the tb for instance wasn't mapped >>> > anywhere? That's the KVM case, at least. >> Hmm. For TCG there are certainly some cases where failure to >> cpu_restore_st

Re: [Qemu-devel] [PATCH v2] target-mips: Implement Loongson Multimedia Instructions

2012-09-17 Thread Richard Henderson
On 09/07/2012 05:32 PM, Aurelien Jarno wrote: >> +do_shift: >> +switch (opc) { >> +case OPC_SLL_CP2: >> +case OPC_DSLL_CP2: >> +tcg_gen_shl_i64(t0, t0, t1); >> +break; >> +case OPC_SRA_CP2: >> +case OPC_DSRA_CP2: >> +/*

Re: [Qemu-devel] [RFC PATCH 01/10] configure: factor out list of supported Xen/KVM targets

2012-09-17 Thread Stefano Stabellini
On Mon, 17 Sep 2012, Stefano Stabellini wrote: > On Mon, 17 Sep 2012, Peter Maydell wrote: > > On 17 September 2012 17:00, Paolo Bonzini wrote: > > > Signed-off-by: Paolo Bonzini > > > --- > > > configure | 63 > > > +-- > > > 1 file m

Re: [Qemu-devel] QEMU (no kvm) Win7 (64bit) boot error [PATCH 1/1]

2012-09-17 Thread Clemens Kolbitsch
On Mon, Sep 17, 2012 at 11:19 AM, Aurelien Jarno wrote: > On Mon, Sep 17, 2012 at 10:27:35AM -0700, Clemens Kolbitsch wrote: >> On Mon, Sep 10, 2012 at 10:31 AM, Aurelien Jarno >> wrote: >> > On Mon, Sep 10, 2012 at 06:23:43PM +0200, Stefan Weil wrote: >> >> Am 10.09.2012 08:19, schrieb Clemens

Re: [Qemu-devel] [PATCH 3/5] target-arm: convert shl and shr helpers to TCG

2012-09-17 Thread Richard Henderson
On 09/17/2012 11:09 AM, Aurelien Jarno wrote: > If you insist, maybe we can just add a movcond op that uses setcond, so > it makes the code more readable? Well, that's certainly a good first step. And an easy fall back for hosts that choose not to implement the full conditional move. But at leas

Re: [Qemu-devel] [RFC PATCH 09/10] i386: move TCG functions out of helper.o, non-TCG functions to cpu.o

2012-09-17 Thread Paolo Bonzini
Il 17/09/2012 19:12, Peter Maydell ha scritto: >> > + >> > +if (env->watchpoint_hit) { >> > +if (env->watchpoint_hit->flags & BP_CPU) { >> > +env->watchpoint_hit = NULL; >> > +if (check_hw_breakpoints(env, 0)) >> > +raise_exception(env, EXCP01_DB)

Re: [Qemu-devel] [PATCH] ignore more generated files

2012-09-17 Thread Jan Kiszka
On 2012-09-17 20:32, Mike Frysinger wrote: > On Monday 17 September 2012 03:19:54 Jan Kiszka wrote: >> On 2012-09-16 22:55, Mike Frysinger wrote: >>> On Sunday 16 September 2012 16:33:15 Stefan Weil wrote: Am 16.09.2012 22:11, schrieb Mike Frysinger: > +libcacard/vscclient +a.out* +.gdb_hi

Re: [Qemu-devel] [PATCH] ignore more generated files

2012-09-17 Thread Mike Frysinger
On Monday 17 September 2012 03:19:54 Jan Kiszka wrote: > On 2012-09-16 22:55, Mike Frysinger wrote: > > On Sunday 16 September 2012 16:33:15 Stefan Weil wrote: > >> Am 16.09.2012 22:11, schrieb Mike Frysinger: > >>> +libcacard/vscclient +a.out* +.gdb_history +core +gmon.out > >>> +*.diff +*.patch +

Re: [Qemu-devel] [RFC PATCH 01/10] configure: factor out list of supported Xen/KVM targets

2012-09-17 Thread Stefano Stabellini
On Mon, 17 Sep 2012, Peter Maydell wrote: > On 17 September 2012 17:00, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > > --- > > configure | 63 > > +-- > > 1 file modificato, 37 inserzioni(+), 26 rimozioni(-) > > > > diff --g

Re: [Qemu-devel] [PULL 00/13] Net patches

2012-09-17 Thread Anthony Liguori
Stefan Hajnoczi writes: > Fixes for hung NICs, USB network interface packet dropping, and inefficient > netdev socket non-blocking I/O. > > The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc: > > Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11 18:06:56 >

Re: [Qemu-devel] [PATCH v5] add -machine mem-merge=on|off option

2012-09-17 Thread Anthony Liguori
Luiz Capitulino writes: > It allows to disable memory merge support (KSM on Linux), which is > enabled by default otherwise. > > Signed-off-by: Luiz Capitulino Applied. Thanks. Regards, Anthony Liguori > --- > > v5 > > - rebase on top of current master > > exec.c | 19 +

Re: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void

2012-09-17 Thread Paolo Bonzini
Il 17/09/2012 19:20, Peter Maydell ha scritto: >> > Couldn't that mean simply that the tb for instance wasn't mapped >> > anywhere? That's the KVM case, at least. > Hmm. For TCG there are certainly some cases where failure to > cpu_restore_state() means that the current CPU state is now broken; >

Re: [Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS debug ports

2012-09-17 Thread Anthony Liguori
Jan Kiszka writes: > We have debugcon these days to listen on those ports that receive debug > messages. Also drop the others that have no effect anymore. > > Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori > --- > hw/pc.c | 27 --- > 1 files ch

Re: [Qemu-devel] [PATCH 1/2] qemu-char: BUGFIX, don't call FD_ISSET with negative fd

2012-09-17 Thread Anthony Liguori
David Gibson writes: > tcp_chr_connect(), unlike for example udp_chr_update_read_handler() does > not check if the fd it is using is valid (>= 0) before passing it to > qemu_set_fd_handler2(). If using e.g. a TCP serial port, which is not > initially connected, this can result in -1 being passed

Re: [Qemu-devel] [RFC PATCH 01/10] configure: factor out list of supported Xen/KVM targets

2012-09-17 Thread Stefano Stabellini
On Mon, 17 Sep 2012, Paolo Bonzini wrote: > Il 17/09/2012 19:02, Peter Maydell ha scritto: > > If Xen requires 64 bit physaddrs it should probably just be asserting > > this here, not randomly changing target_phys_bits. In fact all the > > supported Xen target archs already have 64 bit physaddrs, s

Re: [Qemu-devel] [PATCH 0/9] [PULL] qemu-kvm.git uq/master queue

2012-09-17 Thread Anthony Liguori
Marcelo Tosatti writes: > The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc: > > Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11 18:06:56 > +0200) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/ma

Re: [Qemu-devel] [PULL 00/10] spice patch queue

2012-09-17 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > This pull brings monitor configuration support for qxl which is needed > by the upcoming kms qxl driver. Also a nice speedup for qxl in vga mode > and as usual some bugfixes. > > please pull, > Gerd > > The following changes since commit e0a1e32dbc41e6b2aabb43

Re: [Qemu-devel] [PULL 00/12] Trivial patches for 16 August to 14 September 2012

2012-09-17 Thread Anthony Liguori
Stefan Hajnoczi writes: > The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc: > > Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11 18:06:56 > +0200) > > are available in the git repository at: > > > git://github.com/stefanha/qemu.git trivial-patches > >

Re: [Qemu-devel] [PULL 00/11] Block patches

2012-09-17 Thread Anthony Liguori
Kevin Wolf writes: > The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc: > > Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11 18:06:56 > +0200) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git for-anthony > Pulled. Thanks

Re: [Qemu-devel] [PULL] slirp: enhancements of TFTP and small fixes

2012-09-17 Thread Anthony Liguori
Jan Kiszka writes: > The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc: > > Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11 18:06:56 > +0200) > > are available in the git repository at: > Pulled. Thanks. Regards, Anthony Liguori > git://git.kiszka

Re: [Qemu-devel] QEMU (no kvm) Win7 (64bit) boot error [PATCH 1/1]

2012-09-17 Thread Aurelien Jarno
On Mon, Sep 17, 2012 at 10:27:35AM -0700, Clemens Kolbitsch wrote: > On Mon, Sep 10, 2012 at 10:31 AM, Aurelien Jarno wrote: > > On Mon, Sep 10, 2012 at 06:23:43PM +0200, Stefan Weil wrote: > >> Am 10.09.2012 08:19, schrieb Clemens Kolbitsch: > >> >On Sat, Sep 8, 2012 at 11:22 AM, Clemens Kolbitsc

Re: [Qemu-devel] [PATCH 3/5] target-arm: convert shl and shr helpers to TCG

2012-09-17 Thread Aurelien Jarno
On Mon, Sep 17, 2012 at 08:36:31AM -0700, Richard Henderson wrote: > On 09/16/2012 04:08 PM, Aurelien Jarno wrote: > > +tcg_gen_setcondi_i32(TCG_COND_GE, tmp2, tmp1, 32); \ > > +tcg_gen_andi_i32(tmp1, tmp1, 0x1f);\ > > +tcg_gen_##name##_i32(dest, t0, tmp1);

Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-17 Thread Eric Blake
On 09/17/2012 11:56 AM, Luiz Capitulino wrote: > Hi Wen, > > We've re-reviewed the dump-guest-memory command and found some > possible issues with the -p option. > > However, I also think that we should consider if having the -p > feature is really worth it. It's a complex feature and has a numb

Re: [Qemu-devel] Block Migration and xbzrle

2012-09-17 Thread Orit Wasserman
On 09/16/2012 01:39 PM, Peter Lieven wrote: > Hi, > > I remember that this was broken some time ago and currently with qemu-kvm > 1.2.0 I am still not able to use > block migration plus xbzrle. The migration fails if both are used together. > XBZRLE without block migration works. > > Can someon

[Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-17 Thread Luiz Capitulino
Hi Wen, We've re-reviewed the dump-guest-memory command and found some possible issues with the -p option. The main issue is that it seems possible for a malicious guest to set page tables in a way that we allocate a MemoryMapping structure for each possible PTE. If IA-32e paging is used, this co

[Qemu-devel] Breakage

2012-09-17 Thread malc
Some(thing|one) broke compilation with pcspk enabled. Symptoms being: ../libhw32/hw/pcspk.o: In function `pcspk_io_write': /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to `pit_set_gate' ../libhw32/hw/pcspk.o: In function `pcspk_io_read': /home/malc/x/rcs/git/qemu/hw/pcspk.c:130:

Re: [Qemu-devel] [PATCH 0/7] x86 CPU patches that didn't get into 1.2

2012-09-17 Thread Andreas Färber
Hi Eduardo, Am 05.09.2012 22:41, schrieb Eduardo Habkost: > This is a small queue of patches that I consider "ready to go", that didn't > enter QEMU 1.2. > > Eduardo Habkost (5): > i386: add missing CPUID_* constants > move CPU models from cpus-x86_64.conf to C > eliminate cpus-x86_64.conf

Re: [Qemu-devel] [PATCH] Versatile Express: add modelling of NOR flash

2012-09-17 Thread Francesco Lavra
On 09/17/2012 03:21 PM, Peter Maydell wrote: > On 5 September 2012 20:07, Francesco Lavra > wrote: >> Documentation at >> http://infocenter.arm.com/help/topic/com.arm.doc.ddi0503c/CHDEFDJF.html >> says that the entire first 512 MB can be mapped to either SMC (which is >> the default) or AXI, so i

Re: [Qemu-devel] QEMU (no kvm) Win7 (64bit) boot error [PATCH 1/1]

2012-09-17 Thread Clemens Kolbitsch
On Mon, Sep 10, 2012 at 10:31 AM, Aurelien Jarno wrote: > On Mon, Sep 10, 2012 at 06:23:43PM +0200, Stefan Weil wrote: >> Am 10.09.2012 08:19, schrieb Clemens Kolbitsch: >> >On Sat, Sep 8, 2012 at 11:22 AM, Clemens Kolbitsch >> > wrote: >> >>On Fri, Sep 7, 2012 at 9:26 PM, Stefan Weil wrote: >> >

Re: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void

2012-09-17 Thread Peter Maydell
On 17 September 2012 18:09, Paolo Bonzini wrote: > Il 17/09/2012 19:06, Peter Maydell ha scritto: >>> > The return value is used nowhere. >> ...it looks like we should probably assert() rather than ploughing >> blindly forward if we try to restore state to match a PC value and >> it doesn't work f

[Qemu-devel] [PATCH 3/9] build: avoid duplicate appearance of files

2012-09-17 Thread Paolo Bonzini
cutils.c and iov.c appeared in the Makefile in multiple spots. Clean this up by moving them respectively to oslib-obj-y and block-obj-y. Notably, qemu-ga and user-mode emulation both need cutils.c but not iov.c. async.o was linked in tools via both tools-obj-y and block-obj-y. Remove the former,

[Qemu-devel] [RFC PATCH 08/10] configure: add --disable-tcg configure option

2012-09-17 Thread Paolo Bonzini
From: Anthony Liguori This lets you build without TCG (KVM/Xen/qtest only). When this flag is passed to configure, it will automatically filter out the target list to only those that support KVM or Xen. Signed-off-by: Anthony Liguori Signed-off-by: Paolo Bonzini --- configure | 38 ++

[Qemu-devel] [PATCH qom-cpu] MAINTAINERS: Add entry for QOM CPU

2012-09-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- I keep bugging other maintainers about documenting their files in MAINTAINERS, yet the CPU files I added were not... I'm queuing this for the next CPU pull. We'll have to update it if we split or rearrange this files for linux-user. MAINTAINERS |6 ++

[Qemu-devel] [PATCH 8/9] libcacard: add include/ to CFLAGS

2012-09-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- libcacard/Makefile | 2 +- 1 file modificato, 1 inserzione(+). 1 rimozione(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 63990b7..c2c0212 100644 --- a/libcacard/Makefile +++ b/libcacard/Makefile @@ -10,7 +10,7 @@ $(call set-vpath, $(SRC_PATH)) QE

[Qemu-devel] [PATCH 9/9] libcacard: remove dependency on QEMU main loop

2012-09-17 Thread Paolo Bonzini
libcacard does not use the QEMU main loop, do not link it in. Signed-off-by: Paolo Bonzini --- Makefile | 2 +- 1 file modificato, 1 inserzione(+). 1 rimozione(-) diff --git a/Makefile b/Makefile index a8078ec..4cc4e3a 100644 --- a/Makefile +++ b/Makefile @@ -158,7 +158,7 @@ qemu-io$(EXESUF): q

Re: [Qemu-devel] [RFC PATCH 01/10] configure: factor out list of supported Xen/KVM targets

2012-09-17 Thread Peter Maydell
On 17 September 2012 18:09, Paolo Bonzini wrote: > Il 17/09/2012 19:02, Peter Maydell ha scritto: >> If Xen requires 64 bit physaddrs it should probably just be asserting >> this here, not randomly changing target_phys_bits. In fact all the >> supported Xen target archs already have 64 bit physadd

Re: [Qemu-devel] [RFC PATCH 09/10] i386: move TCG functions out of helper.o, non-TCG functions to cpu.o

2012-09-17 Thread Peter Maydell
On 17 September 2012 17:00, Paolo Bonzini wrote: > This lets non-TCG build remove *_helper.c from the build. > > Signed-off-by: Paolo Bonzini > --- > target-i386/cpu.c | 18 ++ > target-i386/excp_helper.c | 24 > target-i386/fpu_helper.c | 18 ---

Re: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void

2012-09-17 Thread Paolo Bonzini
Il 17/09/2012 19:06, Peter Maydell ha scritto: >> > The return value is used nowhere. > ...it looks like we should probably assert() rather than ploughing > blindly forward if we try to restore state to match a PC value and > it doesn't work for some reason. Couldn't that mean simply that the tb f

Re: [Qemu-devel] [RFC PATCH 01/10] configure: factor out list of supported Xen/KVM targets

2012-09-17 Thread Paolo Bonzini
Il 17/09/2012 19:02, Peter Maydell ha scritto: > If Xen requires 64 bit physaddrs it should probably just be asserting > this here, not randomly changing target_phys_bits. In fact all the > supported Xen target archs already have 64 bit physaddrs, so it's > harmless. But if there ever were a target

[Qemu-devel] [PATCH 7/9] build: use nesting magic for tools-obj-y

2012-09-17 Thread Paolo Bonzini
Move this variable to Makefile.objs, together with all the other lists of object files. Signed-off-by: Paolo Bonzini --- Makefile | 5 - Makefile.objs | 9 + 2 file modificati, 9 inserzioni(+), 5 rimozioni(-) diff --git a/Makefile b/Makefile index fffbbb8..a8078ec 100644 --- a/

Re: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void

2012-09-17 Thread Peter Maydell
On 17 September 2012 17:00, Paolo Bonzini wrote: > The return value is used nowhere. ...it looks like we should probably assert() rather than ploughing blindly forward if we try to restore state to match a PC value and it doesn't work for some reason. -- PMM

Re: [Qemu-devel] [PATCH 04/13] tcg-sparc: Assume v9 cpu always, i.e. force v8plus in 32-bit mode.

2012-09-17 Thread Richard Henderson
On 09/17/2012 09:04 AM, Andreas Färber wrote: > Without knowing the code, this does not strike me as the best of ideas: > SPARC CPUs are rather uncommon these days, so being able to emulate it > in sparc32-softmmu may be helpful for keeping it working. > > Could you elaborate on what exactly is br

[Qemu-devel] [PATCH 6/9] build: add $(TARGET_DIR) to "GEN config-target.h" lines

2012-09-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- rules.mak | 2 +- 1 file modificato, 1 inserzione(+). 1 rimozione(-) diff --git a/rules.mak b/rules.mak index 0327426..13ba62b 100644 --- a/rules.mak +++ b/rules.mak @@ -71,7 +71,7 @@ TRACETOOL=$(PYTHON) $(SRC_PATH)/scripts/tracetool.py @test -f $@ || cp

  1   2   3   >