[Qemu-devel] [PATCH v6 08/13] target-mips-ase-dsp: Add bit/manipulation instructions

2012-08-20 Thread Jia Liu
Add MIPS ASE DSP Bit/Manipulation instructions. Signed-off-by: Jia Liu --- target-mips/dsp_helper.c | 79 + target-mips/helper.h |7 ++ target-mips/translate.c | 289 +- 3 files changed, 374 insertions(+), 1 deletion(-) diff --

[Qemu-devel] [PATCH v6 03/13] target-mips-ase-dsp: Add branch instructions

2012-08-20 Thread Jia Liu
Add MIPS ASE DSP Branch instructions. Signed-off-by: Jia Liu --- target-mips/translate.c | 52 +++ 1 file changed, 48 insertions(+), 4 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 0793153..b049238 100644 --- a/ta

[Qemu-devel] [PATCH v6 01/13] target-mips-ase-dsp: Add internal functions

2012-08-20 Thread Jia Liu
Add internal functions using by MIPS ASE DSP instructions. Signed-off-by: Jia Liu --- target-mips/Makefile.objs |2 +- target-mips/dsp_helper.c | 1277 + 2 files changed, 1278 insertions(+), 1 deletion(-) create mode 100644 target-mips/dsp_helper

Re: [Qemu-devel] qemu log function to print out the registers of the guest

2012-08-20 Thread Steven
Hi, Max, I wrote a small program to verify your patch could catch all the load instructions from the guest. However, I found some problem from the results. The guest OS and the emulated machine are both 32bit x86. My simple program in the guest declares an 1048576-element integer array, initialize

Re: [Qemu-devel] [PATCH V2 0/6] virtio-trace: Support virtio-trace

2012-08-20 Thread Amit Shah
On (Thu) 09 Aug 2012 [21:30:29], Yoshihiro YUNOMAE wrote: > Hi All, > > The following patch set provides a low-overhead system for collecting kernel > tracing data of guests by a host in a virtualization environment. ACK this series. I ran it through the virtio-serial test suite, and there's no

Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-08-20 Thread Amit Shah
On (Tue) 21 Aug 2012 [11:47:16], Rusty Russell wrote: > On Thu, 9 Aug 2012 15:46:20 +0530, Amit Shah wrote: > > Hi, > > > > On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote: > > > Hi All, > > > > > > The following patch set provides a low-overhead system for collecting > > > kernel > >

Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-08-20 Thread Rusty Russell
On Thu, 9 Aug 2012 15:46:20 +0530, Amit Shah wrote: > Hi, > > On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote: > > Hi All, > > > > The following patch set provides a low-overhead system for collecting kernel > > tracing data of guests by a host in a virtualization environment. > > So I

Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?

2012-08-20 Thread liu ping fan
On Sun, Aug 19, 2012 at 7:36 PM, Avi Kivity wrote: > On 08/19/2012 02:23 PM, Peter Maydell wrote: >> On 19 August 2012 11:12, Avi Kivity wrote: >>> On 08/17/2012 10:41 AM, liu ping fan wrote: And something like omap_mpu_timer_init() in file hw/omap1.c , the opaque(omap_mpu_timer_s) is g

Re: [Qemu-devel] [PATCH] i2c: factor out VMSD to parent class

2012-08-20 Thread Peter Crosthwaite
- I guess there is same reasy why you want to split the device state, it could be on the other series where I haven't read it though. >> >> So this is exactly what I have done in the SSI. Correct me if I am >> wrong but it is the same setup as PCI where the VMSTATE_PCI_DEVICE >> (V

Re: [Qemu-devel] [Bug 1038070] [NEW] > qemu-kvm-1.1.1-r1 - USB activkey doesn't work anymore

2012-08-20 Thread Michael Roth
On Fri, Aug 17, 2012 at 12:50:14PM -, linuxale wrote: > Public bug reported: > > Linux Distro: Gentoo > > Smartcard Activkey doesn't work anymore. I use it without problem till version > qemu-kvm-1.0.1. > > Follow a log extraction: > 2012-08-14 16:27:34.751+: 5487: error : qemuProcessRea

Re: [Qemu-devel] [PATCH uq/master] kvm: Clean up irqfd API

2012-08-20 Thread Alex Williamson
On Mon, 2012-08-20 at 10:55 +0200, Jan Kiszka wrote: > No need to expose the fd-based interface, everyone will already be fine > with the more handy EventNotifier variant. Rename the latter to clarify > that we are still talking about irqfds here. > > Signed-off-by: Jan Kiszka > --- > > Alex, pl

Re: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices

2012-08-20 Thread Alex Williamson
On Sat, 2012-08-18 at 00:28 +1000, Alexey Kardashevskiy wrote: > On Fri, Jun 22, 2012 at 6:16 PM, Alexey Kardashevskiy wrote: > > > On 07/06/12 09:17, Alex Williamson wrote: > > > On Fri, 2012-05-25 at 17:35 +1000, Alexey Kardashevskiy wrote: > > >> Some adapters (like NEC PCI USB controller) do

Re: [Qemu-devel] [PATCH] PPC: Update openbios-bin

2012-08-20 Thread Rob Landley
On 08/20/2012 05:33 PM, Alexander Graf wrote: > This updates the OpenBIOS binaries for PPC to svn revision 1063, > fixing -M g3beige with large PCI memory users. > > Signed-off-by: Alexander Graf Tested-by: Rob Landley Rob -- GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code. Ei

Re: [Qemu-devel] [RFC v0] HACK: qom: object_property_set: abort on failure

2012-08-20 Thread Peter Crosthwaite
On Mon, Aug 20, 2012 at 9:02 PM, Andreas Färber wrote: > Am 20.08.2012 04:18, schrieb Peter Crosthwaite: >> [...] Here's my code as it stands: >> >> Error *errp = NULL; >> object_property_set_link(OBJECT(dev), OBJECT(cpus[0]), "cpu0", &errp); >> assert_no_error(errp); > > There's two pitfalls ther

[Qemu-devel] [PATCH] iSCSI: Add support for SG_IO in bdrv_ioctl()

2012-08-20 Thread Ronnie Sahlberg
We need to support SG_IO in the synchronous bdrv_ioctl() since this is used by scsi-block Signed-off-by: Ronnie Sahlberg --- block/iscsi.c | 109 - 1 files changed, 108 insertions(+), 1 deletions(-) diff --git a/block/iscsi.c b/block/iscs

[Qemu-devel] [PATCH] iSCSI: Add support for SG_IO to bdrv_ioctl()/iscsi_ioctl()

2012-08-20 Thread Ronnie Sahlberg
Paolo, List Please find a patch that adds emulation of SG_IO to the synchronous function bdrv_ioctl()/iscsi_ioctl(). Previously we have only supported emulation for this ioctl in iSCSI for the asynchronous function iscsi_aio_ioctl() since that is the only place scsi-generic uses SG_IO. By adding

[Qemu-devel] [PATCH] target-mips: Enable access to required RDHWR hardware registers

2012-08-20 Thread Meador Inge
While running in the usermode emulator all of the MIPS32r2 *required* RDHWR hardware registers should be accessible (the Linux kernel enables access to these same registers). Signed-off-by: Meador Inge --- target-mips/translate.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort

2012-08-20 Thread ronnie sahlberg
On Mon, Aug 20, 2012 at 6:12 PM, Stefan Priebe - Profihost AG wrote: > Hi Ronnie, > > Am 20.08.2012 10:08, schrieb Paolo Bonzini: > >> That's because the "big QEMU lock" is held by the thread that called >> qemu_aio_cancel. >> >>> and i also see >>> no cancellation message in kernel log. >> >> >>

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-20 Thread Nicholas A. Bellinger
On Sun, 2012-08-19 at 11:44 +0300, Michael S. Tsirkin wrote: > On Sat, Aug 18, 2012 at 05:36:26PM -0700, Nicholas A. Bellinger wrote: > > On Sat, 2012-08-18 at 22:12 +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 14, 2012 at 01:31:14PM -0700, Nicholas A. Bellinger wrote: > > > > On Mon, 2012-08

Re: [Qemu-devel] [PATCH v4] linux-user: fix emulation of getdents

2012-08-20 Thread Dmitry V. Levin
In case when TARGET_ABI_BITS == 32 && HOST_LONG_BITS == 64, the last byte of the target dirent structure (aka d_type byte) was never copied from the host dirent structure, thus breaking everything that relies on valid d_type value, e.g. glob(3). Signed-off-by: Dmitry V. Levin --- linux-user/sysc

Re: [Qemu-devel] [PATCH v3] linux-user: fix emulation of getdents

2012-08-20 Thread Peter Maydell
On 20 August 2012 22:36, Dmitry V. Levin wrote: > In case when TARGET_ABI_BITS == 32 && HOST_LONG_BITS == 64, the last > byte of the target dirent structure (aka d_type byte) was never copied > from the host dirent structure, thus breaking everything that relies > on valid d_type value, e.g. glob(

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-20 Thread Anthony Liguori
"Daniel P. Berrange" writes: > From: "Daniel P. Berrange" > > Add a 'query-target' QAPI command to allow management applications > to determine what target architecture a QEMU binary is emulating > without having to parse the binary name or -help output > > $ qmp-shell -p /tmp/qemu > (QEMU)

[Qemu-devel] [PATCH v3] linux-user: fix emulation of getdents

2012-08-20 Thread Dmitry V. Levin
In case when TARGET_ABI_BITS == 32 && HOST_LONG_BITS == 64, the last byte of the target dirent structure (aka d_type byte) was never copied from the host dirent structure, thus breaking everything that relies on valid d_type value, e.g. glob(3). Signed-off-by: Dmitry V. Levin --- linux-user/sysc

Re: [Qemu-devel] [RFC V4 3/9] quorum: Add quorum_open() and quorum_close().

2012-08-20 Thread Eric Blake
On 08/20/2012 01:47 PM, Blue Swirl wrote: > On Mon, Aug 20, 2012 at 11:47 AM, Benoît Canet wrote: >> Valid quorum resources look like: >> quorum:threshold/total:path/to/image_1: ... :path/to/image_total >> >> '\' can escape the ':' character. Also, \ escapes itself (although admittedly : is more

Re: [Qemu-devel] [Bug 657006] Re: arm v7M - svc insn doesn't trigger PendSV handler

2012-08-20 Thread Peter Maydell
On 20 August 2012 17:43, Mark Phillips wrote: > I have been experimenting with Sebastian's patches mentioned earlier > (http://git.rtems.org/rtems/tree/c/src/lib/libbsp/arm/lm3s69xx?id=e1ebfebf1bffe3e7731ac529409bd2576285467b) > and think I have found another major issue:-( > > My reading of the A

Re: [Qemu-devel] TPM does not seem to work under QEMU with TPM patches

2012-08-20 Thread Kent Yoder
Hi Jordi, On Mon, Aug 20, 2012 at 06:12:44PM -0400, Jordi Cucurull Juan wrote: > Dear all, > > I am testing the TPM patches of Stefan Berger to provide TPM support > to QEMU. Nevertheless I have not managed to run them successfully. > During the compilation of QEMU with his patches (V18 for revis

[Qemu-devel] [Bug 657006] Re: arm v7M - svc insn doesn't trigger PendSV handler

2012-08-20 Thread Mark Phillips
I have been experimenting with Sebastian's patches mentioned earlier (http://git.rtems.org/rtems/tree/c/src/lib/libbsp/arm/lm3s69xx?id=e1ebfebf1bffe3e7731ac529409bd2576285467b) and think I have found another major issue:-( My reading of the ARM documentation is that the SVC opcode should perform a

Re: [Qemu-devel] [PATCH] virtio-scsi spec: add per-LUN parameter query

2012-08-20 Thread McPacino
在 2012-8-20 下午9:18,"Paolo Bonzini" 写道: > > Il 20/08/2012 11:03, Cong Meng ha scritto: > > Each virtio scsi HBA has global request queue limits. But the passthrough > > LUNs (scsi-generic) come from different host HBAs may have different request > > queue limits. If the guest sends commands that exc

Re: [Qemu-devel] [PATCH 1/5] move qemu_irq typedef out of cpu-common.h

2012-08-20 Thread Anthony Liguori
Blue Swirl writes: > On Mon, Aug 20, 2012 at 11:13 AM, Igor Mammedov wrote: >> On Mon, 20 Aug 2012 06:41:04 +0200 >> Stefan Weil wrote: >> >>> Am 20.08.2012 01:39, schrieb Igor Mammedov: >>> > it's necessary for making CPU child of DEVICE without >>> > causing circular header deps. >>> > >>> >

[Qemu-devel] [RFC] How should QEMU code handle include statements (was: Re: [PATCH 0/5 v2] cpu: make a child of DeviceState)

2012-08-20 Thread Stefan Weil
Am 20.08.2012 13:47, schrieb Igor Mammedov: On Mon, 20 Aug 2012 06:52:51 +0200 Stefan Weil wrote: I'd prefer if you could keep the following simple pattern: * Start includes in *.c files with config.h (optionally) and qemu-common.h. Can't agree with you on this. I'd say that every header

Re: [Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-20 Thread Luiz Capitulino
On Mon, 20 Aug 2012 19:55:10 + Blue Swirl wrote: > On Mon, Aug 20, 2012 at 3:08 PM, Luiz Capitulino > wrote: > > On Sat, 18 Aug 2012 20:14:54 + > > Blue Swirl wrote: > > > >> Some variables are only used on !win32, declare > >> them only when used. > >> > >> This avoids a warning in mi

Re: [Qemu-devel] [Xen-devel] [PATCH 4/5] cleanup error.h, included qapi-types.h aready has stdbool.h

2012-08-20 Thread Igor Mammedov
On Mon, 20 Aug 2012 12:28:05 -0300 Luiz Capitulino wrote: > On Mon, 20 Aug 2012 01:39:38 +0200 > Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > --- > > error.h |1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/error.h b/error.h > > index 96fc203

Re: [Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 3:08 PM, Luiz Capitulino wrote: > On Sat, 18 Aug 2012 20:14:54 + > Blue Swirl wrote: > >> Some variables are only used on !win32, declare >> them only when used. >> >> This avoids a warning in mingw32 build: >> CCi386-softmmu/monitor.o >> /src/qemu/monitor.c: In

Re: [Qemu-devel] [PATCH 3/5] qapi-types.h doesn't really need to include qemu-common.h

2012-08-20 Thread Igor Mammedov
On Mon, 20 Aug 2012 12:22:10 -0300 Luiz Capitulino wrote: > On Mon, 20 Aug 2012 01:39:37 +0200 > Igor Mammedov wrote: > > > needed to prevent build breakage when CPU becomes a child of DeviceState > > > > Signed-off-by: Igor Mammedov > > --- > > scripts/qapi-types.py |2 +- > > 1 files c

Re: [Qemu-devel] [PATCH v2] configure: properly check if -lrt and -lm is needed

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 12:43 PM, Peter Maydell wrote: > On 16 August 2012 14:22, Natanael Copa wrote: >> Fixes build against uClibc. >> >> uClibc provides 2 versions of clock_gettime(), one with realtime >> support and one without (this is so you can avoid linking in -lrt >> unless actually need

Re: [Qemu-devel] [PATCH v9 3/5] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 1:26 PM, Alon Levy wrote: > Revision bumped to 4 for new IO support, enabled for spice-server >= > 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and > defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= > 0.12.0. > > This io calls the corres

Re: [Qemu-devel] [PATCH v3] pl190: fix read of VECTADDR

2012-08-20 Thread Brendan Fennell
On Mon, 20 Aug 2012, Peter Maydell wrote: On 20 August 2012 18:59, Brendan Fennell wrote: Signed-off-by: Brendan Fennell Reviewed-by: Peter Maydell The () inside the [] aren't actually necessary, but I'm just going to fix those as I take this patch into the arm-devs queue, I think. I've

Re: [Qemu-devel] [PATCH v9 5/5] (temp) FORTIFY_SOURCES hack

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 1:26 PM, Alon Levy wrote: > --- > .gitmodules| 3 +++ > compiler.h | 7 +++ > spice-protocol | 1 + > 3 files changed, 11 insertions(+) > create mode 16 spice-protocol > > diff --git a/.gitmodules b/.gitmodules > index eca876f..ba6844b 100644 > --- a/.gitm

Re: [Qemu-devel] [RFC V4 3/9] quorum: Add quorum_open() and quorum_close().

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 11:47 AM, Benoît Canet wrote: > Valid quorum resources look like: > quorum:threshold/total:path/to/image_1: ... :path/to/image_total > > '\' can escape the ':' character. > > Signed-off-by: Benoit Canet > --- > block/quorum.c | 110 >

Re: [Qemu-devel] [PATCH 1/5] move qemu_irq typedef out of cpu-common.h

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 11:13 AM, Igor Mammedov wrote: > On Mon, 20 Aug 2012 06:41:04 +0200 > Stefan Weil wrote: > >> Am 20.08.2012 01:39, schrieb Igor Mammedov: >> > it's necessary for making CPU child of DEVICE without >> > causing circular header deps. >> > >> > Signed-off-by: Igor Mammedov >

Re: [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection

2012-08-20 Thread Peter Maydell
On 20 August 2012 19:45, Bruce Rogers wrote: > When building qemu-kvm for openSUSE:Factory, I am getting a > warning in the pipe2 detection performed by configure, which > prevents using --enable-werror. > > Change detection code to use return value of pipe2. > > Signed-off-by: Bruce Rogers Revi

Re: [Qemu-devel] qemu-ga : Guest Agent : Windows 2008 : Unknown command guest-fsfreeze-freeze

2012-08-20 Thread Michael Roth
On Mon, Aug 20, 2012 at 10:54:29AM -0300, Luiz Capitulino wrote: > On Fri, 17 Aug 2012 10:11:29 -0700 (PDT) > desi babu wrote: > > > Guest-Agent : Windows 2008 Error : Relase 1.1.90 > > > > error : internal error unable to execute QEMU command > > 'guest-fsfreeze-freeze': this feature or comman

[Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection

2012-08-20 Thread Bruce Rogers
When building qemu-kvm for openSUSE:Factory, I am getting a warning in the pipe2 detection performed by configure, which prevents using --enable-werror. Change detection code to use return value of pipe2. Signed-off-by: Bruce Rogers --- configure |3 +-- 1 files changed, 1 insertions(+), 2

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-20 Thread Luiz Capitulino
On Mon, 20 Aug 2012 15:31:38 +0100 "Daniel P. Berrange" wrote: > From: "Daniel P. Berrange" > > Add a 'query-target' QAPI command to allow management applications > to determine what target architecture a QEMU binary is emulating > without having to parse the binary name or -help output > >

Re: [Qemu-devel] [PATCH] Hack qmp.py to support reading a JSON multi-line response

2012-08-20 Thread Luiz Capitulino
On Mon, 20 Aug 2012 19:25:02 +0100 "Daniel P. Berrange" wrote: > On Mon, Aug 20, 2012 at 03:03:11PM -0300, Luiz Capitulino wrote: > > On Mon, 20 Aug 2012 15:01:37 +0100 > > "Daniel P. Berrange" wrote: > > > > > From: "Daniel P. Berrange" > > > > > > The qmp-shell code assumes the JSON respons

Re: [Qemu-devel] [PATCH] Add a '-r' option to qmp-shell to print out raw JSON replies

2012-08-20 Thread Daniel P. Berrange
On Mon, Aug 20, 2012 at 03:22:35PM -0300, Luiz Capitulino wrote: > On Mon, 20 Aug 2012 15:02:23 +0100 > "Daniel P. Berrange" wrote: > > > From: "Daniel P. Berrange" > > > > By default, the JSON reply is parsed and the corresponding python > > object printed on the console. When developing JSON

Re: [Qemu-devel] [PATCH] Hack qmp.py to support reading a JSON multi-line response

2012-08-20 Thread Daniel P. Berrange
On Mon, Aug 20, 2012 at 03:03:11PM -0300, Luiz Capitulino wrote: > On Mon, 20 Aug 2012 15:01:37 +0100 > "Daniel P. Berrange" wrote: > > > From: "Daniel P. Berrange" > > > > The qmp-shell code assumes the JSON response is only on a single > > line. If the QEMU monitor is configured in "pretty pr

Re: [Qemu-devel] [PATCH] Add a '-r' option to qmp-shell to print out raw JSON replies

2012-08-20 Thread Luiz Capitulino
On Mon, 20 Aug 2012 15:02:23 +0100 "Daniel P. Berrange" wrote: > From: "Daniel P. Berrange" > > By default, the JSON reply is parsed and the corresponding python > object printed on the console. When developing JSON client apps > for QEMU though, it is handy to see the raw JSON document instead

[Qemu-devel] [PATCH for-1.2 v7 13/14] pci: Derive PCI host bridges from TYPE_PCI_HOST_BRIDGE

2012-08-20 Thread Andreas Färber
Use PCIHostState and PCI_HOST_BRIDGE() where appropriate. Signed-off-by: Andreas Färber --- hw/alpha_typhoon.c |4 ++-- hw/bonito.c| 22 +++--- hw/dec_pci.c |4 ++-- hw/grackle_pci.c |6 +++--- hw/gt64xxx.c |4 ++-- hw/piix_pci.c |

[Qemu-devel] [PATCH for-1.2 v7 08/14] ppce500_pci: QOM'ify e500 PCI host bridge

2012-08-20 Thread Andreas Färber
Introduce type constant and cast macro. Avoid accessing parent fields directly. Signed-off-by: Andreas Färber Acked-by: Michael S. Tsirkin --- hw/ppce500_pci.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c index 9974

Re: [Qemu-devel] [PATCH] Hack qmp.py to support reading a JSON multi-line response

2012-08-20 Thread Luiz Capitulino
On Mon, 20 Aug 2012 15:01:37 +0100 "Daniel P. Berrange" wrote: > From: "Daniel P. Berrange" > > The qmp-shell code assumes the JSON response is only on a single > line. If the QEMU monitor is configured in "pretty print" mode > the JSON response can be multi-line. The basic Python JSON APIs > d

[Qemu-devel] [PATCH] Drop redundant resume_all_vcpus from main

2012-08-20 Thread Jan Kiszka
VCPUs are either resumed directly via vm_start, after the incoming migration is done, or when a continue command is issued. We don't need the explicit resume before entering main_loop. Signed-off-by: Jan Kiszka --- I was adding nesting support to pause/resume_all_vcpus, and that stumbled over th

Re: [Qemu-devel] [PATCH v3] pl190: fix read of VECTADDR

2012-08-20 Thread Peter Maydell
On 20 August 2012 18:59, Brendan Fennell wrote: > Signed-off-by: Brendan Fennell Reviewed-by: Peter Maydell The () inside the [] aren't actually necessary, but I'm just going to fix those as I take this patch into the arm-devs queue, I think. I've also expanded the commit message a little: ==

[Qemu-devel] [PATCH v3] pl190: fix read of VECTADDR

2012-08-20 Thread Brendan Fennell
Signed-off-by: Brendan Fennell --- hw/pl190.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/pl190.c b/hw/pl190.c index cb50afb..b372da8 100644 --- a/hw/pl190.c +++ b/hw/pl190.c @@ -117,12 +117,18 @@ static uint64_t pl190_read(void *opaque, target_p

Re: [Qemu-devel] commit da57febfed "qdev: give all devices a canonical path" broke usb_del

2012-08-20 Thread Anthony Liguori
Michael Tokarev writes: > On 08.08.2012 17:09, Michael Tokarev wrote: > [] >> Something similar should be applied to 1.1-stable. FWIW, some >> changes are not needed there. > > Cherry-pick to stable-1.1 removes the two unneeded hunks. > This is what I plan to include into debian package. It > f

Re: [Qemu-devel] [PATCH v2] pl190: fix read of VECTADDR

2012-08-20 Thread Brendan Fennell
On Mon, 20 Aug 2012, Peter Maydell wrote: On 19 August 2012 11:59, Brendan Fennell wrote: Signed-off-by: Brendan Fennell --- hw/pl190.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/pl190.c b/hw/pl190.c index cb50afb..eddb531 100644 --- a/hw/pl190.c +++ b/h

[Qemu-devel] [PATCH for-1.2 v7 12/14] pci_host: Turn into SysBus-derived QOM type

2012-08-20 Thread Andreas Färber
From: Andreas Färber The preceding commits fixed misuses of FROM_SYSBUS() that led people to add a bogus busdev field. For qdev the field order was less relevant but for QOM the PCIHostState field (including the SysBusDevice actually initialized with a value) must be placed first within the state

[Qemu-devel] [PATCH for-1.2 v7 11/14] unin_pci: QOM'ify UniNorth PCI host bridges

2012-08-20 Thread Andreas Färber
Introduce type constants and cast macros. Avoid accessing parent fields directly. Signed-off-by: Andreas Färber Acked-by: Michael S. Tsirkin --- hw/unin_pci.c | 133 ++--- 1 files changed, 70 insertions(+), 63 deletions(-) diff --git a/hw/un

[Qemu-devel] [PATCH for-1.2 v7 00/14] pci_host: Convert to QOM

2012-08-20 Thread Andreas Färber
Hello Anthony, Here's the merged version of the series making pci_host a first-class QOM type. Conflicts were in the spapr_pci patch (suggest to fully re-review that one) and in the derive-from patch (additional/changed cast locations, rather trivial). Regards, Andreas Cc: Anthony Liguori Cc:

[Qemu-devel] [PATCH for-1.2 v7 10/14] spapr_pci: QOM'ify sPAPR PCI host bridge

2012-08-20 Thread Andreas Färber
Introduce type constant. Introduce cast macro to drop bogus busdev field that would've broken SYS_BUS_DEVICE(). Avoid accessing parent fields directly. Free the identifier phb as acronym for PCI_HOST_BRIDGE. Updated against conflicting merge from branch 'agraf/ppc-for-upstream' (0d16fdd732d1b2118

[Qemu-devel] [PATCH for-1.2 v7 07/14] ppc4xx_pci: QOM'ify ppc4xx PCI host bridge

2012-08-20 Thread Andreas Färber
Introduce type constant and cast macro. Avoid accessing its parent field directly. Signed-off-by: Andreas Färber Acked-by: Michael S. Tsirkin --- hw/ppc440_bamboo.c |3 ++- hw/ppc4xx.h|2 ++ hw/ppc4xx_pci.c| 13 - 3 files changed, 12 insertions(+), 6 deletions(

[Qemu-devel] [PATCH for-1.2 v7 06/14] gt64xxx: QOM'ify GT64120 PCI host bridge

2012-08-20 Thread Andreas Färber
Introduce type constant. Introduce cast macro to drop dummy busdev field used with FROM_SYSBUS() macro that would've broken SYS_BUS_DEVICE(). Avoid accessing DeviceState indirectly through PCIHostState. Signed-off-by: Andreas Färber Acked-by: Michael S. Tsirkin --- hw/gt64xxx.c | 35 +

[Qemu-devel] [PATCH for-1.2 v7 01/14] pci: Make host bridge TypeInfos const

2012-08-20 Thread Andreas Färber
During the QOM migration they were amended with further info but this is no longer the case. All static TypeInfos can be const these days. Signed-off-by: Andreas Färber Acked-by: Michael S. Tsirkin --- hw/alpha_typhoon.c |2 +- hw/bonito.c|4 ++-- hw/dec_pci.c |6 +++--

[Qemu-devel] [PATCH for-1.2 v7 02/14] alpha_typhoon: QOM'ify Typhoon PCI host bridge

2012-08-20 Thread Andreas Färber
Introduce type constant and cast macro. Don't access DeviceState or PCIHostState indirectly through parent fields. Signed-off-by: Andreas Färber Acked-by: Michael S. Tsirkin --- hw/alpha_typhoon.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/al

[Qemu-devel] [PATCH for-1.2 v7 03/14] bonito: QOM'ify Bonito PCI host bridge

2012-08-20 Thread Andreas Färber
Introduce type constant. Avoid accessing DeviceState or SysBusDevice indirectly through PCIHostState field. Drop global state by passing BonitoState as opaque and adding the IRQs and a pointer to PCIBonitoState to its state. Signed-off-by: Andreas Färber Acked-by: Michael S. Tsirkin --- hw/bon

[Qemu-devel] [PATCH for-1.2 v7 14/14] pci: Tidy up PCI host bridges

2012-08-20 Thread Andreas Färber
Adopt the QOM parent field name and enforce QOM-style access via casts. Don't just typedef PCIHostState, either use it directly or embed it. Signed-off-by: Andreas Färber --- hw/alpha_typhoon.c |2 +- hw/dec_pci.c |2 +- hw/grackle_pci.c |2 +- hw/gt64xxx.c | 26 +

Re: [Qemu-devel] x86, nops settings result in kernel crash

2012-08-20 Thread Tomas Racek
- Original Message - > On Fri, Aug 17, 2012 at 03:43:56AM -0400, Tomas Racek wrote: > > Well, I've added some debug statements to the code: > > > > void __init arch_init_ideal_nops(void) > > { > > switch (boot_cpu_data.x86_vendor) { > > case X86_VENDOR_INTEL: > >

[Qemu-devel] [PATCH for-1.2 v7 09/14] prep_pci: QOM'ify Raven PCI host bridge

2012-08-20 Thread Andreas Färber
Introduce type constant and cast macro. Avoid accessing parent fields directly. Also add missing space and braces. Signed-off-by: Andreas Färber Acked-by: Michael S. Tsirkin --- hw/prep_pci.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/prep_pci.

[Qemu-devel] [PATCH for-1.2 v7 04/14] dec_pci: QOM'ify DEC 21154 PCI-PCI bridge

2012-08-20 Thread Andreas Färber
Introduce type constant. Introduce cast macro and drop dummy busdev field used with FROM_SYSBUS() that would've broken SYS_BUS_DEVICE(). Avoid accessing parent fields directly. Signed-off-by: Andreas Färber Acked-by: Michael S. Tsirkin --- hw/dec_pci.c | 21 +++-- hw/dec_pci.h

[Qemu-devel] [PATCH for-1.2 v7 05/14] grackle_pci: QOM'ify Grackle PCI host bridge

2012-08-20 Thread Andreas Färber
Introduce type constant. Introduce cast macro to drop dummy busdev field used with FROM_SYSBUS() that would've broken SYS_BUS_DEVICE(). Avoid accessing parent fields directly. Drop no-op reset function. Signed-off-by: Andreas Färber Acked-by: Michael S. Tsirkin --- hw/grackle_pci.c | 57

Re: [Qemu-devel] [PATCH v2] linux-user: fix emulation of getdents

2012-08-20 Thread Peter Maydell
On 18 August 2012 22:56, Dmitry V. Levin wrote: > In case when TARGET_ABI_BITS == 32 && HOST_LONG_BITS == 64, the last > byte of the target dirent structure (aka d_type byte) was never copied > from the host dirent structure, thus breaking everything that relies > on valid d_type value, e.g. glob(

[Qemu-devel] TPM does not seem to work under QEMU with TPM patches

2012-08-20 Thread Jordi Cucurull Juan
Dear all, I am testing the TPM patches of Stefan Berger to provide TPM support to QEMU. Nevertheless I have not managed to run them successfully. During the compilation of QEMU with his patches (V18 for revision 563987d) I have not had any issue. But, I have a virtual machine based on CentOS

Re: [Qemu-devel] [PATCH] virtio-scsi spec: add per-LUN parameter query

2012-08-20 Thread Paolo Bonzini
Il 20/08/2012 16:44, McPacino ha scritto: > > 在 2012-8-20 下午9:18,"Paolo Bonzini" >写道: >> >> Il 20/08/2012 11:03, Cong Meng ha scritto: >> > Each virtio scsi HBA has global request queue limits. But the > passthrough >> > LUNs (scsi-generic) come from different host HBA

Re: [Qemu-devel] [PATCH 3/3] net: EAGAIN handling for net/socket.c TCP

2012-08-20 Thread Paolo Bonzini
Il 20/08/2012 16:57, Peter Maydell ha scritto: > On 20 August 2012 14:27, Stefan Hajnoczi wrote: >> > Replace spinning send_all() with a proper non-blocking send. When the >> > socket write buffer limit is reached, we should stop trying to send and >> > wait for the socket to become writable agai

[Qemu-devel] For 1.2: Re: [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-20 Thread Eric Blake
On 08/20/2012 08:31 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Add a 'query-target' QAPI command to allow management applications > to determine what target architecture a QEMU binary is emulating > without having to parse the binary name or -help output > > $ qmp-shell -p

Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 3:03 PM, Benoît Canet wrote: > Le Monday 20 Aug 2012 ŕ 13:56:53 (+0100), Stefan Hajnoczi a écrit : >> On Mon, Aug 20, 2012 at 12:42 PM, Benoît Canet >> wrote: >> > >> > Le Monday 20 Aug 2012 ŕ 12:24:33 (+0100), Stefan Hajnoczi a écrit : >> >> On Mon, Aug 20, 2012 at 12:23

Re: [Qemu-devel] [PATCH 4/5] cleanup error.h, included qapi-types.h aready has stdbool.h

2012-08-20 Thread Luiz Capitulino
On Mon, 20 Aug 2012 01:39:38 +0200 Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > error.h |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/error.h b/error.h > index 96fc203..643a372 100644 > --- a/error.h > +++ b/error.h > @@ -14,7 +14,6 @@ > > #inc

Re: [Qemu-devel] [PATCH 3/5] qapi-types.h doesn't really need to include qemu-common.h

2012-08-20 Thread Luiz Capitulino
On Mon, 20 Aug 2012 01:39:37 +0200 Igor Mammedov wrote: > needed to prevent build breakage when CPU becomes a child of DeviceState > > Signed-off-by: Igor Mammedov > --- > scripts/qapi-types.py |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/scripts/qapi-types.p

Re: [Qemu-devel] [PATCH v7 0/6] convert sendkey to qapi

2012-08-20 Thread Luiz Capitulino
On Mon, 20 Aug 2012 07:25:13 -0600 Eric Blake wrote: > On 08/19/2012 10:39 PM, Amos Kong wrote: > > This series converted 'sendkey' command to qapi. The raw value > > in hexadecimal format is not supported by 'send-key' of qmp. > > Are we still trying to get this into 1.2, or have we missed that

Re: [Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-20 Thread Luiz Capitulino
On Sat, 18 Aug 2012 20:14:54 + Blue Swirl wrote: > Some variables are only used on !win32, declare > them only when used. > > This avoids a warning in mingw32 build: > CCi386-softmmu/monitor.o > /src/qemu/monitor.c: In function 'monitor_fdset_get_fd': > /src/qemu/monitor.c:2575: warnin

[Qemu-devel] [PATCH v3] configure: properly check if -lrt and -lm is needed

2012-08-20 Thread Natanael Copa
Fixes build against uClibc. uClibc provides 2 versions of clock_gettime(), one with realtime support and one without (this is so you can avoid linking in -lrt unless actually needed). This means that the clock_gettime() don't need -lrt. We still need it for timer_create() so we check for this func

Re: [Qemu-devel] [PATCH 3/3] net: EAGAIN handling for net/socket.c TCP

2012-08-20 Thread Peter Maydell
On 20 August 2012 14:27, Stefan Hajnoczi wrote: > Replace spinning send_all() with a proper non-blocking send. When the > socket write buffer limit is reached, we should stop trying to send and > wait for the socket to become writable again. > > + > +do { > +ret = writev(s->fd, iov, i

[Qemu-devel] [PATCH 0/3] net: asynchronous send/receive for net/socket.c

2012-08-20 Thread Stefan Hajnoczi
The net subsystem supports non-blocking sockets and asynchronous send/receive. Unfortunately, net/socket.c doesn't fully take advantage of that yet. This patch series makes send asynchronous and drops code that will spin when the non-blocking socket would block. Also take advantage of qemu_set_fd

[Qemu-devel] [PATCH 3/4] s390: sclp signal quiesce support

2012-08-20 Thread Jens Freimann
From: Heinz Graalfs This implements the sclp signal quiesce event via the SCLP Event Facility. This allows to gracefully shutdown a guest by using system_powerdown. It creates a service interrupt that will trigger a Read Event Data command from the guest. This code will then add an event that is

Re: [Qemu-devel] [PATCH v2] configure: properly check if -lrt and -lm is needed

2012-08-20 Thread Peter Maydell
On 20 August 2012 15:33, Natanael Copa wrote: > On Mon, Aug 20, 2012 at 3:27 PM, Peter Maydell > wrote: >> The test program is failing to link with this >> /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../x86_64-linux-gnu/librt.a(timer_create.o): >> In function `timer_create': >> (.text+0x121): undefi

[Qemu-devel] [PATCH 1/3] net: asynchronous send/receive infrastructure for net/socket.c

2012-08-20 Thread Stefan Hajnoczi
The net/socket.c net client is not truly asynchronous. This patch borrows the qemu_set_fd_handler2() code from net/tap.c as the basis for proper asynchronous send/receive. Only read packets from the socket when the peer is able to receive. This avoids needless queuing. Later patches implement as

Re: [Qemu-devel] [PATCH v2] pl190: fix read of VECTADDR

2012-08-20 Thread Peter Maydell
On 19 August 2012 11:59, Brendan Fennell wrote: > > Signed-off-by: Brendan Fennell > --- > hw/pl190.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/hw/pl190.c b/hw/pl190.c > index cb50afb..eddb531 100644 > --- a/hw/pl190.c > +++ b/hw/pl190.c > @@ -120,7 +120,8 @

Re: [Qemu-devel] [PATCH v2] configure: properly check if -lrt and -lm is needed

2012-08-20 Thread Natanael Copa
On Mon, Aug 20, 2012 at 3:27 PM, Peter Maydell wrote: > On 16 August 2012 14:22, Natanael Copa wrote: >> Fixes build against uClibc. >> >> uClibc provides 2 versions of clock_gettime(), one with realtime >> support and one without (this is so you can avoid linking in -lrt >> unless actually neede

[Qemu-devel] [PATCH 5/5] virtio-scsi: add backwards-compatibility properties for 1.1 and earlier machines

2012-08-20 Thread Paolo Bonzini
Hotplug and parameter change are new in 1.2, disable them via compat properties for pc-1.1 and earlier. Signed-off-by: Paolo Bonzini --- hw/pc_piix.c | 8 hw/virtio-scsi.c | 7 --- hw/virtio-scsi.h | 9 - 3 file modificati, 16 inserzioni(+), 8 rimozioni(-) diff --git a/

[Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a 'query-target' QAPI command to allow management applications to determine what target architecture a QEMU binary is emulating without having to parse the binary name or -help output $ qmp-shell -p /tmp/qemu (QEMU) query-target { u'return': { u'arch': u'

[Qemu-devel] [PATCH v2 5/5] spice: adding seamless-migration option to the command line

2012-08-20 Thread Yonit Halperin
The seamless-migration flag is required in order to identify whether libvirt supports the new QEVENT_SPICE_MIGRATE_COMPLETED or not (by default the flag is off). New libvirt versions that wait for QEVENT_SPICE_MIGRATE_COMPLETED should turn on this flag. When this flag is off, spice fallbacks to it

Re: [Qemu-devel] [PATCH v2] configure: properly check if -lrt and -lm is needed

2012-08-20 Thread Peter Maydell
On 16 August 2012 14:22, Natanael Copa wrote: > Fixes build against uClibc. > > uClibc provides 2 versions of clock_gettime(), one with realtime > support and one without (this is so you can avoid linking in -lrt > unless actually needed). This means that the clock_gettime() don't > need -lrt. We

[Qemu-devel] [PATCH 4/4] s390: sclp ascii console support

2012-08-20 Thread Jens Freimann
From: Heinz Graalfs This code adds console support by implementing SCLP's ASCII Console Data event. This is the same console as LPARs ASCII console or z/VMs sysascii. The console can be specified manually with something like -chardev stdio,id=charconsole0 -device sclpconsole,chardev=charconsole

[Qemu-devel] [PATCH 1/4] s390: sclp base support

2012-08-20 Thread Jens Freimann
From: Heinz Graalfs This adds a more generic infrastructure for handling Service-Call requests on s390. Currently we only support a small subset of Read SCP Info directly in target-s390x. This patch provides the base infrastructure for supporting more commands and moves Read SCP Info. In the futu

[Qemu-devel] [PATCH 2/4] s390: sclp event support

2012-08-20 Thread Jens Freimann
From: Heinz Graalfs Several SCLP features are considered to be events. Those events don't provide SCLP commands on their own, instead they are all based on Read Event Data, Write Event Data, Write Event Mask and the service interrupt. Follow-on patches will provide SCLP's Signal Quiesce (via syst

[Qemu-devel] [PATCH 0/4 v4] s390: sclp patch set

2012-08-20 Thread Jens Freimann
This patch-set improves the Service-Call Logical Processor support for s390. changes v3->v4: - Event Facility was moved to the main system bus and we now keep the event_facility pointer within the current machine's global property-list as opaque pointer - removed locking - some code refactor

[Qemu-devel] [PATCH 3/3] net: EAGAIN handling for net/socket.c TCP

2012-08-20 Thread Stefan Hajnoczi
Replace spinning send_all() with a proper non-blocking send. When the socket write buffer limit is reached, we should stop trying to send and wait for the socket to become writable again. Non-blocking TCP sockets can return in two different ways when the write buffer limit is reached: 1. ret = -

[Qemu-devel] [PATCH 2/3] net: EAGAIN handling for net/socket.c UDP

2012-08-20 Thread Stefan Hajnoczi
Implement asynchronous send for UDP (or other SOCK_DGRAM) sockets. If send fails with EAGAIN we wait for the socket to become writable again. Signed-off-by: Stefan Hajnoczi --- net/socket.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/net/socket.c b/net/

[Qemu-devel] [PATCH v9 4/5] configure: print spice-protocol and spice-server versions

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index ff6443e..aae051b 100755 --- a/configure +++ b/configure @@ -2657,6 +2657,8 @@ EOF spice="yes" libs_softmmu="$libs_softmmu $spice_libs" QEMU_CFLA

[Qemu-devel] [PATCH v2 0/5] add support for spice migration v2

2012-08-20 Thread Yonit Halperin
v2: Notify spice about vm state changes only via spice_server_vm_start/stop spice repo: http://cgit.freedesktop.org/~yhalperi/spice/log/?h=seamless-migration.v2 --- Hi, The following series introduces support for keeping the spice session active after migration. For more details about s

  1   2   >