Re: [Qemu-devel] [PATCH 4/6] blkdebug: store list of active rules

2012-07-03 Thread Kevin Wolf
Am 03.07.2012 18:03, schrieb Paolo Bonzini: > Il 03/07/2012 17:40, Kevin Wolf ha scritto: case ACTION_INJECT_ERROR: -vars->inject_errno = rule->options.inject.error; -vars->inject_once= rule->options.inject.once; -vars->inject_immediate

Re: [Qemu-devel] [v1 Patch 3/10]Qemu: Cmd "block_set_hostcache" for dynamic cache change

2012-07-03 Thread Kevin Wolf
Am 04.07.2012 07:10, schrieb Shrinidhi Joshi: > Updated patch to auto generate qmp_marshal_input_block_set_hostcache > > > New command "block_set_hostcache" added for dynamically changing > host pagecache setting of a block devic

[Qemu-devel] [RFC][PATCH 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-03 Thread YeongKyoon Lee
Add an option "--enable-ldst-optimization" to enable CONFIG_QEMU_LDST_OPTIMIZATION macro for TCG qemu_ld/st optimization. Signed-off-by: Yeongkyoon Lee --- configure | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 9f071b7..2b364cc

[Qemu-devel] [RFC][PATCH 3/4] tcg: add optimized TCG qemu_ld/st generation

2012-07-03 Thread YeongKyoon Lee
Add optimized TCG qemu_ld/st generation which generates the code for TLB miss case handling at the end of TB after generating other IRs. Signed-off-by: Yeongkyoon Lee --- tcg/i386/tcg-target.c | 328 + tcg/tcg.c | 12 ++ tcg/tcg.h

[Qemu-devel] [RFC][PATCH 2/4] tcg: add extended MMU helpers to targets

2012-07-03 Thread YeongKyoon Lee
Add extended MMU helpers to softmmu targets, where the targets are alpha, arm, cris, i386, lm32, m68k, microblaze, mips, ppc, s390x, sh4, sparc and xtensa. Signed-off-by: Yeongkyoon Lee --- target-alpha/mem_helper.c | 22 ++ target-arm/op_helper.c| 23 +

[Qemu-devel] [RFC][PATCH 1/4] tcg: add declarations and templates of extended MMU helpers

2012-07-03 Thread YeongKyoon Lee
Add declarations and templates of extended MMU helpers which can take return address argument to what helper functions return. Signed-off-by: Yeongkyoon Lee --- softmmu_defs.h | 13 + softmmu_template.h | 51 +-- 2 files changed,

[Qemu-devel] [RFC][PATCH 0/4] tcg: enhance code generation quality for qemu_ld/st IRs

2012-07-03 Thread YeongKyoon Lee
Hi, all. I think the generated codes from qemu_ld/st IRs are relatively heavy, which are up to 12 instructions for TLB hit case on i386 host. This patch series enhances the code quality of TCG qemu_ld/st IRs by reducing jump and enhancing locality. Main idea is simple and has been already descri

Re: [Qemu-devel] [PATCH 08/14] megasas: LSI Megaraid SAS HBA emulation

2012-07-03 Thread Hannes Reinecke
On 07/03/2012 09:09 PM, Blue Swirl wrote: > On Mon, Jul 2, 2012 at 9:41 AM, Paolo Bonzini wrote: >> From: Hannes Reinecke >> >> This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. >> I've tested it to work with Linux, Windows Vista, and Windows7. >> >> Signed-off-by: Hannes Reineck

Re: [Qemu-devel] SMP for PReP architecture

2012-07-03 Thread Eli Lewis
>> >> Stuart, Scott, is there any helpful documentation available for 750 -> > e500 conversion? > > Read the chip manuals, the ISA and/or EREF, and look at what Linux does > differently for each. Thank you!   > What is POK? A simple real time embedded OS. http://pok.safety-critical.net/ Eli

[Qemu-devel] [PATCH 2/2] pci: Unregister BARs before device exit

2012-07-03 Thread Alex Williamson
BARs are registered in init functions from memory regions created by the drivers. Exit functions destroy those memory regions. By unregistering the io regions after exit(), we're calling memory_region_del_subregion on freed memory. Don't do that. The option rom comes along for the ride because i

[Qemu-devel] [PATCH 1/2] pci: convert PCIUnregisterFunc to void

2012-07-03 Thread Alex Williamson
Not a single driver has any possibility of failure on their exit function, let's keep it that way. Signed-off-by: Alex Williamson --- hw/ac97.c |3 +-- hw/e1000.c |3 +-- hw/eepro100.c |3 +-- hw/es1370.c |3 +-- hw/ide/cmd646.c

[Qemu-devel] [PATCH 0/2] pci: exit path cleanup and fix

2012-07-03 Thread Alex Williamson
We've currently got a bug in pci_unregister_device in the ordering of calling the driver exit function and unregistering io regions. In every driver memory regions are created in the init function and destroyed in the exit function. By calling pci_unregister_io_regions after the exit function, we

Re: [Qemu-devel] [PATCH] fix qemu compile error with --enable-debug

2012-07-03 Thread Wanpeng Li
On Wed, Jul 04, 2012 at 10:51:25AM +0800, Dunrong Huang wrote: >There have been two discussions about this error: >http://lists.nongnu.org/archive/html/qemu-devel/2012-06/msg04858.html >and >http://lists.nongnu.org/archive/html/qemu-devel/2012-06/msg04728.html > Oh, thank you! > >2012/7/4 Wanpeng

Re: [Qemu-devel] [PATCH 4/4] target-arm: add minimal dump-guest-memory support

2012-07-03 Thread Wen Congyang
At 06/29/2012 08:42 PM, Andreas Färber Wrote: > Am 28.06.2012 18:46, schrieb Peter Maydell: >> On 20 June 2012 18:28, Rabin Vincent wrote: >>> Add a minimal dump-guest-memory support for ARM. The -p option is not >>> supported and we don't add any QEMU-specific notes. >> >> So what does this patc

Re: [Qemu-devel] [PATCH] fix qemu compile error with --enable-debug

2012-07-03 Thread Dunrong Huang
There have been two discussions about this error: http://lists.nongnu.org/archive/html/qemu-devel/2012-06/msg04858.html and http://lists.nongnu.org/archive/html/qemu-devel/2012-06/msg04728.html 2012/7/4 Wanpeng Li : > From: Wanpeng Li > > CC i386-softmmu/target-i386/translate.o > /home/kerne

Re: [Qemu-devel] [PATCH 4/4] target-arm: add minimal dump-guest-memory support

2012-07-03 Thread Wen Congyang
At 07/01/2012 02:22 PM, Rabin Vincent Wrote: > On Thu, Jun 28, 2012 at 05:46:02PM +0100, Peter Maydell wrote: >> On 20 June 2012 18:28, Rabin Vincent wrote: >>> Add a minimal dump-guest-memory support for ARM. The -p option is not >>> supported and we don't add any QEMU-specific notes. >> >> So w

Re: [Qemu-devel] [PATCH 2/4] dump: extract out note helper

2012-07-03 Thread Wen Congyang
Hi, Rabin Sorry for later reviewing... At 06/21/2012 01:28 AM, Rabin Vincent Wrote: > Make a common helper function to add ELF notes. > > Signed-off-by: Rabin Vincent > --- > dump.c | 49 +++ > dump.h |4 + > target-i386/arch_dump.c | 206 > +++

[Qemu-devel] [PATCH] fix qemu compile error with --enable-debug

2012-07-03 Thread Wanpeng Li
From: Wanpeng Li CC i386-softmmu/target-i386/translate.o /home/kernel/qemu/target-i386/translate.c: In function ‘gen_sse’: /home/kernel/qemu/target-i386/translate.c:3571:27: error: assignment from incompatible pointer type [-Werror] /home/kernel/qemu/target-i386/translate.c:3573:17: error:

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-03 Thread Wayne Xia
于 2012-7-4 0:18, 陳韋任 (Wei-Ren Chen) 写道: + + Note: When qemu-nbd was used to export a disk that would be used by QEMU +block device, -t or --persistent must be set for that QEMU nbd client would try +connect more than one time. For eg: ^^ Not a native engli

Re: [Qemu-devel] [PATCH 2/4] dump: extract out note helper

2012-07-03 Thread Wen Congyang
At 06/21/2012 01:28 AM, Rabin Vincent Wrote: > Make a common helper function to add ELF notes. > > Signed-off-by: Rabin Vincent > --- > dump.c | 49 +++ > dump.h |4 + > target-i386/arch_dump.c | 206 > +++-

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-03 Thread Wayne Xia
于 2012-7-3 19:55, Paolo Bonzini 写道: Il 03/07/2012 13:05, xiaw...@linux.vnet.ibm.com ha scritto: + + Note: When qemu-nbd was used to export a disk that would be used by QEMU +block device, -t or --persistent must be set for that QEMU nbd client would try +connect more than one time. For eg: + q

Re: [Qemu-devel] [PATCH 3/4] dump: extract out get note size function

2012-07-03 Thread Wen Congyang
At 06/21/2012 01:28 AM, Rabin Vincent Wrote: > Extract out the ELF note size function from i386 so we can use it from > other targets. > > Signed-off-by: Rabin Vincent This patch looks fine to me. Thanks Wen Congyang > --- > dump.c | 15 +++ > dump.h

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-03 Thread Wayne Xia
On 03.07.2012 15:05, xiaw...@linux.vnet.ibm.com wrote: From: Wenchao Xia Qemu system emulator reports only fails that make people confused about why, when it is invoked with nbd block device tring to connect qemu-nbd server. In fact qemu will try connect server for several times but server on

Re: [Qemu-devel] [PATCH v14 13/13] Add XBZRLE statistics

2012-07-03 Thread Eric Blake
On 07/03/2012 07:52 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > > ## > # @MigrationInfo > @@ -282,13 +307,18 @@ > #status, only returned if status is 'active' and it is a b

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Jason Baron
On Tue, Jul 03, 2012 at 10:54:37PM +0200, Alexander Graf wrote: > On 03.07.2012, at 22:37, Jason Baron wrote: > > > On Tue, Jul 03, 2012 at 08:52:50PM +0200, Alexander Graf wrote: > >> On 03.07.2012, at 20:46, Jason Baron wrote: > >> > >>> On Tue, Jul 03, 2012 at 08:41:29PM +0200, Alexander Graf

Re: [Qemu-devel] [PATCH v2 0/2] QOMify AXI stream for Xilinx AXI ethernet/DMA

2012-07-03 Thread Peter Crosthwaite
Ping! On Thu, Jun 28, 2012 at 8:41 PM, Peter A. G. Crosthwaite wrote: > Next revision of the series for AXI-stream, rebased on anthonys refactoring > of the Interface system. Anthonys patch is already on the mailing list, but I > have included it form completeness. P2 is all the actual axi-stre

Re: [Qemu-devel] [PATCH 3/6] sheepdog: use coroutine based socket functions in coroutine context

2012-07-03 Thread Peter Crosthwaite
On Tue, Jul 3, 2012 at 11:15 PM, Kevin Wolf wrote: > Am 27.06.2012 00:26, schrieb MORITA Kazutaka: >> This removes blocking network I/Os in coroutine context. >> >> Signed-off-by: MORITA Kazutaka >> --- >> block/sheepdog.c | 10 -- >> 1 files changed, 8 insertions(+), 2 deletions(-) >>

Re: [Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-03 Thread Eric Blake
On 07/03/2012 03:39 PM, Eric Blake wrote: > On 07/03/2012 03:32 PM, Eric Blake wrote: > >>> +ret = uleb128_decode_small(src + i, &count); >>> +if (ret < 0) { >> >> An nzrun should be a non-zero value; I'd write this as (ret <= 0) to >> rule out an attempt to pass a zero-length nzru

Re: [Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-03 Thread Eric Blake
On 07/03/2012 03:32 PM, Eric Blake wrote: >> +ret = uleb128_decode_small(src + i, &count); >> +if (ret < 0) { > > An nzrun should be a non-zero value; I'd write this as (ret <= 0) to > rule out an attempt to pass a zero-length nzrun. Correcting myself, if (ret < 0 || !count) {

Re: [Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-03 Thread Eric Blake
On 07/03/2012 07:52 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > +int xbzrle_encode_buffer(uint8_t *old_buf, uint8_t *new_buf, int slen, > + uint8_t *dst, int dle

Re: [Qemu-devel] [PATCH v14 09/13] Add migration_end function

2012-07-03 Thread Eric Blake
On 07/03/2012 07:52 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > arch_init.c |7 ++- > 1 files changed, 6 insertions(+), 1 deletions(-) You failed to account for my v13 review that you missed a hunk in this patch (you mistakenly delayed it to 11/13). Furthermore, ha

Re: [Qemu-devel] [PATCH v14 04/13] Add cache handling functions

2012-07-03 Thread Eric Blake
On 07/03/2012 07:52 AM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > +PageCache *cache_init(int64_t num_pages, un

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Alexander Graf
On 03.07.2012, at 22:37, Jason Baron wrote: > On Tue, Jul 03, 2012 at 08:52:50PM +0200, Alexander Graf wrote: >> On 03.07.2012, at 20:46, Jason Baron wrote: >> >>> On Tue, Jul 03, 2012 at 08:41:29PM +0200, Alexander Graf wrote: On 03.07.2012, at 20:38, Jason Baron wrote: > On Tue,

Re: [Qemu-devel] [RFC PATCH] Expose tsc deadline timer feature to guest

2012-07-03 Thread Marcelo Tosatti
On Mon, Jul 02, 2012 at 11:08:14AM +, Liu, Jinsong wrote: > Eduardo, Jan, Andreas > > As we sync 3 months ago, I wait until qemu1.1 done, then re-write patch based > on qemu1.1. > Now it's time to re-write my patch based on qemu1.1. > > Attached is a RFC patch for exposing tsc deadline timer

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Jason Baron
On Tue, Jul 03, 2012 at 08:52:50PM +0200, Alexander Graf wrote: > On 03.07.2012, at 20:46, Jason Baron wrote: > > > On Tue, Jul 03, 2012 at 08:41:29PM +0200, Alexander Graf wrote: > >> On 03.07.2012, at 20:38, Jason Baron wrote: > >> > >>> On Tue, Jul 03, 2012 at 08:25:52PM +0200, Alexander Graf

Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

2012-07-03 Thread Andreas Färber
Am 03.07.2012 21:11, schrieb Blue Swirl: > On Mon, Jul 2, 2012 at 2:34 PM, Stefan Hajnoczi wrote: >> On Mon, Jul 2, 2012 at 3:15 PM, Markus Armbruster wrote: >>> Andreas Färber writes: >>> Am 02.07.2012 14:55, schrieb Stefan Hajnoczi: > On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus A

Re: [Qemu-devel] SMP for PReP architecture

2012-07-03 Thread Scott Wood
On 07/03/2012 02:45 PM, Alexander Graf wrote: > > On 03.07.2012, at 07:07, Eli Lewis wrote: > >>> >> Maybe we can change the BSP of POK in order to support the MPC8544DS board. >>> >>> It's not only the board. Kernel mode is vastly different from the 601 >>> you're probably targeting t

Re: [Qemu-devel] [PATCH v14 04/13] Add cache handling functions

2012-07-03 Thread Eric Blake
On 07/03/2012 01:23 PM, Blue Swirl wrote: >> + >> +static inline int64_t round2pow2(int64_t value) round up or down? >> +{ >> +while (!is_power_of_2(value)) { >> +value &= ~(1 << (ffs(value) - 1)); > > ffs() only uses 'int', not int64_t. ffsl() is not universally available. > >>

Re: [Qemu-devel] [PATCH v14 03/13] Add XBZRLE documentation

2012-07-03 Thread Eric Blake
On 07/03/2012 07:52 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > docs/xbzrle.txt | 133 > +++ > 1 files changed, 133 insertions(+), 0 deletions(-) > create mode 100644 docs/xbzrle.txt > + > +Example > +old buffer: > +100

Re: [Qemu-devel] SMP for PReP architecture

2012-07-03 Thread Alexander Graf
On 03.07.2012, at 07:07, Eli Lewis wrote: >> > >>> Maybe >>> we can change the BSP of POK in order to support the MPC8544DS board. >> >> It's not only the board. Kernel mode is vastly different from the 601 >> you're probably targeting today. >> > > > Currently POK > supposes to run on a s

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-03 Thread Michael Tokarev
On 03.07.2012 15:05, xiaw...@linux.vnet.ibm.com wrote: > From: Wenchao Xia > > Qemu system emulator reports only fails that make people confused > about why, when it is invoked with nbd block device tring to connect > qemu-nbd server. In fact qemu will try connect server for several > times but

Re: [Qemu-devel] [PATCH v14 07/13] Add debugging infrastructure

2012-07-03 Thread Blue Swirl
On Tue, Jul 3, 2012 at 1:52 PM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > arch_init.c | 33 +++-- > 1 files changed, 27 insertions(+), 6 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 9dafb6e..ee20c33 100644 > --- a/arch_init.c >

Re: [Qemu-devel] [PATCH v14 04/13] Add cache handling functions

2012-07-03 Thread Blue Swirl
On Tue, Jul 3, 2012 at 1:52 PM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- > Makefile.objs |

Re: [Qemu-devel] [PATCH 1/6] qemu-log: move logging to qemu-log.c

2012-07-03 Thread Blue Swirl
On Tue, Jul 3, 2012 at 10:07 AM, Kevin Wolf wrote: > Am 09.06.2012 14:12, schrieb Blue Swirl: >> Move logging functions from exec.c to qemu-log.c, >> compile it only once. >> >> Signed-off-by: Blue Swirl > > This broke the TARGET_I386 specific logging options. Also DEBUG_IOPORT. Maybe the logge

Re: [Qemu-devel] [PATCH 2/6] file_ram_alloc(): use g_strdup_printf() instead of asprintf()

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 6:06 PM, Eduardo Habkost wrote: > Cc: Blue Swirl > Signed-off-by: Eduardo Habkost Acked-by: Blue Swirl > --- > exec.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/exec.c b/exec.c > index c8bfd27..d856325 100644 > --- a/exec.

Re: [Qemu-devel] [PATCH 1/6] file_ram_alloc(): coding style fixes

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 6:06 PM, Eduardo Habkost wrote: > Cc: Blue Swirl > Signed-off-by: Eduardo Habkost Acked-by: Blue Swirl > --- > exec.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/exec.c b/exec.c > index 8244d54..c8bfd27 100644 > --- a/exec.c > +++ b

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 6:05 PM, Corey Bryant wrote: > > > On 06/28/2012 03:49 PM, Blue Swirl wrote: >> >> On Wed, Jun 27, 2012 at 9:25 PM, Anthony Liguori >> wrote: >>> >>> On 06/21/2012 03:04 AM, Avi Kivity wrote: On 06/19/2012 09:58 PM, Blue Swirl wrote: >>> >>> >>> A

Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 2:34 PM, Stefan Hajnoczi wrote: > On Mon, Jul 2, 2012 at 3:15 PM, Markus Armbruster wrote: >> Andreas Färber writes: >> >>> Am 02.07.2012 14:55, schrieb Stefan Hajnoczi: On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote: > Best to use the same type

Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 9:41 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/scsi-disk.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c > index 747e756..e87e57c 100644 > --- a/hw/scsi-disk.c > +++ b/hw/s

Re: [Qemu-devel] plan for device assignment upstream

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 9:43 AM, Avi Kivity wrote: > On 07/02/2012 12:30 PM, Jan Kiszka wrote: >> On 2012-07-02 11:18, Michael S. Tsirkin wrote: >>> I've been thinking hard about Jan's patches for device >>> assignment. Basically while I thought it makes sense >>> to make all devices: assignment an

Re: [Qemu-devel] [PATCH 07/17] x86: improve SSE table type safety

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 8:53 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> SSE function tables could easily be corrupted because of use >> of void pointers. >> >> Introduce function pointer types and helper variables in order >> to improve type safety. >> >> Split sse_op_table3 according

Re: [Qemu-devel] [PATCH] vga: Implement blinking of text cursor

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 8:20 AM, Jan Kiszka wrote: > Let the text cursor blink at 5 Hz. No timer is used, instead we rely on > the fact that the display is updated periodically. > > Signed-off-by: Jan Kiszka > --- > hw/vga.c | 14 +- > hw/vga_int.h |2 ++ > 2 files changed,

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Alexander Graf
On 03.07.2012, at 20:46, Jason Baron wrote: > On Tue, Jul 03, 2012 at 08:41:29PM +0200, Alexander Graf wrote: >> On 03.07.2012, at 20:38, Jason Baron wrote: >> >>> On Tue, Jul 03, 2012 at 08:25:52PM +0200, Alexander Graf wrote: On 03.07.2012, at 18:16, Jason Baron wrote: > Hi, >>>

Re: [Qemu-devel] [PATCH] w32: Fix broken build (missing include file)

2012-07-03 Thread Blue Swirl
On Sun, Jul 1, 2012 at 2:26 PM, Paolo Bonzini wrote: > Il 16/06/2012 20:48, Artyom Tarasenko ha scritto: >> But still, it's not possible for all contributions, right? >> >> To sum this up: >> GPL v2+ are allowed >> non-GPL contributions are allowed > > Yes, as long as they are GPLv2- and v3-compat

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Jason Baron
On Tue, Jul 03, 2012 at 08:41:29PM +0200, Alexander Graf wrote: > On 03.07.2012, at 20:38, Jason Baron wrote: > > > On Tue, Jul 03, 2012 at 08:25:52PM +0200, Alexander Graf wrote: > >> On 03.07.2012, at 18:16, Jason Baron wrote: > >> > >>> Hi, > >>> > >>> Update on q35 testing with various os's.

Re: [Qemu-devel] [PATCH] target-i386: Fix compilation with --enable-debug

2012-07-03 Thread Blue Swirl
On Sat, Jun 30, 2012 at 1:46 PM, Stefan Weil wrote: > Am 30.06.2012 14:16, schrieb Dunrong Huang: > >> 2012/6/30 Stefan Weil : >>> >>> commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type >>> safety which now raises compiler errors when latest QEMU was configured with >>> --enab

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Alexander Graf
On 03.07.2012, at 20:38, Jason Baron wrote: > On Tue, Jul 03, 2012 at 08:25:52PM +0200, Alexander Graf wrote: >> On 03.07.2012, at 18:16, Jason Baron wrote: >> >>> Hi, >>> >>> Update on q35 testing with various os's. >>> >>> Linux >>> - >>> -RHEL6.3 installs + runs >>> -Fedora 16 install

Re: [Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c

2012-07-03 Thread Blue Swirl
On Sat, Jun 30, 2012 at 5:50 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote: >>> Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, >>> except it was put into block.c. Device-specific functionality should >>> be kep

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Jason Baron
On Tue, Jul 03, 2012 at 08:25:52PM +0200, Alexander Graf wrote: > On 03.07.2012, at 18:16, Jason Baron wrote: > > > Hi, > > > > Update on q35 testing with various os's. > > > > Linux > > - > > -RHEL6.3 installs + runs > > -Fedora 16 install + runs > > -Fedora 17 - squashfs errors > > run

Re: [Qemu-devel] [PATCH v14 02/13] Add migration capabilities

2012-07-03 Thread Eric Blake
On 07/03/2012 07:52 AM, Orit Wasserman wrote: > Add migration capabilities that can be queried by the management. > The management can query the source QEMU and the destination QEMU in order to > verify both support some migration capability (currently only XBZRLE). > The management can enable a ca

Re: [Qemu-devel] q35 and ahci

2012-07-03 Thread Alexander Graf
On 03.07.2012, at 18:16, Jason Baron wrote: > Hi, > > Update on q35 testing with various os's. > > Linux > - > -RHEL6.3 installs + runs > -Fedora 16 install + runs > -Fedora 17 - squashfs errors > running on already installed f17 seems ok. > > Windows > --- > -W7 - install error: >

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Corey Bryant
On 07/03/2012 02:00 PM, Eric Blake wrote: On 07/03/2012 11:46 AM, Corey Bryant wrote: Yes, I think adding a +1 to the refcount for the monitor makes sense. I'm a bit unsure how to increment the refcount when a monitor reconnects though. Maybe it is as simple as adding a +1 to each fd's ref

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Eric Blake
On 07/03/2012 11:46 AM, Corey Bryant wrote: > > Yes, I think adding a +1 to the refcount for the monitor makes sense. > > I'm a bit unsure how to increment the refcount when a monitor reconnects > though. Maybe it is as simple as adding a +1 to each fd's refcount when > the next QMP monitor con

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Corey Bryant
On 07/03/2012 01:03 PM, Eric Blake wrote: On 07/03/2012 10:25 AM, Corey Bryant wrote: I thought qemu would rather return the number of the fdset (which it also assigns if none it passed, i.e. for fdset creation). Does libvirt need the number of an individual fd? If libvirt prefers to assign

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Eric Blake
On 07/03/2012 10:25 AM, Corey Bryant wrote: >> I thought qemu would rather return the number of the fdset (which it >> also assigns if none it passed, i.e. for fdset creation). Does libvirt >> need the number of an individual fd? >> >> If libvirt prefers to assign fdset numbers itself, I'm not aga

Re: [Qemu-devel] race condition in qemu-kvm-1.0.1

2012-07-03 Thread Marcelo Tosatti
On Wed, Jun 27, 2012 at 12:35:22PM +0200, Peter Lieven wrote: > Hi, > > we recently came across multiple VMs racing and stopping working. It > seems to happen when the system is at 100% cpu. > One way to reproduce this is: > qemu-kvm-1.0.1 with vnc-thread enabled > > cmdline (or similar): > /usr/

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Corey Bryant
On 07/03/2012 11:59 AM, Kevin Wolf wrote: Am 03.07.2012 17:40, schrieb Corey Bryant: Thanks again for taking time to discuss this at today's QEMU community call. Here's the proposal we discussed at the call. Please let me know if I missed anything or if there are any issues with this design.

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-03 Thread Wei-Ren Chen
> + > + Note: When qemu-nbd was used to export a disk that would be used by QEMU > +block device, -t or --persistent must be set for that QEMU nbd client would > try > +connect more than one time. For eg: ^^ Not a native english speaker, but I never see such u

[Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-03 Thread xiawenc
From: Wenchao Xia Qemu system emulator reports only fails that make people confused about why, when it is invoked with nbd block device tring to connect qemu-nbd server. In fact qemu will try connect server for several times but server only accept one connect by default. I paid some times to

[Qemu-devel] q35 and ahci

2012-07-03 Thread Jason Baron
Hi, Update on q35 testing with various os's. Linux - -RHEL6.3 installs + runs -Fedora 16 install + runs -Fedora 17 - squashfs errors running on already installed f17 seems ok. Windows --- -W7 - install error: "A required cd/dvd device driver is missing. If you have a driver floppy

[Qemu-devel] [Bug 1020484] [NEW] RFE: Support spice via unix domain socket

2012-07-03 Thread Till Maas
Public bug reported: According to the man page, spice can be only used via TCP/IP in opposite to VNC, which can also be configured to listen on a unix domain socket. To make it easy to use spice without exposing the interface, please support unix domain sockets as well. I can try to provide a pat

[Qemu-devel] qemu doesn't handle big frame in codes for emulating e1000 NIC

2012-07-03 Thread Rugang Chen
I use "e1000" NIC in virtual guest, and the driver in the guest has disable LPE(write "~E1000_RCTL_LPE" to "E1000_RCTL" register of e1000 NIC). But the virtual NIC still forward big frame(bigger than MTU set to the driver) to the driver. And in the file "hw/e1000.c", I don't say any codes that han

Re: [Qemu-devel] KVM call agenda for Tuesday, July 3rd

2012-07-03 Thread 王永博
does KVM have the function like vmsafe to develop security software for Virtualization 。 2012/7/2 Juan Quintela : > > Hi > > Please send in any agenda items you are interested in covering. > > Later, Juan. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a me

Re: [Qemu-devel] [PATCH 4/6] blkdebug: store list of active rules

2012-07-03 Thread Paolo Bonzini
Il 03/07/2012 17:40, Kevin Wolf ha scritto: >> > case ACTION_INJECT_ERROR: >> > -vars->inject_errno = rule->options.inject.error; >> > -vars->inject_once= rule->options.inject.once; >> > -vars->inject_immediately = rule->options.inject.immediately; >> > +

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Kevin Wolf
Am 03.07.2012 17:40, schrieb Corey Bryant: > Thanks again for taking time to discuss this at today's QEMU community call. > > Here's the proposal we discussed at the call. Please let me know if I > missed anything or if there are any issues with this design. > > Proposal Five: New monitor comm

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Corey Bryant
On 07/02/2012 06:02 PM, Corey Bryant wrote: On 06/26/2012 06:54 PM, Eric Blake wrote: On 06/26/2012 04:28 PM, Corey Bryant wrote: With this proposed series, we have usage akin to: 1. pass_fd FDSET={M} -> returns a string "/dev/fd/N" showing QEMU's view of the FD 2. drive_ad

Re: [Qemu-devel] [PATCH 4/6] blkdebug: store list of active rules

2012-07-03 Thread Kevin Wolf
Am 06.06.2012 08:10, schrieb Paolo Bonzini: > This prepares for the next patch, where some active rules may actually > not trigger depending on input to readv/writev. Store the active rules > in a SIMPLEQ (so that it can be emptied easily with QSIMPLEQ_INIT), and > fetch the errno/once/immediately

Re: [Qemu-devel] [PATCH] Use clean shutdown request for ctrl-a x

2012-07-03 Thread Fabien Chouteau
On 07/03/2012 04:49 PM, Paolo Bonzini wrote: > Il 03/07/2012 16:00, Peter Maydell ha scritto: >> I was just talking on #qemu this morning about the equivalent question >> of whether the ARM semihosting exit function ought to be doing a >> qemu_system_shutdown_request rather than a plain exit()... >

[Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-03 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- migration.h |4 ++ savevm.c| 172 +++ 2 files changed, 176 insertions(+), 0 deletions(-) diff --git a/migra

Re: [Qemu-devel] [PATCH 0/6] blkdebug changes extracted from 1.2 streaming patches

2012-07-03 Thread Paolo Bonzini
Il 06/06/2012 08:10, Paolo Bonzini ha scritto: > Hi, > > these patches are prerequisites for testing streaming error handling. > They should be useful on their own, so I am sending them early to keep > the queue small. > > Paolo Bonzini (6): > blkdebug: remove sync i/o events > blkdebug: tiny

[Qemu-devel] [PATCH v14 12/13] Add set_cachesize command

2012-07-03 Thread Orit Wasserman
Change XBZRLE cache size in bytes (the size should be a power of 2). If XBZRLE cache size is too small there will be many cache miss. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- arch_init.c | 10 ++ hm

Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor

2012-07-03 Thread Jan Kiszka
On 2012-07-03 16:41, Stefan Weil wrote: > Am 02.07.2012 10:20, schrieb Jan Kiszka: >> Let the text console cursor blink at 5 HZ. >> >> Signed-off-by: Jan Kiszka >> --- >> console.c | 26 +- >> 1 files changed, 25 insertions(+), 1 deletions(-) >> > > Hi Jan, > > I know that

[Qemu-devel] [PATCH v14 01/13] Add MigrationParams structure

2012-07-03 Thread Orit Wasserman
From: Isaku Yamahata Signed-off-by: Isaku Yamahata --- block-migration.c |8 migration.c | 13 - migration.h |8 ++-- qemu-common.h |1 + savevm.c | 13 + sysemu.h |3 ++- vmstate.h |2 +- 7 f

Re: [Qemu-devel] [PATCH] Use clean shutdown request for ctrl-a x

2012-07-03 Thread Paolo Bonzini
Il 03/07/2012 16:00, Peter Maydell ha scritto: > I was just talking on #qemu this morning about the equivalent question > of whether the ARM semihosting exit function ought to be doing a > qemu_system_shutdown_request rather than a plain exit()... > > The interesting question for the qemu-char cas

[Qemu-devel] [PATCH v14 00/13] XBZRLE delta for live migration of large memory app

2012-07-03 Thread Orit Wasserman
Changes from v13: - Fix round to power of 2 of cache size - Add more checks to the XBZRLE encoding. - use comparison instead of XOR when calculating zrun_len - use strcmp trick for calculating nzrun_len (algorithm from Eric Blake) - Fix other comments by Eric

Re: [Qemu-devel] [PATCH v6 5/6] fdc_test: update media_change test

2012-07-03 Thread Pavel Hrdina
On 06/25/2012 11:50 AM, Kevin Wolf wrote: Am 22.06.2012 12:33, schrieb Pavel Hrdina: After rewrite DSKCHG bit handling the test has to be updated. Now is needed to seek to different track to clear DSKCHG bit. Signed-off-by: Pavel Hrdina --- tests/fdc-test.c | 29 +---

[Qemu-devel] [PATCH v14 13/13] Add XBZRLE statistics

2012-07-03 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- arch_init.c | 68 +- hmp.c| 13 ++ migration.c | 49 +

Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor

2012-07-03 Thread Stefan Weil
Am 02.07.2012 10:20, schrieb Jan Kiszka: Let the text console cursor blink at 5 HZ. Signed-off-by: Jan Kiszka --- console.c | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) Hi Jan, I know that there was a "bug" report. Nevertheless I'd like to ask whether QE

[Qemu-devel] [PATCH v14 02/13] Add migration capabilities

2012-07-03 Thread Orit Wasserman
Add migration capabilities that can be queried by the management. The management can query the source QEMU and the destination QEMU in order to verify both support some migration capability (currently only XBZRLE). The management can enable a capability for the next migration by using migrate_set_p

[Qemu-devel] [PATCH v14 04/13] Add cache handling functions

2012-07-03 Thread Orit Wasserman
Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- Makefile.objs |1 + include/qemu/page_cache.h | 79 + page_cache.c

Re: [Qemu-devel] [PATCH 1/2] virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE

2012-07-03 Thread Paolo Bonzini
Il 03/07/2012 15:46, Kevin Wolf ha scritto: >> > Introduce a new feature bit and configuration field that provide >> > support for toggling the cache mode between writethrough and writeback. >> > >> > Also rename VIRTIO_BLK_F_WCACHE to VIRTIO_BLK_F_WCE for consistency with >> > the spec. > My spec

[Qemu-devel] [PATCH v14 09/13] Add migration_end function

2012-07-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/arch_init.c b/arch_init.c index e763909..66df017 100644 --- a/arch_init.c +++ b/arch_init.c @@ -304,6 +304,11 @@ static void sort_ram_list(void) g_free(blocks); } +

[Qemu-devel] [PATCH v14 11/13] Add XBZRLE to ram_save_block and ram_save_live

2012-07-03 Thread Orit Wasserman
In the outgoing migration check to see if the page is cached and changed than send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set and decompress the page (by using load_xbrle function). Signed-off-by: Benoit Hudzia Signed-of

[Qemu-devel] [PATCH v14 08/13] Change ram_save_block to return -1 if there are no more changes

2012-07-03 Thread Orit Wasserman
It will return 0 if the page is unmodifed. Signed-off-by: Orit Wasserman --- arch_init.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch_init.c b/arch_init.c index ee20c33..e763909 100644 --- a/arch_init.c +++ b/arch_init.c @@ -188,7 +188,7 @@ static int r

[Qemu-devel] [PATCH v14 05/13] Add uleb encoding/decoding functions

2012-07-03 Thread Orit Wasserman
Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman --- cutils.c | 32 qemu-common.h |8 2 files changed, 40 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index af308cd..3f81d53 100644 --- a/cutils.c +++

[Qemu-devel] [PATCH v14 06/13] Add save_block_hdr function

2012-07-03 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- arch_init.c | 26 ++ 1 files changed, 14 insertions(+), 12 deletions(-) diff --git a/arch_init.c b/arch_init.c index a9e8b74..9dafb6e 100644 --- a

Re: [Qemu-devel] [PATCH] Use clean shutdown request for ctrl-a x

2012-07-03 Thread Peter Maydell
On 3 July 2012 14:38, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- > qemu-char.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-char.c b/qemu-char.c > index c2aaaee..1f43c95 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -353,7 +353,7 @@

[Qemu-devel] [PATCH v14 07/13] Add debugging infrastructure

2012-07-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 33 +++-- 1 files changed, 27 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index 9dafb6e..ee20c33 100644 --- a/arch_init.c +++ b/arch_init.c @@ -44,6 +44,14 @@ #include "exec-memory.h" #includ

[Qemu-devel] [PATCH v14 03/13] Add XBZRLE documentation

2012-07-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- docs/xbzrle.txt | 133 +++ 1 files changed, 133 insertions(+), 0 deletions(-) create mode 100644 docs/xbzrle.txt diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt new file mode 100644 index 000..f00d63f ---

Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated

2012-07-03 Thread Paolo Bonzini
Il 03/07/2012 15:49, Kevin Wolf ha scritto: >> If the guest does not support flushes, we should run in writethrough mode. >> > The setting is temporary until the next reset, so that for example the >> > BIOS will run in writethrough mode while Linux will run with a writeback >> > cache. >> > >> >

  1   2   >