Re: [Qemu-devel] Request VFIO inclusion in linux-next

2012-06-27 Thread Dan Carpenter
On Wed, Jun 27, 2012 at 01:23:23PM -0600, Alex Williamson wrote: > On Wed, 2012-06-27 at 15:37 +0300, Dan Carpenter wrote: > > On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: > > > Hi, > > > > > > VFIO has been kicking around for well over a year now and has been > > > posted nume

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-27 Thread Markus Armbruster
Blue Swirl writes: > On Wed, Jun 27, 2012 at 6:01 AM, Markus Armbruster wrote: >> Blue Swirl writes: >> >>> On Tue, Jun 26, 2012 at 6:41 PM, Peter Maydell >>> wrote: On 26 June 2012 19:25, Blue Swirl wrote: > On Tue, Jun 26, 2012 at 6:11 PM, Peter Maydell > wrote: >> On 26

Re: [Qemu-devel] [PATCH] target-i386: implement FPREM and FPREM1 using softfloat only

2012-06-27 Thread Stefan Weil
Am 28.06.2012 01:00, schrieb Catalin Patulea: Hey guys, I've been hacking up the FPREM and FPREM1 i386 instructions (without KVM) to be implemented using SoftFloat only. This was motivated by some correctness issues that we noticed with the current implementation which follows the AMD datasheet

[Qemu-devel] [PATCH] target-i386: implement FPREM and FPREM1 using softfloat only

2012-06-27 Thread Catalin Patulea
Hey guys, I've been hacking up the FPREM and FPREM1 i386 instructions (without KVM) to be implemented using SoftFloat only. This was motivated by some correctness issues that we noticed with the current implementation which follows the AMD datasheet.I believe the datasheet explains the operation

[Qemu-devel] [PATCH v1] xilinx_timer: Removed comma in device name

2012-06-27 Thread Peter A. G. Crosthwaite
Fixes an error in a61e4b07a30c062260d2d01771773f14820d1eb7 Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx.h |2 +- hw/xilinx_timer.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xilinx.h b/hw/xilinx.h index 7df21eb..c4d9d19 100644 --- a/hw/xilinx

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-06-27 Thread Peter Crosthwaite
>> not at a valid yield point. But whats really wrong here is the block >> layer will be making assumption on re-entry of the coroutine, so I >> cant re-enter it witout wildly changing the behaviour of the block >> layer. If you adopt this "mark it as coroutine" poilcy, you end up >> with a system

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Paul Brook
> 'guest_validate_base' is currently called for three reasons: (1) in main.c > when using -B, (2) in main.c when using -R after mapping the reserved va > region, and (3) and when probing for a guest base in probe_guest_base. > > For case (1) I suppose things are pretty much the same -- we just nee

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Meador Inge
On 06/27/2012 07:47 PM, Paul Brook wrote: >> On 28.06.2012, at 02:06, Paul Brook wrote: > openSUSE uses a version patched so that IIUC 3G are reserved. > Just today this failed on a system where swap got disabled and the > mmap() thus failed. Err... why? We map with MAP_NORE

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-27 Thread Marcelo Tosatti
On Sat, Jun 23, 2012 at 11:22:07AM +0200, Jan Kiszka wrote: > On 2012-06-23 02:22, Marcelo Tosatti wrote: > > On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: > >> Should have declared this [RFC] in the subject and CC'ed kvm... > >> > >> On 2012-06-23 00:45, Jan Kiszka wrote: > >>> This

Re: [Qemu-devel] [PATCH 5/6 v5] deal with guest panicked event accoring to -onpanic parameter

2012-06-27 Thread Wen Congyang
At 06/27/2012 10:39 PM, Jan Kiszka Wrote: > On 2012-06-27 09:02, Wen Congyang wrote: >> When the guest is panicked, it will write 0x1 to the port KVM_PV_PORT. >> So if qemu reads 0x1 from this port, we can do the folloing three >> things according to the parameter -onpanic: >> 1. emit QEVENT_GUEST_

Re: [Qemu-devel] [PATCH v2 11/11] xilinx_axidma: changed device name

2012-06-27 Thread Peter Crosthwaite
On Thu, Jun 28, 2012 at 9:06 AM, Alexander Graf wrote: > > On 16.06.2012, at 03:11, Edgar E. Iglesias wrote: > >> On Fri, Jun 15, 2012 at 01:30:17PM +0200, Andreas Färber wrote: >>> Am 13.06.2012 06:46, schrieb Peter A. G. Crosthwaite: Changed device name to xlnx,axi-dma. This is the exact na

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Paul Brook
> On 28.06.2012, at 02:06, Paul Brook wrote: > >>> openSUSE uses a version patched so that IIUC 3G are reserved. > >>> Just today this failed on a system where swap got disabled and the > >>> mmap() thus failed. > >> > >> Err... why? We map with MAP_NORESERVE, so swap shouldn't matter... > > > >

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Meador Inge
On 06/27/2012 12:32 PM, Richard Henderson wrote: > On 06/27/2012 08:51 AM, Meador Inge wrote: >> To solve this issue I experimented with performing a similar probing in >> 'main' >> as in 'probe_guest_base' so that we can find a reserved VA region that also >> passes validation. If a region isn'

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Alexander Graf
On 28.06.2012, at 02:06, Paul Brook wrote: >>> openSUSE uses a version patched so that IIUC 3G are reserved. >>> Just today this failed on a system where swap got disabled and the >>> mmap() thus failed. >> >> Err... why? We map with MAP_NORESERVE, so swap shouldn't matter... > > I can't say i

[Qemu-devel] [PATCH 0/4] PPC: e500 platform refactoring

2012-06-27 Thread Scott Wood
The current ppc_mpc8544ds.c is split into a generic (eventually) e500 backend, and two platform frontends (mpc8544ds and a generic paravirt e500 platform) that instantiate the backend. Currently the only distinction between the subplatforms is toplevel compatible and model in the device tree (the

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Paul Brook
> > openSUSE uses a version patched so that IIUC 3G are reserved. > > Just today this failed on a system where swap got disabled and the > > mmap() thus failed. > > Err... why? We map with MAP_NORESERVE, so swap shouldn't matter... I can't say if it's the same cause, but we fail with "ulimit -v

[Qemu-devel] [PATCH 4/4] PPC: e500: add generic e500 platform

2012-06-27 Thread Scott Wood
This gives the kernel a paravirtualized machine to target, without requiring both sides to pretend to be targeting a specific board that likely has little to do with the host in KVM scenarios. This avoids the need to add new boards to QEMU, just to be able to run KVM on new CPUs. Signed-off-by: S

[Qemu-devel] [PATCH 1/4] PPC: e500: rename mpc8544ds into generic file

2012-06-27 Thread Scott Wood
Rename the file (with no changes other than fixing up the header paths) in preparation for refactoring into a generic e500 platform. Also move it into the newly created ppc/ directory. Signed-off-by: Scott Wood --- hw/ppc/Makefile.objs |2 +- hw/{ppce500_mpc8544ds.c => ppc

[Qemu-devel] [PATCH 2/4] PPC: e500: change internal references away from mpc8544ds

2012-06-27 Thread Scott Wood
No functional changes -- machine is still outwardly mpc8544ds. The references that are not changed contain mpc8544 hardware details that need to be parameterized if/when a different e500 platform wants to change them. Signed-off-by: Scott Wood --- hw/ppc/e500.c | 27 ++

[Qemu-devel] buildbot failure in qemu on default_s390

2012-06-27 Thread qemu
The Buildbot has detected a new failure on builder default_s390 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_s390/builds/277 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: qemu-s390.opensuse.org Build Reas

Re: [Qemu-devel] [PATCH v2 11/11] xilinx_axidma: changed device name

2012-06-27 Thread Alexander Graf
On 16.06.2012, at 03:11, Edgar E. Iglesias wrote: > On Fri, Jun 15, 2012 at 01:30:17PM +0200, Andreas Färber wrote: >> Am 13.06.2012 06:46, schrieb Peter A. G. Crosthwaite: >>> Changed device name to xlnx,axi-dma. This is the exact name of the device >>> in the >>> Xilinx EDK development tools.

Re: [Qemu-devel] [PATCH v7 15/16] target-or32: Add linux user support

2012-06-27 Thread Jia Liu
Hi Blue, On Thu, Jun 28, 2012 at 2:00 AM, Blue Swirl wrote: > On Wed, Jun 27, 2012 at 9:54 AM, Jia Liu wrote: >> Add QEMU OpenRISC linux user support. >> >> Signed-off-by: Jia Liu >> --- >>  configure                           |    1 + >>  default-configs/or32-linux-user.mak |    1 + >>  linux-

Re: [Qemu-devel] [PATCH 00/11] iommu series

2012-06-27 Thread Anthony Liguori
On 06/26/2012 11:50 PM, Benjamin Herrenschmidt wrote: Only difference (appart from being rebased) is the memory barrier patch getting a couple of curly braces where they were missing. Applied all. Thanks. Regards, Anthony Liguori Cheers, Ben.

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Anthony Liguori
On 06/27/2012 05:14 PM, Alexander Graf wrote: On 28.06.2012, at 00:05, Benjamin Herrenschmidt wrote: On Wed, 2012-06-27 at 23:42 +0200, Alexander Graf wrote: It shouldn't be an #if 0 but an if (cirrus) hw_abort() then though. Otherwise we'd just silently ignore the option. You guys love ab

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Alexander Graf
On 28.06.2012, at 00:05, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-27 at 23:42 +0200, Alexander Graf wrote: >> >> It shouldn't be an #if 0 but an if (cirrus) hw_abort() then though. >> Otherwise we'd just silently ignore the option. > > You guys love aborts too much. For a high level opti

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Benjamin Herrenschmidt
On Wed, 2012-06-27 at 23:42 +0200, Alexander Graf wrote: > > It shouldn't be an #if 0 but an if (cirrus) hw_abort() then though. > Otherwise we'd just silently ignore the option. You guys love aborts too much. For a high level option like -vga I'd rather just fallback to "std" (like afaik some ot

Re: [Qemu-devel] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Alexander Graf
On 27.06.2012, at 23:48, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-27 at 16:32 +0200, Andreas Färber wrote: Did you test whether all those paths actually work with ppc? SPICE didn't support ppc host last time I checked. Does it work on x86 >> host? >>> Currently, I test -vga std,

Re: [Qemu-devel] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Benjamin Herrenschmidt
On Wed, 2012-06-27 at 16:32 +0200, Andreas Färber wrote: > >> Did you test whether all those paths actually work with ppc? SPICE > >> didn't support ppc host last time I checked. Does it work on x86 > host? > > Currently, I test -vga std, it works well. > > SPICE and curris are not supported on pcc

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Alexander Graf
On 27.06.2012, at 23:39, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-27 at 14:08 +0200, Alexander Graf wrote: >> Ben, mind to push a working SLOF, we we can just enable all of it in >> one go and don't have to commit #if 0'ed code? >> >> Rest looks reasonable to me. > > Sure, SLOF was gated

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Benjamin Herrenschmidt
On Wed, 2012-06-27 at 14:08 +0200, Alexander Graf wrote: > Ben, mind to push a working SLOF, we we can just enable all of it in > one go and don't have to commit #if 0'ed code? > > Rest looks reasonable to me. Sure, SLOF was gated by the memop patch but we can push it now. However I'd rather leav

Re: [Qemu-devel] [PATCH 0/3] adding MSI/MSIX for PCI on POWER

2012-06-27 Thread Alexander Graf
On 27.06.2012, at 23:32, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-27 at 16:43 +0200, Alexander Graf wrote: >> On 14.06.2012, at 06:29, Alexey Kardashevskiy wrote: >> >>> The following patches add MSIX support for PCI on POWER. >>> The first aim is virtio-pci so it was tested. It will also

Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server

2012-06-27 Thread Anthony Liguori
On 06/20/2012 08:24 AM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" QEMU now has a fundamental requirement for pthreads, so there is no compelling reason to retain support for the non-threaded VNC server. Remove the --{enable,disable}-vnc-thread configure arguments, and all CONFIG_VNC_T

Re: [Qemu-devel] [PATCH] rtl8139: validate rx ring before receiving packets

2012-06-27 Thread Anthony Liguori
On 05/17/2012 12:25 AM, Jason Wang wrote: Commit ff71f2e8cacefae99179993204172bc65e4303df prevent the possible crash during initialization of linux driver by checking the operating mode.This seems too strict as: - the real card could still work in mode other than normal - some buggy driver who d

Re: [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call

2012-06-27 Thread Alexander Graf
On 27.06.2012, at 23:30, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-27 at 14:30 +0200, Alexander Graf wrote: >> Thanks, applied to ppc-next. Next time, please base on top of a newer >> git base - I had to manually fix the patch to apply. > > It was based on top of qemu master from yesterday

Re: [Qemu-devel] [PATCH 0/3] adding MSI/MSIX for PCI on POWER

2012-06-27 Thread Benjamin Herrenschmidt
On Wed, 2012-06-27 at 16:43 +0200, Alexander Graf wrote: > On 14.06.2012, at 06:29, Alexey Kardashevskiy wrote: > > > The following patches add MSIX support for PCI on POWER. > > The first aim is virtio-pci so it was tested. It will also support > > VFIO when it becomes available in public. > > W

Re: [Qemu-devel] [PATCH] Makefile.target: Update clean command to clean hw/ directory

2012-06-27 Thread Anthony Liguori
On 06/20/2012 12:02 PM, Peter Maydell wrote: Now we create object files in a hierarchy under hw/, so the 'clean' target must also be updated to delete those object files. Rather than using a manual list of subdirectories which will easily drift out of date, we just delete all .o and .d files in t

Re: [Qemu-devel] [PATCH buildfix] configure: Assure existence of linux-headers/ build directory

2012-06-27 Thread Anthony Liguori
On 06/14/2012 10:14 AM, Andreas Färber wrote: Commit ec5b06d (configure: ensure directory exists when creating symlinks) moved the creation of directories into the symlink() function but forgot the case where no symlink is created. This leads to build errors on arm Linux due to -I../linux-header

Re: [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call

2012-06-27 Thread Benjamin Herrenschmidt
On Wed, 2012-06-27 at 14:30 +0200, Alexander Graf wrote: > Thanks, applied to ppc-next. Next time, please base on top of a newer > git base - I had to manually fix the patch to apply. It was based on top of qemu master from yesterday. As you know that's what I work on top of. Did you make sure you

[Qemu-devel] [PATCH 05/11] acpi_table_add(): extract ACPI header creation to separate function

2012-06-27 Thread Eduardo Habkost
No behavior change, just code movement. Signed-off-by: Eduardo Habkost --- hw/acpi.c | 157 + 1 file changed, 84 insertions(+), 73 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c index b5f0531..16e2065 100644 --- a/hw/acpi.c +++ b/hw/

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-27 Thread Anthony Liguori
On 06/21/2012 03:04 AM, Avi Kivity wrote: On 06/19/2012 09:58 PM, Blue Swirl wrote: At least qemu-ifup/down scripts, migration exec and smbd have been mentioned. Only the system calls made by smbd (for some version of it) can be known. The user could specify arbitrary commands for the others, th

[Qemu-devel] [PATCH 06/11] acpi_table_add(): rename 'qemu_len' to 'newlen'

2012-06-27 Thread Eduardo Habkost
Now there's only one "length of the new table" variable inside acpi_table_add() (acpi_len is now inside acpi_make_table_header()), so name it "newlen" instead of "qemu_len". This change looks pointless by itself, but it should make the code clearer after changing the rest of the code handling acpi

[Qemu-devel] [PATCH 09/11] acpi_table_add(): extract acpi_tables reallocation code to a separate function

2012-06-27 Thread Eduardo Habkost
This was the maint point of most of the previous variable renames and calculation-method changes: to isolate the g_realloc() call to avoid doing pointer math with acpi_tables everywhere. No behavior change, just code movement. Signed-off-by: Eduardo Habkost --- hw/acpi.c | 17 ++--

[Qemu-devel] [PATCH 07/11] acpi_table_add(): eliminate 'allen' variable

2012-06-27 Thread Eduardo Habkost
Instead of calculating 'allen - start' every time, just keep the 'newlen' variable up to date and use it instead. The math in g_realloc() call is now more complex (using 'start + newlen' instead of 'allen'), but it be simplified later, when the g_realloc() calls get moved to a separate function.

[Qemu-devel] [PATCH 08/11] acpi_table_add(): eliminate 'start' variable

2012-06-27 Thread Eduardo Habkost
The 'start' variable is initialized with the value of 'acpi_tables_len', but neither 'acpi_tables_len' or 'start' are changed during the acpi_table_add() call (except at the end of the function), so 'start' can be simply replaced by 'acpi_tables_len'. No behavior change, just calculation methods c

Re: [Qemu-devel] [KVM][Kemari]: Build error fix

2012-06-27 Thread Sterling Windmill
Is Kemari still in active development? Best regards, Sterling Windmill On Sun, Dec 4, 2011 at 9:45 PM, OHMURA Kei wrote: > On 2011/12/02 21:51, Pradeep Kumar wrote: > > It fixes build failure. > > > > I hit this error, after succsfull migration and sync. > > > > (qemu) qemu-system-x86_64: fill

[Qemu-devel] [PATCH 02/11] acpi_table_add(): extract acpi_tables init to separate function

2012-06-27 Thread Eduardo Habkost
No behavior change, just code movement. Signed-off-by: Eduardo Habkost --- hw/acpi.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c index 21e573b..6180c7a 100644 --- a/hw/acpi.c +++ b/hw/acpi.c @@ -72,6 +72,15 @@ static void strzcpy(ch

[Qemu-devel] [PATCH 11/11] acpi_table_add(): extract acpi_tables count update code to separate function

2012-06-27 Thread Eduardo Habkost
This is the last change needed to eliminate all the acpi_tables/acpi_tables_len math from acpi_table_add(), making that function only take care of the under-construction table (the newtable/newlen variables). No behavior change, just code movement. Signed-off-by: Eduardo Habkost --- hw/acpi.c |

[Qemu-devel] [PATCH 00/11] acpi_table_add() code cleanup

2012-06-27 Thread Eduardo Habkost
Hi, I was recently working on acpi_table_add() changes as a possible workaround for a bug I was chasing. In the end, I dropped the idea of trying to use custom ACPI tables for the specific problem I was working on, but in the process I made some cleanups in the acpi_table_add() function, to make i

[Qemu-devel] [PATCH 01/11] acpi_table_add(): simplify acpi_tables on-demand initialization

2012-06-27 Thread Eduardo Habkost
Change the code to set acpi_tables_len as soon as acpi_tables is allocated, so the rest of the code can simply use acpi_tables_len safely. There's a small behavior change if the first acpi_table_add() call fails to open a file, but the change is actually desirable, because the old code kept 'acpi_

[Qemu-devel] [PATCH 10/11] acpi_table_add(): use acpi_newtable_resize() return value

2012-06-27 Thread Eduardo Habkost
By using the acpi_newtable_resize() return value, there's no need to do 'acpi_tables + acpi_tables_len' math every time. The acpi_table_add() function just needs to keep a newtable/newlen pair, that points to the table being constructed. With this, almost every single reference to acpi_tables/acpi

[Qemu-devel] [PATCH 04/11] acpi_table_add(): introduce 'qemu_len' variable

2012-06-27 Thread Eduardo Habkost
To make the length calculation clearer, introduce a 'qemu_len' variable, for the length of all data being added to acpi_tables (including the QEMU-specific prefix). No behavior change, just make the length calculation clearer. Signed-off-by: Eduardo Habkost --- hw/acpi.c |9 +++-- 1 fil

[Qemu-devel] [PATCH 03/11] acpi_table_add(): rename 'len' to 'acpi_len'

2012-06-27 Thread Eduardo Habkost
'len' is the length of just the ACPI data, not the length of the whole acpi_tables data (that has a QEMU-specific prefix), so rename it to make it more clear. No behavior change, just a variable rename. Signed-off-by: Eduardo Habkost --- hw/acpi.c | 14 +++--- 1 file changed, 7 insert

Re: [Qemu-devel] [PATCH v13 13/13] Add XBZRLE statistics

2012-06-27 Thread Eric Blake
On 06/27/2012 04:34 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- > +++ b/qmp-commands.hx > @@ -2093,18 +2093,28 @@ The main json-object contains the following: > - "transfe

Re: [Qemu-devel] [PATCH v13 12/13] Add set_cachesize command

2012-06-27 Thread Eric Blake
On 06/27/2012 04:34 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by:

Re: [Qemu-devel] usb_packet_complete: Assertion ... failed

2012-06-27 Thread Erik Rull
Jan Kiszka wrote: On 2012-06-23 11:29, Erik Rull wrote: Jan Kiszka wrote: Hi Gerd, I'm getting qemu/hw/usb/core.c:410: usb_packet_complete: Assertion `((&ep->queue)->tqh_first) == p' failed. with a passed-through USB headset (UHCI controller). This was with current QEMU git head. Known issue

Re: [Qemu-devel] [PATCH v13 11/13] Add XBZRLE to ram_save_block and ram_save_live

2012-06-27 Thread Eric Blake
On 06/27/2012 04:34 AM, Orit Wasserman wrote: > In the outgoing migration check to see if the page is cached and > changed than send compressed page by using save_xbrle_page function. > In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set > and decompress the page (by using load_xbr

Re: [Qemu-devel] [PATCH v13 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-06-27 Thread Eric Blake
On 06/27/2012 04:34 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > +int xbzrle_encode_buffer(uint8_t *old_buf, uint8_t *new_buf, int slen, > + uint8_t *dst, int dle

Re: [Qemu-devel] Request VFIO inclusion in linux-next

2012-06-27 Thread Alex Williamson
On Wed, 2012-06-27 at 15:37 +0300, Dan Carpenter wrote: > On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: > > Hi, > > > > VFIO has been kicking around for well over a year now and has been > > posted numerous times for review. The pre-requirements are finally > > available in lin

Re: [Qemu-devel] [PATCH 5/6 v5] deal with guest panicked event accoring to -onpanic parameter

2012-06-27 Thread Cornelia Huck
On Wed, 27 Jun 2012 15:02:23 +0800 Wen Congyang wrote: > When the guest is panicked, it will write 0x1 to the port KVM_PV_PORT. > So if qemu reads 0x1 from this port, we can do the folloing three > things according to the parameter -onpanic: > 1. emit QEVENT_GUEST_PANICKED only > 2. emit QEVENT_G

[Qemu-devel] [Bug 1018530] Re: No write access in a 9p/virtfs shared folder

2012-06-27 Thread Georg Poppe
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1018530 Title: No write access in a 9p/virtfs shared folder Status in QEMU: New St

Re: [Qemu-devel] Request VFIO inclusion in linux-next

2012-06-27 Thread Dan Carpenter
On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: > Hi, > > VFIO has been kicking around for well over a year now and has been > posted numerous times for review. The pre-requirements are finally > available in linux-next (or will be in the 20120626 build) so I'd like > to request

[Qemu-devel] [PATCH] add -machine mem_merge=on|off option

2012-06-27 Thread Luiz Capitulino
Allows to disable memory merge support (KSM on Linux), which is enabled by default otherwise. Signed-off-by: Luiz Capitulino --- exec.c | 19 --- qemu-config.c | 4 qemu-options.hx | 5 - 3 files changed, 24 insertions(+), 4 deletions(-) diff --git a/exec.c

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Andreas Färber
Am 27.06.2012 20:36, schrieb Richard Henderson: > On 06/27/2012 10:53 AM, Andreas Färber wrote: >> openSUSE uses a version patched so that IIUC 3G are reserved. >> Just today this failed on a system where swap got disabled and the >> mmap() thus failed. > > Err... why? We map with MAP_NORESERVE,

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Richard Henderson
On 06/27/2012 10:53 AM, Andreas Färber wrote: > openSUSE uses a version patched so that IIUC 3G are reserved. > Just today this failed on a system where swap got disabled and the > mmap() thus failed. Err... why? We map with MAP_NORESERVE, so swap shouldn't matter... r~

Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-06-27 Thread Mike Lovell
On 06/27/2012 02:26 AM, Stefan Hajnoczi wrote: On Tue, Jun 26, 2012 at 5:48 PM, Mike Lovell wrote: you can connect multiple guests to a single vde_switch. as i understand it, the communication happens over a local unix domain socket. this would limit the guests on the same switch to the same ho

Re: [Qemu-devel] [PATCH 3/3] pseries pci: added MSI/MSIX support

2012-06-27 Thread Alexander Graf
On 14.06.2012, at 06:34, Alexey Kardashevskiy wrote: > virtio-pci expects the guest to set up MSI message address and data, and > to do other initialization such as a vector number negotiation. > It also notifies the guest via writing an MSI message to a previously set > address. > > This patch

Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-27 Thread Blue Swirl
On Wed, Jun 27, 2012 at 10:34 AM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- >  Makefile.objs        |    1

Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-27 Thread Orit Wasserman
On 06/27/2012 07:55 PM, Eric Blake wrote: > On 06/27/2012 04:34 AM, Orit Wasserman wrote: >> Add LRU page cache mechanism. >> The page are accessed by their address. >> >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shribman >> Signed-off-by: Orit Wasserma

Re: [Qemu-devel] [PATCH v7 15/16] target-or32: Add linux user support

2012-06-27 Thread Blue Swirl
On Wed, Jun 27, 2012 at 9:54 AM, Jia Liu wrote: > Add QEMU OpenRISC linux user support. > > Signed-off-by: Jia Liu > --- >  configure                           |    1 + >  default-configs/or32-linux-user.mak |    1 + >  linux-user/elfload.c                |   41 +++ >  linux-user/main.c      

Re: [Qemu-devel] [PATCH v13 12/13] Add set_cachesize command

2012-06-27 Thread Orit Wasserman
On 06/27/2012 08:56 PM, Blue Swirl wrote: > On Wed, Jun 27, 2012 at 10:34 AM, Orit Wasserman wrote: >> Change XBZRLE cache size in bytes (the size should be a power of 2). >> If XBZRLE cache size is too small there will be many cache miss. >> >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Pett

Re: [Qemu-devel] [PATCH v13 12/13] Add set_cachesize command

2012-06-27 Thread Blue Swirl
On Wed, Jun 27, 2012 at 10:34 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Sign

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-27 Thread Blue Swirl
On Wed, Jun 27, 2012 at 6:01 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Tue, Jun 26, 2012 at 6:41 PM, Peter Maydell >> wrote: >>> On 26 June 2012 19:25, Blue Swirl wrote: On Tue, Jun 26, 2012 at 6:11 PM, Peter Maydell wrote: > On 26 June 2012 18:58, Blue Swirl w

Re: [Qemu-devel] [PATCH v13 07/13] Add debugging infrastructure

2012-06-27 Thread Eric Blake
On 06/27/2012 04:34 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > arch_init.c | 33 +++-- > 1 files changed, 27 insertions(+), 6 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 9dafb6e..ee20c33 100644 > --- a/arch_init.c > +++ b/a

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Andreas Färber
Am 27.06.2012 19:32, schrieb Richard Henderson: > On 06/27/2012 08:51 AM, Meador Inge wrote: >> To solve this issue I experimented with performing a similar probing in >> 'main' >> as in 'probe_guest_base' so that we can find a reserved VA region that also >> passes validation. If a region isn't

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Peter Maydell
On 27 June 2012 18:32, Richard Henderson wrote: > I do wonder if it wouldn't be better to rearrange things such that > for 64-bit hosts and 32-bit guests we *always* reserve 4G so that > there's zero possibility of the guest stomping on host memory.  That > would also solve your problem. We alrea

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Richard Henderson
On 06/27/2012 08:51 AM, Meador Inge wrote: > To solve this issue I experimented with performing a similar probing in 'main' > as in 'probe_guest_base' so that we can find a reserved VA region that also > passes validation. If a region isn't found that can be validated, then QEMU > gives up. Does

Re: [Qemu-devel] [PATCH 3/4] file_ram_alloc(): extract temporary-file creation code to separate function

2012-06-27 Thread Blue Swirl
On Tue, Jun 26, 2012 at 8:51 PM, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- >  exec.c |   35 +-- >  1 file changed, 25 insertions(+), 10 deletions(-) > > diff --git a/exec.c b/exec.c > index 5f3b265..dcbe4e1 100644 > --- a/exec.c > +++ b/exec.c >

Re: [Qemu-devel] [PATCH RFC 4/4] add -keep-mem-path-files option

2012-06-27 Thread Blue Swirl
On Tue, Jun 26, 2012 at 8:51 PM, Eduardo Habkost wrote: > This make QEMU create files inside the -mem-path directory using > more predictable names, and not remove them afterwards. > > This allow (for example) users or management layers to use numactl > later, to set NUMA policy for the guest RAM.

Re: [Qemu-devel] [PATCH 2/4] file_ram_alloc: change length argument to size_t

2012-06-27 Thread Blue Swirl
On Tue, Jun 26, 2012 at 8:51 PM, Eduardo Habkost wrote: > While we are at it, rename it to "length", as "memory" doesn't mean > anything. > > Signed-off-by: Eduardo Habkost > --- >  exec.c |   12 ++-- >  1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/exec.c b/exec.c > in

[Qemu-devel] [PATCH] blockdev: warn when copy_on_read=on and readonly=on

2012-06-27 Thread Stefan Hajnoczi
If the image is read-only then it's not possible to copy read data into it. Therefore copy-on-read is automatically disabled for read-only images. Up until now this behavior was silent, add a warning so the user knows why copy-on-read is not working. Signed-off-by: Stefan Hajnoczi --- blockdev

Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-27 Thread Eric Blake
On 06/27/2012 04:34 AM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > +++ b/cache.c cache.c is a rather generic n

Re: [Qemu-devel] race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-06-27 Thread Jan Kiszka
On 2012-06-27 17:39, Peter Lieven wrote: > Hi all, > > i debugged this further and found out that kvm-kmod-3.0 is working with > qemu-kvm-1.0.1 while kvm-kmod-3.3 and kvm-kmod-3.4 are not. What is > working as well is kvm-kmod-3.4 with an old userspace (qemu-kvm-0.13.0). > Has anyone a clue which

[Qemu-devel] [PATCH v2 7/7] kvm: Stop flushing coalesced MMIO on vmexit

2012-06-27 Thread Jan Kiszka
The memory subsystem will now take care of flushing whenever affected regions are accessed or the memory mapping changes. Signed-off-by: Jan Kiszka --- kvm-all.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index f8e4328..a1d32f6 100644 --- a/kv

Re: [Qemu-devel] Add virtual devices to QEMU

2012-06-27 Thread Andreas Färber
Am 26.06.2012 10:27, schrieb Stefan Hajnoczi: > On Mon, Jun 25, 2012 at 7:58 PM, Alberich de megres > wrote: >> Thank you guys for the reply :) >> >> One last question, >> my device is like a physical console with buttons and indicators. >> >> I saw the android emulator also draws the keyboard usi

[Qemu-devel] [PATCH v2 3/7] memory: Use transaction_begin/commit also for single-step operations

2012-06-27 Thread Jan Kiszka
Wrap also simple operations consisting only of a single step with memory_region_transaction_begin/commit. This allows to perform additional steps like coalesced MMIO flushing from a single place. This requires dropping some micro-optimizations: The skipping of topology updates after updating disab

[Qemu-devel] [PATCH v2 4/7] memory: Fold memory_region_update_topology into memory_region_transaction_commit

2012-06-27 Thread Jan Kiszka
Simplify the code as we are using now only a subset of the original features of memory_region_update_topology. Signed-off-by: Jan Kiszka --- memory.c | 39 +++ 1 files changed, 11 insertions(+), 28 deletions(-) diff --git a/memory.c b/memory.c index 8b1218e

[Qemu-devel] [PATCH v2 5/7] memory: Flush coalesced MMIO on mapping and state changes

2012-06-27 Thread Jan Kiszka
Flush pending coalesced MMIO before performing mapping or state changes that could affect the event orderings or route the buffered requests to a wrong region. Signed-off-by: Jan Kiszka --- memory.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/memory.c b/memory.c inde

[Qemu-devel] [PATCH v2 6/7] VGA: Flush coalesced MMIO on related MMIO/PIO accesses

2012-06-27 Thread Jan Kiszka
In preparation of stopping to flush coalesced MMIO unconditionally on vmexits, mark VGA MMIO and PIO regions as synchronous /wrt coalesced MMIO and flush the buffer explicitly on PIO accesses that do not use generic memory regions yet. Signed-off-by: Jan Kiszka --- hw/cirrus_vga.c |7 +++

[Qemu-devel] [PATCH v2 2/7] memory: Flush coalesced MMIO on selected region access

2012-06-27 Thread Jan Kiszka
Instead of flushing pending coalesced MMIO requests on every vmexit, this provides a mechanism to selectively flush when memory regions related to the coalesced one are accessed. This first of all includes the coalesced region itself but can also applied to other regions, e.g. of the same device, b

[Qemu-devel] [PATCH v2 1/7] i82378: Remove bogus MMIO coalescing

2012-06-27 Thread Jan Kiszka
This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark. Acked-by: Hervé Poussineau

[Qemu-devel] [PATCH v2 0/7] kvm: Get coalesced MMIO flushing out of the hot-path

2012-06-27 Thread Jan Kiszka
Changes in v2: - added memory_region_clear_flush_coalesced - call memory_region_clear_flush_coalesced from memory_region_clear_coalescing - wrap all region manipulations via memory_region_transaction_begin/ commit internally - flush coalesced MMIO only on memory_region_transaction_begin

[Qemu-devel] [PATCH] sheepdog: do not blindly memset all read buffers

2012-06-27 Thread Christoph Hellwig
Only buffers that map to unallocated blocks need to be zeroed. Signed-off-by: Christoph Hellwig Index: qemu/block/sheepdog.c === --- qemu.orig/block/sheepdog.c 2012-06-27 18:02:41.849867899 +0200 +++ qemu/block/sheepdog.c 201

Re: [Qemu-devel] [PATCH v13 03/13] Add XBZRLE documentation

2012-06-27 Thread Eric Blake
On 06/27/2012 04:34 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > docs/xbzrle.txt | 142 > +++ > 1 files changed, 142 insertions(+), 0 deletions(-) > create mode 100644 docs/xbzrle.txt > > +Format > +=== > + > +The c

Re: [Qemu-devel] [RFC PATCH 1/1] linux-user: Probe the guest base for shared objects when needed

2012-06-27 Thread Meador Inge
On 06/12/2012 09:08 AM, Richard Henderson wrote: > I think this is one of those cases where the -B or -R options > (or QEMU_GUEST_BASE and QEMU_RESERVED_VA env variables) are the best > way forward for whatever cpu you're emulating. That or a change to > the target's default ld script, not to lin

[Qemu-devel] race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-06-27 Thread Peter Lieven
Hi all, i debugged this further and found out that kvm-kmod-3.0 is working with qemu-kvm-1.0.1 while kvm-kmod-3.3 and kvm-kmod-3.4 are not. What is working as well is kvm-kmod-3.4 with an old userspace (qemu-kvm-0.13.0). Has anyone a clue which new KVM feature could cause this if a vcpu is in

Re: [Qemu-devel] [PATCH] qtest: fix infinite loop when QEMU aborts abruptly

2012-06-27 Thread Markus Armbruster
Anthony Liguori writes: >>From Markus: > > Makes "make check" hang: > > QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 gtester -k --verbose > -m=quick tests/crash-test tests/rtc-test > TEST: tests/crash-test... (pid=972) > qemu-system-x86_64: Device needs media, but drive is emp

Re: [Qemu-devel] [PATCH v6 6/6] fdc_test: introduce test_sense_interrupt

2012-06-27 Thread Pavel Hrdina
On 06/25/2012 01:52 PM, Kevin Wolf wrote: Am 22.06.2012 12:33, schrieb Pavel Hrdina: Calling sense interrupt status while there is no interrupt should return invalid command (0x80). Read command should always returns in st0 seek_end bit set to 1. Signed-off-by: Pavel Hrdina --- tests/fdc-tes

Re: [Qemu-devel] [PATCH v13 02/13] Add migration capabilites

2012-06-27 Thread Eric Blake
On 06/27/2012 04:34 AM, Orit Wasserman wrote: > Add migration capabilites that can be queried by the management. s/capabilites/capabilities/ > The management can query the source QEMU and the destination QEMU in order to > verify both support some migration capability (currently only XBZRLE). > T

Re: [Qemu-devel] [PATCH v6 4/6] fdc: fix interrupt handling

2012-06-27 Thread Pavel Hrdina
On 06/25/2012 02:41 PM, Kevin Wolf wrote: Am 22.06.2012 12:33, schrieb Pavel Hrdina: If you call the SENSE INTERRUPT STATUS command while there is no interrupt waiting you get as result unknown command. Fixed status0 register handling for read/write/format commands. Signed-off-by: Pavel Hrdina

Re: [Qemu-devel] [PATCH 5/6 v5] deal with guest panicked event accoring to -onpanic parameter

2012-06-27 Thread Daniel P. Berrange
On Wed, Jun 27, 2012 at 04:52:32PM +0200, Cornelia Huck wrote: > On Wed, 27 Jun 2012 15:02:23 +0800 > Wen Congyang wrote: > > > When the guest is panicked, it will write 0x1 to the port KVM_PV_PORT. > > So if qemu reads 0x1 from this port, we can do the folloing three > > things according to the

  1   2   3   >