Re: [Qemu-devel] [PATCH block-next 0/3] qemu-img check/qcow2: Allow fixing refcounts

2012-05-31 Thread Zhi Yong Wu
On Thu, May 31, 2012 at 5:26 PM, Stefan Hajnoczi wrote: > On Wed, May 30, 2012 at 9:31 AM, Zhi Yong Wu wrote: >> On Sat, May 12, 2012 at 12:48 AM, Kevin Wolf wrote: >>> A prerequisite for a "QED mode" in qcow2, which doesn't update the refcount >> Recently some new concepts such as "QED mode" in

Re: [Qemu-devel] [PATCH] Ensure migrate_cancel does not block doing I/O

2012-05-31 Thread Amos Kong
On Fri, Aug 26, 2011 at 9:48 PM, Paolo Bonzini wrote: > On 08/26/2011 01:25 PM, Daniel P. Berrange wrote: >> >> diff --git a/migration.c b/migration.c >> index f5959b4..6448d0b 100644 >> --- a/migration.c >> +++ b/migration.c >> @@ -319,6 +319,11 @@ ssize_t migrate_fd_put_buffer(void *opaque, cons

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Zhi Yong Wu
On Thu, May 31, 2012 at 10:16 PM, Jan Kiszka wrote: > On 2012-05-31 16:10, Zhi Yong Wu wrote: >> On Thu, May 31, 2012 at 9:48 PM, Jan Kiszka wrote: >>> On 2012-05-31 15:45, Zhi Yong Wu wrote: On Thu, May 31, 2012 at 5:18 PM, Stefan Hajnoczi wrote: > On Wed, May 30, 2012 at 8:59 AM

Re: [Qemu-devel] Low shared memory throughput at VM when using PCI mapping

2012-05-31 Thread William Tu
This is just an update if you are interested in the outcome. I turns out that my MTRR (Memory Type Range Register) configuration does not take effect so that the shared memory region is always uncachable. My shared memory is located at 0xf24, and the MTRR settings are below: > cat /proc/mtrr r

[Qemu-devel] [PATCH v4] target-microblaze: lwx/swx: first implementation

2012-05-31 Thread Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite --- changed from v3: simplified tcg local variable usage aqcross branch changed from v2: fixed tcg local variable usage across branch reworked carry logic (with new write_carryi() function) made LOG_DIS show lwx swx properly changed from v1: implemented reser

[Qemu-devel] Any approach to log the file read/write (I/O data flow) like the "-d in_asm" option?

2012-05-31 Thread Yue Chen
Hi, Any approach to log all the file read/write (I/O data flow) in order, together with the instruction traces in QEMU? Thanks.

[Qemu-devel] [PATCH V3 1/2] pl330: initial version

2012-05-31 Thread Peter A. G. Crosthwaite
Device model for Primecell PL330 dma controller. Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: Kirill Batuzov --- changed from v2 (in order of diff appearance): GPL version changed to v2 or later Register and field names changed to match TRM id field corrected PL330ChanState enum correct

[Qemu-devel] [PATCH V3 2/2] xilinx_zynq: added pl330 to machine model

2012-05-31 Thread Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_zynq.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c index 7290c64..033ba09 100644 --- a/hw/xilinx_zynq.c +++ b/hw/xilinx_zynq.c @@ -61,6 +61,9 @@ static void zynq

[Qemu-devel] [PATCH V3 0/2] Xilinx Zynq PL330 support

2012-05-31 Thread Peter A. G. Crosthwaite
These patches add support for the Primcell PL330 DMA controller and add it to the Xilinx Zynq machine model. Patch 1 is the device model. Patch 2 is the machine model update. The Device model was originally contributed by Kirill Batuzov / Samsung, as indicated by the (C) notice in hw/pl330.c.

Re: [Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Peter Maydell
On 1 June 2012 02:45, Alexander Graf wrote: > On 01.06.2012, at 03:39, Peter Maydell wrote: >> On 1 June 2012 02:16, Alexander Graf wrote: >>> On 01.06.2012, at 02:44, Peter Maydell wrote: So in the multithreaded case do all the thread stacks live in this one mapping, or do the non-pri

Re: [Qemu-devel] [PATCH 2/2] linux-user: Add -stracefile to log strace elsewhere than stderr

2012-05-31 Thread Riku Voipio
On Fri, Jun 01, 2012 at 01:49:26AM +0100, Peter Maydell wrote: > On 31 May 2012 20:37, Richard Henderson wrote: > >  void gemu_log(const char *fmt, ...) > >  { > >     va_list ap; > > > >     va_start(ap, fmt); > > -    vfprintf(stderr, fmt, ap); > > +    vfprintf(strace_log_file, fmt, ap); > >  

Re: [Qemu-devel] [RFC PATCH V1 2/2] arm_boot: conditionalised dtb command line update

2012-05-31 Thread Peter Crosthwaite
On Fri, Jun 1, 2012 at 11:56 AM, Peter Crosthwaite wrote: > On Fri, Jun 1, 2012 at 11:44 AM, Peter Maydell > wrote: >> On 1 June 2012 02:16, Peter A. G. Crosthwaite >> wrote: >>> @@ -240,10 +241,13 @@ static int load_dtb(target_phys_addr_t addr, const >>> struct arm_boot_info *binfo) >>>      

Re: [Qemu-devel] [RFC PATCH V1 2/2] arm_boot: conditionalised dtb command line update

2012-05-31 Thread Peter Crosthwaite
On Fri, Jun 1, 2012 at 11:44 AM, Peter Maydell wrote: > On 1 June 2012 02:16, Peter A. G. Crosthwaite > wrote: >> @@ -240,10 +241,13 @@ static int load_dtb(target_phys_addr_t addr, const >> struct arm_boot_info *binfo) >>         fprintf(stderr, "couldn't set /memory/reg\n"); >>     } >> >> -  

Re: [Qemu-devel] [RFC PATCH V1 1/2] arm_boot: added linux switch

2012-05-31 Thread Peter Crosthwaite
On Fri, Jun 1, 2012 at 11:41 AM, Peter Maydell wrote: > On 1 June 2012 02:16, Peter A. G. Crosthwaite > wrote: >> Added a switch to tell the bootloader that the image is linux and should be >> bootstrapped as such. This is needed to boot an elf that is linux. >> >> Syntax would be: >> >> qemu-sys

Re: [Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Alexander Graf
On 01.06.2012, at 03:39, Peter Maydell wrote: > On 1 June 2012 02:16, Alexander Graf wrote: >> On 01.06.2012, at 02:44, Peter Maydell wrote: >>> So in the multithreaded case do all the thread stacks live >>> in this one mapping, or do the non-primary thread stacks >>> live in a standard mmap'd

Re: [Qemu-devel] [RFC PATCH V1 2/2] arm_boot: conditionalised dtb command line update

2012-05-31 Thread Peter Maydell
On 1 June 2012 02:16, Peter A. G. Crosthwaite wrote: > @@ -240,10 +241,13 @@ static int load_dtb(target_phys_addr_t addr, const > struct arm_boot_info *binfo) >         fprintf(stderr, "couldn't set /memory/reg\n"); >     } > > -    rc = qemu_devtree_setprop_string(fdt, "/chosen", "bootargs", > -

Re: [Qemu-devel] [RFC PATCH V1 1/2] arm_boot: added linux switch

2012-05-31 Thread Peter Maydell
On 1 June 2012 02:16, Peter A. G. Crosthwaite wrote: > Added a switch to tell the bootloader that the image is linux and should be > bootstrapped as such. This is needed to boot an elf that is linux. > > Syntax would be: > > qemu-system-arm ... -kernel linux.elf -machine linux=on This whole area

Re: [Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Peter Maydell
On 1 June 2012 02:16, Alexander Graf wrote: > On 01.06.2012, at 02:44, Peter Maydell wrote: >> So in the multithreaded case do all the thread stacks live >> in this one mapping, or do the non-primary thread stacks >> live in a standard mmap'd mapping? > > I thought /proc/self/maps always shows the

[Qemu-devel] [RFC PATCH V1 2/2] arm_boot: conditionalised dtb command line update

2012-05-31 Thread Peter A. G. Crosthwaite
The dtb command line should only be overwritten if the user provides a command line. Otherwise whatever command line was in the dtb should stay unchanged. Signed-off-by: Peter A. G. Crosthwaite --- hw/arm_boot.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/

[Qemu-devel] [RFC PATCH V1 1/2] arm_boot: added linux switch

2012-05-31 Thread Peter A. G. Crosthwaite
Added a switch to tell the bootloader that the image is linux and should be bootstrapped as such. This is needed to boot an elf that is linux. Syntax would be: qemu-system-arm ... -kernel linux.elf -machine linux=on Signed-off-by: Peter A. G. Crosthwaite --- hw/arm_boot.c |1 + qemu-config

Re: [Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Alexander Graf
On 01.06.2012, at 02:44, Peter Maydell wrote: > On 30 May 2012 13:45, Alexander Graf wrote: >> When reading our faked /proc/self/maps from a secondary thread, >> we get an invalid stack entry. This is because ts->stack_base is not >> initialized in non-primary threads. >> >> However, ts->info i

[Qemu-devel] [RFC PATCH V1 0/2] Arm Boot Patches

2012-05-31 Thread Peter A. G. Crosthwaite
These two patches add some flexibilities to the arm bootloader. Added a switch to allow booting of linux elfs (1). Means you can boot an elf thats linux and still pick up desired bootstap goodies like dtb edit and smp secondary. Conditionalised dtb command line update on there being a -append a

Re: [Qemu-devel] [Qemu-discuss] ARM7TDMI support

2012-05-31 Thread Peter Maydell
On 31 May 2012 22:12, Vinicius Sanches wrote: > Actually I already did it. It does not have any indication about that core. Correct. This indicates that we do not support the ARM7TDMI. -- PMM

Re: [Qemu-devel] [PATCH 2/2] linux-user: Add -stracefile to log strace elsewhere than stderr

2012-05-31 Thread Peter Maydell
On 31 May 2012 20:37, Richard Henderson wrote: >  void gemu_log(const char *fmt, ...) >  { >     va_list ap; > >     va_start(ap, fmt); > -    vfprintf(stderr, fmt, ap); > +    vfprintf(strace_log_file, fmt, ap); >     va_end(ap); >  } gemu_log() is used for more than just strace output... are we

Re: [Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Peter Maydell
On 30 May 2012 13:45, Alexander Graf wrote: > When reading our faked /proc/self/maps from a secondary thread, > we get an invalid stack entry. This is because ts->stack_base is not > initialized in non-primary threads. > > However, ts->info is, and the stack layout information we're looking > for

Re: [Qemu-devel] [PATCH 23/25] PPC: e500: dt: use target_phys_addr_t for ramsize

2012-05-31 Thread Alexander Graf
On 01.06.2012, at 00:52, Scott Wood wrote: > On 05/31/2012 05:39 PM, Alexander Graf wrote: >> >> On 01.06.2012, at 00:24, Scott Wood wrote: >> >>> On 05/31/2012 05:18 PM, Alexander Graf wrote: On 01.06.2012, at 00:07, Scott Wood wrote: > On 05/30/2012 06:00 AM, Alexander Gr

Re: [Qemu-devel] [PATCH 23/25] PPC: e500: dt: use target_phys_addr_t for ramsize

2012-05-31 Thread Scott Wood
On 05/31/2012 05:39 PM, Alexander Graf wrote: > > On 01.06.2012, at 00:24, Scott Wood wrote: > >> On 05/31/2012 05:18 PM, Alexander Graf wrote: >>> >>> On 01.06.2012, at 00:07, Scott Wood wrote: >>> On 05/30/2012 06:00 AM, Alexander Graf wrote: > We're passing the ram size as uint32_t, c

Re: [Qemu-devel] [PATCH 23/25] PPC: e500: dt: use target_phys_addr_t for ramsize

2012-05-31 Thread Alexander Graf
On 01.06.2012, at 00:24, Scott Wood wrote: > On 05/31/2012 05:18 PM, Alexander Graf wrote: >> >> On 01.06.2012, at 00:07, Scott Wood wrote: >> >>> On 05/30/2012 06:00 AM, Alexander Graf wrote: We're passing the ram size as uint32_t, capping it to 32 bits atm. Change to target_phys_add

Re: [Qemu-devel] [PATCH 16/25] PPC: e500: dt: create serial nodes dynamically

2012-05-31 Thread Alexander Graf
On 01.06.2012, at 00:22, Scott Wood wrote: > On 05/31/2012 05:17 PM, Alexander Graf wrote: >> >> On 01.06.2012, at 00:02, Scott Wood wrote: >>> Please put this somewhere it won't have to be duplicated for every board >>> -- preferably in the serial device code itself. >> >> Yeah, I talked to An

Re: [Qemu-devel] [PATCH 07/25] dt: add helper for phandle allocation

2012-05-31 Thread Scott Wood
On 05/30/2012 06:00 AM, Alexander Graf wrote: > Phandle references work by having 2 pieces: > > - a "phandle" 1-cell property in the device tree node > - a reference to the same value in a property we want to point > to the other node > > To generate the 1-cell property, we need an alloca

Re: [Qemu-devel] [PATCH 17/25] PPC: e500: dt: create mpic node dynamically

2012-05-31 Thread Scott Wood
On 05/30/2012 06:00 AM, Alexander Graf wrote: > Signed-off-by: Alexander Graf > --- > hw/ppce500_mpc8544ds.c | 16 > 1 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c > index 493ad6e..3d073dd 100644 > --- a/hw/pp

Re: [Qemu-devel] [PATCH 22/25] PPC: e500: dt: use 64bit cell helper

2012-05-31 Thread Scott Wood
On 05/31/2012 05:19 PM, Alexander Graf wrote: > > On 01.06.2012, at 00:15, Scott Wood wrote: > >> On 05/30/2012 06:00 AM, Alexander Graf wrote: >>> We have a nice 64bit helper to ease the device tree generation and >>> make the code more readable when creating 64bit 2-cell parameters. >>> Use it

Re: [Qemu-devel] [PATCH 23/25] PPC: e500: dt: use target_phys_addr_t for ramsize

2012-05-31 Thread Scott Wood
On 05/31/2012 05:18 PM, Alexander Graf wrote: > > On 01.06.2012, at 00:07, Scott Wood wrote: > >> On 05/30/2012 06:00 AM, Alexander Graf wrote: >>> We're passing the ram size as uint32_t, capping it to 32 bits atm. >>> Change to target_phys_addr_t (uint64_t) to make sure we have all >>> the bits.

Re: [Qemu-devel] [PATCH 23/25] PPC: e500: dt: use target_phys_addr_t for ramsize

2012-05-31 Thread Scott Wood
On 05/30/2012 06:00 AM, Alexander Graf wrote: > We're passing the ram size as uint32_t, capping it to 32 bits atm. > Change to target_phys_addr_t (uint64_t) to make sure we have all > the bits. Wouldn't ram_addr_t be more appropriate? -Scott

Re: [Qemu-devel] [PATCH 16/25] PPC: e500: dt: create serial nodes dynamically

2012-05-31 Thread Scott Wood
On 05/31/2012 05:17 PM, Alexander Graf wrote: > > On 01.06.2012, at 00:02, Scott Wood wrote: >> Please put this somewhere it won't have to be duplicated for every board >> -- preferably in the serial device code itself. > > Yeah, I talked to Anthony about that and he didn't like the idea of > dev

Re: [Qemu-devel] [PATCH 22/25] PPC: e500: dt: use 64bit cell helper

2012-05-31 Thread Alexander Graf
On 01.06.2012, at 00:15, Scott Wood wrote: > On 05/30/2012 06:00 AM, Alexander Graf wrote: >> We have a nice 64bit helper to ease the device tree generation and >> make the code more readable when creating 64bit 2-cell parameters. >> Use it when generating the device tree. >> >> Signed-off-by: A

Re: [Qemu-devel] [PATCH 23/25] PPC: e500: dt: use target_phys_addr_t for ramsize

2012-05-31 Thread Alexander Graf
On 01.06.2012, at 00:07, Scott Wood wrote: > On 05/30/2012 06:00 AM, Alexander Graf wrote: >> We're passing the ram size as uint32_t, capping it to 32 bits atm. >> Change to target_phys_addr_t (uint64_t) to make sure we have all >> the bits. > > Wouldn't ram_addr_t be more appropriate? I never

Re: [Qemu-devel] [PATCH 16/25] PPC: e500: dt: create serial nodes dynamically

2012-05-31 Thread Scott Wood
On 05/30/2012 06:00 AM, Alexander Graf wrote: > @@ -196,6 +199,38 @@ static int mpc8544_load_device_tree(CPUPPCState *env, > /* XXX should contain a reasonable value */ > qemu_devtree_setprop_cell(fdt, soc, "bus-frequency", 0); > > +/* > + * We have to generate ser1 first, becau

Re: [Qemu-devel] [PATCH 16/25] PPC: e500: dt: create serial nodes dynamically

2012-05-31 Thread Alexander Graf
On 01.06.2012, at 00:02, Scott Wood wrote: > On 05/30/2012 06:00 AM, Alexander Graf wrote: >> @@ -196,6 +199,38 @@ static int mpc8544_load_device_tree(CPUPPCState *env, >> /* XXX should contain a reasonable value */ >> qemu_devtree_setprop_cell(fdt, soc, "bus-frequency", 0); >> >> +/

Re: [Qemu-devel] [PATCH 15/25] PPC: e500: dt: create /soc8544 node dynamically

2012-05-31 Thread Alexander Graf
On 31.05.2012, at 23:58, Scott Wood wrote: > On 05/30/2012 06:00 AM, Alexander Graf wrote: >> @@ -179,6 +182,20 @@ static int mpc8544_load_device_tree(CPUPPCState *env, >> } >> } >> >> +/* XXX These should go into their respective devices' code */ >> +sprintf(soc, "/soc8544@%

Re: [Qemu-devel] [PATCH 22/25] PPC: e500: dt: use 64bit cell helper

2012-05-31 Thread Scott Wood
On 05/30/2012 06:00 AM, Alexander Graf wrote: > We have a nice 64bit helper to ease the device tree generation and > make the code more readable when creating 64bit 2-cell parameters. > Use it when generating the device tree. > > Signed-off-by: Alexander Graf > --- > hw/ppce500_mpc8544ds.c | 1

Re: [Qemu-devel] [PATCH 19/25] PPC: e500: dt: create pci node dynamically

2012-05-31 Thread Scott Wood
On 05/30/2012 06:00 AM, Alexander Graf wrote: > Signed-off-by: Alexander Graf > --- > hw/ppce500_mpc8544ds.c | 50 > > pc-bios/mpc8544ds.dtb | Bin 1810 -> 72 bytes > pc-bios/mpc8544ds.dts | 46 >

Re: [Qemu-devel] [PATCH 15/25] PPC: e500: dt: create /soc8544 node dynamically

2012-05-31 Thread Scott Wood
On 05/30/2012 06:00 AM, Alexander Graf wrote: > @@ -179,6 +182,20 @@ static int mpc8544_load_device_tree(CPUPPCState *env, > } > } > > +/* XXX These should go into their respective devices' code */ > +sprintf(soc, "/soc8544@%x", MPC8544_CCSRBAR_BASE); This should just be "/

Re: [Qemu-devel] ARM7TDMI support

2012-05-31 Thread Emmanuel Blot
Hi Vinicius, > I'm a new dev/user of QEMU. I was wondering if it supports the > ARM7TDMI/ARM7TDMI-S natively. Is that possible or do I have to apply some > additional patch? I'm wondering it because of those differences related to > Branch instructions and some missing instructions and coprocessor

Re: [Qemu-devel] [Qemu-discuss] ARM7TDMI support

2012-05-31 Thread Vinicius Sanches
Actually I already did it. It does not have any indication about that core. I was looking for inside the source code and it is not listed inside cpu.h file. I'm asking about it becuase of some differences in some behaviors in BLX, BX, CP15 and pop operations related to Thumb mode. The V5 and V4T ar

Re: [Qemu-devel] Malta MIPS

2012-05-31 Thread Artyom Tarasenko
On Thu, May 31, 2012 at 2:04 PM, maheen butt wrote: > > > I found this link very useful to emulate MIPS malta > > http://people.debian.org/~aurel32/qemu/mips/ > > kernel and file system images are provided. But I'm facing a problem. > Actually I want to share files between guest and for this purpo

[Qemu-devel] [PATCH 2/2] linux-user: Add -stracefile to log strace elsewhere than stderr

2012-05-31 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/main.c | 25 - 1 files changed, 20 insertions(+), 5 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index f507a32..c728253 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -73,12 +73,14 @@ const ch

[Qemu-devel] [PATCH 1/2] alpha-linux-user: Fix signal handling

2012-05-31 Thread Richard Henderson
Proper signal numbers were not defined, and EXCP_INTERRUPT was unhandled, leading to all sorts of subtle confusion. Signed-off-by: Richard Henderson --- linux-user/main.c |3 +++ linux-user/syscall_defs.h | 41 - 2 files changed, 43 insertion

[Qemu-devel] [PATCH 0/2] linux user improvements

2012-05-31 Thread Richard Henderson
Available at git://repo.or.cz/qemu/rth.git axp-next r~ Richard Henderson (2): alpha-linux-user: Fix signal handling linux-user: Add -stracefile to log strace elsewhere than stderr linux-user/main.c | 28 +++- linux-user/syscall_defs.h | 41 ++

Re: [Qemu-devel] ARM: Virtual / Physical address translation

2012-05-31 Thread Ira Ray Jenkins
On Wed, May 30, 2012 at 10:30 AM, Laurent Desnogues wrote: > On Wed, May 30, 2012 at 3:20 AM, Peter Maydell > wrote: >> On 30 May 2012 02:00, Ira Ray Jenkins wrote: >>> What I would like is to be able to get the physical addresses of both >>> data and instructions. Can anyone help me work throu

Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-05-31 Thread Paul Brook
> >> +void cpu_tlb_flush(CPUState *cpu, bool flush_global) > >> +{ > >> +CPUClass *cc = CPU_GET_CLASS(cpu); > >> + > >> +g_assert(cc->tlb_flush != NULL); > >> + > >> +cc->tlb_flush(cpu, flush_global); > >> +} > > > > This needs to be able to call tlb_flush() itself > > rather than havi

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-31 Thread Markus Armbruster
Anthony Liguori writes: [On how to model virtio devices in QOM:] > Basically, it should look like: > > VirtioPCIDevice is-a PCIDevice > > VirtioPCIDevice has-a link Could you explain why this is link<> and not child<>? > VirtioDevice is-a DeviceState > > VirtioBlk is-a VirtioDevice > VirtioNet

[Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Alexander Graf
When reading our faked /proc/self/maps from a secondary thread, we get an invalid stack entry. This is because ts->stack_base is not initialized in non-primary threads. However, ts->info is, and the stack layout information we're looking for is there too. So let's use that one instead! Signed-off

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc4 release

2012-05-31 Thread Stefan Weil
Am 31.05.2012 17:29, schrieb Anthony Liguori: On 05/31/2012 01:58 PM, Stefan Weil wrote: Did you tag the release? Yup. http://git.qemu.org/qemu.git I pushed that tag when I pushed the version change FWIW. Regards, Anthony Liguori Ah, I found the reason why I neither see the new VERSION

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 18:08, Luiz Capitulino ha scritto: > On Thu, 31 May 2012 17:49:42 +0200 > Paolo Bonzini wrote: > >> Il 31/05/2012 17:44, Luiz Capitulino ha scritto: One is "do not shoehorn errors into errno values". So for QOM invalid values we have PropertyValueBad, not a generic

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Stefan Weil
Hi Paolo, I suggest using false / true instead of 0 / 1 for the boolean values, see my comments below. Regards, Stefan Am 31.05.2012 12:03, schrieb Paolo Bonzini: [...] -void qemu_net_queue_flush(NetQueue *queue) +bool qemu_net_queue_flush(NetQueue *queue) { while (!QTAILQ_EMPTY(&qu

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 17:49:42 +0200 Paolo Bonzini wrote: > Il 31/05/2012 17:44, Luiz Capitulino ha scritto: > >> One is "do not shoehorn errors into errno values". So for QOM invalid > >> values we > >> have PropertyValueBad, not a generic InvalidArgument value. We convert > >> everything > >>

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 17:44, Luiz Capitulino ha scritto: >> One is "do not shoehorn errors into errno values". So for QOM invalid >> values we >> have PropertyValueBad, not a generic InvalidArgument value. We convert >> everything >> to Error rather than returning negative errno values and then returni

Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 17:18:18 +0200 Paolo Bonzini wrote: > Il 31/05/2012 15:49, Luiz Capitulino ha scritto: > >> Seriously? The natural thing to do is -qmp stdio, and I don't read any > >> wikis for that. > >> > >> It's nice that you can get some kind of usability by typing in long > >> network ad

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 16:54:47 +0200 Paolo Bonzini wrote: > Il 31/05/2012 16:31, Luiz Capitulino ha scritto: > Errors are not QAPI-ized yet, so we can add errno values to the above > five errors too. > >>> > >>> We've preferred adding new errors instead of adding errno values to > >>> exi

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc3 release

2012-05-31 Thread Anthony Liguori
On 05/31/2012 08:06 PM, Jan Kiszka wrote: On 2012-05-30 10:42, Jan Kiszka wrote: On 2012-05-30 04:32, Anthony Liguori wrote: On 05/22/2012 11:09 PM, Jan Kiszka wrote: On 2012-05-22 11:32, Anthony Liguori wrote: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the thir

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc4 release

2012-05-31 Thread Anthony Liguori
On 05/31/2012 01:58 PM, Stefan Weil wrote: Am 31.05.2012 05:21, schrieb Anthony Liguori: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 1.1 release. This release is meant for testing purposes and should not be used in a product

Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 15:49, Luiz Capitulino ha scritto: >> Seriously? The natural thing to do is -qmp stdio, and I don't read any >> wikis for that. >> >> It's nice that you can get some kind of usability by typing in long >> network addresses or path names and hacking a rlwrap around it (didn't >> know t

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Kevin Wolf
Am 31.05.2012 16:06, schrieb Luiz Capitulino: > On Thu, 31 May 2012 12:42:34 +0200 > Paolo Bonzini wrote: >> Errors are not QAPI-ized yet, so we can add errno values to the above >> five errors too. > > We've preferred adding new errors instead of adding errno values to > existing errors. I don't

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 16:31, Luiz Capitulino ha scritto: Errors are not QAPI-ized yet, so we can add errno values to the above five errors too. >>> >>> We've preferred adding new errors instead of adding errno values to >>> existing errors. I don't remember exactly why, but I personally don't car

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 16:25:48 +0200 Paolo Bonzini wrote: > Il 31/05/2012 16:06, Luiz Capitulino ha scritto: > >> What about errno values? Let's add an enum QemuErrno and convert host > >> errnos to that enum. Enums are sent as strings, so they are neutral to > >> the OS of the host and client.

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 16:06, Luiz Capitulino ha scritto: >> What about errno values? Let's add an enum QemuErrno and convert host >> errnos to that enum. Enums are sent as strings, so they are neutral to >> the OS of the host and client. And the client (if it desires) can >> convert back to an errno val

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Jan Kiszka
On 2012-05-31 16:10, Zhi Yong Wu wrote: > On Thu, May 31, 2012 at 9:48 PM, Jan Kiszka wrote: >> On 2012-05-31 15:45, Zhi Yong Wu wrote: >>> On Thu, May 31, 2012 at 5:18 PM, Stefan Hajnoczi wrote: On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: > Hi, > while investigating rx perf

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Zhi Yong Wu
On Thu, May 31, 2012 at 9:48 PM, Jan Kiszka wrote: > On 2012-05-31 15:45, Zhi Yong Wu wrote: >> On Thu, May 31, 2012 at 5:18 PM, Stefan Hajnoczi wrote: >>> On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: Hi, while investigating rx performance for emulated network devices (i am

Re: [Qemu-devel] PPC 40p emulation

2012-05-31 Thread Andreas Färber
Hi, Am 31.05.2012 11:14, schrieb Mary Disler: > is there a qemu version which can emulate an IBM 40p machine? > > Google finds http://repo.or.cz/w/qemu/hpoussin.git, but when I compile > and start it nothing happens, except for qemu-system-ppc eating 100% > cpu. Hervé and me are working on PReP

Re: [Qemu-devel] [PATCH 01/14] qerror: extend QERR_TOO_MANY_FILES

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 12:43:24 +0200 Paolo Bonzini wrote: > Il 30/05/2012 16:14, Luiz Capitulino ha scritto: > > Specify it's too many open files in system (ENFILE). > > > > There's no compatibility issue because QERR_TOO_MANY_FILES is actually > > not used today. > > Let's kill it then. :) It's

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 12:42:34 +0200 Paolo Bonzini wrote: > Il 30/05/2012 16:14, Luiz Capitulino ha scritto: > > New errors for write() and open() failures. Will be used by the > > next commits. > > Ouch. We have already these errors: > > #define QERR_OPEN_FILE_FAILED \ > "{ 'class': 'OpenFi

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Zhi Yong Wu
On Thu, May 31, 2012 at 9:19 PM, Paolo Bonzini wrote: > Il 31/05/2012 15:07, Zhi Yong Wu ha scritto: >> Yeah, this case actually exists, but tcp/ip protocol stack in guest >> will make sure this ordering will finally be correct. > > Nevertheless it's not good, and the latest Windows Logo tests wil

Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 10:10:07 +0200 Kevin Wolf wrote: > Am 30.05.2012 18:41, schrieb Luiz Capitulino: > > On Wed, 30 May 2012 16:19:43 +0200 > > Kevin Wolf wrote: > > > >> Am 30.05.2012 12:01, schrieb Pavel Hrdina: > >>> For debug it would be nice to have a same functionality for the qmp > >>>

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Jan Kiszka
On 2012-05-31 15:45, Zhi Yong Wu wrote: > On Thu, May 31, 2012 at 5:18 PM, Stefan Hajnoczi wrote: >> On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: >>> Hi, >>> while investigating rx performance for emulated network devices >>> (i am looking at the userspace version, relying on net=tap >>> o

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Zhi Yong Wu
On Thu, May 31, 2012 at 5:18 PM, Stefan Hajnoczi wrote: > On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: >> Hi, >> while investigating rx performance for emulated network devices >> (i am looking at the userspace version, relying on net=tap >> or similar approaches) i noticed the code >> in

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Jan Kiszka
On 2012-05-31 15:49, Luigi Rizzo wrote: > On Thu, May 31, 2012 at 03:23:12PM +0200, Jan Kiszka wrote: >> On 2012-05-31 15:19, Paolo Bonzini wrote: >>> Il 31/05/2012 15:07, Zhi Yong Wu ha scritto: Yeah, this case actually exists, but tcp/ip protocol stack in guest will make sure this order

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Jan Kiszka
On 2012-05-31 15:19, Paolo Bonzini wrote: > Il 31/05/2012 15:07, Zhi Yong Wu ha scritto: >> Yeah, this case actually exists, but tcp/ip protocol stack in guest >> will make sure this ordering will finally be correct. > > Nevertheless it's not good, and the latest Windows Logo tests will fail > if

Re: [Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-05-31 Thread Stefano Stabellini
On Thu, 31 May 2012, Jan Beulich wrote: > >>> On 31.05.12 at 13:27, Stefano Stabellini > >>> > wrote: > > On Thu, 31 May 2012, Jan Beulich wrote: > >> Legacy (non-pvops) gntdev drivers may require this to be done when the > >> number of grants intended to be used simultaneously exceeds a certain

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Luigi Rizzo
On Thu, May 31, 2012 at 03:23:12PM +0200, Jan Kiszka wrote: > On 2012-05-31 15:19, Paolo Bonzini wrote: > > Il 31/05/2012 15:07, Zhi Yong Wu ha scritto: > >> Yeah, this case actually exists, but tcp/ip protocol stack in guest > >> will make sure this ordering will finally be correct. > > > > Never

Re: [Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-05-31 Thread Jan Beulich
>>> On 31.05.12 at 13:27, Stefano Stabellini wrote: > On Thu, 31 May 2012, Jan Beulich wrote: >> Legacy (non-pvops) gntdev drivers may require this to be done when the >> number of grants intended to be used simultaneously exceeds a certain >> driver specific default limit. >> >> Change in v2: Do

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-31 Thread Roni Luxenberg
- Original Message - > Il 30/05/2012 14:34, Geert Jansen ha scritto: > > > > On 05/29/2012 02:52 PM, Paolo Bonzini wrote: > > > >>> Does the drive-mirror coroutine send the writes to the target in > >>> the > >>> same order as they are sent to the source? I assume so. > >> > >> No, it doe

[Qemu-devel] PPC 40p emulation

2012-05-31 Thread Mary Disler
Hi developers, is there a qemu version which can emulate an IBM 40p machine? Google finds http://repo.or.cz/w/qemu/hpoussin.git, but when I compile and start it nothing happens, except for qemu-system-ppc eating 100% cpu. My PC has Ubuntu 10.10, maybe this is too old for qemu? Mary Disler

[Qemu-devel] Malta MIPS

2012-05-31 Thread maheen butt
I found this link very useful to emulate MIPS malta http://people.debian.org/~aurel32/qemu/mips/ kernel and file system images are provided. But I'm facing a problem. Actually I want to share files between guest and for this purpose I try to modify the provided  file system but whenever I trie

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 15:07, Zhi Yong Wu ha scritto: > Yeah, this case actually exists, but tcp/ip protocol stack in guest > will make sure this ordering will finally be correct. Nevertheless it's not good, and the latest Windows Logo tests will fail if you reorder frames. Paolo

Re: [Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache

2012-05-31 Thread Kevin Wolf
Am 31.05.2012 15:06, schrieb Paolo Bonzini: > Il 31/05/2012 14:33, Paolo Bonzini ha scritto: case 0x02: /* write cache enable */ +bdrv_set_enable_write_cache(s->bs, true); +identify_data = (uint16_t *)s->identify_data; +

Re: [Qemu-devel] [PATCH 1/2] qmp: use readline mode for stdio

2012-05-31 Thread Pavel Hrdina
On 05/31/2012 12:34 PM, Paolo Bonzini wrote: Il 30/05/2012 12:01, Pavel Hrdina ha scritto: Instead of using an echo for '-qmp stdio' we use a readline mode. The readline mode adds a history for users which is useful. Signed-off-by: Pavel Hrdina --- monitor.c | 83 ++

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Zhi Yong Wu
On Thu, May 31, 2012 at 5:34 PM, Luigi Rizzo wrote: > > > On Thu, May 31, 2012 at 11:18 AM, Stefan Hajnoczi > wrote: >> >> On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: >> > Hi, >> > while investigating rx performance for emulated network devices >> > (i am looking at the userspace version

Re: [Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 14:33, Paolo Bonzini ha scritto: >> > case 0x02: /* write cache enable */ >> > +bdrv_set_enable_write_cache(s->bs, true); >> > +identify_data = (uint16_t *)s->identify_data; >> > +put_le16(identify_data + 85, (1 << 14) |

Re: [Qemu-devel] general question

2012-05-31 Thread 吴晓琳
I am wirting a little kernel by myself, but come into a problem which seems strange. I implement the system call fork, in which memory data is copied from parent's space to child's, I insert a fake page into the parent's page, and set its physical address to an empty frame, and then copy data fr

Re: [Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:53, Kevin Wolf ha scritto: >> > case 0x02: /* write cache enable */ >> > +bdrv_set_enable_write_cache(s->bs, true); >> > +identify_data = (uint16_t *)s->identify_data; >> > +put_le16(identify_data + 85, (1 << 14) | (1 << 5) | 1); > How a

Re: [Qemu-devel] [PATCH 1.2 5/7] block: add bdrv_set_enable_write_cache

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:44, Kevin Wolf ha scritto: > Am 22.05.2012 18:17, schrieb Paolo Bonzini: >> Signed-off-by: Paolo Bonzini >> --- >> block.c |5 + >> block.h |1 + >> 2 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/block.c b/block.c >> index b682764..bb709c2 100644

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc3 release

2012-05-31 Thread Max Filippov
On Thu, May 31, 2012 at 4:06 PM, Jan Kiszka wrote: > On 2012-05-30 10:42, Jan Kiszka wrote: >> On 2012-05-30 04:32, Anthony Liguori wrote: >>> On 05/22/2012 11:09 PM, Jan Kiszka wrote: On 2012-05-22 11:32, Anthony Liguori wrote: > Hi, > > On behalf of the QEMU Team, I'd like to an

Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:56, Kevin Wolf ha scritto: >> > Because in this case there is no format over it, so the topmost BDS will >> > be open with BDRV_O_CACHE_WB and no one will call bdrv_flush. > Doesn't block.c do it now? bs->enable_write_cache still wouldn't be set, > even if .bdrv_file_open() is call

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc3 release

2012-05-31 Thread Jan Kiszka
On 2012-05-30 10:42, Jan Kiszka wrote: > On 2012-05-30 04:32, Anthony Liguori wrote: >> On 05/22/2012 11:09 PM, Jan Kiszka wrote: >>> On 2012-05-22 11:32, Anthony Liguori wrote: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate

Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-31 Thread Kevin Wolf
Am 31.05.2012 13:43, schrieb Paolo Bonzini: > Il 31/05/2012 13:33, Kevin Wolf ha scritto: diff --git a/block.c b/block.c index 7add33c..43b3de6 100644 --- a/block.c +++ b/block.c @@ -661,7 +661,7 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filenam

Re: [Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache

2012-05-31 Thread Kevin Wolf
Am 22.05.2012 18:17, schrieb Paolo Bonzini: > Enabling or disabling the write cache is done with the SET FEATURES > command. The command can be issued with sg_sat_set_features from > sg3-utils. > > Signed-off-by: Paolo Bonzini > --- > hw/ide/core.c | 18 +++--- > 1 files changed,

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:43, Stefano Stabellini ha scritto: >> > No, it's not that. I was talking about feature-rx-notify. But I >> > remembered wrong, that feature is advertised by the front-end, not the >> > back-end. > Yes, that's right. > > >> > IIRC there is only one event channel per Xen network

Re: [Qemu-devel] [PATCH 1.2 5/7] block: add bdrv_set_enable_write_cache

2012-05-31 Thread Kevin Wolf
Am 22.05.2012 18:17, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > block.c |5 + > block.h |1 + > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/block.c b/block.c > index b682764..bb709c2 100644 > --- a/block.c > +++ b/block.c > @@ -2369,6 +2369,11

Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:33, Kevin Wolf ha scritto: >> > diff --git a/block.c b/block.c >> > index 7add33c..43b3de6 100644 >> > --- a/block.c >> > +++ b/block.c >> > @@ -661,7 +661,7 @@ static int bdrv_open_common(BlockDriverState *bs, >> > const char *filename, >> > if (drv->bdrv_file_open) { >> >

  1   2   >