[Qemu-devel] Merging backing file with new image

2012-04-01 Thread PANKAJ RAWAT
Hi all i am using qcow2 image format , I create a backing file and to the new image i preform some I/O qemu-img create -f qcow2 -b snap1 guestqcow2 Now I wanted to merge snap1 with guestqcow2. Is their is any command which can merge both disk into one single file -- *Pankaj Rawat*

Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device

2012-04-01 Thread David Gibson
On Mon, Apr 02, 2012 at 09:46:07AM +0300, Michael S. Tsirkin wrote: > This conflicts with deduplication of properties work. > I'll apply on top of that, so don't worry. Alrighty. Any ETA? > > On Mon, Apr 02, 2012 at 12:43:06PM +1000, David Gibson wrote: > > Anthony.. > > > > please apply? > >

[Qemu-devel] Merging backing file with new image

2012-04-01 Thread PANKAJ RAWAT
Hi all, -- *Pankaj Rawat*

Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device

2012-04-01 Thread Michael S. Tsirkin
This conflicts with deduplication of properties work. I'll apply on top of that, so don't worry. On Mon, Apr 02, 2012 at 12:43:06PM +1000, David Gibson wrote: > Anthony.. > > please apply? > > On Mon, Mar 26, 2012 at 12:19:40PM +1100, David Gibson wrote: > > Currently the virtio balloon device,

[Qemu-devel] [PATCH] use: fix bit test

2012-04-01 Thread Lai Jiangshan
use & instead of the wrong && Signed-off-by: Lai Jiangshan --- diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 73b0c7f..89c2406 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci) int level = 0; if (xhci->im

[Qemu-devel] [PATCH v1 1/2] SDHCI: inital version

2012-04-01 Thread Peter A. G. Crosthwaite
device more for standard SD host controller interface (SDHCI). Signed-off-by: Peter A. G. Crosthwaite --- Makefile.target |1 + hw/sdhci.c | 748 +++ 2 files changed, 749 insertions(+), 0 deletions(-) create mode 100644 hw/sdhci.c d

[Qemu-devel] [PATCH v1 2/2] xilinx_zynq: added sdhci controller

2012-04-01 Thread Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_zynq.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c index 31d9e81..e92ebe0 100644 --- a/hw/xilinx_zynq.c +++ b/hw/xilinx_zynq.c @@ -161,6 +161,18 @@ static void zynq_i

[Qemu-devel] [PATCH v1 0/2] SDHCI for Xilinx Zynq

2012-04-01 Thread Peter A. G. Crosthwaite
These two patched add a device model for the standard SD host controller interface (1) and instantiates it as a device to the Xilinx Zynq platform (2). Peter A. G. Crosthwaite (2): SDHCI: inital version xilinx_zynq: added sdhci controller Makefile.target |1 + hw/sdhci.c | 748 +

[Qemu-devel] [PATCH v1 3/3] xilinx_zynq: set initrd and dtb locations

2012-04-01 Thread Peter A. G. Crosthwaite
The xilinx published kernel and linux test binaries expects initrd and dtb to be at these locations Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_zynq.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c index 56d0b96..31d9e81 100

[Qemu-devel] [PATCH v1 1/3] xilinx_zynq: added smp support

2012-04-01 Thread Peter A. G. Crosthwaite
Added linux smp support for the xilinx zynq platform (2x cpus are supported) Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_zynq.c | 64 - 1 files changed, 53 insertions(+), 11 deletions(-) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zyn

[Qemu-devel] [PATCH v1 2/3] arm_boot: parameterized intird and dtb locations

2012-04-01 Thread Peter A. G. Crosthwaite
Added fields that allows a machine model to specify where the initrd and dtb are loaded. Leaving the fields 0 will use to old default values (previously hardcoded in arm_boot.c) Signed-off-by: Peter A. G. Crosthwaite --- hw/arm-misc.h |8 hw/arm_boot.c | 34 ---

[Qemu-devel] [PATCH v1 0/3] Xilinx-Zynq boot process patches

2012-04-01 Thread Peter A. G. Crosthwaite
These patches allow for booting of smp linux as well as custom initrd and dtb blobs on the xilinx zynq platform. Patch 1 is dual core smp support. Patch 2 parameterises the previously hardcoded initrd and dtb address offsets for the arm bootloader. Patch 3 fixes the initrd and dtb addresses for

[Qemu-devel] [PATCH 2/3] pseries: Use more conventional PCI interrupt swizzling

2012-04-01 Thread David Gibson
Currently the pseries PCI code uses a somewhat strange scheme of PCI irq allocation - one per slot up to a maximum that's greater than the usual 4. This scheme more or less worked, because we were able to tell the guest the irq mapping in the device tree, however it's nonstandard and may break assu

[Qemu-devel] [PATCH 1/3] pseries: Fix RTAS based config access

2012-04-01 Thread David Gibson
On the pseries platform, access to PCI config space is via RTAS calls( which go to the hypervisor) rather than MMIO. This means we don't use the same code path as nearly everyone else which goes through pci_host.c and we're missing some of the parameter checking along the way. We do have some par

[Qemu-devel] [PATCH 3/3] pseries: Add DPRINTF macros to spapr pci code

2012-04-01 Thread David Gibson
From: Alexey Kardashevskiy This adds DPRINTF() macros with the usual conventions to the spapr_pci code. Cc: Michael S. Tsirkin Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson --- hw/spapr_pci.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/h

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-01 Thread Benjamin Herrenschmidt
On Mon, 2012-04-02 at 14:04 +1000, David Gibson wrote: > From: Ben Herrenschmidt > > If the kernel page size is larger than TARGET_PAGE_SIZE, which > happens for example on ppc64 with kernels compiled for 64K pages, > the dirty tracking doesn't work. BTW. That was discussed ages back on the list

[Qemu-devel] [PATCH 2/2] usb-xhci: Use PCI DMA helper functions

2012-04-01 Thread David Gibson
Shortly before 1.0, we added helper functions / wrappers for doing PCI DMA from individual devices. This makes what's going on clearer and means that when we add IOMMU support somewhere in the future, only the general PCI code will have to change, not every device that uses PCI DMA. However, usb-

[Qemu-devel] [PATCH 1/2] Better support for dma_addr_t variables

2012-04-01 Thread David Gibson
A while back, we introduced the dma_addr_t type, which is supposed to be used for bus visible memory addresses. At present, this is an alias for target_phys_addr_t, but this will change when we eventually add support for guest visible IOMMUs. There are some instances of target_phys_addr_t in the

[Qemu-devel] [0/2] Convert usb-xhci to use PCI DMA helpers

2012-04-01 Thread David Gibson
This patch converts the usb-xhci driver to use the pci_dma_*() helper functions instead of direct guest memory access. To do this we need a little preliminary patch which adds property support for dma_addr_t variables. The preliminary patch was sent standalone before, but it's been requested that

[Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-01 Thread David Gibson
From: Ben Herrenschmidt If the kernel page size is larger than TARGET_PAGE_SIZE, which happens for example on ppc64 with kernels compiled for 64K pages, the dirty tracking doesn't work. Cc: Avi Kivity Cc: Marcelo Tosatti Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson ---

Re: [Qemu-devel] [PATCH 00/12 v11] introducing a new, dedicated guest memory dump mechanism

2012-04-01 Thread Wen Congyang
At 03/28/2012 08:44 PM, Luiz Capitulino Wrote: > On Wed, 28 Mar 2012 13:17:43 +0800 > Wen Congyang wrote: > >> Hi, Luiz, Anthony, Jan >> >> do you have any comments about this patchset? > > As far as QMP is concerned: > > Acked-by: Luiz Capitulino I fix a overflow bug and resend patch 12/12

[Qemu-devel] [PATCH 12/12 v11.5] introduce a new monitor command 'dump-guest-memory' to dump guest's memory

2012-04-01 Thread Wen Congyang
The command's usage: dump [-p] protocol [begin] [length] The supported protocol can be file or fd: 1. file: the protocol starts with "file:", and the following string is the file's path. 2. fd: the protocol starts with "fd:", and the following string is the fd's name. Note: 1. If you wa

Re: [Qemu-devel] [PATCH 12/12 v11] introduce a new monitor command 'dump-guest-memory' to dump guest's memory

2012-04-01 Thread Wen Congyang
At 03/26/2012 06:06 PM, Wen Congyang Wrote: > The command's usage: >dump [-p] protocol [begin] [length] > The supported protocol can be file or fd: > 1. file: the protocol starts with "file:", and the following string is >the file's path. > 2. fd: the protocol starts with "fd:", and the fol

Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device

2012-04-01 Thread David Gibson
Anthony.. please apply? On Mon, Mar 26, 2012 at 12:19:40PM +1100, David Gibson wrote: > Currently the virtio balloon device, when using the virtio-pci interface > advertises itself with PCI class code MEMORY_RAM. This is wrong; the > balloon is vaguely related to memory, but is nothing like a PC

Re: [Qemu-devel] [PATCH] tests: remove .SECONDARY special target

2012-04-01 Thread Luiz Capitulino
On Sat, 31 Mar 2012 12:50:21 +0200 Paolo Bonzini wrote: > The special target should not be needed anymore, and caused (perhaps > due to a Make bug) a failure with "make -j2". In any case, the > main makefile is a better place for such special targets rather > than an included makefile. > > Repo

[Qemu-devel] [PATCH v5 1/8] tracetool: Rewrite infrastructure as python modules

2012-04-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile.objs |6 Makefile.target | 13 - configure |4 scripts/tracetool | 648 - scripts/tracetool.py |

[Qemu-devel] [PATCH v5 7/8] tracetool: Add support for the 'dtrace' backend

2012-04-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py| 32 +++- scripts/tracetool/__init__.py | 11 scripts/tracetool/backend/dtrace.py | 97 +++ scripts/tracetool/format/d.py | 20 +++ scripts/tracetool/format/

[Qemu-devel] [PATCH v5 3/8] tracetool: Add module for the 'h' format

2012-04-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/format/h.py | 45 + 1 files changed, 45 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/format/h.py diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h.py new fil

[Qemu-devel] [PATCH v5 8/8] tracetool: Add MAINTAINERS info

2012-04-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- MAINTAINERS |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f83d07c2..0e66dd8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -548,6 +548,8 @@ Tracing M: Stefan Hajnoczi S: Maintained F: trace/ +F: scrip

[Qemu-devel] [PATCH v5 6/8] tracetool: Add support for the 'ust' backend

2012-04-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/ust.py | 90 ++ 1 files changed, 90 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/backend/ust.py diff --git a/scripts/tracetool/backend/ust.py b/scripts/tracetool/backend/ust.p

[Qemu-devel] [PATCH v5 5/8] tracetool: Add support for the 'simple' backend

2012-04-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/simple.py | 55 +++ 1 files changed, 55 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/backend/simple.py diff --git a/scripts/tracetool/backend/simple.py b/scripts/tracetool/backen

[Qemu-devel] [PATCH v5 4/8] tracetool: Add support for the 'stderr' backend

2012-04-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/stderr.py | 56 +++ 1 files changed, 56 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/backend/stderr.py diff --git a/scripts/tracetool/backend/stderr.py b/scripts/tracetool/backen

[Qemu-devel] [PATCH v5 2/8] tracetool: Add module for the 'c' format

2012-04-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/format/c.py | 20 1 files changed, 20 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/format/c.py diff --git a/scripts/tracetool/format/c.py b/scripts/tracetool/format/c.py new file mode 100644 index 0

[Qemu-devel] [PATCH v5 0/8] Rewrite tracetool using python modules

2012-04-01 Thread Lluís Vilanova
A full rewrite of the tracetool script using per-format and per-backend modules, so that it's easier to read and extend it in the future. Signed-off-by: Lluís Vilanova --- NOTE: This series applies in current master, ignoring the "Rewrite tracetool using python" series. Changes in v5: * D

[Qemu-devel] [PATCH] qxl: Add missing GCC_FMT_ATTR and fix format specifier

2012-04-01 Thread Stefan Weil
val is an uint64_t, therefore %d was not correct. Cc: Gerd Hoffmann Signed-off-by: Stefan Weil --- hw/qxl.c |2 +- hw/qxl.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 47a162e..85028dd 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1370,7 +1

[Qemu-devel] [PATCH 4/5] target-lm32: add simple disassembler

2012-04-01 Thread Michael Walle
Because binutils disassembler is based on libopcode, this is a rewrite from scratch. Signed-off-by: Michael Walle --- Makefile.objs |1 + configure |4 + dis-asm.h |3 + disas.c |6 + lm32-dis.c| 361 + 5

Re: [Qemu-devel] [PULL v2 0/5] lm32 fixes and additions

2012-04-01 Thread Blue Swirl
On Sun, Apr 1, 2012 at 18:37, Michael Walle wrote: > Hi Blue, > > Please pull the following lm32 fixes and additions. Thanks, pulled. > v2: >  - prefix enumerations in lm32-dis.c to avoid name conflicts > > The following changes since commit b7c8e15a146a7b20021b524f41d6b8072ee093b5: > >  Merge b

[Qemu-devel] [PATCH 5/5] milkymist-vgafb: add missing register

2012-04-01 Thread Michael Walle
This bug existed since the first commit. Fortunately, the affected registers have no functionality in qemu. This will only prevent the following warning: milkymist_vgafb: write access to unknown register 0x0034 Signed-off-by: Michael Walle --- hw/milkymist-vgafb.c |5 - 1 files cha

[Qemu-devel] [PATCH 3/5] milkymist-sysctl: support for new core version

2012-04-01 Thread Michael Walle
The new version introduces the following new registers: - SoC clock frequency: read-only of system clock used on the SoC - debug scratchpad: 8 bit scratchpad register - debug write lock: write once register, without any function on QEMU Signed-off-by: Michael Walle --- hw/milkymist-sysctl.c |

[Qemu-devel] [PATCH 2/5] target-lm32: init tcg only if available

2012-04-01 Thread Michael Walle
Once qtest support for target-lm32 arrives, tcg may be disabled. Signed-off-by: Michael Walle --- target-lm32/helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-lm32/helper.c b/target-lm32/helper.c index 5db8f8d..78076e4 100644 --- a/target-lm32/helper.c ++

[Qemu-devel] [PATCH 1/5] tests: fix out-of-tree building for lm32 target

2012-04-01 Thread Michael Walle
Signed-off-by: Michael Walle --- configure |4 +++- tests/tcg/lm32/Makefile | 13 - 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/configure b/configure index b51a749..4ef5ec6 100755 --- a/configure +++ b/configure @@ -3876,7 +3876,8 @@ echo "QEMU_

[Qemu-devel] [PULL v2 0/5] lm32 fixes and additions

2012-04-01 Thread Michael Walle
Hi Blue, Please pull the following lm32 fixes and additions. v2: - prefix enumerations in lm32-dis.c to avoid name conflicts The following changes since commit b7c8e15a146a7b20021b524f41d6b8072ee093b5: Merge branch 'arm-devs.for-upstream' of git://git.linaro.org/people/pmaydell/qemu-arm (20

Re: [Qemu-devel] [PATCH 4/5] target-lm32: add simple disassembler

2012-04-01 Thread Blue Swirl
On Sat, Mar 31, 2012 at 18:40, Michael Walle wrote: > Because binutils disassembler is based on libopcode, this is a rewrite from > scratch. > > Signed-off-by: Michael Walle > --- >  Makefile.objs |    1 + >  configure     |    4 + >  dis-asm.h     |    3 + >  disas.c       |    6 + >  lm32-dis.c

Re: [Qemu-devel] [PATCH] Better support for dma_addr_t variables

2012-04-01 Thread David Gibson
On Sun, Apr 01, 2012 at 12:17:28PM +0300, Michael S. Tsirkin wrote: > On Tue, Mar 27, 2012 at 01:43:21PM +1100, David Gibson wrote: > > A while back, we introduced the dma_addr_t type, which is supposed to > > be used for bus visible memory addresses. At present, this is an > > alias for target_ph

Re: [Qemu-devel] [PATCH v3] spice_info: add mouse_mode

2012-04-01 Thread Alon Levy
On Fri, Mar 30, 2012 at 10:12:56AM +0200, Gerd Hoffmann wrote: > Hi, > > > +# @SpiceQueryMouseMode > > +# > > +# An enumation of Spice mouse states. > > +# > > +# @client: Mouse cursor position is determined by the client. > > +# > > +# @server: Mouse cursor position is determined by the server.

Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-04-01 Thread Michael S. Tsirkin
On Sat, Mar 31, 2012 at 12:15:34AM +0200, Jan Kiszka wrote: > On 2012-03-30 23:09, Alex Williamson wrote: > > On Fri, 2012-03-30 at 22:35 +0200, Jan Kiszka wrote: > >> On 2012-03-30 22:31, Jason Baron wrote: > >>> On Fri, Mar 30, 2012 at 10:18:31PM +0200, Jan Kiszka wrote: > >>> The root cause

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Gleb Natapov
On Thu, Mar 29, 2012 at 02:51:44PM +0200, Michael S. Tsirkin wrote: > piix acpi interface suffers from the following 2 issues: > > 1. > - delete device a > - quickly add device b in another slot > > if we do this before guest reads the down register, > the down event is discarded and device will

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Gleb Natapov
On Sun, Apr 01, 2012 at 12:13:18PM +0300, Gleb Natapov wrote: > On Sun, Apr 01, 2012 at 12:06:16PM +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 01, 2012 at 11:26:18AM +0300, Gleb Natapov wrote: > > > On Sun, Apr 01, 2012 at 11:22:33AM +0300, Michael S. Tsirkin wrote: > > > > > And if pci-hotplu

Re: [Qemu-devel] [PATCH] Better support for dma_addr_t variables

2012-04-01 Thread Michael S. Tsirkin
On Tue, Mar 27, 2012 at 01:43:21PM +1100, David Gibson wrote: > A while back, we introduced the dma_addr_t type, which is supposed to > be used for bus visible memory addresses. At present, this is an > alias for target_phys_addr_t, but this will change when we eventually > add support for guest v

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Gleb Natapov
On Sun, Apr 01, 2012 at 12:06:16PM +0300, Michael S. Tsirkin wrote: > On Sun, Apr 01, 2012 at 11:26:18AM +0300, Gleb Natapov wrote: > > On Sun, Apr 01, 2012 at 11:22:33AM +0300, Michael S. Tsirkin wrote: > > > > And if pci-hotplug could be done as cpu-hotplug, then it would simplify > > > > pci-ho

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Michael S. Tsirkin
On Sun, Apr 01, 2012 at 11:26:18AM +0300, Gleb Natapov wrote: > On Sun, Apr 01, 2012 at 11:22:33AM +0300, Michael S. Tsirkin wrote: > > > And if pci-hotplug could be done as cpu-hotplug, then it would simplify > > > pci-hotplug > > > (guest would only need to read PCI_BASE) and probably it would b

Re: [Qemu-devel] More build breakage: signrom.sh vs kvmvapic.bin

2012-04-01 Thread Brad Smith
On 01/04/12 4:36 AM, Jan Kiszka wrote: It is only build on x86 unix hosts minus Mac. We are shipping it as binary for the rest. There is WIP on getting KVM working for Solaris, so this may not be of Linux-only interest in the future. Ok so you then build it on Linux and Solaris. But I don't see

Re: [Qemu-devel] [PATCH] vhost-net: Move asserts to after check for end < start

2012-04-01 Thread Michael S. Tsirkin
On Fri, Mar 30, 2012 at 07:21:22PM -0700, Josh Durgin wrote: > On 12/16/2011 12:33 PM, Bruce Rogers wrote: > >When migrating a vm using vhost-net we hit the following assertion: > > > >qemu-kvm: /usr/src/packages/BUILD/qemu-kvm-0.15.1/hw/vhost.c:30: > >vhost_dev_sync_region: Assertion `start / (0x1

Re: [Qemu-devel] [PATCH 3/4] Switch from array based resource allocation to list

2012-04-01 Thread Kevin O'Connor
On Sun, Apr 01, 2012 at 03:28:34AM -0400, Kevin O'Connor wrote: > On Wed, Mar 28, 2012 at 05:54:10PM +1300, Alexey Korolev wrote: > > In this patch instead of array based resource allocation approach > > we calculate resource addresses linked lists of pci_region_entry structures. > > Thanks. I st

Re: [Qemu-devel] More build breakage: signrom.sh vs kvmvapic.bin

2012-04-01 Thread Jan Kiszka
On 2012-04-01 10:36, Jan Kiszka wrote: > On 2012-04-01 04:48, Brad Smith wrote: >> Here is another source of build breakage that popped up over a month ago. >> >> The patch below fixes the build but I'm wondering why the file in question >> is being built on anything but Linux. It seems to be used

Re: [Qemu-devel] More build breakage: signrom.sh vs kvmvapic.bin

2012-04-01 Thread Jan Kiszka
On 2012-04-01 04:48, Brad Smith wrote: > Here is another source of build breakage that popped up over a month ago. > > The patch below fixes the build but I'm wondering why the file in question > is being built on anything but Linux. It seems to be used for KVM support > and thus has no relevance

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Michael S. Tsirkin
On Fri, Mar 30, 2012 at 06:05:26PM +0200, Igor Mammedov wrote: > On 03/29/2012 02:51 PM, Michael S. Tsirkin wrote: > >piix acpi interface suffers from the following 2 issues: > > > >1. > >- delete device a > >- quickly add device b in another slot > > > >if we do this before guest reads the down re

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Gleb Natapov
On Sun, Apr 01, 2012 at 11:22:33AM +0300, Michael S. Tsirkin wrote: > > And if pci-hotplug could be done as cpu-hotplug, then it would simplify > > pci-hotplug > > (guest would only need to read PCI_BASE) and probably it would be possible > > to unify hotplug > > code for pci/cpu. But that for su

Re: [Qemu-devel] [PATCH 3/4] Switch from array based resource allocation to list

2012-04-01 Thread Kevin O'Connor
On Wed, Mar 28, 2012 at 05:54:10PM +1300, Alexey Korolev wrote: > In this patch instead of array based resource allocation approach > we calculate resource addresses linked lists of pci_region_entry structures. Thanks. I still think this migration can be done more seamlessly. I played with your