On Fri, Mar 30, 2012 at 10:12:56AM +0200, Gerd Hoffmann wrote: > Hi, > > > +# @SpiceQueryMouseMode > > +# > > +# An enumation of Spice mouse states. > > +# > > +# @client: Mouse cursor position is determined by the client. > > +# > > +# @server: Mouse cursor position is determined by the server. > > +# > > +# @unknown: No information is available about mouse mode used by > > +# the spice server. > > +# > > +# Note: spice/enums.h has a SpiceMouseMode already, hence the name. > > I guess it makes sense then to just add "unknown" to the existing > SpiceMouseMode and reuse it ...
hmm, actually that would require adding #include "spice/enums.h" to qapi-types.h, not sure that would be accepted happily - making qapi-types depend on spice.h must be controlled with an ifdef since spice can be disabled, and that means the schema would be different depending on the configuration options - I know we specifically don't change command line options based on configure flags, just the results of using them. > > cheers, > Gerd >