Re: [Qemu-devel] [PATCH v4 14/18] virtio-scsi: process control queue requests

2012-02-23 Thread Hu Tao
On Wed, Feb 22, 2012 at 03:33:52PM +0100, Paolo Bonzini wrote: > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini > --- > hw/virtio-scsi.c | 134 ++--- > 1 files changed, 126 insertions(+), 8 deletions(-) > > diff --git a/hw/virtio-scs

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Peter Lieven
Am 24.02.2012 um 08:23 schrieb Stefan Hajnoczi: > On Fri, Feb 24, 2012 at 6:53 AM, Stefan Hajnoczi wrote: >> On Fri, Feb 24, 2012 at 6:41 AM, Stefan Hajnoczi wrote: >>> On Thu, Feb 23, 2012 at 7:08 PM, peter.lie...@gmail.com >>> wrote: Stefan Hajnoczi schrieb: > On Thu, Feb 23

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Stefan Hajnoczi
On Fri, Feb 24, 2012 at 6:53 AM, Stefan Hajnoczi wrote: > On Fri, Feb 24, 2012 at 6:41 AM, Stefan Hajnoczi wrote: >> On Thu, Feb 23, 2012 at 7:08 PM, peter.lie...@gmail.com wrote: >>> Stefan Hajnoczi schrieb: >>> On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven wrote: > However, in a virt

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Gleb Natapov
On Thu, Feb 23, 2012 at 04:42:54PM +, Stefan Hajnoczi wrote: > On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven wrote: > > However, in a virtual machine I have not observed the above slow down to > > that extend > > while the benefit of zero after free in a virtualisation environment is > > obvio

Re: [Qemu-devel] [PATCH v2 0/4] RTC: New logic to emulate RTC

2012-02-23 Thread Paolo Bonzini
On 02/24/2012 01:55 AM, Zhang, Yang Z wrote: > Hi paolo The DM and 24/12 test case assumes the changing of DM bit > will reflect to RTC internal clock. But the datasheet said nothing > will affect if you change it. Also, the current logic in qemu has the > same assumption. Does this a bug or just b

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Stefan Hajnoczi
On Fri, Feb 24, 2012 at 6:41 AM, Stefan Hajnoczi wrote: > On Thu, Feb 23, 2012 at 7:08 PM, peter.lie...@gmail.com wrote: >> >> >> >> >> Stefan Hajnoczi schrieb: >> >>>On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven wrote: However, in a virtual machine I have not observed the above slow down

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 7:08 PM, peter.lie...@gmail.com wrote: > > > > > Stefan Hajnoczi schrieb: > >>On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven wrote: >>> However, in a virtual machine I have not observed the above slow down >>to >>> that extend >>> while the benefit of zero after free in a

Re: [Qemu-devel] [Bug 939027] Re: Combining direct_io and non-direct_io leads to hang

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 9:39 PM, Avleen Vig <939...@bugs.launchpad.net> wrote: > Nothing else at all accesses those files, which is one of the things that > concerned me the most :-/ > It looks like it call came from the same place. It's possible to check the file descriptor flags using /proc/$PI

[Qemu-devel] Backing file Explanation ?

2012-02-23 Thread PANKAJ RAWAT
Hi all can anoyone explain about backing file? How it is written and in which fashion ? and what role it plays when the clusters are allocated ?

Re: [Qemu-devel] Core dumps - commit a0abe474d587499a1553372c1692811f81fd3eda

2012-02-23 Thread Roy Tam
Hi, 2012/2/24 Gerhard Wiesinger : > Hi, > > I'm getting coredumps: > #0  qemu_opt_find (opts=0x0, name=0x7f18e8c833db "kernel") at > qemu-option.c:535 > 535         QTAILQ_FOREACH_REVERSE(opt, &opts->head, QemuOptHead, next) { > > I bisected it down to the following commit: > a0abe474d587499a15533

[Qemu-devel] Core dumps - commit a0abe474d587499a1553372c1692811f81fd3eda

2012-02-23 Thread Gerhard Wiesinger
Hi, I'm getting coredumps: #0 qemu_opt_find (opts=0x0, name=0x7f18e8c833db "kernel") at qemu-option.c:535 535 QTAILQ_FOREACH_REVERSE(opt, &opts->head, QemuOptHead, next) { I bisected it down to the following commit: a0abe474d587499a1553372c1692811f81fd3eda is the first bad commit commit

Re: [Qemu-devel] [PATCH 8/8] Make dma_addr_t 64 bit always

2012-02-23 Thread David Gibson
On Fri, Feb 24, 2012 at 02:27:43PM +1100, David Gibson wrote: Oops, ignore this one folks. As is probably obvious, this was a testing patch not meant to go into the main series. > --- > dma.h |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/dma.h b/dma.h >

[Qemu-devel] [PATCH 6/8] Make sglists and dma_bdrv helpers use new universal DMA herlpers

2012-02-23 Thread David Gibson
dma-helpers.c contains a number of helper functions for doing scatter/gather DMA, and various block device related DMA. Currently, these directly access guest memory using cpu_physical_memory_*(), assuming no IOMMU translation. This patch updates this code to use the new universal DMA helper func

[Qemu-devel] [PATCH 1/8] Use DMADirection type for dma_bdrv_io

2012-02-23 Thread David Gibson
Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to determine the direction of DMA it is emulating. We already have a DMADirection enum designed specifically to encode DMA directions. This patch uses it for dma_bdrv_io() as well. Cc: Kevin Wolf Signed-off-by: David Gibson --- dma-he

[Qemu-devel] [PATCH 8/8] Make dma_addr_t 64 bit always

2012-02-23 Thread David Gibson
--- dma.h |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/dma.h b/dma.h index b8cfd1d..ee540f4 100644 --- a/dma.h +++ b/dma.h @@ -18,10 +18,13 @@ typedef struct ScatterGatherEntry ScatterGatherEntry; #if defined(TARGET_PHYS_ADDR_BITS) -typedef target_phys_addr_

[Qemu-devel] [PATCH 4/8] Add universal DMA helper functions

2012-02-23 Thread David Gibson
Not that long ago, every device implementation using DMA directly accessed guest memory using cpu_physical_memory_*(). This meant that adding support for a guest visible IOMMU would require changing every one of these devices to go through IOMMU translation. Shortly before qemu 1.0, I made a star

[Qemu-devel] [PATCH 7/8] ide/ahci: Use universal DMA helper functions

2012-02-23 Thread David Gibson
The AHCI device can provide both PCI and SysBus AHCI device emulations. For this reason, it wasn't previously converted to use the pci_dma_*() helper functions. Now that we have universal DMA helper functions, this converts AHCI to use them. The DMAContext is obtained from pci_dma_context() in t

[Qemu-devel] [PATCH 2/8] Better support for dma_addr_t variables

2012-02-23 Thread David Gibson
A while back, we introduced the dma_addr_t type, which is supposed to be used for bus visible memory addresses. At present, this is an alias for target_phys_addr_t, but this will change when we eventually add support for guest visible IOMMUs. There are some instances of target_phys_addr_t in the

[Qemu-devel] [PATCH 3/8] usb-xhci: Use PCI DMA helper functions

2012-02-23 Thread David Gibson
Shortly before 1.0, we added helper functions / wrappers for doing PCI DMA from individual devices. This makes what's going on clearer and means that when we add IOMMU support somewhere in the future, only the general PCI code will have to change, not every device that uses PCI DMA. However, usb-

[Qemu-devel] [PATCH 5/8] usb-ohci: Use universal DMA helper functions

2012-02-23 Thread David Gibson
The OHCI device emulation can provide both PCI and SysBus OHCI implementations. Because of this, it was not previously converted to use the PCI DMA helper functions. This patch converts it to use the new universal DMA helper functions. In the PCI case, it obtains its DMAContext from pci_dma_conte

[Qemu-devel] [0/8] RFC: A second batch of preliminaries towards guest visible IOMMUS

2012-02-23 Thread David Gibson
Before qemu 1.0 there was some discussion, and several patch series proposed for adding support for guest visible IOMMU emulation to qemu. No agreement was reached on how to do this, but a patch series did go in preparation - a conversion of most existing PCI devices to use helper functions for th

[Qemu-devel] [Bug 824650] Re: Latest GIT assert error in arp_table.c

2012-02-23 Thread Roy Tam
let me make comment on current git (v1.0-1172-g235fe3b), my XP SP3 -net dump is attached. You can see slirp almost not returning anything to guest (10.0.2.15), while the outgoing packets seem to be delivered correctly. ** Attachment added: "net dump from v1.0-1172-g235fe3b with XP SP3 guest"

[Qemu-devel] [Bug 939995] Re: v1.0-1172-g235fe3b crashes (opts=0x0)

2012-02-23 Thread Roy Tam
qemu_opt_find() doesn't check if opts is NULL or not before use. The patch fixes that issue. ** Patch added: "optfind_fixsegfault.patch" https://bugs.launchpad.net/qemu/+bug/939995/+attachment/2777432/+files/optfind_fixsegfault.patch -- You received this bug notification because you are a me

[Qemu-devel] [Bug 939995] [NEW] v1.0-1172-g235fe3b crashes (opts=0x0)

2012-02-23 Thread Roy Tam
Public bug reported: C:\msys\home\User\qemu\i386-softmmu>gdb --args qemu-system-i386.exe -L ..\pc-bios GNU gdb (GDB) 7.3 Copyright (C) 2011 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change an

[Qemu-devel] [PATCH 2/3] Allow larger return values from get_image_size()

2012-02-23 Thread David Gibson
Currently get_image_size(), used to find the size of files, returns an int. But for modern systems, int may be only 32-bit and we can have files larger than that. This patch, therefore, changes the return type of get_image_size() to off_t (the same as the return type from lseek() itself). It also

[Qemu-devel] [PATCH 4/6] Endian fixes for virtfs

2012-02-23 Thread David Gibson
From: Benjamin Herrenschmidt This patch fixes several endian bugs in virtfs. Cc: Aneesh Kumar K.V Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- hw/9pfs/virtio-9p.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/h

[Qemu-devel] [PATCH 3/6] USB OHCI bug fixes

2012-02-23 Thread David Gibson
From: Wei Yang This patch fixes two bugs in the OHCI device where the device writes back data to system memory that should be exclusively under the control of the guest side driver. In OHCI specification Section 5.2.7, it mentioned "In all cases, Host Controller Driver is responsible for the ins

Re: [Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large kernel page size

2012-02-23 Thread Benjamin Herrenschmidt
> diff --git a/kvm-all.c b/kvm-all.c > index 5e188bf..3f8cfd9 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -348,10 +348,11 @@ static int kvm_set_migration_log(int enable) > static int kvm_get_dirty_pages_log_range(MemoryRegionSection *section, > unsigne

Re: [Qemu-devel] [PATCH v2 0/4] RTC: New logic to emulate RTC

2012-02-23 Thread Zhang, Yang Z
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, February 22, 2012 7:19 PM > 0) My alarm tests failed quite badly. :( I attach a patch for kvm-unit-tests > (repository at git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git). > The tests can be

[Qemu-devel] [PATCH 1/3] pci: Factor out bounds checking on config space accesses

2012-02-23 Thread David Gibson
There are several paths into the code to emulate PCI config space accesses: one for MMIO to a plain old PCI bridge one for MMIO to a PCIe bridge and one for the pseries machine which provides para-virtualized access to PCI config space. Each of these functions does their own bounds checking agains

Re: [Qemu-devel] [PATCH 2/3] Allow larger return values from get_image_size()

2012-02-23 Thread Michael S. Tsirkin
On Fri, Feb 24, 2012 at 11:36:45AM +1100, David Gibson wrote: > Currently get_image_size(), used to find the size of files, returns an int. > But for modern systems, int may be only 32-bit and we can have files > larger than that. > > This patch, therefore, changes the return type of get_image_siz

[Qemu-devel] [PATCH 5/6] Endian fix an assertion in usb-msd

2012-02-23 Thread David Gibson
From: Benjamin Herrenschmidt This fixes a broken endian assumption in an assertion in usb-msd. Cc: Gerd Hoffman Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- hw/usb-msd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-

[Qemu-devel] [PATCH 1/6] kvm: Comparison with ioctl number macros needs to be unsigned

2012-02-23 Thread David Gibson
In kvm-all.c we store an ioctl cmd number in the irqchip_inject_ioctl field of KVMState, which has type 'int'. This seems to make sense since the ioctl() man page says that the cmd parameter has type int. However, the kernel treats ioctl numbers as unsigned - sys_ioctl() takes an unsigned int, an

[Qemu-devel] [PATCH 3/3] .gitignore update

2012-02-23 Thread David Gibson
This adds a few previously missing generated files to .gitignore: the qemu-bridge-helper binary, and the linuxboot and multiboot images from pc-bios/optionrom. Signed-off-by: David Gibson --- .gitignore |1 + pc-bios/optionrom/.gitignore |3 +++ 2 files changed, 4 inser

[Qemu-devel] [0/3] Various code cleanups

2012-02-23 Thread David Gibson
These 3 patches make several cleanups to the qemu code; they affect files across the tree, particularly 2/3. Please apply.

[Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large kernel page size

2012-02-23 Thread David Gibson
From: Benjamin Herrenschmidt If the kernel page size is larger than TARGET_PAGE_SIZE, which happens for example on ppc64 with kernels compiled for 64K pages, the dirty tracking doesn't work. Cc: Avi Kivity Cc: Marcelo Tossatti Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson

[Qemu-devel] [PATCH 2/6] slirp: Fix assertion failure on rejected DHCP requests

2012-02-23 Thread David Gibson
The guest network stack might DHCPREQUEST an address that the slirp built in dhcp server can't let it have - for example if the guest has an old leases file from another network configuration. In this case the dhcp server should and does reject the request and prepares to send a DHCPNAK to the cli

[Qemu-devel] [0/6] Assorted bugfixes

2012-02-23 Thread David Gibson
Hi Anthony, This series contains my current accumulated batch of qemu bugfixes which are not ppc specific. There are small, but real, fixes from across the codebase. Maintainers for the individual subsystems should be CCed. Please apply.

Re: [Qemu-devel] [offtopic] Sparc Softmmu

2012-02-23 Thread P. Wilhelm
We use the old Solaris/Sparc in a medical device we produce where I work. Since we can't get new Sparc hardware any longer (many countries no longer accept "refurbished" devices - so we can't sell this product to them when we use refurbish IT parts) that is reasonable cost for our application,

Re: [Qemu-devel] arm-linux-user, i386-linux-user: Make QEMU act as TCG compiler

2012-02-23 Thread Peter Maydell
2012/2/23 Rajat Goyal : > Would QEMU developers be interested in integrating this TCG compilation > functionality that I have been working on into later releases of QEMU? The > patch I have right now breaks the original emulation but if there is some > interest in supporting static compilation into

[Qemu-devel] Qemu for simulating SoCs?

2012-02-23 Thread Magnus Therning
Hello, Qemu seems to mostly ship with emulation of individual CPUs (e.g. ARM processors) and with emulation of boards (e.g. versatile), is it also used for emulation of SoC? I've looked around a bit, and found some indications of it, e.g. a branch that allows connection between SystemC and qemu.

Re: [Qemu-devel] Qemu for simulating SoCs?

2012-02-23 Thread Peter Maydell
On 23 February 2012 14:36, Magnus Therning wrote: > Qemu seems to mostly ship with emulation of individual CPUs (e.g. ARM > processors) and with emulation of boards (e.g. versatile), is it also > used for emulation of SoC? Yes. Our infrastructure for doing it in a neatly encapsulated way has been

[Qemu-devel] QEMU PEX HW device

2012-02-23 Thread Shlomo Pongratz
Hi, I want to add a new PEX HW device emulation to QEMU, but I can't find a skeleton/template driver or documentation that explains how to do it. Are there any guidelines for this task? Best regards, S.P.

[Qemu-devel] RFC: Change the default display adapter

2012-02-23 Thread Marko Myllynen
Hi, glxgears shows that vga provides much better FPS rate than cirrus (these numbers are from RHEL 6.2 host/guest on a Lenovo laptop): cirrus : 78 FPS vga: 260 FPS This makes one wonder should the default display adapter in qemu be changed from cirrus to vga? Thanks, -- Marko Myllynen

Re: [Qemu-devel] [RFC] sdl: initialize all graphic consoles

2012-02-23 Thread Anthony Liguori
On 02/23/2012 03:39 PM, Hervé Poussineau wrote: MIPS Jazz emulation registers two graphical consoles, but second one stays black. This patch repairs it. Other display methods (cocoa, vnc...) also probably require the same kind of fix. I don't think this is really the right way to solve this

[Qemu-devel] [PATCH 6/8] qemu-ga: add initial win32 support

2012-02-23 Thread Michael Roth
This adds a win32 channel implementation that makes qemu-ga functional on Windows using virtio-serial (unix-listen/isa-serial not currently implemented). Unlike with the posix implementation, we do not use GIOChannel for the following reasons: - glib calls stat() on an fd to check whether S_IFCHR

[Qemu-devel] [PATCH 8/8] qemu-ga: add win32 guest-shutdown command

2012-02-23 Thread Michael Roth
Implement guest-shutdown RPC for Windows. Functionally this should be equivalent to the posix implementation. Original patch by Gal Hammer Signed-off-by: Michael Roth --- qga/commands-win32.c | 41 - 1 files changed, 40 insertions(+), 1 deletions(-) d

[Qemu-devel] [PATCH 2/8] qemu-ga: move channel/transport functionality into wrapper class

2012-02-23 Thread Michael Roth
This is mostly in preparation for the win32 port, which won't use GIO channels for reasons that will be made clearer later. Here the GAChannel class is just a loose wrapper around GIOChannel calls/callbacks, but we also roll in the logic/configuration for various channel types and managing unix soc

[Qemu-devel] [PATCH 7/8] qemu-ga: add Windows service integration

2012-02-23 Thread Michael Roth
This allows qemu-ga to function as a Windows service: - to install the service (will auto-start on boot): qemu-ga --service install - to start the service: net start qemu-ga - to stop the service: net stop qemu-ga - to uninstall service: qemu-ga --service uninstall Origina

[Qemu-devel] [PATCH 3/8] qemu-ga: separate out common commands from posix-specific ones

2012-02-23 Thread Michael Roth
Many of the current RPC implementations are very much POSIX-specific and require complete re-writes for Windows. There are however a small set of core guest agent commands that are common to both, and other commands such as guest-file-* which *may* be portable. So we introduce commands.c for the la

[Qemu-devel] [PATCH 4/8] qemu-ga: rename guest-agent-commands.c -> commands-posix.c

2012-02-23 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile.objs |2 +- qga/commands-posix.c | 528 qga/guest-agent-commands.c | 528 3 files changed, 529 insertions(+), 529 deletions(-) create mode

[Qemu-devel] [PATCH 5/8] qemu-ga: fixes for win32 build of qemu-ga

2012-02-23 Thread Michael Roth
Various stubs and #ifdefs to compile for Windows using mingw cross-build. Still has 1 linker error due to a dependency on the forthcoming win32 versions of the GAChannel/transport class. Signed-off-by: Michael Roth --- Makefile |2 +- Makefile.objs|9 +++-- configure

[Qemu-devel] [PATCH 1/8] qemu-ga: Add schema documentation for types

2012-02-23 Thread Michael Roth
Document guest agent schema types in similar fashion to qmp schema types. Signed-off-by: Michael Roth --- qapi-schema-guest.json | 118 +++- 1 files changed, 97 insertions(+), 21 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.js

[Qemu-devel] [PULL 0/8] qemu-ga: add support for Windows

2012-02-23 Thread Michael Roth
The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99: qom: add test tools (2012-02-22 12:18:26 -0600) are available in the git repository at: git://github.com/mdroth/qemu.git qga-win32-pull-2-23-12 Michael Roth (8): qemu-ga: Add schema documentation for types

[Qemu-devel] [Bug 939027] Re: Combining direct_io and non-direct_io leads to hang

2012-02-23 Thread Avleen Vig
Nothing else at all accesses those files, which is one of the things that concerned me the most :-/ It looks like it call came from the same place. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/93902

[Qemu-devel] [RFC] sdl: initialize all graphic consoles

2012-02-23 Thread Hervé Poussineau
MIPS Jazz emulation registers two graphical consoles, but second one stays black. This patch repairs it. Other display methods (cocoa, vnc...) also probably require the same kind of fix. --- console.c |3 +++ vl.c | 30 +- 2 files changed, 24 insertions(+)

[Qemu-devel] [BUG] Multiple graphical consoles are broken (black screen)

2012-02-23 Thread Hervé Poussineau
Hi, MIPS Magnum machine emulation is quite specific because it instanciates two graphical consoles. This has worked for a while, up to following commit which breaks it badly (qemu crashes): commit 3023f3329d87a6203d03a0e9ccb948772940da96 Author: aliguori Date: Fri Jan 16 19:04:14 2009 +

[Qemu-devel] [PATCH v2 5/6] qapi: String visitor, use %f represenation for floats

2012-02-23 Thread Michael Roth
Currently string-output-visitor formats floats as %g, which is nice in that trailing 0's are automatically truncated, but otherwise this causes some issues: - it 6 uses significant figures instead of 6 decimal places, which means something like 155777.5 (which even has an exact floating point

[Qemu-devel] [PATCH v2 2/6] qapi: unit tests for visitor-based serialization

2012-02-23 Thread Michael Roth
Currently we test our visitors individually, and seperately for input vs. output. This is useful for validating internal representations against the native C types and vice-versa, and other visitor-specific testing, but it doesn't cover the potential use-case of using visitor pairs for serializatio

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-23 Thread Stefan Berger
On 02/20/2012 10:48 AM, Stefan Berger wrote: On 02/20/2012 03:51 AM, Michael S. Tsirkin wrote: +static const MemoryRegionOps tpm_tis_memory_ops = { +.read = tpm_tis_mmio_read, +.write = tpm_tis_mmio_write, +.endianness = DEVICE_NATIVE_ENDIAN, Are you sure? Most devices are BIG or

[Qemu-devel] [PATCH v2 3/6] qapi: QMP input visitor, handle floats parsed as ints

2012-02-23 Thread Michael Roth
JSON numbers can be interpreted as either integers or floating point values depending on their representation. As a result, QMP input visitor might visit a QInt when it was expecting a QFloat, so add handling to account for this. Signed-off-by: Michael Roth --- qapi/qmp-input-visitor.c |9 ++

[Qemu-devel] [PATCH v2 6/6] qdev: switch property accessors to fixed-width visitor interfaces

2012-02-23 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/qdev-addr.c |4 ++-- hw/qdev-properties.c | 42 +- 2 files changed, 19 insertions(+), 27 deletions(-) diff --git a/hw/qdev-addr.c b/hw/qdev-addr.c index 0bb16c7..b711b6b 100644 --- a/hw/qdev-addr.c +++ b/hw/q

[Qemu-devel] [PATCH v2 4/6] qapi: add String visitor coverage to serialization unit tests

2012-02-23 Thread Michael Roth
Signed-off-by: Michael Roth --- test-visitor-serialization.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/test-visitor-serialization.c b/test-visitor-serialization.c index 6ef57d0..b8ad16f 100644 --- a/test-visitor-serialization

[Qemu-devel] [PATCH v2 1/6] qapi: add Visitor interfaces for uint*_t and int*_t

2012-02-23 Thread Michael Roth
This adds visitor interfaces for fixed-width integers types. Implementing these in visitors is optional, otherwise we fall back to visit_type_int() (int64_t) with some additional bounds checking to avoid integer overflows for cases where the value fetched exceeds the bounds of our target C type. S

[Qemu-devel] [PATCH v2 0/6] add fixed-width visitors and serialization tests

2012-02-23 Thread Michael Roth
These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git visitor-fixed-width-v2 CHANGES SINCE V1: - unit tests: covert QmpOutputVisitor qobject to json before passing it to QmpInputVisitor*. I.e., actually do the serialization :) - QmpInpu

Re: [Qemu-devel] [PATCH V7 03/11] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE

2012-02-23 Thread Michael S. Tsirkin
On Fri, Feb 17, 2012 at 05:08:37PM +, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Applied, thanks. > --- > hw/pci_regs.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/pci_regs.h b/hw/pci_regs.h > index 6b42515..56a404b 100644 > --- a/hw/pci_regs

Re: [Qemu-devel] PCI: Add PCI_EXP_TYPE_PCIE_BRIDGE value

2012-02-23 Thread Jesse Barnes
On Tue, 21 Feb 2012 16:22:10 + Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > > --- > include/linux/pci_regs.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/linux/pci_regs.h b/include/linux/pci_regs.h > index e41a10f..4b608f5 100644 > --- a

Re: [Qemu-devel] arm-linux-user, i386-linux-user: Make QEMU act as TCG compiler

2012-02-23 Thread Rajat Goyal
Hi Peter, Would QEMU developers be interested in integrating this TCG compilation functionality that I have been working on into later releases of QEMU? The patch I have right now breaks the original emulation but if there is some interest in supporting static compilation into TCG in the future, I

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread peter.lie...@gmail.com
Stefan Hajnoczi schrieb: >On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven wrote: >> However, in a virtual machine I have not observed the above slow down >to >> that extend >> while the benefit of zero after free in a virtualisation environment >is >> obvious: >> >> 1) zero pages can easily be

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Javier Guerra Giraldez
On Thu, Feb 23, 2012 at 11:42 AM, Stefan Hajnoczi wrote: > The other approach is a memory page "discard" mechanism - which > obviously requires more code changes than zeroing freed pages. > > The advantage is that we don't take the brute-force and CPU intensive > approach of zeroing pages.  It wou

Re: [Qemu-devel] qemu assertion failed with usb on current git master!

2012-02-23 Thread Erik Rull
Gerd Hoffmann wrote: On 02/23/12 12:38, Erik Rull wrote: When running qemu with -device usb-host an assertion failed caused by attaching a new usb device to the host that gets routed to the guest. The assertion that fails is: qemu-system-x86_64: /home/erik/qemu/hw/usb.c:358 usb_packet_comple

Re: [Qemu-devel] VirtIO 9p mount_tag (bogus?) limit of 32 bytes

2012-02-23 Thread Aneesh Kumar K.V
On Tue, 21 Feb 2012 21:58:39 -0600, C Anthony Risinger wrote: > On Sat, Feb 18, 2012 at 11:38 AM, Aneesh Kumar K.V > wrote: > > On Thu, 16 Feb 2012 06:20:21 -0600, C Anthony Risinger > > wrote: > >> a) mapped FS security policy (xattrs) causes `ldconfig` to abort()? > >> root or normal user ...

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-23 Thread Federico Simoncelli
- Original Message - > From: "Stefan Hajnoczi" > To: "Federico Simoncelli" > Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com > Sent: Thursday, February 23, 2012 5:35:23 PM > Subject: Re: [Qemu-devel] Live Block Migration using Mirroring > > On Wed, Feb 22, 2012 at 5:13 PM

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2012-02-23 Thread Serge Hallyn
@Jamie, if you feel the priority if this needs to be raised, please do raise it or comment here. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/918791 Title: qemu-kvm dies when using vmvga driver a

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Federico Simoncelli
- Original Message - > From: "Stefan Hajnoczi" > To: "Federico Simoncelli" > Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com > Sent: Thursday, February 23, 2012 5:28:23 PM > Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver > > On Thu, Feb 23, 2012 at 4:20

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven wrote: > However, in a virtual machine I have not observed the above slow down to > that extend > while the benefit of zero after free in a virtualisation environment is > obvious: > > 1) zero pages can easily be merged by ksm or other technique. > 2)

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-23 Thread Stefan Hajnoczi
On Wed, Feb 22, 2012 at 5:13 PM, Federico Simoncelli wrote: >  recently I've been working on live block migration combining the live > snapshots and the blkmirror patch sent by Marcelo Tosatti few months ago. > > The design is summarized at this url as "Mirrored-Snapshot": > > http://www.ovirt.org

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 4:20 PM, Federico Simoncelli wrote: > - Original Message - >> From: "Stefan Hajnoczi" >> To: "Federico Simoncelli" >> Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com >> Sent: Thursday, February 23, 2012 5:18:41 PM >> Subject: Re: [Qemu-devel] [PAT

Re: [Qemu-devel] [PATCH] qom: Make object_unref() free the object's memory when refcount goes to 0.

2012-02-23 Thread Alexander Barabash
On 02/22/2012 09:12 PM, Anthony Liguori wrote: On 02/22/2012 12:00 PM, alexander_barab...@mentor.com wrote: From: Alexander Barabash In the existing implementation, object_delete() calls object_unref(), then frees the object's storage. Running object_delete() on an object with reference count d

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Federico Simoncelli
- Original Message - > From: "Stefan Hajnoczi" > To: "Federico Simoncelli" > Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com > Sent: Thursday, February 23, 2012 5:18:41 PM > Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver > > On Thu, Feb 23, 2012 at 4:14

[Qemu-devel] [PATCH] configure: Check whether makecontext() is a glibc stub function

2012-02-23 Thread Peter Maydell
On some systems (notably ARM Linux) glibc provides implementations of makecontext(), getcontext() and friends which are stubs which always return failure. Make the configure test for makecontext() also check for the presence of the __stub_makecontext macro which indicates the presence of these stub

Re: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

2012-02-23 Thread Peter Maydell
On 23 February 2012 16:16, Peter Maydell wrote: > Improve the configure test for presence of ucontext functions by > making linker warnings fatal; this allows us to detect when we are > linked with a glibc which implements makecontext() to always return > ENOSYS. Er, ignore this, emailed wrong pa

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Federico Simoncelli
- Original Message - > From: "Stefan Hajnoczi" > To: "Federico Simoncelli" > Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com > Sent: Thursday, February 23, 2012 5:14:09 PM > Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver > > On Wed, Feb 22, 2012 at 5:13

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 4:14 PM, Stefan Hajnoczi wrote: > By the way, this code does not build against qemu.git/master.  It uses > interfaces which have been dropped. Ah, I see you changed that in Patch 2/3. Please don't do that, it's hard to review and breaks git-bisect. Stefan

[Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

2012-02-23 Thread Peter Maydell
Improve the configure test for presence of ucontext functions by making linker warnings fatal; this allows us to detect when we are linked with a glibc which implements makecontext() to always return ENOSYS. Signed-off-by: Peter Maydell --- Compiling on an Ubuntu Natty ARM host will hit this. (An

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Stefan Hajnoczi
On Wed, Feb 22, 2012 at 5:13 PM, Federico Simoncelli wrote: > From: Marcelo Tosatti > > Mirrored writes are used by live block copy. I think the right approach is to create a single blkmirror driver that also includes blkverify functionality. The code is basically the same except blkverify also

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-23 Thread Federico Simoncelli
- Original Message - > From: "Stefan Hajnoczi" > To: "Federico Simoncelli" > Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com > Sent: Thursday, February 23, 2012 4:47:38 PM > Subject: Re: [Qemu-devel] Live Block Migration using Mirroring > > On Wed, Feb 22, 2012 at 5:13 PM

Re: [Qemu-devel] FLR capability hidden in VF config space

2012-02-23 Thread Alex Williamson
On Thu, 2012-02-23 at 09:25 +0530, rukhsana ansari wrote: > Hello, > > Was wondering whether someone could shed some light on the issue below. > Without FLR exposed in the VF, VF reset via FLR cannot be initiated from > the guest. > Appreciate any pointers. The device state needs to be restored a

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-23 Thread Stefan Hajnoczi
On Wed, Feb 22, 2012 at 5:13 PM, Federico Simoncelli wrote: > Preparation > === > > $ mkdir /tmp/{src/dst} > $ qemu-img create -f qcow2 /tmp/src/hd0base.qcow2 20G > Formatting '/tmp/src/hd0base.qcow2', fmt=qcow2 size=21474836480 > encryption=off cluster_size=65536 > > Step 1 - Initital Sce

[Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Peter Lieven
Hi, i have recently been playing with an old idea (originally in grsecurity for security reasons) to change the policy from zero on allocate to zero after free in the linux page allocator. My concern is that linux leaves a lot of waste in the physical memory unlike Windows which per default zeros

[Qemu-devel] [Bug 883136] Re: qemu on ARM hosts aborts on startup because makecontext() always fails

2012-02-23 Thread Peter Maydell
Michael Hope pointed out that glibc defines a macro __stub_makecontext when the makecontext() implementation is a stub, so we can just add this to the qemu configure test to make it automatically fall back to the pthreads version as required. -- You received this bug notification because you are

Re: [Qemu-devel] [Bug 938945] [NEW] Slirp cannot be forward and makes segmentation faults

2012-02-23 Thread Andreas Färber
Am 22.02.2012 20:50, schrieb Vincent Autefage: > $ qemu -enable-kvm -name opeth -hda debian1.img -k fr -localtime -m 512 The qemu executable has been renamed to qemu-system-i386 some time ago. Are you sure you're executing the right one, and which version are you using? Did you check qemu.git mast

Re: [Qemu-devel] qemu assertion failed with usb on current git master!

2012-02-23 Thread Gerd Hoffmann
On 02/23/12 12:38, Erik Rull wrote: > When running qemu with -device usb-host an assertion failed caused by > attaching a new usb device to the host that gets routed to the guest. > > The assertion that fails is: > > qemu-system-x86_64: /home/erik/qemu/hw/usb.c:358 usb_packet_complete: > Asserti

[Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray state didn't change

2012-02-23 Thread Luiz Capitulino
It's not needed. Besides we can then assume that bdrv_eject() is only called when there's a tray state change, which is useful to the DEVICE_TRAY_MOVED event (going to be added in a future commit). Signed-off-by: Luiz Capitulino Reviewed-by: Markus Armbruster Acked-by: Kevin Wolf --- hw/ide/at

[Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-23 Thread Luiz Capitulino
It's emitted whenever the tray is moved by the guest or by HMP/QMP commands. Signed-off-by: Luiz Capitulino Reviewed-by: Markus Armbruster Acked-by: Kevin Wolf --- QMP/qmp-events.txt | 18 ++ block.c| 24 monitor.c |3 +++ m

[Qemu-devel] [PATCH 1/5] block: Rename bdrv_mon_event() & BlockMonEventAction

2012-02-23 Thread Luiz Capitulino
They are QMP events, not monitor events. Rename them accordingly. Also, move bdrv_emit_qmp_error_event() up in the file. A new event will be added soon and it's good to have them next each other. Signed-off-by: Luiz Capitulino Reviewed-by: Markus Armbruster Acked-by: Kevin Wolf --- block.c

[Qemu-devel] [PATCH 2/5] block: bdrv_eject(): Make eject_flag a real bool

2012-02-23 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino Reviewed-by: Markus Armbruster Acked-by: Kevin Wolf --- block.c |2 +- block.h |2 +- block/raw-posix.c |6 +++--- block/raw.c |2 +- block_int.h |2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --gi

[Qemu-devel] [PATCH 4/5] ide: drop ide_tray_state_post_load()

2012-02-23 Thread Luiz Capitulino
This is used to sync the physical tray state after migration when using CD-ROM passthrough. However, migrating when using passthrough is broken anyway and shouldn't be supported... So, drop this function as it causes a problem with the DEVICE_TRAY_MOVED event, which is going to be introduced by th

[Qemu-devel] [PULL 0/5]: QMP queue

2012-02-23 Thread Luiz Capitulino
Contains only the DEVICE_TRAY_MOVED event series. The changes (since 235fe3bfd46b1104575b540d0bc3fdf584030b99) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Luiz Capitulino (5): block: Rename bdrv_mon_event() & BlockMonEventAction blo

[Qemu-devel] [PATCH] usb-hid: fix tablet activation

2012-02-23 Thread Gerd Hoffmann
Activate usb hid pointer devices (mouse+tablet) unconditionally on polls, even if we NAK the poll due to lack of new events. Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c index 53353d3..36730ce

  1   2   >