On Thu, Feb 23, 2012 at 4:20 PM, Federico Simoncelli <fsimo...@redhat.com> wrote: > ----- Original Message ----- >> From: "Stefan Hajnoczi" <stefa...@gmail.com> >> To: "Federico Simoncelli" <fsimo...@redhat.com> >> Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com >> Sent: Thursday, February 23, 2012 5:18:41 PM >> Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver >> >> On Thu, Feb 23, 2012 at 4:14 PM, Stefan Hajnoczi <stefa...@gmail.com> >> wrote: >> > By the way, this code does not build against qemu.git/master. It >> > uses >> > interfaces which have been dropped. >> >> Ah, I see you changed that in Patch 2/3. Please don't do that, it's >> hard to review and breaks git-bisect. > > Squashing is easy (anyone could do it at the commit phase), reviewing > is hard (if you hide your changes in someone else's code).
I don't care if you or Marcelo wrote it, I want to see a coherent piece of code. The way to do it is to merge the g_malloc() and BlockDriver interface changes into this path. Then you have not snuck any significant changes into Marcelo's code. Keep the BDRV_O_NO_BACKING separate. Stefan
