Re: [Qemu-devel] [PATCH 5/5] runstate: Allow user to migrate twice

On 10/14/2011 07:26 PM, Luiz Capitulino wrote: It should be a matter of allowing the transition POSTMIGRATE -> FINISH_MIGRATE, but it turns out that the VM won't do the transition the second time because it's already stopped. So this commit also adds vm_stop_force_state() which performs the tran

[Qemu-devel] Guest NIC interfaces always operate in promiscuous mode?

We have been seeing some unexpected behavior in our guests (configuration details below). We have a configuration where we have redundant networks configured in our guests and use IPM to control the network routing over these networks (this is a port of a redundant high availability Linux co

[Qemu-devel] [PATCH 07/10] trace: qemu_(put|get)_(byte|buffer) events

Signed-off-by: Michael Roth --- qemu-file.c | 22 -- trace-events | 18 ++ 2 files changed, 38 insertions(+), 2 deletions(-) diff --git a/qemu-file.c b/qemu-file.c index 3d05622..34bc136 100644 --- a/qemu-file.c +++ b/qemu-file.c @@ -27,6 +27,7 @@ #incl

[Qemu-devel] [PATCH 04/10] savevm: move QEMUFile interfaces into qemu-file.c

Signed-off-by: Michael Roth --- Makefile.objs |2 +- hw/hw.h |1 + qemu-file.c | 541 + savevm.c | 494 4 files changed, 543 insertions(+), 495 deletions(-) create

[Qemu-devel] [PATCH 09/10] qapi: add trace statements to qapi-visit-core.c

Signed-off-by: Michael Roth --- Makefile.objs |2 +- qapi/qapi-visit-core.c | 41 +++-- 2 files changed, 40 insertions(+), 3 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 75c5770..8137cbd 100644 --- a/Makefile.objs +++ b/Makefil

[Qemu-devel] [PATCH 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

Signed-off-by: Michael Roth --- qapi/qapi-visit-core.c | 78 qapi/qapi-visit-core.h | 30 ++ 2 files changed, 108 insertions(+), 0 deletions(-) diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c index ddef3ed..58f11f

[Qemu-devel] [PATCH 10/10] vmstate: use visitors

Signed-off-by: Michael Roth --- hw/eeprom93xx.c| 12 +- hw/fw_cfg.c| 12 +- hw/hw.h|4 +- hw/pci.c | 38 +++-- hw/twl92230.c | 18 ++- qemu-timer.c | 24 ++- qemu-timer.h |5 + savevm.c

[Qemu-devel] [PATCH 06/10] savevm: add QEMUFile->visitor lookup routines

Signed-off-by: Michael Roth --- hw/hw.h | 19 + qemu-file.c | 64 +++ 2 files changed, 83 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 244bfb9..e6d7c6a 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -10

[Qemu-devel] [PATCH 05/10] qapi: test cases for QEMUFile input/output visitors

Signed-off-by: Michael Roth --- Makefile |2 +- test-visitor.c | 404 2 files changed, 405 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index f63fc02..50803b0 100644 --- a/Makefile +++ b/Makefile @@ -204,7 +20

[Qemu-devel] [PATCH 07/24] QMP: query-status: Add 'io-status' key

From: Luiz Capitulino Contains the I/O status for the given device. The key is only present if the device supports it and the VM is configured to stop on errors. Please, check the documentation being added in this commit for more information. Signed-off-by: Luiz Capitulino Reviewed-by: Markus

[Qemu-devel] [PATCH 4/5] savevm: qemu_savevm_state(): Drop stop VM logic

qemu_savevm_state() has some logic to stop the VM and to (or not to) resume it. But this seems to be a big noop, as qemu_savevm_state() is only called by do_savevm() when the VM is already stopped. So, let's drop qemu_savevm_state()'s stop VM logic. Reviewed-by: Michael Roth Reviewed-by: Kevin W

[Qemu-devel] [PATCH 09/24] block/vvfat: Fix potential memory leaks and other memory errors

From: Stefan Weil cppcheck reported memory leaks and mismatched g_malloc() with free() instead of g_free(). Fix these errors. Cc: Kevin Wolf Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf --- block/vvfat.c | 51 ++- 1 files changed, 30

[Qemu-devel] [PATCH 08/10] trace: add trace statements for visitor interface

Signed-off-by: Michael Roth --- trace-events | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/trace-events b/trace-events index fe639ff..26dcea7 100644 --- a/trace-events +++ b/trace-events @@ -556,3 +556,28 @@ qemu_put_sbe32(void *f, int v) "file

[Qemu-devel] [PATCH 02/10] qapi: add QemuFileOutputVisitor

Visitor interface to write values to a QEMUFile. Signed-off-by: Michael Roth --- Makefile.objs | 19 +-- qapi/qemu-file-output-visitor.c | 328 +++ qapi/qemu-file-output-visitor.h | 26 +++ 3 files changed, 363 insertions(+), 10 deletion

[Qemu-devel] [PATCH 03/10] qapi: add QemuFileInputVisitor

Visitor interfaces to read values from a QEMUFile Signed-off-by: Michael Roth --- Makefile.objs |1 + qapi/qemu-file-input-visitor.c | 328 qapi/qemu-file-input-visitor.h | 26 +++ 3 files changed, 355 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 00/10] do savevm/migration save/load via Visitor interface

These patches apply on top of origin/master, and can also be obtained from: git://repo.or.cz/qemu/mdroth.git migration-visitor-v1 OVERVIEW This patch series implements a QEMUFile Visitor class that's intended to abstract away direct calls to qemu_put_*/qemu_get_* for save/load functions. Currentl

[Qemu-devel] [PATCH 16/24] block: switch bdrv_aio_readv() to coroutines

From: Stefan Hajnoczi More sync, aio, and coroutine unification. Make bdrv_aio_readv() go through coroutine request processing. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 48 +++- 1 files changed, 35 insertions(+), 13

[Qemu-devel] [PATCH 17/24] block: mark blocks dirty on coroutine write completion

From: Stefan Hajnoczi The aio write operation marks blocks dirty when the write operation completes. The coroutine write operation marks blocks dirty before issuing the write operation. It seems safest to mark the block dirty when the operation completes so that anything tracking dirty blocks w

[Qemu-devel] [PATCH 18/24] block: switch bdrv_aio_writev() to coroutines

From: Stefan Hajnoczi More sync, aio, and coroutine unification. Make bdrv_aio_writev() go through coroutine request processing. Remove the dirty block callback mechanism which was needed only for aio processing and can be done more naturally in coroutine context. Signed-off-by: Stefan Hajnocz

[Qemu-devel] [PATCH 3/5] runstate: Allow to transition from paused to postmigrate

The user may already have paused the VM before starting the migration process. If s/he does that, then the state will be 'paused' when we finish the migration process. In that case we want to transition from 'paused' to 'postmigrate' as the latter is now the real reason why the VM is stopped. Sign

[Qemu-devel] [PATCH 06/24] scsi: Support I/O status

From: Luiz Capitulino Signed-off-by: Luiz Capitulino Reviewed-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/scsi-disk.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 4f681ef..6909578 100644 --- a/hw/scsi-disk.c +++ b/h

[Qemu-devel] [PATCH] net: tap-linux: Fix unhelpful error message

I'm getting: could not configure /dev/net/tun (tap%d): Operation not permitted When the ioctl() fails, ifr.ifr_name will most likely not be overwritten. So we better only use it when ifname contains a string. Signed-off-by: Luiz Capitulino --- PS: Trivial tree candidate. net/tap-linux.c

[Qemu-devel] [PATCH 14/24] block: split out bdrv_co_do_readv() and bdrv_co_do_writev()

From: Stefan Hajnoczi The public interface for I/O in coroutine context is bdrv_co_readv() and bdrv_co_writev(). Split out the request processing code into bdrv_co_do_readv() and bdrv_co_writev() so that it can be called internally when we refactor all request processing to use coroutines. Sign

[Qemu-devel] [PATCH 15/24] block: switch bdrv_read()/bdrv_write() to coroutines

From: Stefan Hajnoczi The bdrv_read()/bdrv_write() functions call .bdrv_read()/.bdrv_write(). They should go through bdrv_co_do_readv() and bdrv_co_do_writev() instead in order to unify request processing code across sync, aio, and coroutine interfaces. This is also an important step towards rem

[Qemu-devel] [PATCH 05/24] ide: Support I/O status

From: Luiz Capitulino Signed-off-by: Luiz Capitulino Reviewed-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/core.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index b71a356..fbc0859 100644 --- a/hw/ide/core.c +++ b/hw/id

[Qemu-devel] [PATCH 13/24] block: directly invoke .bdrv_* from emulation functions

From: Stefan Hajnoczi The emulation functions which supply default BlockDriver .bdrv_*() functions given another implemented .bdrv_*() function should not use public bdrv_*() interfaces. This patch ensures they invoke .bdrv_*() directly to avoid adding an extra layer of coroutine request process

[Qemu-devel] [PATCH 12/24] block: directly invoke .bdrv_aio_*() in bdrv_co_io_em()

From: Stefan Hajnoczi We will unify block layer request processing across sync, aio, and coroutines and this means a .bdrv_co_*() emulation function should not call back into the public interface. There's no need here, just call .bdrv_aio_*() directly. The gory details: bdrv_co_io_em() cannot c

Re: [Qemu-devel] [PULL 00/24] Block patches

On 10/14/2011 11:48 AM, Kevin Wolf wrote: The following changes since commit ebffe2afceb1a17b5d134b5debf553955fe5ea1a: Merge remote-tracking branch 'qmp/queue/qmp' into staging (2011-10-10 08:21:46 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthon

[Qemu-devel] [PATCH 21/24] raw-posix: remove bdrv_read()/bdrv_write()

From: Stefan Hajnoczi Block drivers only need to provide one of sync, aio, or coroutine interfaces. Since raw-posix.c provides aio interfaces, simply drop the synchronous interfaces since they can be emulated using aio and coroutines. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf -

[Qemu-devel] [PATCH 03/24] block: Keep track of devices' I/O status

From: Luiz Capitulino This commit adds support to the BlockDriverState type to keep track of devices' I/O status. There are three possible status: BDRV_IOS_OK (no error), BDRV_IOS_ENOSPC (no space error) and BDRV_IOS_FAILED (any other error). The distinction between no space and other errors is

[Qemu-devel] [PATCH 11/24] vvfat: Fix potential buffer overflow

path2[PATH_MAX] can be used for the null termination, so make the array big enough to allow this. Signed-off-by: Kevin Wolf --- block/vvfat.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index ba207e2..7e9e35a 100644 --- a/block/vvfat.c

[Qemu-devel] [PATCH 01/24] block: allow resizing of images residing on host devices

From: Christoph Hellwig Allow to resize images that reside on host devices up to the available space. This allows to grow images after resizing the device manually or vice versa. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- block/raw-posix.c | 24 +---

[Qemu-devel] [PATCH 23/24] block: drop .bdrv_read()/.bdrv_write() emulation

From: Stefan Hajnoczi There is no need to emulate .bdrv_read()/.bdrv_write() since these interfaces are only called if aio and coroutine interfaces are not present. All valid BlockDrivers must implement either sync, aio, or coroutine interfaces. Signed-off-by: Stefan Hajnoczi Signed-off-by: Ke

Re: [Qemu-devel] [PATCH] compatfd.c: Don't pass NULL pointer to SYS_signalfd

On 14 October 2011 18:20, Stefan Weil wrote: > Am 13.10.2011 19:45, schrieb Peter Maydell: >> >> Don't pass a NULL pointer in to SYS_signalfd in qemu_signalfd_available(): >> this isn't valid and Valgrind complains about it. >> >> Signed-off-by: Peter Maydell >> --- >> compatfd.c | 12 ++-

[Qemu-devel] [PATCH 22/24] block: use coroutine interface for raw format

From: Stefan Hajnoczi The raw format delegates all operations to bs->file (the protocol). Previously this block driver exposed both sync and aio interfaces. Since the block layer now works in terms of coroutines, expose the coroutine interfaces and drop the others. This avoids unnecessary emulat

[Qemu-devel] [PATCH 04/24] virtio: Support I/O status

From: Luiz Capitulino Signed-off-by: Luiz Capitulino Reviewed-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/virtio-blk.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 03878bf..2a5d1a9 100644 --- a/hw/virtio-blk.c +++

[Qemu-devel] [PATCH 5/5] runstate: Allow user to migrate twice

It should be a matter of allowing the transition POSTMIGRATE -> FINISH_MIGRATE, but it turns out that the VM won't do the transition the second time because it's already stopped. So this commit also adds vm_stop_force_state() which performs the transition even if the VM is already stopped. While

[Qemu-devel] [PATCH 2/5] runstate: Print state transition when invalid

Makes it easier to debug. Signed-off-by: Luiz Capitulino --- vl.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index dbf7778..6645720 100644 --- a/vl.c +++ b/vl.c @@ -397,7 +397,9 @@ void runstate_set(RunState new_state) { if (new_state >= RUN_STA

[Qemu-devel] [PATCH 1/5] QMP: Fix blockdev-snapshot-sync doc example

Fix wrong command name. Reported-by: Eric Blake Signed-off-by: Luiz Capitulino --- qmp-commands.hx |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index ea96191..9edb3b9 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -710,

[Qemu-devel] [PULL 0/5]: QMP queue

Most of the patches are runstate fixes and have been sent to the list already. The changes (since 210b3a70383b0bcc4266856431491b39dcb4f14d) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git qmp/queue Luiz Capitulino (5): QMP: Fix blockdev-snapshot-sync d

[Qemu-devel] [PATCH 24/24] block: drop bdrv_has_async_rw()

From: Stefan Hajnoczi Commit cd74d83345e0e3b708330ab8c4cd9111bb82cda6 ("block: switch bdrv_read()/bdrv_write() to coroutines") removed the bdrv_has_async_rw() callers. This patch removes bdrv_has_async_rw() since it is no longer used. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf -

Re: [Qemu-devel] [PATCH] compatfd.c: Don't pass NULL pointer to SYS_signalfd

Am 13.10.2011 19:45, schrieb Peter Maydell: Don't pass a NULL pointer in to SYS_signalfd in qemu_signalfd_available(): this isn't valid and Valgrind complains about it. Signed-off-by: Peter Maydell --- compatfd.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PATCH 10/24] block/vvfat: Remove unused code

From: Stefan Weil The unused code was detected using cppcheck. Cc: Kevin Wolf Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf --- block/vvfat.c | 56 1 files changed, 0 insertions(+), 56 deletions(-) diff --git a/block/vvfat.c

[Qemu-devel] [PATCH 08/24] HMP: Print 'io-status' information

From: Luiz Capitulino Signed-off-by: Luiz Capitulino Reviewed-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 40621b1..25b03dd 100644 --- a/block.c +++ b/block.c @@ -1868,6 +1868,1

[Qemu-devel] [PATCH 20/24] block: drop emulation functions that use coroutines

From: Stefan Hajnoczi Block drivers that implement coroutine functions used to get sync and aio wrappers. This is no longer necessary since all request processing now happens in a coroutine. If a block driver implements the coroutine interface then none of the other interfaces will be invoked.

Re: [Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

On Fri, Oct 14, 2011 at 7:04 PM, Paul Brook wrote: >> Fixes two trivial indices errors. > > No. > > You're doing two much in a single patch. While both happen to be bug in the > save/restore code involving arrays, these are not two instances of the same > bug.  The justification for each change is

[Qemu-devel] [PATCH 19/24] linux-aio: Allow reads beyond the end of growable images

This is the linux-aio version of commits 22afa7b5 (raw-posix, synchronous) and ba1d1afd (posix-aio-compat). Reads now produce zeros after the end of file instead of failing or resulting in short reads, making linux-aio compatible with the behaviour of synchronous raw-posix requests and posix-aio-co

[Qemu-devel] [PATCH 02/24] linux-aio: Fix laio_submit error handling

The error handling order was in the wrong order, so that either the ACB would be leaked or the counter would be decremented when it shouldn't. Signed-off-by: Kevin Wolf --- linux-aio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-aio.c b/linux-aio.c index bff

[Qemu-devel] [PULL 00/24] Block patches

The following changes since commit ebffe2afceb1a17b5d134b5debf553955fe5ea1a: Merge remote-tracking branch 'qmp/queue/qmp' into staging (2011-10-10 08:21:46 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Christoph Hellwig (1): block: allow r

Re: [Qemu-devel] [PULL 0/7] Trivial patches for October 6 to 14 2011

On 10/14/2011 09:11 AM, Stefan Hajnoczi wrote: The following changes since commit ebffe2afceb1a17b5d134b5debf553955fe5ea1a: Merge remote-tracking branch 'qmp/queue/qmp' into staging (2011-10-10 08:21:46 -0500) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanh

Re: [Qemu-devel] [PATCH] rtl8139: check the buffer availiability

See my comments below. Am 14.10.2011 12:49, schrieb Jason Wang: Reduce spurious packet drops on RX ring empty when in c+ mode by verifying that we have at least 1 buffer ahead of the time. Signed-off-by: Jason Wang --- hw/rtl8139.c | 43 +-- 1 files

Re: [Qemu-devel] [PULL] usb patch queue

On 10/13/2011 06:08 AM, Gerd Hoffmann wrote: Hi, Here comes the usb patch queue with a bunch of bug fixes. Check the individual patches for details. please pull, Gerd Pulled. Thanks. Regards, Anthony Liguori The following changes since commit ebffe2afceb1a17b5d134b5debf553955fe5ea

Re: [Qemu-devel] [PULL 00/24] Memory API, batch 11

On 10/11/2011 08:58 AM, Avi Kivity wrote: On 10/11/2011 03:51 PM, Avi Kivity wrote: For some reason I'm the only one that doesn't get this... will try to work around it. Please re-pull - I changed the code to use plain structs, not the typedefs. git://github.com/avikivity/qemu.git memory/bat

[Qemu-devel] [PATCHv3] ps2: migrate ledstate

Make the ps2 device track its ledstate so that we can migrate it. Otherwise it gets lost across migration, and spice-server gets confused about the actual keyboard state and sends bogus caps/scroll/num key events. This fixes RH bug #729294 Signed-off-by: Christophe Fergeau --- v3: use VMSTATE_UI

[Qemu-devel] test

I am testing this mailing list

Re: [Qemu-devel] [PATCH v3 03/15] add qemu_send_full and qemu_recv_full

On 10/14/2011 12:16 PM, Paolo Bonzini wrote: On 10/14/2011 11:52 AM, Kevin Wolf wrote: Am 05.10.2011 09:17, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzini --- osdep.c | 67 + qemu-common.h | 4 +++ 2 files changed, 71 insertions(+), 0 d

Re: [Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

> Fixes two trivial indices errors. No. You're doing two much in a single patch. While both happen to be bug in the save/restore code involving arrays, these are not two instances of the same bug. The justification for each change is completely different. Even if each change was obviously cor

Re: [Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

Am 14.10.2011 15:25, schrieb Dmitry Koshelev: > Fixes two trivial indices errors. > > Signed-off-by: Dmitry Koshelev > --- > hw/arm_gic.c | 12 ++-- > target-arm/machine.c |4 ++-- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/hw/arm_gic.c b/hw/arm_gi

Re: [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support

On 10/14/2011 04:32 PM, Kevin Wolf wrote: > I can certainly drop aio_discard from the backends, but I'm not sure how > heavy can fallocate be (with FALLOC_FL_PUNCH_HOLE). Probably not much, > but I think there's no guarantee of O(1) behavior especially with > filesystems like ecryptfs. So y

Re: [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support

Am 14.10.2011 16:24, schrieb Paolo Bonzini: > On 10/14/2011 04:23 PM, Kevin Wolf wrote: >>> This similarly adds support for coroutine and asynchronous discard. >>> >>> Signed-off-by: Paolo Bonzini >> >> Do we really need bdrv_discard and bdrv_aio_discard in the backends? I >> think it makes sense

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

On 10/14/2011 04:24 PM, Luiz Capitulino wrote: Yes, you're right. But there's another problem there: the VM is stopped when the migration process finishes. So, if you migrate again, there won't be a POST_MIGRATE -> FINISH_MIGRATE transition, as vm_stop() will just return. Acked-by: Paolo Bonzi

Re: [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support

On 10/14/2011 04:23 PM, Kevin Wolf wrote: > This similarly adds support for coroutine and asynchronous discard. > > Signed-off-by: Paolo Bonzini Do we really need bdrv_discard and bdrv_aio_discard in the backends? I think it makes sense to have a bdrv_aio_discard() in block.h as AIO generally

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

On Fri, 14 Oct 2011 15:37:29 +0200 Paolo Bonzini wrote: > On 10/14/2011 03:23 PM, Luiz Capitulino wrote: > > I'm not, because I'm assuming that allowing a transition from 'paused' to > > 'postmigrate' plus this fix: > > > > http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg01430.html > >

Re: [Qemu-devel] [PATCH 1/2] spice: turn client_migrate_info to async

On 09/21/11 17:50, Yonit Halperin wrote: RHBZ 737921 Spice client is required to connect to the migration target before/as migration starts. Since after migration starts, the target qemu is blocked and cannot accept new spice client we trigger the connection to the target upon client_migrate_inf

Re: [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support

Am 14.10.2011 10:41, schrieb Paolo Bonzini: > This similarly adds support for coroutine and asynchronous discard. > > Signed-off-by: Paolo Bonzini Do we really need bdrv_discard and bdrv_aio_discard in the backends? I think it makes sense to have a bdrv_aio_discard() in block.h as AIO generally

[Qemu-devel] [PATCH 2/7] qemu-char: Fix use of free() instead of g_free()

From: Stefan Weil cppcheck reported these errors: qemu-char.c:1667: error: Mismatching allocation and deallocation: s qemu-char.c:1668: error: Mismatching allocation and deallocation: chr qemu-char.c:1769: error: Mismatching allocation and deallocation: s qemu-char.c:1770: error: Mismatching all

[Qemu-devel] [PATCH 1/7] qemu-options: avoid #if in spicevmc texi help

Preprocessor directives cannot be used in STEXI/ETEXI sections since they are not passed through the preprocessor. The spicevmc chardev option help currently uses #if, which is included verbatim in the man page output. Fix this by simply stating that spicevmc chardevs are available only in builds

[Qemu-devel] [PATCH 7/7] block/qcow: Fix use of free() instead of g_free()

From: Stefan Weil cppcheck reported this error: qemu/block/qcow.c:599: error: Mismatching allocation and deallocation: cluster_data Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- block/qcow.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/qcow

[Qemu-devel] [PATCH 4/7] remove hpet.h

From: Paolo Bonzini It is unused since the HPET and RTC timers were removed (commit 25f3151, 2011-05-31). Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- hpet.h | 22 -- 1 files changed, 0 insertions(+), 22 deletions(-) delete mode 100644 hpet.h diff --

[Qemu-devel] [PATCH 5/7] tcg: Fix spelling in comment (varables -> variables)

From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- tcg/tcg.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index de8a1d5..015f88a 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -175,7 +175,7 @@ typedef enum TCGType {

[Qemu-devel] [PULL 0/7] Trivial patches for October 6 to 14 2011

The following changes since commit ebffe2afceb1a17b5d134b5debf553955fe5ea1a: Merge remote-tracking branch 'qmp/queue/qmp' into staging (2011-10-10 08:21:46 -0500) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-patches Andreas Färber (1): ar

[Qemu-devel] [PATCH 3/7] arm_pic: Fix typo

From: Andreas Färber interrput -> interrupt Cc: Paul Brook Signed-off-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- hw/arm_pic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/arm_pic.c b/hw/arm_pic.c index 985148a..41f8d3e 100644 --- a/hw/arm_pic.c +++

[Qemu-devel] [PATCH 6/7] sheepdog: correct spelling

From: Dong Xu Wang Reviewed-by: Andreas Färber Signed-off-by: Dong Xu Wang Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index c1f6e07..ae857e2 100644 --- a/block/sheepdog.c +++

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

On 10/14/2011 04:02 PM, Kevin Wolf wrote: > > It would still host the checks on BDRV_O_NO_FLUSH and bs->drv->*_flush. > It would be the same as bdrv_flush_co_entry is now, minus the > marshalling in/out of the RwCo. Right. By the way, I like how you handle all three backends in the same f

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

Am 14.10.2011 14:42, schrieb Paolo Bonzini: > On 10/14/2011 01:54 PM, Kevin Wolf wrote: >> Am 14.10.2011 13:30, schrieb Paolo Bonzini: >>> On 10/14/2011 01:08 PM, Kevin Wolf wrote: Am 14.10.2011 10:41, schrieb Paolo Bonzini: > Add coroutine support for flush and apply the same emulation th

Re: [Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

On Fri, Oct 14, 2011 at 05:25:29PM +0400, Dmitry Koshelev wrote: > Fixes two trivial indices errors. > > Signed-off-by: Dmitry Koshelev > --- > hw/arm_gic.c | 12 ++-- > target-arm/machine.c |4 ++-- > 2 files changed, 8 insertions(+), 8 deletions(-) Not obvious to me what

Re: [Qemu-devel] [v7 Patch 5/5]Qemu: New struct 'BDRVReopenState' for image files reopen

Am 14.10.2011 15:42, schrieb Supriya Kannery: >>> +/* Use driver specific reopen() if available */ >>> +if (drv->bdrv_reopen_prepare) { >>> +ret = drv->bdrv_reopen_prepare(bs,&rs, bdrv_flags); >>> if (ret< 0) { >>> -/* Reopen failed with orig and modified flag

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

On 10/14/2011 03:20 PM, Stefan Hajnoczi wrote: It's just too tempting to call these functions in contexts where it is not okay to do so. The bdrv_co_*() functions are all tagged as coroutine_fn and make it clear that they can yield. Yes, I agree. We already have an event loop in qemu-img exc

Re: [Qemu-devel] [v7 Patch 5/5]Qemu: New struct 'BDRVReopenState' for image files reopen

On 10/14/2011 04:43 PM, Stefan Hajnoczi wrote: On Tue, Oct 11, 2011 at 08:41:59AM +0530, Supriya Kannery wrote: Index: qemu/block.c === --- qemu.orig/block.c +++ qemu/block.c @@ -706,6 +706,7 @@ int bdrv_reopen(BlockDriverState *bs,

Re: [Qemu-devel] [v7 Patch 5/5]Qemu: New struct 'BDRVReopenState' for image files reopen

On 10/12/2011 08:25 PM, Kevin Wolf wrote: Am 11.10.2011 05:11, schrieb Supriya Kannery: Struct BDRVReopenState introduced for handling reopen state of images. This can be extended by each of the block drivers to reopen respective image files. Implementation for raw-posix is done here. Signed-o

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

On 10/14/2011 03:23 PM, Luiz Capitulino wrote: I'm not, because I'm assuming that allowing a transition from 'paused' to 'postmigrate' plus this fix: http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg01430.html I think POST_MIGRATE -> FINISH_MIGRATE should be still allowed in case you

[Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

Fixes two trivial indices errors. Signed-off-by: Dmitry Koshelev --- hw/arm_gic.c | 12 ++-- target-arm/machine.c |4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index 8286a28..ba05131 100644 --- a/hw/arm_gic.c +++ b/hw/ar

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

On Fri, 14 Oct 2011 08:56:57 +0200 Paolo Bonzini wrote: > On 10/13/2011 10:26 PM, Luiz Capitulino wrote: > > I'm going to take my word back on this one, I've found the real cause of the > > problem. Will post the patch right now. > > > > Are you keeping the vl.c hunks though? I'm not, because I

Re: [Qemu-devel] [PATCH] ui/spice-core: fix segfault in monitor

On 10/04/11 13:25, Alon Levy wrote: Fix segfault if a qxl device is present but no spice command line argument is given. RHBZ 743251. Added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

On Fri, Oct 14, 2011 at 01:54:42PM +0200, Kevin Wolf wrote: > Am 14.10.2011 13:30, schrieb Paolo Bonzini: > > On 10/14/2011 01:08 PM, Kevin Wolf wrote: > >> Am 14.10.2011 10:41, schrieb Paolo Bonzini: > > Let me show how this might go. Right now you have > > > > bdrv_read/write > >

Re: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

On 14 October 2011 13:55, Paolo Bonzini wrote: > On 10/14/2011 02:47 PM, Paolo Bonzini wrote: >> >> A user-space longjmp will always be slower than a mutex+condvar+context >> switch. > > Gah, I obviously meant faster. :) Ah, I hadn't actually looked at the coroutine-gthread.c code, and had assume

Re: [Qemu-devel] [PATCH] qxl: create slots on post_load in any state (fix RHBZ 740547)

On 09/22/11 14:33, Alon Levy wrote: If we migrate when the device is not in a native state the guest still believes the slots are created, and will cause operations that reference the slots, causing a "panic: virtual address out of range" on the first of them. Easy to see by migrating in vga mode

Re: [Qemu-devel] [PATCH 0/2] spice migration interface (RHBZ 737921)

Hi, Yonit Halperin (2): spice: turn client_migrate_info to async spice: support the new migration interface (spice 0.8.3) Added to spice patch queue. thanks, Gerd

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

The existing code looks OK to me -- there's no need to call gen_set_CF_bit31() early because the inputs t0 and t1 to gen_thumb2_data_op() should always be distinct TCG values, and so gen_thumb2_data_op() will never trash t1. (There was a bug in this area involving ORN, but that was fixed in rev 295

Re: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

On 10/14/2011 02:47 PM, Paolo Bonzini wrote: A user-space longjmp will always be slower than a mutex+condvar+context switch. Gah, I obviously meant faster. :) Paolo

Re: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

On 10/14/2011 02:30 PM, Peter Maydell wrote: I've also just discovered that it's no use on Oneiric, where the linker warning has gone away but the syscall still always returns ENOSYS. I think we should just always use the gthread implementation rather than preferring a non-portable-and-hard-to-d

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

On 10/14/2011 01:54 PM, Kevin Wolf wrote: Am 14.10.2011 13:30, schrieb Paolo Bonzini: On 10/14/2011 01:08 PM, Kevin Wolf wrote: Am 14.10.2011 10:41, schrieb Paolo Bonzini: Add coroutine support for flush and apply the same emulation that we already do for read/write. bdrv_aio_flush is simplif

Re: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

On 13 October 2011 23:23, Andreas Färber wrote: > Am 13.10.2011 16:26, schrieb Andreas Färber: >> Am 12.10.2011 18:21, schrieb Peter Maydell: >>> Improve the configure test for presence of ucontext functions by >>> making linker warnings fatal; this allows us to detect when we are >>> linked with

Re: [Qemu-devel] [PATCH 0/6] trace: Add support for trace events grouping

On Thu, Oct 13, 2011 at 04:10:56PM +0800, Mark Wu wrote: > On 10/13/2011 01:14 AM, Mark Wu wrote: > >This series add support for trace events grouping. The state of a given group > >of trace events can be queried or changed in bulk by the following monitor > >commands: > > > >* info trace-groups >

Re: [Qemu-devel] [PATCH 1/1 V5 tuning] kernel/kvm: introduce KVM_SET_LINT1 and fix improper nmi emulation

On 2011-10-14 13:59, Sasha Levin wrote: > On Fri, 2011-10-14 at 17:51 +0800, Lai Jiangshan wrote: >> Currently, NMI interrupt is blindly sent to all the vCPUs when NMI >> button event happens. This doesn't properly emulate real hardware on >> which NMI button event triggers LINT1. Because of this,

[Qemu-devel] [PATCH] hw/9pfs: Handle Security model parsing

Except local fs driver other fs drivers (handle) don't need security model. Update fsdev parameter parsing accordingly. Signed-off-by: M. Mohan Kumar --- fsdev/qemu-fsdev.c | 26 +- qemu-options.hx| 12 vl.c |6 ++ 3 files change

Re: [Qemu-devel] [PATCH 1/1 V5 tuning] kernel/kvm: introduce KVM_SET_LINT1 and fix improper nmi emulation

On Fri, 2011-10-14 at 17:51 +0800, Lai Jiangshan wrote: > Currently, NMI interrupt is blindly sent to all the vCPUs when NMI > button event happens. This doesn't properly emulate real hardware on > which NMI button event triggers LINT1. Because of this, NMI is sent to > the processor even when LINT

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

Am 14.10.2011 13:30, schrieb Paolo Bonzini: > On 10/14/2011 01:08 PM, Kevin Wolf wrote: >> Am 14.10.2011 10:41, schrieb Paolo Bonzini: >>> Add coroutine support for flush and apply the same emulation that >>> we already do for read/write. bdrv_aio_flush is simplified to always >>> go through a cor

Re: [Qemu-devel] [PATCH 2/2] hda: do not mix output and input stream states, RHBZ #740493

Hi, a) My understanding of this patch is that we move from an array of 16 bools representing anything to one array where the 1st 16 represent if there are input and the 2nd 16's reprosenting if there are output for that channel. Correct. So, what we should do if we migrate from one old ver

Re: [Qemu-devel] website

> http://wiki.qemu.org/Main_Page > > Someone may want to have a look over the website, the links in the > "Contribute" section in the column on the left. > All pages seem to primarily discuss the quality of Pandora jewelry and > how beneficial it would be to purchase such. Jcmvbkbc and I have r

  1   2   >