Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset

2011-09-30 Thread Jan Kiszka
On 2011-09-30 22:47, Blue Swirl wrote: > That part of the discussion is obsolete (or at least uninteresting > here). For example this message has a relevant example: > http://lists.nongnu.org/archive/html/qemu-devel/2009-06/msg01081.html > > It's about VM restore, but the situation is similar duri

Re: [Qemu-devel] [PATCH V3] Add stdio char device on windows

2011-09-30 Thread Blue Swirl
On Wed, Sep 28, 2011 at 4:28 PM, Fabien Chouteau wrote: > Simple implementation of an stdio char device on Windows. > > Signed-off-by: Fabien Chouteau > --- >  qemu-char.c |  216 > ++- >  1 files changed, 214 insertions(+), 2 deletions(-) >

[Qemu-devel] buildbot failure in qemu on default_mingw32

2011-09-30 Thread qemu
The Buildbot has detected a new failure on builder default_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/41 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason:

[Qemu-devel] buildbot failure in qemu on default_x86_64_rhel61

2011-09-30 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/41 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Bu

[Qemu-devel] buildbot failure in qemu on default_x86_64_fedora16

2011-09-30 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_fedora16 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_fedora16/builds/41 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_fedora

[Qemu-devel] buildbot failure in qemu on default_openbsd_4.9

2011-09-30 Thread qemu
The Buildbot has detected a new failure on builder default_openbsd_4.9 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_openbsd_4.9/builds/41 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_openbsd49 Bui

[Qemu-devel] buildbot failure in qemu on default_i386_rhel61

2011-09-30 Thread qemu
The Buildbot has detected a new failure on builder default_i386_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_rhel61/builds/40 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61_32bit

[Qemu-devel] [PATCH 08/26] qapi: add test cases for generated free functions

2011-09-30 Thread Luiz Capitulino
From: Michael Roth Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- test-qmp-commands.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/test-qmp-commands.c b/test-qmp-commands.c index f142cc6..fa5a7bd 100644 --- a/test-qmp-com

[Qemu-devel] [PATCH 12/26] qapi: Automatically generate a _MAX value for enums

2011-09-30 Thread Luiz Capitulino
It's the last value in the enum and is very useful for the C implementation. Signed-off-by: Luiz Capitulino --- scripts/qapi-types.py |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 3bacc0c..f64d84c 100644 --- a/scr

[Qemu-devel] [PATCH 02/26] qerror: add qerror_report_err()

2011-09-30 Thread Luiz Capitulino
From: Anthony Liguori This provides a bridge between Error (new error mechanism) and QError (old error mechanism). Errors can be propagated whereas QError cannot. The minor evilness avoids layering violations. Since QError should go away RSN, it seems like a reasonable hack. Signed-off-by: An

[Qemu-devel] [PATCH 22/26] qapi: Convert query-commands

2011-09-30 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c| 40 +++- qapi-schema.json | 23 +++ qmp-commands.hx |6 ++ 3 files changed, 44 insertions(+), 25 deletions(-) diff --git a/monitor.c b/monitor.c index ecf8db3..11363d5 10064

[Qemu-devel] [PATCH 24/26] qapi: Convert stop

2011-09-30 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c|5 + hmp.h|1 + monitor.c|9 - qapi-schema.json | 12 qmp-commands.hx |5 + qmp.c|5 + 7 files

[Qemu-devel] [PATCH 19/26] qapi: Convert query-status

2011-09-30 Thread Luiz Capitulino
Please, note that the RunState type as defined in sysemu.h and its runstate_as_string() function are being dropped in favor of the RunState type generated by the QAPI. Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp.c| 19 +++ hmp.h|

[Qemu-devel] [PATCH 25/26] qapi: Convert system_reset

2011-09-30 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c|5 + hmp.h|1 + monitor.c| 10 -- qapi-schema.json |9 + qmp-commands.hx |5 + qmp.c|4 7 files cha

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-30 Thread Alex Williamson
On Fri, 2011-09-30 at 10:37 -0600, Alex Williamson wrote: > On Fri, 2011-09-30 at 18:46 +1000, David Gibson wrote: > > On Mon, Sep 26, 2011 at 12:34:52PM -0600, Alex Williamson wrote: > > > On Mon, 2011-09-26 at 12:04 +0200, Alexander Graf wrote: > > > > Am 26.09.2011 um 09:51 schrieb David Gibson

[Qemu-devel] [PATCH 09/26] qapi: dealloc visitor, support freeing of nested lists

2011-09-30 Thread Luiz Capitulino
From: Michael Roth Previously our logic for keeping track of when we're visiting the head of a list was done via a global bool. This can be overwritten if dealing with nested lists, so use stack entries to track this instead. Reviewed-by: Anthony Liguori Signed-off-by: Michael Roth Signed-off-

[Qemu-devel] [PATCH 01/26] error: let error_is_type take a NULL error

2011-09-30 Thread Luiz Capitulino
From: Anthony Liguori Reported-by: Luiz Capitulino Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- error.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/error.c b/error.c index b802752..68c0039 100644 --- a/error.c +++ b/error.c @@ -97,6 +97,10

[Qemu-devel] [PATCH] etrax: Fix wrong conditional statement

2011-09-30 Thread Stefan Weil
cppcheck reports an error: the conditional statement is always true. I assume that the register should be masked with 3, but could not test the code. Please test before applying this patch. Cc: Edgar E. Iglesias Signed-off-by: Stefan Weil --- hw/etraxfs_dma.c |4 ++-- 1 files changed, 2 i

[Qemu-devel] [PATCH 17/26] RunState: Drop the RSTATE_NO_STATE value

2011-09-30 Thread Luiz Capitulino
The QAPI framework won't generate it, so we need to get rid of it. In order to do that, this commit makes RSTATE_PRE_LAUNCH the initial state and change qemu_vmstop_requested() to use RSTATE_MAX. Signed-off-by: Luiz Capitulino --- sysemu.h |1 - vl.c | 19 +++ 2 files

[Qemu-devel] [PATCH 21/26] qapi: Convert query-chardev

2011-09-30 Thread Luiz Capitulino
Reviewed-by: Michael Roth Tested-by: Michael Roth Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp.c| 13 + hmp.h|1 + monitor.c| 11 +-- qapi-schema.json | 26 ++ qemu-char.c | 35

[Qemu-devel] [PATCH 14/26] qapi: Convert query-version

2011-09-30 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp.c| 13 + hmp.h|1 + monitor.c| 46 +++--- qapi-schema.json | 37 + qmp-commands.hx |6 +

[Qemu-devel] [PATCH 20/26] qapi: Convert query-uuid

2011-09-30 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp.c|8 hmp.h|1 + monitor.c| 28 +--- qapi-schema.json | 24 qmp-commands.hx |6 ++ qmp.c| 15 +

[Qemu-devel] [PATCH 23/26] qapi: Convert quit

2011-09-30 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |2 +- hmp.c|6 ++ hmp.h|1 + monitor.c| 12 qapi-schema.json | 11 +++ qmp-commands.hx |5 + qmp.c|6 ++ 7 fil

[Qemu-devel] [PATCH] block/vvfat: Fix potential memory leaks and other memory errors

2011-09-30 Thread Stefan Weil
cppcheck reported memory leaks and mismatched g_malloc() with free() instead of g_free(). Fix these errors. Cc: Kevin Wolf Signed-off-by: Stefan Weil --- block/vvfat.c | 51 ++- 1 files changed, 30 insertions(+), 21 deletions(-) diff --git a/b

[Qemu-devel] [PATCH 10/26] qapi: modify visitor code generation for list iteration

2011-09-30 Thread Luiz Capitulino
From: Michael Roth Modify logic such that we never assign values to the list head argument to progress through the list on subsequent iterations, instead rely only on having our return value passed back in as an argument on the next call. Also update QMP I/O visitors and test cases accordingly, a

[Qemu-devel] [PATCH 18/26] RunState: Rename enum values as generated by the QAPI

2011-09-30 Thread Luiz Capitulino
Next commit will convert the query-status command to use the RunState type as generated by the QAPI. In order to "transparently" replace the current enum by the QAPI one, we have to make some changes to some enum values. As the changes are simple renames, I'll do them in one shot. The changes are

[Qemu-devel] [PATCH 03/26] qapi: add code generation support for middle mode

2011-09-30 Thread Luiz Capitulino
From: Anthony Liguori To get the ball rolling merging QAPI, this patch introduces a "middle mode" to the code generator. In middle mode, the code generator generates marshalling functions that are compatible with the current QMP server. We absolutely need to replace the current QMP server in or

[Qemu-devel] [PATCH 16/26] vl: Change qemu_vmstop_requested() to return a bool

2011-09-30 Thread Luiz Capitulino
The stop reason is returned in the RunState argument. This is a preparation for a future commit which will convert the query-status command to the QAPI. Signed-off-by: Luiz Capitulino --- vl.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/vl.c b/vl.c in

[Qemu-devel] [PATCH 06/26] qapi: dealloc visitor, fix premature free and iteration logic

2011-09-30 Thread Luiz Capitulino
From: Michael Roth Currently we do 3 things wrong: 1) The list iterator, in practice, is used in a manner where the pointer we pass in is the same as the pointer we assign the output to from visit_next_list(). This causes an infinite loop where we keep freeing the same structures. 2) We attempt

[Qemu-devel] [PATCH 04/26] qapi: use middle mode in QMP server

2011-09-30 Thread Luiz Capitulino
From: Anthony Liguori Use the new middle mode within the existing QMP server. Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- Makefile | 12 Makefile.objs|2 ++ Makefile.target |6 +++--- monitor.c|9 - qapi-schema.json

[Qemu-devel] [PATCH 15/26] qapi: Convert query-kvm

2011-09-30 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp.c| 16 hmp.h|1 + monitor.c| 36 +--- qapi-schema.json | 25 + qmp-commands.hx |6 ++ qmp.c

[Qemu-devel] [PATCH 13/26] qapi: convert query-name

2011-09-30 Thread Luiz Capitulino
From: Anthony Liguori A simple example conversion 'info name'. This also adds the new files for QMP and HMP. Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- Makefile.objs|1 + hmp.c| 26 ++ hmp.h| 22 ++

Re: [Qemu-devel] [PATCH 4/5] backdoor: [softmmu] Add QEMU-side proxy to "libbackdoor.a"

2011-09-30 Thread Blue Swirl
2011/9/30 Lluís Vilanova : > Blue Swirl writes: > >> 2011/9/29 Lluís Vilanova : >>> Blue Swirl writes: >>> 2011/9/29 Lluís Vilanova : > +static uint64_t control_io_read(void *opaque, target_phys_addr_t addr, > unsigned size) > +{ > +    State *s = opaque; > + > +    ui

[Qemu-devel] [PATCH 26/26] qapi: Convert system_powerdown

2011-09-30 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c|5 + hmp.h|1 + qapi-schema.json | 14 ++ qmp.c|5 + 5 files changed, 26 insertions(+), 2 deletions(-) diff --git a/hmp-comm

Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset

2011-09-30 Thread Blue Swirl
On Fri, Sep 30, 2011 at 9:14 AM, Peter Maydell wrote: > On 30 September 2011 07:47, Jan Kiszka wrote: >> There is no difference between system reset after power-up or later on. >> And there should be no difference between per device, per group of >> devices or system-wide reset. A device model ca

Re: [Qemu-devel] [PATCH 4/5] backdoor: [softmmu] Add QEMU-side proxy to "libbackdoor.a"

2011-09-30 Thread Lluís Vilanova
Blue Swirl writes: > 2011/9/29 Lluís Vilanova : >> Blue Swirl writes: >> >>> 2011/9/29 Lluís Vilanova : +static uint64_t control_io_read(void *opaque, target_phys_addr_t addr, unsigned size) +{ +    State *s = opaque; + +    uint64_t res = ldq_p(&s->size); +  

Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset

2011-09-30 Thread Blue Swirl
On Fri, Sep 30, 2011 at 6:47 AM, Jan Kiszka wrote: > On 2011-09-29 21:45, Blue Swirl wrote: >> On Wed, Sep 28, 2011 at 9:18 PM, Jan Kiszka wrote: >>> On 2011-09-28 20:01, Blue Swirl wrote: On Wed, Sep 28, 2011 at 11:00 AM, Jan Kiszka  wrote: > > As we clearly modify the PIC

[Qemu-devel] [PATCH 11/26] qapi: Don't use c_var() on enum strings

2011-09-30 Thread Luiz Capitulino
Otherwise if we have something like 'foo-bar' in the schema, it will be generated as 'foo_bar' in the string lookup table. c_var() is good for C variables, but not for enum strings. Signed-off-by: Luiz Capitulino --- scripts/qapi-types.py |2 +- 1 files changed, 1 insertions(+), 1 deletions

[Qemu-devel] [PATCH 07/26] qapi: generate qapi_free_* functions for *List types

2011-09-30 Thread Luiz Capitulino
From: Michael Roth Reviewed-by: Anthony Liguori Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- scripts/qapi-types.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index fc0f7af..4797a70 100644 --- a/scri

[Qemu-devel] [PATCH 05/26] qapi: fixup command generation for functions that return list types

2011-09-30 Thread Luiz Capitulino
From: Anthony Liguori Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- scripts/qapi-commands.py | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index 2776804..c947ba4 100644 ---

[Qemu-devel] [PATCH v2 00/26]: First round of QAPI conversions

2011-09-30 Thread Luiz Capitulino
This series is a bundle of three things: 1. Patches 01 to 04 add the middle mode feature to the current QMP server. That mode allows for the current server to support QAPI commands. The Original author is Anthony, you can find his original post here: http://lists.gnu.org/archive/

Re: [Qemu-devel] [PATCH v2 21/22] monitor: Restrict pic/irq_info to supporting targets

2011-09-30 Thread Blue Swirl
On Fri, Sep 30, 2011 at 6:50 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Signed-off-by: Jan Kiszka Acked-by: Blue Swirl > --- > > Changes in v2: >  - keep slavio_intctl local, introduce sun4m_pic/irq_info instead > >  hw/an5206.c             |   10 -- >  hw/arm_pic.c            |   1

Re: [Qemu-devel] [PATCH 4/5] backdoor: [softmmu] Add QEMU-side proxy to "libbackdoor.a"

2011-09-30 Thread Blue Swirl
On Thu, Sep 29, 2011 at 10:35 PM, Frans de Boer wrote: > On 09/29/2011 11:49 PM, Lluís Vilanova wrote: >> >> Blue Swirl writes: >> >>> 2011/9/29 Lluís Vilanova: +static uint64_t control_io_read(void *opaque, target_phys_addr_t addr, unsigned size) +{ +    State *s = opaque

Re: [Qemu-devel] [PATCH 4/5] backdoor: [softmmu] Add QEMU-side proxy to "libbackdoor.a"

2011-09-30 Thread Blue Swirl
2011/9/29 Lluís Vilanova : > Blue Swirl writes: > >> 2011/9/29 Lluís Vilanova : >>> +static uint64_t control_io_read(void *opaque, target_phys_addr_t addr, >>> unsigned size) >>> +{ >>> +    State *s = opaque; >>> + >>> +    uint64_t res = ldq_p(&s->size); >>> +    uint8_t *resb = (uint8_t*)&res;

Re: [Qemu-devel] QEMU Live Snapshots / Commiting

2011-09-30 Thread Robert P
On Fri, Sep 30, 2011 at 4:54 PM, Stefan Hajnoczi wrote: > On Fri, Sep 30, 2011 at 2:46 PM, Robert P wrote: > > > > > > On Fri, Sep 30, 2011 at 2:04 PM, Stefan Hajnoczi > wrote: > >> > >> On Fri, Sep 30, 2011 at 11:32 AM, Robert P wrote: > >> > >> Please use Reply-All to keep qemu-devel CCed so

[Qemu-devel] qcow2 corrupted image, no error from qemu-img check

2011-09-30 Thread nicolas prochazka
Hello, I'm converting some images without problem, but with one i cannot (vm_import) , due to error. ( this image was creating with qemu 0.14.1 and continue to work, windows guest image) So, is it possible to repair this image ? I know my email is more for qemu user list, but qemu-img check tell

Re: [Qemu-devel] [BUG] need to export variables in config.mak

2011-09-30 Thread Chris Friesen
On 09/30/2011 11:52 AM, Richard Henderson wrote: On 09/30/2011 10:07 AM, Chris Friesen wrote: We've been playing a bit with kvm-kmod-3.0b. We use a cross compile environment, and one of my coworkers noticed that the variables in config.mak weren't actually exported and so didn't actually have a

Re: [Qemu-devel] [PATCH 1/3] ppc: Generalize the kvmppc_get_clockfreq() function

2011-09-30 Thread Alexander Graf
Am 30.09.2011 um 09:50 schrieb David Gibson : > Currently the kvmppc_get_clockfreq() function reads the host's clock > frequency from /proc/device-tree, which is useful to past to the guest > in KVM setups. However, there are some other host properties > advertised in the device tree which can a

Re: [Qemu-devel] [BUG] need to export variables in config.mak

2011-09-30 Thread Alexander Graf
Am 30.09.2011 um 19:52 schrieb Richard Henderson : > On 09/30/2011 10:07 AM, Chris Friesen wrote: >> We've been playing a bit with kvm-kmod-3.0b. We use a cross compile >> environment, and one of my coworkers noticed that the variables in >> config.mak weren't actually exported and so didn't act

Re: [Qemu-devel] [BUG] need to export variables in config.mak

2011-09-30 Thread Richard Henderson
On 09/30/2011 10:07 AM, Chris Friesen wrote: > We've been playing a bit with kvm-kmod-3.0b. We use a cross compile > environment, and one of my coworkers noticed that the variables in > config.mak weren't actually exported and so didn't actually have any > effect. Please elaborate on "no effect",

[Qemu-devel] [PATCH] need to export variables in config.mak

2011-09-30 Thread Chris Friesen
The variables being written to config.mak by configure need to be exported in order to take effect when building the package. The following patch fixes this in our environment. Signed-off-by: Chris Friesen Index: kvm-kmod-3.0b/configure =

[Qemu-devel] [PATCH] linux-user: add binfmt wrapper for argv[0] handling

2011-09-30 Thread Alexander Graf
When using qemu's linux-user binaries through binfmt, argv[0] gets lost along the execution because qemu only gets passed in the full file name to the executable while argv[0] can be something completely different. This breaks in some subtile situations, such as the grep and make test suites. Thi

[Qemu-devel] [PATCH 1/6] scsi: move tcq/ndev to SCSIBusOps (now SCSIBusInfo)

2011-09-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/esp.c |7 +-- hw/lsi53c895a.c |9 ++--- hw/scsi-bus.c| 27 --- hw/scsi-disk.c |2 +- hw/scsi.h| 11 +-- hw/spapr_vscsi.c |8 +--- hw/usb-msd.c |7 +-- 7 files cha

[Qemu-devel] [PATCH 2/6] qdev: switch children device list to QTAILQ

2011-09-30 Thread Paolo Bonzini
SCSI buses will need to read the children list first-to-last. This requires using a QTAILQ, because hell breaks loose if you just try inserting at the tail (thus reversing the order of all existing visits from last-to-first to first-to-tail). Signed-off-by: Paolo Bonzini --- hw/acpi_piix4.c

[Qemu-devel] [PATCH 0/6] introduce SCSI channel/target/LUN addressing

2011-09-30 Thread Paolo Bonzini
This patch introduces the possibility to address SCSI devices by channel/target/LUN. New properties are introduced to define the address. The implementation is pretty trivial, and thanks to the ReqOps mechanism does not require introducing dummy devices representing channels and targets. For QEMU

[Qemu-devel] [PATCH 5/6] scsi: allow arbitrary LUNs

2011-09-30 Thread Paolo Bonzini
This only requires changes in two places: in SCSIBus, we need to look for a free LUN if somebody creates a device with a pre-existing scsi-id but the default LUN (-1, meaning "search for a free spot"); in vSCSI, we need to actually parse the LUN according to the SCSI spec. Signed-off-by: Paolo Bon

[Qemu-devel] [PATCH 3/6] scsi: remove devs array from SCSIBus

2011-09-30 Thread Paolo Bonzini
Change the devs array into a linked list, and add a scsi_device_find function to navigate the children list instead. This lets the SCSI bus use more complex addressing. scsi_device_find may return another LUN on the same target if none is found that matches exactly. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [BUG] need to export variables in config.mak

2011-09-30 Thread Jan Kiszka
On 2011-09-30 19:07, Chris Friesen wrote: > We've been playing a bit with kvm-kmod-3.0b. We use a cross compile > environment, and one of my coworkers noticed that the variables in config.mak > weren't actually exported and so didn't actually have any effect. > > I think something like the foll

[Qemu-devel] [PATCH 6/6] scsi: add channel to addressing

2011-09-30 Thread Paolo Bonzini
This also requires little more than adding the new argument to scsi_device_find, and the qdev property. All devices by default end up on channel 0. Signed-off-by: Paolo Bonzini --- hw/esp.c |4 ++-- hw/lsi53c895a.c |4 ++-- hw/scsi-bus.c| 24 +++- hw/s

Re: [Qemu-devel] RFC [v2]: vfio / device assignment -- layout of device fd files

2011-09-30 Thread Alex Williamson
On Fri, 2011-09-30 at 18:46 +1000, David Gibson wrote: > On Mon, Sep 26, 2011 at 12:34:52PM -0600, Alex Williamson wrote: > > On Mon, 2011-09-26 at 12:04 +0200, Alexander Graf wrote: > > > Am 26.09.2011 um 09:51 schrieb David Gibson : > [snip] > > > Also, if you can come up with an interface that d

[Qemu-devel] [PATCH 4/6] scsi: implement REPORT LUNS for arbitrary LUNs

2011-09-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 49 +++-- 1 files changed, 39 insertions(+), 10 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index c0da8c7..17acf48 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -170,7 +170,7 @@ typedef

[Qemu-devel] [BUG] need to export variables in config.mak

2011-09-30 Thread Chris Friesen
We've been playing a bit with kvm-kmod-3.0b. We use a cross compile environment, and one of my coworkers noticed that the variables in config.mak weren't actually exported and so didn't actually have any effect. I think something like the following patch is required. Thanks, Chris Friesen I

[Qemu-devel] git-bisect results (was: Re: qemu.git hangs booting Linux after insmod virtio_blk.ko)

2011-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2011 at 02:11:48PM +0100, Richard W.M. Jones wrote: > > I've not looked into this at all, it's just a report that something > seems to be "up". I will try to git bisect this later if no one spots > anything obvious. > > The next operation after insmod virtio_blk would be insmod_v

[Qemu-devel] [PATCH 3/3] trace: add arguments to bdrv_co_io_em() trace event

2011-09-30 Thread Stefan Hajnoczi
It is useful to know the BlockDriverState as well as the sector_num/nb_sectors of an emulated .bdrv_co_*() request. Signed-off-by: Stefan Hajnoczi --- block.c |2 +- trace-events |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 1ae22d5..e

[Qemu-devel] [PATCH 2/3] trace: trace monitor qmp dispatch/completion

2011-09-30 Thread Stefan Hajnoczi
Add trace events for handle_qmp_command(), which dispatches qmp commands, and monitor_protocol_emitter(), which produces the reply to a qmp command. Also remove duplicate #include "trace/control.h". Signed-off-by: Stefan Hajnoczi --- monitor.c|5 - trace-events |4 2 files

[Qemu-devel] [PATCH 1/3] trace: trace bdrv_open_common()

2011-09-30 Thread Stefan Hajnoczi
bdrv_open_common() is a useful point to trace since it reveals the filename and block driver for a given BlockDriverState. Signed-off-by: Stefan Hajnoczi --- block.c |2 ++ trace-events |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index e3fe

[Qemu-devel] [PATCH 0/3] trace: more trace events for block and qmp

2011-09-30 Thread Stefan Hajnoczi
This series adds new trace events for correlating filenames with BlockDriverState pointers and observing QMP monitor command input. It also expands the bdrv_co_io_em() trace event to provide more useful information. Basically small additions to improve observability in QEMU :). Stefan Hajnoczi (

Re: [Qemu-devel] Correction: Announcing qemu-users - the unofficial mailing list for qemu users (was: Now, what's left to non-developers?

2011-09-30 Thread Ottavio
On 30 September 2011 15:36, wrote: > To: Ottavio > Date: Fri, 30 Sep 2011 22:09:48 +0800 > Subject: Re: [Qemu-devel] Correction: Announcing qemu-users - the unofficial > mailing list for qemu users (was: Now, what's left to non-developers? ... ) > Hi, Ottavio > >  Would you like to put http://t

Re: [Qemu-devel] [PATCH 4/5] softfloat: Implement fused multiply-add

2011-09-30 Thread Peter Maydell
On 30 September 2011 16:28, Richard Henderson wrote: > On 09/28/2011 10:27 AM, Peter Maydell wrote: >>  /* >> +| Select which NaN to propagate for a three-input operation. >> +| For the moment we assume that no CPU needs t

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-09-30 Thread Amit Shah
On (Fri) 30 Sep 2011 [16:23:30], Stefan Hajnoczi wrote: > On Fri, Sep 30, 2011 at 12:27 PM, Amit Shah wrote: > > On (Fri) 30 Sep 2011 [11:39:11], Stefan Hajnoczi wrote: > >> QED's metadata caching strategy allows two parallel requests to race for > >> metadata lookup.  The first one to complete wi

Re: [Qemu-devel] [PATCH 4/5] softfloat: Implement fused multiply-add

2011-09-30 Thread Richard Henderson
On 09/28/2011 10:27 AM, Peter Maydell wrote: > > /* > +| Select which NaN to propagate for a three-input operation. > +| For the moment we assume that no CPU needs the 'larger significand' > +| information. > +| Return va

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-09-30 Thread Stefan Hajnoczi
On Fri, Sep 30, 2011 at 11:39 AM, Stefan Hajnoczi wrote: > QED's metadata caching strategy allows two parallel requests to race for > metadata lookup.  The first one to complete will populate the metadata > cache and the second one will drop the data it just read in favor of the > cached data. > >

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-09-30 Thread Stefan Hajnoczi
On Fri, Sep 30, 2011 at 12:27 PM, Amit Shah wrote: > On (Fri) 30 Sep 2011 [11:39:11], Stefan Hajnoczi wrote: >> QED's metadata caching strategy allows two parallel requests to race for >> metadata lookup.  The first one to complete will populate the metadata >> cache and the second one will drop t

Re: [Qemu-devel] [PATCH 1/5] softfloat: Reinstate accidentally disabled target-specific NaN handling

2011-09-30 Thread Richard Henderson
On 09/28/2011 10:27 AM, Peter Maydell wrote: > Include config.h in softfloat.c, so that the target specific ifdefs in > softfloat-specialize.h are evaluated correctly. This was accidentally > broken in commit 789ec7ce2 when config-target.h was removed from > softfloat.h, and means that most targets

Re: [Qemu-devel] QEMU Live Snapshots / Commiting

2011-09-30 Thread Stefan Hajnoczi
On Fri, Sep 30, 2011 at 2:46 PM, Robert P wrote: > > > On Fri, Sep 30, 2011 at 2:04 PM, Stefan Hajnoczi wrote: >> >> On Fri, Sep 30, 2011 at 11:32 AM, Robert P wrote: >> >> Please use Reply-All to keep qemu-devel CCed so that others can >> contribute. >> >> > >> > On Fri, Sep 30, 2011 at 10:16 A

Re: [Qemu-devel] [PATCH] tcg: Use the GDB JIT debugging interface.

2011-09-30 Thread Richard Henderson
On 09/30/2011 12:12 AM, Jan Kiszka wrote: >> Breakpoint 1, __ldb_mmu (addr=1001716, mmu_idx=0) >> at /home/rth/work/qemu/qemu/softmmu_template.h:86 >> 86 { >> (gdb) where >> #0 __ldb_mmu (addr=1001716, mmu_idx=0) >> at /home/rth/work/qemu/qemu/softmmu_template.h:86 >> #1 0x4

Re: [Qemu-devel] Correction: Announcing qemu-users - the unofficial mailing list for qemu users (was: Now, what's left to non-developers? ... )

2011-09-30 Thread Anthony Liguori
On 09/30/2011 09:04 AM, Ottavio wrote: On 30 September 2011 14:53, Anthony Liguori wrote: You know, it's possible to actually talk to people instead of going off and declaring that there's "lack of interest from the maintainers". Both me and Stefan Weil had written to you and the list asking

Re: [Qemu-devel] Correction: Announcing qemu-users - the unofficial mailing list for qemu users (was: Now, what's left to non-developers? ... )

2011-09-30 Thread 陳韋任
Hi, Ottavio Would you like to put http://tech.groups.yahoo.com/group/qemu-users/ on http://wiki.qemu.org/MailingLists ? Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667

Re: [Qemu-devel] [RFC 8/8] slirp: convert save/load function to visitor interface

2011-09-30 Thread Michael Roth
On Fri, 30 Sep 2011 08:39:49 -0500, Anthony Liguori wrote: > On 09/19/2011 09:41 AM, Michael Roth wrote: > > Where possible common routines are used for both input and output, thus > > save on lines of code, theoretically. The added lines here are mostly > > due to extra logic for each save/load

Re: [Qemu-devel] [FYI] Soft feature freeze for 1.0 is 10/15 (three weeks away)

2011-09-30 Thread Stefan Berger
On 09/30/2011 08:59 AM, Anthony Liguori wrote: On 09/29/2011 10:21 PM, Stefan Berger wrote: On 09/21/2011 08:34 PM, Anthony Liguori wrote: For any major feature that you're targeting to the next release, you should: # Make sure that you've posted a patch series to qemu-devel # Write a Feat

Re: [Qemu-devel] Correction: Announcing qemu-users - the unofficial mailing list for qemu users (was: Now, what's left to non-developers? ... )

2011-09-30 Thread Ottavio
On 30 September 2011 14:53, Anthony Liguori wrote: > You know, it's possible to actually talk to people instead of going off and > declaring that there's "lack of interest from the maintainers". Both me and Stefan Weil had written to you and the list asking when qemu-users was going to be availab

Re: [Qemu-devel] Correction: Announcing qemu-users - the unofficial mailing list for qemu users (was: Now, what's left to non-developers? ... )

2011-09-30 Thread 陳韋任
> Instead of waiting for qemu-users to go away in order to recreate it, I > decided > to just create a qemu-discuss list. > > That list is now open. See > > http://lists.nongnu.org/mailman/listinfo/qemu-devel ^^

Re: [Qemu-devel] Correction: Announcing qemu-users - the unofficial mailing list for qemu users

2011-09-30 Thread Anthony Liguori
On 09/30/2011 08:53 AM, Anthony Liguori wrote: On 09/30/2011 08:44 AM, Ottavio wrote: Correction: To subscribe to the mailing list just send a blank email to: qemu-users-subscr...@yahoogroups.com (not qemu-users-ow...@yahoogroups.com as previoulsy stated). You will be given the option to join th

Re: [Qemu-devel] Correction: Announcing qemu-users - the unofficial mailing list for qemu users (was: Now, what's left to non-developers? ... )

2011-09-30 Thread Anthony Liguori
On 09/30/2011 08:44 AM, Ottavio wrote: Correction: To subscribe to the mailing list just send a blank email to: qemu-users-subscr...@yahoogroups.com (not qemu-users-ow...@yahoogroups.com as previoulsy stated). You will be given the option to join the mailing list only. Sorry for the confusion.

Re: [Qemu-devel] QEMU Live Snapshots / Commiting

2011-09-30 Thread Robert P
On Fri, Sep 30, 2011 at 2:04 PM, Stefan Hajnoczi wrote: > On Fri, Sep 30, 2011 at 11:32 AM, Robert P wrote: > > Please use Reply-All to keep qemu-devel CCed so that others can contribute. > > > > > On Fri, Sep 30, 2011 at 10:16 AM, Stefan Hajnoczi > > wrote: > >> > >> On Thu, Sep 29, 2011 at 09

[Qemu-devel] Correction: Announcing qemu-users - the unofficial mailing list for qemu users (was: Now, what's left to non-developers? ... )

2011-09-30 Thread Ottavio
Correction: To subscribe to the mailing list just send a blank email to: qemu-users-subscr...@yahoogroups.com (not qemu-users-ow...@yahoogroups.com as previoulsy stated). You will be given the option to join the mailing list only. Sorry for the confusion. -- Forwarded message -- F

Re: [Qemu-devel] [RFC 8/8] slirp: convert save/load function to visitor interface

2011-09-30 Thread Anthony Liguori
On 09/19/2011 09:41 AM, Michael Roth wrote: Where possible common routines are used for both input and output, thus save on lines of code, theoretically. The added lines here are mostly due to extra logic for each save/load routine to manipulate strings into a unique field name for each saved fie

[Qemu-devel] [PATCH 1/1] PPC: Drop initial ESCC mapping

2011-09-30 Thread Alexander Graf
We are mapping ESCC to a static (incorrect) address on machine init. This overlaps with our vram, rendering the screen barely usable. Since openBIOS is clever enough to map ESCC to where it needs to be, we can just drop that invalid map and everyone's happy. Signed-off-by: Alexander Graf --- hw

[Qemu-devel] qemu.git hangs booting Linux after insmod virtio_blk.ko

2011-09-30 Thread Richard W.M. Jones
I've not looked into this at all, it's just a report that something seems to be "up". I will try to git bisect this later if no one spots anything obvious. The next operation after insmod virtio_blk would be insmod_virtio_net. Guest kernel is a Fedora kernel, version 3.1.0-0.rc6.git0.3.fc16.x86

Re: [Qemu-devel] [FYI] Soft feature freeze for 1.0 is 10/15 (three weeks away)

2011-09-30 Thread Anthony Liguori
On 09/29/2011 10:21 PM, Stefan Berger wrote: On 09/21/2011 08:34 PM, Anthony Liguori wrote: For any major feature that you're targeting to the next release, you should: # Make sure that you've posted a patch series to qemu-devel # Write a Feature page on the qemu.org wiki describing the featu

Re: [Qemu-devel] [PATCH 03/12] qemu-timer: more clock functions

2011-09-30 Thread Lluís Vilanova
Paolo Bonzini writes: > On 09/30/2011 12:52 PM, Lluís Vilanova wrote: >> Paolo Bonzini writes: >> >>> These will be used when moving icount accounting to cpus.c. >> >> I have something related to this kind of refactoring. While trying to >> understand >> all the timing facilities in QEMU, I wro

Re: [Qemu-devel] QEMU Live Snapshots / Commiting

2011-09-30 Thread Stefan Hajnoczi
On Fri, Sep 30, 2011 at 11:32 AM, Robert P wrote: Please use Reply-All to keep qemu-devel CCed so that others can contribute. > > On Fri, Sep 30, 2011 at 10:16 AM, Stefan Hajnoczi > wrote: >> >> On Thu, Sep 29, 2011 at 09:07:19PM +0200, Robert P wrote: >> > Hello, >> > >> > I still have a probl

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-09-30 Thread Amit Shah
On (Fri) 30 Sep 2011 [11:39:11], Stefan Hajnoczi wrote: > QED's metadata caching strategy allows two parallel requests to race for > metadata lookup. The first one to complete will populate the metadata > cache and the second one will drop the data it just read in favor of the > cached data. > >

[Qemu-devel] Announcing qemu-users - the unofficial mailing list for qemu users (was: Now, what's left to non-developers? ... )

2011-09-30 Thread Ottavio
On 5 September 2011 23:13, Stefan Weil wrote: > Do you already know when you expect qemu-users to be available? Due to lack of interest from the maintainers of this project, I have decided to setup an unofficial mailing list for qemu users. Description: This unofficial mailing list is a place fo

Re: [Qemu-devel] [PATCH 03/12] qemu-timer: more clock functions

2011-09-30 Thread Paolo Bonzini
On 09/30/2011 12:52 PM, Lluís Vilanova wrote: Paolo Bonzini writes: These will be used when moving icount accounting to cpus.c. I have something related to this kind of refactoring. While trying to understand all the timing facilities in QEMU, I wrote some (unfinished) patches that try to dis

Re: [Qemu-devel] [RFC PATCH 0/2] Replace 9p debug infrastructure with Qemu Tracing

2011-09-30 Thread Harsh Bora
On 09/29/2011 10:46 PM, Stefan Hajnoczi wrote: On Thu, Sep 29, 2011 at 06:09:47PM +0530, Harsh Prateek Bora wrote: This patchset introduces Qemu Tracing to 9p pdu handlers and removes the existing debug infrastructure which becomes less meaningful after the introduction of coroutines. Parallel o

Re: [Qemu-devel] [PATCH 03/12] qemu-timer: more clock functions

2011-09-30 Thread Lluís Vilanova
Paolo Bonzini writes: > These will be used when moving icount accounting to cpus.c. I have something related to this kind of refactoring. While trying to understand all the timing facilities in QEMU, I wrote some (unfinished) patches that try to disentangle much of the code in qemu-timer into two

Re: [Qemu-devel] [PATCH v2 3/3] scripts: Simpletrace log analysis script for pretty-printing 9p log.

2011-09-30 Thread Harsh Bora
On 09/30/2011 04:06 PM, Harsh Prateek Bora wrote: This python script allows to pretty print 9p simpletrace logs and can be further enhanced to filter 9p logs based on command line arguments. Sample ouput of this analysis script (will be added in commit log): Pretty printing 9p simpletr

[Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-09-30 Thread Stefan Hajnoczi
QED's metadata caching strategy allows two parallel requests to race for metadata lookup. The first one to complete will populate the metadata cache and the second one will drop the data it just read in favor of the cached data. There is a use-after-free in qed_read_l2_table_cb() and qed_commit_l

[Qemu-devel] [PATCH v2 2/3] hw/9pfs: Remove virtio-9p-debug.* infra to be replaced by Qemu Tracing.

2011-09-30 Thread Harsh Prateek Bora
Removing the existing debug infrastrucure as proposed to be replaced by Qemu Tracing infrastructure. Signed-off-by: Harsh Prateek Bora --- Makefile.objs |2 +- hw/9pfs/virtio-9p-debug.c | 646 - hw/9pfs/virtio-9p-debug.h |6 - hw/9

  1   2   >