Paolo Bonzini writes: > These will be used when moving icount accounting to cpus.c.
I have something related to this kind of refactoring. While trying to understand all the timing facilities in QEMU, I wrote some (unfinished) patches that try to disentangle much of the code in qemu-timer into two new files: - qemu-htime: Provides routines related to time in the host. - qemu-vtime: Provides routines related to time in the guest. These patches also try to sanitize some routine names by making their domain and units explicit (e.g., get_clock becomes qemu_htime_nsec and cpu_get_ticks becomes qemu_vtime_tsc). The patches also make the frequency explicit (adds qemu_htime_freq and qemu_vtime_freq). The result should provide code that makes it very clear on which time domain and frequency the code is operating on. The routines in qemu-timer should be already moved into the corresponding qemu-*time files (I no longer remember on which state I left it), but the routine name sanitizing is not finished, mostly because I still had to clear out some details about how the current deadline calculation works. Does this kind of refactoring sound interesting? Thanks, Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth