Re: [Qemu-devel] TB chaining

2011-09-23 Thread 陳韋任
> I see, so they (jmp_next, jmp_first) are just for finding the tbs when > unchaining is needed. do they have any other uses? also, does QEMU do inline > caching ( when it is a conditional branch)? Yes, they are used for unchaining. Please see cpu_unlink_tb -> tb_reset_jump_recursive. What "i

Re: [Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-09-23 Thread Rick Vernam
On Friday 23 September 2011 14:07:17 Alon Levy wrote: > On Thu, Sep 22, 2011 at 02:10:04PM -0500, Rick Vernam wrote: > > On Friday 16 September 2011 12:42:02 Rick Vernam wrote: > > > On Friday 16 September 2011 03:52:34 hkran wrote: > > > [snip] > > > > > > > I have tried many times with many rest

Re: [Qemu-devel] [PATCH 1/6] block: Keep track of devices' I/O status

2011-09-23 Thread Luiz Capitulino
On Fri, 23 Sep 2011 17:36:53 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Fri, 23 Sep 2011 09:51:24 +0200 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > This commit adds support to the BlockDriverState type to keep track > >> > of devices' I/O

Re: [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards

2011-09-23 Thread Anthony Liguori
On 09/20/2011 10:18 AM, Peter Maydell wrote: Add myself as co-maintainer alongside Paul Brook for the TCG ARM guest implementation (target-arm) and the ARM dev boards (integratorcp, realview, stellaris, versatilepb). Signed-off-by: Peter Maydell Applied. Thanks. Regards, Anthony Liguori -

Re: [Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-09-23 Thread Alon Levy
On Thu, Sep 22, 2011 at 02:10:04PM -0500, Rick Vernam wrote: > On Friday 16 September 2011 12:42:02 Rick Vernam wrote: > > On Friday 16 September 2011 03:52:34 hkran wrote: > > [snip] > > > > > I have tried many times with many restarts or shutdown-and-boot xp guest > > > but failed to meet the cr

Re: [Qemu-devel] [PATCH 1/2] virtio: Use global memory barrier macros

2011-09-23 Thread Anthony Liguori
On 09/19/2011 09:05 PM, David Gibson wrote: The virtio code uses wmb() macros in several places, as required by the SMP-aware virtio protocol. However the wmb() macro is locally defined to be a compiler barrier only. This is probably sufficient on x86 due to its strong storage ordering model, b

Re: [Qemu-devel] [PATCH] Makefile: Remove 'tarbin' target

2011-09-23 Thread Anthony Liguori
On 09/16/2011 09:40 AM, Peter Maydell wrote: Remove the 'tarbin' target -- it isn't used as part of the official QEMU release process, and it's out of date (various new bios files were never added to its list of files). It's better not to provide it at all than to have a broken makefile target we

Re: [Qemu-devel] [PATCH] adlib: remove write-only variable

2011-09-23 Thread Anthony Liguori
On 09/18/2011 09:27 AM, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau Applied. Thanks. Regards, Anthony Liguori --- hw/adlib.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/adlib.c b/hw/adlib.c index d98aebc..66db797 100644 --- a/hw/adlib.c +

Re: [Qemu-devel] [PATCH] irq: introduce qemu_irq_proxy()

2011-09-23 Thread Anthony Liguori
On 09/18/2011 07:58 AM, Avi Kivity wrote: In some cases we have a circular dependency involving irqs - the irq controller depends on a bus, which in turn depends on the irq controller. Add qemu_irq_proxy() which acts as a passthrough, except that the target irq may be set later on. Signed-off-by

Re: [Qemu-devel] [PATCH] qemu-char: use qemu_set_fd_handler/2 consistently

2011-09-23 Thread Anthony Liguori
On 09/16/2011 04:19 PM, Marcelo Tosatti wrote: Now that qemu_set_fd_handler and qemu_set_fd_handler2 have different implementations, one using qemu iohandlers and the other glib, it is not safe to mix the two when inserting/deleting handlers. Fixes kvm-autotest. Signed-off-by: Marcelo Tosatti

Re: [Qemu-devel] [PATCH 0/2] Use QEMU_GNUC_PREREQ to fix wrong gcc version test

2011-09-23 Thread Anthony Liguori
On 09/16/2011 03:03 PM, Stefan Weil wrote: These two patches fix a wrong gcc version test. [PATCH 1/2] Move macro QEMU_GNUC_PREREQ to compiler.h [PATCH 2/2] Fix and clean code which tests the gcc version Applied all. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2 11/12] isa: give bus to isa_get_irq() and isa_bus_irqs()

2011-09-23 Thread Anthony Liguori
On 09/20/2011 12:24 AM, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau This patch breaks booting a 64-bit Ubuntu guest under KVM (probably under TCG too). It hangs during startup. Regards, Anthony Liguori --- hw/i8254.c |2 +- hw/ide.h | 12 ---

Re: [Qemu-devel] Enabling Hyperthreading for Guest

2011-09-23 Thread Alex Williamson
On Fri, 2011-09-23 at 17:29 +0200, Erik Rull wrote: > Alex Williamson wrote: > > On Thu, 2011-09-22 at 18:43 +0200, Erik Rull wrote: > >> Alex Williamson wrote: > >>> See the extended -smp options: > >>> > >>> -smp n[,maxcpus=cpus][,cores=cores][,threads=threads][,sockets=sockets] > >>>

[Qemu-devel] [PATCH v3 3/3] trace: Add "vcpu_reset" event

2011-09-23 Thread Lluís Vilanova
Signals the reset of the state a vCPU (CPUState structure). Signed-off-by: Lluís Vilanova --- target-arm/helper.c |3 +++ target-cris/translate.c |3 +++ target-i386/helper.c |3 +++ target-lm32/helper.c |3 +++ target-m68k/helper.c |

[Qemu-devel] [PATCH v3 2/3] trace: Add "vcpu_init" event

2011-09-23 Thread Lluís Vilanova
Signals the creation of a new vCPU (CPUState structure). Signed-off-by: Lluís Vilanova --- cpus-user.c |2 ++ cpus.c |2 ++ trace-events |7 +++ 3 files changed, 11 insertions(+), 0 deletions(-) diff --git a/cpus-user.c b/cpus-user.c index c1e5e58..5db48d2 100644 --- a/cp

[Qemu-devel] [PATCH v3 1/3] Make 'qemu_init_vcpu' a function (instead of a macro)

2011-09-23 Thread Lluís Vilanova
Implementation with 'CONFIG_USER_ONLY' is moved into new file 'cpus-user.c'. Signed-off-by: Lluís Vilanova --- Makefile.objs |1 + cpus-user.c | 15 +++ qemu-common.h |4 3 files changed, 16 insertions(+), 4 deletions(-) create mode 100644 cpus-user.c diff --git a/

Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA

2011-09-23 Thread Anthony Liguori
On 09/01/2011 12:00 AM, David Gibson wrote: This patch adds functions to pci.[ch] to perform PCI DMA operations. At present, these are just stubs which perform directly cpu physical memory accesses. Using these stubs, however, distinguishes PCI device DMA transactions from other accesses to phy

Re: [Qemu-devel] [PATCH 0/4] ISA PC fixes

2011-09-23 Thread Anthony Liguori
On 09/23/2011 11:15 AM, Jan Kiszka wrote: On 2011-09-23 18:06, Anthony Liguori wrote: On 09/21/2011 01:49 PM, Jan Kiszka wrote: This plus [1] reanimates -M isapc for me again. Applied all. Thanks. What's [1] BTW? Oops: http://thread.gmane.org/gmane.comp.emulators.qemu/118195 Okay, when

Re: [Qemu-devel] [PATCH 1/3] Make 'qemu_init_vcpu' a function (instead of a macro)

2011-09-23 Thread Anthony Liguori
On 09/21/2011 10:42 AM, Lluís Vilanova wrote: Implementation with 'CONFIG_USER_ONLY' is moved into new file 'cpus-user.c'. Signed-off-by: Lluís Vilanova --- Makefile.objs |1 + cpus-user.c |8 qemu-common.h |4 3 files changed, 9 insertions(+), 4 deletions(-) c

Re: [Qemu-devel] [PATCH v8 3/4] block: add block timer and throttling algorithm

2011-09-23 Thread Kevin Wolf
Am 08.09.2011 12:11, schrieb Zhi Yong Wu: > Note: > 1.) When bps/iops limits are specified to a small value such as 511 > bytes/s, this VM will hang up. We are considering how to handle this senario. > 2.) When "dd" command is issued in guest, if its option bs is set to a > large value

Re: [Qemu-devel] [PATCH 0/4] ISA PC fixes

2011-09-23 Thread Jan Kiszka
On 2011-09-23 18:06, Anthony Liguori wrote: > On 09/21/2011 01:49 PM, Jan Kiszka wrote: >> This plus [1] reanimates -M isapc for me again. > > Applied all. Thanks. What's [1] BTW? Oops: http://thread.gmane.org/gmane.comp.emulators.qemu/118195 Jan signature.asc Description: OpenPGP digital s

Re: [Qemu-devel] [PATCH 0/4] ISA PC fixes

2011-09-23 Thread Anthony Liguori
On 09/21/2011 01:49 PM, Jan Kiszka wrote: This plus [1] reanimates -M isapc for me again. Applied all. Thanks. What's [1] BTW? Regards, Anthony Liguori Jan Kiszka (4): pc: Unbreak ROM mapping for ISA machine pc: Disable HPET for ISA machine vga: Unbreak ISA support cirrus: Un

Re: [Qemu-devel] [PATCH] core: remove qemu_service_io

2011-09-23 Thread Anthony Liguori
On 09/22/2011 04:26 AM, Frediano Ziglio wrote: qemu_service_io was mainly an alias to qemu_notify_event, currently used only by PPC for timer hack, so call qemu_notify_event directly. Signed-off-by: Frediano Ziglio Applied. Thanks. Regards, Anthony Liguori --- arch_init.c |

Re: [Qemu-devel] stale savannah git repo

2011-09-23 Thread Stefan Weil
Am 23.09.2011 13:53, schrieb Andreas Schwab: Stefan Weil writes: Maybe this works: * Get login account for savannah: http://www.gnu.org/software/README.accounts.html * Upload your public ssh key to savannah. * Run a cron job on qemu.org: ssh to savannah or fencepost.gnu.org and upda

Re: [Qemu-devel] [PATCH] pci-devfn: check that device/slot number is within range

2011-09-23 Thread Anthony Liguori
On 09/21/2011 02:25 PM, Donald Dutile wrote: Need to check that guest slot/device number is not> 31 or walk off the devfn table when checking if a devfn is available or not in a guest. before this fix, passing in an addr=abc or addr=34, can crash qemu, sometimes fail gracefully if data past en

Re: [Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit

2011-09-23 Thread Anthony Liguori
On 09/21/2011 03:06 PM, dann frazier wrote: [Originally sent to qemu-kvm list, but I was redirected here] The Capabilities Pointer is NULL, so this bit shouldn't be set. The state of this bit doesn't appear to change any behavior on Linux/Windows versions we've tested, but it does cause Windows'

Re: [Qemu-devel] [PATCH] isapc: give system address space when pci is disabled

2011-09-23 Thread Anthony Liguori
On 09/18/2011 11:04 AM, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau Applied. Thanks. Regards, Anthony Liguori --- hw/pc_piix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index da6fa55..c0b8a3a 100644 --- a/hw/pc_pii

[Qemu-devel] [RFC] Generic image streaming

2011-09-23 Thread Stefan Hajnoczi
Here is my generic image streaming branch, which aims to provide a way to copy the contents of a backing file into an image file of a running guest without requiring specific support in the various block drivers (e.g. qcow2, qed, vmdk): http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/im

Re: [Qemu-devel] [PATCH 2/2] build: fix race with creating qapi-generated

2011-09-23 Thread Anthony Liguori
On 09/07/2011 06:40 PM, Michael Roth wrote: Since qapi-generated/ is a global QEMU include path, we need to make sure it is created before anything is compiled, so do this in the configure phase rather than via the Makefile. Signed-off-by: Michael Roth Applied for real this time :-) Thanks.

Re: [Qemu-devel] [PATCH v8 2/4] block: add the command line support

2011-09-23 Thread Kevin Wolf
Am 08.09.2011 12:11, schrieb Zhi Yong Wu: > Signed-off-by: Zhi Yong Wu > --- > block.c | 59 > +++ > block.h |5 > block_int.h |3 ++ > blockdev.c | 29 +++ > qemu-config.c |

Re: [Qemu-devel] [PATCH 1/6] block: Keep track of devices' I/O status

2011-09-23 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 23 Sep 2011 09:51:24 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > This commit adds support to the BlockDriverState type to keep track >> > of devices' I/O status. >> > >> > There are three possible status: BDRV_IOS_OK (no error), BDRV_

Re: [Qemu-devel] [PATCH v8 1/4] block: add the block queue support

2011-09-23 Thread Kevin Wolf
Am 08.09.2011 12:11, schrieb Zhi Yong Wu: > Signed-off-by: Zhi Yong Wu > --- > Makefile.objs |2 +- > block/blk-queue.c | 201 > + > block/blk-queue.h | 59 > block_int.h | 27 +++ > 4 files changed, 288

Re: [Qemu-devel] Enabling Hyperthreading for Guest

2011-09-23 Thread Erik Rull
Alex Williamson wrote: On Thu, 2011-09-22 at 18:43 +0200, Erik Rull wrote: Alex Williamson wrote: See the extended -smp options: -smp n[,maxcpus=cpus][,cores=cores][,threads=threads][,sockets=sockets] set the number of CPUs to 'n' [default=1] maxcpus= maximu

Re: [Qemu-devel] [PATCH] vga: Fix text mode screendumps

2011-09-23 Thread Anthony Liguori
On 09/15/2011 05:47 PM, Jan Kiszka wrote: From: Jan Kiszka In text mode, even a full refresh of the screen takes multiple updates. As we reset the dump file pointer after the first call, we only wrote the first line. Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori ---

Re: [Qemu-devel] [PATCH] console: Properly switch consoles for screen dumps

2011-09-23 Thread Anthony Liguori
On 09/15/2011 05:48 PM, Jan Kiszka wrote: From: Jan Kiszka Do not mess with active_console, use console_select instead. This fixes corrupt virtual monitor consoles after issuing the screendump command. Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori --- Looks still w

Re: [Qemu-devel] [PATCH] qdev: print bus properties too

2011-09-23 Thread Anthony Liguori
On 09/16/2011 04:25 AM, Gerd Hoffmann wrote: Make qdev_device_help print both device and bus properties. Helps libvirt to figure whenever bus properties such as PCI.multifunction are supported present or not. Signed-off-by: Gerd Hoffmann Applied. Thanks. Regards, Anthony Liguori --- hw/

[Qemu-devel] [PATCH 06/11] migration: If there is one error, it makes no sense to continue

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- buffered_file.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/buffered_file.c b/buffered_file.c index 486af57..bcdf04f 100644 --- a/buffered_file.c +++ b/buffered_file.c @@ -193,9 +193,9 @@ static int buffered_rate_limit(void *opaq

[Qemu-devel] [PATCH 04/11] migration: return real error code

2011-09-23 Thread Juan Quintela
make functions propaget errno, instead of just using -EIO. Signed-off-by: Juan Quintela --- migration.c |6 +- savevm.c| 33 +++-- 2 files changed, 20 insertions(+), 19 deletions(-) diff --git a/migration.c b/migration.c index ea7bcc8..9498e20 100644 --

Re: [Qemu-devel] [PATCH] Add KZM board support to qemu

2011-09-23 Thread Anthony Liguori
On 09/22/2011 07:50 PM, Peter Chubb wrote: The KZM board is an evaluation board for the ARM v6 i.mx31 processor. It is about the only readily-available development board for that processor, even though the imx.31 is used in many embedded devices. This patch was developed at OK-Labs. I have pe

[Qemu-devel] [PATCH 07/23] migration: move migrate_create_state to do_migrate

2011-09-23 Thread Juan Quintela
Once there, remove all parameters that don't need to be passed to *start_outgoing_migration() functions Signed-off-by: Juan Quintela --- migration-exec.c | 19 +-- migration-fd.c | 22 ++ migration-tcp.c | 22 +++--- migration-unix.c |

[Qemu-devel] [PATCH 14/23] migration: Move exported functions to the end of the file

2011-09-23 Thread Juan Quintela
This means we can remove the two forward declarations. Signed-off-by: Juan Quintela --- migration.c | 188 -- 1 files changed, 91 insertions(+), 97 deletions(-) diff --git a/migration.c b/migration.c index 9bc7ffa..9bb089a 100644 --- a/mi

[Qemu-devel] [PATCH 08/23] migration: Introduce MIG_STATE_NONE

2011-09-23 Thread Juan Quintela
Use MIG_STATE_ACTIVE only when migration has really started Signed-off-by: Juan Quintela --- migration.c |6 +- migration.h | 11 +++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/migration.c b/migration.c index 88f4c23..abb99ea 100644 --- a/migration.c +++ b/

[Qemu-devel] [PATCH 15/23] migration: use global variable directly

2011-09-23 Thread Juan Quintela
We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->file test because it is already done inside qemu_file_set_rate_limit() function. Signed-off-by: Juan Quintela --- migration.c |6 ++ 1 files changed, 2 insertions(+)

[Qemu-devel] [PATCH 07/11] buffered_file: Use right "opaque"

2011-09-23 Thread Juan Quintela
buffered_close 's' variable is of type QEMUFileBuffered, and wait_for_unfreeze() expect to receive a MigrationState, that 'coincidentaly' is s->opaque. Signed-off-by: Juan Quintela --- buffered_file.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/buffered_file.c b/buf

[Qemu-devel] [PATCH 03/11] migration: Check that migration is active before cancel it

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 531fe83..ea7bcc8 100644 --- a/migration.c +++ b/migration.c @@ -133,9 +133,9 @@ int do_migrate_cancel(Monitor *mon, const QDict *qdict, QObject

[Qemu-devel] [PATCH 20/23] migration: Make state definitions local

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c |8 migration.h |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/migration.c b/migration.c index 580f546..0213d5c 100644 --- a/migration.c +++ b/migration.c @@ -31,6 +31,14 @@ do { } while (0) #endif

[Qemu-devel] [PATCH 12/23] migration: Remove get_status() accessor

2011-09-23 Thread Juan Quintela
It is only used inside migration.c, and fields on that struct are accessed all around the place on that file. Signed-off-by: Juan Quintela --- migration.c | 16 +--- migration.h |1 - 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/migration.c b/migration.c inde

[Qemu-devel] [PATCH 06/23] migration: Make all posible migration functions static

2011-09-23 Thread Juan Quintela
I have to move two functions postions to avoid forward declarations Signed-off-by: Juan Quintela --- migration.c | 72 +- migration.h | 12 - 2 files changed, 36 insertions(+), 48 deletions(-) diff --git a/migration.c b/migrati

[Qemu-devel] [PATCH 03/23] migration: Fold MigrationState into FdMigrationState

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c | 10 +- migration-fd.c | 10 +- migration-tcp.c | 10 +- migration-unix.c | 10 +- migration.c | 14 ++ migration.h | 23 +-- 6 files changed, 31 insertions(

[Qemu-devel] [PATCH 13/23] migration: Remove migration cancel() callback

2011-09-23 Thread Juan Quintela
It is used only in one place Signed-off-by: Juan Quintela --- migration.c |9 - migration.h |1 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/migration.c b/migration.c index 7cb0404..9bc7ffa 100644 --- a/migration.c +++ b/migration.c @@ -133,12 +133,12 @@ free_

[Qemu-devel] [PATCH 10/23] migration: Introduce migrate_fd_completed() for consistency

2011-09-23 Thread Juan Quintela
This function is a bit different of the others that change the state, in the sense that if migrate_fd_cleanup() returns an error, it set the status to error, not completed. Signed-off-by: Juan Quintela --- migration.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH 02/23] migration: Use FdMigrationState instead of MigrationState when possible

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c | 34 -- migration.h | 16 2 files changed, 24 insertions(+), 26 deletions(-) diff --git a/migration.c b/migration.c index fae540f..5262dd0 100644 --- a/migration.c +++ b/migration.c @@ -34,7 +34,7

[Qemu-devel] [PATCH 02/11] migration: simplify state assignmente

2011-09-23 Thread Juan Quintela
Once there, make sure that if we already know that there is one error, just call migration_fd_cleanup() with the ERROR state. Signed-off-by: Juan Quintela --- migration.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/migration.c b/migration.c index 7dd8f4e..5

[Qemu-devel] [PATCH 05/11] migration: add error handling to migrate_fd_put_notify().

2011-09-23 Thread Juan Quintela
From: Yoshiaki Tamura Although migrate_fd_put_buffer() sets MIG_STATE_ERROR if it failed, since migrate_fd_put_notify() isn't checking error of underlying QEMUFile, those resources are kept open. This patch checks it and calls migrate_fd_error() in case of error. Signed-off-by: Yoshiaki Tamura

Re: [Qemu-devel] [PATCH v1 0/6]: block: Add I/O status support

2011-09-23 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 23 Sep 2011 10:55:39 +0200 > Markus Armbruster wrote: > >> Kevin Wolf writes: >> >> > Am 19.09.2011 16:09, schrieb Luiz Capitulino: >> >> On Mon, 19 Sep 2011 15:40:06 +0200 >> >> Kevin Wolf wrote: >> >> >> >>> Am 01.09.2011 20:37, schrieb Luiz Capitulino: >>

[Qemu-devel] [PATCH 04/23] migration: Rename FdMigrationState MigrationState

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c | 10 +- migration-fd.c | 10 +- migration-tcp.c | 12 ++-- migration-unix.c | 12 ++-- migration.c | 34 +- migration.h | 38 +++-

[Qemu-devel] [PATCH 09/11] migration: don't "write" when migration is not active

2011-09-23 Thread Juan Quintela
If migration is not active, just ignore writes. [Based on Daniel Berrange suggestion] Signed-off-by: Juan Quintela --- migration.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/migration.c b/migration.c index 0b284ff..755b96b 100644 --- a/migration.c +++ b/migratio

Re: [Qemu-devel] [PATCH 1/6] block: Keep track of devices' I/O status

2011-09-23 Thread Luiz Capitulino
On Fri, 23 Sep 2011 09:51:24 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > This commit adds support to the BlockDriverState type to keep track > > of devices' I/O status. > > > > There are three possible status: BDRV_IOS_OK (no error), BDRV_IOS_ENOSPC > > (no space error) and B

[Qemu-devel] [PATCH 23/23] migration: make migration-{tcp, unix} consistent

2011-09-23 Thread Juan Quintela
Files are almost identical in functionality, just remove the differences that make no sense. Signed-off-by: Juan Quintela --- migration-tcp.c | 15 ++- migration-unix.c | 46 +- 2 files changed, 35 insertions(+), 26 deletions(-) diff

[Qemu-devel] [PATCH 16/23] migration: another case of global variable assigned to local one

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index d5e0eb0..1cc21f0 100644 --- a/migration.c +++ b/migration.c @@ -137,9 +137,8 @@ void do_info_migrate(Monitor *mon, QObject **ret_data) QDic

[Qemu-devel] [PATCH 21/23] migration: Don't use callback on file defining it

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-tcp.c |4 ++-- migration-unix.c |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c index f6b2288..bd3aa3a 100644 --- a/migration-tcp.c +++ b/migration-tcp.c @@ -58,7 +58,7 @@ static void

[Qemu-devel] [PATCH 17/23] migration: make sure we always have a migration state

2011-09-23 Thread Juan Quintela
This cleans up a lot the code as we don't have to check anymore if the variable is NULL or not. We don't make it static, because when we integrate fault tolerance, we can have several migrations at once. Signed-off-by: Juan Quintela --- migration.c | 126 +--

[Qemu-devel] [PATCH 22/23] migration: propagate error correctly

2011-09-23 Thread Juan Quintela
unix and tcp outgoing migration have error values, but didn't returned it. Make them return the error. Notice that EINPROGRESS & EWOULDBLOCK are not considered errors as callwill be retry later. Signed-off-by: Juan Quintela --- migration-tcp.c | 20 +++- migration-unix.c |

[Qemu-devel] [PATCH 08/11] buffered_file: reuse QEMUFile has_error field

2011-09-23 Thread Juan Quintela
Instead of having two has_error fields in QEMUFile & QEMUBufferedFile, reuse the 1st one. Notice that the one in buffered_file is only set after a file operation. Signed-off-by: Juan Quintela --- buffered_file.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --

Re: [Qemu-devel] [PATCH] Qemu co-operation with kvm tsc deadline timer

2011-09-23 Thread Jan Kiszka
On 2011-09-22 10:57, Liu, Jinsong wrote: > From 8c39f2ddbf7069342826a83e535c0c7b641d6501 Mon Sep 17 00:00:00 2001 > From: Liu, Jinsong > Date: Thu, 22 Sep 2011 16:28:13 +0800 > Subject: [PATCH] Qemu co-operation with kvm tsc deadline timer > > KVM add emulation of lapic tsc deadline timer for gue

[Qemu-devel] [PATCH 19/23] migration: Export a function that tells if the migration has finished correctly

2011-09-23 Thread Juan Quintela
This will allows us to hide the status values. Signed-off-by: Juan Quintela --- migration.c |4 ++-- migration.h |2 +- ui/spice-core.c |4 +--- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/migration.c b/migration.c index ea50a6f..580f546 100644 --- a/migrat

Re: [Qemu-devel] [PATCH v2] support add-cow format

2011-09-23 Thread Paolo Bonzini
On 09/23/2011 02:20 PM, Kevin Wolf wrote: +static BlockDriverAIOCB *add_cow_aio_flush(BlockDriverState *bs, +BlockDriverCompletionFunc *cb, void *opaque) +{ +BDRVAddCowState *state = bs->opaque; +bdrv_aio_flush(state->image_hd, cb, opaque); +return bdrv_aio_flush(bs->file, cb,

Re: [Qemu-devel] [PATCH v1 0/6]: block: Add I/O status support

2011-09-23 Thread Luiz Capitulino
On Fri, 23 Sep 2011 10:55:39 +0200 Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 19.09.2011 16:09, schrieb Luiz Capitulino: > >> On Mon, 19 Sep 2011 15:40:06 +0200 > >> Kevin Wolf wrote: > >> > >>> Am 01.09.2011 20:37, schrieb Luiz Capitulino: > This series adds support to the b

Re: [Qemu-devel] [PATCH 09/11] migration: don't "write" when migration is not active

2011-09-23 Thread Paolo Bonzini
On 09/23/2011 02:50 PM, Juan Quintela wrote: If migration is not active, just ignore writes. [Based on Daniel Berrange suggestion] Signed-off-by: Juan Quintela --- migration.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/migration.c b/migration.c index 0b284ff.

[Qemu-devel] [PATCH 01/23] migration: Make *start_outgoing_migration return FdMigrationState

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c |4 ++-- migration-fd.c |4 ++-- migration-tcp.c |4 ++-- migration-unix.c |4 ++-- migration.c |4 ++-- migration.h |8 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/migration-exec.

Re: [Qemu-devel] [PATCH 05/11] migration: add error handling to migrate_fd_put_notify().

2011-09-23 Thread Paolo Bonzini
On 09/23/2011 02:50 PM, Juan Quintela wrote: From: Yoshiaki Tamura Although migrate_fd_put_buffer() sets MIG_STATE_ERROR if it failed, since migrate_fd_put_notify() isn't checking error of underlying QEMUFile, those resources are kept open. This patch checks it and calls migrate_fd_error() in c

[Qemu-devel] [PATCH 18/23] migration: Use bandwidth_limit directly

2011-09-23 Thread Juan Quintela
Now that current_migration always exist, there is no reason for max_throotle variable. Signed-off-by: Juan Quintela --- migration.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/migration.c b/migration.c index c382383..ea50a6f 100644 --- a/migration.

[Qemu-devel] [PATCH] s390: fix short kernel command lines

2011-09-23 Thread Christian Borntraeger
The default kernel command line for s390 is "root=/dev/ram0 ro" When overriding this line, we have to ensure to also copy the \0 to avoid false lines, for example, -append "root=/dev/vda" will result in "root=/dev/vda0 ro" with the current code. Signed-off-by: Christian Borntraeger --- hw/s

[Qemu-devel] [PATCH 10/11] migration: set error if select return one error

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/migration.c b/migration.c index 755b96b..9265b16 100644 --- a/migration.c +++ b/migration.c @@ -457,6 +457,10 @@ void migrate_fd_wait_for_unfreeze(void *opaque) ret

[Qemu-devel] [PATCH 11/23] migration: Our release callback was just free

2011-09-23 Thread Juan Quintela
We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is exactly the case where they don't care, we are just freeing the state from previous failed migration (it can't be a sucessful one, otherwise

[Qemu-devel] [PATCH 05/23] migration: Refactor MigrationState creation

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c | 16 +--- migration-fd.c | 16 +--- migration-tcp.c | 15 +-- migration-unix.c | 15 +-- migration.c | 29 + migration.h | 11 +++ 6 file

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for guest

2011-09-23 Thread Marcelo Tosatti
On Fri, Sep 23, 2011 at 04:25:51PM +0800, Liu, Jinsong wrote: > Marcelo Tosatti wrote: > > On Thu, Sep 22, 2011 at 04:55:52PM +0800, Liu, Jinsong wrote: > >>> From 4d5b83aba40ce0d421add9a41a6c591a8590a32e Mon Sep 17 00:00:00 > >>> 2001 > >> From: Liu, Jinsong > >> Date: Thu, 22 Sep 2011 14:00:08

Re: [Qemu-devel] [PATCH] Qemu co-operation with kvm tsc deadline timer

2011-09-23 Thread Marcelo Tosatti
On Thu, Sep 22, 2011 at 04:57:14PM +0800, Liu, Jinsong wrote: > >From 8c39f2ddbf7069342826a83e535c0c7b641d6501 Mon Sep 17 00:00:00 2001 > From: Liu, Jinsong > Date: Thu, 22 Sep 2011 16:28:13 +0800 > Subject: [PATCH] Qemu co-operation with kvm tsc deadline timer > > KVM add emulation of lapic tsc

[Qemu-devel] [Bug 855633] Re: guest boots up too slowly

2011-09-23 Thread Yongjie Ren
Eh? I can reproduce very easily and it always has this issue in the qemu.git upstream in the past two weeks. I used rhel5u5, rhel6, rhel6u1 or any other images as guest, and met the same issue. And this is not a platform specific issue. It can be reproduced in Westmere-EP and Sandybrige-EP plat

[Qemu-devel] [PATCH 09/23] migration: Refactor and simplify error checking in migrate_fd_put_ready

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/migration.c b/migration.c index abb99ea..740483d 100644 --- a/migration.c +++ b/migration.c @@ -373,23 +373,22 @@ static void migrate_fd_put_ready(void *opa

[Qemu-devel] [PATCH v3 00/23] Refactor and cleanup migration code

2011-09-23 Thread Juan Quintela
Hi v4: rebase on top of new qemu and new migration-errors series v3: this patch applies on top of my previous "migration error" patches. All error handling has been moved to that series, except for "propagate error correctly", without this refactoring, it is qui

[Qemu-devel] [PATCH 11/11] migration: change has_error to contain errno values

2011-09-23 Thread Juan Quintela
We normally already have an errno value. When not, abuse EINVAL. Signed-off-by: Juan Quintela --- arch_init.c |2 +- block-migration.c |6 +++--- buffered_file.c |4 ++-- hw/hw.h |2 +- migration.c |2 +- savevm.c |8 6 files cha

[Qemu-devel] [PATCH 01/11] ds1225y: Use stdio instead of QEMUFile

2011-09-23 Thread Juan Quintela
QEMUFile * is only intended for migration nowadays. Using it for anything else just adds pain and a layer of buffers for no good reason. Signed-off-by: Juan Quintela --- hw/ds1225y.c | 28 1 files changed, 16 insertions(+), 12 deletions(-) diff --git a/hw/ds1225y

[Qemu-devel] [PATCH v2 00/11] Handle errors during migration

2011-09-23 Thread Juan Quintela
Hi [v2] - dropped migration_flush patch. Substituted by migration: don't write when migration is not active (based on danp suggestion) - we were using wrong "opaque" - merge has_error field (Paolo suggested to handle both) - has_error now contains errno values Later, Juan. [v1] This patch ser

Re: [Qemu-devel] [PATCH] qcow2: fix 028 iotest

2011-09-23 Thread Kevin Wolf
Am 23.09.2011 13:25, schrieb Frediano Ziglio: > This fix bound check bug accessing last cluster if image size is not > cluster aligned caused by "Unlock during COW" patch. > > Signed-off-by: Frediano Ziglio I'm considering a solution like this, but I'm not completely happy with it. Maybe the mor

[Qemu-devel] [PATCH 2/4] omap_intc: Qdevify

2011-09-23 Thread Peter Maydell
Convert the omap_intc devices to qdev. This includes adding a 'revision' property which will be needed for omap3. The bulk of this patch is the replacement of "s->irq[x][y]" with "qdev_get_gpio_in(s->ih[x], y)" now that the interrupt controller exposes its input lines as qdev gpio inputs. The de

Re: [Qemu-devel] [PATCH v2] support add-cow format

2011-09-23 Thread Kevin Wolf
Am 21.09.2011 10:56, schrieb Dong Xu Wang: > ubuntu.img is a disk image which has been installed OS. > (1) Create a raw image with the same size of ubuntu.img > qemu-img create -f raw test.raw 8G > (2) Create a add-cow image which will store dirty bitmap > qemu-img create -f add-cow test.add-cow -o

Re: [Qemu-devel] stale savannah git repo

2011-09-23 Thread Andreas Schwab
Stefan Weil writes: > Maybe this works: > > * Get login account for savannah: >http://www.gnu.org/software/README.accounts.html > > * Upload your public ssh key to savannah. > > * Run a cron job on qemu.org: >ssh to savannah or fencepost.gnu.org and update the git repo. You don't need a

[Qemu-devel] [PATCH 1/4] omap_intc: Use MemoryRegion API

2011-09-23 Thread Peter Maydell
Convert omap_intc to use the MemoryRegion API Signed-off-by: Peter Maydell --- hw/omap_intc.c | 64 ++- 1 files changed, 30 insertions(+), 34 deletions(-) diff --git a/hw/omap_intc.c b/hw/omap_intc.c index f1f570e..38637c6 100644 --- a/hw/om

[Qemu-devel] [PULL 0/4] pull: omap patches

2011-09-23 Thread Peter Maydell
This is a small pullreq for the couple of outstanding OMAP patches, which I have now rebased following the landing of Avi's memoryregion batch which touched omap1.c. I've also included the MAINTAINERS file update. Please pull. Thanks -- PMM The following changes since commit 7e36b264ce524bc60b7b

[Qemu-devel] [PATCH 3/4] hw/omap1: Wire up GPIO clock

2011-09-23 Thread Peter Maydell
Wire up the OMAP1 GPIO clock -- this fixes a hw_error() on startup with OMAP1 based machines (sx1, cheetah). Signed-off-by: Peter Maydell --- hw/omap1.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/omap1.c b/hw/omap1.c index 4bf88e8..619812c 100644 --- a/hw/omap1.c

[Qemu-devel] [PATCH 4/4] MAINTAINERS: claim maintainership for the OMAP devices

2011-09-23 Thread Peter Maydell
Signed-off-by: Peter Maydell Acked-by: Edgar E. Iglesias --- MAINTAINERS |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7c5ea87..5046dc9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -355,6 +355,11 @@ M: Kevin Wolf S: Odd Fixes F:

[Qemu-devel] [PATCH] qcow2: fix 028 iotest

2011-09-23 Thread Frediano Ziglio
This fix bound check bug accessing last cluster if image size is not cluster aligned caused by "Unlock during COW" patch. Signed-off-by: Frediano Ziglio --- block/qcow2-cluster.c |8 ++-- block/qcow2.c |2 +- block/qcow2.h |2 ++ 3 files changed, 9 insertions(+),

[Qemu-devel] [PATCH v2] support add-cow format

2011-09-23 Thread Dong Xu Wang
ubuntu.img is a disk image which has been installed OS. (1) Create a raw image with the same size of ubuntu.img qemu-img create -f raw test.raw 8G (2) Create a add-cow image which will store dirty bitmap qemu-img create -f add-cow test.add-cow -o backing_file=ubuntu.img,image_file=test.raw (3) Run

Re: [Qemu-devel] Help needed -- vvfat.c

2011-09-23 Thread Pintu Kumar
On Mon, Sep 19, 2011 at 8:07 PM, Kevin Wolf wrote: > Am 15.09.2011 14:49, schrieb Pintu Kumar: >> Hi, >> >> This is regarding qemu block/vvfat.c. >> >> Currently vvfat scans all directories and sub-directories in the >> beginning during init_directories(). >> >> I want to modify vvfat such that it

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-23 Thread Paolo Bonzini
On 09/23/2011 11:15 AM, Mark Wu wrote: I tested this patch with the following command: x86_64-softmmu/qemu-system-x86_64 --enable-kvm rhel54_1.img -m 1024 -net tap,ifname=tap0,script=no -net nic,model=virtio -sdl -drive file=iscsi://127.0.0.1/iqn.2011-09.com.example:server.target1/ And I found th

Re: [Qemu-devel] [PATCH v1 0/6]: block: Add I/O status support

2011-09-23 Thread Markus Armbruster
Kevin Wolf writes: > Am 23.09.2011 10:55, schrieb Markus Armbruster: [...] >> Apropos enforcing. Currently, -drive accepts any werror and rerror >> action with if={ide,virtio,scsi,none}. We rely on device models not >> implementing an action to check and fail during initialization. >> scsi-gene

Re: [Qemu-devel] [PATCH] tcg/arm: Remove unused tcg_out_addi()

2011-09-23 Thread Peter Maydell
Ping? Would be nice to get this committed since it's a compile failure fix... -- PMM On 12 September 2011 11:03, Peter Maydell wrote: > Remove the unused function tcg_out_addi() from the ARM TCG backend; > this fixes a compilation failure on ARM hosts with newer gcc. > > Signed-off-by: Peter May

Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-23 Thread Jan Kiszka
On 2011-09-23 11:31, Lai Jiangshan wrote: > On 09/22/2011 10:51 PM, Jan Kiszka wrote: >> On 2011-09-22 11:50, Lai Jiangshan wrote: >>> >>> From: KAMEZAWA Hiroyuki >>> Subject: [PATCH] Fix inject-nmi >>> >>> Now, inject-nmi sends NMI to all cpus...but this doesn't emulate >>> pc hardware 'NMI butto

Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-23 Thread Lai Jiangshan
On 09/22/2011 10:51 PM, Jan Kiszka wrote: > On 2011-09-22 11:50, Lai Jiangshan wrote: >> >> From: KAMEZAWA Hiroyuki >> Subject: [PATCH] Fix inject-nmi >> >> Now, inject-nmi sends NMI to all cpus...but this doesn't emulate >> pc hardware 'NMI button', which triggers LINT1. >> >> So, now, LINT1 mask

  1   2   >