Ping? Would be nice to get this committed since it's a compile failure fix...
-- PMM On 12 September 2011 11:03, Peter Maydell <peter.mayd...@linaro.org> wrote: > Remove the unused function tcg_out_addi() from the ARM TCG backend; > this fixes a compilation failure on ARM hosts with newer gcc. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > A previous patch from Richard Henderson for this compile failure: > http://patchwork.ozlabs.org/patch/110400/ > was rejected, so here's another go. This simply removes the unused function, > in line with the approach taken for ppc/ppc64 in commits 1a2eb162414 and > c24a9c6ef94. > > If this is accepted I can do the equivalent patches for tcg/ia64 and tcg/s390 > (although those don't cause compile failures because the unused function > happens to be marked 'inline'.) > > tcg/arm/tcg-target.c | 15 --------------- > 1 files changed, 0 insertions(+), 15 deletions(-) > > diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c > index 93eb0f1..ce4760d 100644 > --- a/tcg/arm/tcg-target.c > +++ b/tcg/arm/tcg-target.c > @@ -1820,21 +1820,6 @@ static inline void tcg_out_st(TCGContext *s, TCGType > type, int arg, > tcg_out_st32(s, COND_AL, arg, arg1, arg2); > } > > -static void tcg_out_addi(TCGContext *s, int reg, tcg_target_long val) > -{ > - if (val > 0) > - if (val < 0x100) > - tcg_out_dat_imm(s, COND_AL, ARITH_ADD, reg, reg, val); > - else > - tcg_abort(); > - else if (val < 0) { > - if (val > -0x100) > - tcg_out_dat_imm(s, COND_AL, ARITH_SUB, reg, reg, -val); > - else > - tcg_abort(); > - } > -} > - > static inline void tcg_out_mov(TCGContext *s, TCGType type, int ret, int arg) > { > tcg_out_dat_reg(s, COND_AL, ARITH_MOV, ret, 0, arg, SHIFT_IMM_LSL(0)); > -- > 1.7.1